Change in vdsm[master]: add verb for vdsm to tuneCpu params
Doron Fediuck has posted comments on this change. Change subject: add verb for vdsm to tuneCpu params .. Patch Set 3: Hi Royce, Thanks for a very interesting work. However, I'm afraid I'm missing a design, before we rush into the implementation. ie- why did you choose to implement capping via proportions? I'm not saying it's wrong, but I'm looking for the reasoning as well as interaction with other libvirt settings. Implementation wise, why did you choose tuneParams['vcpu_period'] = 100 ? Which problem does it solve? I believe we should add emulator_quota and period as well to make sure we can control non-vcpu threads as well. Please use http://wiki.ovirt.org/wiki/Sla/cpu-and-memory to share your thoughts, so we get the bigger picture. -- To view, visit http://gerrit.ovirt.org/7492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e02e09ef06ad6de45be75c3f2f913a3025750f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Zhu Bo bo...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Related to BZ#815359 - Improve log on qemu-convert error.
Yeela Kaplan has posted comments on this change. Change subject: Related to BZ#815359 - Improve log on qemu-convert error. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e9e139f3254953577cfebe048ea89a2ababf2a6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add simple VM creation functional test
Zhou Zheng Sheng has posted comments on this change. Change subject: add simple VM creation functional test .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/7396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Michal Skrivanek has posted comments on this change. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm: unsetPortMirroring just before hotunplug
Dan Kenigsberg has posted comments on this change. Change subject: libvirtvm: unsetPortMirroring just before hotunplug .. Patch Set 3: I would prefer that you didn't submit this Igor: must add symmetric setPortMirroring on hotplug! -- To view, visit http://gerrit.ovirt.org/7425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: refine unsetPortMirroring
Dan Kenigsberg has posted comments on this change. Change subject: tc: refine unsetPortMirroring .. Patch Set 5: I would prefer that you didn't submit this (3 inline comments) File vdsm/tc.py Line 55: Line 56: Line 57: def setPortMirroring(network, target): Line 58: qdisc_replace_ingress(network) Line 59: _addTarget(network, ':', target) it may be nicer to define QDISC_INGRESS = ':' Line 60: Line 61: qdisc_replace_prio(network) Line 62: devid = qdisc_get_devid(network) Line 63: _addTarget(network, devid, target) Line 56: Line 57: def setPortMirroring(network, target): Line 58: qdisc_replace_ingress(network) Line 59: _addTarget(network, ':', target) Line 60: Igor notes that we have a problem if Vdsm dies right here. We would then have a half-defined mirroring, that unsetPortMirroring would not be able remove. Line 61: qdisc_replace_prio(network) Line 62: devid = qdisc_get_devid(network) Line 63: _addTarget(network, devid, target) Line 64: Line 58: qdisc_replace_ingress(network) Line 59: _addTarget(network, ':', target) Line 60: Line 61: qdisc_replace_prio(network) Line 62: devid = qdisc_get_devid(network) devid is a wrong and misleading name. it is the qdisc_id of the first egress qdisc of the device. Line 63: _addTarget(network, devid, target) Line 64: Line 65: set_promisc(network, True) Line 66: -- To view, visit http://gerrit.ovirt.org/7299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change waitForMigrationDestinationPrepare function waiting.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Change waitForMigrationDestinationPrepare function waiting. .. Change waitForMigrationDestinationPrepare function waiting. The change is to avoid timeouts during migration of several VMs at once. The new implementation doesn't start the timer until the VM starts it creation (e.g. acquired the _ongoingCreations lock). Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Signed-off-by: Gal Hammer gham...@redhat.com --- M vdsm/libvirtvm.py M vdsm/vm.py 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Gal Hammer: Verified Dan Kenigsberg: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I017980ee6da676af654b0dd225928830818ebbd3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gal Hammer gham...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make vdsm/storage/fileSD.py pep8 clean
Dan Kenigsberg has posted comments on this change. Change subject: Make vdsm/storage/fileSD.py pep8 clean .. Patch Set 2: Looks good to me, approved Thanks! -- To view, visit http://gerrit.ovirt.org/7520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79e4e8bf82213c31269a6fe1fefddf619a34b82f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make vdsm/storage/fileSD.py pep8 clean
Dan Kenigsberg has submitted this change and it was merged. Change subject: Make vdsm/storage/fileSD.py pep8 clean .. Make vdsm/storage/fileSD.py pep8 clean Change-Id: I79e4e8bf82213c31269a6fe1fefddf619a34b82f Signed-off-by: Xu He Jie x...@linux.vnet.ibm.com --- M Makefile.am M vdsm/storage/fileSD.py 2 files changed, 79 insertions(+), 48 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79e4e8bf82213c31269a6fe1fefddf619a34b82f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Libvirt service engagement workaround
Moti Asayag has posted comments on this change. Change subject: Libvirt service engagement workaround .. Patch Set 4: (1 inline comment) File vdsm/vdsmd.init.in Line 459: Line 460: startout=`/sbin/initctl start libvirtd 21` Line 461: if [[ $? -eq 0 || $startout =~ .*already\ running.* ]]; Line 462: then Line 463: await_libvirt_start_workaround you can review the history of this patch-set to see how it evolved to this point. The bottom line was to improve the latency. Line 464: return 0 Line 465: else Line 466: echo $startout 2 Line 467: return 1 -- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#846323 - Search PV's belonging to the VG in removeVG.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#846323 - Search PV's belonging to the VG in removeVG. .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/711/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: refine unsetPortMirroring
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: refine unsetPortMirroring .. Patch Set 5: No score (4 inline comments) File vdsm/tc.py Line 34: Exception.__init__(self, self.errCode, self.message, self.command) Line 35: Line 36: Line 37: def _addTarget(network, parent, target): Line 38: fs = list(filters(network, parent)) Ok, you know better the author of the filters ;-). Line 39: if fs: Line 40: filt = fs[0] Line 41: else: Line 42: filt = Filter(prio=None, handle=None, actions=[]) Line 55: Line 56: Line 57: def setPortMirroring(network, target): Line 58: qdisc_replace_ingress(network) Line 59: _addTarget(network, ':', target) Definitely. It had been about 6 years since I last played with traffic control commands and the magic number left me initially scratching my head. Line 60: Line 61: qdisc_replace_prio(network) Line 62: devid = qdisc_get_devid(network) Line 63: _addTarget(network, devid, target) Line 56: Line 57: def setPortMirroring(network, target): Line 58: qdisc_replace_ingress(network) Line 59: _addTarget(network, ':', target) Line 60: Some proposal? Doing it in some sort of transaction that rolls back in case of error/death? Line 61: qdisc_replace_prio(network) Line 62: devid = qdisc_get_devid(network) Line 63: _addTarget(network, devid, target) Line 64: Line 58: qdisc_replace_ingress(network) Line 59: _addTarget(network, ':', target) Line 60: Line 61: qdisc_replace_prio(network) Line 62: devid = qdisc_get_devid(network) Yes. I understood what it meant, but the new name is indeed more suitable. But aren't we normally using camelCase? qdiscId? Line 63: _addTarget(network, devid, target) Line 64: Line 65: set_promisc(network, True) Line 66: -- To view, visit http://gerrit.ovirt.org/7299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Remove the domain weakref cache and parallelize _findD...
Federico Simoncelli has posted comments on this change.
Change subject: [WIP] Remove the domain weakref cache and parallelize
_findDomain
..
Patch Set 1: (1 inline comment)
File vdsm/storage/sdc.py
Line 65: self.__domainCache = {}
Line 66: self.__inProgress = set()
Line 67: self.storage_repo = storage_repo
Line 68:
Line 69: def invalidateStorage(self):
I agree on moving lvm.invalidateCache down to refresh() but I don't think that
hsm should call refresh() at all (it's going to clean all the domain cache and
we'll start issuing _findDomain for each new sd produce).
I think that we should preserve storageStale in some fashion and hsm should
call that.
Line 70: lvm.invalidateCache()
Line 71:
Line 72: @misc.samplingmethod
Line 73: def refreshStorage(self):
--
To view, visit http://gerrit.ovirt.org/7511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a04babcfbb5620e9e703fe94a1ae681ac300bfb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Libvirt service engagement workaround
Yaniv Bronhaim has posted comments on this change. Change subject: Libvirt service engagement workaround .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add verb for vdsm to tuneCpu params
oVirt Jenkins CI Server has posted comments on this change. Change subject: add verb for vdsm to tuneCpu params .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/712/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e02e09ef06ad6de45be75c3f2f913a3025750f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Zhu Bo bo...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tcTests: test port-mirroring while another device is watchin...
Antoni Segura Puimedon has posted comments on this change. Change subject: tcTests: test port-mirroring while another device is watching .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm: allow acpi again
Dan Kenigsberg has uploaded a new change for review.
Change subject: libvirtvm: allow acpi again
..
libvirtvm: allow acpi again
Commit c3e2272f has mistakenly changed
features
acpi/
/features
into
features
acpi
/features
which caused VMs to start up silently with no acpi support. This patch
reverts the offending part of the above commit.
Bug initially reported by Itzik Brown.
Change-Id: I591c40678f030f1bcd4cb7cb42c21907420f7cf1
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/7533/1
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index a975206..c29a1a9 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -726,7 +726,8 @@
features/
if utils.tobool(self.conf.get('acpiEnable', 'true')):
-self.appendChildWithText('features', 'acpi')
+self.dom.appendChild(self.doc.createElement('features')) \
+ .appendChild(self.doc.createElement('acpi'))
def appendCpu(self):
--
To view, visit http://gerrit.ovirt.org/7533
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I591c40678f030f1bcd4cb7cb42c21907420f7cf1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Remove the domain weakref cache and parallelize _findD...
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Remove the domain weakref cache and parallelize _findDomain .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/713/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a04babcfbb5620e9e703fe94a1ae681ac300bfb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tcTests: test port-mirroring while another device is watchin...
Antoni Segura Puimedon has posted comments on this change. Change subject: tcTests: test port-mirroring while another device is watching .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: refine unsetPortMirroring
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: refine unsetPortMirroring .. Patch Set 6: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/714/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: refine unsetPortMirroring
Antoni Segura Puimedon has posted comments on this change.
Change subject: tc: refine unsetPortMirroring
..
Patch Set 6: (1 inline comment)
File vdsm/tc.py
Line 120:'parent', 'root', 'prio']
Line 121: _process_request(command)
Line 122:
Line 123: def qdisc_get_devid(dev):
Line 124: Return qdisc_id of the first qdisc associated with dev
Would it be possible to change the method name instead, or is it already fixed
in the API?
Line 125:
Line 126: command = [EXT_TC, 'qdisc', 'show', 'dev', dev]
Line 127: out = _process_request(command)
Line 128: return out.split(' ')[2]
--
To view, visit http://gerrit.ovirt.org/7299
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added an option to create a watchdog device.
ShaoHe Feng has uploaded a new change for review.
Change subject: Added an option to create a watchdog device.
..
Added an option to create a watchdog device.
A support for a watchdog device was added to the devices
configuration.
Also add the watchdog event callback.
model of watchdog:
'i6300esb' default model, emulating a PCI Intel 6300ESB
'ib700'emulating an ISA iBase IB700
action of watchdog:
'reset' default, forcefully reset the guest
'shutdown' gracefully shutdown the guest (not recommended)
'poweroff' forcefully power off the guest
'pause' pause the guest
'none' do nothing
'dump' automatically dump the guest
The watchdog device can used to detect guest crash, and if choose
'dump' action, the libvirt will dump the guest automatically.
The directory to save dump files can be configured by auto_dump_path
in file /etc/libvirt/qemu.conf.
The watchdog device requires an additional driver and management
daemon in the guest. Just enabling the watchdog in the vdsm
devices configuration does not do anything useful on its own.
Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Signed-off-by: ShaoHe Feng shao...@linux.vnet.ibm.com
---
M vdsm/libvirtconnection.py
M vdsm/libvirtev.py
M vdsm/libvirtvm.py
M vdsm/vm.py
4 files changed, 102 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/7535/1
diff --git a/vdsm/libvirtconnection.py b/vdsm/libvirtconnection.py
index e525996..25e2494 100644
--- a/vdsm/libvirtconnection.py
+++ b/vdsm/libvirtconnection.py
@@ -63,6 +63,12 @@
elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_BLOCK_JOB:
path, type, status = args[:-1]
v._onBlockJobEvent(path, type, status)
+elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_WATCHDOG:
+wdargs = args[:-1]
+action = libvirtev.watchdogActionToString(wdargs[0])
+cif.log.debug(watchdog event: Domain %s(%s). Action: %s,
+ dom.name(), dom.ID(), action)
+v._onWatchdogEvent(dom.name(), dom.ID(), action)
else:
v.log.warning('unknown eventid %s args %s', eventid, args)
except:
@@ -118,7 +124,8 @@
libvirt.VIR_DOMAIN_EVENT_ID_RTC_CHANGE,
libvirt.VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON,
libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS,
- libvirt.VIR_DOMAIN_EVENT_ID_BLOCK_JOB):
+ libvirt.VIR_DOMAIN_EVENT_ID_BLOCK_JOB,
+ libvirt.VIR_DOMAIN_EVENT_ID_WATCHDOG):
conn.domainEventRegisterAny(None, ev,
__eventCallback, (cif, ev))
for name in dir(libvirt.virConnect):
diff --git a/vdsm/libvirtev.py b/vdsm/libvirtev.py
index 92a7a0e..b12b916 100644
--- a/vdsm/libvirtev.py
+++ b/vdsm/libvirtev.py
@@ -444,6 +444,16 @@
return eventStrings[event]
+def watchdogActionToString(action):
+actionStrings = (No action, watchdog ignored,
+ Guest CPUs are paused,
+ Guest CPUs are reset,
+ Guest is forcably powered off,
+ Guest is requested to gracefully shutdown,
+ No action, a debug message logged)
+return actionStrings[action]
+
+
def myDomainEventCallback1(conn, dom, event, detail, opaque):
print (myDomainEventCallback1 EVENT: Domain %s(%s) %s %d %
(dom.name(), dom.ID(), eventToString(event), detail))
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index e95e94b..cc75d78 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1188,6 +1188,20 @@
m.setAttribute('model', self.specParams['model'])
return m
+class WatchdogDevice(LibvirtVmDevice):
+def getXML(self):
+
+Create domxml for a watchdog device.
+
+watchdog model='i6300esb' action='dump'
+ address type='pci' domain='0x' bus='0x00' slot='0x07'
function='0x0'/
+/watchdog
+
+m = self.createXmlElem(self.type, None, ['address'])
+m.setAttribute('model', self.specParams['model'])
+if 'action' in self.specParams:
+m.setAttribute('action', self.specParams['action'])
+return m
class RedirDevice(LibvirtVmDevice):
def getXML(self):
@@ -1331,6 +1345,7 @@
self._getUnderlyingVideoDeviceInfo()
self._getUnderlyingControllerDeviceInfo()
self._getUnderlyingBalloonDeviceInfo()
+self._getUnderlyingWatchdogDeviceInfo()
# Obtain info of all unknown devices. Must be last!
self._getUnderlyingUnknownDeviceInfo()
@@ -1420,6 +1435,7 @@
vm.CONTROLLER_DEVICES: ControllerDevice,
vm.GENERAL_DEVICES: GeneralDevice,
vm.BALLOON_DEVICES:
Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/717/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm: allow acpi again
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtvm: allow acpi again .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/718/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I591c40678f030f1bcd4cb7cb42c21907420f7cf1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itzik Brown itz...@mellanox.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add simple VM creation functional test
ShaoHe Feng has posted comments on this change. Change subject: add simple VM creation functional test .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/7396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: refine unsetPortMirroring
Dan Kenigsberg has posted comments on this change.
Change subject: tc: refine unsetPortMirroring
..
Patch Set 6: (1 inline comment)
File vdsm/tc.py
Line 120:'parent', 'root', 'prio']
Line 121: _process_request(command)
Line 122:
Line 123: def qdisc_get_devid(dev):
Line 124: Return qdisc_id of the first qdisc associated with dev
how about
qdisc_get_first_per_dev()
? That's rather lame. Do you have a better suggestion?
Line 125:
Line 126: command = [EXT_TC, 'qdisc', 'show', 'dev', dev]
Line 127: out = _process_request(command)
Line 128: return out.split(' ')[2]
--
To view, visit http://gerrit.ovirt.org/7299
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tcTests: test port-mirroring while another device is watchin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: tcTests: test port-mirroring while another device is watching .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/720/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06f654be269ccbbfc90dd29e30239eb010db3df8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Bump libvirt required version for RHEL6
Federico Simoncelli has uploaded a new change for review. Change subject: Bump libvirt required version for RHEL6 .. Bump libvirt required version for RHEL6 The version bump is required to avoid the libvirt error Shareable leases are not supported when starting a VM (rhbz838819). Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/7537/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index ce73f6e..0d1b195 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -54,7 +54,7 @@ # Update the qemu-kvm requires when block_stream will be included Requires: qemu-kvm = 2:0.12.1.2-2.227 Requires: qemu-img = 2:0.12.1.2-2.227 -Requires: libvirt = 0.9.10-20 +Requires: libvirt = 0.9.10-21.el6_3.4 Requires: libvirt-python, libvirt-lock-sanlock Requires: iscsi-initiator-utils = 6.2.0.872-15 Requires: device-mapper-multipath = 0.4.9-52 -- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added an option to create a watchdog device.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added an option to create a watchdog device. .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/722/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move load_needed_modules to vdsm-tool
Dan Kenigsberg has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 3: I would prefer that you didn't submit this
(5 inline comments)
File vdsm-tool/load_needed_modules.py.in
Line 29:
Line 30:
Line 31: def _exec_command(argv):
Line 32: subprocess.Popen(argv, stdout=subprocess.PIPE,
Line 33: stderr=subprocess.PIPE).communicate()
ignoring errors and returning None is not a good practice.
Line 34:
Line 35:
Line 36: def _is_bond_dev_available(bond):
Line 37: if os.path.exists(DEVS):
Line 46: def load_needed_modules():
Line 47:
Line 48: Load needed modules
Line 49:
Line 50: _exec_command([EX_MODPROBE, 'tun'])
this begs for a 'for' loop
Line 51: _exec_command([EX_MODPROBE, 'bonding'])
Line 52:
Line 53: for bond in BOND:
Line 54: if not _is_bond_dev_available(bond):
Line 49:
Line 50: _exec_command([EX_MODPROBE, 'tun'])
Line 51: _exec_command([EX_MODPROBE, 'bonding'])
Line 52:
Line 53: for bond in BOND:
this is an ugly hack for backward compatibility. please keep the comment saying
so. Actually, moving to a separate function is even better.
Line 54: if not _is_bond_dev_available(bond):
Line 55: with open(DEVS, 'w') as f:
Line 56: f.write('+%s\n' % bond)
Line 57:
Line 50: _exec_command([EX_MODPROBE, 'tun'])
Line 51: _exec_command([EX_MODPROBE, 'bonding'])
Line 52:
Line 53: for bond in BOND:
Line 54: if not _is_bond_dev_available(bond):
btw, this function is currently written in a very bashy way. let us use the
benefits of Python: read all available bonds as a set, compare to the set of
legacy bonds, and create what's needed.
Line 55: with open(DEVS, 'w') as f:
Line 56: f.write('+%s\n' % bond)
Line 57:
File vdsm-tool/Makefile.am
Line 28: dist_vdsmtool_DATA = \
Line 29:__init__.py \
Line 30:passwd.py \
Line 31:validate_ovirt_certs.py \
Line 32:load_needed_modules.py
please end with
$(NULL)
and keep sorted.
--
To view, visit http://gerrit.ovirt.org/7487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Bump libvirt required version for RHEL6
Dan Kenigsberg has posted comments on this change. Change subject: Bump libvirt required version for RHEL6 .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Commit Message Line 3: AuthorDate: 2012-08-28 09:25:19 -0400 Line 4: Commit: Federico Simoncelli fsimo...@redhat.com Line 5: CommitDate: 2012-08-28 09:38:39 -0400 Line 6: Line 7: Bump libvirt required version for RHEL6 Let's avoid the RH trademark Line 8: Line 9: The version bump is required to avoid the libvirt error Shareable Line 10: leases are not supported when starting a VM (rhbz838819). Line 11: Line 6: Line 7: Bump libvirt required version for RHEL6 Line 8: Line 9: The version bump is required to avoid the libvirt error Shareable Line 10: leases are not supported when starting a VM (rhbz838819). let's conform to Bug-Id: url-of-bug Line 11: Line 12: Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 -- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: refine unsetPortMirroring
Antoni Segura Puimedon has posted comments on this change.
Change subject: tc: refine unsetPortMirroring
..
Patch Set 6: (1 inline comment)
File vdsm/tc.py
Line 120:'parent', 'root', 'prio']
Line 121: _process_request(command)
Line 122:
Line 123: def qdisc_get_devid(dev):
Line 124: Return qdisc_id of the first qdisc associated with dev
The fact that it is the first makes a short and nice-sounding name difficult. I
guess that if it would return all the qdisc ids and then the caller would pick
just the first would make it easier (but it would be cheating on your question).
What I found weird is the grammatical inversion of direct object and verb,
qdisc_get_devid suggests to me that what we get as a return is a devid, not a
qdisc_id. Maybe get_qdisc_of_devid (the 'of' sounds lame, I know, it's what we
get by not having object (OO) or dictionary(FP) representations of the network
that would allow for nicer queries).
Line 125:
Line 126: command = [EXT_TC, 'qdisc', 'show', 'dev', dev]
Line 127: out = _process_request(command)
Line 128: return out.split(' ')[2]
--
To view, visit http://gerrit.ovirt.org/7299
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tc: add to PEP8_WHITELIST
Antoni Segura Puimedon has posted comments on this change. Change subject: tc: add to PEP8_WHITELIST .. Patch Set 4: Looks good to me, but someone else must approve This rebase makes it easier to test. -- To view, visit http://gerrit.ovirt.org/7426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3b1d8de08ea8fac5cd3debb53f22d7a7a8ad87 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Bump libvirt required version for RHEL6
oVirt Jenkins CI Server has posted comments on this change. Change subject: Bump libvirt required version for RHEL6 .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/723/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added glusterVolumeProfileStart verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added glusterVolumeProfileStart verb .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/724/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] vdsm API and libvdsm
Adam Litke has abandoned this change. Change subject: [WIP] vdsm API and libvdsm .. Patch Set 2: Abandoned -- To view, visit http://gerrit.ovirt.org/6863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7c7427ea3f757135c9919fd65603495878fe3ae6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Libvirt service engagement workaround
Dan Kenigsberg has posted comments on this change. Change subject: Libvirt service engagement workaround .. Patch Set 4: Verified Copying yesterday's score. -- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a basic xmlrpc functional test
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a basic xmlrpc functional test .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/736/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtvm: allow acpi again
Zhou Zheng Sheng has posted comments on this change. Change subject: libvirtvm: allow acpi again .. Patch Set 1: Looks good to me, but someone else must approve This bug is introduced in my refactor patch. I open the gerrit review page of that patch, and find that in the test result, there is no ACPI in the generated XML. This is my fault, I should check the generated XML is exactly the same as the one generated by the old code. -- To view, visit http://gerrit.ovirt.org/7533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I591c40678f030f1bcd4cb7cb42c21907420f7cf1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itzik Brown itz...@mellanox.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move load_needed_modules to vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move load_needed_modules to vdsm-tool .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/738/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Correct vdsClient's help for the verb getVmsInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: Correct vdsClient's help for the verb getVmsInfo .. Patch Set 2: Build Failed http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/740/ : ABORTED -- To view, visit http://gerrit.ovirt.org/7560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I152f28dea29f6ac6bb61c0597dbd3b596646c569 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhu Bo bo...@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Zhu Bo bo...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
