Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 5:
The following will not restarting libvirt while it should for backward
compatibility:
reconfigure_libvirt() {
if [ "$1" = "force" ]; then
"$VDSM_TOOL" libvirt-configure --force
else
"$VDSM_TOOL" libvirt-configure
fi
}
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Yaniv Bronhaim has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 5: No, we just add comment to do it manually. sysv script calls libvirt_reconfigure.sh , it doesn't perform the restart. maybe I don't understand about what reset you are talking about -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service.py: _runAlts() remove ServiceNotExistError
Douglas Schilling Landgraf has abandoned this change. Change subject: service.py: _runAlts() remove ServiceNotExistError .. Abandoned Provide a different approach. -- To view, visit http://gerrit.ovirt.org/19165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0d8dc3c50bee73e492127d6aedda3b125c8add0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service.py: _runAlts() remove ServiceNotExistError
Zhou Zheng Sheng has posted comments on this change. Change subject: service.py: _runAlts() remove ServiceNotExistError .. Patch Set 1: (1 comment) File lib/vdsm/tool/service.py Line 357 Line 358 Line 359 Line 360 Line 361 Sorry, the first comment should be applied to service_stop() function. -- To view, visit http://gerrit.ovirt.org/19165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d8dc3c50bee73e492127d6aedda3b125c8add0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service.py: _runAlts() remove ServiceNotExistError
Zhou Zheng Sheng has posted comments on this change. Change subject: service.py: _runAlts() remove ServiceNotExistError .. Patch Set 1: (1 comment) File lib/vdsm/tool/service.py Line 357 Line 358 Line 359 Line 360 Line 361 I just think of the "service-is-managed". We can avoid starting a non-existing service by vdsm-tool service-is-managed ServiceName && vdsm-tool service-start ServiceName -- To view, visit http://gerrit.ovirt.org/19165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d8dc3c50bee73e492127d6aedda3b125c8add0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service.py: _runAlts() remove ServiceNotExistError
Zhou Zheng Sheng has posted comments on this change.
Change subject: service.py: _runAlts() remove ServiceNotExistError
..
Patch Set 1:
(1 comment)
File lib/vdsm/tool/service.py
Line 357
Line 358
Line 359
Line 360
Line 361
vdsm/gluster/service.py relies on this error to decide if the service is
installed.
What do you think of this proposal?
@expose("service-start")
def service_start(srvName, raiseError=True):
"""
Start a system service
"""
try:
r = _runAlts(_srvStartAlts, srvName)
return r
except Exception as e:
if raiseError:
raise
else:
print str(e)
return 1
Then we call it by
vdsm-tool service-start ServiceName False
--
To view, visit http://gerrit.ovirt.org/19165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d8dc3c50bee73e492127d6aedda3b125c8add0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service.py: _runAlts() remove ServiceNotExistError
oVirt Jenkins CI Server has posted comments on this change. Change subject: service.py: _runAlts() remove ServiceNotExistError .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4381/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3484/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4300/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d8dc3c50bee73e492127d6aedda3b125c8add0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service.py: _runAlts() remove ServiceNotExistError
Douglas Schilling Landgraf has posted comments on this change. Change subject: service.py: _runAlts() remove ServiceNotExistError .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d8dc3c50bee73e492127d6aedda3b125c8add0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service.py: _runAlts() remove ServiceNotExistError
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: service.py: _runAlts() remove ServiceNotExistError
..
service.py: _runAlts() remove ServiceNotExistError
Do not call raise() if service does not exist
Change-Id: I0d8dc3c50bee73e492127d6aedda3b125c8add0e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006842
Signed-off-by: Douglas Schilling Landgraf
---
M lib/vdsm/tool/service.py
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/19165/1
diff --git a/lib/vdsm/tool/service.py b/lib/vdsm/tool/service.py
index 6122cb0..cd4aaf5 100644
--- a/lib/vdsm/tool/service.py
+++ b/lib/vdsm/tool/service.py
@@ -348,9 +348,6 @@
else:
raise ServiceOperationError(
"%s failed" % alt.func_name, out, err)
-raise ServiceNotExistError(
-'Tried all alternatives but failed:\n%s' %
-('\n'.join(str(e) for errs in errors.values() for e in errs)))
@expose("service-start")
--
To view, visit http://gerrit.ovirt.org/19165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d8dc3c50bee73e492127d6aedda3b125c8add0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: handle missing sanlock pid file
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: handle missing sanlock pid file .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I711d9b413415ca9372520e6bb25cf6d39ff571a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: handle missing sanlock pid file
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: handle missing sanlock pid file .. vdsm-tool: handle missing sanlock pid file Change-Id: I711d9b413415ca9372520e6bb25cf6d39ff571a3 Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/19112 Reviewed-by: Dan Kenigsberg --- M lib/vdsm/tool/sanlock.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I711d9b413415ca9372520e6bb25cf6d39ff571a3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/3] - Save running config
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [1/3] - Save running config .. Patch Set 22: unifiedpersistence.py begs for a unit test that proves that whatever is persisted is recoverable. -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 8: Code-Review-1 (1 comment) File lib/vdsm/unifiedpersistence.py Line 28: import utils Line 29: Line 30: Line 31: CONF_RUN_DIR = constants.P_VDSM_RUN + 'netconf/' Line 32: CONF_PERSIST_DIR = constants.P_VDSM_LIB + 'persistence/netconf/' everything under /var/lib is persisted. I think that /var/lib/vdsm/netconf is enough. Line 33: Line 34: Line 35: class Config(object): Line 36: def __init__(self, savePath): -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/3] - Save running config
Dan Kenigsberg has posted comments on this change.
Change subject: Unified network persistence [1/3] - Save running config
..
Patch Set 22: Code-Review-1
(6 comments)
File lib/vdsm/unifiedpersistence.py
Line 14: # You should have received a copy of the GNU General Public License
Line 15: # along with this program; if not, write to the Free Software
Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
I'm still unhappy with the module name. It sits on the top of the vdsm package,
and may make people think that it is some kind of a vdsm-wide facility, while
it is very specific and netconf-related. How about "netconfpersistence" instead?
Line 19: #
Line 20:
Line 21: import errno
Line 22: import json
Line 39:
Line 40: def __eq__(self, other):
Line 41: return self.networks == other.networks and self.bonds ==
other.bonds
Line 42:
Line 43: def __repr(self):
that's a funny-looking function.
Line 44: return '%s(%s, %s)' % (self.__class__.__name__, self.networks,
Line 45:self.bonds)
Line 46:
Line 47: def _networkPath(self, network):
Line 70: fullPath = path + fileName
Line 71: networkEntities[fileName] =
self._getConfigDict(fullPath)
Line 72: except OSError as ose:
Line 73: if ose.errno == errno.ENOENT:
Line 74: logging.debug('Unified persistence: No existent config
set.')
English: non-exsiting config set
Line 75: else:
Line 76: raise
Line 77:
Line 78: return networkEntities
Line 78: return networkEntities
Line 79:
Line 80: def _setConfig(self, config, path):
Line 81: dirPath = os.path.dirname(path)
Line 82: if not os.path.exists(dirPath):
Why do we need to create the directories during runtime? If we have to do that,
let's do it in a thread-safe manner
try:
os.makedirs(dirPath)
except OSError as e:
if e.errono != ENOENT:
raise
Line 83: os.makedirs(dirPath)
Line 84: with open(path, 'w') as configurationFile:
Line 85: json.dump(config, configurationFile)
Line 86:
Line 85: json.dump(config, configurationFile)
Line 86:
Line 87: def _removeConfig(self, path):
Line 88: try:
Line 89: os.unlink(path)
that's pretty much utils.rmFile().
Line 90: except OSError as ose:
Line 91: if ose.errno == errno.ENOENT:
Line 92: logging.debug('Unified persistence: Network entity at
%s not '
Line 93: 'found for removal' % path)
Line 100: if value is not None and key not in
Line 101: ('configurator', '_netinfo', 'force',
Line 102:'implicitBonding'))
Line 103: self.networks[network] = cleanAttrs
Line 104: logging.info('Unified persistence: Adding network %s(%s)' %
I do not understand why the "Unified persistence: " prefix is useful here. we
log the module name, anyway.
Line 105: (network, cleanAttrs))
Line 106:
Line 107: def removeNetwork(self, network):
Line 108: try:
--
To view, visit http://gerrit.ovirt.org/16699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Petr Šebek
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: make libvirtd env file path and qemu process user...
Dan Kenigsberg has posted comments on this change. Change subject: Packaging: make libvirtd env file path and qemu process user group configurable .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11830b95257655bdc1fe2ba54861655fdcdb861e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: make libvirtd env file path and qemu process user...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Packaging: make libvirtd env file path and qemu process user group configurable .. Packaging: make libvirtd env file path and qemu process user group configurable In Ubuntu, qemu user is libvirt-qemu, qemu group is kvm. libvirt daemon environment file is /etc/default/libvirt-bin. This patch make these configurable by adding the following options. --with-libvirt-service-default=/etc/default/libvirt-bin --with-qemu-user=libvirt-qemu --with-qemu-group=kvm The default value are based on RH family so Fedora and RHEL can safely ignore these options. Change-Id: I11830b95257655bdc1fe2ba54861655fdcdb861e Signed-off-by: Zhou Zheng Sheng Reviewed-on: http://gerrit.ovirt.org/19007 Reviewed-by: Alon Bar-Lev Reviewed-by: Dan Kenigsberg --- M configure.ac M lib/vdsm/tool/libvirt_configure.sh.in 2 files changed, 35 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified -- To view, visit http://gerrit.ovirt.org/19007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11830b95257655bdc1fe2ba54861655fdcdb861e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 10:
(3 comments)
File init/daemonAdapter
Line 57: self._args = parser.parse_args(sys.argv[1:])
Line 58:
Line 59: def _log(self, msg):
Line 60: if self._args and self._args.syslog:
Line 61: syslog.syslog(msg)
Please check what happens if there is \n in msg, you probably need to loop.
Line 62: else:
Line 63: sys.stderr.write(msg)
Line 64:
Line 65: def execute(self):
Line 59: def _log(self, msg):
Line 60: if self._args and self._args.syslog:
Line 61: syslog.syslog(msg)
Line 62: else:
Line 63: sys.stderr.write(msg)
"%s\n" msg?
Line 64:
Line 65: def execute(self):
Line 66: try:
Line 67: os.nice(config.getint('vars', 'vdsm_nice'))
Line 102: os.execve(cmd[0], cmd, env)
Line 103: return 0
Line 104:
Line 105: except Exception as e:
Line 106: self._log("Error in daemonAdapater: %s" % e)
don't you want to print stack trace?
Line 107: return 1
Line 108:
Line 109:
Line 110: if __name__ == '__main__':
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: Fix str/unicode concatenation issue.
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsClient: Fix str/unicode concatenation issue. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4380/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3483/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4299/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44dce25bb167da8ade579b2d67eb34a0e05f491b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: small refactor for _normalizeVdsmImg
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: small refactor for _normalizeVdsmImg .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4379/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3482/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4298/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie68292eee4b82fbe8527e3960739979cfe117dfa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 5: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4378/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4297/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: small refactor for _normalizeVdsmImg
Federico Simoncelli has uploaded a new change for review.
Change subject: vm: small refactor for _normalizeVdsmImg
..
vm: small refactor for _normalizeVdsmImg
Change-Id: Ie68292eee4b82fbe8527e3960739979cfe117dfa
Signed-off-by: Federico Simoncelli
---
M vdsm/vm.py
1 file changed, 18 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/19157/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 92d274e..2605f24 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1779,25 +1779,26 @@
break
return str(idx)
-def _normalizeVdsmImg(self, drv):
-drv['reqsize'] = drv.get('reqsize', '0') # Backward compatible
-if 'device' not in drv:
-drv['device'] = 'disk'
+def _normalizeVdsmImg(self, drive):
+drive['device'] = drive.get('device', 'disk') # Disk by default
+drive['reqsize'] = drive.get('reqsize', '0') # Backward compatible
-if drv['device'] == 'disk':
-res = self.cif.irs.getVolumeSize(drv['domainID'], drv['poolID'],
- drv['imageID'], drv['volumeID'])
-try:
-drv['truesize'] = res['truesize']
-drv['apparentsize'] = res['apparentsize']
-except KeyError:
-self.log.error("Unable to get volume size for %s",
- drv['volumeID'], exc_info=True)
-raise RuntimeError("Volume %s is corrupted or missing" %
- drv['volumeID'])
+if drive['device'] == 'disk':
+volInfo = self.cif.irs.getVolumeInfo(
+drive['domainID'], drive['poolID'], drive['imageID'],
+drive['volumeID'])
+
+if volInfo.get('status', {}).get('code', -1):
+self.log.error(
+"Unable to get volume info for %s", drive['volumeID'])
+raise RuntimeError(
+"Volume %s is corrupted or missing" % drive['volumeID'])
+
+drive['truesize'] = volInfo['info']['truesize']
+drive['apparentsize'] = volInfo['info']['apparentsize']
else:
-drv['truesize'] = 0
-drv['apparentsize'] = 0
+drive['truesize'] = 0
+drive['apparentsize'] = 0
@classmethod
def _normalizeDriveSharedAttribute(self, drive):
--
To view, visit http://gerrit.ovirt.org/19157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie68292eee4b82fbe8527e3960739979cfe117dfa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4374/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3477/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4293/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4373/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3476/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4292/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 5: > what change in sysv? we use vsdm-tool for reconfigure.. and shouldn't it restart? -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 13:
(1 comment)
sorry... not committed... :)
File init/sysvinit/vdsmd.init.in
Line 168: case "$1" in
Line 169: start)
Line 170: {
Line 171: if flock -n 9; then
Line 172: start
I thought of doing something like:
if not flock ...; then
lock message
elif start; then
success message
else
failure message
fi
removing the messages from start... same for stop.
Line 173: else
Line 174: log_failure_msg "another ${prog} operation is
running..."
Line 175:false
Line 176: fi
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Yaniv Bronhaim has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 14: Verified+1 invisible one? so we're good to go -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Yaniv Bronhaim has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 5: what change in sysv? we use vsdm-tool for reconfigure.. -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4377/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4296/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 4: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4376/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3479/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4295/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 4:
(1 comment)
Again, I do not understand why we do not have a change in sysv init.
File lib/vdsm/tool/libvirt_configure.py
Line 74: sys.stdout.write("To start working after reconfigure run:\n"
Line 75: "vdsm-tool reconfigure-restart\n"
Line 76: "This will manage stop and start to the
services: \n"
Line 77: "libvirtd, supervdsmd\n")
Line 78: return 0
help usually returns 1...
Line 79:
Line 80: service.service_stop("supervdsmd")
Line 81: service.service_stop("libvirtd")
Line 82: service.service_start("libvirtd")
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 14: Code-Review+1 Minor style commets. -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4375/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3478/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4294/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 3:
(1 comment)
File lib/vdsm/tool/libvirt_configure.sh.in
Line 282: ovirt_store_config "${lconf}" "${qconf}" "${ldconf}"
"${llogr}"
Line 283: fi
Line 284:
Line 285: echo "Reconfigure libvirt is done."
Line 286: /bin/vdsm-tool reconfigure-restart -h
why not? kind of an help print.. useful
Line 287:
Line 288:
Line 289: #
Line 290: # finished reconfiguration, do not trigger
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Yaniv Bronhaim has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 13: (1 comment) File init/sysvinit/vdsmd.init.in Line 155: killproc -p "$PIDFILE" -d 2 Line 156: RETVAL=$? Line 157: if [ "$RETVAL" = 0 ]; then Line 158: "@RM_PATH@" -f "$LOCK_FILE" > /dev/null 2>&1 Line 159: log_success_msg $"$prog stop" what messages? explain. but I'll do it separately anyway. not in this page. Line 160: else Line 161: log_failure_msg $"$prog stop" Line 162: fi Line 163: fi -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: Fix str/unicode concatenation issue.
Amador Pahim has posted comments on this change.
Change subject: vdsClient: Fix str/unicode concatenation issue.
..
Patch Set 2:
(2 comments)
Commit Message
Line 36: not in range(128)
Line 37:
Line 38: This patch is removing the str() conversion for
infos['vmlist'][entry]. The result
Line 39: is 'messages' variable as type unicode when infos['vmlist'][entry] is
unicode.
Line 40: Also, to avoid stdout redir encode error, the messages print is
encoded as UTF-8.
When infos['vmlist'][entry] is utf8, message is uft8 too. print will use
sys.stdout.encoding to represent characters. When redirecting stdout to a file,
sys.stdout.encoding is None, which means print will use
sys.getdefaultencoding(), 'acsii' in my case. message.encoding('utf-8') will
force to use utf-8 regardless the sys.stdout.encoding and
sys.getdefaultencoding() to assure proper representation of characters in any
case. The corner case is console not supporting utf-8 at all. Is this case, an
error is expected. I cant see a proper way to represent uft-8 characters in
ascii, for example. We can half-hack around it to use encoding('utf-8') only
when message is unicode
if isinstance(message, unicode):
print message.encode('utf-8')
else:
print message
This way the error will happen only when terminal does not support utf8 AND
there are utf8 characters to be represented. What do you think?
Line 41:
Line 42: Change-Id: I44dce25bb167da8ade579b2d67eb34a0e05f491b
File client/vdsClient.py
Line 1469: message += '\n' + ''
+ '\n'
Line 1470: message += entry + '=' + infos['vmlist'][entry]
Line 1471: if not message:
Line 1472: message = 'No VMs found.'
Line 1473: print message.encode("utf-8")
I don't think it's a good choice...
* If sys.stdout.encoding is not utf-8, an error may occur.
* Redirecting stdout to a file, sys.stdout.encoding is None.
Line 1474:
Line 1475: return 0, ''
Line 1476:
Line 1477: def do_getVmsList(self, args):
--
To view, visit http://gerrit.ovirt.org/19032
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44dce25bb167da8ade579b2d67eb34a0e05f491b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4372/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3475/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4291/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtiorng device
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for virtiorng device .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4371/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3474/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4290/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtiorng device
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for virtiorng device .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4370/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3473/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4289/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Michal Skrivanek has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 23: and we still have one working on engine as a backup, we'll use him as a last resort;-) -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4369/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3472/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4288/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4368/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3471/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4287/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4367/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3470/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4286/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtiorng device
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: add support for virtiorng device
..
Patch Set 3:
(1 comment)
File vdsm/vm.py
Line 1658:
Line 1659:
Line 1660: """
Line 1661: rng = self.createXmlElem('rng', None, ['model'])
Line 1662: if 'bytes' in self.specParams:
if I violate the API and call it with bytes only?
Line 1663: rng.appendChildWithArgs('rate',
Line 1664:
period=self.specParams.get('period'),
Line 1665: bytes=self.specParams['bytes'])
Line 1666:
--
To view, visit http://gerrit.ovirt.org/19091
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 3:
(2 comments)
File lib/vdsm/tool/libvirt_configure.py
Line 64: """
Line 65: return exec_libvirt_configure("test_conflict_configurations",
*args)
Line 66:
Line 67:
Line 68: @vdsm.tool.expose("reconfigure-restart")
libvirt-configure-services-restart ?
Line 69: def reconfigure_restart(*args):
Line 70: """
Line 71: Managing restart of related services
Line 72: """
File lib/vdsm/tool/libvirt_configure.sh.in
Line 282: ovirt_store_config "${lconf}" "${qconf}" "${ldconf}"
"${llogr}"
Line 283: fi
Line 284:
Line 285: echo "Reconfigure libvirt is done."
Line 286: /bin/vdsm-tool reconfigure-restart -h
why -h?
Line 287:
Line 288:
Line 289: #
Line 290: # finished reconfiguration, do not trigger
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 9:
(2 comments)
File init/daemonAdapter
Line 98: except Exception as e:
Line 99: if self._args and self._args.syslog:
Line 100: syslog.syslog("Error in daemonAdapater: %s" % e)
Line 101: else:
Line 102: sys.stderr.write("Error in daemonAdapater: %s" % e)
why not have log method?
Line 103: sys.exit(1)
Line 104:
Line 105:
Line 106: if __name__ == '__main__':
Line 104:
Line 105:
Line 106: if __name__ == '__main__':
Line 107: d = DaemonAdapter()
Line 108: sys.exit(d.execute())
double exit? here and at except?
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 13:
(3 comments)
File init/sysvinit/vdsmd.init.in
Line 155: killproc -p "$PIDFILE" -d 2
Line 156: RETVAL=$?
Line 157: if [ "$RETVAL" = 0 ]; then
Line 158: "@RM_PATH@" -f "$LOCK_FILE" > /dev/null 2>&1
Line 159: log_success_msg $"$prog stop"
I am thinking of moving these messages to main switch so we have all in one
place... success, failure, locked, what do you think?
Line 160: else
Line 161: log_failure_msg $"$prog stop"
Line 162: fi
Line 163: fi
Line 170: {
Line 171: if flock -n 9; then
Line 172: start
Line 173: else
Line 174: log_failure_msg "another ${prog} operation is
running..."
use $"xxx" as others?
Line 175:false
Line 176: fi
Line 177: } 9<$0
Line 178: RETVAL=$?
Line 171: if flock -n 9; then
Line 172: start
Line 173: else
Line 174: log_failure_msg "another ${prog} operation is
running..."
Line 175:false
tabs
Line 176: fi
Line 177: } 9<$0
Line 178: RETVAL=$?
Line 179: ;;
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 2:
(1 comment)
still missing restart from the sysv init
File lib/vdsm/tool/libvirt_configure.sh.in
Line 282: ovirt_store_config "${lconf}" "${qconf}" "${ldconf}"
"${llogr}"
Line 283: fi
Line 284:
Line 285: echo "Reconfigure libvirt is done."
Line 286: echo "To start using new configuration please restart related
services:"
I would have specified which services, and state or execute ...
Line 287: echo "['vdsm-tool reconfigure-restart']"
Line 288:
Line 289: #
Line 290: # finished reconfiguration, do not trigger
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4366/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3469/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4285/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 12:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 166: }
Line 167:
Line 168: die() {
Line 169: log_failure_msg "$1"
Line 170: exit 1
the exit 1 is not good in the context bellow, as it quites the script while we
need to finish execution. Not critical as error code will be 1 anyway.
Line 171: }
Line 172:
Line 173: case "$1" in
Line 174: start)
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtiorng device
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for virtiorng device .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4365/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3468/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4284/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4364/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3467/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4283/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4363/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3466/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4282/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 11:
(2 comments)
File init/sysvinit/vdsmd.init.in
Line 134: --daemon --masterpid "${RESPAWNPIDFILE}" "${VDSM_BIN}"
--pidfile "${PIDFILE}"
Line 135: )
Line 136: RETVAL=$?
Line 137: [ "$RETVAL" -eq 0 ] && touch "${LOCK_FILE}" &&
Line 138: log_success_msg $"$prog start" || log_failure_msg $"$prog start"
this is bad... as if log_success or touch fails... well I know that for this
specific case it is somewhat ok.
I prefer:
if [ "${RETVAL}" = 0 ]; then
touch
message
else
message
fi
The double if is also better than the new one... :)
Line 139: return "$RETVAL"
Line 140: }
Line 141:
Line 142: stop() {
Line 170: RETVAL=$?
Line 171: ;;
Line 172: stop)
Line 173: {
Line 174: flock -n 9 || fail_op
still think that fail_op should be renamed to die and accept parameter or
removed entirely.
Line 175: stop
Line 176: } 9<$0
Line 177: RETVAL=$?
Line 178: ;;
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4362/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3465/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4281/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: Fix str/unicode concatenation issue.
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsClient: Fix str/unicode concatenation issue.
..
Patch Set 2:
(1 comment)
File client/vdsClient.py
Line 1469: message += '\n' + ''
+ '\n'
Line 1470: message += entry + '=' + infos['vmlist'][entry]
Line 1471: if not message:
Line 1472: message = 'No VMs found.'
Line 1473: print message.encode("utf-8")
shouldn't we encode to sys.stdout.encoding encoding?
Line 1474:
Line 1475: return 0, ''
Line 1476:
Line 1477: def do_getVmsList(self, args):
--
To view, visit http://gerrit.ovirt.org/19032
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44dce25bb167da8ade579b2d67eb34a0e05f491b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 9:
(3 comments)
File init/sysvinit/vdsmd.init.in
Line 206
Line 207
Line 208
Line 209
Line 210
we also need to lock the stop per the post logic
Line 150: else
Line 151: killproc -p "$PIDFILE" -d 2
Line 152: RETVAL=$?
Line 153: [ "$RETVAL" -eq 0 ] && log_success_msg $"$prog stop" ||
log_failure_msg $"$prog stop"
Line 154: [ "$RETVAL" -eq 0 ] && "@RM_PATH@" -f "$LOCK_FILE" >
/dev/null 2>&1
single if please
Line 155: fi
Line 156: "${VDSMD_INIT_COMMON}" --post-stop
Line 157: }
Line 158:
Line 164: case "$1" in
Line 165: start)
Line 166: {
Line 167: flock -n 9 || fail_op
Line 168: start 9<&-
no need 9<&- here, you break the lock.
Line 169: } 9<$0
Line 170: RETVAL=$?
Line 171: ;;
Line 172: stop)
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4361/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3464/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4280/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4360/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3463/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4279/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Yaniv Bronhaim has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 8: (1 comment) File init/sysvinit/vdsmd.init.in Line 166: } 9<$0 Line 167: RETVAL=$? Line 168: ;; Line 169: stop) Line 170: stop something is wrong with my vi plugins. I'll fix the tabs, ignore it for now please. Line 171: RETVAL=$? Line 172: ;; Line 173: status) Line 174: pidofproc -p "$PIDFILE" "$VDSM_BIN" >/dev/null -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 7:
(3 comments)
File init/sysvinit/vdsmd.init.in
Line 29
Line 30
Line 31
Line 32
Line 33
you need lock file... create on successful start and removed at successful stop.
Line 160:
Line 161: case "$1" in
Line 162: start)
Line 163:{
Line 164: flock -n 9 || fail_op
remove tabs, well or better indent all with tabs :)
rename fail_op to die and accept message, but if it used only once consider
just using if.
also the exit here is no correct, as you are not in subshell...
so it should be:
{
if ! flock -n 9; then
log_failure_msg "another ${prog} operation is running..."
false
else
start
fi
} 9<$0
Line 165: start
Line 166: } 9<$0
Line 167: RETVAL=$?
Line 168: ;;
Line 166: } 9<$0
Line 167: RETVAL=$?
Line 168: ;;
Line 169: stop)
Line 170: stop
tab?
Line 171: RETVAL=$?
Line 172: ;;
Line 173: status)
Line 174: pidofproc -p "$PIDFILE" "$VDSM_BIN" >/dev/null
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4359/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3462/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4278/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 6: (1 comment) File init/sysvinit/vdsmd.init.in Line 174: start Line 175: RETVAL=$? Line 176: ;; Line 177: stop) Line 178: check_running_operation hmm... the post stop is something that is highly non standard, as when vdsm exists for any reason other than normal stop it won't execute this code. you are right, as long as we have the post stop we should lock the stop and post stop as well. Line 179: stop Line 180: RETVAL=$? Line 181: ;; Line 182: status) -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Zhou Zheng Sheng has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 6: (1 comment) File init/sysvinit/vdsmd.init.in Line 174: start Line 175: RETVAL=$? Line 176: ;; Line 177: stop) Line 178: check_running_operation Do we need to sync pre-start and post-stop tasks, including hooks? If they should be synced, we probably need to lock inid.pid before calling start() and stop(), and this is exactly what we're implementing flock on init.pid for. Line 179: stop Line 180: RETVAL=$? Line 181: ;; Line 182: status) -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...
Zhou Zheng Sheng has posted comments on this change. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock .. Patch Set 4: (1 comment) File configure.ac Line 47 Line 48 Line 49 Line 50 Line 51 No. According to the official document, the example packages I mentioned in the last patch set discussion and output from ./configure, the following help string styles are encouraged. --enable-xxx[=value]plain English [default=yes] --enable-xxx[=value]plain English [default=no] --disable-xxxplain English So we only remove "[default=value]" from help string of "--disable-xxx", because "--disable-xxx" does not accept value. Even it accepts value actually, it's not in official documentation and not in the example packages I examined. So it's not encouraged. -- To view, visit http://gerrit.ovirt.org/19005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: handle missing sanlock pid file
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: handle missing sanlock pid file .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4358/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3461/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4277/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I711d9b413415ca9372520e6bb25cf6d39ff571a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: Fix str/unicode concatenation issue.
Dan Kenigsberg has posted comments on this change. Change subject: vdsClient: Fix str/unicode concatenation issue. .. Patch Set 2: Code-Review-1 (1 comment) Commit Message Line 36: not in range(128) Line 37: Line 38: This patch is removing the str() conversion for infos['vmlist'][entry]. The result Line 39: is 'messages' variable as type unicode when infos['vmlist'][entry] is unicode. Line 40: Also, to avoid stdout redir encode error, the messages print is encoded as UTF-8. Could you explain this last point? What if the controlling terminal has a non utf8 enconding? Line 41: Line 42: Change-Id: I44dce25bb167da8ade579b2d67eb34a0e05f491b -- To view, visit http://gerrit.ovirt.org/19032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44dce25bb167da8ade579b2d67eb34a0e05f491b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: handle missing sanlock pid file
Federico Simoncelli has posted comments on this change. Change subject: vdsm-tool: handle missing sanlock pid file .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I711d9b413415ca9372520e6bb25cf6d39ff571a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: handle missing sanlock pid file
Federico Simoncelli has uploaded a new change for review. Change subject: vdsm-tool: handle missing sanlock pid file .. vdsm-tool: handle missing sanlock pid file Change-Id: I711d9b413415ca9372520e6bb25cf6d39ff571a3 Signed-off-by: Federico Simoncelli --- M lib/vdsm/tool/sanlock.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/19112/1 diff --git a/lib/vdsm/tool/sanlock.py b/lib/vdsm/tool/sanlock.py index c64c874..650a5cf 100644 --- a/lib/vdsm/tool/sanlock.py +++ b/lib/vdsm/tool/sanlock.py @@ -38,13 +38,13 @@ supplementary groups. """ -sanlock_pid = open(SANLOCK_PID, "r").readline().strip() - try: +sanlock_pid = open(SANLOCK_PID, "r").readline().strip() sanlock_status = open(PROC_STATUS_PATH % sanlock_pid, "r") except IOError as e: if e.errno == os.errno.ENOENT: return 0 # service is not running, returning +raise for status_line in sanlock_status: if status_line.startswith(PROC_STATUS_GROUPS): -- To view, visit http://gerrit.ovirt.org/19112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I711d9b413415ca9372520e6bb25cf6d39ff571a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...
Alon Bar-Lev has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 4:
(2 comments)
File configure.ac
Line 47
Line 48
Line 49
Line 50
Line 51
I do not follow... please be consistent... if you put default here you should
put default on disable bellow, the format should be the same.
File lib/vdsm/tool/libvirt_configure.sh.in
Line 207: set_if_default "${lconf}" auth_unix_rw \"sasl\"
Line 208: set_if_default "${lconf}" host_uuid "\"$(uuidgen)\""
Line 209: set_if_default "${lconf}" keepalive_interval -1
Line 210: set_if_default "${qconf}" dynamic_ownership 0
Line 211: if [ "${ENABLE_LIBVIRT_SELINUX}" != "yes" ]; then
as far as I can see this is a bug fix not fixing the strings especially if we
add the consistent handling of all enable/disable... but not that important.
Line 212: set_if_default "${qconf}" security_driver \"none\"
Line 213: fi
Line 214:
Line 215: if [ "${ssl}" = "true" ]; then
--
To view, visit http://gerrit.ovirt.org/19005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 4: Verified+1
(2 comments)
File configure.ac
Line 47
Line 48
Line 49
Line 50
Line 51
According to the discussion on official manual and the example packages in the
previous patch set, I think this @<:@default=no@:>@ is valid in the help string
for --enable-xxx. There is also no ambiguity in the semantics.
File lib/vdsm/tool/libvirt_configure.sh.in
Line 207: set_if_default "${lconf}" auth_unix_rw \"sasl\"
Line 208: set_if_default "${lconf}" host_uuid "\"$(uuidgen)\""
Line 209: set_if_default "${lconf}" keepalive_interval -1
Line 210: set_if_default "${qconf}" dynamic_ownership 0
Line 211: if [ "${ENABLE_LIBVIRT_SELINUX}" != "yes" ]; then
I think it's OK to fix them together. The help string is part of the "user
interface", the code is part of the "implementation", both are part of this
feature.
Line 212: set_if_default "${qconf}" security_driver \"none\"
Line 213: fi
Line 214:
Line 215: if [ "${ssl}" = "true" ]; then
--
To view, visit http://gerrit.ovirt.org/19005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] vdsm: add support for virtiorng device
Michal Skrivanek has posted comments on this change. Change subject: [WIP] vdsm: add support for virtiorng device .. Patch Set 2: (1 comment) Commit Message Line 6: Line 7: [WIP] vdsm: add support for virtiorng device Line 8: Line 9: Adds support for virtiorng with basic capabilities Line 10: - TODO: decide which sources are supported I'd go with bug 977079, random & rgd...rgd probably only as a passthrough of parameters to not overcomplicate things Line 11: agree upon API Line 12: Line 13: Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] vdsm: add support for virtiorng device
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] vdsm: add support for virtiorng device .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3460/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4276/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4356/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3459/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4275/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...
Alon Bar-Lev has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 4:
(2 comments)
File configure.ac
Line 47
Line 48
Line 49
Line 50
Line 51
please fix that as well.
File lib/vdsm/tool/libvirt_configure.sh.in
Line 207: set_if_default "${lconf}" auth_unix_rw \"sasl\"
Line 208: set_if_default "${lconf}" host_uuid "\"$(uuidgen)\""
Line 209: set_if_default "${lconf}" keepalive_interval -1
Line 210: set_if_default "${qconf}" dynamic_ownership 0
Line 211: if [ "${ENABLE_LIBVIRT_SELINUX}" != "yes" ]; then
different patch?
Line 212: set_if_default "${qconf}" security_driver \"none\"
Line 213: fi
Line 214:
Line 215: if [ "${ssl}" = "true" ]; then
--
To view, visit http://gerrit.ovirt.org/19005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 6:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 26: GETCONFITEM="@VDSMDIR@/get-conf-item"
Line 27: prog=vdsm
Line 28: PIDFILE=@VDSMRUNDIR@/vdsmd.pid
Line 29: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid
Line 30: INITPIDFILE=@VDSMRUNDIR@/init.pid
This is working, pid is not required and subprocess will not inherit fd 9, the
problem is that the whole start is done in subshell, easier is to close the fd
9 and create this subshell only before we do the daemon.
{
flock -n 9 || die "locked"
( start 9>&- ) || die "start failed"
} 9< $0
Line 31: CORE_DUMP_PATH="/var/log/core/core.%p.%t.dump"
Line 32: CORE_PATTERN="/proc/sys/kernel/core_pattern"
Line 33: LOCK_FILE="/var/lock/subsys/vdsmd"
Line 34: NEEDED_SERVICES="iscsid multipathd rpcbind ntpd wdmd sanlock network
libvirtd
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 6:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 79:if [ -n "${initpid}" ]; then
Line 80: kill -0 "${initpid}" >/dev/null && fail_op
Line 81:fi
Line 82: echo $$ > "${INITPIDFILE}"
Line 83: } 9<"${LOCK_FILE}"
Sorry, I missed one point here. 9>init.pid means open the pid file in truncate
mode. So in the { } block when we cat init.pid, it outputs nothing. I think
9>>init.pid is better. It creates the pid automatically and open it without
truncating, and we'll still use "echo $$ >init.pid' to overwrite the pid file.
Another valid method is always "touch init.pid" before "{ flock ... }
9http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 6: (1 comment) File init/sysvinit/vdsmd.init.in Line 26: GETCONFITEM="@VDSMDIR@/get-conf-item" Line 27: prog=vdsm Line 28: PIDFILE=@VDSMRUNDIR@/vdsmd.pid Line 29: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid Line 30: INITPIDFILE=@VDSMRUNDIR@/init.pid well, then I would call this lock... and put it in /var/lock.. :) Line 31: CORE_DUMP_PATH="/var/log/core/core.%p.%t.dump" Line 32: CORE_PATTERN="/proc/sys/kernel/core_pattern" Line 33: LOCK_FILE="/var/lock/subsys/vdsmd" Line 34: NEEDED_SERVICES="iscsid multipathd rpcbind ntpd wdmd sanlock network libvirtd -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use the full prefix when removing file images.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use the full prefix when removing file images. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4355/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3458/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4274/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie42dfb17eff1cbbf054de0cab493321567ea7e25 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gadi Ickowicz Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Yaniv Bronhaim has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 6: (2 comments) File init/sysvinit/vdsmd.init.in Line 26: GETCONFITEM="@VDSMDIR@/get-conf-item" Line 27: prog=vdsm Line 28: PIDFILE=@VDSMRUNDIR@/vdsmd.pid Line 29: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid Line 30: INITPIDFILE=@VDSMRUNDIR@/init.pid we can't use the RESPAWNPIDFILE, it can cause a mess while check status or trying to stop the service. lets say we have a running instance of vdsm with respawn pid alive, now we call another start -> it changes the pid file and call start, saw that instance exists and exit. now the pid in the file is wrong. Additional file is required here, and I'll add it to comment. we can omit the usage of the LOCK_FILE though and use this init pid file instead as suggested by Zhou. Line 31: CORE_DUMP_PATH="/var/log/core/core.%p.%t.dump" Line 32: CORE_PATTERN="/proc/sys/kernel/core_pattern" Line 33: LOCK_FILE="/var/lock/subsys/vdsmd" Line 34: NEEDED_SERVICES="iscsid multipathd rpcbind ntpd wdmd sanlock network libvirtd Line 174: start Line 175: RETVAL=$? Line 176: ;; Line 177: stop) Line 178: check_running_operation After some thinking seems that you're right. I'll verify it just to be sure, but from reading the code it seems fine to use this validation only on start Line 179: stop Line 180: RETVAL=$? Line 181: ;; Line 182: status) -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use the full prefix when removing file images.
Eduardo has uploaded a new change for review. Change subject: Use the full prefix when removing file images. .. Use the full prefix when removing file images. os.tempnam() prefix is limited to 5 characters. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1005788 Change-Id: Ie42dfb17eff1cbbf054de0cab493321567ea7e25 Signed-off-by: Eduardo --- M vdsm/storage/fileSD.py 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/19107/1 diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py index ee1255f..0cccaef 100644 --- a/vdsm/storage/fileSD.py +++ b/vdsm/storage/fileSD.py @@ -342,7 +342,9 @@ def deleteImage(self, sdUUID, imgUUID, volsImgs): currImgDir = getImagePath(sdUUID, imgUUID) dirName, baseName = os.path.split(currImgDir) -toDelDir = os.tempnam(dirName, sd.REMOVED_IMAGE_PREFIX + baseName) +saltDir, salt = os.path.split(os.tempnam(dirName, "_DEL_")) +toDelDir = os.path.join(saltDir, +sd.REMOVED_IMAGE_PREFIX + baseName + salt) try: self.oop.os.rename(currImgDir, toDelDir) except OSError as e: -- To view, visit http://gerrit.ovirt.org/19107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie42dfb17eff1cbbf054de0cab493321567ea7e25 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
