Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor StoragePool.getPoolParams()
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactor StoragePool.getPoolParams() .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4428/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3531/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4347/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeaaaf67a39f3ca8b27252fc631a91f266d1adc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor StoragePool.getPoolParams()
Eduardo has uploaded a new change for review.
Change subject: Refactor StoragePool.getPoolParams()
..
Refactor StoragePool.getPoolParams()
Change-Id: Ibbeaaaf67a39f3ca8b27252fc631a91f266d1adc
Signed-off-by: Eduardo
---
M vdsm/storage/sp.py
1 file changed, 4 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/19232/1
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 38eda39..d5a8b4e 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -734,21 +734,10 @@
@unsecured
def getPoolParams(self):
-file = open(self._poolFile, "r")
-for line in file:
-pair = line.strip().split("=")
-if len(pair) == 2:
-if pair[0] == "id":
-hostId = int(pair[1])
-elif pair[0] == "scsiKey":
-scsiKey = pair[1]
-elif pair[0] == "sdUUID":
-msdUUID = pair[1]
-elif pair[0] == "version":
-masterVersion = pair[1]
-file.close()
-
-return hostId, scsiKey, msdUUID, masterVersion
+lines = open(self._poolFile, "r").readlines()
+params = dict(line.strip().split('=') for line in lines if '=' in line)
+return tuple(params[k] for k in ('hostId', 'scsiKey', 'msdUUID',
+ 'masterVersion'))
@unsecured
def createMaster(self, poolName, domain, masterVersion, leaseParams):
--
To view, visit http://gerrit.ovirt.org/19232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbeaaaf67a39f3ca8b27252fc631a91f266d1adc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4427/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3530/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4346/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 16: (1 comment) File init/daemonAdapter Line 29: Line 30: Line 31: class DaemonAdapter(object): Line 32: def __init__(self): Line 33: self._args = None so its either this with one function instead of a class or http://gerrit.ovirt.org/#/c/18810/14/init/daemonAdapter , the latter more useful for future use .. I also prefer the old form. Dan, any rejections? Line 34: Line 35: def _parse_args(self): Line 36: parser = argparse.ArgumentParser( Line 37: description='Start daemon process with various daemon options') -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 16: (1 comment) File init/daemonAdapter Line 29: Line 30: Line 31: class DaemonAdapter(object): Line 32: def __init__(self): Line 33: self._args = None BTW: in this implementation you do not need _args as member, nor do you need the class... I liked the old one more. Line 34: Line 35: def _parse_args(self): Line 36: parser = argparse.ArgumentParser( Line 37: description='Start daemon process with various daemon options') -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4426/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4345/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 16: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 15:
(1 comment)
File init/daemonAdapter
Line 56: help='Add options to be passed to target')
Line 57: return parser.parse_args(sys.argv[1:])
Line 58:
Line 59: def _log(self, msg):
Line 60: if self._args.syslog:
but still it can ends up with failure during the parse, so check if "self._args
is not none" is needed in this part avoid AttributeError
Line 61: for m in msg.splitlines():
Line 62: syslog.syslog(m)
Line 63: else:
Line 64: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4425/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3528/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4344/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 8:
(2 comments)
File init/systemd/systemd-vdsmd.in
Line 26: [ "$1" != "reconfigure" ] && usage_exit
Line 27: [ -n "$2" -a "$2" != "force" ] && usage_exit
Line 28:
Line 29: "@BINDIR@/vdsm-tool" libvirt-configure ${2:+--force} &&
Line 30: "@BINDIR@/vdsm-tool" libvirt-configure-services-restart
please indent
File init/sysvinit/vdsmd.init.in
Line 119: reconfigure_libvirt() {
Line 120: local force
Line 121: [ "${1}" = "force" ] && force="--force"
Line 122: "$VDSM_TOOL" libvirt-configure "${force}" &&
Line 123: "$VDSM_TOOL" libvirt-configure-services-restart
usually you need to indent such statements so it will be cleared that these are
two.
also remove the quotes from "${force}", as you do not want any parameter if
empty.
Line 124: }
Line 125:
Line 126: start() {
Line 127: local ret_val
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 7:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 123: "$VDSM_TOOL" libvirt-configure
Line 124: fi
Line 125: RETVAL=$?
Line 126: [ "$RETVAL" = 0 ] && "$VDSM_TOOL"
libvirt-configure-services-restart
Line 127: return "$RETVAL"
Another option:
reconfigure_libvirt() {
local force
[ "$1" = "force" ] && force="--force"
"${VDSM_TOOL}" libvirt-configure ${force} && "${VDSM_TOOL}"
libvirt-configure-services-restart
}
better, no?
Line 128: }
Line 129:
Line 130: start() {
Line 131: local ret_val
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 15:
(1 comment)
File init/daemonAdapter
Line 56: help='Add options to be passed to target')
Line 57: return parser.parse_args(sys.argv[1:])
Line 58:
Line 59: def _log(self, msg):
Line 60: if self._args.syslog:
and I noted that file.write and syslog.syslog are different as you can see...
so if I to choose between function reference and member function, of course I
am for member!
so you wrote proper _log() function that can be used in future at any state,
but now we are limiting it to a specific case, so better is to put it in the
specific place in this new case.
Line 61: for m in msg.splitlines():
Line 62: syslog.syslog(m)
Line 63: else:
Line 64: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 15:
(1 comment)
File init/daemonAdapter
Line 56: help='Add options to be passed to target')
Line 57: return parser.parse_args(sys.argv[1:])
Line 58:
Line 59: def _log(self, msg):
Line 60: if self._args.syslog:
I did it before there and you commented to make a log func... it was your call,
i prefer to have it only under the except
Line 61: for m in msg.splitlines():
Line 62: syslog.syslog(m)
Line 63: else:
Line 64: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 7:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 123: "$VDSM_TOOL" libvirt-configure
Line 124: fi
Line 125: RETVAL=$?
Line 126: [ "$RETVAL" = 0 ] && "$VDSM_TOOL"
libvirt-configure-services-restart
Line 127: return "$RETVAL"
first fail...
RETVAL=$?
if [ "$RETVAL" = 0 ]; then
"$VDSM_TOOL" libvirt-configure-services-restart
RETVAL=$?
fi
Line 128: }
Line 129:
Line 130: start() {
Line 131: local ret_val
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 7:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 123: "$VDSM_TOOL" libvirt-configure
Line 124: fi
Line 125: RETVAL=$?
Line 126: [ "$RETVAL" = 0 ] && "$VDSM_TOOL"
libvirt-configure-services-restart
Line 127: return "$RETVAL"
but what is righter? returning the libvirt-configure return code or the
"restart services" one?
Line 128: }
Line 129:
Line 130: start() {
Line 131: local ret_val
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 15:
(1 comment)
File init/daemonAdapter
Line 56: help='Add options to be passed to target')
Line 57: return parser.parse_args(sys.argv[1:])
Line 58:
Line 59: def _log(self, msg):
Line 60: if self._args.syslog:
if this specific to the except, and you call it only once, just move this
entire code to the except and drop the function :)
Line 61: for m in msg.splitlines():
Line 62: syslog.syslog(m)
Line 63: else:
Line 64: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 14:
(1 comment)
File init/daemonAdapter
Line 57: help='Add options to be passed to target')
Line 58: self._args = parser.parse_args(sys.argv[1:])
Line 59:
Line 60: def _log(self, msg):
Line 61: if self._args and self._args.syslog:
if you use _log at constructor or any other... I just like closed
implementations... especially for logs.
nevertheless it is not that important.
Line 62: for m in msg.splitlines():
Line 63: syslog.syslog(m)
Line 64: else:
Line 65: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 15:
(1 comment)
File init/daemonAdapter
Line 56: help='Add options to be passed to target')
Line 57: return parser.parse_args(sys.argv[1:])
Line 58:
Line 59: def _log(self, msg):
Line 60: if self._args.syslog:
I don't know which is better, both seems fine to me.
but this must contain try except clause on parse part. Dan, any preferences?
Line 61: for m in msg.splitlines():
Line 62: syslog.syslog(m)
Line 63: else:
Line 64: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4424/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3527/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4343/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 14:
(1 comment)
File init/daemonAdapter
Line 57: help='Add options to be passed to target')
Line 58: self._args = parser.parse_args(sys.argv[1:])
Line 59:
Line 60: def _log(self, msg):
Line 61: if self._args and self._args.syslog:
I guess not parsing that currently will raise an exception, so that's not
necessary here, but we might need to scope the parse part in try except
Line 62: for m in msg.splitlines():
Line 63: syslog.syslog(m)
Line 64: else:
Line 65: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 7:
(1 comment)
File init/systemd/systemd-vdsmd.in
Line 26: [ "$1" != "reconfigure" ] && usage_exit
Line 27: [ -n "$2" -a "$2" != "force" ] && usage_exit
Line 28:
Line 29: "@BINDIR@/vdsm-tool" libvirt-configure ${2:+--force}
Line 30: "@BINDIR@/vdsm-tool" libvirt-configure-services-restart
I don't care which method you choose, but please sync behavior between this and
init/sysvinit/vdsmd.init.in
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 15:
(1 comment)
File init/daemonAdapter
Line 56: help='Add options to be passed to target')
Line 57: return parser.parse_args(sys.argv[1:])
Line 58:
Line 59: def _log(self, msg):
Line 60: if self._args.syslog:
I liked this if no args.
Line 61: for m in msg.splitlines():
Line 62: syslog.syslog(m)
Line 63: else:
Line 64: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 14:
(1 comment)
File init/daemonAdapter
Line 57: help='Add options to be passed to target')
Line 58: self._args = parser.parse_args(sys.argv[1:])
Line 59:
Line 60: def _log(self, msg):
Line 61: if self._args and self._args.syslog:
for the case argument where not parsed correctly or some other early error.
Line 62: for m in msg.splitlines():
Line 63: syslog.syslog(m)
Line 64: else:
Line 65: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Dan Kenigsberg has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 14: Code-Review-1
(2 comments)
minor question, -1 for visibility.
Commit Message
Line 7: Handling errors in daemonAdapter
Line 8:
Line 9: This patch adds --syslog arguments to daemonAdapter that declares if
reporting
Line 10: will be logged to syslog or to standard stderr (which is used by
Line 11: default).
missing text: "The new option is needed in order to catch and log possible
failures when vdsm is run via sysv, which does not capture stderr of the
service script." Right?
Line 12: This patch also introduces daemonAdapter class to simplify the
Line 13: implementation.
Line 14:
Line 15: Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
File init/daemonAdapter
Line 57: help='Add options to be passed to target')
Line 58: self._args = parser.parse_args(sys.argv[1:])
Line 59:
Line 60: def _log(self, msg):
Line 61: if self._args and self._args.syslog:
when can bool(self._args) be False? The check seems redundant to me.
Line 62: for m in msg.splitlines():
Line 63: syslog.syslog(m)
Line 64: else:
Line 65: sys.stderr.write("%s\n" % msg)
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 7:
(1 comment)
File init/systemd/systemd-vdsmd.in
Line 26: [ "$1" != "reconfigure" ] && usage_exit
Line 27: [ -n "$2" -a "$2" != "force" ] && usage_exit
Line 28:
Line 29: "@BINDIR@/vdsm-tool" libvirt-configure ${2:+--force}
Line 30: "@BINDIR@/vdsm-tool" libvirt-configure-services-restart
I don't understand the comment.. The problem is that the retval should be the
exit code of libvirt-configure, right?
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4422/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3525/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4341/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4423/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4342/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Yaniv Bronhaim has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 19: Verified+1 -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 19: Code-Review+1 Please avoid rebase if not required... -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Yaniv Bronhaim has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 18: Verified+1 Of course it is, I wouldn't submit without at least one run. re-verification will be appreciated. Zhou? :) Thanks for following. -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 18: Code-Review+1 OK, looks OK, hope that also working :) -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 13:
(1 comment)
File init/daemonAdapter
Line 101: os.dup2(fderr, sys.stderr.fileno())
Line 102: os.close(fderr)
Line 103:
Line 104: os.execve(cmd[0], cmd, env)
Line 105: return 0
because execve never returns unless there is an error executing the process. it
replaces the current container in other image.
Line 106:
Line 107: except:
Line 108: self._log("Error in daemonAdapater: %s" %
traceback.print_exc())
Line 109: return 1
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 13:
(1 comment)
File init/daemonAdapter
Line 101: os.dup2(fderr, sys.stderr.fileno())
Line 102: os.close(fderr)
Line 103:
Line 104: os.execve(cmd[0], cmd, env)
Line 105: return 0
Why? the execution will exit eventually, maybe last errno should be returned
Line 106:
Line 107: except:
Line 108: self._log("Error in daemonAdapater: %s" %
traceback.print_exc())
Line 109: return 1
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4421/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3524/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4340/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 13:
(1 comment)
File init/daemonAdapter
Line 101: os.dup2(fderr, sys.stderr.fileno())
Line 102: os.close(fderr)
Line 103:
Line 104: os.execve(cmd[0], cmd, env)
Line 105: return 0
return 1, reaching here is a failure
Line 106:
Line 107: except:
Line 108: self._log("Error in daemonAdapater: %s" %
traceback.print_exc())
Line 109: return 1
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4420/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3523/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4339/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4419/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3522/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4338/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 16:
(3 comments)
File init/sysvinit/vdsmd.init.in
Line 128:
Line 129: echo $"Starting up vdsm daemon: "
Line 130: NICELEVEL="${NICE_LOWEST}" daemon --user=vdsm
"@VDSMDIR@/daemonAdapter" \
Line 131: -0 /dev/null -1 /dev/null -2 /dev/null --syslog
"@VDSMDIR@/respawn" --minlifetime 10 \
Line 132: --daemon --masterpid "${RESPAWNPIDFILE}" "${VDSM_BIN}"
--pidfile "${PIDFILE}"
nothing should have changed above in this patch.
Line 133: RETVAL=$?
Line 134: [ "$RETVAL" = 0 ] && touch "${LOCK_FILE}"
Line 135: return "$RETVAL"
Line 136: }
Line 154:
Line 155: lock_op() {
Line 156: {
Line 157: if ! flock -n 9; then
Line 158: log_failure_msg $"cannot "${1}" "${prog}", operation is
locked"
tabs
Line 159: elif ( "${1}" 9<&- ); then
Line 160: log_success_msg $"$prog "${1}""
Line 161: else
Line 162: log_failure_msg $"${prog} "${1}""
Line 179: RETVAL=$?
Line 180: if [ "$RETVAL" -eq 0 ]; then
Line 181: echo "VDS daemon server is running"
Line 182: else
Line 183: echo "VDS daemon is not running"
this will trigger new line and the bellow statement will not be at same line
Line 184: if pidofproc -p "$RESPAWNPIDFILE" >/dev/null; then
Line 185: echo ", and its watchdog is running"
Line 186: else
Line 187: echo
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 12:
(1 comment)
File init/daemonAdapter
Line 62: msg = msg.split('\n')
Line 63: for m in msg.splitlines():
Line 64: syslog.syslog(m)
Line 65: else:
Line 66: msg = '%s\n' % msg
my glitch. sorry.
Line 67: sys.stderr.write("%s\n" % msg)
Line 68:
Line 69: def execute(self):
Line 70: try:
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 12:
(2 comments)
File init/daemonAdapter
Line 58: self._args = parser.parse_args(sys.argv[1:])
Line 59:
Line 60: def _log(self, msg):
Line 61: if self._args and self._args.syslog:
Line 62: msg = msg.split('\n')
the above can be removed.
Line 63: for m in msg.splitlines():
Line 64: syslog.syslog(m)
Line 65: else:
Line 66: msg = '%s\n' % msg
Line 62: msg = msg.split('\n')
Line 63: for m in msg.splitlines():
Line 64: syslog.syslog(m)
Line 65: else:
Line 66: msg = '%s\n' % msg
the above can be remvoed.
Line 67: sys.stderr.write("%s\n" % msg)
Line 68:
Line 69: def execute(self):
Line 70: try:
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4417/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3520/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4336/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4418/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4337/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu
Dan Kenigsberg has posted comments on this change. Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu .. Patch Set 6: Code-Review+1 I think that the vdsm tarball would be better if it includes a "reference" deb, to be used as a basis for the Ubuntu maintainer. However, we can take this patch only if Zhou (are any other Ubuntu expert) commits to keeping it up to date with changes, as most vdsm developers (and maintainers) are quite likely to neglect it. -- To view, visit http://gerrit.ovirt.org/18443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...
Alon Bar-Lev has posted comments on this change. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock .. Patch Set 5: > Alon, I assume that if this had been unacceptable to you, you would not have > been shy to use your -1. Thus, I'll take this as it is. I just try to share some of my experience. -- To view, visit http://gerrit.ovirt.org/19005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...
Dan Kenigsberg has posted comments on this change. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock .. Patch Set 4: Code-Review+2 I must admit that I do not care that much for the exact help wording. The included bugfix interests me more, and the depending patch - even more. Alon, I assume that if this had been unacceptable to you, you would not have been shy to use your -1. Thus, I'll take this as it is. -- To view, visit http://gerrit.ovirt.org/19005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock .. Packaging: Fix help string and usage for --disable-libvirt-sanlock Help strings in configure.ac for --disable-libvirt-sanlock and --disable-libvirt-selinux are as follow. --disable-libvirt-sanlock disable libvirt sanlock plugin [default=yes] --disable-libvirt-selinux disable libvirt selinux plugin [default=yes] From simplicity and disambiguation, we remove "[default=yes]". This patch changes the help string to as follow --disable-libvirt-sanlock disable libvirt sanlock plugin --disable-libvirt-selinux disable libvirt selinux plugin So there is no ambiguity of whether the feature is disbale or enabled by default. We also avoid suggesting user to use "--disable-libvirt-sanlock=yes|no" which is a bit confusing (at least to me). The user can just use "--disable-libvirt-sanlock" to disable it. This patch also fix the code logic related to ENABLE_LIBVIRT_SELINUX in libvirt_configure.sh.in to make it agree with the help string. Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd Signed-off-by: Zhou Zheng Sheng Reviewed-on: http://gerrit.ovirt.org/19005 Reviewed-by: Dan Kenigsberg --- M configure.ac M lib/vdsm/tool/libvirt_configure.sh.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified -- To view, visit http://gerrit.ovirt.org/19005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Fix the mtu of bond/nic not being set for new network
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Fix the mtu of bond/nic not being set for new network .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4415/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3518/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4334/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd534 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: more combinations mtu combinations
oVirt Jenkins CI Server has posted comments on this change. Change subject: net tests: more combinations mtu combinations .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4416/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3519/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4335/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd535 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: more combinations mtu combinations
Hello Mark Wu,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19230
to review the following change.
Change subject: net tests: more combinations mtu combinations
..
net tests: more combinations mtu combinations
The tests were splitted from the former functional fix in order to
expedite the merge of the latter one.
Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd535
Signed-off-by: Mark Wu
Signed-off-by: Dan Kenigsberg
---
M tests/functional/networkTests.py
1 file changed, 114 insertions(+), 25 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/19230/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 3825bf5..dff7ce2 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1024,48 +1024,62 @@
{})
self.assertEquals(status, SUCCESS, msg)
+def _createBondedNetAndCheck(self, netNum, bondDict, bridged,
+ **networkOpts):
+netName = NETWORK_NAME + str(netNum)
+networks = {netName: dict(bonding=BONDING_NAME, bridged=bridged,
+ vlan=str(int(VLAN_ID) + netNum),
+ **networkOpts)}
+status, msg = self.vdsm_net.setupNetworks(networks,
+ {BONDING_NAME: bondDict},
+ {})
+self.assertEquals(status, SUCCESS, msg)
+self.vdsm_net.networkExists(netName, bridged=bridged)
+self.vdsm_net.bondExists(BONDING_NAME, bondDict['nics'])
+if 'mtu' in networkOpts:
+self.assertEquals(networkOpts['mtu'],
+ self.vdsm_net.getMtu(netName))
+
@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@ValidateRunningAsRoot
def testSetupNetworksStableBond(self, bridged):
-def createBondedNetAndCheck(netNum, bondDict):
-netName = NETWORK_NAME + str(netNum)
-networks = {netName: dict(bonding=BONDING_NAME, bridged=bridged,
- vlan=str(int(VLAN_ID) + netNum))}
-status, msg = self.vdsm_net.setupNetworks(networks,
- {BONDING_NAME: bondDict},
- {})
-self.assertEquals(status, SUCCESS, msg)
-self.vdsm_net.networkExists(netName, bridged=bridged)
-self.vdsm_net.bondExists(BONDING_NAME, bondDict['nics'])
-
with dummyIf(3) as nics:
with self.vdsm_net.pinger():
# Add initial vlanned net over bond
-createBondedNetAndCheck(0, {'nics': nics[:2],
-'options': 'mode=3 miimon=250'})
+self._createBondedNetAndCheck(0, {'nics': nics[:2],
+ 'options': 'mode=3 miimon=250'},
+ bridged)
with nonChangingOperstate(BONDING_NAME):
# Add additional vlanned net over the bond
-createBondedNetAndCheck(1,
-{'nics': nics[:2],
- 'options': 'mode=3 miimon=250'})
+self._createBondedNetAndCheck(1,
+ {'nics': nics[:2],
+ 'options':
+ 'mode=3 miimon=250'},
+ bridged)
# Add additional vlanned net over the increasing bond
-createBondedNetAndCheck(2,
-{'nics': nics,
- 'options': 'mode=3 miimon=250'})
+self._createBondedNetAndCheck(2,
+ {'nics': nics,
+ 'options':
+ 'mode=3 miimon=250'},
+ bridged)
# Add additional vlanned net over the changing bond
-createBondedNetAndCheck(3,
-{'nics': nics[1:],
- 'options': 'mode=3 miimon=250'})
+self._createBondedNetAndCheck(3,
+ {'nics': nics[1:],
+ 'options':
+ 'mode=3 miimon=250'},
+ bridged)
Change in vdsm[master]: Handling errors in daemonAdapter
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 11:
(1 comment)
File init/daemonAdapter
Line 63: for m in msg:
Line 64: syslog.syslog(msg)
Line 65: else:
Line 66: msg = '%s\n' % msg
Line 67: sys.stderr.write(msg)
After the fast I'm more pedant about having temporaries :) To remember my sins
Line 68:
Line 69: def execute(self):
Line 70: try:
Line 71: os.nice(config.getint('vars', 'vdsm_nice'))
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Avoid prepare template by using unsafe qemu-img rebase
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: Avoid prepare template by using unsafe qemu-img rebase .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4413/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4332/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I959e49315b2539cdb9111edd1786590a22023907 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: add rebase to qemuImg module
oVirt Jenkins CI Server has posted comments on this change. Change subject: lib: add rebase to qemuImg module .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4414/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3517/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4333/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78e5584e59deaa5c302b1da67f5e3b840f6aa222 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Alon Bar-Lev has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 7:
(2 comments)
File init/systemd/systemd-vdsmd.in
Line 26: [ "$1" != "reconfigure" ] && usage_exit
Line 27: [ -n "$2" -a "$2" != "force" ] && usage_exit
Line 28:
Line 29: "@BINDIR@/vdsm-tool" libvirt-configure ${2:+--force}
Line 30: "@BINDIR@/vdsm-tool" libvirt-configure-services-restart
only if return is 0 similar to the other script?
File lib/vdsm/tool/libvirt_configure.sh.in
Line 285: echo "Reconfigure libvirt is done."
Line 286: echo "To start working with new configuration execute:"
Line 287: echo " vdsm-tool reconfigure-restart"
Line 288: echo "This will manage stop and start to the following services:"
Line 289: echo " libvirtd, supervdsmd"
Consider:
cat << __EOF__
bla bla bla
bla bla bla
__EOF__
and BTW: I would have done so in the vdsm-tool applet and not here.
Line 290:
Line 291: #
Line 292: # finished reconfiguration, do not trigger
Line 293: # next time
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: add rebase to qemuImg module
Yeela Kaplan has uploaded a new change for review.
Change subject: lib: add rebase to qemuImg module
..
lib: add rebase to qemuImg module
Change-Id: I78e5584e59deaa5c302b1da67f5e3b840f6aa222
Signed-off-by: Yeela Kaplan
---
M lib/vdsm/qemuImg.py
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/19229/1
diff --git a/lib/vdsm/qemuImg.py b/lib/vdsm/qemuImg.py
index e9a328c..24d6940 100644
--- a/lib/vdsm/qemuImg.py
+++ b/lib/vdsm/qemuImg.py
@@ -167,3 +167,24 @@
if rc != 0:
raise QImgError(rc, out, err)
+
+
+def rebase(image, backing, format=None, backingFormat=None, unsafe=False):
+cmd = [_qemuimg.cmd, "rebase"]
+
+if format:
+cmd.extend(("-f", format))
+
+if unsafe:
+cmd.append("-u")
+
+cmd.extend(("-b", backing))
+
+if backingFormat:
+cmd.extend(("-F", backingFormat))
+
+cmd.append(image)
+rc, out, err = utils.execCmd(cmd)
+
+if rc != 0:
+raise QImgError(rc, out, err)
--
To view, visit http://gerrit.ovirt.org/19229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78e5584e59deaa5c302b1da67f5e3b840f6aa222
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4412/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3515/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4331/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Alon Bar-Lev has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 15:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 126:
Line 127: "${VDSMD_INIT_COMMON}" --pre-start
Line 128:
Line 129: echo $"Starting up vdsm daemon: "
Line 130: (
no need for that now
Line 131: exec 9>&-
Line 132: NICELEVEL="${NICE_LOWEST}" daemon --user=vdsm
"@VDSMDIR@/daemonAdapter" \
Line 133: -0 /dev/null -1 /dev/null -2 /dev/null --syslog
"@VDSMDIR@/respawn" --minlifetime 10 \
Line 134: --daemon --masterpid "${RESPAWNPIDFILE}" "${VDSM_BIN}"
--pidfile "${PIDFILE}"
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
Alon Bar-Lev has posted comments on this change.
Change subject: Handling errors in daemonAdapter
..
Patch Set 11:
(2 comments)
File init/daemonAdapter
Line 59:
Line 60: def _log(self, msg):
Line 61: if self._args and self._args.syslog:
Line 62: msg = msg.split('\n')
Line 63: for m in msg:
why do you need msg temp? should be:
for m in msg.splitlines():
syslog.syslog(m)
Line 64: syslog.syslog(msg)
Line 65: else:
Line 66: msg = '%s\n' % msg
Line 67: sys.stderr.write(msg)
Line 63: for m in msg:
Line 64: syslog.syslog(msg)
Line 65: else:
Line 66: msg = '%s\n' % msg
Line 67: sys.stderr.write(msg)
should be:
sys.stderr.write("%s\n" % msg)
why do you need msg variable modified?
Line 68:
Line 69: def execute(self):
Line 70: try:
Line 71: os.nice(config.getint('vars', 'vdsm_nice'))
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handling errors in daemonAdapter
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4411/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3514/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4330/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4410/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3513/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4329/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...
Yaniv Bronhaim has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 14: -Verified
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 168: case "$1" in
Line 169: start)
Line 170: {
Line 171: if flock -n 9; then
Line 172: start
It does. It seems also easier to manage
Line 173: else
Line 174: log_failure_msg $"another ${prog} operation is
running..."
Line 175: false
Line 176: fi
--
To view, visit http://gerrit.ovirt.org/18875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic74c9cf9c2c520e94a98b99fdb970b544b780ba3
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: small refactoring for _normalizeVdsmImg
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: small refactoring for _normalizeVdsmImg .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4409/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3512/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4328/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie68292eee4b82fbe8527e3960739979cfe117dfa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 6: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4408/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3511/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4327/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 6: (2 comments) File vdsm/vm.py Line 1424: # To handle legacy and removable drives. Line 1425: return False Line 1426: Line 1427: def _customize(self): Line 1428: if self.transientDisk: Note to self: remember to check this. Line 1429: # Force the cache to be writethrough, which is qemu's default. Line 1430: # This is done to ensure that we don't ever use cache=none for Line 1431: # transient disks, since we create them in /var/run/vdsm which Line 1432: # may end up on tmpfs and don't support O_DIRECT, and qemu uses Line 3398: # We lookup the drive by UUIDs since the image path could be Line 3399: # transient. Line 3400: drive = self._findDriveByUUIDs(diskParams) Line 3401: else: Line 3402: drive = self._findDriveByPath(diskParams['path']) Catch LookupError and transform to errCode['hotunplugDisk']. Line 3403: Line 3404: if drive.hasVolumeLeases: Line 3405: return errCode['noimpl'] Line 3406: -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
