Change in vdsm[master]: Use the full prefix when removing file images.
Ayal Baron has posted comments on this change. Change subject: Use the full prefix when removing file images. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie42dfb17eff1cbbf054de0cab493321567ea7e25 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gadi Ickowicz Gerrit-Reviewer: Meital Bourvine Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Making getVSize and getVTrueSize SD methods.
Eduardo has posted comments on this change. Change subject: Making getVSize and getVTrueSize SD methods. .. Patch Set 4: (3 comments) Commit Message Line 12: Line 13: TODO: Line 14: This two method should be unified in a future patch since the Line 15: two values are returned in the same call for file volumes and Line 16: the two values are identical for block volumes. Makes the rebase of subsequent patches hard. Will be done after the remove of the getVolumeSize() call. Line 17: Line 18: Required to reduce the volume size functions proliferation. Line 19: Line 20: Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9 File vdsm/storage/blockSD.py Line 620: return False Line 621: return True Line 622: Line 623: def getVSize(self, imgUUID, volUUID): Line 624: """ Return the block volume size in bytes. Like st_size.""" Done Line 625: try: Line 626: size = _get_st_size(lvm.lvPath(self.sdUUID, volUUID)) Line 627: except IOError as e: Line 628: if e.errno == os.errno.ENOENT: Line 634: raise Line 635: Line 636: return size Line 637: Line 638: getVAllocSize = getVSize Will be addressed in a future patch. Line 639: Line 640: @classmethod Line 641: def validateCreateVolumeParams(cls, volFormat, preallocate, srcVolUUID): Line 642: """ -- To view, visit http://gerrit.ovirt.org/18202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getVolumeInfo() new implementation.
Eduardo has posted comments on this change. Change subject: getVolumeInfo() new implementation. .. Patch Set 3: (2 comments) Commit Message Line 5: CommitDate: 2013-09-16 04:46:09 +0300 Line 6: Line 7: getVolumeInfo() new implementation. Line 8: Line 9: BC compatibility preserved but in broken behaviours. The former semantic was incosistent but preserved. Logical impossibilities were removed if it was possible. Line 10: Line 11: Required to reduce the volume size functions proliferation. Line 12: Line 13: Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e File vdsm/storage/volume.py Line 895: else: Line 896: info = self.metadata2info(meta) Line 897: info["capacity"] = str(int(info["size"]) * BLOCK_SIZE) # Virtual Line 898: del info["size"] # Remove the virtual (by volMD) size [blocks] Line 899: if info['mtime'] == "" and self.__class__.__name__ == "FileVolume": They are operating on different files. Therefore we should not unify. Unfortunately this info dict is created only here and mix information of multiple sources and is created only here. Line 900: info['mtime'] = self.oop.os.stat(self.volumePath).st_mtime Line 901: # If image was set to illegal, mark the status same Line 902: # (because of VDC constraints) Line 903: if info['legality'] == ILLEGAL_VOL: -- To view, visit http://gerrit.ovirt.org/18233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: remove afterMigrationStatus
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: remove afterMigrationStatus .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4490/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4409/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3593/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60ffa2c30d091a548cd4ab42e67fc6b5c3f57b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: remove afterMigrationStatus
Martin Polednik has uploaded a new change for review. Change subject: vdsm: remove afterMigrationStatus .. vdsm: remove afterMigrationStatus Not supported by any vdsm anymore Change-Id: Ia60ffa2c30d091a548cd4ab42e67fc6b5c3f57b4 Signed-off-by: Martin Polednik --- M vdsm/vm.py 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/19306/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 92d274e..f356c08 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -192,10 +192,6 @@ self._machineParams.update(self._vm.status()) # patch VM config for targets < 3.1 self._patchConfigForLegacy() -if self._vm._guestCpuRunning: -self._machineParams['afterMigrationStatus'] = 'Up' -else: -self._machineParams['afterMigrationStatus'] = 'Pause' self._machineParams['elapsedTimeOffset'] = \ time.time() - self._vm._startTime vmStats = self._vm.getStats() @@ -3420,7 +3416,6 @@ self._domDependentInit() del self.conf['migrationDest'] -del self.conf['afterMigrationStatus'] hooks.after_vm_migrate_destination(self._dom.XMLDesc(0), self.conf) for dev in self._customDevices(): -- To view, visit http://gerrit.ovirt.org/19306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia60ffa2c30d091a548cd4ab42e67fc6b5c3f57b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix parent volume rollback after failure to create snapshot
Sergey Gotliv has posted comments on this change.
Change subject: Fix parent volume rollback after failure to create snapshot
..
Patch Set 6:
(3 comments)
File vdsm/storage/volume.py
Line 258:(self.volumePath, dst_path))
Line 259: self.prepare(rw=False)
Line 260: try:
Line 261: size = int(self.getMetaParam(SIZE))
Line 262: parent = self.getVolumePath()
Done
Line 263: parent_format = fmt2str(self.getFormat())
Line 264: # We should use parent's relative path instead of full
path
Line 265: parent =
os.path.join(os.path.basename(os.path.dirname(parent)),
Line 266: os.path.basename(parent))
Line 262: parent = self.getVolumePath()
Line 263: parent_format = fmt2str(self.getFormat())
Line 264: # We should use parent's relative path instead of full
path
Line 265: parent =
os.path.join(os.path.basename(os.path.dirname(parent)),
Line 266: os.path.basename(parent))
I will rebase this patch on top of Yeela's patch that removes prepare/teardown
from the clone, so the finally block will disappear.
Line 267: createVolume(parent, parent_format, dst_path,
Line 268: size, volFormat, preallocate)
Line 269: except Exception as e:
Line 270: self.log.error("Volume.clone: can't clone: %s to %s" %
Line 269: except Exception as e:
Line 270: self.log.error("Volume.clone: can't clone: %s to %s" %
Line 271:(self.volumePath, dst_path))
Line 272: raise se.CannotCloneVolume(self.volumePath, dst_path,
str(e))
Line 273: else:
I will rebase this patch on top of Yeela's patch that removes prepare/teardown
from the clone, so the finally block will disappear.
Line 274: if self.isLeaf():
Line 275: taskName = "parent volume rollback: " + self.volUUID
Line 276: vars.task.pushRecovery(
Line 277: task.Recovery(taskName, "volume", "Volume",
--
To view, visit http://gerrit.ovirt.org/18205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11948aacad21008ffbb4cb23013bf363e60bdb9b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: skip mkimageTests when mkisofs and mkfs.msdos don't e...
Jarod.w has posted comments on this change. Change subject: tests: skip mkimageTests when mkisofs and mkfs.msdos don't exist .. Patch Set 2: (1 comment) Commit Message Line 4: Commit: jarod.w Line 5: CommitDate: 2013-09-09 14:07:00 +0800 Line 6: Line 7: tests: skip mkimageTests when mkisofs and mkfs.msdos don't exist Line 8: In some cases, we don't need to build srpms, but install directly it using the following command: ./autogen.sh && make && make check && make install If so, we can't get any clue to install the packages. Line 9: Change-Id: I192707f466203786cd0864c8ca7c9e5070867523 -- To view, visit http://gerrit.ovirt.org/18984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I192707f466203786cd0864c8ca7c9e5070867523 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jarod.w Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jarod.w Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix parent volume rollback after failure to create snapshot
Federico Simoncelli has posted comments on this change.
Change subject: Fix parent volume rollback after failure to create snapshot
..
Patch Set 6:
(1 comment)
File vdsm/storage/volume.py
Line 262: parent = self.getVolumePath()
Line 263: parent_format = fmt2str(self.getFormat())
Line 264: # We should use parent's relative path instead of full
path
Line 265: parent =
os.path.join(os.path.basename(os.path.dirname(parent)),
Line 266: os.path.basename(parent))
Anything could raise an exception there (KeyError in fmt2str, etc.). I'm not a
fan of exceptions translation/masking. The CannotCloneVolume exception is not
helping the engine: what difference it makes at what step we failed? We weren't
able to create a volume (which required cloning, but that's not interesting).
Even more, if we translate it to CannotCloneVolume it is even misleading as the
real error would be a metadata corruption (as the size is not a base-10 integer
or the format is unknown).
For as much as I know the exception translation could be removed:
def clone(...):
(prepare the needed variables)
self.prepare(rw=False)
try:
createVolume(...)
finally:
self.teardown(...)
if self.isLeaf():
...
Line 267: createVolume(parent, parent_format, dst_path,
Line 268: size, volFormat, preallocate)
Line 269: except Exception as e:
Line 270: self.log.error("Volume.clone: can't clone: %s to %s" %
--
To view, visit http://gerrit.ovirt.org/18205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11948aacad21008ffbb4cb23013bf363e60bdb9b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix parent volume rollback after failure to create snapshot
Nir Soffer has posted comments on this change.
Change subject: Fix parent volume rollback after failure to create snapshot
..
Patch Set 6: Code-Review-1
(5 comments)
Too big - trying to fix two unrelated issues, and having misleading commit
message.
Commit Message
Line 3: AuthorDate: 2013-08-21 20:49:35 +0300
Line 4: Commit: Sergey Gotliv
Line 5: CommitDate: 2013-09-15 15:16:10 +0300
Line 6:
Line 7: Fix parent volume rollback after failure to create snapshot
The code is fixing parent volume rollback *and* clone.
The message is missing a detailed description of both changes - see comments in
the code for missing details.
Line 8:
Line 9: Change-Id: I11948aacad21008ffbb4cb23013bf363e60bdb9b
Line 10: Bug-Url: https://bugzilla.redhat.com/982004
File vdsm/storage/volume.py
Line 248
Line 249
Line 250
Line 251
Line 252
I would separate this change into its own patch about fixing clone.
The commit message should describe what was wrong in the previous code and how
the new code improve the situation.
Line 325
Line 326
Line 327
Line 328
Line 329
This method looks good now - I would split it to separate patch. Fixing parent
rollback is different from fixing code calling it.
Regarding this change - the commit message should describe:
- Why prepare is needed
- Why the call to pvol.isShared() was removed
- Why the call to pvol.setLeaf() was removed.
Some of the answers are in other comments but the info is hard to find.
Line 258:(self.volumePath, dst_path))
Line 259: self.prepare(rw=False)
Line 260: try:
Line 261: size = int(self.getMetaParam(SIZE))
Line 262: parent = self.getVolumePath()
This is not parent - rename to path?
Line 263: parent_format = fmt2str(self.getFormat())
Line 264: # We should use parent's relative path instead of full
path
Line 265: parent =
os.path.join(os.path.basename(os.path.dirname(parent)),
Line 266: os.path.basename(parent))
Line 262: parent = self.getVolumePath()
Line 263: parent_format = fmt2str(self.getFormat())
Line 264: # We should use parent's relative path instead of full
path
Line 265: parent =
os.path.join(os.path.basename(os.path.dirname(parent)),
Line 266: os.path.basename(parent))
Line 261 may raise ValueError - do we want this error to raise
CannotCloneVolume in this case or ValueError?
Line 267: createVolume(parent, parent_format, dst_path,
Line 268: size, volFormat, preallocate)
Line 269: except Exception as e:
Line 270: self.log.error("Volume.clone: can't clone: %s to %s" %
--
To view, visit http://gerrit.ovirt.org/18205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11948aacad21008ffbb4cb23013bf363e60bdb9b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor StoragePool.getPoolParams()
Eduardo has posted comments on this change.
Change subject: Refactor StoragePool.getPoolParams()
..
Patch Set 2:
(3 comments)
Commit Message
Line 3: AuthorDate: 2013-09-13 12:40:03 +0300
Line 4: Commit: Eduardo Warszawski
Line 5: CommitDate: 2013-09-15 15:05:25 +0300
Line 6:
Line 7: Refactor StoragePool.getPoolParams()
Because is ugly, error prone and is needed for the HE project.
Line 8:
Line 9: Change-Id: Ibbeaaaf67a39f3ca8b27252fc631a91f266d1adc
File vdsm/storage/hsm.py
Line 379: # exist under pool link as well (for hsm tasks)
Line 380: self.taskMng.loadDumpedTasks(self.tasksDir)
Line 381: self.taskMng.recoverDumpedTasks()
Line 382:
Line 383: poolDirs = os.listdir(self._poolsTmpDir)
line ~113 _poolsTmpDir = config.get('irs', 'pools_data_dir')
It is a class attribute
Line 384: for spUUID in poolDirs:
Line 385: poolPath = os.path.join(self.storage_repository,
spUUID)
Line 386: poolParamFile = os.path.join(self._poolsTmpDir,
spUUID)
Line 387: if os.path.exists(poolPath):
Line 400: self.log.error("Connection to SP %s
failed",
Line 401:spUUID, exc_info=True)
Line 402: else:
Line 403: # TODO Once we support simultaneous
connection to
Line 404: # multiple pools, remove following line
(break)
You can try: _connectStoragePool(), but break can not raise.
Therefore it is separated.
The whole loop is redundant since support for multiple pools will not be added.
Line 405: break
Line 406:
Line 407: storageRefreshThread = threading.Thread(target=storageRefresh,
Line 408: name="storageRefresh")
--
To view, visit http://gerrit.ovirt.org/19232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbeaaaf67a39f3ca8b27252fc631a91f266d1adc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Elad Ben Aharon
Gerrit-Reviewer: Gadi Ickowicz
Gerrit-Reviewer: Meital Bourvine
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduce lvm short filters.
Eduardo has posted comments on this change. Change subject: Introduce lvm short filters. .. Patch Set 3: Verified+1 Following CLI (only) commands tested. Tested from CLI only with: connectStorageServer getStorageDomainsList getImagesList getStorageDomainInfo createStoragePool spmStart extendStorageDomain Since this patch influence each single lvm command more tests are required. -- To view, visit http://gerrit.ovirt.org/17968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26f3a7c712b6d7009f5f4e945374b62f18483889 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Normalize lvm._buildFilter().
Eduardo has posted comments on this change. Change subject: Normalize lvm._buildFilter(). .. Patch Set 2: Verified+1 Following CLI (only) commands tested. Tested from CLI only with: connectStorageServer getStorageDomainsList getImagesList getStorageDomainInfo createStoragePool spmStart extendStorageDomain Since this patch influence each single lvm command more tests are required. -- To view, visit http://gerrit.ovirt.org/17966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c0a5c61ba6754db996b2c88b32bedee852df22f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduce lvm short filters.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introduce lvm short filters. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4489/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4408/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3592/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26f3a7c712b6d7009f5f4e945374b62f18483889 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath.getMPDevNamesIter() return /dev/mapper.
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath.getMPDevNamesIter() return /dev/mapper. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4488/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4407/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3591/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ec54147205992ac130684d01e73cd7aceccad48 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Normalize lvm._buildFilter().
oVirt Jenkins CI Server has posted comments on this change. Change subject: Normalize lvm._buildFilter(). .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4487/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4406/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3590/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c0a5c61ba6754db996b2c88b32bedee852df22f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath.getMPDevNamesIter() return /dev/mapper.
Eduardo has posted comments on this change. Change subject: multipath.getMPDevNamesIter() return /dev/mapper. .. Patch Set 2: Verified+1 Following CLI (only) commands tested. Tested from CLI only with: connectStorageServer getStorageDomainsList getImagesList getStorageDomainInfo createStoragePool spmStart extendStorageDomain Since this patch influence each single lvm command more tests are required. -- To view, visit http://gerrit.ovirt.org/17967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ec54147205992ac130684d01e73cd7aceccad48 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report bond speed as function of slaved nics speed and bond ...
Amador Pahim has uploaded a new change for review.
Change subject: Report bond speed as function of slaved nics speed and bond mode
..
Report bond speed as function of slaved nics speed and bond mode
Currently bond interfaces are always assumed to have 1GB of speed,
reflecting in inaccurate network usage calculations.
This patch add bond speed probe to netinfo.speed(), considering bond
mode and slaved nics speed:
Failover modes: 1 and 3
Bond speed = active slaved nic speed.
Load Balance modes: 0, 2, 4, 5 and 6
Bond speed = all slaved nics speed summed up.
Change-Id: Ide077846e49ac5e4d759a85ff9d5c6cec653aa18
Bug-Url: https://bugzilla.redhat.com/1007860
Signed-off-by: Amador Pahim
---
M lib/vdsm/netinfo.py
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/19297/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index ba78dc9..885740b 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -297,6 +297,22 @@
s = int(speedFile.read())
if s not in (2 ** 16 - 1, 2 ** 32 - 1) or s > 0:
return s
+
+# bondings() lists bond devices
+if dev in bondings():
+bond_options = bondOpts(dev)
+# only bonds with slaved nics will be probed
+if bond_options['slaves']:
+# failover modes
+if bond_options['mode'][1] in ['1', '3']:
+s = speed(bond_options['active_slave'][0])
+# load balance modes
+elif bond_options['mode'][1] in ['0', '2', '4', '5', '6']:
+s = 0
+for slave in bond_options['slaves']:
+s += speed(slave)
+return s
+
except Exception:
logging.exception('cannot read %s speed', dev)
return 0
--
To view, visit http://gerrit.ovirt.org/19297
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide077846e49ac5e4d759a85ff9d5c6cec653aa18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report bond speed as function of slaved nics speed and bond ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Report bond speed as function of slaved nics speed and bond mode .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4486/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4405/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3589/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide077846e49ac5e4d759a85ff9d5c6cec653aa18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Ryan Harper Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: reduce the time VM is paused in snapshot with RAM creation .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4485/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4404/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3588/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: fix updateVolumeSize for raw volumes
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: fix updateVolumeSize for raw volumes .. hsm: fix updateVolumeSize for raw volumes Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/19279 Reviewed-by: Sergey Gotliv Tested-by: Sergey Gotliv Reviewed-by: Dan Kenigsberg --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sergey Gotliv: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: fix updateVolumeSize for raw volumes
Dan Kenigsberg has posted comments on this change. Change subject: hsm: fix updateVolumeSize for raw volumes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation
Arik Hadas has uploaded a new change for review. Change subject: reduce the time VM is paused in snapshot with RAM creation .. reduce the time VM is paused in snapshot with RAM creation By using libvirt's VIR_DOMAIN_SNAPSHOT_CREATE_LIVE flag we minimize the time the VM is switched to paused state while creating live snapshot with RAM. Without this flag the VM is switched to pause state for the whole process of dumping the memory, and with this flag the VM is switched to pause state only for a short time. Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c Signed-off-by: Arik Hadas --- M vdsm/vm.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/19296/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 92d274e..6dece1f 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -3668,6 +3668,8 @@ memoryVol = memoryParams['dst'] memoryVolPath = self.cif.prepareVolumePath(memoryVol) snap.appendChild(_memorySnapshot(memoryVolPath)) + +snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_LIVE else: snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY -- To view, visit http://gerrit.ovirt.org/19296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/3] - Save running config
Antoni Segura Puimedon has posted comments on this change.
Change subject: Unified network persistence [1/3] - Save running config
..
Patch Set 22:
(7 comments)
File lib/vdsm/unifiedpersistence.py
Line 14: # You should have received a copy of the GNU General Public License
Line 15: # along with this program; if not, write to the Free Software
Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Done
Line 19: #
Line 20:
Line 21: import errno
Line 22: import json
Line 34: def __init__(self, savePath):
Line 35: self.networksPath = savePath + 'nets/'
Line 36: self.bondingsPath = savePath + 'bonds/'
Line 37: self.networks = self._getConfigs(self.networksPath)
Line 38: self.bonds = self._getConfigs(self.bondingsPath)
The model I aim for is to have a runningConfig instance A (created on
instantiation) and an instance B( created upon transaction beginning). If the
transaction is successful, commit will make B take the place of A, otherwise,
the changes to revert will be described by A-B. This will be done in a later
patch.
Line 39:
Line 40: def __eq__(self, other):
Line 41: return self.networks == other.networks and self.bonds ==
other.bonds
Line 42:
Line 39:
Line 40: def __eq__(self, other):
Line 41: return self.networks == other.networks and self.bonds ==
other.bonds
Line 42:
Line 43: def __repr(self):
Done
Line 44: return '%s(%s, %s)' % (self.__class__.__name__, self.networks,
Line 45:self.bonds)
Line 46:
Line 47: def _networkPath(self, network):
Line 70: fullPath = path + fileName
Line 71: networkEntities[fileName] =
self._getConfigDict(fullPath)
Line 72: except OSError as ose:
Line 73: if ose.errno == errno.ENOENT:
Line 74: logging.debug('Unified persistence: No existent config
set.')
Done
Line 75: else:
Line 76: raise
Line 77:
Line 78: return networkEntities
Line 78: return networkEntities
Line 79:
Line 80: def _setConfig(self, config, path):
Line 81: dirPath = os.path.dirname(path)
Line 82: if not os.path.exists(dirPath):
Done
Line 83: os.makedirs(dirPath)
Line 84: with open(path, 'w') as configurationFile:
Line 85: json.dump(config, configurationFile)
Line 86:
Line 85: json.dump(config, configurationFile)
Line 86:
Line 87: def _removeConfig(self, path):
Line 88: try:
Line 89: os.unlink(path)
Done
Line 90: except OSError as ose:
Line 91: if ose.errno == errno.ENOENT:
Line 92: logging.debug('Unified persistence: Network entity at
%s not '
Line 93: 'found for removal' % path)
Line 100: if value is not None and key not in
Line 101: ('configurator', '_netinfo', 'force',
Line 102:'implicitBonding'))
Line 103: self.networks[network] = cleanAttrs
Line 104: logging.info('Unified persistence: Adding network %s(%s)' %
Done
Line 105: (network, cleanAttrs))
Line 106:
Line 107: def removeNetwork(self, network):
Line 108: try:
--
To view, visit http://gerrit.ovirt.org/16699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Petr Šebek
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4484/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4403/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3587/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/3] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/3] - Save running config .. Patch Set 23: Addressed comments to previous patch set and changed some methods to be staticmethod. -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing
Dan Kenigsberg has uploaded a new change for review. Change subject: caps: coarse-grain libvirt.rpm may be missing .. caps: coarse-grain libvirt.rpm may be missing As of http://gerrit.ovirt.org/15761 we no longer require the legacy libvirt.rpm to be installed on Fedora, so getCaps should not look for it. Without this patch we get an annoying (_getKeyPackages) rpm package libvirt not found log message, and do not report libvirt's version. Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Signed-off-by: Dan Kenigsberg --- M vdsm/caps.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/19295/1 diff --git a/vdsm/caps.py b/vdsm/caps.py index 3a7a6a2..ceea429 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -331,6 +331,9 @@ 'mom': 'mom', } +if getos() in (OSName.OVIRT, OSName.FEDORA): +KEY_PACKAGES['libvirt-daemon-kvm'] + if _glusterEnabled: KEY_PACKAGES.update(GLUSTER_RPM_PACKAGES) -- To view, visit http://gerrit.ovirt.org/19295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/3] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/3] - Save running config .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4483/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4402/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3586/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: deleteImage fails because of wrong dictionary use
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: deleteImage fails because of wrong dictionary use .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4482/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4401/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3585/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81f9a5aa63c0914e3b934046454df64ccd39c269 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: when creating fake template get template params before ...
Yeela Kaplan has abandoned this change. Change subject: hsm: when creating fake template get template params before deleting .. Abandoned rebased into another change. -- To view, visit http://gerrit.ovirt.org/19286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I535f29f1f956afaf28f6f496a240aa75abf1ed70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: deleteImage fails because of wrong dictionary use
Yeela Kaplan has posted comments on this change. Change subject: hsm: deleteImage fails because of wrong dictionary use .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/17383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81f9a5aa63c0914e3b934046454df64ccd39c269 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: when creating fake template get template params before ...
Ayal Baron has posted comments on this change. Change subject: hsm: when creating fake template get template params before deleting .. Patch Set 1: (1 comment) Please merge this with the previous patch as they are not standalone. File vdsm/storage/hsm.py Line 1536: if misc.parseBool(postZero): Line 1537: # postZero implies block domain. Backup domains are always NFS Line 1538: # hence no need to create fake template if postZero is true. Line 1539: self._spmSchedule(spUUID, "zeroImage_%s" % imgUUID, dom.zeroImage, Line 1540: sdUUID, imgUUID, volsByImg) Ok, reading the comment above explains this, nm. Line 1541: else: Line 1542: if fakeTUUID: Line 1543: tParams = dom.produceVolume(imgUUID, fakeTUUID).\ Line 1544: getVolumeParams() -- To view, visit http://gerrit.ovirt.org/19286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I535f29f1f956afaf28f6f496a240aa75abf1ed70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: fix updateVolumeSize for raw volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: fix updateVolumeSize for raw volumes .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4400/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3584/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: fix updateVolumeSize for raw volumes
Sergey Gotliv has posted comments on this change. Change subject: hsm: fix updateVolumeSize for raw volumes .. Patch Set 2: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: when creating fake template get template params before ...
Ayal Baron has posted comments on this change. Change subject: hsm: when creating fake template get template params before deleting .. Patch Set 1: Code-Review+1 While reviewing now it looks like although this is a bit better than current situation, we are not handling the postZero case at all (unless I'm missing something). -- To view, visit http://gerrit.ovirt.org/19286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I535f29f1f956afaf28f6f496a240aa75abf1ed70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: when creating fake template get template params before ...
Ayal Baron has posted comments on this change. Change subject: hsm: when creating fake template get template params before deleting .. Patch Set 1: Code-Review-1 (1 comment) File vdsm/storage/hsm.py Line 1536: if misc.parseBool(postZero): Line 1537: # postZero implies block domain. Backup domains are always NFS Line 1538: # hence no need to create fake template if postZero is true. Line 1539: self._spmSchedule(spUUID, "zeroImage_%s" % imgUUID, dom.zeroImage, Line 1540: sdUUID, imgUUID, volsByImg) what's creating the fake template in postZero case? Line 1541: else: Line 1542: if fakeTUUID: Line 1543: tParams = dom.produceVolume(imgUUID, fakeTUUID).\ Line 1544: getVolumeParams() -- To view, visit http://gerrit.ovirt.org/19286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I535f29f1f956afaf28f6f496a240aa75abf1ed70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: fix updateVolumeSize for qcow2 volumes
Sergey Gotliv has posted comments on this change. Change subject: hsm: fix updateVolumeSize for qcow2 volumes .. Patch Set 1: Verified+1 (1 comment) Commit Message Line 4: Commit: Federico Simoncelli Line 5: CommitDate: 2013-09-16 08:41:51 -0400 Line 6: Line 7: hsm: fix updateVolumeSize for qcow2 volumes Line 8: Please, change description to "not qcow2" volumes Line 9: Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 -- To view, visit http://gerrit.ovirt.org/19279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sos/vdsm.py: Collect /etc/vdsm permissions
oVirt Jenkins CI Server has posted comments on this change. Change subject: sos/vdsm.py: Collect /etc/vdsm permissions .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4399/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3583/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17371a82340f64df285bb4dda650e571899ca02f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sos/vdsm.py: Collect /etc/vdsm permissions
Douglas Schilling Landgraf has posted comments on this change. Change subject: sos/vdsm.py: Collect /etc/vdsm permissions .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/19227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17371a82340f64df285bb4dda650e571899ca02f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: when creating fake template get template params before ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: when creating fake template get template params before deleting .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4479/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4398/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3582/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I535f29f1f956afaf28f6f496a240aa75abf1ed70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: deleteImage fails because of wrong dictionary use
Yeela Kaplan has posted comments on this change. Change subject: hsm: deleteImage fails because of wrong dictionary use .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/17383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81f9a5aa63c0914e3b934046454df64ccd39c269 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: fix updateVolumeSize for qcow2 volumes
Sergey Gotliv has posted comments on this change. Change subject: hsm: fix updateVolumeSize for qcow2 volumes .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: when creating fake template get template params before ...
Yeela Kaplan has posted comments on this change. Change subject: hsm: when creating fake template get template params before deleting .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I535f29f1f956afaf28f6f496a240aa75abf1ed70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: when creating fake template get template params before ...
Yeela Kaplan has uploaded a new change for review. Change subject: hsm: when creating fake template get template params before deleting .. hsm: when creating fake template get template params before deleting Change-Id: I535f29f1f956afaf28f6f496a240aa75abf1ed70 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=964649 Signed-off-by: Yeela Kaplan --- M vdsm/storage/hsm.py 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/19286/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 8660b9b..c8604dc 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1539,6 +1539,9 @@ self._spmSchedule(spUUID, "zeroImage_%s" % imgUUID, dom.zeroImage, sdUUID, imgUUID, volsByImg) else: +if fakeTUUID: +tParams = dom.produceVolume(imgUUID, fakeTUUID).\ +getVolumeParams() dom.deleteImage(sdUUID, imgUUID, volsByImg) # This is a hack to keep the interface consistent # We currently have race conditions in delete image, to quickly fix @@ -1550,8 +1553,6 @@ if fakeTUUID: img = image.Image(os.path.join(self.storage_repository, spUUID)) -tParams = dom.produceVolume(imgUUID, fakeTUUID).\ -getVolumeParams() img.createFakeTemplate(sdUUID=sdUUID, volParams=tParams) self._spmSchedule(spUUID, "deleteImage_%s" % imgUUID, lambda: True) -- To view, visit http://gerrit.ovirt.org/19286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I535f29f1f956afaf28f6f496a240aa75abf1ed70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: imageSharing: return proper size in httpGetSize
Federico Simoncelli has posted comments on this change. Change subject: imageSharing: return proper size in httpGetSize .. Patch Set 1: Verified+1 Code-Review+2 Same as master. -- To view, visit http://gerrit.ovirt.org/19284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbcc601767d7f5b044b9e0e32f35abccdfb5746b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: imageSharing: return proper size in httpGetSize
Federico Simoncelli has submitted this change and it was merged. Change subject: imageSharing: return proper size in httpGetSize .. imageSharing: return proper size in httpGetSize When importing images from OpenStack Glance the Content-Length is 0 so we need to override the value with the content of the custom header X-Image-Meta-Size. Change-Id: Icbcc601767d7f5b044b9e0e32f35abccdfb5746b Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/19222 Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/19284 --- M vdsm/storage/imageSharing.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Federico Simoncelli: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbcc601767d7f5b044b9e0e32f35abccdfb5746b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: imageSharing: return proper size in httpGetSize
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19284
to review the following change.
Change subject: imageSharing: return proper size in httpGetSize
..
imageSharing: return proper size in httpGetSize
When importing images from OpenStack Glance the Content-Length is 0
so we need to override the value with the content of the custom header
X-Image-Meta-Size.
Change-Id: Icbcc601767d7f5b044b9e0e32f35abccdfb5746b
Signed-off-by: Federico Simoncelli
Reviewed-on: http://gerrit.ovirt.org/19222
Reviewed-by: Dan Kenigsberg
---
M vdsm/storage/imageSharing.py
1 file changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/19284/1
diff --git a/vdsm/storage/imageSharing.py b/vdsm/storage/imageSharing.py
index 5db0a4e..26f299a 100644
--- a/vdsm/storage/imageSharing.py
+++ b/vdsm/storage/imageSharing.py
@@ -29,11 +29,18 @@
headers = curlImgWrap.head(methodArgs.get('url'),
methodArgs.get("headers", {}))
+size = None
+
if 'Content-Length' in headers:
size = int(headers['Content-Length'])
-elif 'X-Image-Meta-Size' in headers:
-size = int(headers['X-Image-Meta-Size'])
-else:
+
+# OpenStack Glance returns Content-Length = 0 so we need to
+# override the value with the content of the custom header
+# X-Image-Meta-Size.
+if 'X-Image-Meta-Size' in headers:
+size = max(size, int(headers['X-Image-Meta-Size']))
+
+if size is None:
raise RuntimeError("Unable to determine image size")
return size
--
To view, visit http://gerrit.ovirt.org/19284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbcc601767d7f5b044b9e0e32f35abccdfb5746b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: fix updateVolumeSize for qcow2 volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: fix updateVolumeSize for qcow2 volumes .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4478/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4397/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3581/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: fix updateVolumeSize for qcow2 volumes
Federico Simoncelli has uploaded a new change for review. Change subject: hsm: fix updateVolumeSize for qcow2 volumes .. hsm: fix updateVolumeSize for qcow2 volumes Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Signed-off-by: Federico Simoncelli --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/19279/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 744a855..6210912 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -696,7 +696,7 @@ if volFormat != volume.COW_FORMAT: # This method is used only with COW volumes (see docstring), # for RAW volumes we just return the volume size. -return dict(size=str(self.getVolumeSize(bs=1))) +return dict(size=str(volToExtend.getVolumeSize(bs=1))) qemuImgFormat = volume.fmt2str(volume.COW_FORMAT) -- To view, visit http://gerrit.ovirt.org/19279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I08aa24277d11595e82c93b979c2c34fcf9d09c38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Text: add 'dstqemu' to vds client migration command description
oVirt Jenkins CI Server has posted comments on this change. Change subject: Text: add 'dstqemu' to vds client migration command description .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4477/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4396/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3580/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Text: add 'dstqemu' to vds client migration command description
mooli tayer has uploaded a new change for review.
Change subject: Text: add 'dstqemu' to vds client migration command description
..
Text: add 'dstqemu' to vds client migration command description
Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007686
Signed-off-by: Mooli Tayer
---
M client/vdsClient.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/19277/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 590b1e7..bddfaa1 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1957,8 +1957,8 @@
' name:value,name:value'
)),
'migrate': (serv.do_migrate,
-('vmId= method= src= '
- 'dst=',
+('vmId= method= src= '
+ 'dst= dstqemu=',
'Migrate a desktop from src machine to dst host using '
'the specified ports'
)),
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Iscsi rescan cleanup
oVirt Jenkins CI Server has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4476/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4395/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3579/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move fencing logic out of API.py
Saggi Mizrahi has posted comments on this change. Change subject: Move fencing logic out of API.py .. Patch Set 7: (1 comment) test File vdsm/fenceAgent.py Line 60:'passwd=%s\n') % (agent, addr, username, action, password) Line 61: Line 62: if bladePort: Line 63: inp += 'port=%d\n' % (bladePort,) Line 64: it can't be passthrough anymore, we're going typesafe :). I'll just have it be a string. Line 65: if secure: Line 66: inp += 'secure=yes\n' Line 67: Line 68: inp += options -- To view, visit http://gerrit.ovirt.org/7190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Infra: Create AsyncProcessOperation
oVirt Jenkins CI Server has posted comments on this change. Change subject: Infra: Create AsyncProcessOperation .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4475/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4394/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3578/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup of vm.py
Michal Skrivanek has posted comments on this change. Change subject: cleanup of vm.py .. Patch Set 13: -Code-Review (2 comments) +1 on a break up File vdsm/vm.py Line 1964 Line 1965 Line 1966 Line 1967 Line 1968 I'm sure. It was introduced after the new devices framework was already in place so it's useless Line 190: Line 191: def _setupRemoteMachineParams(self): Line 192: self._machineParams.update(self._vm.status()) Line 193: # patch VM config for targets < 3.1 Line 194: self._patchConfigForLegacy() IIRC we checked and it was only in vdsm 2.3. Line 195: self._machineParams['elapsedTimeOffset'] = \ Line 196: time.time() - self._vm._startTime Line 197: vmStats = self._vm.getStats() Line 198: if 'username' in vmStats: -- To view, visit http://gerrit.ovirt.org/18047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2712148b670c9f85beaea40a0b2e870d829b2b4b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4474/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4393/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3577/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Dan Kenigsberg has submitted this change and it was merged. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Removing automatic restart of services in libvirt-reconfigure libvirt-reconfigure also restarted libvirtd as post reconfigure operation. The restart is required but there is no reason and its not expected to perform it automatically as part of the reconfigure operation. Restart also required to supervdsmd service (as described in the Bug-Url). Instead of restarting both, this patch prints message to user to preform the restart manually. To make it easier and centralized the patch also adds libvirt-configure-services-restart command that restart related services after reconfigure. For backward compatibility with systemd, this also update systemd-vdsmd script to restart libvirtd and supervdsmd services in previous versions. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999853 Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Signed-off-by: Yaniv Bronhaim Reviewed-on: http://gerrit.ovirt.org/18780 Reviewed-by: Zhou Zheng Sheng Reviewed-by: Dan Kenigsberg --- M init/systemd/systemd-vdsmd.in M init/sysvinit/vdsmd.init.in M lib/vdsm/tool/libvirt_configure.py M lib/vdsm/tool/libvirt_configure.sh.in 4 files changed, 28 insertions(+), 8 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup of vm.py
Dan Kenigsberg has posted comments on this change. Change subject: cleanup of vm.py .. Patch Set 13: Code-Review-1 (5 comments) Thanks, we need your will to clean this huge file. However, for a proper review, I have to ask you to break this patch to several self-contained single-topic patches. Some of the changes here carry a considerable challenge to backward compatibility, and have to be carefully scrutinized. File vdsm/vm.py Line 1869 Line 1870 Line 1871 Line 1872 Line 1873 this is another delicate spot in the code. If you suggest to drop this function - do it in a separate patch and have Eduardo review it. Line 1964 Line 1965 Line 1966 Line 1967 Line 1968 Are you sure this API is not used? Drop it in a separate patch with a comment explaining why its time has arrived. Line 190: Line 191: def _setupRemoteMachineParams(self): Line 192: self._machineParams.update(self._vm.status()) Line 193: # patch VM config for targets < 3.1 Line 194: self._patchConfigForLegacy() Are you sure no supported old Vdsm expects afterMigrationStatus ? This kind of change deserves a patch for its own. Line 195: self._machineParams['elapsedTimeOffset'] = \ Line 196: time.time() - self._vm._startTime Line 197: vmStats = self._vm.getStats() Line 198: if 'username' in vmStats: Line 1779: if 'device' not in drv: Line 1780: drv['device'] = 'disk' Line 1781: Line 1782: if drv['device'] == 'disk': Line 1783: res = self.cif.irs.getVolumeSize(drv['domainID'], formatting changes should be kept to a separate patch from functional ones (unless they touch the very same lines). Line 1784: drv['poolID'], Line 1785: drv['imageID'], Line 1786: drv['volumeID']) Line 1787: try: Line 2846: for dev in devices.values(): Line 2847: newDevices.extend(dev) Line 2848: Line 2849: with self._confLock: Line 2850: self.conf['devices'] = newDevices In CPython, a single assignment is atomic anyway - why do you need to take this lock? Line 2851: # We need to save conf here before we actually run VM. Line 2852: # It's not enough to save conf only on status changes as we did Line 2853: # before, because if vdsm will restarted between VM run and conf Line 2854: # saving we will fail in inconsistent state during recovery. -- To view, visit http://gerrit.ovirt.org/18047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2712148b670c9f85beaea40a0b2e870d829b2b4b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Fix the mtu of bond/nic not being set for new network
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Fix the mtu of bond/nic not being set for new network .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4473/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3576/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4392/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd534 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup of vm.py
Michal Skrivanek has posted comments on this change. Change subject: cleanup of vm.py .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2712148b670c9f85beaea40a0b2e870d829b2b4b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Yaniv Bronhaim has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Iscsi rescan cleanup
oVirt Jenkins CI Server has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4472/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3575/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4391/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4471/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4390/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tests: Fixed resource manager stress test
Dan Kenigsberg has posted comments on this change.
Change subject: Tests: Fixed resource manager stress test
..
Patch Set 2:
(1 comment)
File vdsm.spec.in
Line 97: Requires: python-netaddr
Line 98: Requires: python-inotify
Line 99: Requires: python-argparse
Line 100: Requires: python-ethtool >= 0.6-3
Line 101: Requires: vdsm-zombiereaper = %{version}-%{release}
this should sit in the next patch, right?
Line 102: Requires: rpm-python
Line 103: Requires: nfs-utils
Line 104: Requires: m2crypto
Line 105: Requires: libguestfs-tools-c
--
To view, visit http://gerrit.ovirt.org/19252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba095724a251968c8d5b2767e6491825d79297e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Dan Kenigsberg has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Iscsi rescan cleanup
oVirt Jenkins CI Server has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4470/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3573/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4389/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: imageSharing: return proper size in httpGetSize
Dan Kenigsberg has posted comments on this change. Change subject: imageSharing: return proper size in httpGetSize .. Patch Set 1: Code-Review+2 Missing the true Content-Length is probably a Glance bug that should be fixed there. "But we have to work with what we have" -- To view, visit http://gerrit.ovirt.org/19222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbcc601767d7f5b044b9e0e32f35abccdfb5746b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: imageSharing: return proper size in httpGetSize
Dan Kenigsberg has submitted this change and it was merged. Change subject: imageSharing: return proper size in httpGetSize .. imageSharing: return proper size in httpGetSize When importing images from OpenStack Glance the Content-Length is 0 so we need to override the value with the content of the custom header X-Image-Meta-Size. Change-Id: Icbcc601767d7f5b044b9e0e32f35abccdfb5746b Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/19222 Reviewed-by: Dan Kenigsberg --- M vdsm/storage/imageSharing.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbcc601767d7f5b044b9e0e32f35abccdfb5746b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: more combinations mtu combinations
Antoni Segura Puimedon has posted comments on this change.
Change subject: net tests: more combinations mtu combinations
..
Patch Set 1: Code-Review+1
(1 comment)
Only minor orthography question.
File tests/functional/networkTests.py
Line 1124:
dict(remove=True)},
Line 1125: {})
Line 1126: self.assertEquals(status, SUCCESS, msg)
Line 1127:
Line 1128: def _createVlanedNetOverNicAndCheck(self, netNum, bridged,
**networkOpts):
Shouldn't it be vlanned instead of vlaned?
Line 1129: netName = NETWORK_NAME + str(netNum)
Line 1130: networks = {netName: dict(bridged=bridged,
Line 1131: vlan=str(int(VLAN_ID) + netNum),
Line 1132: **networkOpts)}
--
To view, visit http://gerrit.ovirt.org/19230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd535
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Fix the mtu of bond/nic not being set for new network
Dan Kenigsberg has submitted this change and it was merged. Change subject: netconf: Fix the mtu of bond/nic not being set for new network .. netconf: Fix the mtu of bond/nic not being set for new network The configuring should not be skipped if the new vlaned network over the bond or nic has a bigger mtu than current. This patch fixes the testSetupNetworksMtus functional test, broken by http://gerrit.ovirt.org/17491. Bug-Url: https://bugzilla.redhat.com/1004196 Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd534 Signed-off-by: Mark Wu Signed-off-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/18966 Reviewed-by: Assaf Muller --- M vdsm/netmodels.py 1 file changed, 19 insertions(+), 10 deletions(-) Approvals: Assaf Muller: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd534 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Fix the mtu of bond/nic not being set for new network
Dan Kenigsberg has posted comments on this change. Change subject: netconf: Fix the mtu of bond/nic not being set for new network .. Patch Set 5: Verified+1 Code-Review+2 Thanks, Assaf (for the review) and Mark (for the bugfix). -- To view, visit http://gerrit.ovirt.org/18966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd534 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Fix the mtu of bond/nic not being set for new network
Assaf Muller has posted comments on this change. Change subject: netconf: Fix the mtu of bond/nic not being set for new network .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd534 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Infra: Create AsyncProcessOperation
oVirt Jenkins CI Server has posted comments on this change. Change subject: Infra: Create AsyncProcessOperation .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4469/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3572/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4388/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Fix the mtu of bond/nic not being set for new network
Dan Kenigsberg has posted comments on this change. Change subject: netconf: Fix the mtu of bond/nic not being set for new network .. Patch Set 4: (1 comment) File vdsm/netmodels.py Line 89: Line 90: super(Nic, self).__init__(name, configurator, ipconfig, Line 91: mtu=mtu) Line 92: Line 93: def configure(self, **opts): Yes, while re-writing this patch, in hope you would hate it a bit less, I found out that Mark made a mistake in his De Morgan application. Line 94: # in a limited condition, we should not touch the nic config Line 95: if (self.vlan and Line 96: netinfo.operstate(self.name) == netinfo.OPERSTATE_UP and Line 97: netinfo.NetInfo().ifaceUsers(self.name) and -- To view, visit http://gerrit.ovirt.org/18966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd534 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4468/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3571/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4387/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor StoragePool.getPoolParams()
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactor StoragePool.getPoolParams() .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4467/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3570/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4386/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeaaaf67a39f3ca8b27252fc631a91f266d1adc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Gadi Ickowicz Gerrit-Reviewer: Meital Bourvine Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] AsyncOpFix
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] AsyncOpFix .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3569/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie120c6b241aa45268b8e3d29110b51b39c30af50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: java_binding: Simplify bindings by using object mappers
mooli tayer has posted comments on this change.
Change subject: java_binding: Simplify bindings by using object mappers
..
Patch Set 6:
(8 comments)
Review still in process. one general comment:
This patch set is a good opportunity to introduce dependency injection -
consider it.
File client/java/pom.xml
Line 3: 4.0.0
Line 4: org.ovirt.vdsm
Line 5: vdsm-java-client
Line 6: 0.0.1-SNAPSHOT
Line 7: vdsm
vdsm client ?
Line 8: vdsm java client
Line 9: pom
Line 10:
Line 11: vdsm-json-rpc
File client/java/vdsm-api/src/main/java/org/ovirt/vdsm/RequestBuilder.java
Line 5: import org.ovirt.vdsm.jsonrpc.*;
Line 6:
Line 7: public class RequestBuilder {
Line 8:
Line 9: private String _id;
Please be consistent in ordering variables
(e.g static finals first, then finals, then instance variables)
Line 10: private static final ObjectMapper _objMapper;
Line 11: private final ObjectNode _parameters;
Line 12: private final String _methodName;
Line 13:
Line 12: private final String _methodName;
Line 13:
Line 14: static {
Line 15: _objMapper = new ObjectMapper();
Line 16: }
Why not do:
private static final ObjectMapper objMapper = new ObjectMapper();
Line 17:
Line 18: public RequestBuilder(String methodName) {
Line 19: _id = null;
Line 20: _parameters = _objMapper.createObjectNode();
Line 22: }
Line 23:
Line 24: public void id(String id) {
Line 25: _id = id;
Line 26: }
setId() ?
Line 27:
Line 28: public void addParameter(String name, String value) {
Line 29: _parameters.put(name, value);
Line 30: }
Line 50: }
Line 51:
Line 52: public void addParameter(String name, VDSMEnum value) {
Line 53: _parameters.put(name, value.toString());
Line 54: }
Consider
1.) Why not create a nice DSL here:
public RequestBuilder addParameter (String name, VDSMEnum value){
...
return this
}
then you can:
RequestBuilder requestBuilder = new RequestBuilder('kuku')
JsonRpcRequest jrb =requestBuilder.addParameter('pupu',8).
.addParameter('yuhu', 'Hi')
.addParameter('paka', ACTIVE)
.build();
2.)replacing all the above with:
public void addParameter(String name,T value){...}
Calling:
_parameters.put('kuku', 'pupu');
_parameters.put('VDSMEnumVak', BlockDevicePathState.Active.toString());
Line 55:
Line 56: public JsonRpcRequest build() {
Line 57: final TextNode id = _parameters.textNode(_id);
Line 58: return new JsonRpcRequest(_methodName, _parameters, id);
File client/java/vdsm-api/src/main/java/org/ovirt/vdsm/VDSMClientBase.java
Line 19: public void close() {
Line 20: _transport.close();
Line 21: }
Line 22:
Line 23: public boolean closed() {
getClosed() or isClosed()
Line 24: return _transport.closed();
Line 25: }
Line 26:
Line 27: protected Future> _call(RequestBuilder rb,
Line 36: public void connectTimeout(long timeout, TimeUnit unit) {
Line 37: _transport.connectTimeout(timeout, unit);
Line 38: }
Line 39:
Line 40: public URI uri() {
getUri()?
Line 41: return _transport.uri();
Line 42: }
Line 43:
Line 44: public String newID() {
Line 40: public URI uri() {
Line 41: return _transport.uri();
Line 42: }
Line 43:
Line 44: public String newID() {
generateId()?
Line 45: return UUID.randomUUID().toString();
Line 46: }
--
To view, visit http://gerrit.ovirt.org/17196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida303667cbba365bf14cc10147bbf507e3b730d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] AsyncOpFix
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] AsyncOpFix .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4466/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie120c6b241aa45268b8e3d29110b51b39c30af50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] AsyncOpFix
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] AsyncOpFix .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4464/ : ABORTED -- To view, visit http://gerrit.ovirt.org/19259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie120c6b241aa45268b8e3d29110b51b39c30af50 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] AsyncOpFix
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] AsyncOpFix .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3567/ : ABORTED -- To view, visit http://gerrit.ovirt.org/19259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie120c6b241aa45268b8e3d29110b51b39c30af50 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer was not passing kwargs to fuser
Saggi Mizrahi has posted comments on this change. Change subject: supervdsmServer was not passing kwargs to fuser .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix parent volume rollback after failure to create snapshot
Federico Simoncelli has posted comments on this change.
Change subject: Fix parent volume rollback after failure to create snapshot
..
Patch Set 6: Code-Review+1
(2 comments)
Small nits
File vdsm/storage/volume.py
Line 262: parent = self.getVolumePath()
Line 263: parent_format = fmt2str(self.getFormat())
Line 264: # We should use parent's relative path instead of full
path
Line 265: parent =
os.path.join(os.path.basename(os.path.dirname(parent)),
Line 266: os.path.basename(parent))
Lines 261-266 can be taken out of the try block (they don't need the volume to
be prepared).
Line 267: createVolume(parent, parent_format, dst_path,
Line 268: size, volFormat, preallocate)
Line 269: except Exception as e:
Line 270: self.log.error("Volume.clone: can't clone: %s to %s" %
Line 269: except Exception as e:
Line 270: self.log.error("Volume.clone: can't clone: %s to %s" %
Line 271:(self.volumePath, dst_path))
Line 272: raise se.CannotCloneVolume(self.volumePath, dst_path,
str(e))
Line 273: else:
No need for an else block. You can just move this after "finally" (no need for
the volume to be prepared).
Line 274: if self.isLeaf():
Line 275: taskName = "parent volume rollback: " + self.volUUID
Line 276: vars.task.pushRecovery(
Line 277: task.Recovery(taskName, "volume", "Volume",
--
To view, visit http://gerrit.ovirt.org/18205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11948aacad21008ffbb4cb23013bf363e60bdb9b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] AsyncOpFix
Saggi Mizrahi has abandoned this change. Change subject: [WIP] AsyncOpFix .. Abandoned Was only used to invoke Jenkins -- To view, visit http://gerrit.ovirt.org/19259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie120c6b241aa45268b8e3d29110b51b39c30af50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] AsyncOpFix
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] AsyncOpFix .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3565/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie120c6b241aa45268b8e3d29110b51b39c30af50 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Zhou Zheng Sheng has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 15: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4460/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3563/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4379/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 14:
(1 comment)
File lib/vdsm/tool/libvirt_configure.py
Line 69: def libvirt_configure_services_restart(*args):
Line 70: """
Line 71: Managing restart of related services
Line 72: """
Line 73: return (service.service_stop("supervdsmd") and
No need. I'll return 0, you're right about the exceptions handling.
Line 74: service.service_stop("libvirtd") and
Line 75: service.service_start("libvirtd") and
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3711da62d6c196978fb4f5e89f1bce4b7500470
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Fix the mtu of bond/nic not being set for new network
Assaf Muller has posted comments on this change. Change subject: netconf: Fix the mtu of bond/nic not being set for new network .. Patch Set 4: (1 comment) File vdsm/netmodels.py Line 89: Line 90: super(Nic, self).__init__(name, configurator, ipconfig, Line 91: mtu=mtu) Line 92: Line 93: def configure(self, **opts): Just a quick note. If A = isVlan and B = linkUp, then: Base patch was: (not A or not B) -> configure patch 1: not (A and not B) -> configure patch 4: (A and B) -> don't configure The base patch and patch 4 are logically equivalent while patch 1 is not equivalent to either. This is ignoring predicates C & D for this if statement, and any changes in the following if statement. Just bringing this up to make sure that the final outcome is what is intended. Line 94: # in a limited condition, we should not touch the nic config Line 95: if (self.vlan and Line 96: netinfo.operstate(self.name) == netinfo.OPERSTATE_UP and Line 97: netinfo.NetInfo().ifaceUsers(self.name) and -- To view, visit http://gerrit.ovirt.org/18966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd534 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Don't re-produce the same SD again.
Ayal Baron has posted comments on this change. Change subject: Don't re-produce the same SD again. .. Patch Set 4: (1 comment) With a proper commit message I'd +2 this in a jiffy Commit Message Line 5: CommitDate: 2013-09-16 04:46:06 +0300 Line 6: Line 7: Don't re-produce the same SD again. Line 8: Line 9: Anyway a similar SD is expected. meaningless commit message Line 10: Line 11: Change-Id: I7f5c267c8afa961bd5cde5e2b67d598a1fb5e486 -- To view, visit http://gerrit.ovirt.org/18201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f5c267c8afa961bd5cde5e2b67d598a1fb5e486 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Making getVSize and getVTrueSize SD methods.
Ayal Baron has posted comments on this change.
Change subject: Making getVSize and getVTrueSize SD methods.
..
Patch Set 4: Code-Review-1
(8 comments)
Commit Message
Line 5: CommitDate: 2013-09-16 04:46:07 +0300
Line 6:
Line 7: Making getVSize and getVTrueSize SD methods.
Line 8:
Line 9: Units sanitized. The two methods returns now size in bytes,
s/returns/return/
Line 10: like st_size.
Line 11: getVTrueSize() renamed to getAllocSize().
Line 12:
Line 13: TODO:
Line 10: like st_size.
Line 11: getVTrueSize() renamed to getAllocSize().
Line 12:
Line 13: TODO:
Line 14: This two method should be unified in a future patch since the
s/This/These/
s/method/methods/
Line 15: two values are returned in the same call for file volumes and
Line 16: the two values are identical for block volumes.
Line 17:
Line 18: Required to reduce the volume size functions proliferation.
Line 12:
Line 13: TODO:
Line 14: This two method should be unified in a future patch since the
Line 15: two values are returned in the same call for file volumes and
Line 16: the two values are identical for block volumes.
so unify them now while you're refactoring. I see no reason to wait.
Line 17:
Line 18: Required to reduce the volume size functions proliferation.
Line 19:
Line 20: Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9
File vdsm/storage/blockSD.py
Line 132: return LVM_ENC_ESCAPE.sub(lambda c: unichr(int(c.groups()[0])), s)
Line 133:
Line 134:
Line 135: def _get_st_size(devPath):
Line 136: """ Size in bytes of a dm device workaround.
???
Line 137:
Line 138: stat.st_size (in /sys/block/dm-*/stat) is identically 0.
Line 139: """
Line 140: with open(devPath, "rb") as f:
Line 134:
Line 135: def _get_st_size(devPath):
Line 136: """ Size in bytes of a dm device workaround.
Line 137:
Line 138: stat.st_size (in /sys/block/dm-*/stat) is identically 0.
???
Line 139: """
Line 140: with open(devPath, "rb") as f:
Line 141: f.seek(0, 2)
Line 142: return f.tell()
Line 620: return False
Line 621: return True
Line 622:
Line 623: def getVSize(self, imgUUID, volUUID):
Line 624: """ Return the block volume size in bytes. Like st_size."""
s/Like st_size//
Line 625: try:
Line 626: size = _get_st_size(lvm.lvPath(self.sdUUID, volUUID))
Line 627: except IOError as e:
Line 628: if e.errno == os.errno.ENOENT:
Line 634: raise
Line 635:
Line 636: return size
Line 637:
Line 638: getVAllocSize = getVSize
redundant, unify the methods/
Line 639:
Line 640: @classmethod
Line 641: def validateCreateVolumeParams(cls, volFormat, preallocate,
srcVolUUID):
Line 642: """
File vdsm/storage/volume.py
Line 477: # match the apparent size (eg: physical extent
granularity in LVM)
Line 478: # we need to update the size value so that the metadata
reflects
Line 479: # the correct state.
Line 480: if volFormat == RAW_FORMAT:
Line 481: # TODO: fix size in [sectors]! "I tawt I taw a puddy
tat!"
sub/incorrect quote//g
And please spare us of redundant comments (both in code and in reviews)
Line 482: apparentSize = int(dom.getVSize(imgUUID, volUUID) /
BLOCK_SIZE)
Line 483: if apparentSize < size:
Line 484: cls.log.error("The volume %s apparent size %s is
smaller "
Line 485: "than the requested size %s",
--
To view, visit http://gerrit.ovirt.org/18202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Elad Ben Aharon
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
