Change in vdsm[master]: Removing libvirt_configure from pre-start and ask for manual...
Alon Bar-Lev has posted comments on this change.
Change subject: Removing libvirt_configure from pre-start and ask for manual run
..
Patch Set 2:
(2 comments)
File init/sysvinit/vdsmd.init.in
Line 140: -0 /dev/null -1 /dev/null -2 /dev/null --syslog
@VDSMDIR@/respawn --minlifetime 10 \
Line 141: --daemon --masterpid ${RESPAWNPIDFILE} ${VDSM_BIN}
--pidfile ${PIDFILE}
Line 142: RETVAL=$?
Line 143: [ $RETVAL = 0 ] touch ${LOCK_FILE}
Line 144: return $RETVAL
using this retval is the ugliest approach :
local RETVAL=1
if ${VDSMD_INIT_COMMON} --pre-start; then
echo $Starting up vdsm daemon:
if NICELEVEL=${NICE_LOWEST} daemon --user=vdsm @VDSMDIR@/daemonAdapter
\
...; then
touch ${LOCK_FILE}
RETVAL=0
fi
return ${RETVAL}
or... use the || return 1 structure...
Line 145: }
Line 146:
Line 147: stop() {
Line 148: echo $Shutting down vdsm daemon:
File init/vdsmd_init_common.sh.in
Line 207: run_tasks \
Line 208: run_init_hooks gencerts check_libvirt_configure \
Line 209: reconfigure_sanlock syslog_available nwfilter dummybr \
Line 210: load_needed_modules tune_system mkdirs test_space test_lo
\
Line 211: test_conflicting_conf
please move closing quotes to new line as well to allow adding last.
Line 212: ;;
Line 213: --post-stop)
Line 214: run_tasks run_final_hooks
Line 215: ;;
--
To view, visit http://gerrit.ovirt.org/19737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
Hello Ayal Baron, Bala.FA, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19863
to review the following change.
Change subject: gluster: fix integer overflow error in rebalance status
..
gluster: fix integer overflow error in rebalance status
Provides rebalance status values as strings to avoid overflow error
when a rebalance status values exceeds the XML-RPC limits
For more info: https://bugzilla.redhat.com/show_bug.cgi?id=1012393
Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Signed-off-by: Timothy Asir tjeya...@redhat.com
---
M vdsm/gluster/cli.py
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/19863/1
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index 62b5f13..f9d6404 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -610,21 +610,21 @@
status = {
'summary': {
-'filesScanned': int(tree.find('aggregate/lookups').text),
-'filesMoved': int(tree.find('aggregate/files').text),
-'filesFailed': int(tree.find('aggregate/failures').text),
-'filesSkipped': int(tree.find('aggregate/failures').text),
-'totalSizeMoved': int(tree.find('aggregate/size').text),
+'filesScanned': tree.find('aggregate/lookups').text,
+'filesMoved': tree.find('aggregate/files').text,
+'filesFailed': tree.find('aggregate/failures').text,
+'filesSkipped': tree.find('aggregate/failures').text,
+'totalSizeMoved': tree.find('aggregate/size').text,
'status': tree.find('aggregate/statusStr').text.upper()},
'hosts': []}
for el in tree.findall('node'):
status['hosts'].append({'name': el.find('nodeName').text,
-'filesScanned': int(el.find('lookups').text),
-'filesMoved': int(el.find('files').text),
-'filesFailed': int(el.find('failures').text),
-'filesSkipped': int(el.find('failures').text),
-'totalSizeMoved': int(el.find('size').text),
+'filesScanned': el.find('lookups').text,
+'filesMoved': el.find('files').text,
+'filesFailed': el.find('failures').text,
+'filesSkipped': el.find('failures').text,
+'totalSizeMoved': el.find('size').text,
'status': el.find('statusStr').text.upper()})
return status
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Sandro Bonazzola has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 1: (2 comments) File client/vdsClient.py Line 1694: Line 1695: def startMonitoringDomain(self, args): Line 1696: sdUUID, hostID = args Line 1697: self.s.startMonitoringDomain(sdUUID, hostID) Line 1698: return 0, '' Always return 0? doesn't self.s.startMonitoringDomain(sdUUID, hostID) return the usual dict with ['status']['code'] ? Line 1699: Line 1700: def stopMonitoringDomain(self, args): Line 1701: sdUUID, = args Line 1702: self.s.stopMonitoringDomain(sdUUID) Line 1698: return 0, '' Line 1699: Line 1700: def stopMonitoringDomain(self, args): Line 1701: sdUUID, = args Line 1702: self.s.stopMonitoringDomain(sdUUID) same here Line 1703: return 0, '' Line 1704: Line 1705: def snapshot(self, args): Line 1706: vmUUID, sdUUID, imgUUID, baseVolUUID, volUUID = args -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4691/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4767/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3882/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reintroduce afterMigrationStatus
Michal Skrivanek has posted comments on this change. Change subject: Reintroduce afterMigrationStatus .. Patch Set 1: Code-Review+1 is there any recommendation how to deprecate things in vdsm perhaps? -- To view, visit http://gerrit.ovirt.org/19859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc55f7fc0d7debd1590011301c38565d27dc137e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Antoni Segura Puimedon has posted comments on this change.
Change subject: Unified persistence [3/4] - Restore network config
..
Patch Set 20:
(10 comments)
Commit Message
Line 6:
Line 7: Unified persistence [3/4] - Restore network config
Line 8:
Line 9: Add vdsm-restore-net-config support for unified persistence.
Line 10: It relies on configurator specific persistence removal, i.e.,
Done
Line 11: each configurator should remove their persisted conf, leaving
Line 12: only unified persistence as source of persistence.
Line 13:
Line 14: After the configurator persistence is flushed, the unified
Line 7: Unified persistence [3/4] - Restore network config
Line 8:
Line 9: Add vdsm-restore-net-config support for unified persistence.
Line 10: It relies on configurator specific persistence removal, i.e.,
Line 11: each configurator should remove their persisted conf, leaving
Done
Line 12: only unified persistence as source of persistence.
Line 13:
Line 14: After the configurator persistence is flushed, the unified
Line 15: persisted nets and bonds are passed to a setupNetworks call.
Line 15: persisted nets and bonds are passed to a setupNetworks call.
Line 16:
Line 17: Since we want vdsm-restore-net-config to be run at boot after
Line 18: libvirtd but before vdsmd listens, the service was removed
Line 19: and it was integrated as one of the start tasks.
Done
Line 20:
Line 21: If the restoration is run via vdsmd_init_common.sh we touch
Line 22: /var/run/vdsm/nets_restored that, if present, prevents the
Line 23: next vdsmd starts and restarts without boot from restoring
Line 18: libvirtd but before vdsmd listens, the service was removed
Line 19: and it was integrated as one of the start tasks.
Line 20:
Line 21: If the restoration is run via vdsmd_init_common.sh we touch
Line 22: /var/run/vdsm/nets_restored that, if present, prevents the
Done
Line 23: next vdsmd starts and restarts without boot from restoring
Line 24: the nets.
Line 25:
Line 26: The user can explicitly restore the nets by explicitly calling
Line 22: /var/run/vdsm/nets_restored that, if present, prevents the
Line 23: next vdsmd starts and restarts without boot from restoring
Line 24: the nets.
Line 25:
Line 26: The user can explicitly restore the nets by explicitly calling
Done
Line 27: /usr/share/vdsm/vdsm-restore-net-config or via vdsm-tool:
Line 28: vdsm-tool restore-nets
Line 29:
Line 30: Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
File init/vdsmd_init_common.sh.in
Line 173: }
Line 174:
Line 175: task_restore_nets(){
Line 176: RESTORATION_FILE=@VDSMRUNDIR@/nets_restored
Line 177: if [ ! -f $RESTORATION_FILE ]; then
Done
Line 178: @PYTHON@ @VDSMDIR@/vdsm-restore-net-config
Line 179: touch $RESTORATION_FILE
Line 180: fi
Line 181: }
Line 206: fi
Line 207: done
Line 208: }
Line 209:
Line 210:
Done
Line 211: case $1 in
Line 212: --pre-start)
Line 213: run_tasks \
Line 214: run_init_hooks gencerts reconfigure_sanlock
reconfigure_libvirt \
File lib/vdsm/netconfpersistence.py
Line 23: import logging
Line 24: import os
Line 25:
Line 26: from config import config
Line 27: from tool.restore_nets import restore
Because of it's usage in lib/vdsm/netinfo in for getBootProto in Assaf's patch.
Line 28: import constants
Line 29: import utils
Line 30:
Line 31:
File lib/vdsm/tool/restore_nets.py
Line 30:
Line 31: Restores the networks to what was previously persisted via vdsm.
Line 32:
Line 33: rc, out, err = utils.execCmd([os.path.join(
Line 34: P_VDSM, 'vdsm-restore-net-config')], raw=True, sudo=True)
Yes, I put it because of the functional tests.
Line 35: sys.stdout.write(out)
Line 36: sys.stderr.write(err)
File vdsm/netconf/ifcfg.py
Line 220: self._removeSourceRouteFile('route', device)
Line 221:
Line 222: def flush(self):
Line 223: libvirtCfg.flush()
Line 224: service_stop('network')
Ok, I'll use _ownedFiles together with sorting to do it. It will need deeper
testing.
Line 225: self.configApplier.flush()
Line 226: service_start('network')
Line 227:
Line 228:
--
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_network_functional_tests/649/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4692/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3883/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Sandro Bonazzola has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 1: Verified-1 Fails starting the VM for hosted engine setup after disconnecting the pool and calling startMonitoringDomain (http://gerrit.ovirt.org/19867) -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3884/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: interpret and use correct xml elements
Bala.FA has posted comments on this change.
Change subject: gluster: interpret and use correct xml elements
..
Patch Set 1:
(1 comment)
File vdsm/gluster/cli.py
Line 611: tree = xmltree.find('volRemoveBrick')
Line 612: else:
Line 613: return
Line 614:
Line 615: st = re.sub('[ -]', '_',
tree.find('aggregate/statusStr').text.upper())
I need two chained replace(). To avoid that I used regex. Let me know I go
back to chained replace().
Line 616: status = {
Line 617: 'summary': {
Line 618: 'runtime': float(tree.find('aggregate/runtime').text),
Line 619: 'filesScanned': int(tree.find('aggregate/lookups').text),
--
To view, visit http://gerrit.ovirt.org/19674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b90283ac2b9f4b54acfccffa02a30e38e5e9d85
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
Timothy Asir has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reintroduce afterMigrationStatus
Dan Kenigsberg has posted comments on this change. Change subject: Reintroduce afterMigrationStatus .. Patch Set 1: Verified+1 Code-Review+2 I see no other way than the one done in this patch: first stop using a feature, declare that it is deprecated, and after all versions expecting it are gone (usually, major version change of ovirt) drop the support. Or did you ask about a proper means to list deprecated features waiting for their demise? Currently in-code comments are the only way I know of. -- To view, visit http://gerrit.ovirt.org/19859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc55f7fc0d7debd1590011301c38565d27dc137e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reintroduce afterMigrationStatus
Dan Kenigsberg has submitted this change and it was merged. Change subject: Reintroduce afterMigrationStatus .. Reintroduce afterMigrationStatus In http://gerrit.ovirt.org/19306 I was fooled to believe that we can drop the unused afterMigrationStatus parameter. However vdsm version prior to that change (e.g. that of ovirt-3.3.0) expect to delete it. Change-Id: Ibc55f7fc0d7debd1590011301c38565d27dc137e Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19859 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com --- M vdsm/vm.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc55f7fc0d7debd1590011301c38565d27dc137e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
Timothy Asir has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: Calculation of chain to remove is inaccurate
Dan Kenigsberg has posted comments on this change. Change subject: image: Calculation of chain to remove is inaccurate .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248c51727584a35d1f439e57c93613caa9f369a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4694/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4770/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3885/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
Bala.FA has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
Dan Kenigsberg has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 2: (1 comment) File vdsm/storage/blockSD.py Line 1035: try: Line 1036: os.symlink(imgPath, dst) Line 1037: except OSError as e: Line 1038: if e.errno == errno.EEXIST: Line 1039: self.log.debug(img run dir already exists: %s, dst) how about path to image directory already exists: %s Line 1040: else: Line 1041: self.log.error(Failed to create img run dir: %s, dst) Line 1042: raise Line 1043: return dst -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: Calculation of chain to remove is inaccurate
Ayal Baron has posted comments on this change. Change subject: image: Calculation of chain to remove is inaccurate .. Patch Set 1: Code-Review+2 I believe engine only ever passes a single volume so possibly it would be better to just remove the support for removal of subchain and significantly simplify the code. This does not detract from the correctness of this patch though so +2. -- To view, visit http://gerrit.ovirt.org/19852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248c51727584a35d1f439e57c93613caa9f369a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
Dan Kenigsberg has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 2: (1 comment) Ayal, maybe I misunderstood the condition that worries you. If so, please re-explain it. I am a bit anxious to unbreak migration in ovirt-3.3 by promptly taking this patch. File vdsm/storage/blockSD.py Line 1035: try: Line 1036: os.symlink(imgPath, dst) Line 1037: except OSError as e: Line 1038: if e.errno == errno.EEXIST: Line 1039: self.log.debug(img run dir already exists: %s, dst) I tend to agree with Eduardo: the link source and destination contains the very same sdUUID. If someone called prepareImage() with sdUUID, we are bound to return a path to that domain, even though a newer image exists on another domain. In such a case, the bug exists higher in the stack, with whomever asked to prepare the image on the stale storage domain. Line 1040: else: Line 1041: self.log.error(Failed to create img run dir: %s, dst) Line 1042: raise Line 1043: return dst -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
Dan Kenigsberg has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 3: Code-Review-1 (1 comment) Code seems fine, thought please fix the commit message. Commit Message Line 8: Line 9: Provides rebalance status values as strings to avoid overflow error Line 10: when a rebalance status values exceeds the XML-RPC limits Line 11: Line 12: For more info: https://bugzilla.redhat.com/show_bug.cgi?id=1012393 use the Bug-Url: format, please. Line 13: Line 14: Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4695/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3886/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: Remove redundant activate and deactivate of the same ...
Ayal Baron has posted comments on this change.
Change subject: image: Remove redundant activate and deactivate of the same
volume
..
Patch Set 1: Code-Review-1
(2 comments)
File vdsm/storage/image.py
Line 918: tmpVol.prepare(rw=True, justme=True, setrw=True)
Line 919:
Line 920: # We should prepare/teardown volume for every single rebase.
Line 921: # The reason is recheckIfLeaf at the end of the rebase, that
change
Line 922: # volume permissions to RO for internal volumes.
Please read this comment
Line 923: srcVol.prepare(rw=True, chainrw=True, setrw=True)
Line 924: try:
Line 925: # Step 2: Rebase successor on top of tmpVol
Line 926: # qemu-img rebase -b tmpBackingFile -F backingFormat -f
srcFormat
Line 926: # qemu-img rebase -b tmpBackingFile -F backingFormat -f
srcFormat
Line 927: # src
Line 928: backingVolPath = os.path.join('..',
srcVolParams['imgUUID'],
Line 929: newUUID)
Line 930: srcVol.rebase(newUUID, backingVolPath,
volParams['volFormat'],
Since unsafe rebase doesn't require access to the parent, you can probably
replace the second prepare with:
srcVol.prepare(rw=True, justme=True, setrw=True).
Line 931: unsafe=False, rollback=True)
Line 932:
Line 933: # Step 3: Remove pointer to backing file from the
successor by
Line 934: # 'unsafed' rebase qemu-img rebase -u -b -F
--
To view, visit http://gerrit.ovirt.org/19854
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d615fd8e9b199cef1340360c7f68b19919b0caa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Eduardo has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 1: (1 comment) File client/vdsClient.py Line 1694: Line 1695: def startMonitoringDomain(self, args): Line 1696: sdUUID, hostID = args Line 1697: self.s.startMonitoringDomain(sdUUID, hostID) Line 1698: return 0, '' This is equivalent, code, msg as in other functions. Line 1699: Line 1700: def stopMonitoringDomain(self, args): Line 1701: sdUUID, = args Line 1702: self.s.stopMonitoringDomain(sdUUID) -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Sandro Bonazzola has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 1: (1 comment) File client/vdsClient.py Line 1694: Line 1695: def startMonitoringDomain(self, args): Line 1696: sdUUID, hostID = args Line 1697: self.s.startMonitoringDomain(sdUUID, hostID) Line 1698: return 0, '' I would have expected something like: status = self.s.startMonitoringDomain(sdUUID, hostID) return status['status']['code'], status['status']['message'] with the above return 0, '' vdsClient will exit with status 0 also if the call fails, no? Line 1699: Line 1700: def stopMonitoringDomain(self, args): Line 1701: sdUUID, = args Line 1702: self.s.stopMonitoringDomain(sdUUID) -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
Ayal Baron has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 3: Code-Review+1 (2 comments) File vdsm/storage/blockSD.py Line 1035: try: Line 1036: os.symlink(imgPath, dst) Line 1037: except OSError as e: Line 1038: if e.errno == errno.EEXIST: Line 1039: self.log.debug(path to img directory already exists: %s, dst) s/img/image/ Line 1040: else: Line 1041: self.log.error(Failed to create path to img dir: %s, dst) Line 1042: raise Line 1043: return dst Line 1037: except OSError as e: Line 1038: if e.errno == errno.EEXIST: Line 1039: self.log.debug(path to img directory already exists: %s, dst) Line 1040: else: Line 1041: self.log.error(Failed to create path to img dir: %s, dst) ditto Line 1042: raise Line 1043: return dst Line 1044: Line 1045: def createImageLinks(self, srcImgPath, imgUUID, volUUIDs): -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure active LVs are refreshed before use.
Lee Yarwood has uploaded a new change for review. Change subject: Ensure active LVs are refreshed before use. .. Ensure active LVs are refreshed before use. At present active LVs are trusted to correctly represent the correct state of a given LV. This may not be the case if the LV has been modified by another host since the LV was activated Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Bug-Url: https://bugzilla.redhat.com/1009812 Signed-off-by: Lee Yarwood lyarw...@redhat.com --- M vdsm/storage/lvm.py 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/19871/1 diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 0c2964e..6d2c487 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -1127,9 +1127,15 @@ lvNames = _normalizeargs(lvNames) toActivate = [lvName for lvName in lvNames if not _isLVActive(vgName, lvName)] +toRefresh = [lvname for lvname in lvNames if _isLVActive(vgName, lvName)] + if toActivate: _setLVAvailability(vgName, toActivate, y) +if toRefresh: +for lv in toRefresh: +refreshLV(vgName, lv) + def deactivateLVs(vgName, lvNames): lvNames = _normalizeargs(lvNames) -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure active LVs are refreshed before use.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Ensure active LVs are refreshed before use. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4696/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3887/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4697/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4773/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3888/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4698/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4774/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3889/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
Dan Kenigsberg has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 5: Verified+1 Code-Review+2 Getting this patch in is more important than dropping the redundant pre-raise log line. Thanks, Eduardo and Ayal! -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Enable VM migration to old vdsm's. .. Enable VM migration to old vdsm's. Old vdsm's can't run VM from /var/run/vdsm/storage and rely on /rhev/data-center hierarchy. Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011608 Signed-off-by: Eduardo ewars...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19825 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py M vdsm/storage/hsm.py 3 files changed, 24 insertions(+), 1 deletion(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Remove bonds before editing and adding
Dan Kenigsberg has abandoned this change. Change subject: Remove bonds before editing and adding .. Abandoned Going to get to ovirt-3.3.1 since it's already in master branch. -- To view, visit http://gerrit.ovirt.org/18587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3ea081fe7760b52f6febb4959f69851b2cf4c2a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Add support for direct setting of cpu_shares when creating a VM
Dan Kenigsberg has abandoned this change. Change subject: Add support for direct setting of cpu_shares when creating a VM .. Abandoned getting into ovirt-3.3 via its master rebranch. -- To view, visit http://gerrit.ovirt.org/17603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7ef73cf0579a0efd5a31c32638efcc6cdf2447d7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4699/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4775/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3890/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
Lee Yarwood has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 4: I'm not sure what you mean import only what needed. What's being imported that's not needed? As we require multiprocessing to call get_logger() I've removed the subsequent imports from the module and edited the lines calling for them. Feel free to revert if this is not what you wanted here Yaniv. So 17199 won't remove the necessity for this patch. +1 -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix vdsClient.repoStats() bad path.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix vdsClient.repoStats() bad path. .. Fix vdsClient.repoStats() bad path. (Or why using your list as a dict is bad.) Change-Id: Idf7f6c367c83c2d00967e31dda6c9d0ef2fd3e57 Signed-off-by: Eduardo ewars...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19764 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Yeela Kaplan ykap...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClient.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yeela Kaplan: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf7f6c367c83c2d00967e31dda6c9d0ef2fd3e57 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix vdsClient.repoStats() bad path.
Dan Kenigsberg has posted comments on this change. Change subject: Fix vdsClient.repoStats() bad path. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf7f6c367c83c2d00967e31dda6c9d0ef2fd3e57 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: is list a dict?
Dan Kenigsberg has posted comments on this change. Change subject: vdsClient: is list a dict? .. Patch Set 1: Verified+1 verified with Zhou ZhengSheng's pydiff. -- To view, visit http://gerrit.ovirt.org/19763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacd7af3691eb2ed15b7fbb042f8ce43528dce31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: is list a dict?
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsClient: is list a dict? .. vdsClient: is list a dict? Short answer: NO! Change-Id: Iacd7af3691eb2ed15b7fbb042f8ce43528dce31e Signed-off-by: Eduardo ewars...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19763 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Yeela Kaplan ykap...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClient.py 1 file changed, 22 insertions(+), 22 deletions(-) Approvals: Yeela Kaplan: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacd7af3691eb2ed15b7fbb042f8ce43528dce31e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Handling topology for ppc64
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Handling topology for ppc64 .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4700/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4776/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3891/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4701/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4777/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3892/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix premature selinux dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: fix premature selinux dependency .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4778/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3893/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea625d7c39035055b246357030372430b4bddf68 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Toshio くらとみ a.bad...@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix premature selinux dependency
Nir Soffer has posted comments on this change. Change subject: fix premature selinux dependency .. Patch Set 2: (2 comments) Fixes to commit message. Commit Message Line 5: CommitDate: 2013-10-04 15:22:20 +0100 Line 6: Line 7: fix premature selinux dependency Line 8: Line 9: Vdsm v4.13.0 places its storage reporsitory under /var/run/vdsm/storage s/reporsitory/repository/ Line 10: istead of the non-standard trademarked /rhev/data-center. This change Line 11: requires a compatible change to selinux which would be available only Line 12: when selinux-policy-3.7.19-195.el6.13 is released. Line 13: Line 11: requires a compatible change to selinux which would be available only Line 12: when selinux-policy-3.7.19-195.el6.13 is released. Line 13: Line 14: Until then, to try out vdsm one could --force its installation and Line 15: disable selinux. Did you mean run selinux in permissive mode? Line 16: Line 17: Change-Id: Iea625d7c39035055b246357030372430b4bddf68 -- To view, visit http://gerrit.ovirt.org/19807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea625d7c39035055b246357030372430b4bddf68 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Toshio くらとみ a.bad...@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: Remove redundant activate and deactivate of the same ...
Nir Soffer has posted comments on this change. Change subject: image: Remove redundant activate and deactivate of the same volume .. Patch Set 1: Code-Review-1 (2 comments) Usage of try-finally is unsafe. File vdsm/storage/image.py Line 919: Line 920: # We should prepare/teardown volume for every single rebase. Line 921: # The reason is recheckIfLeaf at the end of the rebase, that change Line 922: # volume permissions to RO for internal volumes. Line 923: srcVol.prepare(rw=True, chainrw=True, setrw=True) If srcVol.prepare raise, tmpvol will not be teardown. Not related to this patch - just to make sure we do not forget this. See bellow for safe way to do this. Line 924: try: Line 925: # Step 2: Rebase successor on top of tmpVol Line 926: # qemu-img rebase -b tmpBackingFile -F backingFormat -f srcFormat Line 927: # src Line 937: unsafe=True, rollback=False) Line 938: finally: Line 939: srcVol.teardown(sdUUID=srcVol.sdUUID, volUUID=srcVol.volUUID) Line 940: tmpVol.teardown(sdUUID=tmpVol.sdUUID, volUUID=tmpVol.volUUID, Line 941: justme=True) If srcVol.teardown raise an exception, tmpVol.teardown will be skipped. Even if now teardown never raises, it may in the future. The safe way to do this is to nest try-finally blocks: prepare this try: work with this prepare that try: work with that finally: teardown that finally: teardown this Line 942: Line 943: # Step 4: Delete temporary volume Line 944: tmpVol.delete(postZero=False, force=True) Line 945: -- To view, visit http://gerrit.ovirt.org/19854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d615fd8e9b199cef1340360c7f68b19919b0caa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR .. vdsm: support VIR_MIGRATE_ABORT_ON_ERROR Abort VM migration on EIO by default. The flag is supported since libvirt 1.0.1 upstream, so use it only in appropriate cluster versions. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961154 Signed-off-by: Peter V. Saveliev p...@redhat.com Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80 Reviewed-on: http://gerrit.ovirt.org/17422 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Saggi Mizrahi smizr...@redhat.com Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/vm.py M vdsm_api/vdsmapi-schema.json 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Saggi Mizrahi: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Peter V. Saveliev: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change mom policy related interface to support multi-policy
Dan Kenigsberg has posted comments on this change. Change subject: Change mom policy related interface to support multi-policy .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/12466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09c40fee74b10d3eb41f4ec3ca18096a9b20dfcd Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change mom policy related interface to support multi-policy
Dan Kenigsberg has posted comments on this change. Change subject: Change mom policy related interface to support multi-policy .. Patch Set 12: Code-Review-1 Please rebase an retest. -- To view, visit http://gerrit.ovirt.org/12466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09c40fee74b10d3eb41f4ec3ca18096a9b20dfcd Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add task support
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: add task support
..
gluster: add task support
gluster volume operations like rebalance, replace-brick, remove-brick
are async operations which needs to be tracked as async tasks in
oVirt. This is done by introducing below new verbs.
New verb:
* glusterTasksList
- return value structure:
{TASKID: {
volume: VOLUMENAME,
status: TaskStatus,
type: TaskType,
bricks: [BRICK1,..],
data: SUMMARY
}, ...}
Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Signed-off-by: Bala.FA barum...@redhat.com
Signed-off-by: Timothy Asir tjeya...@redhat.com
Signed-off-by: Aravinda VK avish...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/10200
Reviewed-by: Saggi Mizrahi smizr...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M client/vdsClientGluster.py
M tests/Makefile.am
M tests/glusterTestData.py
A tests/glusterVolumeTasks.xml
M tests/gluster_cli_tests.py
M vdsm.spec.in
M vdsm/gluster/Makefile.am
M vdsm/gluster/__init__.py
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
A vdsm/gluster/tasks.py
M vdsm/gluster/vdsmapi-gluster-schema.json
13 files changed, 353 insertions(+), 2 deletions(-)
Approvals:
Saggi Mizrahi: Looks good to me, but someone else must approve
Aravinda VK: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: ndarshan dnara...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add task support
Dan Kenigsberg has posted comments on this change. Change subject: gluster: add task support .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/10200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 28: Verified+1 Code-Review+2 Copy score from ps27 -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Dan Kenigsberg has submitted this change and it was merged. Change subject: Unified network persistence [1/4] - Save running config .. Unified network persistence [1/4] - Save running config This patch introduces the new persistence model for vdsm networking. It is meant to provide a single reliable way abstracting persistence out of the netconf configurators as much as possible. To achieve its purpose, it stores the network actions as setupNetwork parameters serialized in json which are then used for rollback and initialization. The first patch in the series saves the current state of networks, nics and bonds to a folder. The second patch copies the contents of the running config folder to a startup config folder The third patch uses the startup config folder to restore network configuration to the host upon host boot up. Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Signed-off-by: Assaf Muller amul...@redhat.com Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/16699 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/Makefile.am M lib/vdsm/config.py.in A lib/vdsm/netconfpersistence.py M lib/vdsm/netinfo.py M tests/functional/utils.py M vdsm.spec.in M vdsm/configNetwork.py M vdsm/netconf/__init__.py M vdsm/netconf/ifcfg.py 9 files changed, 287 insertions(+), 14 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Dan Kenigsberg has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 13: Verified+1 Code-Review+2 Copying ancient score. -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Unified network persistence [2/4] Respond to
setSafeNetworkConfig
..
Unified network persistence [2/4] Respond to setSafeNetworkConfig
This patch adds setSafeNetwork capabilities to the unified
persistence model. At this stage, it is able to store the running
configuration to /var/lib/vdsm/persistence/netconf/{nets,bonds}
in an atomic way so that it will be available after reboot.
In the following patches there should be added a service that
calls a configurator flushing system that deletes the configurator
persistence bits before networking goes up and instead uses the
unified persistence to restore the network configuration.
Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Signed-off-by: Assaf Muller amul...@redhat.com
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/17009
Reviewed-by: Dan Kenigsberg dan...@redhat.com
Tested-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/netconfpersistence.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/configNetwork.py
M vdsm/vdsm-store-net-config.in
5 files changed, 67 insertions(+), 12 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get rid of mutables(lists) as default parameters
Dan Kenigsberg has posted comments on this change. Change subject: Get rid of mutables(lists) as default parameters .. Patch Set 2: Code-Review-1 (1 comment) Keep the initiative! File vdsm/storage/misc.py Line 123: Line 124: return False Line 125: Line 126: Line 127: def findCaller(skipUp=0, ignoreSourceFiles=None, ignoreMethodNames=None, Wouldn't ignoreMethodNames=() be enough? Line 128:logSkipName=None): Line 129: Line 130: Find the stack frame of the caller so that we can note the source Line 131: file name, line number and function name. -- To view, visit http://gerrit.ovirt.org/18356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I911485cf30d587f5b6b8bf44cf3552c1517abfd5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
Timothy Asir has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 3: (1 comment) Commit Message Line 8: Line 9: Provides rebalance status values as strings to avoid overflow error Line 10: when a rebalance status values exceeds the XML-RPC limits Line 11: Line 12: For more info: https://bugzilla.redhat.com/show_bug.cgi?id=1012393 Done Line 13: Line 14: Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3894/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
Dan Kenigsberg has posted comments on this change. Change subject: gluster: fix integer overflow error in rebalance status .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix integer overflow error in rebalance status
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: fix integer overflow error in rebalance status .. gluster: fix integer overflow error in rebalance status Provides rebalance status values as strings to avoid overflow error when a rebalance status values exceeds the XML-RPC limits Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1012393 Signed-off-by: Timothy Asir tjeya...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19863 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M tests/glusterTestData.py M vdsm/gluster/cli.py 2 files changed, 30 insertions(+), 30 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
