Change in vdsm[master]: tests: Add Patch class for fixture monkey patching
Nir Soffer has posted comments on this change. Change subject: tests: Add Patch class for fixture monkey patching .. Patch Set 3: Verified+1 (1 comment) Changes: 1. Refine commit message 2. Simplify complex test helper class 3. Make Patch more flexible by separating Patch creation from applying 4. Improve Patch methods names 5. Create instance variables in __init__ 6. Complain if Patch object is used improperly File tests/monkeypatchTests.py Line 39: def c(self): Line 40: pass Line 41: Line 42: def isClean(self): Line 43: return self.a == self.olda and self.b == self.oldb and self.oldc == self.c Will unify check in next patch Line 44: Line 45: Line 46: def patched(*args, **kw): Line 47: pass -- To view, visit http://gerrit.ovirt.org/19881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd419377be951635fe7d10cb21c0d1195e88cf8d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add Patch class for fixture monkey patching
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add Patch class for fixture monkey patching .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4945/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4059/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4869/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/19881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd419377be951635fe7d10cb21c0d1195e88cf8d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add Patch class for fixture monkey patching
Nir Soffer has posted comments on this change. Change subject: tests: Add Patch class for fixture monkey patching .. Patch Set 4: Verified+1 Make pep8 happy -- To view, visit http://gerrit.ovirt.org/19881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd419377be951635fe7d10cb21c0d1195e88cf8d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving coredump configuration to common script
Yaniv Bronhaim has posted comments on this change. Change subject: Moving coredump configuration to common script .. Patch Set 10: Verified-1 -- To view, visit http://gerrit.ovirt.org/19889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving coredump configuration to common script
Yaniv Bronhaim has posted comments on this change. Change subject: Moving coredump configuration to common script .. Patch Set 11: Verified+1 Now it works :) -- To view, visit http://gerrit.ovirt.org/19889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding dependency on cpopen formal package
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding dependency on cpopen formal package
..
Adding dependency on cpopen formal package
Removing cpopen code from vdsm and using formal package instead
Change-Id: I6dfc943cbf7ac1e4c575069afca9c7df0624372f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=903246
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M Makefile.am
M configure.ac
M debian/control
D debian/vdsm-python-cpopen.docs
D debian/vdsm-python-cpopen.install
M lib/Makefile.am
D lib/cpopen/.gitignore
D lib/cpopen/Makefile.am
D lib/cpopen/__init__.py
D lib/cpopen/cpopen.c
D lib/cpopen/setup.py
D lib/cpopen/tests.py
M vdsm.spec.in
13 files changed, 9 insertions(+), 755 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/20142/1
diff --git a/Makefile.am b/Makefile.am
index 195688f..84e5e6e 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -56,7 +56,6 @@
# checkd from now on
PEP8_WHITELIST = \
client \
- lib/cpopen/*.py \
lib/vdsm/*.py \
lib/vdsm/*.py.in \
tests \
diff --git a/configure.ac b/configure.ac
index 93b6b96..a1a5465 100644
--- a/configure.ac
+++ b/configure.ac
@@ -252,7 +252,6 @@
init/sysvinit/Makefile
init/upstart/Makefile
lib/Makefile
- lib/cpopen/Makefile
lib/vdsm/Makefile
lib/vdsm/tool/Makefile
lib/yajsonrpc/Makefile
diff --git a/debian/control b/debian/control
index da030ad..820bc26 100644
--- a/debian/control
+++ b/debian/control
@@ -31,13 +31,6 @@
Vcs-Git: git://gerrit.ovirt.org/vdsm
Vcs-Browser: http://gerrit.ovirt.org/gitweb?p=vdsm.git
-Package: vdsm-python-cpopen
-Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}, python
(=2.7.3)
-Description: Creates a sub-process in simpler safer manner
- Python package for creating sub-process in simpler and safer manner by using
- C code.
-
Package: vdsm-yajsonrpc
Architecture: all
Depends: ${shlibs:Depends}, ${misc:Depends}, python (=2.7.3),
@@ -54,7 +47,7 @@
Architecture: all
Depends: ${shlibs:Depends}, ${misc:Depends},
python (=2.7.3),
- vdsm-python-cpopen (= ${source:Version}),
+ python-cpopen,
vdsm-python (= ${source:Version})
Description: VDSM command line interface
Call VDSM commands from the command line. Used for testing and debugging.
@@ -93,7 +86,7 @@
policycoreutils (= 2.1.10),
psmisc (= 22.6),
python (= 2.7.3),
- vdsm-python-cpopen (= ${binary:Version}),
+ python-cpopen,
python-dmidecode,
python-ethtool (= 0.8),
python-ethtool (= 0.8),
diff --git a/debian/vdsm-python-cpopen.docs b/debian/vdsm-python-cpopen.docs
deleted file mode 100644
index 5ecd9c6..000
--- a/debian/vdsm-python-cpopen.docs
+++ /dev/null
@@ -1 +0,0 @@
-COPYING
diff --git a/debian/vdsm-python-cpopen.install
b/debian/vdsm-python-cpopen.install
deleted file mode 100644
index d38a40e..000
--- a/debian/vdsm-python-cpopen.install
+++ /dev/null
@@ -1,2 +0,0 @@
-./usr/lib/python2.7/dist-packages/cpopen/__init__.py
-./usr/lib/python2.7/dist-packages/cpopen/cpopen.so
diff --git a/lib/Makefile.am b/lib/Makefile.am
index b1a1a12..ff46328 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -19,4 +19,4 @@
#
include $(top_srcdir)/build-aux/Makefile.subs
-SUBDIRS = vdsm cpopen yajsonrpc
+SUBDIRS = vdsm yajsonrpc
diff --git a/lib/cpopen/.gitignore b/lib/cpopen/.gitignore
deleted file mode 100644
index d23b815..000
--- a/lib/cpopen/.gitignore
+++ /dev/null
@@ -1,2 +0,0 @@
-build
-*.so
diff --git a/lib/cpopen/Makefile.am b/lib/cpopen/Makefile.am
deleted file mode 100644
index c39ca24..000
--- a/lib/cpopen/Makefile.am
+++ /dev/null
@@ -1,48 +0,0 @@
-#
-# Copyright 2012 Red Hat, Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-#
-# Refer to the README and COPYING files for full details of the license
-#
-
-cpopendir = $(pyexecdir)/cpopen
-
-dist_cpopen_PYTHON = \
- __init__.py \
- $(NULL)
-
-cpopen.so: cpopen.c setup.py
- (cd $(srcdir); $(PYTHON) setup.py build \
- --build-temp $(abs_builddir) --build-lib $(abs_builddir))
-
-all-local: cpopen.so
-
-install-data-local:
- $(MKDIR_P) $(DESTDIR)$(cpopendir)
- $(INSTALL_PROGRAM) cpopen.so \
-
Change in vdsm[master]: Adding dependency on cpopen formal package
Yaniv Bronhaim has posted comments on this change. Change subject: Adding dependency on cpopen formal package .. Patch Set 1: Verified+1 Verified over rhel and f19. Zhou please tell me what should be done to make it also over debian. Thanks -- To view, visit http://gerrit.ovirt.org/20142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dfc943cbf7ac1e4c575069afca9c7df0624372f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving coredump configuration to common script
Dan Kenigsberg has submitted this change and it was merged. Change subject: Moving coredump configuration to common script .. Moving coredump configuration to common script Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19889 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M init/systemd/vdsmd.service.in M init/sysvinit/vdsmd.init.in M init/vdsmd_init_common.sh.in M vdsm/vdsm 4 files changed, 24 insertions(+), 15 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving coredump configuration to common script
Dan Kenigsberg has posted comments on this change. Change subject: Moving coredump configuration to common script .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move zombieReaper to its own package
Saggi Mizrahi has posted comments on this change. Change subject: Move zombieReaper to its own package .. Patch Set 7: No I don't have any work for putting it outside. My main concern is to pull infra code to lib so that we don't get assigned other people's bugs. Even if things remain VDSM specific putting them outside vdsm/ is better to declare layering. -- To view, visit http://gerrit.ovirt.org/19253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add Patch class for fixture monkey patching
Allon Mureinik has posted comments on this change. Change subject: tests: Add Patch class for fixture monkey patching .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd419377be951635fe7d10cb21c0d1195e88cf8d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4946/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4060/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4870/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Add vdsm lvm log
Nir Soffer has uploaded a new change for review.
Change subject: logging: Add vdsm lvm log
..
logging: Add vdsm lvm log
LVM log is disabled by default, making it harder then it should to debug
lvm issues. This patch add lvm log file where vdsm operations are
logged, and new lvm section in the vdsm configuration file.
Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M lib/vdsm/config.py.in
M vdsm/storage/lvm.py
2 files changed, 22 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/20145/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index c0bdd53..a9532a1 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -288,6 +288,17 @@
('guests_gateway_ip', '', None),
]),
+
+# Section: [lvm]
+('lvm', [
+
+('log_file', '/var/log/vdsm/lvm.log',
+'LVM log filename.'),
+
+('log_level', '4', # warning
+'LVM log level (0-7)'),
+
+]),
]
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 0c2964e..f3d5bac 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -105,7 +105,7 @@
ignore_suspended_devices=1
write_cache_state=0
disable_after_error_count=3
-%s
+%(devices_filter)s
}
global {
@@ -117,6 +117,11 @@
backup {
retain_min = 50
retain_days = 0
+}
+
+log {
+ file = %(log_file)s
+ level = %(log_level)s
}
@@ -142,7 +147,11 @@
def _buildConfig(devList):
flt = _buildFilter(chain(devList, USER_DEV_LIST))
-conf = LVMCONF_TEMPLATE % flt
+conf = LVMCONF_TEMPLATE % {
+'devices_filter': flt,
+'log_file': config.get('lvm', 'log_file'),
+'log_level': config.get('lvm', 'log_level'),
+}
return conf.replace(\n, )
--
To view, visit http://gerrit.ovirt.org/20145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Add vdsm lvm log
Nir Soffer has posted comments on this change. Change subject: logging: Add vdsm lvm log .. Patch Set 2: Make pep8 happy -- To view, visit http://gerrit.ovirt.org/20145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 8: I changed Bridge.py due to Saggi's comment. -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: config logging in spawned process
Ayal Baron has posted comments on this change. Change subject: remoteFileHandler: config logging in spawned process .. Patch Set 7: (1 comment) File vdsm/storage/remoteFileHandler.py Line 46: import misc Line 47: import fileUtils Line 48: import zombieReaper Line 49: from vdsm import constants Line 50: I'm not sure the complexity of it is worth the trouble considering http://gerrit.ovirt.org/14626 has been merged. Can you show why this is needed after this patch? Line 51: Line 52: # Crabs are known for their remote process calls Line 53: LENGTH_STRUCT_FMT = Q Line 54: LENGTH_STRUCT_LENGTH = calcsize(LENGTH_STRUCT_FMT) -- To view, visit http://gerrit.ovirt.org/9182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add Patch class for fixture monkey patching
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add Patch class for fixture monkey patching .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4947/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4061/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4871/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd419377be951635fe7d10cb21c0d1195e88cf8d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Create AsyncProcessOperation
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Create AsyncProcessOperation .. Patch Set 10: Code-Review+1 (1 comment) File lib/vdsm/utils.py Line 938: the process Line 939: self._proc.kill() Line 940: Line 941: def result(self): Line 942: Returns the result in the as a tuple of (result, error). you can still omit the in the Line 943: If the operation is still running it will block until it returns. Line 944: Line 945: If no resultParser has been set the default result Line 946: is (rc, out, err) -- To view, visit http://gerrit.ovirt.org/19254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
Eduardo has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 9: Verified-1 Adding the working patch. -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...
Alon Bar-Lev has posted comments on this change. Change subject: Avoiding automatically restart of sanlock service when starting vdsmd .. Patch Set 11: (1 comment) File init/vdsmd_init_common.sh.in Line 50: # If sanlock was started before the *first* installation of vdsm Line 51: # then it is probably missing the supplementary groups. Line 52: # Here we attempt to restart the service (when needed) to refresh Line 53: # the groups. Line 54: if $VDSM_TOOL sanlock-check-service; then the tool should return success (0) if service is ok, something is not right either in message and return or in vdsm tool. Line 55: echo Perform 'vdsm-tool service-restart sanlock' and start vdsm again Line 56: return 1 Line 57: fi Line 58: return 0 -- To view, visit http://gerrit.ovirt.org/19890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move zombieReaper to its own package
Yaniv Bronhaim has posted comments on this change. Change subject: Move zombieReaper to its own package .. Patch Set 7: Generally I agree. Next to go is creating separate package as you say.. but lets start from first step which is that patch -- To view, visit http://gerrit.ovirt.org/19253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Alon Bar-Lev has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 4: (1 comment) File lib/vdsm/tool/configurator.py Line 145: if service.service_status(srv): Line 146: service_should_start.append(srv) Line 147: Line 148: configure_libvirt(*args) Line 149: for srv in service_should_start: I believe that best to do the start in reverse order. Line 150: service.service_start(srv) Line 151: Line 152: # sanlock configuration Line 153: if sanlock_check_service(*args) and force: -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4948/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4062/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4872/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving coredump configuration to common script
oVirt Jenkins CI Server has posted comments on this change. Change subject: Moving coredump configuration to common script .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4949/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4063/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4873/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoiding automatically restart of sanlock service when starting vdsmd .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4950/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4064/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4874/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving coredump configuration to common script
oVirt Jenkins CI Server has posted comments on this change. Change subject: Moving coredump configuration to common script .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4951/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4065/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4875/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Add vdsm lvm log
Nir Soffer has posted comments on this change. Change subject: logging: Add vdsm lvm log .. Patch Set 3: lvm log is the most useless and pathetic log I even seen. Adding command_names = 1 may make it suck less. -- To view, visit http://gerrit.ovirt.org/20145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding dependency on cpopen formal package
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding dependency on cpopen formal package .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4952/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4066/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4876/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dfc943cbf7ac1e4c575069afca9c7df0624372f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4953/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4067/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4877/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: refresh on mda permission mismatch
Ayal Baron has posted comments on this change. Change subject: lvm: refresh on mda permission mismatch .. Patch Set 1: Code-Review+2 (1 comment) File vdsm/storage/lvm.py Line 1299: changelv(vg, lv, (--permission, permission)) Line 1300: except se.StorageException: Line 1301: l = getLV(vg, lv) Line 1302: if l.attr.permission == 'R': Line 1303: refreshLV(vg, lv) That was nack'd by lvm iirc? Line 1304: l = getLV(vg, lv) Line 1305: if l.writeable == rw: Line 1306: # Ignore the error since lv is now rw, hoping that the error was Line 1307: # because lv was already rw, see BZ#654691. We may hide here -- To view, visit http://gerrit.ovirt.org/20121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a77b967a057329a90499d7707074befe756b68a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding dependency on cpopen formal package
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding dependency on cpopen formal package .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4954/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4068/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4878/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dfc943cbf7ac1e4c575069afca9c7df0624372f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified persistence [3/4] - Restore network config
..
Patch Set 30:
(5 comments)
File init/vdsmd_init_common.sh.in
Line 191: return ${rt}
Line 192: fi
Line 193: touch ${restoration_file}
Line 194: fi
Line 195: }
if you don't have any additional operations under the condition please make
that way:
if [ ! -f ${restoration_file} ]; then
@PYTHON@ @VDSMDIR@/vdsm-restore-net-config || return 1
touch ${restoration_file}
fi
return 0
Line 196: pre-start tasks end
Line 197:
Line 198:
Line 199: post-stop tasks
File lib/vdsm/tool/restore_nets.py
Line 31: Restores the networks to what was previously persisted via vdsm.
Line 32:
Line 33: rc, out, err = utils.execCmd([os.path.join(
Line 34: P_VDSM, 'vdsm-restore-net-config')], raw=True,
Line 35: sudo=kwargs.get('sudo', False))
why do you still have the sudo option? please explain when this operation needs
root privilege, and if it does , why can it run without root privileges?
Line 36: sys.stdout.write(out)
Line 37: sys.stderr.write(err)
Line 34: P_VDSM, 'vdsm-restore-net-config')], raw=True,
Line 35: sudo=kwargs.get('sudo', False))
Line 36: sys.stdout.write(out)
Line 37: sys.stderr.write(err)
Line 38: return rc
if rc!=0 better to raise an Runtime Exception.. your call, depends how you use
the verb
File tests/functional/networkTests.py
Line 139: func(*args, **kwargs)
Line 140: except Exception:
Line 141: # cleanup
Line 142: instance = args[0]
Line 143: instance.vdsm_net.restoreNetConfig()
might raise an exception too, and you'll see only that instead of the original
exception
Line 144: raise
Line 145: return wrapper
Line 146:
Line 147: @cleanupNet
File tests/functional/utils.py
Line 118: self.vdscli.setSafeNetworkConfig()
Line 119:
Line 120: @netinfo_altering
Line 121: def restoreNetConfig(self):
Line 122: restore(sudo=True)
let supervdsm call that verb if it needs root privilege, we're trying to avoid
such calls
Line 123:
Line 124: @netinfo_altering
Line 125: def addNetwork(self, bridge, vlan=None, bond=None, nics=None,
opts=None):
Line 126: result = self.vdscli.addNetwork(bridge,
--
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding dependency on cpopen formal package
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding dependency on cpopen formal package .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4955/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4069/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4879/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dfc943cbf7ac1e4c575069afca9c7df0624372f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Add vdsm lvm log
Nir Soffer has posted comments on this change. Change subject: logging: Add vdsm lvm log .. Patch Set 4: Use log level 3 (error), as level 4 (warning) is way too noisy. -- To view, visit http://gerrit.ovirt.org/20145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Add vdsm lvm log
oVirt Jenkins CI Server has posted comments on this change. Change subject: logging: Add vdsm lvm log .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4956/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4070/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4880/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Add vdsm lvm log
oVirt Jenkins CI Server has posted comments on this change. Change subject: logging: Add vdsm lvm log .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4957/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4071/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4881/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4958/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4072/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4882/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Add vdsm lvm log
oVirt Jenkins CI Server has posted comments on this change. Change subject: logging: Add vdsm lvm log .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4959/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4073/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4883/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Add vdsm lvm log
oVirt Jenkins CI Server has posted comments on this change. Change subject: logging: Add vdsm lvm log .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4960/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4074/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4884/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reconfigure related services after vdsm rpm upgrade
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Reconfigure related services after vdsm rpm upgrade
..
Reconfigure related services after vdsm rpm upgrade
When performing an upgrade we might require reconfiguration of related
services. This patch force reconfigure of all related services and
restart them afterwards. After reconfigure is done, we're safe to start
vdsmd as usual.
Change-Id: I4a8c9c548b7a23588107b17351ab7f9ba3ae1d2b
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/20149/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index cf3dbc7..8384057 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -729,8 +729,10 @@
%postun
%if 0%{?rhel}
if [ $1 -ge 1 ]; then
-/sbin/service vdsmd condrestart /dev/null 21
-/sbin/service supervdsmd condrestart /dev/null 21
+if /sbin/service vdsmd condrestart /dev/null 21; then
+%{_bindir}/vdsm-tool configure-all --force
+/sbin/service vdsmd start /dev/null 2/dev/null
+fi
fi
exit 0
%else
--
To view, visit http://gerrit.ovirt.org/20149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a8c9c548b7a23588107b17351ab7f9ba3ae1d2b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reconfigure related services after vdsm rpm upgrade
Alon Bar-Lev has posted comments on this change.
Change subject: Reconfigure related services after vdsm rpm upgrade
..
Patch Set 2:
(1 comment)
File vdsm.spec.in
Line 731: if [ $1 -ge 1 ]; then
Line 732: if ! /sbin/service vdsmd condrestart /dev/null 21; then
Line 733: %{_bindir}/vdsm-tool configure-all --force
Line 734: /sbin/service vdsmd start /dev/null 2/dev/null
Line 735: fi
if that's failing, the rpm install will produce error, but nobody will be able
to see why
what about systemd configuration?
Line 736: fi
Line 737: exit 0
Line 738: %else
Line 739: %if 0%{?with_systemd_macros}
--
To view, visit http://gerrit.ovirt.org/20149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a8c9c548b7a23588107b17351ab7f9ba3ae1d2b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Alon Bar-Lev has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 7: (1 comment) File lib/vdsm/tool/configurator.py Line 120: if diskimage_gid not in groups: Line 121: sys.stdout.write(sanlock service requires restart\n) Line 122: else: Line 123: sys.stdout.write(sanlock service is already configured\n) Line 124: retval = 0 please decide if you writing procedural or exceptional. if you are writing exceptional, you can always throw an exception if there is error and avoid nesting. retval above will always be not equal to zero, so condition is void Line 125: Line 126: return retval Line 127: Line 128: -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4962/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4076/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4886/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modifying libvirt_configure usage print
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modifying libvirt_configure usage print .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4961/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4075/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4885/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcb0757a3321712f81951707ad1f77ca02b6bcae Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoiding automatically restart of sanlock service when starting vdsmd .. Patch Set 12: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4963/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4077/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4887/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reconfigure related services after vdsm rpm upgrade
oVirt Jenkins CI Server has posted comments on this change. Change subject: Reconfigure related services after vdsm rpm upgrade .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4964/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4078/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4888/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a8c9c548b7a23588107b17351ab7f9ba3ae1d2b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reconfigure related services after vdsm rpm upgrade
oVirt Jenkins CI Server has posted comments on this change. Change subject: Reconfigure related services after vdsm rpm upgrade .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4965/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4079/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4889/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a8c9c548b7a23588107b17351ab7f9ba3ae1d2b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4967/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4081/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4891/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4966/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4080/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4890/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Antoni Segura Puimedon has posted comments on this change.
Change subject: Unified persistence [3/4] - Restore network config
..
Patch Set 30:
(5 comments)
File init/vdsmd_init_common.sh.in
Line 191: return ${rt}
Line 192: fi
Line 193: touch ${restoration_file}
Line 194: fi
Line 195: }
Done
Line 196: pre-start tasks end
Line 197:
Line 198:
Line 199: post-stop tasks
File lib/vdsm/tool/restore_nets.py
Line 31: Restores the networks to what was previously persisted via vdsm.
Line 32:
Line 33: rc, out, err = utils.execCmd([os.path.join(
Line 34: P_VDSM, 'vdsm-restore-net-config')], raw=True,
Line 35: sudo=kwargs.get('sudo', False))
Done
Line 36: sys.stdout.write(out)
Line 37: sys.stderr.write(err)
Line 34: P_VDSM, 'vdsm-restore-net-config')], raw=True,
Line 35: sudo=kwargs.get('sudo', False))
Line 36: sys.stdout.write(out)
Line 37: sys.stderr.write(err)
Line 38: return rc
Done
File tests/functional/networkTests.py
Line 139: func(*args, **kwargs)
Line 140: except Exception:
Line 141: # cleanup
Line 142: instance = args[0]
Line 143: instance.vdsm_net.restoreNetConfig()
Very right!
Line 144: raise
Line 145: return wrapper
Line 146:
Line 147: @cleanupNet
File tests/functional/utils.py
Line 118: self.vdscli.setSafeNetworkConfig()
Line 119:
Line 120: @netinfo_altering
Line 121: def restoreNetConfig(self):
Line 122: restore(sudo=True)
Done
Line 123:
Line 124: @netinfo_altering
Line 125: def addNetwork(self, bridge, vlan=None, bond=None, nics=None,
opts=None):
Line 126: result = self.vdscli.addNetwork(bridge,
--
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4968/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4082/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4892/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 30: Thanks a lot for the reviews Yaniv! -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoiding automatically restart of sanlock service when starting vdsmd .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4969/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4083/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4893/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4970/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4084/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4894/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 31: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4971/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4085/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4895/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/689/ : FAILURE -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 31: Verified-1 -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix bonding races
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix bonding races .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4972/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4086/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4896/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/690/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I619680ac3846e317e269d46d722a39e9cbf3c36b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: config logging in spawned process
Zhou Zheng Sheng has abandoned this change. Change subject: remoteFileHandler: config logging in spawned process .. Abandoned http://gerrit.ovirt.org/14626 covers this case and it's simpler. -- To view, visit http://gerrit.ovirt.org/9182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
