Change in vdsm[master]: hsm: Fix race when checking visible devices readability
Ayal Baron has posted comments on this change.
Change subject: hsm: Fix race when checking visible devices readability
..
Patch Set 1:
(1 comment)
File vdsm/storage/hsm.py
Line 2009: if visibility[guid]:
Line 2010: path = os.path.join('/dev/mapper', guid)
Line 2011: try:
Line 2012: mode = os.stat(path).st_mode
Line 2013: visibility[guid] = mode stat.S_IRUSR != 0
this line should not be in the try clause as it cannot throw and ENOENT
exception
Line 2014: except OSError as e:
Line 2015: if e.errno != errno.ENOENT:
Line 2016: raise
Line 2017: self.log.warning(device %s disappeared, path)
--
To view, visit http://gerrit.ovirt.org/21053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8628ebe2eb03f42761f8ee1faa648d75052983c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve err msg when multipath cant access a pv
Vered Volansky has posted comments on this change. Change subject: Improve err msg when multipath cant access a pv .. Patch Set 2: (5 comments) Accepted Dan's suggestion, will submit soon. Commit Message Line 3: AuthorDate: 2013-11-05 17:33:36 +0200 Line 4: Commit: Vered Volansky vvola...@redhat.com Line 5: CommitDate: 2013-11-10 13:40:15 +0200 Line 6: Line 7: Improve err msg when multipath cant access a pv Because there's a limit to how long the error message can be, and I'm a character away from that limit. Line 8: Line 9: InvalidPhysDev gave a cryptic error message - Invalid physical device. Line 10: The message was amended to Multipath cannot access storage device along Line 11: with the device name. The error key was changed according to the new Line 3: AuthorDate: 2013-11-05 17:33:36 +0200 Line 4: Commit: Vered Volansky vvola...@redhat.com Line 5: CommitDate: 2013-11-10 13:40:15 +0200 Line 6: Line 7: Improve err msg when multipath cant access a pv Wasn't there before, I thought it might fail the script. If it won't, will add. Line 8: Line 9: InvalidPhysDev gave a cryptic error message - Invalid physical device. Line 10: The message was amended to Multipath cannot access storage device along Line 11: with the device name. The error key was changed according to the new Line 7: Improve err msg when multipath cant access a pv Line 8: Line 9: InvalidPhysDev gave a cryptic error message - Invalid physical device. Line 10: The message was amended to Multipath cannot access storage device along Line 11: with the device name. The error key was changed according to the new Done to both. Line 12: message content. The only thing needed here by the engine is the Line 13: error code, which was not changed in this patch. Line 14: Line 15: Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e File vdsm/storage/hsm.py Line 2037: in multipath.getMPDevNamesIter()) Line 2038: size = 0 Line 2039: devices = [] Line 2040: Line 2041: for dev in devlist: More important does not mean the other issue is NOT important. Current situation is exception-name almost equals already-agreed-upon-bad-message. Why do you want to fix the whole thing and then have an exception name that turns not really related to it's error message? What if were totally different? would you still want the older exception name? I think you should look at this extremity to decide, and if you still think the naming should remain the same please explain why. Line 2042: if dev in knowndevs: Line 2043: devices.append(dev) Line 2044: size += multipath.getDeviceSize(devicemapper.getDmId(dev)) Line 2045: else: File vdsm/storage/storage_exception.py Line 1456: class InaccessiblePhysDev(StorageException): Line 1457: def __init__(self, pvname): Line 1458: self.value = pvname=%s % (pvname) Line 1459: code = 606 Line 1460: message = Multipath cannot access storage device Ack. Note that when digging into the code in this exact flow the same devices are referred to as pvs. Maybe this should be changed as well (in a different patch, of course). Line 1461: Line 1462: Line 1463: class PartitionedPhysDev(StorageException): Line 1464: code = 607 -- To view, visit http://gerrit.ovirt.org/21089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG
Ayal Baron has posted comments on this change. Change subject: Invalidate filters on HSMs before rescanning extended VG .. Patch Set 18: Dan, clearly there is not enough clarity on the flow which is leading you to wrongly think there is a race here. The flow is: on SPM host: discover and connect to storage (optional) getDeviceList in GUI choose a new device to add to domain Now *before* vgextend is run, on *all* hosts: discover and connect to storage (if needed) getDevicesVisibility Only after all hosts have reported that the new device(s) is visible (and filter is up to date) do we go back to the spm and run: vgextend On top of all this, a host only moves to non-op after *5* minutes !!! (to differentiate between host and total storage failure). So now is it clear that there is no race? -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5316/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5394/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: First try the fast path, deactivating the whole vg. It it fails, try to deactivate active lvs. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Yaniv Bronhaim has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 4: (21 comments) Commit Message Line 13: corruption sooner or later, when a vm is trying to write to logical Line 14: volume with stale metadata. Line 15: Line 16: This patch adds new vdsm-tool lvm-deactivate-lvs command, deactivating Line 17: vdsm active logical volumes. The command is invoked during boot as part the invocation is not part of that patch.. why not? Line 18: of vdsmd pre-start. If vdsmd was disabled during boot, or an older vdsm Line 19: version was started during boot, the command is invoked in the first Line 20: time vdsmd is started. Line 21: Line 23: running vms, the lvm-deactivate-lvs command does not deactivate open Line 24: devices. Line 25: Line 26: We chose this solution because it is compatible with all upstream and Line 27: downstream supported versions, easy to implement, and does not require s/ all upstream and downstreadm supported versions/ all vdsm supported versions Line 28: changes in vdsm delicate runtime. Line 29: Line 30: We considered several other solutions: Line 31: - Using volume_list lvm configuration: By adding system vgs to this Line 38: - Modifying system init scripts: We rejected this because it is not Line 39: their responsibility to activate only certain vgs, and touching them is Line 40: last resort. Line 41: Line 42: This patch should be easy to backport to RHEV 3.2, invoking the new should be ovirt 3.2 ? or shouldn't mentioned at all Line 43: vdsm-tool command from the legacy vdsmd.init script instead of pre-start Line 44: available only in ovirt 3.3. Line 45: Line 46: Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 File lib/vdsm/tool/lvm_deactivate_lvs.py Line 18: # Line 19: Line 20: Line 21: When using FC storage, physical volumes are connected during boot, and vdsm Line 22: logical volumes are auto-activated during boot. These volumes do not pick commit message is enough Line 23: changes done by the SPM on the storage, which may lead to data corruption Line 24: sooner or later, when a vm is trying to write to logical volume with stale Line 25: metadata. Line 26: Line 33: import sys Line 34: Line 35: from vdsm import tool Line 36: from vdsm import utils Line 37: from vdsm import constants use: from .. import tool, utils, constants Line 38: Line 39: NAME = 'lvm-deactivate-lvs' Line 40: RUN_FILE = os.path.join(constants.P_VDSM_RUN, NAME) Line 41: Line 36: from vdsm import utils Line 37: from vdsm import constants Line 38: Line 39: NAME = 'lvm-deactivate-lvs' Line 40: RUN_FILE = os.path.join(constants.P_VDSM_RUN, NAME) no need for NAME: RUN_FILE = os.path.join(constants.P_VDSM_RUN, 'lvm-deactivate-lvs') Line 41: Line 42: LVM_SEPARATOR = | Line 43: Line 44: # Tags used to detect vdsm FC vgs Line 38: Line 39: NAME = 'lvm-deactivate-lvs' Line 40: RUN_FILE = os.path.join(constants.P_VDSM_RUN, NAME) Line 41: Line 42: LVM_SEPARATOR = | private? Line 43: Line 44: # Tags used to detect vdsm FC vgs Line 45: VG_SD_TAG = RHAT_storage_domain Line 46: VG_FCP_TAG = MDT_TYPE=FCP Line 48: Line 49: class Error(Exception): Line 50: Line 51: Raised for expected errors in this module. Line 52: pass ? can you give it more meaningful name than Error? why not using RuntimeError? Line 53: Line 54: Line 55: @tool.expose(NAME) Line 56: def main(*args, **kwargs): Line 51: Raised for expected errors in this module. Line 52: Line 53: Line 54: Line 55: @tool.expose(NAME) please use a string explicitly as in all pys. should me - deactivate-lvs Line 56: def main(*args, **kwargs): Line 57: Line 58: Deactivates unused vdsm volume lvs. Line 59: Line 52: Line 53: Line 54: Line 55: @tool.expose(NAME) Line 56: def main(*args, **kwargs): why main? call it def deactivate_lvs Line 57: Line 58: Deactivates unused vdsm volume lvs. Line 59: Line 60: try: Line 56: def main(*args, **kwargs): Line 57: Line 58: Deactivates unused vdsm volume lvs. Line 59: Line 60: try: cover try only where needed. Line 61: if was_run(): Line 62: log(already run) Line 63: return 0 Line 64: set_was_run() Line 71: log(no vgs found) Line 72: return 0 Line 73: except Error as e: Line 74: log(e) Line 75: return 1 should raise an error on failures Line 76: Line 77: Line 78: def log(msg): Line 79: sys.stderr.write(%s: %s\n % (NAME, msg)) Line 74: log(e) Line 75: return 1 Line 76: Line 77: Line 78: def log(msg): we don't do it anywhere else.. why do you add it here? just call to sys.stderr whenever you need please. Line 79: sys.stderr.write(%s: %s\n % (NAME, msg)) Line 80: Line 81: Line
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Yaniv Bronhaim has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: Code-Review-1 see my comments on ps4. thanks -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Yaniv Bronhaim has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: (1 comment) File lib/vdsm/tool/lvm_deactivate_lvs.py Line 135: return lv_attr[5] == o Line 136: Line 137: Line 138: def deactivate_vg(vg): Line 139: log(deactivating %s % vg) stderr?! Line 140: rc, out, err = lvm(vgchange, --available, n, vg) Line 141: if rc != 0: Line 142: raise Error(Error deactivating %s: %s % (vg, err)) Line 143: -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster prepareImage: return gluster-specific information
Sandro Bonazzola has posted comments on this change. Change subject: gluster prepareImage: return gluster-specific information .. Patch Set 4: Code-Review+1 python code looks good to me. -- To view, visit http://gerrit.ovirt.org/21059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9a8fbf2baafa1f9bfc3677b1301c7934ca74651 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: decommission GlusterVolume
Dan Kenigsberg has uploaded a new change for review.
Change subject: gluster: decommission GlusterVolume
..
gluster: decommission GlusterVolume
GlusterVolume has no semantics beyond these of any other FileVolume.
Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/storage/glusterSD.py
D vdsm/storage/glusterVolume.py
4 files changed, 0 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/21124/1
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 55464a3..dd447f6 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -89,7 +89,6 @@
./usr/share/vdsm/storage/fileVolume.py
./usr/share/vdsm/storage/fuser.py
./usr/share/vdsm/storage/glusterSD.py
-./usr/share/vdsm/storage/glusterVolume.py
./usr/share/vdsm/storage/hba.py
./usr/share/vdsm/storage/hsm.py
./usr/share/vdsm/storage/image.py
diff --git a/vdsm.spec.in b/vdsm.spec.in
index de066f5..714b11d 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -880,7 +880,6 @@
%{_datadir}/%{vdsm_name}/storage/fuser.py*
%if 0%{?with_gluster}
%{_datadir}/%{vdsm_name}/storage/glusterSD.py*
-%{_datadir}/%{vdsm_name}/storage/glusterVolume.py*
%else
%exclude %{_datadir}/%{vdsm_name}/storage/gluster*
%endif
diff --git a/vdsm/storage/glusterSD.py b/vdsm/storage/glusterSD.py
index 7458d10..c048dbd 100644
--- a/vdsm/storage/glusterSD.py
+++ b/vdsm/storage/glusterSD.py
@@ -1,7 +1,6 @@
import os
import nfsSD
import sd
-import glusterVolume
import fileSD
import mount
import storage_exception as se
@@ -15,9 +14,6 @@
def getMountPoint(cls, mountPath):
return os.path.join(cls.storage_repository,
sd.DOMAIN_MNT_POINT, sd.GLUSTERSD_DIR, mountPath)
-
-def getVolumeClass(self):
-return glusterVolume.GlusterVolume
@staticmethod
def findDomainPath(sdUUID):
diff --git a/vdsm/storage/glusterVolume.py b/vdsm/storage/glusterVolume.py
deleted file mode 100644
index 1406cdd..000
--- a/vdsm/storage/glusterVolume.py
+++ /dev/null
@@ -1,9 +0,0 @@
-import fileVolume
-
-
-class GlusterVolume(fileVolume.FileVolume):
-
-def __init__(self, repoPath, sdUUID, imgUUID, volUUID):
-fileVolume.FileVolume.__init__(self, repoPath, sdUUID, imgUUID,
- volUUID)
-
--
To view, visit http://gerrit.ovirt.org/21124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: prepareImage: decommission volType from gluster info
Dan Kenigsberg has uploaded a new change for review.
Change subject: prepareImage: decommission volType from gluster info
..
prepareImage: decommission volType from gluster info
If hsm.prepareImage returns gluster info, vm.Vm can simply use it,
instead of checking for the value of 'volType' which carry zero
additional information.
Change-Id: I720b4b145e63899584e601d01fd423eb016583e4
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/storage/glusterSD.py
M vdsm/storage/sd.py
M vdsm/vm.py
3 files changed, 5 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/21123/1
diff --git a/vdsm/storage/glusterSD.py b/vdsm/storage/glusterSD.py
index 492413f..7458d10 100644
--- a/vdsm/storage/glusterSD.py
+++ b/vdsm/storage/glusterSD.py
@@ -60,7 +60,6 @@
'protocol': 'gluster', 'volPort': volPort,
'volTransport': volTrans,
'volfileServer': volfileServer,
-'volType': 'network',
}
def findDomain(sdUUID):
diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py
index 31759df..127f36d 100644
--- a/vdsm/storage/sd.py
+++ b/vdsm/storage/sd.py
@@ -784,4 +784,4 @@
pass
def getExtraVolumeInfo(self, volPath):
-return {'volType': 'path'}
+return {}
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 4922bb0..eca8641 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1421,18 +1421,7 @@
((self.apparentsize + constants.MEGAB - 1) / constants.MEGAB))
@property
-def networkDev(self):
-try:
-return self.volumeInfo['volType'] == network
-except AttributeError:
-# To handle legacy and removable drives.
-return False
-
-@property
def blockDev(self):
-if self.networkDev:
-return False
-
if self._blockDev is None:
try:
self._blockDev = utils.isBlockDevice(self.path)
@@ -1547,10 +1536,7 @@
self.device = getattr(self, 'device', 'disk')
source = XMLElement('source')
-if self.blockDev:
-deviceType = 'block'
-source.setAttrs(dev=self.path)
-elif self.networkDev:
+if 'protocol' in getattr(self, 'volumeInfo', {}):
deviceType = 'network'
source.setAttrs(protocol=self.volumeInfo['protocol'],
name=self.volumeInfo['path'])
@@ -1558,6 +1544,9 @@
'port': self.volumeInfo['volPort'],
'transport': self.volumeInfo['volTransport']}
source.appendChildWithArgs('host', **hostAttrs)
+elif self.blockDev:
+deviceType = 'block'
+source.setAttrs(dev=self.path)
else:
deviceType = 'file'
sourceAttrs = {'file': self.path}
--
To view, visit http://gerrit.ovirt.org/21123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I720b4b145e63899584e601d01fd423eb016583e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage.glusterVolume.getVmVolInfo: move logic to storage do...
Dan Kenigsberg has uploaded a new change for review.
Change subject: storage.glusterVolume.getVmVolInfo: move logic to storage domain
..
storage.glusterVolume.getVmVolInfo: move logic to storage domain
volume.getVmVolInfo is never used. The only usage of
glusterVolume.getVmVolInfo requires a cumbersome production of a
glusterVolume object. This patch moves the logic into the storage
domain, and enable the complete removal of glusterVolume in a subsequent
patch.
Change-Id: I05352ee60546f03b8e6272abbdd923d0ec6074b7
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/storage/glusterSD.py
M vdsm/storage/glusterVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/sd.py
M vdsm/storage/volume.py
5 files changed, 39 insertions(+), 66 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/21122/1
diff --git a/vdsm/storage/glusterSD.py b/vdsm/storage/glusterSD.py
index 2931083..492413f 100644
--- a/vdsm/storage/glusterSD.py
+++ b/vdsm/storage/glusterSD.py
@@ -5,6 +5,8 @@
import fileSD
import mount
import storage_exception as se
+import supervdsm
+from gluster.exception import GlusterException
class GlusterStorageDomain(nfsSD.NfsStorageDomain):
@@ -27,6 +29,39 @@
raise se.StorageDomainDoesNotExist(sdUUID)
+def getExtraVolumeInfo(self, volPath):
+volfileServer, gvolname = self.getRemotePath().rsplit(:, 1)
+
+# Volume transport to Libvirt transport mapping
+VOLUME_TRANS_MAP = {'TCP': 'tcp', 'RDMA': 'rdma'}
+
+# Extract the volume's transport using gluster cli
+svdsmProxy = supervdsm.getProxy()
+try:
+volInfo = svdsmProxy.glusterVolumeInfo(gvolname, volfileServer)
+volTrans = VOLUME_TRANS_MAP[volInfo[gvolname]['transportType'][0]]
+except GlusterException:
+# In case of issues with finding transport type, default to tcp
+self.log.warning(Unable to find transport type for GlusterFS
+ volume %s. GlusterFS server = %s.
+ Defaulting to tcp,
+ (gvolname, volfileServer), exc_info=True)
+volTrans = VOLUME_TRANS_MAP['TCP']
+
+# Use default port
+volPort = 0
+
+# sdUUID/images/imgUUID/volUUID
+imgFileRelPath = '/'.join(volPath.rsplit(/)[-4:])
+
+glusterPath = gvolname + '/' + imgFileRelPath
+
+return {'path': glusterPath,
+'protocol': 'gluster', 'volPort': volPort,
+'volTransport': volTrans,
+'volfileServer': volfileServer,
+'volType': 'network',
+}
def findDomain(sdUUID):
return GlusterStorageDomain(GlusterStorageDomain.findDomainPath(sdUUID))
diff --git a/vdsm/storage/glusterVolume.py b/vdsm/storage/glusterVolume.py
index 3368de3..1406cdd 100644
--- a/vdsm/storage/glusterVolume.py
+++ b/vdsm/storage/glusterVolume.py
@@ -1,8 +1,4 @@
-from volume import VmVolumeInfo
import fileVolume
-from sdc import sdCache
-import supervdsm as svdsm
-from gluster.exception import GlusterException
class GlusterVolume(fileVolume.FileVolume):
@@ -11,44 +7,3 @@
fileVolume.FileVolume.__init__(self, repoPath, sdUUID, imgUUID,
volUUID)
-def getVmVolumeInfo(self):
-
-Send info to represent Gluster volume as a network block device
-
-rpath = sdCache.produce(self.sdUUID).getRemotePath()
-rpath_list = rpath.rsplit(:, 1)
-volfileServer = rpath_list[0]
-volname = rpath_list[1]
-
-# Volume transport to Libvirt transport mapping
-VOLUME_TRANS_MAP = {'TCP': 'tcp', 'RDMA': 'rdma'}
-
-# Extract the volume's transport using gluster cli
-svdsmProxy = svdsm.getProxy()
-
-try:
-volInfo = svdsmProxy.glusterVolumeInfo(volname, volfileServer)
-volTrans = VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]]
-except GlusterException:
-# In case of issues with finding transport type, default to tcp
-self.log.warning(Unable to find transport type for GlusterFS
- volume %s. GlusterFS server = %s.
- Defaulting to tcp,
- (volname, volfileServer), exc_info=True)
-volTrans = VOLUME_TRANS_MAP['TCP']
-
-# Use default port
-volPort = 0
-
-imgFilePath = self.getVolumePath()
-imgFilePath_list = imgFilePath.rsplit(/)
-
-# Extract path to the image, relative to the gluster mount
-imgFileRelPath = /.join(imgFilePath_list[-4:])
-
-glusterPath = volname + '/' + imgFileRelPath
-
-return {'volType': VmVolumeInfo.TYPE_NETWORK, 'path': glusterPath,
-'protocol': 'gluster', 'volPort': volPort,
-'volTransport': volTrans,
-
Change in vdsm[master]: prepareImage: decommission volType from gluster info
oVirt Jenkins CI Server has posted comments on this change. Change subject: prepareImage: decommission volType from gluster info .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4518/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5318/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5396/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I720b4b145e63899584e601d01fd423eb016583e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage.glusterVolume.getVmVolInfo: move logic to storage do...
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage.glusterVolume.getVmVolInfo: move logic to storage domain .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4517/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5317/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5395/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05352ee60546f03b8e6272abbdd923d0ec6074b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: decommission GlusterVolume
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: decommission GlusterVolume .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4519/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5319/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5397/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 32: Verified+1 -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 6: Address Yaniv comments: - Commit message cleanup - Use new style imports - Rename Error to clarify its role - Rename find_ function to _iter to clarify their usage - Rename lvm to run_lvm conforming with other commands -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: performs peer detach using host UUID if provided
Darshan N has posted comments on this change. Change subject: gluster: performs peer detach using host UUID if provided .. Patch Set 3: I have restructured the patch as per the suggestions. -- To view, visit http://gerrit.ovirt.org/20648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage.glusterVolume.getVmVolInfo: move logic to storage do...
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage.glusterVolume.getVmVolInfo: move logic to storage domain .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4522/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5322/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5400/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05352ee60546f03b8e6272abbdd923d0ec6074b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 32: (1 comment) File debian/vdsm-python.install Line 17: ./usr/lib/python2.7/dist-packages/vdsm/tool/load_needed_modules.py Line 18: ./usr/lib/python2.7/dist-packages/vdsm/tool/nwfilter.py Line 19: ./usr/lib/python2.7/dist-packages/vdsm/tool/passwd.py Line 20: ./usr/lib/python2.7/dist-packages/vdsm/tool/restore_nets.py Line 21: Introducing configurator package in vdsm-tool ah?! can't be its a lie. Line 22: ./usr/lib/python2.7/dist-packages/vdsm/tool/seboolsetup.py Line 23: ./usr/lib/python2.7/dist-packages/vdsm/tool/service.py Line 24: ./usr/lib/python2.7/dist-packages/vdsm/tool/transient.py Line 25: ./usr/lib/python2.7/dist-packages/vdsm/tool/validate_ovirt_certs.py -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: iscsi: Iscsi rescan cleanup
Saggi Mizrahi has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: iscsi: Iscsi rescan cleanup
Saggi Mizrahi has uploaded a new change for review.
Change subject: iscsi: Iscsi rescan cleanup
..
iscsi: Iscsi rescan cleanup
* Remove forceIscsiScan(): iscsiadm already does that when refreshing
sessions
* Cleanup iscsi.rescan(): Replace complex logic with a simpler
implementation since new iscsiadm takes care of all of this itself
* Make iscsi.rescan() more testable
* Test confusing timeout semantics of iscsi.rescan()
Bug-Url: https://bugzilla.redhat.com/964595
Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd
Signed-off-by: Saggi Mizrahi smizr...@redhat.com
---
M tests/Makefile.am
A tests/iscsiTests.py
M vdsm.spec.in
M vdsm/storage/iscsi.py
M vdsm/storage/iscsiadm.py
M vdsm/storage/multipath.py
M vdsm/supervdsmServer
7 files changed, 111 insertions(+), 62 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/21136/1
diff --git a/tests/Makefile.am b/tests/Makefile.am
index f87eddd..5efae38 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -37,6 +37,7 @@
guestIFTests.py \
hooksTests.py \
ipwrapperTests.py \
+ iscsiTests.py \
jsonRpcTests.py \
jsonRpcUtils.py \
libvirtconnectionTests.py \
diff --git a/tests/iscsiTests.py b/tests/iscsiTests.py
new file mode 100644
index 000..44f6962
--- /dev/null
+++ b/tests/iscsiTests.py
@@ -0,0 +1,80 @@
+import threading
+import time
+from contextlib import contextmanager
+
+from testrunner import VdsmTestCase as TestCaseBase
+
+from storage import iscsi
+
+
+class AsyncStubOperation(object):
+def __init__(self, timeout):
+self._evt = threading.Event()
+if timeout == 0:
+self._evt.set()
+else:
+threading.Timer(timeout, self._evt.set)
+
+def wait(self, timeout=None, cond=None):
+if cond is not None:
+raise Exception(TODO!!!)
+
+self._evt.wait(timeout)
+
+def stop(self):
+self._evt.set()
+
+def result(self):
+if self._evt.is_set():
+return (None, None)
+else:
+return None
+
+
+class RescanTimeoutTests(TestCaseBase):
+def setUp(self):
+self._iscsiadm_rescan_async = \
+iscsi.iscsiadm.session_rescan_async
+iscsi.iscsiadm.session_rescan_async = self._iscsi_stub
+self._timeout = 0
+
+def tearDown(self):
+iscsi.iscsiadm.session_rescan_async = \
+self._iscsiadm_rescan_async
+
+def _iscsi_stub(self):
+return AsyncStubOperation(self._timeout)
+
+@contextmanager
+def assertMaxDuration(self, maxtime):
+start = time.time()
+try:
+yield
+finally:
+end = time.time()
+elapsed = end - start
+if maxtime elapsed:
+self.fail(Operation was too slow %fs %fs %
+ (elapsed, maxtime))
+
+@contextmanager
+def assertMinDuration(self, mintime):
+start = time.time()
+try:
+yield
+finally:
+end = time.time()
+elapsed = end - start
+if mintime elapsed:
+self.fail(Operation was too fast %fs %fs %
+ (elapsed, mintime))
+
+def testFast(self):
+self._timeout = 0
+with self.assertMinDuration(2):
+iscsi.rescan(2, 4)
+
+def testSlow(self):
+self._timeout = 60
+with self.assertMaxDuration(3):
+iscsi.rescan(1, 2)
diff --git a/vdsm.spec.in b/vdsm.spec.in
index b0b89a1..cae9cab 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -146,7 +146,7 @@
# Update the qemu-kvm requires when block_stream will be included
Requires: qemu-kvm = 2:0.12.1.2-2.295.el6_3.4
Requires: qemu-img = 2:0.12.1.2-2.295.el6_3.4
-Requires: iscsi-initiator-utils = 6.2.0.872-15
+Requires: iscsi-initiator-utils = 6.2.0.873-3
Requires: device-mapper-multipath = 0.4.9-52
Requires: e2fsprogs = 1.41.12-11
Requires: fence-agents
diff --git a/vdsm/storage/iscsi.py b/vdsm/storage/iscsi.py
index 7da94ab..f4fdceb 100644
--- a/vdsm/storage/iscsi.py
+++ b/vdsm/storage/iscsi.py
@@ -30,7 +30,6 @@
import time
from collections import namedtuple
-from vdsm import constants
import misc
from vdsm.config import config
import devicemapper
@@ -373,38 +372,15 @@
@misc.samplingmethod
-def rescan():
-try:
-iscsiadm.session_rescan()
-except iscsiadm.IscsiError:
-pass
+def rescan(minTimeout=None, maxTimeout=None):
+# FIXME: This whole thing is wrong from the core. We need to make rescan
+#completely async and have methods timeout on their own if they
+#can't find the devices they are looking for
+if minTimeout is None:
+minTimeout = config.getint('irs', 'scsi_rescan_minimal_timeout')
+if maxTimeout is None:
+maxTimeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
-
-@misc.samplingmethod
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 16: (1 comment) File lib/vdsm/tool/unified_persistence.py Line 129: def unified_persistence(): Line 130: Line 131: Upgrade host networking persistence from ifcfg to unified if the Line 132: persistence model is set as unified in /usr/lib64/python2.X/site-packages/ Line 133: vdsm/config.py after seeing http://gerrit.ovirt.org/#/c/20803/3/lib/vdsm/tool/upgrade_300_networks.py , I understand that you are not the only one that provides such explanation here. I'll try to think about better solution for detailed and short description Line 134: Line 135: unifiedPersistenceUpgrade = UnifiedPersistence() Line 136: upgradeName = UnifiedPersistence.__name__ Line 137: upgrade = Upgrade(upgradeName) -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Ayal Baron has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: utils: Create AsyncProcessOperation
Saggi Mizrahi has uploaded a new change for review. Change subject: utils: Create AsyncProcessOperation .. utils: Create AsyncProcessOperation This is an object to wrap a process so it can be treated as an AsyncOperation. Features: * Takes care of pid collection * Has pluggable output parsing * Process appropriate implementation of wait() and stop() Related-Bug-Url: http://bugzilla.redhat.com/964595 Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Signed-off-by: Saggi Mizrahi smizr...@redhat.com --- M lib/vdsm/utils.py M tests/utilsTests.py 2 files changed, 113 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/21135/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index d3e0c2b..14f9dfa 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -48,6 +48,7 @@ import subprocess import threading import time +import zombiereaper from cpopen import CPopen as BetterPopen from config import config @@ -914,6 +915,55 @@ time.sleep(sleep) +class AsyncProcessOperation(object): +def __init__(self, proc, resultParser=None): +Wraps a running process operation. + +resultParser should be of type callback(rc, out, err) and can return +anything or throw exceptions. +self._lock = threading.Lock() + +self._result = None +self._resultParser = resultParser + +self._proc = proc + +def wait(self, timeout=None, cond=None): +Waits until the process has exited, the timeout has been reached or +the condition has been met +return self._proc.wait(timeout, cond) + +def stop(self): +Stops the running operation, effectively sending a kill signal to +the process +self._proc.kill() + +def result(self): +Returns the result in the as a tuple of (result, error). +If the operation is still running it will block until it returns. + +If no resultParser has been set the default result +is (rc, out, err) +with self._lock: +if self._result is None: +out, err = self._proc.communicate() +rc = self._proc.returncode +if self._resultParser is not None: +try: +self._result = (self._resultParser(rc, out, err), +None) +except Exception as e: +self._result = (None, e) +else: +self._result = ((rc, out, err), None) + +return self._result + +def __del__(self): +if self._proc.returncode is None: +zombiereaper.autoReapPID(self._proc.pid) + + def panic(msg): logging.error(Panic: %s, msg, exc_info=True) os.killpg(0, 9) diff --git a/tests/utilsTests.py b/tests/utilsTests.py index a6a222d..656c121 100644 --- a/tests/utilsTests.py +++ b/tests/utilsTests.py @@ -22,6 +22,7 @@ from testrunner import VdsmTestCase as TestCaseBase from vdsm import utils from storage import misc +import time class RetryTests(TestCaseBase): @@ -80,3 +81,65 @@ class GeneralUtilsTests(TestCaseBase): def testPanic(self): self.assertRaises(AssertionError, utils.panic, panic test) + + +class AsyncProcessOperationTests(TestCaseBase): +def _echo(self, text): +proc = misc.execCmd([echo, -n, test], sync=False) + +def parse(rc, out, err): +return out + +return utils.AsyncProcessOperation(proc, parse) + +def _sleep(self, t): +proc = misc.execCmd([sleep, str(t)], sync=False) +return utils.AsyncProcessOperation(proc) + +def _fail(self, t): +proc = misc.execCmd([sleep, str(t)], sync=False) + +def parse(rc, out, err): +raise Exception(TEST!!!) + +return utils.AsyncProcessOperation(proc, parse) + +def test(self): +aop = self._sleep(1) +self.assertEquals(aop.result(), ((0, , ), None)) + +def testAlreadyExitedSuccess(self): +aop = self._sleep(0) +time.sleep(1) +self.assertEquals(aop.result(), ((0, , ), None)) + +def testAlreadyExitedFail(self): +aop = self._sleep(hello) +time.sleep(1) +((rc, out, err), err) = aop.result() +self.assertEquals(err, None) +self.assertEquals(rc, 1) + +def testWait(self): +aop = self._sleep(1) +aop.wait(timeout=2) + +def testParser(self): +aop = self._echo(test) +self.assertEquals(aop.result(), (test, None)) + +def testStop(self): +aop = self._sleep(10) +aop.stop() + +start = time.time() +aop.result() +end = time.time() +duration = end - start +self.assertTrue(duration 2) + +def testException(self): +aop = self._fail(1) +res, err = aop.result() +self.assertEquals(res, None)
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: Fine - will add the pre-start invocation in this patch. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Dan Kenigsberg has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 33: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: utils: Create AsyncProcessOperation
Saggi Mizrahi has posted comments on this change. Change subject: utils: Create AsyncProcessOperation .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Dan Kenigsberg has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 32: Code-Review-1 (1 comment) File debian/vdsm-python.install Line 17: ./usr/lib/python2.7/dist-packages/vdsm/tool/load_needed_modules.py Line 18: ./usr/lib/python2.7/dist-packages/vdsm/tool/nwfilter.py Line 19: ./usr/lib/python2.7/dist-packages/vdsm/tool/passwd.py Line 20: ./usr/lib/python2.7/dist-packages/vdsm/tool/restore_nets.py Line 21: Introducing configurator package in vdsm-tool oh dear. Line 22: ./usr/lib/python2.7/dist-packages/vdsm/tool/seboolsetup.py Line 23: ./usr/lib/python2.7/dist-packages/vdsm/tool/service.py Line 24: ./usr/lib/python2.7/dist-packages/vdsm/tool/transient.py Line 25: ./usr/lib/python2.7/dist-packages/vdsm/tool/validate_ovirt_certs.py -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Quarantine ovirt-3.0.0 network upgrade
Yaniv Bronhaim has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 3:
(5 comments)
File init/vdsmd_init_common.sh.in
Line 200: return 0
Line 201: }
Line 202:
Line 203: task_upgrade_300_nets(){
Line 204: $VDSM_TOOL upgrade-3.0.0-networks
this and nwfilter require libvirtd service up to gather all information from
it. don't you prefer to verify it before running and report on failure, instead
of having weird print when libvirt is down when it runs? it might happen..
Line 205: }
Line 206: pre-start tasks end
Line 207:
Line 208:
File lib/vdsm/tool/upgrade_300_networks.py
Line 26: from vdsm.tool import expose
Line 27: from vdsm.tool.upgrade import Upgrade
Line 28:
Line 29: sys.path.append(/usr/share/vdsm)
Line 30: from netconf import ifcfg
more appropriate way of doing that is moving ifcfg to lib/vdsm, don't you think?
Line 31:
Line 32:
Line 33: def isNeeded(networks, bridges):
Line 34: return (MANAGEMENT_NETWORK not in networks and
Line 55: def upgrade_networks():
Line 56:
Line 57: Since ovirt-3.0, Vdsm uses libvirt networks (with names vdsm-*) to
store
Line 58: its own networks. Older Vdsms did not have those defined, and used
only
Line 59: linux bridges. This script is kept as an upgrade tool for the
(very few)
s\this command\this script
Line 60: people who still have such old setups running.
Line 61:
Line 62: upgradeName = '3.0.0-networks'
Line 63: upgrade = Upgrade(upgradeName)
File vdsm/clientIF.py
Line 399
Line 400
Line 401
Line 402
Line 403
so now it doesn't initializing much. you can move the setMaxOutgoingMigrations
to the main function and remove this private function.
Line 394: # we prefer running this code in external thread to avoid
blocking
Line 395: # API response.
Line 396: self._initializingLibvirt()
Line 397:
Line 398: vdsmVms = self._getVDSMVms()
now here will be the first try to communicate with libvirt. so the comment
above should move here
Line 399: #Recover
Line 400: for v in vdsmVms:
Line 401: vmId = v.UUIDString()
Line 402: if not self._recoverVm(vmId):
--
To view, visit http://gerrit.ovirt.org/20803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb21715dc3b92fc6c198dbb4c49f0bbef0cb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4525/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5325/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5403/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Alon Bar-Lev has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: Fine - will add the pre-start invocation in this patch. I am almost sure it will be simpler to write this logic entirely in the pre-start using shell. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Alon Bar-Lev has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: What do you mean by this logic? Whatever in: lib/vdsm/tool/lvm_deactivate_lvs.py -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 33: Verified+1 All honey :) -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: prepareImage: decommission volType from gluster info
oVirt Jenkins CI Server has posted comments on this change. Change subject: prepareImage: decommission volType from gluster info .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4523/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5323/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5401/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I720b4b145e63899584e601d01fd423eb016583e4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: decommission GlusterVolume
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: decommission GlusterVolume .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4524/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5324/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5402/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: performs peer detach using host UUID if provided
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: performs peer detach using host UUID if provided .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5321/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5399/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: What do you mean by this logic? -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 33: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4520/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5320/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5398/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing configurator package in vdsm-tool
Dan Kenigsberg has submitted this change and it was merged. Change subject: Introducing configurator package in vdsm-tool .. Introducing configurator package in vdsm-tool This package union libvirt and sanlock configuration operations for now. The package defines ModuleConfigure interface and API for modules configuration tool. The format for the configure command is modified to: vdsm-tool configure --module libvirt --force This module also provides is-configured and validate-config verbs with the same syntax. --force flag means the configure flow will stop all related services if needed. Without force, if one of the related services is running, the configure will fail. For reuse and easier additional configurers for other services, all the developer needs to add is an object that inherit ModuleConfigure and implements the interface for test, dry and configure, then adding the class to configurers. Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20100 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm-python.install M init/systemd/systemd-vdsmd.in M init/sysvinit/vdsmd.init.in M init/vdsmd_init_common.sh.in M lib/vdsm/tool/Makefile.am A lib/vdsm/tool/configurator.py D lib/vdsm/tool/libvirt_configure.py M lib/vdsm/tool/libvirt_configure.sh.in D lib/vdsm/tool/sanlock.py M vdsm.spec.in 10 files changed, 316 insertions(+), 218 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: Forgot to mention - this patch should not include the invocation from pre-start, to allow easy backport to 3.2, where there is no pre-start. Invocation will be a separate patch. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 4: (20 comments) Commit Message Line 13: corruption sooner or later, when a vm is trying to write to logical Line 14: volume with stale metadata. Line 15: Line 16: This patch adds new vdsm-tool lvm-deactivate-lvs command, deactivating Line 17: vdsm active logical volumes. The command is invoked during boot as part Not finished yet. Line 18: of vdsmd pre-start. If vdsmd was disabled during boot, or an older vdsm Line 19: version was started during boot, the command is invoked in the first Line 20: time vdsmd is started. Line 21: Line 23: running vms, the lvm-deactivate-lvs command does not deactivate open Line 24: devices. Line 25: Line 26: We chose this solution because it is compatible with all upstream and Line 27: downstream supported versions, easy to implement, and does not require Done Line 28: changes in vdsm delicate runtime. Line 29: Line 30: We considered several other solutions: Line 31: - Using volume_list lvm configuration: By adding system vgs to this Line 38: - Modifying system init scripts: We rejected this because it is not Line 39: their responsibility to activate only certain vgs, and touching them is Line 40: last resort. Line 41: Line 42: This patch should be easy to backport to RHEV 3.2, invoking the new I''l replace with ovirt-3.2. Line 43: vdsm-tool command from the legacy vdsmd.init script instead of pre-start Line 44: available only in ovirt 3.3. Line 45: Line 46: Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 File lib/vdsm/tool/lvm_deactivate_lvs.py Line 18: # Line 19: Line 20: Line 21: When using FC storage, physical volumes are connected during boot, and vdsm Line 22: logical volumes are auto-activated during boot. These volumes do not pick Commit message does not replace module documentation. To get the commit message you must search through history, reading multiple commit messages. The reader needs this info here. Line 23: changes done by the SPM on the storage, which may lead to data corruption Line 24: sooner or later, when a vm is trying to write to logical volume with stale Line 25: metadata. Line 26: Line 33: import sys Line 34: Line 35: from vdsm import tool Line 36: from vdsm import utils Line 37: from vdsm import constants I'll use absolute import. Line 38: Line 39: NAME = 'lvm-deactivate-lvs' Line 40: RUN_FILE = os.path.join(constants.P_VDSM_RUN, NAME) Line 41: Line 38: Line 39: NAME = 'lvm-deactivate-lvs' Line 40: RUN_FILE = os.path.join(constants.P_VDSM_RUN, NAME) Line 41: Line 42: LVM_SEPARATOR = | Module constant, see vdsm.storage.lvm. Line 43: Line 44: # Tags used to detect vdsm FC vgs Line 45: VG_SD_TAG = RHAT_storage_domain Line 46: VG_FCP_TAG = MDT_TYPE=FCP Line 48: Line 49: class Error(Exception): Line 50: Line 51: Raised for expected errors in this module. Line 52: pass is redundant when you have a docstring. This is *lvm_deactivate_lvs.Error* - meaning error in this module which should be treated differently then other errors. Used here to log the error and return a non-zero return code on expected failures. RuntimeError is a library error and should not be used in your code unless you want to make it harder for the caller to tell a real RuntimeError and your module sepcific errors. See http://docs.python.org/2.6/library/exceptions.html#exceptions.RuntimeError Line 53: Line 54: Line 55: @tool.expose(NAME) Line 56: def main(*args, **kwargs): Line 51: Raised for expected errors in this module. Line 52: Line 53: Line 54: Line 55: @tool.expose(NAME) Why not a constant? And why not lvm-deactivate-lvs, like libvirt-configure? Line 56: def main(*args, **kwargs): Line 57: Line 58: Deactivates unused vdsm volume lvs. Line 59: Line 52: Line 53: Line 54: Line 55: @tool.expose(NAME) Line 56: def main(*args, **kwargs): I took nwfilter as example - isn't the expose is enough to give info the the tool? Line 57: Line 58: Deactivates unused vdsm volume lvs. Line 59: Line 60: try: Line 56: def main(*args, **kwargs): Line 57: Line 58: Deactivates unused vdsm volume lvs. Line 59: Line 60: try: Entire function is covered so I can throw Error everywhere in this module when an expected failure is detected. This does not effect other exceptions anyway. For example, was_run does not throw an Error today, but if we start throwing it in the future, we don't have to change the main logic. Line 61: if was_run(): Line 62: log(already run) Line 63: return 0 Line 64: set_was_run() Line 71: log(no vgs found) Line 72: return 0 Line 73: except Error as e: Line 74: log(e) Line 75:
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Yaniv Bronhaim has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 13: Code-Review-1 (5 comments) Looks like all (or at least most) of this patch is about the logger that I don't want Commit Message Line 9: Unified network persistence feature: Line 10: http://www.ovirt.org/Feature/NetworkReloaded#Unified_persistence Line 11: Line 12: This patch is the first of two patches that implement an upgrade Line 13: that is the ran the first time VDSM that uses unified network remove the the Line 14: persistence is started. The goal is to look at the current Line 15: host networking configuration and populate the running config. Line 16: Line 17: Please see the next patch in the series: Line 16: Line 17: Please see the next patch in the series: Line 18: http://gerrit.ovirt.org/#/c/18425/ Line 19: Line 20: To better understand how this patch is used. the link to the wiki is enough .. you don't need to mention the next patch imo Line 21: Line 22: Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 File lib/vdsm/tool/upgrade.py Line 22: import os Line 23: Line 24: from vdsm import constants Line 25: Line 26: LOGGER_CONF_FILE = constants.P_VDSM_CONF + 'vdsm-tool.logger.conf' Please don't add this logger. I don't see the reason for it I don't mind if you want to submit it in separate patch and chat about it there Line 27: Line 28: Line 29: class Upgrade(object): Line 30: def __init__(self, upgradeName): Line 45: def seal(self): Line 46: Line 47: Mark the upgrade as a success Line 48: Line 49: self.log.debug(Upgrade %s successfully performed % self.upgradeName) use sys.stdout.write for that Line 46: Line 47: Mark the upgrade as a success Line 48: Line 49: self.log.debug(Upgrade %s successfully performed % self.upgradeName) Line 50: open(self.upgradeFilePath, 'w').close() can't be exception in this line? like permission errors and etc.. -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 5: (1 comment) File lib/vdsm/tool/lvm_deactivate_lvs.py Line 135: return lv_attr[5] == o Line 136: Line 137: Line 138: def deactivate_vg(vg): Line 139: log(deactivating %s % vg) Logging go to stderr - this command as meaningful output. Does it create any issue for the tool or for pre-start? Line 140: rc, out, err = lvm(vgchange, --available, n, vg) Line 141: if rc != 0: Line 142: raise Error(Error deactivating %s: %s % (vg, err)) Line 143: -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5326/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5404/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: introduce VmDeviceContainer
Martin Polednik has uploaded a new change for review.
Change subject: vmDevices: introduce VmDeviceContainer
..
vmDevices: introduce VmDeviceContainer
EARLY WORK IN PROGRESS: VmDeviceContainer is structure that will allow
us to store devices as a class instances while keeping backwards
compatibility with old self.conf['devices']
Change-Id: I65debd35115da078df0c0cb6f50c57feb984c5a3
Signed-off-by: Martin Polednik mpole...@redhat.com
---
M vdsm/vm.py
1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/21138/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 5ae54d7..36cdbb1 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1727,6 +1727,39 @@
return m
+class VmDeviceContainer(dict):
+@property
+def legacy(self):
+
+Return list of device dicts that represents backwards-compatible
+self.conf['devices']
+
+[..., {..., 'type': 'disk', ...}, ...]
+
+deviceList = []
+for key in self.keys():
+for device in self[key]:
+# loop through devices __slots__ and return all set attributes
+deviceList.append(dict((attr, getattr(device, attr))
+ for attr in device.__slots__
+ if hasattr(device, attr)))
+
+return deviceList
+
+def restoreLegacy(self, state):
+
+Reconstruct container using old self.conf['devices'] structure of
+
+[..., {..., 'type': 'disk', ...}, ...]
+to
+
+VmDeviceContainer[DISK_DEVICES] =
+[..., {..., 'type': 'disk', ...}, ...]
+
+for device in state:
+self[device['type']] = device
+
+
class Vm(object):
Used for abstracting communication between various parts of the
--
To view, visit http://gerrit.ovirt.org/21138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65debd35115da078df0c0cb6f50c57feb984c5a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rescan FC when rescanning for new multipath devices
Ayal Baron has posted comments on this change. Change subject: Rescan FC when rescanning for new multipath devices .. Patch Set 5: (1 comment) File vdsm/storage/multipath.py Line 107: Should only be called from hsm._rescanDevices() Line 108: Line 109: Line 110: # First ask fc and iSCSI to rescan all of their sessions Line 111: fc.rescan() rescan on miss is definitely warranted in this situation. of course the i/o is suspended only on these paths. These paths may be used by running VMs and issuing the lip is quite problematic here. refreshStorage is actually the place that worries me the most for this operation since it is used in too many flows and is the last place I would like to have it. Line 112: iscsi.rescan() Line 113: Line 114: # Now let multipath daemon pick up new devices Line 115: -- To view, visit http://gerrit.ovirt.org/19539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec939222676a24452e8825b36db68839bfd2bbc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: introduce VmDeviceContainer
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmDevices: introduce VmDeviceContainer .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4528/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5328/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5406/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65debd35115da078df0c0cb6f50c57feb984c5a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Alon Bar-Lev has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 7: Code-Review-1 OK, my note in more clear way. In master the implementation should be future maintainable not backward portable as suggested. This means that if the entire logic can be closed in shell at pre-start in a simple manner, add this to pre-start and not vdsm-tool. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: stop monitoring on detach storage domain
Ayal Baron has posted comments on this change. Change subject: sp: stop monitoring on detach storage domain .. Patch Set 1: this works on the spm, what about HSMs? does refreshStoragePool handle this properly? -- To view, visit http://gerrit.ovirt.org/21065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c202720fc183ca0c194780c659bd25e3cac7e19 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove irs_enable configuration attribute
oVirt Jenkins CI Server has posted comments on this change. Change subject: remove irs_enable configuration attribute .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5329/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5407/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove irs_enable configuration attribute
oVirt Jenkins CI Server has posted comments on this change. Change subject: remove irs_enable configuration attribute .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4530/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5330/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5408/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Ensure active LVs are refreshed before use.
Ayal Baron has posted comments on this change. Change subject: lvm: Ensure active LVs are refreshed before use. .. Patch Set 5: 2) erroneous activation (e.g. https://bugzilla.redhat.com/1009812 use case) We cannot assert that the volume wasn't altered or is not still in use (by the same or other reason) by other hosts. In such case refresh will not help. The cause should be fixed and not mitigated. Are we aware of other causes but the current BZ? If the volume is in use by some other host which is altering it then indeed there is nothing to do about it, but that is not the scenario nor is relevant to anything here. In case the LV was erroneously activated in the past on *this* host then *not* refreshing it can and will lead to corruption while refresh will avoid that at the cost of the possible performance hit you are referring to. corruption vs. perf hit... hmmm. The answer is clear cut to me. This is still +2 -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 7: In master the implementation should be future maintainable not backward portable as suggested. I think that backward portability is not less important than future maintainability. This means that if the entire logic can be closed in shell at pre-start in a simple manner, add this to pre-start and not vdsm-tool. I can re-implement this in shell and put this in vdsmd_init_common.sh, and then create another patch using same or similar shell script for downstream, but this will be more work and will be harder to test and maintain. I would like to have one file with the deactivation logic, that I can test separately from the context where it is used, and use the same file in both upstream and downstream. How about installing this Python script where vdsm_init_common.sh is, and invoking it from pre-start task function in upstream, and from vdsmd.init in downstream? -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2 ip link wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 ip link wrapper .. Patch Set 9: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/782/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4531/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5331/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5409/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Alon Bar-Lev has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 7: I can re-implement this in shell and put this in vdsmd_init_common.sh, and then create another patch using same or similar shell script for downstream, but this will be more work and will be harder to test and maintain. It won't be harder to maintain if I looking into the future. You ask people to maintain something that is not natural only because you want to save you work of backporting a patch one time? I do not understand. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2 ip link wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 ip link wrapper .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/783/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4532/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5332/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5410/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove irs_enable configuration attribute
Eduardo has posted comments on this change. Change subject: remove irs_enable configuration attribute .. Patch Set 2: Code-Review+1 (2 comments) File vdsm/clientIF.py Line 247: while self._enabled: Line 248: time.sleep(3) Line 249: Line 250: def _initIRS(self): Line 251: self.irs = None Can this be removed? If not, it should be under the except clause. Line 252: try: Line 253: self.irs = Dispatcher(HSM()) Line 254: except: Line 255: self.log.error(Error initializing IRS, exc_info=True) Line 250: def _initIRS(self): Line 251: self.irs = None Line 252: try: Line 253: self.irs = Dispatcher(HSM()) Line 254: except: I would like a narrow except only because you are touching it, but... Line 255: self.log.error(Error initializing IRS, exc_info=True) Line 256: else: Line 257: self.irs.registerDomainStateChangeCallback(self.contEIOVms) Line 258: -- To view, visit http://gerrit.ovirt.org/21141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 7: I can re-implement this in shell and put this in vdsmd_init_common.sh, and then create another patch using same or similar shell script for downstream, but this will be more work and will be harder to test and maintain. It won't be harder to maintain if I looking into the future. You ask people to maintain something that is not natural only because you want to save you work of backporting a patch one time? I do not understand. Looking into the future, we may find a bug in the deactivation code, and then we would have to fix both upstream copy and downstream copy. So not only we have more work now, we will have more work in the future. And of course adding this amount of logic to vdsmd_init_common.sh does not makes sense. This script already calls either vsdm-tool verbs or run other Python scritps like vdsm-restore-net-config. I think that same solution used for vdsm-restore-net-config is what we need here. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: stop monitoring on detach storage domain
Ayal Baron has posted comments on this change. Change subject: sp: stop monitoring on detach storage domain .. Patch Set 1: Code-Review+2 After discussing with Federico, HSM is irrelevant in this flow. There are 2 cases: 1. we're detaching a regular domain - it isn't monitored anyway so no concern 2. we're detaching the master domain and destroying the pool - in this case the domain is only monitored on the spm so again, no concern. +2 ing -- To view, visit http://gerrit.ovirt.org/21065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c202720fc183ca0c194780c659bd25e3cac7e19 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Alon Bar-Lev has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 7: Looking into the future, we may find a bug in the deactivation code, and then we would have to fix both upstream copy and downstream copy. So not only we have more work now, we will have more work in the future. nobody cares about downstream, this is upstream project. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: iscsi: Iscsi rescan cleanup
Dan Kenigsberg has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 1: Code-Review-1 This cleanup is quite widespread and quite new, so I would not like to see it in our already-delaying ovirt-3.3.1 version. Let's give it some testing time, and push it to ovirt-3.3.2. -- To view, visit http://gerrit.ovirt.org/21136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 7: We are not making any progress - lets talk only about upstream: Don't you think that separate easy to test script is better then dumping lot of hard to test code into vdsmd_init_common.sh? -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2 ip link wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 ip link wrapper .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/784/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4533/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5411/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Yaniv Bronhaim has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 7: Please add the pre-start \ backwards compatibility part as next patch that depends on this one. That way Alon and I will be able to continue reviewing the usage part and we'll might get into conclusion that the vdsm-tool verb is redundant , and we'll might not. lets see the usage logic first Thanks. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4534/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5412/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Handling topology for ppc64
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Handling topology for ppc64 .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4535/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5413/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/19875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Report fake capabilities
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Report fake capabilities .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4538/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5338/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5416/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/19396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb934eb8aff1ac0ce82ea5d5bd082afce6d9ba50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4536/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5414/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Create VMs for the POWER architecture
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Create VMs for the POWER architecture .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4537/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5337/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5415/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/18718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5026f254d8212f522836f856c2027c04b1d247 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2 ip link wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 ip link wrapper .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/784/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4533/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5417/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2 ip link wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 ip link wrapper .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4533/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5417/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/785/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Hello Sergey Gotliv,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21150
to review the following change.
Change subject: vm: prevent faulty volume extensions
..
vm: prevent faulty volume extensions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
Signed-off-by: Sergey Gotliv sgot...@redhat.com
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
M vdsm/vm.py
1 file changed, 36 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/21150/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index b39e5b9..75da883 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -2288,6 +2288,39 @@
continue
capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
+
+# Since the check based on nextPhysSize is extremly risky (it
+# may result in the VM being paused) we can't use the regular
+# getNextVolumeSize call as it relies on a cached value of the
+# drive apparentsize.
+nextPhysSize = physical + (
+config.getint('irs', 'volume_utilization_chunk_mb') *
+constants.MEGAB
+)
+
+# NOTE: the intent of this check is to prevent faulty images to
+# trick qemu in requesting extremely large extensions (BZ#998443).
+# Probably the definitive check would be comparing the allocated
+# space with capacity + format_overhead. Anyway given that:
+#
+# - format_overhead is tricky to be computed (it depends on few
+# assumptions that may change in the future e.g. cluster size)
+# - currently we allow only to extend by one chunk at time
+#
+# the current check compares alloc with the next volume size.
+# It should be noted that alloc cannot be directly compared with
+# the volume physical size as it includes also the clusters not
+# written yet (pending).
+if alloc nextPhysSize:
+self.log.error(
+Improbable extension request for volume %s on domain
+%s, pausing the VM to avoid corruptions (capacity: %s,
+allocated: %s, physical: %s, next physical size: %s),
+drive.volumeID, drive.domainID, capacity, alloc,
+physical, nextPhysSize)
+self.pause(pauseCode='EOTHER')
+return False
+
if physical - alloc drive.watermarkLimit:
extend.append((drive, capacity, alloc, physical))
@@ -2438,12 +2471,13 @@
if not guestCpuLocked:
self._guestCpuLock.release()
-def pause(self, afterState='Paused', guestCpuLocked=False):
+def pause(self, afterState='Paused', guestCpuLocked=False,
+ pauseCode='NOERR'):
if not guestCpuLocked:
self._acquireCpuLockWithTimeout()
try:
with self._confLock:
-self.conf['pauseCode'] = 'NOERR'
+self.conf['pauseCode'] = pauseCode
self._underlyingPause()
if hasattr(self, 'updateGuestCpuRunning'):
self.updateGuestCpuRunning()
--
To view, visit http://gerrit.ovirt.org/21150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: (1 comment) Commit Message Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Line 10: Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Line 11: Signed-off-by: Federico Simoncelli fsimo...@redhat.com Line 12: Signed-off-by: Sergey Gotliv sgot...@redhat.com Line 13: Signed-off-by: Federico Simoncelli fsimo...@redhat.com I'll remove one of my two entries. -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4539/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5339/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5418/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4540/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5340/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5419/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: configuring selinux allowing qemu-kvm to generate coredumps.
mooli tayer has posted comments on this change. Change subject: configuring selinux allowing qemu-kvm to generate coredumps. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia22181fe0c60ccab1cc8004213e216292ccc8283 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: configuring selinux allowing qemu-kvm to generate coredumps.
Yaniv Bronhaim has posted comments on this change. Change subject: configuring selinux allowing qemu-kvm to generate coredumps. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia22181fe0c60ccab1cc8004213e216292ccc8283 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: configuring selinux allowing qemu-kvm to generate coredumps.
Yaniv Bronhaim has submitted this change and it was merged. Change subject: configuring selinux allowing qemu-kvm to generate coredumps. .. configuring selinux allowing qemu-kvm to generate coredumps. this is a hack until we replce coredumping with abrt. Change-Id: Ia22181fe0c60ccab1cc8004213e216292ccc8283 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005031 Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20705 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21045 Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia22181fe0c60ccab1cc8004213e216292ccc8283 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Yaniv Bronhaim has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 13: (1 comment) File lib/vdsm/tool/upgrade.py Line 46: Line 47: Mark the upgrade as a success Line 48: Line 49: self.log.debug(Upgrade %s successfully performed % self.upgradeName) Line 50: open(self.upgradeFilePath, 'w').close() please create def touch(f, perm) in utils.py if you can.. that does exactly that, set permissions if specified and treat errors. -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: gluster prepareImage: return gluster-specific information
Dan Kenigsberg has posted comments on this change. Change subject: gluster prepareImage: return gluster-specific information .. Patch Set 1: Verified+1 verified by Samuli Heinonen. This patch fixes an ovirt-3.3.1 blocker. -- To view, visit http://gerrit.ovirt.org/21151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9a8fbf2baafa1f9bfc3677b1301c7934ca74651 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5342/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5421/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2 ip link wrapper
Dan Kenigsberg has posted comments on this change.
Change subject: iproute2 ip link wrapper
..
Patch Set 11: Code-Review-1
(5 comments)
File lib/vdsm/ipwrapper.py
Line 99:
Line 100: @staticmethod
Line 101: def _parse(text):
Line 102:
Line 103: Returns the Link attribute dictionary resulting from parsing
the text.
Nir, please explain why you think pep257 is wrong. I find the imperative form
less confusing then others.
Line 104:
Line 105: attrs = {}
Line 106: attrs['index'], attrs['name'], data = [el.strip() for el in
Line 107:text.split(':', 2)]
Line 127: range(0, len(tokens)-1, 2))
Line 128: return attrs
Line 129:
Line 130: @classmethod
Line 131: def fromText(cls, text, detection=True):
Doing a device type detection in a function called fromText is quite evil;
publishing this in the arg list is even worse. I believe that detection=False
is only for tests. If so, monkey-patch _detectType.
Line 132: Creates a Link object from the textual representation from
Line 133: iproute2's ip -o -d link show command.
Line 134: attrs = cls._parse(text)
Line 135: if 'linkType' not in attrs:
File lib/vdsm/netinfo.py
Line 113: hidden_bonds = config.get('vars', 'hidden_bonds').split(',')
Line 114: res = []
Line 115: try:
Line 116: for bond in open(BONDING_MASTERS).readline().split():
Line 117: if not anyFnmatch(bond, hidden_bonds):
I'd be happier if you introduce anyFnmatch() in its own patch.
Line 118: res.append(bond)
Line 119: except IOError as e:
Line 120: if e.errno == os.errno.ENOENT:
Line 121: return res
File lib/vdsm/utils.py
Line 947: sys.exit(-3)
Line 948:
Line 949:
Line 950: def pairwise(iterable):
Line 951: s - (s0,s1), (s1,s2), (s2, s3), ...
Copied from...
Attribution is important.
Line 952: a, b = itertools.tee(iterable)
Line 953: next(b, None)
Line 954: return itertools.izip(a, b)
Line 955:
File tests/functional/networkTests.py
Line 1504: Link class.
Line 1505: BIG_MTU = '2000'
Line 1506: VLAN_NAME = '%s.%s' % (BONDING_NAME, VLAN_ID)
Line 1507: with dummyIf(2) as nics:
Line 1508: with self.vdsm_net.pinger():
see my comment regaring pinger() in PS8
Line 1509: status, msg = self.vdsm_net.setupNetworks(
Line 1510: {NETWORK_NAME:
Line 1511: {'bonding': BONDING_NAME, 'bridged': True,
Line 1512: 'vlan': VLAN_ID, 'mtu': BIG_MTU}},
--
To view, visit http://gerrit.ovirt.org/21054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 8: Changes: - Remove module documentation - Remove debug logs - Prefix private names with _ - Raise RuntimeError on error and return 0 on success - Merge deactivate_vg and deactivate_lv, since the difference was confusing, and it is uninteresting implementation detail - When deactivating multiple lvs, call lvchange with all lvs instead of multiple calls. - Remove some pointless constants -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Nir Soffer has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 5:
(3 comments)
File vdsm/vm.py
Line 2279: self.log.debug('new rtc offset %s', timeOffset)
Line 2280: with self._confLock:
Line 2281: self.conf['timeOffset'] = timeOffset
Line 2282:
Line 2283: def checkDrivesForExtension(self):
This name is misleading - you don't expect that check will trigger an
extension.
How about:
def extendDrivesIfNeeded():
One can expect that this method will check which drives should be extended and
extend them.
Line 2284: extend = []
Line 2285:
Line 2286: for drive in self._devices[DISK_DEVICES]:
Line 2287: if not drive.blockDev or drive.format != 'cow':
Line 2298: drive.volumeID, drive.domainID, drive.apparentsize,
capacity,
Line 2299: alloc, physical)
Line 2300: self.extendDriveVolume(drive)
Line 2301:
Line 2302: return len(extend) 0
Now that we don't have the check for alloc capacity, why do we need the
extend list?
We can do:
extended = 0
for drive in drives:
skip irelevant drives
get drive info
if drive needs extension:
log
extend it
extended +=1
return extended
Line 2303:
Line 2304: def extendDriveVolume(self, vmDrive):
Line 2305: if not vmDrive.blockDev:
Line 2306: return
Line 4277: self.conf['pauseCode'] = err.upper()
Line 4278: self._guestCpuRunning = False
Line 4279: if err.upper() == 'ENOSPC':
Line 4280: if not self.checkDrivesForExtension():
Line 4281: self.log.info(No VM drives were extended)
Warning or an error?
Line 4282:
Line 4283: def _acpiShutdown(self):
Line 4284:
self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
Line 4285:
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add NetworkTest.testAddDelNetworkDhcp
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add NetworkTest.testAddDelNetworkDhcp
..
Patch Set 2: Code-Review-1
(10 comments)
Commit Message
Line 3: AuthorDate: 2013-11-10 19:37:57 +0100
Line 4: Commit: Petr Benas pbe...@redhat.com
Line 5: CommitDate: 2013-11-11 19:16:33 +0100
Line 6:
Line 7: tests: Add NetworkTest.testAddDelNetworkDhcp
please drop the angular brackets.
Line 8:
Line 9: Tests adding and deletion of network with dynamically
Line 10: assigned address. The dhcp package is required for this
Line 11: test, otherwise the test is skipped.
File tests/functional/Makefile.am
Line 29:utils.py \
Line 30:virtTests.py \
Line 31:storageTests.py \
Line 32:veth.py \
Line 33:dhcpd.py \
please keep sorted
Line 34:$(NULL)
Line 35:
Line 36: dist_vdsmfunctests_DATA = \
Line 37:60_test_balloon_shrink.policy \
File tests/functional/dhcpd.py
Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19:
Line 20: import tempfile
sort imports, please.
Line 21: import os
Line 22:
Line 23: from nose.plugins.skip import SkipTest
Line 24:
Line 24:
Line 25: from vdsm.utils import CommandPath
Line 26: from vdsm.utils import execCmd
Line 27:
Line 28: _DHCPD_BINARY = CommandPath('dhcpd', '/sbin/dhcpd')
you must raise SkipTest here, not later (please try!)
Line 29:
Line 30: dhcpdConfig = '''# minimalistic dhcpd configuration file
Line 31: authoritative;
Line 32:
Line 37:
Line 38:
Line 39: class Dhcpd():
Line 40: def __init__(self):
Line 41: self.configDir = ''
no need for transient value for self.configDir. Initialize it to
tempfile.mkdtemp() now.
but why do you need a directory? I see a singe configuration file.
Line 42: self.proc = ''
Line 43:
Line 44: def start(self, interface):
Line 45: self._checkDhcpdInstalled()
Line 38:
Line 39: class Dhcpd():
Line 40: def __init__(self):
Line 41: self.configDir = ''
Line 42: self.proc = ''
initialize to None
Line 43:
Line 44: def start(self, interface):
Line 45: self._checkDhcpdInstalled()
Line 46: self._writeConfigFile()
Line 48: '/dhcpd.conf', interface], sync=False)
Line 49:
Line 50: def stop(self):
Line 51: self.proc.kill()
Line 52: execCmd(['rm', '-rf', self.configDir])
use shutil.rmtree(), no need to exec.
Line 53:
Line 54: def _writeConfigFile(self):
Line 55: self.configDir = tempfile.mkdtemp()
Line 56: f = open(self.configDir + '/dhcpd.conf', 'w')
Line 52: execCmd(['rm', '-rf', self.configDir])
Line 53:
Line 54: def _writeConfigFile(self):
Line 55: self.configDir = tempfile.mkdtemp()
Line 56: f = open(self.configDir + '/dhcpd.conf', 'w')
use with, it is a much better practice.
Line 57: f.write(dhcpdConfig)
Line 58: f.close()
Line 59:
Line 60: def _checkDhcpdInstalled(self):
File tests/functional/networkTests.py
Line 1512: @permutations([[True], [False]])
Line 1513: @RequireVethMod
Line 1514: @ValidateRunningAsRoot
Line 1515: def testAddDelNetworkDhcp(self, bridged):
Line 1516: with vethIf() as nics:
the temporary nics variable is redundant
with vethIf() as (right, left)
btw, why right is on the left hand side of the pair?
Line 1517: (right, left) = nics
Line 1518: veth.setIP(right, IP_ADDRESS, IP_CIDR)
Line 1519: veth.setLinkUp(right)
Line 1520:
Line 1518: veth.setIP(right, IP_ADDRESS, IP_CIDR)
Line 1519: veth.setLinkUp(right)
Line 1520:
Line 1521: dhcpServer = dhcpd.Dhcpd()
Line 1522: dhcpServer.start(right)
this could be even cooler as a context manager. for your consideration.
Line 1523:
Line 1524: try:
Line 1525: status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
Line 1526:nics=[left],
--
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iproute2 ip link wrapper
Nir Soffer has posted comments on this change.
Change subject: iproute2 ip link wrapper
..
Patch Set 11:
(1 comment)
File lib/vdsm/ipwrapper.py
Line 99:
Line 100: @staticmethod
Line 101: def _parse(text):
Line 102:
Line 103: Returns the Link attribute dictionary resulting from parsing
the text.
It is wrong in general to tell people how to write. I read the docstirng, it is
clear and beautiful - good enough for me.
Line 104:
Line 105: attrs = {}
Line 106: attrs['index'], attrs['name'], data = [el.strip() for el in
Line 107:text.split(':', 2)]
--
To view, visit http://gerrit.ovirt.org/21054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
Nir Soffer has posted comments on this change. Change subject: vm: unify _highWrite and _onAbnormalStop .. Patch Set 5: (1 comment) File vdsm/vm.py Line 2298: drive.volumeID, drive.domainID, drive.apparentsize, capacity, Line 2299: alloc, physical) Line 2300: self.extendDriveVolume(drive) Line 2301: Line 2302: return len(extend) 0 I see that there is another patch depending on this, that will use the extend list. However if this patch will be merge without the other then we are left with strange code. The extend list should be added by the other patch. Line 2303: Line 2304: def extendDriveVolume(self, vmDrive): Line 2305: if not vmDrive.blockDev: Line 2306: return -- To view, visit http://gerrit.ovirt.org/20966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP]export a priviledged vdsm startup for supervdsm server
Itamar Heim has posted comments on this change. Change subject: [WIP]export a priviledged vdsm startup for supervdsm server .. Patch Set 4: ping? -- To view, visit http://gerrit.ovirt.org/11191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I540b1d3f3c823433f100f4803f31322fc7ee2153 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only run speed() on nic devices
Itamar Heim has posted comments on this change. Change subject: Only run speed() on nic devices .. Patch Set 4: ping? -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...
Itamar Heim has posted comments on this change. Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor and product id .. Patch Set 11: ping? -- To view, visit http://gerrit.ovirt.org/14237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Guglielmi david.guglie...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Itamar Heim has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: ping? -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: Do not reconfigure existing underlaying device for VLANs
Itamar Heim has posted comments on this change. Change subject: ifcfg: Do not reconfigure existing underlaying device for VLANs .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/16474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0738c32aefd6eca7fd094ad6f51d8a07353bb2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: remove the option implicitBonding
Itamar Heim has posted comments on this change. Change subject: configNetwork: remove the option implicitBonding .. Patch Set 3: ping? -- To view, visit http://gerrit.ovirt.org/17215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb6429a67d522e4a813494c45e90187d39fcdcd1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats
Itamar Heim has posted comments on this change. Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats .. Patch Set 3: ping? -- To view, visit http://gerrit.ovirt.org/11675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: skip validation on bonding's slaves on removal
Itamar Heim has posted comments on this change. Change subject: netconf: skip validation on bonding's slaves on removal .. Patch Set 3: ping? -- To view, visit http://gerrit.ovirt.org/17216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3da599fc5d68b65b2cae1da4181bde488d8949 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: enable multiple gateways for iproute2 configurator
Itamar Heim has posted comments on this change. Change subject: netconf: enable multiple gateways for iproute2 configurator .. Patch Set 7: ping? -- To view, visit http://gerrit.ovirt.org/16276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76e1225caffdb2de3073041e541c7c978eefb396 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: use defined options from configure
Itamar Heim has posted comments on this change. Change subject: use defined options from configure .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/18694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: make ifcfg's rollback cover new added networks
Itamar Heim has posted comments on this change. Change subject: netconf: make ifcfg's rollback cover new added networks .. Patch Set 3: ping? -- To view, visit http://gerrit.ovirt.org/17214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabcfb10119d303f81f505a6065e3139eddb3b049 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 9: Use same import for expose as used in other tool commands. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
