Change in vdsm[master]: Fix calculation of file volume allocated size
Allon Mureinik has posted comments on this change. Change subject: Fix calculation of file volume allocated size .. Patch Set 4: @Sergey, can you backport this to ovirt-3.3 too? -- To view, visit http://gerrit.ovirt.org/21490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71646199e2c0ac4564b832b8ebb202f49e289344 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath before loading lvm cache
Nir Soffer has posted comments on this change. Change subject: hsm: Rescan multipath before loading lvm cache .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ec7beee1db193a47d9e8109929badfd5b322c02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move reconnection info check to StoragePool
Ayal Baron has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool .. Patch Set 3: Code-Review-1 (5 comments) File vdsm/storage/hsm.py Line 1027: except se.StoragePoolUnknown: Line 1028: pass # pool not connected yet Line 1029: else: Line 1030: with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.shared): Line 1031: pool.update(hostID, scsiKey, msdUUID, masterVersion) after acquiring the lock we can't even be sure we're connected to the same pool (chances are slim, but still)... Line 1032: return True Line 1033: Line 1034: with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.exclusive): Line 1035: try: Line 1036: pool = self.getPool(spUUID) Line 1037: except se.StoragePoolUnknown: Line 1038: pass # pool not connected yet Line 1039: else: Line 1040: pool.update(hostID, scsiKey, msdUUID, masterVersion) same Line 1041: return True Line 1042: Line 1043: pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng) Line 1044: res = pool.connect(hostID, scsiKey, msdUUID, masterVersion) File vdsm/storage/sp.py Line 688: msg = Pools temp data dir: %s does not exist % ( Line 689: self._poolsTmpDir) Line 690: raise se.StoragePoolConnectionError(msg) Line 691: Line 692: self._saveReconnectInformation(hostID, scsiKey, msdUUID, masterVersion) I wonder if the mistake is not reverse than the purpose of this patch. i.e. not that reading the reconnection info belong inside connect but rather that persisting it belongs outside. this method has 2 different ways of getting its parameters and if someone called it and did not pass them then we fail back to the other method. Instead, maybe we should have a separate reconnect method and whenever connect here is called, the parameters have to be passed. The only place we actually call connectStoragePool without params is in the init of hsm. So we could just retrieve the info there and persist it also at hsm level in connect. Alternatively, I'm not even clear on whether this still works and engine automatically reconnects and we also support running VMs without being connected to a pool so I wonder if we shouldn't just drop all the reconnect logic and be done with it (esp. as what we're trying to do is get rid of the pool here). We will need to automatically connect to domains later on (acquire lock space) to cut on startup time, but that is pretty much a different issue entirely. Line 693: self.id = hostID Line 694: self.scsiKey = scsiKey Line 695: # Make sure SDCache doesn't have stale data (it can be in case of FC) Line 696: sdCache.invalidateStorage() Line 741: Line 742: @unsecured Line 743: def getPoolParams(self, hostID, scsiKey, msdUUID, masterVersion): Line 744: if all(hostID, scsiKey, msdUUID, masterVersion): Line 745: return hostID, scsiKey, msdUUID, masterVersion this makes things even more weird. if user passed params - return the params right back. if not - read from disk and return Line 746: Line 747: self.log.info( Line 748: Using saved connection parameters: hostID=%s, scsiKey=%s, Line 749: msdUUID=%s, masterVersion=%s, hostID, scsiKey, msdUUID, Line 752: with open(self._poolFile, r) as f: Line 753: poolInfo = dict((x.strip().split(=, 1) for x in f)) Line 754: Line 755: return tuple(poolInfo.get(x) for x in Line 756: (hostId, scsiKey, msdUUID, masterVersion)) same as patch set 1 or at least explain why I'm wrong? Line 757: Line 758: @unsecured Line 759: def createMaster(self, poolName, domain, masterVersion, leaseParams): Line 760: -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: turn spm status attributes private
Ayal Baron has posted comments on this change. Change subject: sp: turn spm status attributes private .. Patch Set 2: (4 comments) Commit Message Line 3: AuthorDate: 2013-11-21 12:26:08 -0500 Line 4: Commit: Federico Simoncelli fsimo...@redhat.com Line 5: CommitDate: 2013-11-22 11:40:14 -0500 Line 6: Line 7: sp: turn spm status attributes private why? Line 8: Line 9: Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c File vdsm/storage/hsm.py Line 305: except se.StorageDomainDoesNotExist: Line 306: pass Line 307: Line 308: def validateSPM(self, pool): Line 309: if pool.isSpmRoleAcquired(): this is the reverse logic. validateSPM should return True if acquired Line 310: raise se.SpmStatusError(pool.spUUID) Line 311: Line 312: def validateNotSPM(self, pool): Line 313: if not pool.isSpmRoleFree(): File vdsm/storage/sp.py Line 138: return self.getMetaParam(PMDK_LVER) Line 139: Line 140: @unsecured Line 141: def getSpmStatus(self): Line 142: return self._spmRole, self._getSpmLver(), self._getSpmId() not caused by this patch but, getSpmLver and getSpmId get eh domain metadata twice. 1. it's not efficient 2. it might change between calls possibly worth fixing (either here or in a subsequent patch) Line 143: Line 144: @unsecured Line 145: def isSpmRoleAcquired(self): Line 146: return self._spmRole == SPM_ACQUIRED Line 141: def getSpmStatus(self): Line 142: return self._spmRole, self._getSpmLver(), self._getSpmId() Line 143: Line 144: @unsecured Line 145: def isSpmRoleAcquired(self): s/isSpmRolAcquired/isSpmAcquired/ ? if 'yes' then same for isSpmRoleFree Line 146: return self._spmRole == SPM_ACQUIRED Line 147: Line 148: @unsecured Line 149: def isSpmRoleFree(self): -- To view, visit http://gerrit.ovirt.org/21527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21577
to review the following change.
Change subject: Keeping gluster modules when with_gluster set to 0
..
Keeping gluster modules when with_gluster set to 0
Currently the code imports and uses gluster modules. Setting
with_gluster=0 brakes the code. With this patch with_gluster=0 will
only drop the vdsm-gluster rpm creation.
Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/21477
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm.spec.in
M vdsm/supervdsmServer
2 files changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/21577/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 5e306e4..91d3168 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -895,12 +895,8 @@
%{_datadir}/%{vdsm_name}/storage/fileUtils.py*
%{_datadir}/%{vdsm_name}/storage/fileVolume.py*
%{_datadir}/%{vdsm_name}/storage/fuser.py*
-%if 0%{?with_gluster}
%{_datadir}/%{vdsm_name}/storage/glusterSD.py*
%{_datadir}/%{vdsm_name}/storage/glusterVolume.py*
-%else
-%exclude %{_datadir}/%{vdsm_name}/storage/gluster*
-%endif
%{_datadir}/%{vdsm_name}/storage/hba.py*
%{_datadir}/%{vdsm_name}/storage/hsm.py*
%{_datadir}/%{vdsm_name}/storage/image.py*
@@ -1086,11 +1082,11 @@
%{_datadir}/%{vdsm_name}/tests/netmaskconversions
%{_datadir}/%{vdsm_name}/tests/run_tests.sh
%{_datadir}/%{vdsm_name}/tests/tc_filter_show.out
-%if 0%{?with_gluster}
%{_datadir}/%{vdsm_name}/tests/glusterVolumeProfileInfo.xml
%{_datadir}/%{vdsm_name}/tests/glusterVolumeProfileInfoNfs.xml
%{_datadir}/%{vdsm_name}/tests/glusterVolumeRebalanceStatus.xml
%{_datadir}/%{vdsm_name}/tests/glusterVolumeRemoveBricksStatus.xml
+%{_datadir}/%{vdsm_name}/tests/glusterVolumeTasks.xml
%else
%exclude %{_datadir}/%{vdsm_name}/tests/gluster*
%endif
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 40ec9df..7fa1c2b 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -43,7 +43,12 @@
from storage import fuser
from multiprocessing import Pipe, Process
-from gluster import listPublicFunctions
+try:
+from gluster import listPublicFunctions
+_glusterEnabled = True
+except ImportError:
+_glusterEnabled = False
+
import storage.misc as misc
from vdsm import utils
from parted_utils import getDevicePartedInfo as _getDevicePartedInfo
@@ -362,8 +367,9 @@
return func(*args, **kwargs)
return wrapper
-for name, func in listPublicFunctions():
-setattr(_SuperVdsm, name, logDecorator(bind(func)))
+if _glusterEnabled:
+for name, func in listPublicFunctions():
+setattr(_SuperVdsm, name, logDecorator(bind(func)))
try:
log.debug(Making sure I'm root - SuperVdsm)
--
To view, visit http://gerrit.ovirt.org/21577
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Keeping gluster modules when with_gluster set to 0
oVirt Jenkins CI Server has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/291/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix PEP 8 issue.
Eduardo has uploaded a new change for review.
Change subject: Fix PEP 8 issue.
..
Fix PEP 8 issue.
Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47
Signed-off-by: Eduardo ewars...@redhat.com
---
M lib/vdsm/ipwrapper.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/21578/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index 5e5ec29..c50b376 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -125,8 +125,8 @@
tokens = [token for token in processedData[1].split(' ') if token]
linkType = tokens.pop(0)
attrs['linkType'] = linkType
-attrs.update((linkType + tokens[i], tokens[i+1]) for i in
- range(0, len(tokens)-1, 2))
+attrs.update((linkType + tokens[i], tokens[i + 1]) for i in
+ range(0, len(tokens) - 1, 2))
return attrs
@classmethod
--
To view, visit http://gerrit.ovirt.org/21578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix PEP 8 issue.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix PEP 8 issue. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4861/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5661/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/872/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5746/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix PEP 8 issue.
Yaniv Bronhaim has posted comments on this change. Change subject: Fix PEP 8 issue. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix PEP 8 issue.
Gadi Ickowicz has posted comments on this change. Change subject: Fix PEP 8 issue. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix PEP 8 issue.
Saggi Mizrahi has posted comments on this change. Change subject: Fix PEP 8 issue. .. Patch Set 1: Code-Review+1 The pep8 tool doesn't check for spaces between operators and the actual document leaves it to the users discretion. They recommend pairing operators according to precedence but we just use parenthesis instead to remove ambiguity. Let's all just agree to use spaces and parenthesis. -- To view, visit http://gerrit.ovirt.org/21578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report device to engine in a new fashion
oVirt Jenkins CI Server has posted comments on this change. Change subject: Report device to engine in a new fashion .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4862/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5662/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/873/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5747/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icedb16c7f0bfccf05ffd2438e013e4894fda20da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report device to engine in a new fashion
Assaf Muller has posted comments on this change. Change subject: Report device to engine in a new fashion .. Patch Set 4: Verified+1 Patch 4: Rebased off latest master, and changed from: getRouteTo(destinationIP=None) To: getRouteTo(destinationIP) -- To view, visit http://gerrit.ovirt.org/21470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icedb16c7f0bfccf05ffd2438e013e4894fda20da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Ayal Baron has posted comments on this change. Change subject: bootstrap: Return recovery error during lvm bootstrap .. Patch Set 3: (1 comment) File vdsm/storage/hsm.py Line 376: def storageRefresh(): Line 377: try: Line 378: lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS) Line 379: finally: Line 380: readyCallback() yet another place where we introduce dependency from hsm to vm.py (on top of registerDomainStateChangeCallback)... Line 381: Line 382: sdCache.refreshStorage() Line 383: Line 384: fileUtils.createdir(self.tasksDir) -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath before loading lvm cache
Allon Mureinik has posted comments on this change. Change subject: hsm: Rescan multipath before loading lvm cache .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ec7beee1db193a47d9e8109929badfd5b322c02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Log exceptions in domain monitor thread
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Log exceptions in domain monitor thread .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 14: (3 comments) File lib/vdsm/utils.py Line 103: return stat.S_ISBLK(os.stat(path).st_mode) Line 104: Line 105: Line 106: def touchFile(filePath, ignoreExceptions=False): Line 107: Done Line 108: Subset of POSIX touch functionality Line 109: :param filePath: The file to touch Line 110: :param ignoreExceptions: Should file handling exceptions be ignored? Line 111: File vdsm/logger.conf.in Line 1: [loggers] Line 2: keys=root,vds,Storage,metadata I need to get my eyes checked... Thanks. Line 3: Line 4: [handlers] Line 5: keys=console,syslog,logfile,metadata Line 6: Line 1: [loggers] Line 2: keys=root,vds,Storage,metadata Line 3: Line 4: [handlers] Line 5: keys=console,syslog,logfile,metadata Done Line 6: Line 7: [formatters] Line 8: keys=long,simple,none,sysform Line 9: -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: link monitor: Add optional asynchronous operation
Nir Soffer has posted comments on this change.
Change subject: link monitor: Add optional asynchronous operation
..
Patch Set 4:
(1 comment)
File lib/vdsm/ipwrapper.py
Line 597: ep = select.epoll()
Line 598: ep.register(self.proc.stdout, select.EPOLLIN)
Line 599: fd, event = ep.poll()[0]
Line 600: outBuffer = os.read(fd, 1024)
Line 601: while self.proc is not None:
This may be little more efficient:
pos = outBuffer.find('\n')
if pos != -1:
line = outBuffer[:pos + 1]
outBuffer = outBuffer[pos + 1:]
yield line
Line 602: if '\n' in outBuffer:
Line 603: line, outBuffer = outBuffer.split('\n', 1)
Line 604: yield line + '\n'
Line 605: else:
--
To view, visit http://gerrit.ovirt.org/21430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8ca850fc324a5b4c0268541fd4d4d062706a159
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix PEP 8 issue.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix PEP 8 issue. .. Fix PEP 8 issue. Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47 Signed-off-by: Eduardo ewars...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21578 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Gadi Ickowicz gicko...@redhat.com Reviewed-by: Saggi Mizrahi smizr...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/ipwrapper.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Saggi Mizrahi: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Gadi Ickowicz: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix PEP 8 issue.
Dan Kenigsberg has posted comments on this change. Change subject: Fix PEP 8 issue. .. Patch Set 1: Verified+1 Code-Review+2 Toni! -- To view, visit http://gerrit.ovirt.org/21578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added lib/vdsm/utils.py:touchFile
Assaf Muller has uploaded a new change for review. Change subject: Added lib/vdsm/utils.py:touchFile .. Added lib/vdsm/utils.py:touchFile Change-Id: Ifbbea57c425adc8b911bb9e1931c02edb71db820 Signed-off-by: Assaf Muller amul...@redhat.com --- M lib/vdsm/utils.py 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/21590/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index 3166a92..cd0f24c 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -103,6 +103,20 @@ return stat.S_ISBLK(os.stat(path).st_mode) +def touchFile(filePath, ignoreExceptions=False): + +Subset of POSIX touch functionality +:param filePath: The file to touch +:param ignoreExceptions: Should file handling exceptions be ignored? + +try: +with open(filePath, 'a'): +os.utime(filePath, None) +except (IOError, OSError) as e: +if not ignoreExceptions: +raise e + + def rmFile(fileToRemove): Try to remove a file. -- To view, visit http://gerrit.ovirt.org/21590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifbbea57c425adc8b911bb9e1931c02edb71db820 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added lib/vdsm/utils.py:touchFile
Assaf Muller has posted comments on this change. Change subject: Added lib/vdsm/utils.py:touchFile .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbbea57c425adc8b911bb9e1931c02edb71db820 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added lib/vdsm/utils.py:touchFile
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added lib/vdsm/utils.py:touchFile .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4863/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5663/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5748/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbbea57c425adc8b911bb9e1931c02edb71db820 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added lib/vdsm/utils.py:touchFile
Yaniv Bronhaim has posted comments on this change. Change subject: Added lib/vdsm/utils.py:touchFile .. Patch Set 1: (2 comments) File lib/vdsm/utils.py Line 102: path = os.path.abspath(path) Line 103: return stat.S_ISBLK(os.stat(path).st_mode) Line 104: Line 105: Line 106: def touchFile(filePath, ignoreExceptions=False): I would add setPermissions for that. and maybe do that as supervdsm verb.. otherwise you open the file as the caller user with all its limits. as root it can be - touchFile(filePath, user, group, perm, raiseErrors=False) your patch that uses vdsm-tool for that, will touch the file as root. anyhow, to make things short, this is good infra and I think we don't need more than that for now. but maybe later this might be a bit limited. just raising the issue.. Line 107: Line 108: Subset of POSIX touch functionality Line 109: :param filePath: The file to touch Line 110: :param ignoreExceptions: Should file handling exceptions be ignored? Line 110: :param ignoreExceptions: Should file handling exceptions be ignored? Line 111: Line 112: try: Line 113: with open(filePath, 'a'): Line 114: os.utime(filePath, None) please add a comment why you update utime here. Line 115: except (IOError, OSError) as e: Line 116: if not ignoreExceptions: Line 117: raise e Line 118: -- To view, visit http://gerrit.ovirt.org/21590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbbea57c425adc8b911bb9e1931c02edb71db820 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Antoni Segura Puimedon has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
..
Patch Set 3:
(2 comments)
Very insignificant review.
File vdsm/storage/hsm.py
Line 324: def __init__(self, readyCallback):
Line 325:
Line 326: The HSM Constructor
Line 327:
Line 328: :param readyCallback: Called when instance has finished its
deffered
s/deffered/deferred/
Line 329: initialization and is ready to answer
requests.
Line 330: :type readyCallback: function
Line 331:
Line 332: rm.ResourceManager.getInstance().registerNamespace(
Line 326: The HSM Constructor
Line 327:
Line 328: :param readyCallback: Called when instance has finished its
deffered
Line 329: initialization and is ready to answer
requests.
Line 330: :type readyCallback: function
shouldn't type be callable?
Line 331:
Line 332: rm.ResourceManager.getInstance().registerNamespace(
Line 333: STORAGE, rm.SimpleResourceFactory())
Line 334: self.storage_repository = config.get('irs', 'repository')
--
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add simple mocking library
Yaniv Bronhaim has posted comments on this change. Change subject: tests: Add simple mocking library .. Patch Set 1: go for it -- To view, visit http://gerrit.ovirt.org/21155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d874f553b6a983652ed745d7d8554716e7a15e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Yaniv Bronhaim has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 11: (1 comment) File lib/vdsm/constants.py.in Line 148: Line 149: EXT_CURL_IMG_WRAP = '@LIBEXECDIR@/curl-img-wrap' Line 150: Line 151: Line 152: class Architecture: I recall I asked you to move it here because you used those not only in caps. but if it is used only there, move it Line 153: X86_64 = 'x86_64' -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: (1 comment) File lib/vdsm/ppc64HardwareInfo.py Line 15: # Line 16: # Refer to the README and COPYING files for full details of the license Line 17: # Line 18: Line 19: from vdsm import utils why ? its a utility\package that unrelated to vdsm and might be used as external python package in the future. vdsm just uses it, exactly like dmidecode_util . I prefer all of those move to lib/vdsm, as ipwrapper, netinfo, libvirtconnection ... don't you agree? Line 20: Line 21: import os Line 22: Line 23: -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: (1 comment) File lib/vdsm/ppc64HardwareInfo.py Line 15: # Line 16: # Refer to the README and COPYING files for full details of the license Line 17: # Line 18: Line 19: from vdsm import utils For packaging sake and time to release I agree with Yaniv. But as how it should be, I would very much prefer to have this code in a python library in pypi that is packaged in Fedora/EPEL and we just import (like the ipwrapper, and the lower level bits of netinfo). Line 20: Line 21: import os Line 22: Line 23: -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Peform related services restart after reconfiguring
oVirt Jenkins CI Server has posted comments on this change. Change subject: Peform related services restart after reconfiguring .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/292/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Peform related services restart after reconfiguring
Alon Bar-Lev has posted comments on this change.
Change subject: Peform related services restart after reconfiguring
..
Patch Set 4:
(1 comment)
File vdsm.spec.in
Line 748: %{_bindir}/vdsm-tool service-stop supervdsmd /dev/null 21
Line 749: supervdsmd_start_required='yes'
Line 750: fi
Line 751:
Line 752: %{_bindir}/vdsm-tool libvirt-configure /dev/null 21
if error?
Line 753:
Line 754: fi
Line 755: if [ ${supervdsmd_start_required} = 'yes' ]; then
Line 756: %{_bindir}/vdsm-tool service-start supervdsmd /dev/null 21
--
To view, visit http://gerrit.ovirt.org/21356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8216f9556e6ef4df96977db494c5b5169bfae80a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop unused MigrationSourceThreadClass abstraction
Martin Polednik has posted comments on this change. Change subject: vm: drop unused MigrationSourceThreadClass abstraction .. Patch Set 1: Code-Review+1 exactly what Tony said -- To view, visit http://gerrit.ovirt.org/21560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: Return recovery error during lvm bootstrap .. Patch Set 3: (1 comment) File vdsm/storage/hsm.py Line 376: def storageRefresh(): Line 377: try: Line 378: lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS) Line 379: finally: Line 380: readyCallback() Indeed. I prefer to reverse the dependency: add a ready property in HSM, to be checked in wrapIrsMethod. It would be even better to clean some of clientIF over-complexity, and return recovery errCode until HSM() is initialized, with no need of an extra property. Line 381: Line 382: sdCache.refreshStorage() Line 383: Line 384: fileUtils.createdir(self.tasksDir) -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to add brick command
Bala.FA has posted comments on this change. Change subject: gluster: Add force option to add brick command .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I907e3798d2a360cfcfd736d7cf9cb8f43c95ca10 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Kanagaraj M kmayi...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: gluster: correct parameter for creating hookpath in verb hoo...
Bala.FA has posted comments on this change. Change subject: gluster: correct parameter for creating hookpath in verb hookAdd. .. Patch Set 1: Code-Review+1 (1 comment) Commit Message Line 9: parameter hookLevel must be in lower case for creating correct Line 10: path for hook. so that parameter is changed to lower case. Line 11: Line 12: Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60 Line 13: https://bugzilla.redhat.com/show_bug.cgi?id=1028972 Prefix with Bug-Url: Line 14: Signed-off-by: ndarshan dnara...@redhat.com Line 15: Reviewed-on: http://gerrit.ovirt.org/21017 Line 16: Reviewed-by: Aravinda VK avish...@redhat.com Line 17: Reviewed-by: Bala.FA barum...@redhat.com -- To view, visit http://gerrit.ovirt.org/21538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to Volume Create command
Bala.FA has posted comments on this change. Change subject: gluster: Add force option to Volume Create command .. Patch Set 3: Code-Review-1 (1 comment) Commit Message Line 9: glusterfs cli will fail if system's root partition is used Line 10: as brick dirs. If user wants to use system's root partition as Line 11: bricks dir then force option can be used in gluster cli. Line 12: Line 13: Added the force parameter to vdsm verb glusterfs upstream master doesn't have force option. Please check this behavior in release-3.4 Line 14: glusterVolumeCreate Line 15: Line 16: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1008942 Line 17: Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0 -- To view, visit http://gerrit.ovirt.org/21082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to Volume Create command
Bala.FA has posted comments on this change. Change subject: gluster: Add force option to Volume Create command .. Patch Set 3: (1 comment) Commit Message Line 9: glusterfs cli will fail if system's root partition is used Line 10: as brick dirs. If user wants to use system's root partition as Line 11: bricks dir then force option can be used in gluster cli. Line 12: Line 13: Added the force parameter to vdsm verb glusterfs-3.4.1-1.fc19.x86_64 doesn't have force option. please check what version of glusterfs has this option and update vdsm.spec.in accordingly Line 14: glusterVolumeCreate Line 15: Line 16: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1008942 Line 17: Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0 -- To view, visit http://gerrit.ovirt.org/21082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop unused MigrationSourceThreadClass abstraction
Vinzenz Feenstra has posted comments on this change. Change subject: vm: drop unused MigrationSourceThreadClass abstraction .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9fac9aa5b66b68c7447df0c460d91f5f4415b73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add host uuid in volume status
Hello Timothy Asir, Saggi Mizrahi, Aravinda VK, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21596
to review the following change.
Change subject: gluster: add host uuid in volume status
..
gluster: add host uuid in volume status
This patch adopts newly added host uuid in gluster volume status cli
output
Change-Id: Ib9d92845ffce4ba5a2f9f0f2cca782ef18664bdf
Signed-off-by: Bala.FA barum...@redhat.com
---
M tests/gluster_cli_tests.py
M vdsm.spec.in
M vdsm/gluster/cli.py
3 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/21596/1
diff --git a/tests/gluster_cli_tests.py b/tests/gluster_cli_tests.py
index 72d98ed..d0c8a1c 100644
--- a/tests/gluster_cli_tests.py
+++ b/tests/gluster_cli_tests.py
@@ -212,6 +212,7 @@
nodeCount4/nodeCount
node
hostname192.168.122.2/hostname
+ peeridf06b108e-a780-4519-bb22-c3083a1e3f8a/peerid
path/tmp/music-b1/path
port49152/port
status1/status
@@ -219,6 +220,7 @@
/node
node
hostname192.168.122.2/hostname
+ peeridf06b108e-a780-4519-bb22-c3083a1e3f8a/peerid
path/tmp/music-b2/path
port49153/port
status1/status
@@ -227,6 +229,7 @@
node
hostnameNFS Server/hostname
path192.168.122.2/path
+ peeridf06b108e-a780-4519-bb22-c3083a1e3f8a/peerid
port38467/port
status1/status
pid1357/pid
@@ -234,6 +237,7 @@
node
hostnameSelf-heal Daemon/hostname
path192.168.122.2/path
+ peeridf06b108e-a780-4519-bb22-c3083a1e3f8a/peerid
port0/port
status1/status
pid1375/pid
@@ -247,19 +251,27 @@
status = gcli._parseVolumeStatus(tree)
self.assertEquals(status,
{'bricks': [{'brick': '192.168.122.2:/tmp/music-b1',
+ 'hostuuid': \
+ 'f06b108e-a780-4519-bb22-c3083a1e3f8a',
'pid': '1313',
'port': '49152',
'status': 'ONLINE'},
{'brick': '192.168.122.2:/tmp/music-b2',
+ 'hostuuid': \
+ 'f06b108e-a780-4519-bb22-c3083a1e3f8a',
'pid': '1335',
'port': '49153',
'status': 'ONLINE'}],
'name': 'music',
'nfs': [{'hostname': '192.168.122.2',
+'hostuuid': \
+'f06b108e-a780-4519-bb22-c3083a1e3f8a',
'pid': '1357',
'port': '38467',
'status': 'ONLINE'}],
'shd': [{'hostname': '192.168.122.2',
+'hostuuid': \
+'f06b108e-a780-4519-bb22-c3083a1e3f8a',
'pid': '1375',
'status': 'ONLINE'}]})
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 43e47ea..e9628dd 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -217,7 +217,7 @@
# GlusterFS client-side RPMs needed for Gluster SD
%if 0%{?with_gluster}
-Requires: glusterfs = 3.4.1
+Requires: glusterfs = 3.4.2
Requires: glusterfs-cli
Requires: glusterfs-api
Requires: glusterfs-fuse
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index a654b56..639c41d 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -148,16 +148,19 @@
if value['hostname'] == 'NFS Server':
status['nfs'].append({'hostname': value['path'],
+ 'hostuuid': value['peerid'],
'port': value['port'],
'status': value['status'],
'pid': value['pid']})
elif value['hostname'] == 'Self-heal Daemon':
status['shd'].append({'hostname': value['path'],
+ 'hostuuid': value['peerid'],
'status': value['status'],
'pid': value['pid']})
else:
status['bricks'].append({'brick': '%s:%s' % (value['hostname'],
value['path']),
+ 'hostuuid': value['peerid'],
'port': value['port'],
'status': value['status'],
Change in vdsm[master]: gluster: add host uuid in volume status
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add host uuid in volume status .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4864/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5664/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5749/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9d92845ffce4ba5a2f9f0f2cca782ef18664bdf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdc: Change error messages to info
Vered Volansky has uploaded a new change for review. Change subject: sdc: Change error messages to info .. sdc: Change error messages to info Two informative, non-error log messages were logged as error and are now logged as info: 1._findDomain - looking for unfetched domain 2._findUnfetchedDomain - looking for domain Also an error is raised in the process, now logged as info. Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Signed-off-by: Vered Volansky vvola...@redhat.com Bug-url: https://bugzilla.redhat.com/1031814 --- M vdsm/storage/sdc.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/21597/1 diff --git a/vdsm/storage/sdc.py b/vdsm/storage/sdc.py index 2767d6c..bb8b93f 100644 --- a/vdsm/storage/sdc.py +++ b/vdsm/storage/sdc.py @@ -134,13 +134,13 @@ try: findMethod = self.knownSDs[sdUUID] except KeyError: -self.log.error(looking for unfetched domain %s, sdUUID) +self.log.info(looking for unfetched domain %s, sdUUID) findMethod = self._findUnfetchedDomain try: dom = findMethod(sdUUID) except se.StorageDomainDoesNotExist: -self.log.error(domain %s not found, sdUUID, exc_info=True) +self.log.info(domain %s not found, sdUUID, exc_info=True) raise else: return dom @@ -151,7 +151,7 @@ import localFsSD import nfsSD -self.log.error(looking for domain %s, sdUUID) +self.log.info(looking for domain %s, sdUUID) # The order is somewhat important, it's ordered # by how quickly get can find the domain. For instance -- To view, visit http://gerrit.ovirt.org/21597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdc: Change error messages to info
Vered Volansky has posted comments on this change. Change subject: sdc: Change error messages to info .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdc: Change error messages to info
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdc: Change error messages to info .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4865/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5750/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
