Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread
Assaf Muller has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Code-Review+1 Nif - Please verify. You can do this by moving ovirtmgmt to static, manually removing its source routing rules (ip rule del...) on the host, then running setupNetworks with dhcp and verifying that source routing was successfully configured. -- To view, visit http://gerrit.ovirt.org/22718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: the libvirt xml is changed now to allow adding more cpus this means we have a topology element and a vcpu element to reflect the current placement of cpus vcpu placement='static' current='2'160/vcpu topology sockets='160' cores='1' threads='1'/ this means we currently use 2 VCPU and we can grow by hot adding up to 160 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6393/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5500/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6296/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: Verified+1 Verified * the vm is up and running with 2 cpus * can call setVcpus Not verified * the libvirt call still says the domain couldn't hot add cpus probably an OS issue -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add --force option to upgrades
Assaf Muller has uploaded a new change for review.
Change subject: Add --force option to upgrades
..
Add --force option to upgrades
The --force option will ignore the existance of upgrade files
in /var/lib/vdsm/upgrade/
Each upgrade will still only run if it thinks it should run.
Change-Id: I2e6b84bdd14b9cd3921cea187b2654be22989334
Signed-off-by: Assaf Muller amul...@redhat.com
---
M lib/vdsm/tool/unified_persistence.py
M lib/vdsm/tool/upgrade.py
M lib/vdsm/tool/upgrade_300_networks.py
3 files changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/22750/1
diff --git a/lib/vdsm/tool/unified_persistence.py
b/lib/vdsm/tool/unified_persistence.py
index d1b3d0a..a2d92cf 100644
--- a/lib/vdsm/tool/unified_persistence.py
+++ b/lib/vdsm/tool/unified_persistence.py
@@ -137,7 +137,7 @@
@expose('upgrade-to-unified-persistence')
-def unified_persistence():
+def unified_persistence(*args):
Upgrade host networking persistence from ifcfg to unified if the
persistence model is set as unified in /usr/lib64/python2.X/site-packages/
diff --git a/lib/vdsm/tool/upgrade.py b/lib/vdsm/tool/upgrade.py
index c3e92bc..8c9f57b 100644
--- a/lib/vdsm/tool/upgrade.py
+++ b/lib/vdsm/tool/upgrade.py
@@ -17,6 +17,7 @@
# Refer to the README and COPYING files for full details of the license
#
+import argparse
from functools import wraps
import logging
import logging.config
@@ -116,6 +117,18 @@
self._detachUpgradeLog()
+def _parse_args():
+parser = argparse.ArgumentParser('vdsm-tool')
+parser.add_argument(
+'--force',
+dest='force',
+default=False,
+action='store_true',
+help='Run the upgrade again, even if it was ran before',
+)
+return parser.parse_args(sys.argv[2:])
+
+
def upgrade(upgradeName):
Used as a decorator for upgrades. Runs the upgrade with an Upgrade
@@ -126,7 +139,8 @@
@wraps(f)
def wrapper(*args, **kwargs):
with Upgrade(upgradeName) as upgrade:
-if upgrade.isNeeded():
+cliArguments = _parse_args()
+if cliArguments.force or upgrade.isNeeded():
upgrade.log.debug(Running upgrade %s, upgradeName)
try:
f(*args, **kwargs)
diff --git a/lib/vdsm/tool/upgrade_300_networks.py
b/lib/vdsm/tool/upgrade_300_networks.py
index 0f754fd..41a49b5 100644
--- a/lib/vdsm/tool/upgrade_300_networks.py
+++ b/lib/vdsm/tool/upgrade_300_networks.py
@@ -55,7 +55,7 @@
@expose('upgrade-3.0.0-networks')
-def upgrade_networks():
+def upgrade_networks(*args):
Since ovirt-3.0, Vdsm uses libvirt networks (with names vdsm-*) to store
its own networks. Older Vdsms did not have those defined, and used only
--
To view, visit http://gerrit.ovirt.org/22750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e6b84bdd14b9cd3921cea187b2654be22989334
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add --force option to upgrades
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add --force option to upgrades .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6394/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5501/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6297/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e6b84bdd14b9cd3921cea187b2654be22989334 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add --force option to upgrades
Assaf Muller has posted comments on this change. Change subject: Add --force option to upgrades .. Patch Set 1: Verified+1 Verification: VDSM's invocation of the upgrades doesn't use --force Using --force properly ignores the upgrade files. Not setting it properly checks for the existence of the upgrade files. -- To view, visit http://gerrit.ovirt.org/22750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e6b84bdd14b9cd3921cea187b2654be22989334 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [1/2] getVdsCaps returns client iface for *current* connection
Assaf Muller has posted comments on this change. Change subject: [1/2] getVdsCaps returns client iface for *current* connection .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib503d24ac933d8b6efef6128fff79f20b0503fe2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added network directory
Assaf Muller has posted comments on this change. Change subject: Added network directory .. Patch Set 2: Verified+1 Passes all unit and functional tests. -- To view, visit http://gerrit.ovirt.org/22694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9c7e8cfc96cc1671ed7549c2f45ca820211c7c1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread
Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: (1 comment) File vdsm/sourceRouteThread.py Line 10: from vdsm import utils Line 11: Line 12: Line 13: SOURCE_ROUTES_FOLDER = P_VDSM_RUN + 'sourceRoutes' Line 14: configurator = Iproute2() - This line: Separating public and private variables blocks improve readability. If configurator is actually a private variable, we can rename it to _configurator and remove this line. - Line 49: Separating paragraphs of code make it more readable. Removing it is not related to this patch anyway. Line 15: _thread = None Line 16: Line 17: Line 18: class DHClientEventHandler(pyinotify.ProcessEvent): -- To view, visit http://gerrit.ovirt.org/22723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e1d402ac1c1cd4de4c3e74910244b47e7977f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread
Assaf Muller has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: (1 comment) File vdsm/sourceRouteThread.py Line 10: from vdsm import utils Line 11: Line 12: Line 13: SOURCE_ROUTES_FOLDER = P_VDSM_RUN + 'sourceRoutes' Line 14: configurator = Iproute2() You misunderstood - I meant removing line 15, which is _thread = None, and line 49, which is global _thread. They are redundant as far as I can see. Line 15: _thread = None Line 16: Line 17: Line 18: class DHClientEventHandler(pyinotify.ProcessEvent): -- To view, visit http://gerrit.ovirt.org/22723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e1d402ac1c1cd4de4c3e74910244b47e7977f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: split metadata transaction in createMaster
Ayal Baron has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 2:
(1 comment)
File vdsm/storage/sd.py
Line 771: pools = self.getPools()
Line 772:
Line 773: if len(pools) 0:
Line 774: self.log.info('initializing master domain %s detaching
pools %s',
Line 775: self.sdUUID, ', '.join((str(x) for x in
pools)))
reconstructMaster is never run on a domain from a different pool, only on a
detached domain or on a domain from the same pool...
Line 776:
Line 777: with self._metadata.transaction():
Line 778: self.changeLeaseParams(leaseParams)
Line 779: self.setMetaParam(DMDK_POOLS, [spUUID])
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 1: (1 comment) File vdsm/supervdsmServer Line 407: log.debug(Started serving super vdsm object) Line 408: Line 409: _sourceRouteThread = threading.Thread( Line 410: target=sourceRouteThread.subscribeToInotifyLoop, Line 411: name='sourceRoute') Funny.. but we need the rest of the file Line 412: _sourceRouteThread.daemon = True Line 413: _sourceRouteThread.start() Line 414: Line 415: # Python bug of thread.join() will block signal -- To view, visit http://gerrit.ovirt.org/22718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Code-Review+1 why do you have 3 patchsets for the same change? good catch. must be backported to ovirt-3.3, (I'd open a bug and relate it to it, to ensure it will be tested as part of ovirt-3.3 and follow the backporting) thanks! -- To view, visit http://gerrit.ovirt.org/22718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread
Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 4: Since the module does not care any more about starting multiple threads, the global _thread is not needed. -- To view, visit http://gerrit.ovirt.org/22723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e1d402ac1c1cd4de4c3e74910244b47e7977f0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain
Yaniv Bronhaim has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 1: Code-Review-2 until we'll have a bug -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread
Dan Kenigsberg has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Multiple patches are a Good Thing. I am not sure this is a bug per se. It's not the intended behavior but we have no proof that it's actually worse. -- To view, visit http://gerrit.ovirt.org/22718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eb78b57b9ae6ada9948815020ac3d5ac005d20a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread
Assaf Muller has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e1d402ac1c1cd4de4c3e74910244b47e7977f0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6395/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5502/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1101/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6298/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e1d402ac1c1cd4de4c3e74910244b47e7977f0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain
Nir Soffer has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 2: Add bug url, no code change. -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain
Nir Soffer has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 2: Verified+1 Code was not changed. -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: Check all devices visibility after multipath rescan .. hsm: Check all devices visibility after multipath rescan After invoking multipath rescan, existing devices may disapper, and non-existing devices may appear. The orignal code was checking again only one device after a rescan, possibly returning bogus results. This patch check now all devices after invoking multipath.rescan(). Change-Id: I46ede1124f4c5f849b040b598b49ee784c540ecc Relates-To: https://bugzilla.redhat.com/923773 Bug-Url: https://bugzilla.redhat.com/1044068 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21182 Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 5 insertions(+), 9 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Nir Soffer: Verified -- To view, visit http://gerrit.ovirt.org/21182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46ede1124f4c5f849b040b598b49ee784c540ecc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Do not hide errors when checking device visibility
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: Do not hide errors when checking device visibility .. hsm: Do not hide errors when checking device visibility When checking devices visibility, all errors from os.stat() are treated as device does not exists, hiding fatal error and making it harder to debug and fix them. This patch handle only ENOENT for checking visibility and raise other errors we cannot handle. Change-Id: I7411d7d2eaa9172f612fd1b1e04177bef270ab19 Relates-To: https://bugzilla.redhat.com/923773 Bug-Url: https://bugzilla.redhat.com/1044068 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21211 Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ayal Baron: Looks good to me, approved Nir Soffer: Verified -- To view, visit http://gerrit.ovirt.org/21211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7411d7d2eaa9172f612fd1b1e04177bef270ab19 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert clientIF: rescan devices on failed hotplugDisk
Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert clientIF: rescan devices on failed hotplugDisk .. Revert clientIF: rescan devices on failed hotplugDisk Commit 15c7f74365cb5d2c9258bc333c441941c6e42bdb tried fix a case where device is not visible after hotplug. The solution included a call to multipath.rescan() if the device does not exists, and checking again if the device exists. However, due to sneaky bug in the fix, the code was never invoking multipath.rescan(), and was actually a Placebo. The original commit added an undocumented public method for scanning devices visibility. The method did not perform readability check, like getDevicesVisiblity; there is no documentation or other evidence why this solution was chosen. The original commit tried to improve the way devices are checked for visibility, checking if all devices exists after multipath.rescan(). However this improvement was canceled because multipath.resacn() was never running. The original code was calling os.stat() once per device. After the commit, we call os.path.exists() for all devices, and os.stat() for existing devices. This additional calls are pointless and introduces a race, when a devices exist in the first call, and disappear in the second. Since the commit remove the exception handling while calling os.stat(), getDevicesVisibility may fail now with OSError in this case. One successful change was improving logging in clientIF, but this should have never be committed with the rest of the changes. This is the first patch in series of patches fixing the regressions introduced by the original commit and adding the good changes. This reverts commit 15c7f74365cb5d2c9258bc333c441941c6e42bdb. Change-Id: Ib978fada8ee82e3c6da9de9b79a66edafba4eb70 Relates-To: https://bugzilla.redhat.com/923773 Bug-Url: https://bugzilla.redhat.com/1044068 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21173 Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/clientIF.py M vdsm/storage/hsm.py 2 files changed, 24 insertions(+), 21 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Nir Soffer: Verified -- To view, visit http://gerrit.ovirt.org/21173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib978fada8ee82e3c6da9de9b79a66edafba4eb70 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setupNetworks: support networks with no underlying NIC
Dan Kenigsberg has posted comments on this change. Change subject: setupNetworks: support networks with no underlying NIC .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d2342cf3629eb05f4249a4657dc2ba45466ba24 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setupNetworks: support networks with no underlying NIC
Dan Kenigsberg has submitted this change and it was merged. Change subject: setupNetworks: support networks with no underlying NIC .. setupNetworks: support networks with no underlying NIC The old addNetwork API supported the ability to create a bridged network that has no leg to the outer world. This capability was lost in the not-so-very-new setupNetworks API. If a user had a nicless network defined by addNetwork, and tried to upgrade to unified persistence, the upgrade script (which uses setupNetworks) would have failed. Change-Id: I2d2342cf3629eb05f4249a4657dc2ba45466ba24 Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22595 Reviewed-by: Assaf Muller amul...@redhat.com Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com --- M tests/functional/networkTests.py M vdsm/configNetwork.py 2 files changed, 21 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Assaf Muller: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d2342cf3629eb05f4249a4657dc2ba45466ba24 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improved macspoof hook README following user request
Assaf Muller has uploaded a new change for review.
Change subject: Improved macspoof hook README following user request
..
Improved macspoof hook README following user request
Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718
Signed-off-by: Assaf Muller amul...@redhat.com
---
M vdsm_hooks/macspoof/README
1 file changed, 27 insertions(+), 20 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/22760/1
diff --git a/vdsm_hooks/macspoof/README b/vdsm_hooks/macspoof/README
index 984f050..109481e 100644
--- a/vdsm_hooks/macspoof/README
+++ b/vdsm_hooks/macspoof/README
@@ -1,31 +1,38 @@
macspoof vdsm hook
=
These hooks allow to remove MAC and ARP spoofing filtering
-from all of the VM's interfaces or for a specific vnic.
+from all of the VMs' interfaces or for a specific vNIC.
Installation:
-* Use the engine-config to append the appropriate custom properties
- as such:
+* Use engine-config to set the appropriate custom properties as such:
-Custom property which removes MAC and ARP spoofing filtering
-for all interfaces in a VM:
+Custom property for all interfaces in a VM:
+sudo engine-config -s UserDefinedVMProperties=macspoof=^(true|false)$
- sudo engine-config -s UserDefinedVMProperties=
- 'previousProperties;macspoof=^(true|false)$' --cver=3.2
+Custom property for a specific vNIC in a VM:
+sudo engine-config -s
CustomDeviceProperties={type=interface;prop={ifacemacspoof=^(true|false)$}}
-Custom property which removes MAC and ARP spoofing filtering
-for a specific vnic in a VM:
-
- sudo engine-config -s CustomDeviceProperties=
- '{type=interface;prop={ifacemacspoof=true}}'
-
-* Verify that the macspoof custom propertes were properly added:
+* Verify that the custom properties were added properly:
+sudo engine-config -g UserDefinedVMProperties
sudo engine-config -g CustomDeviceProperties
-Usage:
-In the VM configuration window, open the custom properites tab
-and add macspoof=true for applying filtering to all VM's interfaces.
+* Setting UserDefinedVMProperties or CustomDeviceProperties overwrites all
+ previous custom properties. To append:
+sudo engine-config -g UserDefinedVMProperties
+ Copy the value into $PREVIOUS_PROPERTIES, then use:
+sudo engine-config -s
UserDefinedVMProperties=$PREVIOUS_PROPERTIES;macspoof=^(true|false)$
+ Or, for per-device properties:
+sudo ./engine-config -s
CustomDeviceProperties={type=interface;prop={$PREVIOUS_PROPERTIES;ifacemacspoof=^(true|false)$}}
-In the vnic profiles configuration window, open the custom properties
-tab and add ifacemacspoof=true for applying filtering to the specific
-interface.
+Usage:
+In the VM configuration window, open the custom properties tab
+and add macspoof=true to remove filtering from all interfaces.
+
+In the vNIC profiles configuration window, open the custom properties
+tab and add ifacemacspoof=true to remove filtering from the specified
interface.
+
+Precedence:
+If you set both VM-wide macspoof, and vNIC specific ifacemacspoof, then the
+VM wide setting takes precedence. For example, if a VM's macspoof is True
+(Disable the filter), but a vNIC's ifacemacspoof is False (Enable the filter)
+then the filter for all vNICs on that VM will be disabled.
--
To view, visit http://gerrit.ovirt.org/22760
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improved macspoof hook README following user request
Assaf Muller has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improved macspoof hook README following user request
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6396/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6299/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6397/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5504/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6300/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improved macspoof hook README following user request
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6398/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6301/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improved macspoof hook README following user request
Dan Kenigsberg has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 2: (1 comment) File vdsm_hooks/macspoof/README Line 1: macspoof vdsm hook Line 2: = Line 3: These hooks allow to remove MAC and ARP spoofing filtering Line 4: from all of the VMs' interfaces or from a specific vNIC. Why is the change from VM's? This hook affects a specific VM, not all VMs. Line 5: Line 6: Installation: Line 7: * Use engine-config to set the appropriate custom properties as such: Line 8: -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified net persistence upgrade: Change 'bridged' from str t...
Dan Kenigsberg has posted comments on this change. Change subject: Unified net persistence upgrade: Change 'bridged' from str to bool .. Patch Set 1: Taking Toni's word on this one. -- To view, visit http://gerrit.ovirt.org/22721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13301d2b61e2e998e6623a8db3540ca6a8a6369c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified net persistence upgrade: Change 'bridged' from str t...
Dan Kenigsberg has posted comments on this change. Change subject: Unified net persistence upgrade: Change 'bridged' from str to bool .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13301d2b61e2e998e6623a8db3540ca6a8a6369c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified net persistence upgrade: Change 'bridged' from str t...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Unified net persistence upgrade: Change 'bridged' from str to bool .. Unified net persistence upgrade: Change 'bridged' from str to bool 'bridged' is defined as a bool in the VDSM API, although both a string and a bool seem to work. Change-Id: I13301d2b61e2e998e6623a8db3540ca6a8a6369c Signed-off-by: Assaf Muller amul...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22721 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/unified_persistence.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13301d2b61e2e998e6623a8db3540ca6a8a6369c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improved macspoof hook README following user request
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6399/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6302/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 9: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6400/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5507/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6303/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improved macspoof hook README following user request
Assaf Muller has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improved macspoof hook README following user request
Dan Kenigsberg has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improved macspoof hook README following user request
Dan Kenigsberg has submitted this change and it was merged. Change subject: Improved macspoof hook README following user request .. Improved macspoof hook README following user request Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718 Signed-off-by: Assaf Muller amul...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22760 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm_hooks/macspoof/README 1 file changed, 28 insertions(+), 20 deletions(-) Approvals: Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52963e5a344ba12a97906a9d8ed8f22cc2919718 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add --force option to upgrades
Dan Kenigsberg has posted comments on this change. Change subject: Add --force option to upgrades .. Patch Set 1: Code-Review-1 What is it good for? When should it be used? Please explain in the commit message. -- To view, visit http://gerrit.ovirt.org/22750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e6b84bdd14b9cd3921cea187b2654be22989334 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [1/2] getVdsCaps returns client iface for *current* connection
Dan Kenigsberg has posted comments on this change. Change subject: [1/2] getVdsCaps returns client iface for *current* connection .. Patch Set 2: Code-Review-1 (3 comments) This is an important bug fix. Would you make it more localized, and easier to backport? Commit Message Line 3: AuthorDate: 2013-12-25 15:37:37 +0200 Line 4: Commit: Assaf Muller amul...@redhat.com Line 5: CommitDate: 2013-12-25 17:36:34 +0200 Line 6: Line 7: [1/2] getVdsCaps returns client iface for *current* connection is there a 2/2 in this series. Line 8: Line 9: Previously getVdsCaps took server and client IPs from the last Line 10: connection, and not the current one. A side effect was that Line 11: the first verb after VDSM start always returned server and client File vdsm/BindingXMLRPC.py Line 80 Line 81 Line 82 Line 83 Line 84 why was it important/useful to inline this function? and why was it done in this patch? Line 151 Line 152 Line 153 Line 154 Line 155 even the removal of this dead attribute merits its own patch, imo. -- To view, visit http://gerrit.ovirt.org/22742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib503d24ac933d8b6efef6128fff79f20b0503fe2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
