Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/25284/1/tests/resourceManagerTests.py File tests/resourceManagerTests.py: Line 28: Line 29: import storage.resourceManager as resourceManager Line 30: from testrunner import VdsmTestCase as TestCaseBase Line 31: from testValidation import slowtest, stresstest Line 32: import monkeypatch this import should be with the non vdsm imports group This is a vdsm test utitily module, just like testrunner and testValidation. I will move it so this group is sorted by imported name. Line 33: Line 34: Line 35: class NullResourceFactory(resourceManager.SimpleResourceFactory): Line 36: Line 221: # And it should not leave a locked resource Line 222: with self.manager.acquireResource(string, test, Line 223: resourceManager.LockType.exclusive, Line 224: 0): Line 225: pass the only difference between those methos is the lock type, Good idea Line 226: Line 227: def testRegisterResourceFailureShared(self): Line 228: # This regeisterion must fail Line 229: with monkeypatch.MonkeyPatchScope( Line 741: Line 742: Line 743: def FakeRequestRef(*a, **kw): Line 744: Used to simulate failures when registering a resource Line 745: raise Failure() when you add the test helper method, those can be defined within. Good idea -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py File vdsm/storage/resourceManager.py: Line 574: Line 575: self._log.debug(Resource '%s' is currently locked, Line 576: Entering queue (%d in queue), Line 577: fullName, len(resource.queue) + 1) Line 578: ref = RequestRef(request) please move this line to be before the log Why? we always log before doing any action. I don't want to change this logging behavior in this patch. Line 579: resource.queue.insert(0, request) Line 580: return ref Line 581: Line 582: # TODO : Creating the object inside the namespace lock causes -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Enable all loggers
Dima Kuznetsov has posted comments on this change. Change subject: logging: Enable all loggers .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/25185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Liron Ar has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py File vdsm/storage/resourceManager.py: Line 574: Line 575: self._log.debug(Resource '%s' is currently locked, Line 576: Entering queue (%d in queue), Line 577: fullName, len(resource.queue) + 1) Line 578: ref = RequestRef(request) Why? we always log before doing any action. I don't want to change this log i referred to line 578, if you moved it from the return statement it seems better to have it defined also before the log. Line 579: resource.queue.insert(0, request) Line 580: return ref Line 581: Line 582: # TODO : Creating the object inside the namespace lock causes -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Enable all loggers
Dan Kenigsberg has posted comments on this change. Change subject: logging: Enable all loggers .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Enable all storage loggers
Dan Kenigsberg has posted comments on this change. Change subject: logging: Enable all storage loggers .. Patch Set 1: Is this still needed when http://gerrit.ovirt.org/#/c/25185/ is merged? -- To view, visit http://gerrit.ovirt.org/23924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py File vdsm/storage/resourceManager.py: Line 574: Line 575: self._log.debug(Resource '%s' is currently locked, Line 576: Entering queue (%d in queue), Line 577: fullName, len(resource.queue) + 1) Line 578: ref = RequestRef(request) i referred to line 578, if you moved it from the return statement it seems It seems better to keep logging before attempting to change the resource. Line 579: resource.queue.insert(0, request) Line 580: return ref Line 581: Line 582: # TODO : Creating the object inside the namespace lock causes -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
oVirt Jenkins CI Server has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7404/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6611/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7513/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 2: Changes: - Extract helper assertions - Move tests higher to acquireResource, so we don't have to change them if we kill registerResource. - Add test for acquiring a busy resource, hopefully covering all the code paths -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7405/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6612/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7514/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add shorthand NetInfo.bridges for consistency
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Add shorthand NetInfo.bridges for consistency .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf14be0a4db0678b4653512accd48b5ee9a43e1d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Add shorthand NetInfo.bridges for consistency
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: Add shorthand NetInfo.bridges for consistency .. netinfo: Add shorthand NetInfo.bridges for consistency Change-Id: Ibf14be0a4db0678b4653512accd48b5ee9a43e1d Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25212 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/netinfo.py M tests/configNetworkTests.py M tests/netmodelsTests.py 3 files changed, 8 insertions(+), 1 deletion(-) Approvals: Ondřej Svoboda: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf14be0a4db0678b4653512accd48b5ee9a43e1d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean .. netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean testSetupNetworksAddDelDhcp verifies the new property. Legacy BOOTPROTO parameter is set in a network's or iface's ['cfg'] dictionary to mimic information from ifcfg files which may be missing in current setups. Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6 Bug-Url: https://bugzilla.redhat.com/987813 Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25170 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/netinfo.py M tests/functional/dhcp.py M tests/functional/networkTests.py 3 files changed, 40 insertions(+), 6 deletions(-) Approvals: Ondřej Svoboda: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages
mooli tayer has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/21772/4/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 43: Line 44: # Line 45: # SASL definitions Line 46: # Line 47: P_EXEC_SASL = '/usr/sbin/saslpasswd2' I think it should be similar to other EXT_GREP = '@GREP_PATH@', and determi Done Line 48: SASL_USERNAME = vdsm@ovirt Line 49: Line 50: # This is the domain version translation list Line 51: # DO NOT CHANGE OLD VALUES ONLY APPEND http://gerrit.ovirt.org/#/c/21772/4/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 354: for c in __configurers: Line 355: if c.getName() in args.modules: Line 356: try: Line 357: c.removeConf() Line 358: except: please do not swallow exceptions. Done Line 359: failed.append(c.getName) Line 360: if failed: Line 361: sys.stderr.write( Line 362: Could not remove configuration for modules %s\n % ','.join(failed), Line 359: failed.append(c.getName) Line 360: if failed: Line 361: sys.stderr.write( Line 362: Could not remove configuration for modules %s\n % ','.join(failed), Line 363: ) I think this can be dropped in favour of boolean and print above. Done Line 364: raise RuntimeError(Remove configuration failed) Line 365: Line 366: Line 367: def _parse_args(action): http://gerrit.ovirt.org/#/c/21772/4/lib/vdsm/tool/passwd.py File lib/vdsm/tool/passwd.py: Line 53: Remove vdsm password for libvirt connection Line 54: Line 55: rc, out, err = utils.execCmd( Line 56: (constants.P_EXEC_SASL, '-p', '-a', 'libvirt', '-d', constants.SASL_USERNAME,), Line 57: raw=True, why raw? I saw that raw=False (default) splits output lines, and we don't need that. I not sure why its a part of the function? Remove the raw? Line 58: ) Line 59: if rc != 0: -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages
Alon Bar-Lev has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/21772/4/lib/vdsm/tool/passwd.py File lib/vdsm/tool/passwd.py: Line 53: Remove vdsm password for libvirt connection Line 54: Line 55: rc, out, err = utils.execCmd( Line 56: (constants.P_EXEC_SASL, '-p', '-a', 'libvirt', '-d', constants.SASL_USERNAME,), Line 57: raw=True, I saw that raw=False (default) splits output lines, and we don't need that. well, I tend to use default unless there is a good reason, not the other way around :) Line 58: ) Line 59: if rc != 0: -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7406/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6613/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7515/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 5: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7407/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6614/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7516/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: Enable all storage loggers
Nir Soffer has posted comments on this change. Change subject: logging: Enable all storage loggers .. Patch Set 1: This can help to configure the new loggers that were missing before. For example, some logger may log to syslog while storage logger are configured to not log to syslog. Or maybe you want to change the configuration for all storage loggers, now all sub loggers inherit the storage configuration. However I think that some loggers, like ResourceMonitor are not related to storage and should sub loggeres of utils logger (which does not exists yet). -- To view, visit http://gerrit.ovirt.org/23924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages
Alon Bar-Lev has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 5: Code-Review+1 ok, I am good, now vdsm people will probably wake up :) -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages
mooli tayer has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/21772/5/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 27: from .. import utils Line 28: from . import service, expose Line 29: from ..constants import P_VDSM_EXEC, DISKIMAGE_GROUP, QEMU_PROCESS_GROUP, \ Line 30: VDSM_GROUP, P_VDSM_LCONF, P_VDSM_QCONF, P_VDSM_LDCONF, P_SYSTEMCTL_CONF Line 31: removing unused DISKIMAGE_GROUP Line 32: Line 33: def removeSectionFromFile(filename, beginField=None, endField=None): Line 34: ( Line 35: BEFORE, -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Install vdsm.conf.example during build
Dan Kenigsberg has posted comments on this change. Change subject: Install vdsm.conf.example during build .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2606c571cd6de06eee811bbd340a790f98d11907 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Liron Ar has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 2: (6 comments) http://gerrit.ovirt.org/#/c/25284/2/tests/resourceManagerTests.py File tests/resourceManagerTests.py: Line 502: def testAcquireResourceFailureExclusive(self): Line 503: self.assertAcquireResourceFails(string, test, Line 504: resourceManager.LockType.exclusive) Line 505: self.assertCanAcquireResource(string, test, Line 506: resourceManager.LockType.exclusive) perhaps add here a check that the resource can be acquired also in shared or it can be done in assertCanAcquireResource or a new method (see comment down below) Line 507: Line 508: def testAcquireResourceFailureExclusiveBusy(self): Line 509: with self.manager.acquireResource(string, test, Line 510: resourceManager.LockType.shared, 0): Line 508: def testAcquireResourceFailureExclusiveBusy(self): Line 509: with self.manager.acquireResource(string, test, Line 510: resourceManager.LockType.shared, 0): Line 511: self.assertAcquireResourceFails(string, test, Line 512: resourceManager.LockType.exclusive) 1. this should be separated to a different patch, it tests generally the resource manager. 2. we don't need the monkeypatching in that usecase, acquiring the exclusive lock should always fail when we have the shared lock. Line 513: self.assertCanAcquireResource(string, test, Line 514: resourceManager.LockType.exclusive) Line 515: Line 516: def testAcquireResourceFailureShared(self): Line 516: def testAcquireResourceFailureShared(self): Line 517: self.assertAcquireResourceFails(string, test, Line 518: resourceManager.LockType.shared) Line 519: self.assertCanAcquireResource(string, test, Line 520: resourceManager.LockType.exclusive) perhaps add here a check that the resource can be acquired also in shared or it can be done in assertCanAcquireResource or a new method (see comment down below) Line 521: Line 522: def testAcquireResourceFailureSharedBusy(self): Line 523: with self.manager.acquireResource(string, test, Line 524: resourceManager.LockType.shared, 0): Line 524: resourceManager.LockType.shared, 0): Line 525: self.assertAcquireResourceFails(string, test, Line 526: resourceManager.LockType.shared) Line 527: self.assertCanAcquireResource(string, test, Line 528: resourceManager.LockType.exclusive) perhaps add here a check that the resource can be acquired also in shared or it can be done in assertCanAcquireResource or a new method (see comment down below) Line 529: Line 530: def testResourceStatuses(self): Line 531: manager = self.manager Line 532: self.assertEquals(manager.getResourceStatus(storage, resource), Line 736: raise Line 737: Line 738: # Helpers Line 739: Line 740: def assertAcquireResourceFails(self, namespace, name, locktype): perhaps rename to assertAcquireResourceFailsInternally or something like that Line 741: class Failure(Exception): Line 742: pass Line 743: Line 744: def FakeRequestRef(*a, **kw): Line 748: [(resourceManager, 'RequestRef', FakeRequestRef)]): Line 749: self.assertRaises(Failure, self.manager.acquireResource, Line 750: namespace, name, locktype, 0) Line 751: Line 752: def assertCanAcquireResource(self, namespace, name, locktype): this method can be refactored to check always both exclusive and shared lock (with the current use) or it can be done in the calls (see previous comments). Line 753: with self.manager.acquireResource(namespace, name, locktype, 0): -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer:
Change in vdsm[master]: lvm: remove unused add/remove tags
Yeela Kaplan has posted comments on this change. Change subject: lvm: remove unused add/remove tags .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/25013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibffb9138cb28e150f18e2283c24a60c165cde337 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method
Yeela Kaplan has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 13: Verified-1 There are a few functional tests that fail, we are dealing with them, therefore a -1. For a later iteration we might consider gathering default values of different bonding modes. E.g. after VDSM sets the miimon to its own default of 150 and, importantly, the mode to 4 (802.3ad), there appear new /sys nodes, which results in BONDING_OPTS reporting them too: ad_actor_key=0 ad_aggregator=0 ad_num_ports=0 ad_partner_key=0 miimon=150 mode=4 -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: setupNetworks: Fix incorrect mtu overriding when adding
multiple networks
..
setupNetworks: Fix incorrect mtu overriding when adding multiple networks
When configuring several networks over a bond, if the iteration over
the networks to be added made networks with lower MTUs to be added
after those with higher ones, the last mtu, regardless of value would
be set.
This was because the _netinfo object is passed from addNetworks to
addNetworks and the objectivize of the succeeding addNetworks would
not see the higher MTUs set by the preceding addNetworks.
Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072411
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M vdsm/configNetwork.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/25343/1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index ea875f9..2b6162b 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -644,6 +644,7 @@
logger.debug(Adding network %r % network)
addNetwork(network, configurator=configurator,
implicitBonding=True, _netinfo=_netinfo, **d)
+_netinfo.updateDevices() # Things like a bond mtu can change
if utils.tobool(options.get('connectivityCheck', True)):
logger.debug('Checking connectivity...')
--
To view, visit http://gerrit.ovirt.org/25343
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 3: Changes: - When checking if resource can be acquired, check both exclusive and shared locks. For checking if resource is not locked, checking exclusive is enough, but checking also shared ensure that we this code path is not broken now. It does not cost anything and make the test code more readable. - Add new tests checking failure while exclusive lock is held -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25284/2/tests/resourceManagerTests.py File tests/resourceManagerTests.py: Line 736: raise Line 737: Line 738: # Helpers Line 739: Line 740: def assertAcquireResourceFails(self, namespace, name, locktype): perhaps rename to assertAcquireResourceFailsInternally or something like th The name is little too long for me. If we will have more asserts we can rethink this name. Line 741: class Failure(Exception): Line 742: pass Line 743: Line 744: def FakeRequestRef(*a, **kw): -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...
oVirt Jenkins CI Server has posted comments on this change. Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7409/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6616/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7518/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 4: Changes: - Make pep8 happy - timeout=0 is more clear than 0 -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
oVirt Jenkins CI Server has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7410/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6617/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7519/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel P. Berrange berra...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 13:
When running all functional network tests (in alphabetical order), the
testIPv6ConfigNetwork failing leaves bonding options in a non-clean state:
ad_actor_key=0 ad_aggregator=6 ad_num_ports=1 ad_partner_key=1
ad_partner_mac=00:00:00:00:00:00 miimon=9 mode=4
Running NOSE_EXCLUDE=testIPv6ConfigNetwork ./run_tests_local.sh
functional/networkTests.py avoids this.
However, testSetupNetworksAddOverExistingBond(kwargs=False) and
testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=True) error out due
to OperStateChangedError: bond0 operstate changed: DOWN - [('bond0', 'UP'),
('bond0', 'UP')] or the like.
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/24636/2/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 297: elif (params.get('path', '') == '' and
Line 298: # line above can be removed in future, when
3.3 engine
Line 299: # is not supported
Line 300: drive.get('path', '') == ''):
Line 301: volPath = ''
do we intentionally fall out of the inner condition silently? if so, add
else:
pass
if not, add
else:
raise
Line 302:
Line 303: elif path in drive:
Line 304: volPath = drive['path']
Line 305:
Line 338: # This is so generic because supervdsm.ProxyCaller wraps a
Line 339: # multiprocessing' RemoteError into a RuntimeError.
Line 340: raise vm.VolumeError(Supervdsm call failed for %s in
Line 341: drive: %s % (device, drive))
Line 342:
I find the following implementation of the function much simpler, functionally
equivalent, and thus preferable. I see no reason to catch and translate
supervdsm-induced RuntimeError. The modified exception gives me no further
information, and only hides the (improbable, I know) case of a RuntimeError
dissipating from within mkIsoFs.
if device == 'cdrom':
return supervdsm.getProxy().mkIsoFs(vmId, payload['file'],
payload.get('volId')
elif device == 'floppy':
return supervdsm.getProxy().mkFloppyFs(vmId, payload['file'],
payload.get('volId')
else:
raise vm.VolumeError(Unsupported 'device': %s % device)
I'd understand it if you'd like to postpone this change to a follow-up patch,
but then, the introduction of except RuntimeError could wait, too.
Line 343: return mkFsFunction(vmId, payload['file'],
payload.get('volId'))
Line 344:
Line 345: def teardownVolumePath(self, drive):
Line 346: res = {'status': doneCode}
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058206b7506ddbb5ec087c9ea0963a10ed57affb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...
Dan Kenigsberg has posted comments on this change. Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25343/1//COMMIT_MSG Commit Message: Line 12: be set. Line 13: Line 14: This was because the _netinfo object is passed from addNetworks to Line 15: addNetworks and the objectivize of the succeeding addNetworks would Line 16: not see the higher MTUs set by the preceding addNetworks. Was this introduced by the recent scaling work? Can you think of a functional test that could have revealed it earlier? (I'd expect testSetupNetworksMtus, but it missed the bug) Line 17: Line 18: Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36 Line 19: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072411 -- To view, visit http://gerrit.ovirt.org/25343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect numa information
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: Collect numa information .. Patch Set 8: No Builds Executed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7411/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6618/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7520/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/23703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
David Gibson has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Code-Review+1 Looks good to me now. -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Yaniv Bronhaim has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25063/4/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 233: tune_system \ Line 234: test_space \ Line 235: test_lo \ Line 236: unified_network_persistence_upgrade \ Line 237: restore_nets \ if this change of order is mandatory i'd add a comment that it will stay this way Line 238: upgrade_300_nets \ Line 239: Line 240: ;; Line 241: --post-stop) -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24636/2/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 297: elif (params.get('path', '') == '' and
Line 298: # line above can be removed in future, when
3.3 engine
Line 299: # is not supported
Line 300: drive.get('path', '') == ''):
Line 301: volPath = ''
do we intentionally fall out of the inner condition silently? if so, add
Please add test for this case.
Line 302:
Line 303: elif path in drive:
Line 304: volPath = drive['path']
Line 305:
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058206b7506ddbb5ec087c9ea0963a10ed57affb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Nir Soffer has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: Set numatune and guest numa topology
..
Patch Set 1: Code-Review-1
(2 comments)
Please update vdsm_api/vdsmapi-schema.json if you modify the API
Also I don't like the inconsistency of 'vmNumaTopology' vs 'numaMemory'
http://gerrit.ovirt.org/#/c/25254/1/vdsm/vm.py
File vdsm/vm.py:
Line 1157:
unnecessary paranthesis
Line 1155: if 'numaMemory' in self.conf:
Line 1156: numaMemory = self.conf.get('numaMemory')
Line 1157: if ('nodeset' in numaMemory.keys()):
Line 1158: mode = 'strict'
Line 1159: if ('mode' in numaMemory.keys()):
same here
But better would be:
mode = numaMemory.get('mode', 'strict')
Which defaults to strict when mode not present
Line 1160: mode = numaMemory['mode']
Line 1161: nodeset = numaMemory['nodeset'].replace(';', ',')
Line 1162: numatune = XMLElement('numatune')
Line 1163: numatune.appendChildWithArgs('memory', mode=mode,
--
To view, visit http://gerrit.ovirt.org/25254
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
