Change in vdsm[master]: replace configure_libvirt.py with python code.
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 12: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/27298/12/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 121: self._getPersistedFiles()
Line 122: ):
Line 123: ovirtfunctions.ovirt_store_config(path)
Line 124:
Line 125: sys.stdout.write(Reconfiguration of libvirt is done.)
remove this print and update the print def configure() with modules' names
Line 126:
Line 127: def validate(self):
Line 128:
Line 129: Validate conflict in configured files
Line 311: with self._openConfig(path) as conff:
Line 312: conff.removeConf()
Line 313:
Line 314: FILES = {
Line 315:
I would put the CONF_VERSION aside the configuration and state that
modification in defaults must follow VERSION update
Line 316: # Vdsm configuration
Line 317:
Line 318: 'VDSM_CONF': {
Line 319: 'path': os.path.join(
http://gerrit.ovirt.org/#/c/27298/12/vdsm.spec.in
File vdsm.spec.in:
Line 749: removeConf
it's called remove-config
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Yaniv Bronhaim has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
Francesco Romani has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 3: (2 comments) The patch looks OK, but I'd like to know more about the scenario in order to understand if we can make an even better fix. http://gerrit.ovirt.org/#/c/27801/3//COMMIT_MSG Commit Message: Line 6: Line 7: keep pauseCode when migrating paused VM Line 8: Line 9: This patch fix a bug where the pauseCode is cleared on the destination Line 10: host when migrating paused VM. There is a bug for this? Please add a bug-url if so; if there isn't, please add a couple of lines to provide a bit more details about the scenario. Line 11: Line 12: Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 http://gerrit.ovirt.org/#/c/27801/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1952: self._ongoingCreations.release() Line 1953: self.log.debug(_ongoingCreations released) Line 1954: Line 1955: migrating = 'migrationDest' in self.conf or \ Line 1956: 'restoreState' in self.conf This cries for a cleanup/refactoring, but of course this has to be done in a separate patch (I volunteer for that) Line 1957: if migrating and self.lastStatus != vmstatus.DOWN: Line 1958: self._waitForIncomingMigrationFinish() Line 1959: Line 1960: self.lastStatus = vmstatus.UP -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add optimizations for hyperv
Francesco Romani has posted comments on this change. Change subject: vm: add optimizations for hyperv .. Patch Set 1: Will add dependency requirements -- To view, visit http://gerrit.ovirt.org/27619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28ea1d5adeda07798255484209e1a1d92c2c2bc5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8970/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9111/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8182/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 19: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8971/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9112/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8183/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add optimizations for hyperv
Francesco Romani has posted comments on this change. Change subject: vm: add optimizations for hyperv .. Patch Set 1: Apparently these options were introduced first in libvirt 1.1.0 (I'd have a preciated a reference to that in the libvirt docs. however). RHEL 6.5 has partial support (only to the 'relaxed' attribute) -- To view, visit http://gerrit.ovirt.org/27619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28ea1d5adeda07798255484209e1a1d92c2c2bc5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
Arik Hadas has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/27801/3//COMMIT_MSG Commit Message: Line 6: Line 7: keep pauseCode when migrating paused VM Line 8: Line 9: This patch fix a bug where the pauseCode is cleared on the destination Line 10: host when migrating paused VM. There is a bug for this? Please add a bug-url if so; if there isn't, please well.. the answer is yes. but.. :) it is related to bz 1053884, but not exactly and this patch is not required for the solution for that bug. I'll add few lines here as you suggested Line 11: Line 12: Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 http://gerrit.ovirt.org/#/c/27801/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1952: self._ongoingCreations.release() Line 1953: self.log.debug(_ongoingCreations released) Line 1954: Line 1955: migrating = 'migrationDest' in self.conf or \ Line 1956: 'restoreState' in self.conf This cries for a cleanup/refactoring, but of course this has to be done in +1 we should also consider line 1960 - I don't understand why we set it always to UP, what if the status on the source host was paused? we set it to up and it is switched right after that to paused when we get the status from libvirt? maybe we can set it to the status the VM had on the source host Line 1957: if migrating and self.lastStatus != vmstatus.DOWN: Line 1958: self._waitForIncomingMigrationFinish() Line 1959: Line 1960: self.lastStatus = vmstatus.UP -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
Vinzenz Feenstra has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8972/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9113/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8184/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
Francesco Romani has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27801/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1952: self._ongoingCreations.release() Line 1953: self.log.debug(_ongoingCreations released) Line 1954: Line 1955: migrating = 'migrationDest' in self.conf or \ Line 1956: 'restoreState' in self.conf +1 That is exactly what I was thinking about, and that's why I asked about the context of this patch. If we want to keep the pauseCode across a migration, chances are to always put the status to UP can be troublesome, to say the least. I'm kinda brainstorming now, but I think your suggestion to set the status as the one of the source VM could be a sensible move. Line 1957: if migrating and self.lastStatus != vmstatus.DOWN: Line 1958: self._waitForIncomingMigrationFinish() Line 1959: Line 1960: self.lastStatus = vmstatus.UP -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8974/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9115/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8186/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
Michal Skrivanek has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27801/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1957: if migrating and self.lastStatus != vmstatus.DOWN: Line 1958: self._waitForIncomingMigrationFinish() Line 1959: Line 1960: self.lastStatus = vmstatus.UP Line 1961: if self._initTimePauseCode: hm, we do some pause-related things in domDependentInit run by _waitForIncomingMigrationFinish. Might be a better place (or at least needs to be revisited). Ideally the whole block here should go away Line 1962: self.conf['pauseCode'] = self._initTimePauseCode Line 1963: if self._initTimePauseCode == 'ENOSPC': Line 1964: self.cont() Line 1965: elif not migrating: -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
Arik Hadas has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27801/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1957: if migrating and self.lastStatus != vmstatus.DOWN: Line 1958: self._waitForIncomingMigrationFinish() Line 1959: Line 1960: self.lastStatus = vmstatus.UP Line 1961: if self._initTimePauseCode: hm, we do some pause-related things in domDependentInit run by _waitForInco I noticed that part of course, it doesn't do anything in case of migration though (_initTimePauseCode remains None so the pause code does not change). shouldn't such change as you propose be made in a separate refactoring patch? Line 1962: self.conf['pauseCode'] = self._initTimePauseCode Line 1963: if self._initTimePauseCode == 'ENOSPC': Line 1964: self.cont() Line 1965: elif not migrating: -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Pyroute2 network configurator
Antoni Segura Puimedon has posted comments on this change. Change subject: Pyroute2 network configurator .. Patch Set 2: Code-Review+1 Now it just needs verification. How have you tested it (besides unit tests) and what works, what doesn't? -- To view, visit http://gerrit.ovirt.org/27745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife1ba6fca28f04bc1b171313bfb57bf630f8bc7a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Robert Cernak robocer...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon celeb...@gmail.com Gerrit-Reviewer: Peter V. Saveliev svinota.savel...@gmail.com Gerrit-Reviewer: Robert Cernak robocer...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
Michal Skrivanek has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27801/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1957: if migrating and self.lastStatus != vmstatus.DOWN: Line 1958: self._waitForIncomingMigrationFinish() Line 1959: Line 1960: self.lastStatus = vmstatus.UP Line 1961: if self._initTimePauseCode: I noticed that part of course, it doesn't do anything in case of migration I think the current code is broken. E.g. for the regular Run - we do this in domDependentInit(via _run): if self.lastStatus not in (vmstatus.MIGRATION_DESTINATION, vmstatus.RESTORING_STATE): we get here self._initTimePauseCode = self._readPauseCode(0) readPauseCode always returns NOERR if not self.recovering and self._initTimePauseCode: self.conf['pauseCode'] = self._initTimePauseCode i.e. we always set the pauseCode to NOERR and now we are removing the pause code in almost all cases. And it gets even more confusing when you track _initTimePauseCode. Line 1962: self.conf['pauseCode'] = self._initTimePauseCode Line 1963: if self._initTimePauseCode == 'ENOSPC': Line 1964: self.cont() Line 1965: elif not migrating: -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
Francesco Romani has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27801/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1957: if migrating and self.lastStatus != vmstatus.DOWN: Line 1958: self._waitForIncomingMigrationFinish() Line 1959: Line 1960: self.lastStatus = vmstatus.UP Line 1961: if self._initTimePauseCode: I think the current code is broken. To add even more, one of the driving factors, possibly the main one, to track the _initTimePauseCode is to extend the drives if needed, but the _initTimePauseCode collection is known broken: https://bugzilla.redhat.com/show_bug.cgi?id=1067414 However, to make a long -and confusing- story short, I think we simply do not cope properly with the pause code handling across migrations (including migrating paused VM). I think is safer if we review all these flows. Not sure it is within the scope of this patch, however. Line 1962: self.conf['pauseCode'] = self._initTimePauseCode Line 1963: if self._initTimePauseCode == 'ENOSPC': Line 1964: self.cont() Line 1965: elif not migrating: -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: keep pauseCode when migrating paused VM
Arik Hadas has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27801/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1957: if migrating and self.lastStatus != vmstatus.DOWN: Line 1958: self._waitForIncomingMigrationFinish() Line 1959: Line 1960: self.lastStatus = vmstatus.UP Line 1961: if self._initTimePauseCode: I think the current code is broken. but as long as self._initTimePauseCode = self._readPauseCode(0) is executed, we won't clear the pause-code (#1961) so as long as pause code = NOERR + status != paused is ok, it should be fine, right? I wonder why don't we call _readPauseCode only when the status is paused.. Line 1962: self.conf['pauseCode'] = self._initTimePauseCode Line 1963: if self._initTimePauseCode == 'ENOSPC': Line 1964: self.cont() Line 1965: elif not migrating: -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove unused remote file handler method (directWriteLines)
Yeela Kaplan has posted comments on this change. Change subject: Remove unused remote file handler method (directWriteLines) .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/27640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16be5717b492b1093a26e5a5c85cfe5a9d1b07e9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8975/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9116/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8187/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/612/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop dead ksmtuned-related code
Martin Sivák has posted comments on this change. Change subject: drop dead ksmtuned-related code .. Patch Set 2: Code-Review+1 Killing ksmtuned sounds like a good plan to me.. -- To view, visit http://gerrit.ovirt.org/27026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I511fa1754e55076084529834fa9758c2fd139761 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
Yeela Kaplan has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/26576/11/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 29: RFH = 'rfh' Line 30: IOPROC = 'ioprocess' Line 31: GLOBAL = 'Global' Line 32: Line 33: oopImpl = RFH _oopImpl as it's private to the module Done Line 34: Line 35: DEFAULT_TIMEOUT = config.getint(irs, process_pool_timeout) Line 36: HELPERS_PER_DOMAIN = config.getint(irs, process_pool_max_slots_per_domain) Line 37: -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: reorganize the graphic devices lookup
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: reorganize the graphic devices lookup .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8976/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9117/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8188/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231087647e515a1f310de45b659e512444bd0a1d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the to clipboard copypaste
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the to clipboard copypaste .. Patch Set 29: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8977/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9118/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8189/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 29: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8978/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9119/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8190/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/613/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: add the GraphicsDevice class .. Patch Set 27: removed the 'display' treatment in saveState (it breaked recovery after the last changes). I lost a +1 but it was needed :( Verification in progress, using unpatched engine. SPICE part OK: - creation - recovery - migration destination/source, repeatead - hibernation/dehibernation - verified vdsClient getVmStats output (display* params) - verified engine logs, no worrysome messages spotted Will tick Verified once VNC is tested as above -- To view, visit http://gerrit.ovirt.org/26895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 15:
(9 comments)
Partial review.
http://gerrit.ovirt.org/#/c/26300/15/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:
Line 26:
Line 27: from sslutils import SSLServerSocket
Line 28:
Line 29:
Line 30: class ProtocolDetector:
I think this name is misleading. This class does not detect protocols
(XmlDetector does), but serve connections, dispatching each connection to the
correct server.
So this should be named MultiProtocolServer or ServerDispatcher or
something similar that explain the intent.
Line 31: log = logging.getLogger(protocolDetector.ProtocolDetector)
Line 32:
Line 33: READ_ONLY = (select.POLLIN | select.POLLPRI | select.POLLHUP
Line 34: | select.POLLERR)
Line 39: self._host = host
Line 40: self._port = port
Line 41: self._default_bridge = default_bridge
Line 42:
Line 43: self._read_fd, self._write_fd = os.pipe()
These are not in non-blocking mode, so both read() and write() can block. We
clearly do not want to block the whole server when it happens, right? Both
should use nonblocking mode.
Line 44: self.poller = select.poll()
Line 45: self.socket = self._create_socket(host, port)
Line 46: self.handlers = {}
Line 47:
Line 42:
Line 43: self._read_fd, self._write_fd = os.pipe()
Line 44: self.poller = select.poll()
Line 45: self.socket = self._create_socket(host, port)
Line 46: self.handlers = {}
If you initialize handlers here, why do you keep init_handlers?
Either inline init_handlers here, or initialize this to None. This will make it
easier to detect code accessing handler before init_hanlders was invoked.
Line 47:
Line 48: self._jsonBinding = None
Line 49: self._xmlBinding = None
Line 50:
Line 57: while self._isRunning:
Line 58: events = self.poller.poll()
Line 59:
Line 60: for fd, flag in events:
Line 61: if flag (select.POLLIN | select.POLLPRI):
This (lines 61-82) is too complex. Can you break this into few simple functions
that make it easier to understand what you are doing here?
Line 62: if fd is self._read_fd:
Line 63: self._cleanup()
Line 64: elif fd is self.socket.fileno():
Line 65: (client_socket, socket_address) =
self._accept_conn()
Line 72: self.log.warn(Unrecognized protocol from
%s,
Line 73: socket_address)
Line 74: continue
Line 75:
Line 76: for handler in self.handlers.values():
This means that order of detection is random. Do we really want that? I think
in most similar systems, (e.g. routing http request by path), you like to have
clear order of handlers, so the right data structure for the handlers is a
list, not a dict.
Line 77: if handler.detect(data):
Line 78: handler.handleSocket(client_socket,
Line 79: socket_address)
Line 80: break
Line 76: for handler in self.handlers.values():
Line 77: if handler.detect(data):
Line 78: handler.handleSocket(client_socket,
Line 79: socket_address)
Line 80: break
This is a good example, for refactoring this method - there is no reason. At
this point I have data that can be detected, and I don't care how it is being
detected. So this loop should go into a method like detect_protocol, which
return the handler that should handle this connection, or actually handle this
client socket.
So this can be replaced with:
handler = self.detect_protocol(data)
if handler:
handler.handleSoccket(client_socket, socket_address)
Or:
self.handleScocket(client_socket, data)
Which will include the current code.
Line 81: else:
Line 82: pass
Line 83:
Line 84: def load_json(self, bridge):
Line 80: break
Line 81: else:
Line 82: pass
Line 83:
Line 84: def load_json(self, bridge):
Lets not make this server know anything about json/xml servers. Instead, lets
make only the detectors know about the servers, and plug in the detectors into
this server. This will make this class smaller and easier to test.
And since it does not know anything now about specific protocols, lets move it
to different file?
Line 85: from BindingJsonRpc import BindingJsonRpc
Line 86:
Line 87: self._jsonBinding =
Change in vdsm[master]: virt: graphdev: support multiple graphics devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: support multiple graphics devices .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8979/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9120/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8191/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5be348b342359d42c878937dca27454fe206a35a Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: handle ticket for multiple devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: handle ticket for multiple devices .. Patch Set 30: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8980/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9121/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8192/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62f56ea47399b0d26aafce053ea1201457564b73 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: graphdev: add the GraphicsDevice class .. Patch Set 27: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8981/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9122/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8193/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 27: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/26895/27//COMMIT_MSG
Commit Message:
Line 24:
Line 25: Noteworthy side effects of this patch:
Line 26: * It is now possible to create a VM without any display
Line 27: (aka headless VM), and they are supported.
Line 28: * The input 'display' parameter of the Vm.create API is
I'm all for headless VMs, but what was the motivation of introducing this side
effect in this refactoring patch?
Line 29: no longer mandatory
Line 30: * In the API schema, the display* parameters are now
Line 31: marked as optional, even though Engine is expected to still
Line 32: send them in the near/medium term.
Line 29: no longer mandatory
Line 30: * In the API schema, the display* parameters are now
Line 31: marked as optional, even though Engine is expected to still
Line 32: send them in the near/medium term.
Line 33: * setTicket and the internally used _reviveTicket can now
it's fine for setTicket, as it is called from outside. But _reviveTicket must
never be called if there is no ticket to revive.
Line 34: fail if they are invoked against a VM without graphic devices.
Line 35:
Line 36: Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
http://gerrit.ovirt.org/#/c/26895/27/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4281: def setTicket(self, otp, seconds, connAct, params):
Line 4282: try:
Line 4283: graphics =
_domParseStr(self._dom.XMLDesc(0)).childNodes[0]. \
Line 4284: getElementsByTagName('graphics')[0]
Line 4285: except IndexError:
Why do you add support for optional display in this patch? I thought it
intended to be refactoring-only, with no functional effect.
Line 4286: return {
Line 4287: 'status': {'code':
errCode['ticketErr']['status']['code'],
Line 4288:'message': 'no graphics devices
configured'}}
Line 4289: graphics.setAttribute('passwd', otp)
Line 4309: try:
Line 4310: graphics = _domParseStr(
Line 4311: self._dom.XMLDesc(libvirt.VIR_DOMAIN_XML_SECURE)). \
Line 4312: childNodes[0].getElementsByTagName('graphics')[0]
Line 4313: except IndexError:
Why is this needed? It seems that this function is called only if
self._vm.hasSpice.
Swallowing an error like this is a sure way to hide bugs.
Line 4314: self.log.error('no graphics devices configured')
Line 4315: return
Line 4316: validto =
max(time.strptime(graphics.getAttribute('passwdValidTo'),
Line 4317: '%Y-%m-%dT%H:%M:%S'),
--
To view, visit http://gerrit.ovirt.org/26895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 27:
(2 comments)
http://gerrit.ovirt.org/#/c/26895/27/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4281: def setTicket(self, otp, seconds, connAct, params):
Line 4282: try:
Line 4283: graphics =
_domParseStr(self._dom.XMLDesc(0)).childNodes[0]. \
Line 4284: getElementsByTagName('graphics')[0]
Line 4285: except IndexError:
Why do you add support for optional display in this patch? I thought it i
I'd say regardless the new feature, it's a safenet which is good to have
anyway.
(I'm good either way if it's here or next patch)
Line 4286: return {
Line 4287: 'status': {'code':
errCode['ticketErr']['status']['code'],
Line 4288:'message': 'no graphics devices
configured'}}
Line 4289: graphics.setAttribute('passwd', otp)
Line 4309: try:
Line 4310: graphics = _domParseStr(
Line 4311: self._dom.XMLDesc(libvirt.VIR_DOMAIN_XML_SECURE)). \
Line 4312: childNodes[0].getElementsByTagName('graphics')[0]
Line 4313: except IndexError:
Why is this needed? It seems that this function is called only if self._vm.
again as a protection it makes sense to me
Line 4314: self.log.error('no graphics devices configured')
Line 4315: return
Line 4316: validto =
max(time.strptime(graphics.getAttribute('passwdValidTo'),
Line 4317: '%Y-%m-%dT%H:%M:%S'),
--
To view, visit http://gerrit.ovirt.org/26895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add unprefixLines() to configfile.py.
mooli tayer has posted comments on this change. Change subject: vdsm-tool: add unprefixLines() to configfile.py. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27737/1//COMMIT_MSG Commit Message: Line 15: tests included (see testPrefixIdempotencey in toolTests.py). Line 16: Line 17: unprefixLines is the reverse function of prefixLines so that Line 18: unprefixLines(prefixLines(file)) = file. Line 19: please explain why it is needed. something like: in vdsm 3.x we used to set You are talking about a http://gerrit.ovirt.org/#/c/27822/ I will add a note here. Line 20: Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 -- To view, visit http://gerrit.ovirt.org/27737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Arik Hadas has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/26544/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3649: # is to prevent spurious libvirt errors about missing drive paths Line 3650: # (since we're changing them), and also to prevent to trigger a drive Line 3651: # extension for the new volume with the apparent size of the old one Line 3652: # (the apparentsize is updated as last step in updateDriveParameters) Line 3653: self.stopDisksStatsCollection() Arik, just wondering…once we do the real live RAM snapshot the above must n I'm not sure, but I see that it is also called from diskReplicateFinish which is part of live-storage-migration - similar flow to real live snapshot since in both cases the VM is running and the volume we're writing to is changed. so I think it would still be needed Line 3654: Line 3655: try: Line 3656: try: Line 3657: self._dom.snapshotCreateXML(snapxml, snapFlags) Line 3679: # This code should be removed once qemu-img will handle files Line 3680: # with size that is not multiple of block size correctly. Line 3681: if memoryParams: Line 3682: _padMemoryVolume(memoryVolPath, memoryVol['domainID']) Line 3683: # Teardown should happen anyway (also in case of exceptions). not if an exception is raised from within _padMemoryVolume(). right right, it was just a TODO for me :) sorry for the confusion Line 3684: self.cif.teardownVolumePath(memoryVol) Line 3685: Line 3686: for drive in newDrives.values(): # Update the drive information Line 3687: try: Line 3680: # with size that is not multiple of block size correctly. Line 3681: if memoryParams: Line 3682: _padMemoryVolume(memoryVolPath, memoryVol['domainID']) Line 3683: # Teardown should happen anyway (also in case of exceptions). Line 3684: self.cif.teardownVolumePath(memoryVol) how about a if memoryVolPath in the finally section? Done Line 3685: Line 3686: for drive in newDrives.values(): # Update the drive information Line 3687: try: Line 3688: self.updateDriveParameters(drive) -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: do not use OOP for padding snapshot's memory volume
Arik Hadas has posted comments on this change. Change subject: do not use OOP for padding snapshot's memory volume .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26538/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-04-08 13:58:13 +0300 Line 4: Commit: Arik Hadas aha...@redhat.com Line 5: CommitDate: 2014-04-08 13:58:13 +0300 Line 6: Line 7: do not use OOP for padding snapshot's memory volume How could it disappear when QEMU just finished writing data to it? I added an explanation to the commit msg, Federico Dan - do you agree? Line 8: Line 9: Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b -- To view, visit http://gerrit.ovirt.org/26538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Michal Skrivanek has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26544/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3649: # is to prevent spurious libvirt errors about missing drive paths Line 3650: # (since we're changing them), and also to prevent to trigger a drive Line 3651: # extension for the new volume with the apparent size of the old one Line 3652: # (the apparentsize is updated as last step in updateDriveParameters) Line 3653: self.stopDisksStatsCollection() I'm not sure, but I see that it is also called from diskReplicateFinish whi Federico, what do you say? Why is it ok to stop stats during live-storage-migration? Line 3654: Line 3655: try: Line 3656: try: Line 3657: self._dom.snapshotCreateXML(snapxml, snapFlags) -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: extract reconfiguration of x is done to ver...
mooli tayer has uploaded a new change for review. Change subject: configurator.py: extract reconfiguration of x is done to verb level. .. configurator.py: extract reconfiguration of x is done to verb level. Change-Id: I2eb2e1e889539571bd20cfb09ab1499333a47fd4 Signed-off-by: Mooli Tayer mta...@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/27841/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 54d9e8b..7af7e26 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -122,8 +122,6 @@ ): ovirtfunctions.ovirt_store_config(path) -sys.stdout.write(Reconfiguration of libvirt is done.) - def validate(self): Validate conflict in configured files @@ -676,6 +674,7 @@ sys.stdout.write(\nRunning configure...\n) for c in configurer_to_trigger: c.configure() +sys.stdout.write(Reconfiguration of %s is done. % (c.getName(),)) for s in reversed(services): service.service_start(s) -- To view, visit http://gerrit.ovirt.org/27841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2eb2e1e889539571bd20cfb09ab1499333a47fd4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add execCmd sync mode failing stress tests
Federico Simoncelli has posted comments on this change. Change subject: utils: Add execCmd sync mode failing stress tests .. Patch Set 2: Code-Review+1 Nir, given your findings, is this breaking the current build procedure? -- To view, visit http://gerrit.ovirt.org/27784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57ebd5faf028ccfc928a8b2e7ae47008f0970c23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 12:
(3 comments)
http://gerrit.ovirt.org/#/c/27298/12/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 121: self._getPersistedFiles()
Line 122: ):
Line 123: ovirtfunctions.ovirt_store_config(path)
Line 124:
Line 125: sys.stdout.write(Reconfiguration of libvirt is done.)
remove this print and update the print def configure() with modules' name
ok.
here:
http://gerrit.ovirt.org/#/c/27841/
Line 126:
Line 127: def validate(self):
Line 128:
Line 129: Validate conflict in configured files
Line 311: with self._openConfig(path) as conff:
Line 312: conff.removeConf()
Line 313:
Line 314: FILES = {
Line 315:
I would put the CONF_VERSION aside the configuration and state that modific
Done
Line 316: # Vdsm configuration
Line 317:
Line 318: 'VDSM_CONF': {
Line 319: 'path': os.path.join(
http://gerrit.ovirt.org/#/c/27298/12/vdsm.spec.in
File vdsm.spec.in:
Line 749: removeConf
it's called remove-config
Thanks. done
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: http protocol detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: http protocol detection .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8982/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9123/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8194/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f899cbab4d95ebd184bf32f3ccec1f4fa0e49bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add unprefixLines() to configfile.py.
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: add unprefixLines() to configfile.py. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8983/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9124/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8195/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
oVirt Jenkins CI Server has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8984/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9125/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8196/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: do not use OOP for padding snapshot's memory volume
oVirt Jenkins CI Server has posted comments on this change. Change subject: do not use OOP for padding snapshot's memory volume .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8985/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9126/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8197/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9127/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8198/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: improve indentation of multiline if statments.
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve indentation of multiline if statments. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8987/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9128/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8199/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3783bf50d55c54ec38c3240f66b4a14296f244a8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: prefix private methods with _
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: prefix private methods with _ .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8988/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9129/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8200/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: include default section wrapping comments. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8990/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9130/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8201/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54b6b10d64d4a2d299e8fc783880c92c07dedd7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: test for key=val pattern only after replacing...
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: test for key=val pattern only after replacing old lines. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8989/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9131/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8202/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb6094d8a1feeb45630d29e36ecad2ddfac1fca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
oVirt Jenkins CI Server has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8991/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9132/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8203/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/614/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9133/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8204/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9546c6a8f127a430aab95a0fc05ee7cb3daa887c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: improve documentation
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve documentation .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8993/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9134/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8205/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22bf0a9d38d1d14679fe65e239b45dc3c0845cfe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: extract reconfiguration of x is done to ver...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: extract reconfiguration of x is done to verb level. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8994/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9135/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8206/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2eb2e1e889539571bd20cfb09ab1499333a47fd4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
oVirt Jenkins CI Server has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8995/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9136/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8207/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/615/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Dan Kenigsberg has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 4: Code-Review+2 Escalating scores -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
Francesco Romani has uploaded a new change for review.
Change subject: virt: graphdev: support headless VM
..
virt: graphdev: support headless VM
This patch add support for headless VMs, aka VMs without
a graphic device.
Noteworthy side effects of this patch:
* It is now possible to create a VM without any display
(aka headless VM), and they are supported.
* The input 'display' parameter of the Vm.create API is
no longer mandatory
* In the API schema, the display* parameters are now
marked as optional, even though Engine is expected to still
send them in the near/medium term.
* setTicket and the internally used _reviveTicket can now
fail if they are invoked against a VM without graphic devices.
Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54
Signed-off-by: Francesco Romani from...@redhat.com
---
M tests/functional/virtTests.py
M tests/vmTests.py
M vdsm/API.py
M vdsm/virt/vm.py
M vdsm_api/vdsmapi-schema.json
5 files changed, 117 insertions(+), 72 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/27846/1
diff --git a/tests/functional/virtTests.py b/tests/functional/virtTests.py
index a074e62..9a25850 100644
--- a/tests/functional/virtTests.py
+++ b/tests/functional/virtTests.py
@@ -225,6 +225,14 @@
self._waitForStartup(vm, VM_MINIMAL_UPTIME)
@requireKVM
+def testHeadlessVm(self):
+customization = {'vmId': '----',
+ 'vmName': 'testHeadlessVm'}
+
+with RunningVm(self.vdsm, customization) as vm:
+self._waitForStartup(vm, VM_MINIMAL_UPTIME)
+
+@requireKVM
@permutations([['localfs'], ['iscsi'], ['nfs']])
def testVmWithStorage(self, backendType):
disk = storage.StorageTest()
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 69d5643..4022dfb 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -1077,6 +1077,11 @@
devs = fake.buildConfDevices()
self.assertTrue(devs['graphics'])
+def testGraphicDeviceHeadless(self):
+with FakeVM(self.conf) as fake:
+devs = fake.buildConfDevices()
+self.assertFalse(devs['graphics'])
+
def testGraphicsDeviceMixed(self):
if proper Graphics Devices are supplied, display* params must be
diff --git a/vdsm/API.py b/vdsm/API.py
index 14e7bae..4747be1 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -200,7 +200,7 @@
self.log.error(Error restoring VM parameters,
exc_info=True)
-requiredParams = ['vmId', 'memSize', 'display']
+requiredParams = ['vmId', 'memSize']
for param in requiredParams:
if param not in vmParams:
self.log.error('Missing required parameter %s' % (param))
@@ -252,11 +252,6 @@
'No space on /tmp?'}}
return errCode['createErr']
-if not vm.GraphicsDevice.isSupportedDisplayType(vmParams):
-return {'status': {'code': errCode['createErr']
- ['status']['code'],
- 'message': 'Unknown display type %s' %
- vmParams.get('display')}}
if 'nicModel' not in vmParams:
vmParams['nicModel'] = config.get('vars', 'nic_model')
return self._cif.createVm(vmParams)
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index a547a5e..5d08cea 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1344,10 +1344,6 @@
'main', 'display', 'inputs', 'cursor', 'playback',
'record', 'smartcard', 'usbredir')
-@staticmethod
-def isSupportedDisplayType(vmParams):
-return vmParams.get('display') in ('vnc', 'qxl', 'qxlnc')
-
def __init__(self, conf, log, **kwargs):
super(GraphicsDevice, self).__init__(conf, log, **kwargs)
self.port = self.LIBVIRT_PORT_AUTOSELECT
@@ -1840,8 +1836,8 @@
if len(devices[device]) 1:
raise ValueError(only a single %s device is
supported % device)
-if len(devices[GRAPHICS_DEVICES]) != 1:
-raise ValueError(one graphics device is required)
+if len(devices[GRAPHICS_DEVICES]) 1:
+raise ValueError(only one graphics device is supported)
def getConfController(self):
@@ -1866,12 +1862,16 @@
devType = DEFAULT_VIDEOS[self.arch]
elif self.hasSpice:
devType = 'qxl'
+else:
+devType = None
-monitors = int(self.conf.get('spiceMonitors', '1'))
-vram = '65536' if (monitors = 2) else '32768'
-for idx in range(monitors):
-vcards.append({'type': VIDEO_DEVICES, 'specParams': {'vram': vram},
-
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: add the GraphicsDevice class .. Patch Set 27: Verified+1 -- To view, visit http://gerrit.ovirt.org/26895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 27:
(4 comments)
http://gerrit.ovirt.org/#/c/26895/27//COMMIT_MSG
Commit Message:
Line 24:
Line 25: Noteworthy side effects of this patch:
Line 26: * It is now possible to create a VM without any display
Line 27: (aka headless VM), and they are supported.
Line 28: * The input 'display' parameter of the Vm.create API is
I'm all for headless VMs, but what was the motivation of introducing this s
A plain and simple mistake. Patch splitted into:
http://gerrit.ovirt.org/#/c/27846/
Now the current patch is stripped back to the bare refactoring changes and
preparation for the other patches in the serie.
Line 29: no longer mandatory
Line 30: * In the API schema, the display* parameters are now
Line 31: marked as optional, even though Engine is expected to still
Line 32: send them in the near/medium term.
Line 29: no longer mandatory
Line 30: * In the API schema, the display* parameters are now
Line 31: marked as optional, even though Engine is expected to still
Line 32: send them in the near/medium term.
Line 33: * setTicket and the internally used _reviveTicket can now
it's fine for setTicket, as it is called from outside. But _reviveTicket mu
Rechecked, should be fine because _reviveTicket is called only if vm.hasSpice.
Line 34: fail if they are invoked against a VM without graphic devices.
Line 35:
Line 36: Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
http://gerrit.ovirt.org/#/c/26895/27/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4281: def setTicket(self, otp, seconds, connAct, params):
Line 4282: try:
Line 4283: graphics =
_domParseStr(self._dom.XMLDesc(0)).childNodes[0]. \
Line 4284: getElementsByTagName('graphics')[0]
Line 4285: except IndexError:
I'd say regardless the new feature, it's a safenet which is good to have
Kept, in a different patch.
Line 4286: return {
Line 4287: 'status': {'code':
errCode['ticketErr']['status']['code'],
Line 4288:'message': 'no graphics devices
configured'}}
Line 4289: graphics.setAttribute('passwd', otp)
Line 4309: try:
Line 4310: graphics = _domParseStr(
Line 4311: self._dom.XMLDesc(libvirt.VIR_DOMAIN_XML_SECURE)). \
Line 4312: childNodes[0].getElementsByTagName('graphics')[0]
Line 4313: except IndexError:
again as a protection it makes sense to me
Kept, in a different patch.
Line 4314: self.log.error('no graphics devices configured')
Line 4315: return
Line 4316: validto =
max(time.strptime(graphics.getAttribute('passwdValidTo'),
Line 4317: '%Y-%m-%dT%H:%M:%S'),
--
To view, visit http://gerrit.ovirt.org/26895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: add the GraphicsDevice class .. Patch Set 28: Verified+1 Verified all the flows - creation (spice, vnc) - migration source/destination with vanilla 4.14.8.1 (spice, vnc) - recovery - hibernation/dehibernation. -- To view, visit http://gerrit.ovirt.org/26895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 28: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26895/28/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4326: def hasSpice(self):
Line 4327: return (self.conf.get('display') == 'qxl' or
Line 4328: any(dev['device'] == 'spice'
Line 4329: for dev in self.conf.get('devices', [])
Line 4330: if dev['type'] == GRAPHICS_DEVICES))
Wouldn't it be more readable:
any(dev for dev in self.conf.get('devices', ()) if
dev['type'] = GRAPHICS_DEVICES and dev['device'] == 'spice')
Line 4331:
Line 4332: def _getPid(self):
Line 4333: pid = '0'
Line 4334: try:
--
To view, visit http://gerrit.ovirt.org/26895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 28: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/26895/28/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4326: def hasSpice(self):
Line 4327: return (self.conf.get('display') == 'qxl' or
Line 4328: any(dev['device'] == 'spice'
Line 4329: for dev in self.conf.get('devices', [])
Line 4330: if dev['type'] == GRAPHICS_DEVICES))
Wouldn't it be more readable:
I'm not sure. And much like you, not going to block on that.
Line 4331:
Line 4332: def _getPid(self):
Line 4333: pid = '0'
Line 4334: try:
--
To view, visit http://gerrit.ovirt.org/26895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: add the GraphicsDevice class
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: graphdev: add the GraphicsDevice class .. virt: graphdev: add the GraphicsDevice class this patch introduces the Graphics Device class to be used to define the Vm display properties. No more than one Graphics Device is supported. If VDSM receives a Graphic Device definition, it uses that; otherwise, tries to fallback to display* parameters received as input. VDSM will continue to supply the legacy display* parameters in stats output and in the conf dictionary (VmDefinition) to preserve the backward compatibility. This includes migrations, so a VM created with a single new style graphic device can be migrated to old VDSMs without breaking cluster compatibility. Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26895 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/functional/virtTests.py M tests/vmTests.py M tests/vmTestsData.py M vdsm/API.py M vdsm/virt/vm.py M vdsm_api/vdsmapi-schema.json 6 files changed, 393 insertions(+), 132 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/26895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: reorganize the graphic devices lookup
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: reorganize the graphic devices lookup .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8996/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9137/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8208/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231087647e515a1f310de45b659e512444bd0a1d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add execCmd sync mode failing stress tests
Nir Soffer has posted comments on this change. Change subject: utils: Add execCmd sync mode failing stress tests .. Patch Set 2: The new tests always fail with current code. They always pass if rebased on http://gerrit.ovirt.org/27553. I think we need another patch before this patch, disabling the stress tests by default, since it does not make sense to run stress test each time you run the tests, and forcing everyone to run with some SKIP_STRESS_TESTS flag is crazy. When these tests are enabled, we may like more iterations and more delays between functions calls. In previous life, I used to run stress tests that run for few days. There is no reason to limit them to 30 seconds or so because they happen to be in the test suit. -- To view, visit http://gerrit.ovirt.org/27784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57ebd5faf028ccfc928a8b2e7ae47008f0970c23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] vdsm: API extension to improve the communication with ...
Itamar Heim has posted comments on this change. Change subject: [WIP] vdsm: API extension to improve the communication with the Engine .. Patch Set 7: ping -- To view, visit http://gerrit.ovirt.org/14541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa0a7a86a351a8c2d891f22802a95d1fe1bc1df4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for multiple iSCSI interfaces
Itamar Heim has abandoned this change. Change subject: vdsm: add support for multiple iSCSI interfaces .. Abandoned abandoning per last comment. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/20981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0ea11855623a9fa8398a1027b55ba7ac335998b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Goldstone m.j.goldst...@keele.ac.uk Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
Vinzenz Feenstra has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/27846/1/vdsm/API.py File vdsm/API.py: Line 251 Line 252 Line 253 Line 254 Line 255 Please leave this. See the comment for vm.py http://gerrit.ovirt.org/#/c/27846/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1345 Line 1346 Line 1347 Line 1348 Line 1349 You should rather check whether the param is present if if so that it is one of the supported ones. Please do not drop the sanitization. Even if you fall back on vnc, we should not allow invalid values. -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: refresh on mda permission mismatch
Itamar Heim has abandoned this change. Change subject: lvm: refresh on mda permission mismatch .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/20121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6a77b967a057329a90499d7707074befe756b68a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: export mininum kernel via caps
Itamar Heim has abandoned this change. Change subject: vdsm: export mininum kernel via caps .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/19792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I16c496e1a77639c39fae733e3a34c974b6f10b5c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yair Zaslavsky yzasl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Get underlying device info moved to Device classes
Itamar Heim has abandoned this change. Change subject: vdsm: Get underlying device info moved to Device classes .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/19732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8f797baece3601b88584f611b420523828f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor StoragePool.getPoolParams()
Itamar Heim has abandoned this change. Change subject: Refactor StoragePool.getPoolParams() .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/19232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibbeaaaf67a39f3ca8b27252fc631a91f266d1adc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Meital Bourvine mbour...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: geo replication status and status detail
Itamar Heim has abandoned this change. Change subject: gluster: geo replication status and status detail .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/18414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid hsm image deletions.
Itamar Heim has abandoned this change. Change subject: Avoid hsm image deletions. .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/17193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie1ec2ea8793a4ad63453559bc5f663b65f9b9336 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
Francesco Romani has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27846/1/vdsm/API.py File vdsm/API.py: Line 251 Line 252 Line 253 Line 254 Line 255 Please leave this. See the comment for vm.py Done http://gerrit.ovirt.org/#/c/27846/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1345 Line 1346 Line 1347 Line 1348 Line 1349 You should rather check whether the param is present if if so that it is on Makes sense to me. Will restore and change it the way you suggest. -- To view, visit http://gerrit.ovirt.org/27846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: More precise exception when multipath failed.
Itamar Heim has abandoned this change. Change subject: More precise exception when multipath failed. .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/17145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1b87e8e91b838db2c8a98c9afbbc998e8f4c792a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Reassign mount specification in case of backup option
Itamar Heim has abandoned this change. Change subject: mount: Reassign mount specification in case of backup option .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/16534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3166c6863dffa297bc0adcdeb4c22f810d18de8e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Adding monitorDomains.
Itamar Heim has abandoned this change. Change subject: [WIP] Adding monitorDomains. .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/14674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9f148764ac030730c93bfd9c8da25a7ea434dc33 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Remove unused 'deduceType' and MIXED_DEV
Itamar Heim has abandoned this change. Change subject: multipath: Remove unused 'deduceType' and MIXED_DEV .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/13363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I37a94c3d67641f1c78d8fbecd63cbf1480c6e1b0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: introduce VmDeviceContainer
Itamar Heim has posted comments on this change. Change subject: vmDevices: introduce VmDeviceContainer .. Patch Set 7: ping -- To view, visit http://gerrit.ovirt.org/21138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65debd35115da078df0c0cb6f50c57feb984c5a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: add mechanism to persist vmDevice defaults
Itamar Heim has posted comments on this change. Change subject: vmDevices: add mechanism to persist vmDevice defaults .. Patch Set 3: ping -- To view, visit http://gerrit.ovirt.org/21066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc8383cbce78490c8dfab1c253883a06459f1547 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make new timekeeping revertable
Itamar Heim has posted comments on this change. Change subject: vm: make new timekeeping revertable .. Patch Set 3: ping -- To view, visit http://gerrit.ovirt.org/24443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I471be44454dcae6e73c46a473eb1eee19a5275ab Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: improve pool creation error handling
Itamar Heim has posted comments on this change. Change subject: sp: improve pool creation error handling .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/22818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cce08e368dec09c081609d0663d7990ab10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: _normalizeVdsmImg refactoring
Itamar Heim has posted comments on this change. Change subject: vm: _normalizeVdsmImg refactoring .. Patch Set 4: ping -- To view, visit http://gerrit.ovirt.org/19157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie68292eee4b82fbe8527e3960739979cfe117dfa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Makefile.am: create vdsm logs on make install
Itamar Heim has posted comments on this change. Change subject: Makefile.am: create vdsm logs on make install .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/23882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f5dc4ca01fecddc5226255e37b0bab68b8c479f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: get rid of BoundedSemaphore around libvirt
Itamar Heim has posted comments on this change. Change subject: vm: get rid of BoundedSemaphore around libvirt .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/25857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a2038eadccee045e72dcf90cefe93286dab273b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: replace self.conf['devices'] by VmDeviceContainer
Itamar Heim has abandoned this change. Change subject: vmDevices: replace self.conf['devices'] by VmDeviceContainer .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/21162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3bdb5c331657c1c0d1ae902eabb5d3315d45bf8b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Itamar Heim has posted comments on this change. Change subject: vdsm-tool: vdsm-id: add force option to force generate id .. Patch Set 7: ping -- To view, visit http://gerrit.ovirt.org/20808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add man page for vdsm.conf
Itamar Heim has posted comments on this change. Change subject: Add man page for vdsm.conf .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/22891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8e5a47d484fa06070d4566a39cab8a7a53ea717 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: GuestIF Refactoring
Itamar Heim has posted comments on this change. Change subject: GuestIF Refactoring .. Patch Set 4: ping -- To view, visit http://gerrit.ovirt.org/24618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib357d770a26ef1dc80b89a32bf6808551a7d622d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow GZIP transport on XMLRPC
Itamar Heim has posted comments on this change. Change subject: Allow GZIP transport on XMLRPC .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/25201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebdaa04b17e2c1df1c1852ed536c5d6d8ec8d88b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hot(un)plug of pci-passthrough devices
Itamar Heim has posted comments on this change. Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices .. Patch Set 3: ping -- To view, visit http://gerrit.ovirt.org/22523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fbf4a1d62789d9404e5977eb7eb01b17a1a43fb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the to clipboard copypaste
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the to clipboard copypaste .. Patch Set 30: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8997/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9138/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8209/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15f3d74860b99d805d1d204704ec06afcd729484 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: Avoid log spamming when drive format is undefined
Itamar Heim has posted comments on this change. Change subject: vm: Avoid log spamming when drive format is undefined .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/22518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia50e8af94b9c9b54332066a3f30999ce73e7a56f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Avoid log spamming when drive format is undefined
Itamar Heim has abandoned this change. Change subject: vm: Avoid log spamming when drive format is undefined .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/22551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia50e8af94b9c9b54332066a3f30999ce73e7a56f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Add a releaseHostId option to stop the DomainMonitorTh...
Itamar Heim has abandoned this change. Change subject: [WIP] Add a releaseHostId option to stop the DomainMonitorThread .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/7581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I83458fb4146de7e402606916615533da305bd867 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow GZIP transport on XMLRPC
Nir Soffer has posted comments on this change. Change subject: Allow GZIP transport on XMLRPC .. Patch Set 2: This is important improvement, someone should find the time to finish it. -- To view, visit http://gerrit.ovirt.org/25201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebdaa04b17e2c1df1c1852ed536c5d6d8ec8d88b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spice: allow to disable the agent file transfer
oVirt Jenkins CI Server has posted comments on this change. Change subject: spice: allow to disable the agent file transfer .. Patch Set 30: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8998/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9139/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8210/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/616/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Replace bricks verbs removed
Itamar Heim has abandoned this change. Change subject: gluster: Replace bricks verbs removed .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/20060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I23cd224ced9c6892ab182f663476df428f2f35da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: More safe startSpm().
Itamar Heim has abandoned this change. Change subject: More safe startSpm(). .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1e6b32bdf1dd8dc36f6633306d4edef89d542e31 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: storage replace/remove too generic except handlers
Itamar Heim has abandoned this change. Change subject: vdsm: storage replace/remove too generic except handlers .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/17751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia09dcada40bca3f16f94ad7a6c83e6d7a85ade77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move fenceNode out of API.py
Itamar Heim has abandoned this change. Change subject: Move fenceNode out of API.py .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/7191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idaba551333a0f289abaff11dc113e09c426d591a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
