Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: improve functional network tests duration time
..


Patch Set 2:

ping

-- 
To view, visit https://gerrit.ovirt.org/48356
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: improve message id handling during response send

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: improve message id handling during response send
..


Patch Set 2: Verified+1

Fixed comment and rebased. Copying verification flag.

-- 
To view, visit https://gerrit.ovirt.org/49185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21102b03245da7906d5618ba9e0f9811e8864c34
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: config: Resolve crash when IPv6 disabled in kernel

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: config: Resolve crash when IPv6 disabled in kernel
..


Patch Set 4: Code-Review-1

(1 comment)

minor comment, please have this patch ready quickly.

https://gerrit.ovirt.org/#/c/47978/4/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

Line 91: updates = propose_updates_to_reported_dhcp(network_info, 
networking)
Line 92: update_reported_dhcp(updates, networking)
Line 93: 
Line 94: report_network_qos(networking)
Line 95: networking['supportsIPv6'] = ipv6_supported()
please add this in a separate patch, updating VdsmCapabilities in 
lib/api/vdsmapi-schema.json as well.
Line 96: 
Line 97: return networking
Line 98: 
Line 99: 


-- 
To view, visit https://gerrit.ovirt.org/47978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774cac868ddee08ac072adf2104a811594779052
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ollie Armstrong 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ollie Armstrong 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Align Fedora and EL qemu requirements

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: Align Fedora and EL qemu requirements
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50071
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23ef5ff5c70e9cd5979e34023f2bcf46787a8c07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: replace an annoying (and misleading) log message

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netinfo: replace an annoying (and misleading) log message
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49389
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e7d4d97efa9854f3108494879b1c3965a125481
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I160a0e2d4c734de94b0995e7433216baa88972ab
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: JsonRpcServer tests suite

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: JsonRpcServer tests suite
..


Patch Set 4:

ping

-- 
To view, visit https://gerrit.ovirt.org/43581
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1090764c7289544abe331a13ec765ceed2a53afe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Show debug message before action

[sshnaidm]

Sagi Shnaidman has posted comments on this change.

Change subject: Show debug message before action
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib868e14b91ccf75fd5c73286833af21aa23f8c01
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Show debug message before action

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Show debug message before action
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib868e14b91ccf75fd5c73286833af21aa23f8c01
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I160a0e2d4c734de94b0995e7433216baa88972ab
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: improve message id handling during response send

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: improve message id handling during response send
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21102b03245da7906d5618ba9e0f9811e8864c34
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: message tracking do not clean properly

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: message tracking do not clean properly
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: config: Resolve crash when IPv6 disabled in kernel

[automation]

gerrit-hooks has posted comments on this change.

Change subject: config: Resolve crash when IPv6 disabled in kernel
..


Patch Set 4:

* #1277204::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1277204::OK, public bug
* Check Product::#1277204::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774cac868ddee08ac072adf2104a811594779052
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ollie Armstrong 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ollie Armstrong 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: configurators: make disable_ipv6 permanent by using sysctl.d...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configurators: make disable_ipv6 permanent by using sysctl.d 
configs
..


Patch Set 5:

* #1219363::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1219363::OK, public bug
* Check Product::#1219363::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46985
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb8c529dae7a773530c6c5e98c12d33ef91968f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add vmfex-dev hook to default RPMs for install

[sshnaidm]

Sagi Shnaidman has posted comments on this change.

Change subject: Add vmfex-dev hook to default RPMs for install
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50024
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f45e14a318e2ea331d51654869e464945c730f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Align RHEL and CentOS qemu* requiments

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Align RHEL and CentOS qemu* requiments
..


Patch Set 4:

* #1248400::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1248400::OK, public bug
* Check Product::#1248400::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb1035641fd03ecd3c7b38f398a2b7679f4801
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/49097/11/lib/vdsm/netinfo/dhcp.py
File lib/vdsm/netinfo/dhcp.py:

Line 27: DhcpDevices:
> I wanted to have a neat container to replace the usage of two separate sets
I am removing it now.


-- 
To view, visit https://gerrit.ovirt.org/49097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I160a0e2d4c734de94b0995e7433216baa88972ab
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Align Fedora and EL qemu requirements

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: build: Align Fedora and EL qemu requirements
..

build: Align Fedora and EL qemu requirements

Bump the Fedora requirement to 2.3.0 to better align Fedora and EL
requirements.
This version is provided by Fedora >= 22.

Change-Id: I23ef5ff5c70e9cd5979e34023f2bcf46787a8c07
Signed-off-by: Allon Mureinik 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/50071/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index c55e01d..2643017 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -232,8 +232,8 @@
 Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7
 Requires: qemu-img-rhev >= 10:2.3.0-13.el7
 %else
-Requires: qemu-kvm >= 2:2.1.3-11
-Requires: qemu-img >= 2:2.1.3-11
+Requires: qemu-kvm >= 2:2.3.0
+Requires: qemu-img >= 2:2.3.0
 %endif # rhel
 
 # GlusterFS client-side RPMs needed for Gluster SD


-- 
To view, visit https://gerrit.ovirt.org/50071
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I23ef5ff5c70e9cd5979e34023f2bcf46787a8c07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: Send all the pending messages in handle_write
..


Patch Set 2: Code-Review+2

On the other hand we may use all the reactor cycles to work with single client 
which is not the best approach.

-- 
To view, visit https://gerrit.ovirt.org/4
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35dad03942cb53f95c57cc6b48bd3ae93885a0d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: startup: Change system default encoding to utf8

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: startup: Change system default encoding to utf8
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3f072a499ba4034bdbedd09eb60d7a3a32f9c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/49097/11/lib/vdsm/netinfo/dhcp.py
File lib/vdsm/netinfo/dhcp.py:

Line 56: argv
> can this really be an empty tuple?
When I still had here an iteration over all processes, including kernel 
threads, I would hit an infinite loop in getCmdArgs.

Now, I can use getCmdArgs (thanks to only caring about dhclients) of course, 
and enjoy its protection against falsely empty cmdlines. I haven't seen them 
yet but let's be safe.


-- 
To view, visit https://gerrit.ovirt.org/49097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I160a0e2d4c734de94b0995e7433216baa88972ab
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure that subscriptions use uniqe id

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make sure that subscriptions use uniqe id
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/46656/3/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 134: return
Line 135: 
Line 136: if sub_id in self._sub_ids:
Line 137: self._send_error("Subscription id already exists",
Line 138:  dispatcher.connection)
> Done
Checking the code to be sure and this code is run only by reactor thread so no 
need to use a lock.
Line 139: return
Line 140: 
Line 141: ack = frame.headers.get("ack", stomp.AckMode.AUTO)
Line 142: subscription = stomp._Subscription(dispatcher.connection, 
destination,


-- 
To view, visit https://gerrit.ovirt.org/46656
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3883bb68134a6e2cc52cf54ce4027122db8150e9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Show debug message before action

[sshnaidm]

Sagi Shnaidman has posted comments on this change.

Change subject: Show debug message before action
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib868e14b91ccf75fd5c73286833af21aa23f8c01
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Align RHEL and CentOS qemu* requiments

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Align RHEL and CentOS qemu* requiments
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/49974/3/vdsm.spec.in
File vdsm.spec.in:

Line 237
Line 238
Line 239
Line 240
Line 241
> +1
Sandro, see https://gerrit.ovirt.org/#/c/50071/ for that patch.


-- 
To view, visit https://gerrit.ovirt.org/49974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb1035641fd03ecd3c7b38f398a2b7679f4801
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Align Fedora and EL qemu requirements

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: build: Align Fedora and EL qemu requirements
..


Patch Set 1: Verified+1

Verification:
1. Make sure the system does not have qemu-kvm installed
2. make rpm with this patch
3. dnf install the produced RPMs
4. Make sure that qemu-img is successfully pulled from a standard repo

I tested on F22 and F23.
F22 pulled qemu-kvm-2.3.1 from @Updates.
F23 pulled qemu-kvm-2.5.0 from @system.

-- 
To view, visit https://gerrit.ovirt.org/50071
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23ef5ff5c70e9cd5979e34023f2bcf46787a8c07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: config: Resolve crash when IPv6 disabled in kernel

[automation]

gerrit-hooks has posted comments on this change.

Change subject: config: Resolve crash when IPv6 disabled in kernel
..


Patch Set 3:

* #1277204::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1277204::OK, public bug
* Check Product::#1277204::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774cac868ddee08ac072adf2104a811594779052
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ollie Armstrong 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ollie Armstrong 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 6: Code-Review+1 Continuous-Integration+1

unrelated failure

-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: make sure not to ignore response queue

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: make sure not to ignore response queue
..


Patch Set 1:

ping

-- 
To view, visit https://gerrit.ovirt.org/48609
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d6991b22f36b1a62e167a6be5c7229479f895df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding python3 run for nosetests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding python3 run for nosetests
..


Patch Set 28:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix brick devices are created with incorrect data a...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix brick devices are created with incorrect data 
alignment
..


Patch Set 3:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jsonrpcvdscli: improve functional network tests duration time
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48356/2/tests/functional/utils.py
File tests/functional/utils.py:

Line 80: def getInstance(cls):
Line 81: with cls._instanceLock:
Line 82: if cls._instance is None:
Line 83: cls._instance = VdsProxy()
Line 84: return cls._instance
Please avoid this java-like code for implementing a singleton.

The best way to implement a singleton in python is a module - you can provide a 
function to get a proxy which creates it in the first time and return a cached 
instance later.
Line 85: 
Line 86: def start(self):
Line 87: if _JSONRPC_ENABLED:
Line 88: requestQueues = config.get('addresses', 'request_queues')


-- 
To view, visit https://gerrit.ovirt.org/48356
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consolidate bondings.py naming

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: consolidate bondings.py naming
..


net: consolidate bondings.py naming

This is only a partial change. More cleanup needs to be done soon after
I1f4c16b1523822a2d53d4525841ff8741af6296c will be merged.
Parameters are now called the same. In addition function names became
relative to the module (e.g. bondinfo->info). Naming clashes were
made explicit in vlans.py, virt.sampling.py and netinfo.__initi__.py

Change-Id: Ia2f4c5b8037e30efa504d1fa416ae96d9c271fbf
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/49626
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
M lib/vdsm/netinfo/__init__.py
M lib/vdsm/netinfo/bonding.py
M lib/vdsm/netinfo/vlans.py
3 files changed, 26 insertions(+), 25 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2f4c5b8037e30efa504d1fa416ae96d9c271fbf
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: publicise misc._visible_devs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: publicise misc._visible_devs
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia836988f57aecb817f67655f2e33cd94dd3031d2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: publicise misc._visible_devs

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: publicise misc._visible_devs
..


net: publicise misc._visible_devs

It is used in many netinfo submodules

Change-Id: Ia836988f57aecb817f67655f2e33cd94dd3031d2
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/49627
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/netinfo/bonding.py
M lib/vdsm/netinfo/bridges.py
M lib/vdsm/netinfo/misc.py
M lib/vdsm/netinfo/nics.py
M lib/vdsm/netinfo/vlans.py
5 files changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia836988f57aecb817f67655f2e33cd94dd3031d2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consolidate bondings.py naming

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: consolidate bondings.py naming
..


Patch Set 9: Code-Review+2 Verified+1

copying score

-- 
To view, visit https://gerrit.ovirt.org/49626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2f4c5b8037e30efa504d1fa416ae96d9c271fbf
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix for generated code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fix for generated code
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5f06b071fcc2fda63920507f0ed8be8ff899fc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix for generated code

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: fix for generated code
..

fix for generated code

Change-Id: Ic5f06b071fcc2fda63920507f0ed8be8ff899fc0
Signed-off-by: Yaniv Bronhaim 
---
M lib/vdsm/constants.py.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/50086/1

diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index a1610c7..7b6637a 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -23,7 +23,7 @@
 from __future__ import absolute_import
 import os
 
-GLUSTER_MGMT_ENABLED = bool(@GLUSTER_MGMT@)
+GLUSTER_MGMT_ENABLED = bool(int('@GLUSTER_MGMT@'))
 
 # VDSM management networks
 LEGACY_MANAGEMENT_NETWORKS = ('ovirtmgmt', 'rhevm')


-- 
To view, visit https://gerrit.ovirt.org/50086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5f06b071fcc2fda63920507f0ed8be8ff899fc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: tests: rename config to running_config

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: network: tests: rename config to running_config
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4333aef51c45d1faef827399d42c5aa4744023e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: Send all the pending messages in handle_write
..


Patch Set 2:

I thought about my comment and as a result I gave second one. Let's have it in.

-- 
To view, visit https://gerrit.ovirt.org/4
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35dad03942cb53f95c57cc6b48bd3ae93885a0d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: init: wait for ipv4 with monitoring
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9d53f8f436b5c5f11643ae03bdd768d555b83d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: init: wait for ipv4 with monitoring
..


Patch Set 11:

rebased

-- 
To view, visit https://gerrit.ovirt.org/46148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9d53f8f436b5c5f11643ae03bdd768d555b83d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consolidate bridges.py names

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: consolidate bridges.py names
..


net: consolidate bridges.py names

Functions names became relative to the module

Change-Id: Id0e89c53f5507c80a260c760b6cfb0cd97697a39
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/49628
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/netinfo/__init__.py
M lib/vdsm/netinfo/bridges.py
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0e89c53f5507c80a260c760b6cfb0cd97697a39
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: canonify netinfo.vlans.py names

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: canonify netinfo.vlans.py names
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I686743e97b7bb0ef48381fd77c6089d5320bee11
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consolidate bridges.py names

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: consolidate bridges.py names
..


Patch Set 9: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0e89c53f5507c80a260c760b6cfb0cd97697a39
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: init: wait for ipv4 with monitoring
..


Patch Set 12: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/46148/12/init/wait_for_ipv4s
File init/wait_for_ipv4s:

Line 26: CONFFILE_HEADER_BASE
much better!


-- 
To view, visit https://gerrit.ovirt.org/46148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9d53f8f436b5c5f11643ae03bdd768d555b83d
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Introduction to transfer.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Introduction to transfer.py
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50014
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9ded4bde73b1ab504cae50d2cea726d4f77e51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Makefile: use tox to run make pep8 and pyflakes
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/49952/1/Makefile.am
File Makefile.am:

Line 94:done;
Line 95: 
Line 96: .PHONY: pyflakes-pep8
Line 97: pyflakes-pep8:
Line 98:tox
> I like a separate pep8 and pyflakes targets, and use tox to run them either
for now we want it as is  lets change and improve it after we'll have it 
in. we have more tasks to do and this one was delayed for quite long already. 
I'm fine with what it currently provides - which is much more comfortable from 
what we currently do in make
Line 99: 
Line 100: .PHONY: python3
Line 101: python3:
Line 102:   if [ -x "$(PYTHON3)" ]; then \


https://gerrit.ovirt.org/#/c/49952/1/tox.ini
File tox.ini:

Line 2: envlist = py27
Line 3: skipsdist = true
Line 4: [testenv:py27]
Line 5: commands=
Line 6: pip install pyflakes==0.9.2
> Now that it works, lets use the standard format so that we don't have to in
what standard format... be more explicit please in the comments
Line 7: python -c 'import pyflakes; print("pyflakes-%s" % 
pyflakes.__version__)'
Line 8: 
Line 9: pip install pep8==1.5.6
Line 10: python -c 'import pep8; print("pep8-%s" % pep8.__version__)'


-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: tests TODO draft

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: tests TODO draft
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37f45e513b2d0ae512fabd2fba285dff4597b5aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consolidate bondings.py naming

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: consolidate bondings.py naming
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2f4c5b8037e30efa504d1fa416ae96d9c271fbf
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consolidate bridges.py names

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: consolidate bridges.py names
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0e89c53f5507c80a260c760b6cfb0cd97697a39
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove network residues.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: remove network residues.
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49975
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I185e1ca87fa0054a9d28164fad1754132d64b821
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix for generated code

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: fix for generated code
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5f06b071fcc2fda63920507f0ed8be8ff899fc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: stomp: Send all the pending messages in handle_write
..


Patch Set 2:

Piotr, based on your comment, I'm not sure if you want this patch or not.

-- 
To view, visit https://gerrit.ovirt.org/4
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35dad03942cb53f95c57cc6b48bd3ae93885a0d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: init: wait for ipv4 with monitoring
..


Patch Set 11:

@Ondra: now im using constants from ifcfg module

-- 
To view, visit https://gerrit.ovirt.org/46148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9d53f8f436b5c5f11643ae03bdd768d555b83d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: init: wait for ipv4 with monitoring
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9d53f8f436b5c5f11643ae03bdd768d555b83d
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove network residues.

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: remove network residues.
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49975
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I185e1ca87fa0054a9d28164fad1754132d64b821
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove network residues.

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: remove network residues.
..


net: remove network residues.

Those files were forgotten in the branch after the network package
was moved under lib/vdsm/ in 65537e5.

Change-Id: I185e1ca87fa0054a9d28164fad1754132d64b821
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/49975
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
D vdsm/network/api.py
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49975
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I185e1ca87fa0054a9d28164fad1754132d64b821
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: replace an annoying (and misleading) log message

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: replace an annoying (and misleading) log message
..


Patch Set 7: Verified+1

Needless tracebacks are gone and instead, we have nice, one-line notifications 
about broken networks.

-- 
To view, visit https://gerrit.ovirt.org/49389
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e7d4d97efa9854f3108494879b1c3965a125481
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Add support for vgamem attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Add support for vgamem attribute
..


Patch Set 1:

* #1275539::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1275539::OK, public bug
* Check Product::#1275539::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: Simple jsonrpc client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: improve functional network tests duration time
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48356/2/tests/functional/utils.py
File tests/functional/utils.py:

Line 80: def getInstance(cls):
Line 81: with cls._instanceLock:
Line 82: if cls._instance is None:
Line 83: cls._instance = VdsProxy()
Line 84: return cls._instance
> Please avoid this java-like code for implementing a singleton.
Similar code is used in ClientIF and in java having singleton is not trivial 
and people tend to use enums.

Will make change this code as you suggest.
Line 85: 
Line 86: def start(self):
Line 87: if _JSONRPC_ENABLED:
Line 88: requestQueues = config.get('addresses', 'request_queues')


-- 
To view, visit https://gerrit.ovirt.org/48356
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: tests: rename config to running_config

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: tests: rename config to running_config
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4333aef51c45d1faef827399d42c5aa4744023e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix for generated code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fix for generated code
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/50086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5f06b071fcc2fda63920507f0ed8be8ff899fc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix for generated code

[ybronhei]

Yaniv Bronhaim has abandoned this change.

Change subject: fix for generated code
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/50086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic5f06b071fcc2fda63920507f0ed8be8ff899fc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: Simple jsonrpc client

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 6:

Here is my proposal how we could have command line client which uses jsonrpc.

The code was verified and I want to keep the discussion going.

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: Simple jsonrpc client

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/35181/5/contrib/jsonrpc
File contrib/jsonrpc:

Line 84: DESTINATION
This destination is not supported because it breaks the engine we can't use it.


Line 91: Listener
I like this approach. We could have something similar for our client.


-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding python3 run for nosetests

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding python3 run for nosetests
..


Patch Set 28: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.spec typo in package description

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec typo in package description
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d93bfda23cda70948af9d96b7f76198543d1953
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: drop initial bonds' slaves IP config
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.spec typo in package description

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm.spec typo in package description
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d93bfda23cda70948af9d96b7f76198543d1953
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.spec typo in package description

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm.spec typo in package description
..


vdsm.spec typo in package description

Change-Id: I0d93bfda23cda70948af9d96b7f76198543d1953
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/49661
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d93bfda23cda70948af9d96b7f76198543d1953
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: improve functional network tests duration time
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48356/2/tests/functional/utils.py
File tests/functional/utils.py:

Line 80: def getInstance(cls):
Line 81: with cls._instanceLock:
Line 82: if cls._instance is None:
Line 83: cls._instance = VdsProxy()
Line 84: return cls._instance
> Similar code is used in ClientIF and in java having singleton is not trivia
Nir means to override 'def __new__' afaik. Not so important Nir... this 
implementation is perfectly fine imo
Line 85: 
Line 86: def start(self):
Line 87: if _JSONRPC_ENABLED:
Line 88: requestQueues = config.get('addresses', 'request_queues')


-- 
To view, visit https://gerrit.ovirt.org/48356
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding python3 run for nosetests

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Adding python3 run for nosetests
..


Adding python3 run for nosetests

This patch adds list of nosetests modules that makecheck will try to run
with python3. The initial work will allow to add more verified tests to
that list until covering all of them.

Change-Id: I83355cce2af9125e6f017017905056956cd17081
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: https://gerrit.ovirt.org/48051
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M automation/check-patch.packages
M tests/Makefile.am
M vdsm.spec.in
3 files changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding python3 run for nosetests

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Adding python3 run for nosetests
..


Patch Set 28: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding python3 run for nosetests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding python3 run for nosetests
..


Patch Set 29:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Makefile: use tox to run make pep8 and pyflakes
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/49952/1/Makefile.am
File Makefile.am:

Line 94:done;
Line 95: 
Line 96: .PHONY: pyflakes-pep8
Line 97: pyflakes-pep8:
Line 98:tox
> for now we want it as is  lets change and improve it after we'll have i
Yeela, would it be hard to keep the status quo, of having to different targets, 
both using tox?
Line 99: 
Line 100: .PHONY: python3
Line 101: python3:
Line 102:   if [ -x "$(PYTHON3)" ]; then \


https://gerrit.ovirt.org/#/c/49952/1/tox.ini
File tox.ini:

Line 2: envlist = py27
Line 3: skipsdist = true
Line 4: [testenv:py27]
Line 5: commands=
Line 6: pip install pyflakes==0.9.2
> what standard format... be more explicit please in the comments
I am guessing that Nir relates to 
http://tox.readthedocs.org/en/latest/config.html?highlight=deps#confval-deps=MULTI-LINE-LIST
Line 7: python -c 'import pyflakes; print("pyflakes-%s" % 
pyflakes.__version__)'
Line 8: 
Line 9: pip install pep8==1.5.6
Line 10: python -c 'import pep8; print("pep8-%s" % pep8.__version__)'


https://gerrit.ovirt.org/#/c/49952/1/vdsm.spec.in
File vdsm.spec.in:

Line 98: 
Line 99: %if 0%{?with_check}
Line 100: BuildRequires: pyflakes
Line 101: BuildRequires: python-pep8
Line 102: BuildRequires: python-tox
> this first one is enough
isn't the *second* one enough?
Line 103: %endif
Line 104: 
Line 105: BuildRequires: systemd-units
Line 106: 


-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR
..

pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

Commit 6177a169fc84576 attempted to ignore a false pyflakes error with a
too-clever shell constract. Modern pyflake no longer complain, but the
code causes the pyflakes target to ignore real failures.

Change-Id: If5e797335d73af50e6ac4c8e1542adc4b6e4f07f
Signed-off-by: Dan Kenigsberg 
---
M Makefile.am
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/50109/1

diff --git a/Makefile.am b/Makefile.am
index bce25f4..4b7b917 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -98,17 +98,12 @@
echo "Missing absolute_import in $$f"; exit 1; fi; \
done;
 
-SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \
-   'lv' from line .*"
-
 .PHONY: pyflakes
 pyflakes:
python -c 'import pyflakes; print("pyflakes-%s" % pyflakes.__version__)'
( find . -path './.git' -prune -type f -o \
-name '*.py' -o -name '*.py.in' && \
-   echo $(WHITELIST) ) | xargs $(PYFLAKES) | \
-   grep -w -v $(SKIP_PYFLAKES_ERR) | \
-   while read LINE; do echo "$$LINE"; false; done
+   echo $(WHITELIST) ) | xargs $(PYFLAKES)
 
 .PHONY: pep8
 pep8:


-- 
To view, visit https://gerrit.ovirt.org/50109
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5e797335d73af50e6ac4c8e1542adc4b6e4f07f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

[automation]

gerrit-hooks has posted comments on this change.

Change subject: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50109
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5e797335d73af50e6ac4c8e1542adc4b6e4f07f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: tests: rename config to running_config

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: network: tests: rename config to running_config
..


Patch Set 2: Verified+1

Passed network functional tests without a regression.

-- 
To view, visit https://gerrit.ovirt.org/50004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4333aef51c45d1faef827399d42c5aa4744023e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: _read_ovf_from_tar_ova use tarfile package
..


Patch Set 1:

(3 comments)

Neat!

https://gerrit.ovirt.org/#/c/50106/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-12-08 15:56:16 +0200
Line 6: 
Line 7: v2v: _read_ovf_from_tar_ova use tarfile package
Line 8: 
Line 9: using build-in package instead of execCmd.
How about: Use tarfile instead of running tar process
Line 10: 
Line 11: Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f


https://gerrit.ovirt.org/#/c/50106/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 916: raise ClientError('OVA does not contains file with .ovf suffix')
Line 917: 
Line 918: 
Line 919: def _read_ovf_from_tar_ova(ova_path):
Line 920: tar = tarfile.TarFile(ova_path)
Also, better use the higher level interface tarfile.open().

You should close tar when you are done, use with closing(tar):.
Line 921: for member in tar.getmembers():
Line 922: if member.name.endswith('.ovf'):
Line 923: ovf = tar.extractfile(member)
Line 924: with closing(ovf):


Line 917: 
Line 918: 
Line 919: def _read_ovf_from_tar_ova(ova_path):
Line 920: tar = tarfile.TarFile(ova_path)
Line 921: for member in tar.getmembers():
Tarfile is iteratble - you can do:

for member in tar:
...
Line 922: if member.name.endswith('.ovf'):
Line 923: ovf = tar.extractfile(member)
Line 924: with closing(ovf):
Line 925: return ovf.read()


-- 
To view, visit https://gerrit.ovirt.org/50106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: use network lib instead of hardcoded path hack

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: use network lib instead of hardcoded path hack
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49967
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I788e9e071ccf394022c754e33850b74aef2cad8a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Safer fake objects for indirection tests

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Safer fake objects for indirection tests
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9e4802077316cb49d4c9f8664507bfa3b552012
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: _read_ovf_from_tar_ova use tarfile package
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/50106/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-12-08 15:56:16 +0200
Line 6: 
Line 7: v2v: _read_ovf_from_tar_ova use tarfile package
Line 8: 
Line 9: using build-in package instead of execCmd.
> How about: Use tarfile instead of running tar process
sure
Line 10: 
Line 11: Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f


https://gerrit.ovirt.org/#/c/50106/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 915
Line 916
Line 917
Line 918
Line 919
> Lets add a test for this function - before you improve it.
Next patch is a test to ovf,
The test will include tests for the zip, tar and directory ovf


Line 916: raise ClientError('OVA does not contains file with .ovf suffix')
Line 917: 
Line 918: 
Line 919: def _read_ovf_from_tar_ova(ova_path):
Line 920: tar = tarfile.TarFile(ova_path)
> Also, better use the higher level interface tarfile.open().
Done
Line 921: for member in tar.getmembers():
Line 922: if member.name.endswith('.ovf'):
Line 923: ovf = tar.extractfile(member)
Line 924: with closing(ovf):


Line 917: 
Line 918: 
Line 919: def _read_ovf_from_tar_ova(ova_path):
Line 920: tar = tarfile.TarFile(ova_path)
Line 921: for member in tar.getmembers():
> Tarfile is iteratble - you can do:
Done
Line 922: if member.name.endswith('.ovf'):
Line 923: ovf = tar.extractfile(member)
Line 924: with closing(ovf):
Line 925: return ovf.read()


-- 
To view, visit https://gerrit.ovirt.org/50106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Safer fake objects for indirection tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Safer fake objects for indirection tests
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9e4802077316cb49d4c9f8664507bfa3b552012
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: drop initial bonds' slaves IP config
..


Patch Set 2: Verified+1

Passed ovs tests without a regression. test_drop_initial_bond_slaves_ip_config 
is passing now.

-- 
To view, visit https://gerrit.ovirt.org/50100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: _read_ovf_from_tar_ova use tarfile package
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

[shavivi]

Shahar Havivi has uploaded a new change for review.

Change subject: v2v: _read_ovf_from_tar_ova use tarfile package
..

v2v: _read_ovf_from_tar_ova use tarfile package

using build-in package instead of execCmd.

Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f
Signed-off-by: Shahar Havivi 
---
M vdsm/v2v.py
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/50106/1

diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index 23f1c7f..e93ddee 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -917,13 +917,13 @@
 
 
 def _read_ovf_from_tar_ova(ova_path):
-# FIXME: change to tarfile package when support --to-stdout
-cmd = ['/usr/bin/tar', 'xf', ova_path, '*.ovf', '--to-stdout']
-rc, output, error = execCmd(cmd)
-if rc:
-raise V2VError(error)
-
-return ''.join(output)
+tar = tarfile.TarFile(ova_path)
+for member in tar.getmembers():
+if member.name.endswith('.ovf'):
+ovf = tar.extractfile(member)
+with closing(ovf):
+return ovf.read()
+raise ClientError('OVA does not contains file with .ovf suffix')
 
 
 def _add_general_ovf_info(vm, node, ns):


-- 
To view, visit https://gerrit.ovirt.org/50106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: stomp: Send all the pending messages in handle_write
..


Patch Set 2:

Yaniv, can review?

-- 
To view, visit https://gerrit.ovirt.org/4
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35dad03942cb53f95c57cc6b48bd3ae93885a0d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Use tarfile instead of running tar process

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Use tarfile instead of running tar process
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Safer fake objects for indirection tests

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: Safer fake objects for indirection tests
..


tests: Safer fake objects for indirection tests

When testing that old code is redirecting calls to new code, the fake
recording classes should inherit from object instead of the real
classes. Otherwise, the real methods may run, which may not be safe
during the tests (unwanted side effects), or cause incorrect results.

Fixing the inheritance revealed missing properties in the fake manifest
and metadata classes, that worked using the real code properties.

Change-Id: Ic9e4802077316cb49d4c9f8664507bfa3b552012
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/50029
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
---
M tests/sdm_indirection_tests.py
1 file changed, 16 insertions(+), 8 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9e4802077316cb49d4c9f8664507bfa3b552012
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: drop initial bonds' slaves IP config
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: avoid running pep8 and pyflakes on py.in files

[automation]

gerrit-hooks has posted comments on this change.

Change subject: avoid running pep8 and pyflakes on py.in files
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50101
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76d5e555455d1b4acc568a42b864e220c79ab6fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: avoid running pep8 and pyflakes on py.in files

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: avoid running pep8 and pyflakes on py.in files
..

avoid running pep8 and pyflakes on py.in files

Change-Id: I76d5e555455d1b4acc568a42b864e220c79ab6fa
Signed-off-by: Yaniv Bronhaim 
---
M Makefile.am
M automation/check-patch.sh
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/50101/1

diff --git a/Makefile.am b/Makefile.am
index bce25f4..548436a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -105,7 +105,7 @@
 pyflakes:
python -c 'import pyflakes; print("pyflakes-%s" % pyflakes.__version__)'
( find . -path './.git' -prune -type f -o \
-   -name '*.py' -o -name '*.py.in' && \
+   -name '*.py' && \
echo $(WHITELIST) ) | xargs $(PYFLAKES) | \
grep -w -v $(SKIP_PYFLAKES_ERR) | \
while read LINE; do echo "$$LINE"; false; done
@@ -116,7 +116,7 @@
for x in $(PEP8_BLACKLIST); do \
exclude="$${exclude},$${x}" ; \
done ; \
-   $(PEP8) --exclude="$${exclude}" --filename '*.py,*.py.in' . \
+   $(PEP8) --exclude="$${exclude}" --filename '*.py' . \
$(WHITELIST)
 
 .PHONY: python3
diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index 259481e..ab2be2f 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -5,7 +5,7 @@
 set -xe
 
 ./autogen.sh --system --enable-hooks
-
+make all
 make check NOSE_WITH_COVERAGE=1 NOSE_COVER_PACKAGE="$PWD/vdsm,$PWD/lib"
 
 ./automation/build-artifacts.sh


-- 
To view, visit https://gerrit.ovirt.org/50101
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76d5e555455d1b4acc568a42b864e220c79ab6fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..


Patch Set 1: Verified+1

Passed ovs tests without a regression.

-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: _read_ovf_from_tar_ova use tarfile package
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50106/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 915
Line 916
Line 917
Line 918
Line 919
Lets add a test for this function - before you improve it.

You can add a tar file with small ovf file as test data, and check that this 
function returns the contents of the file.

Another option it to generate the tarfile in a temporary directory during the 
test. I would use existing file since it requires less code and less likely to 
break.

The test should also test invalid tar without ovf file.


-- 
To view, visit https://gerrit.ovirt.org/50106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: Send all the pending messages in handle_write
..


stomp: Send all the pending messages in handle_write

We used to send one pending message in handle_write, and poll again,
which would wake up the reactor immediately since the socket is still
writable.

When socket is writable, we like to send all the pending data until
there is no data to send, or the socket buffers are full.

This change should send data quicker and consume less cpu time.

Change-Id: I35dad03942cb53f95c57cc6b48bd3ae93885a0d2
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/4
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
---
M lib/yajsonrpc/stomp.py
1 file changed, 16 insertions(+), 14 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/4
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35dad03942cb53f95c57cc6b48bd3ae93885a0d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

[derez]

Daniel Erez has posted comments on this change.

Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..


Patch Set 22: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/41999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c1fa58d64efbb3cbc7eea84189fc8375b6fa3d
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Remove the lib64 vdsm python directory

[ykaplan]

Yeela Kaplan has posted comments on this change.

Change subject: spec: Remove the lib64 vdsm python directory
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50115
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dc611cfad83739af3d0706570420cb6dc9630c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Use tarfile instead of running tar process

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: Use tarfile instead of running tar process
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/50106/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 916: raise ClientError('OVA does not contains file with .ovf suffix')
Line 917: 
Line 918: 
Line 919: def _read_ovf_from_tar_ova(ova_path):
Line 920: with closing(tarfile.open(ova_path)) as tar:
You don't need closing() here, since the returned file object support the 
context manager interface - use:

with tarfile.open(path) as tar:
...
Line 921: for member in tar:
Line 922: if member.name.endswith('.ovf'):
Line 923: with tar.extractfile(member) as ovf:
Line 924: return ovf.read()


Line 919: def _read_ovf_from_tar_ova(ova_path):
Line 920: with closing(tarfile.open(ova_path)) as tar:
Line 921: for member in tar:
Line 922: if member.name.endswith('.ovf'):
Line 923: with tar.extractfile(member) as ovf:
This does not work, the returned file-like object does not support the context 
manager protocol, so you must close it using "with closing()".
Line 924: return ovf.read()
Line 925: raise ClientError('OVA does not contains file with .ovf 
suffix')
Line 926: 
Line 927: 


-- 
To view, visit https://gerrit.ovirt.org/50106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: tests: rename config to running_config

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: network: tests: rename config to running_config
..


network: tests: rename config to running_config

Let's be more explicit and call 'config' (= self.vdsm_net.config)
'running_config' because of we call it like that everywhere.

Change-Id: I4333aef51c45d1faef827399d42c5aa4744023e2
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/50004
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
---
M tests/functional/networkTests.py
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4333aef51c45d1faef827399d42c5aa4744023e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches