Change in vdsm[master]: gluster: fix brick devices are created with incorrect data a...

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: fix brick devices are created with incorrect data 
alignment
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: DONTMERGE virt: use "run_async" helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: DONTMERGE virt: use "run_async" helper
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3147b6e860b9839b656257fcc22bf6f4b3c58914
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[fromani]

Francesco Romani has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 2: Code-Review+1

looks OK, will merge once branch 3.6.1 is created. ETA: next monday (20151214)

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 8:

Post-rebase fix: __recording__ renamed to __calls__ in tests.

-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: do not use status after getStat()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: do not use status after getStat()
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f1d330376590d0c4060baa9b13e5496c8b7f9ee
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: make status field private

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: make status field private
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic14e19f0576512dde081a2bb575915563843ee87
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after migration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: vm: Update time on VM after migration
..


Patch Set 3: Code-Review-1

We should wait with this until qemu-guest-agent issues are resolved, as 
discussed in https://gerrit.ovirt.org/48860.

-- 
To view, visit https://gerrit.ovirt.org/49212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes

[rnachimu]

Hello Piotr Kliczewski, Bala.FA, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/50312

to review the following change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..

gluster: Added VDSM verb to stop gluster related processes

Added a verb which stops the gluster related process like
brick processes, gsyncd process.
This needs to be done as part of a host moving to maintenance
mode. as data should not be available if a host is moved to
maintenence mode for some migration etc.

Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Bug-URL: https://bugzilla.redhat.com/1205724
Signed-off-by: Shubhendu Tripathi 
Reviewed-on: https://gerrit.ovirt.org/43821
Tested-by: Ramesh N 
Continuous-Integration: Jenkins CI
Reviewed-by: Bala.FA 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
5 files changed, 45 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/50312/1

diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index a4bce63..89b90ee 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -740,6 +740,11 @@
 pp.pprint(status)
 return status['status']['code'], status['status']['message']
 
+def do_glusterProcessesStop(self, args):
+status = self.s.glusterProcessesStop()
+pp.pprint(status)
+return status['status']['code'], status['status']['message']
+
 
 def getGlusterCmdDict(serv):
 return \
@@ -1252,5 +1257,10 @@
  serv.do_glusterSnapshotScheduleReset,
  ('',
   'Reset gluster snapshot scheduling'
+  )),
+ 'glusterProcessesStop': (
+ serv.do_glusterProcessesStop,
+ ('',
+  'Stop gluster processes'
   ))
  }
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 781ab77..5748115 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -52,6 +52,12 @@
 "/usr/sbin/snap_scheduler.py",
 )
 
+_stopAllProcessesPath = utils.CommandPath(
+"stop-all-gluster-processes.sh",
+"/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh",
+)
+
+
 GLUSTER_RPM_PACKAGES = (
 ('glusterfs', ('glusterfs',)),
 ('glusterfs-fuse', ('glusterfs-fuse',)),
@@ -263,6 +269,14 @@
 raise ge.GlusterSnapshotScheduleFlagUpdateFailedException(
 err=[str(e)])
 return True
+
+
+@makePublic
+def processesStop():
+command = ["/bin/sh", _stopAllProcessesPath.cmd]
+rc, out, err = utils.execCmd(command)
+if rc:
+raise ge.GlusterProcessesStopFailedException(rc)
 
 
 class GlusterApi(object):
@@ -752,6 +766,10 @@
 def snapshotScheduleReset(self, options=None):
 self.svdsmProxy.glusterSnapshotScheduleFlagUpdate("none")
 
+@exportAsVerb
+def processesStop(self):
+self.svdsmProxy.glusterProcessesStop()
+
 
 def getGlusterMethods(gluster):
 l = []
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 4768a86..a018c76 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -86,6 +86,9 @@
 return self._gluster.createBrick(name, mountPoint,
  devList, fsType, raidParams)
 
+def processesStop(self):
+return self._gluster.processesStop()
+
 
 class GlusterService(GlusterApiBase):
 def __init__(self):
diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py
index 17ad018..a4f373a 100644
--- a/vdsm/gluster/exception.py
+++ b/vdsm/gluster/exception.py
@@ -102,6 +102,11 @@
 message = "Command failed"
 
 
+class GlusterProcessesStopFailedException(GlusterGeneralException):
+code = 4579
+message = "Failed to stop gluster processes"
+
+
 # Volume
 class GlusterVolumeException(GlusterException):
 code = 4111
diff --git a/vdsm/rpc/vdsmapi-gluster-schema.json 
b/vdsm/rpc/vdsmapi-gluster-schema.json
index c86f43c..233497f 100644
--- a/vdsm/rpc/vdsmapi-gluster-schema.json
+++ b/vdsm/rpc/vdsmapi-gluster-schema.json
@@ -1299,6 +1299,15 @@
  'returns': 'bool'}
 
 ##
+# @GlusterHost.processesStop:
+#
+# Stops the gluster processes on the host
+#
+# Since: 4.17.0
+##
+{'command': {'class': 'GlusterHost', 'name': 'processesStop'}}
+
+##
 # @GlusterVolumeStatsInfo:
 #
 # Gluster Volumes disk usage statistics


-- 
To view, visit https://gerrit.ovirt.org/50312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 

Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: DONTMERGE virt: use "run_async" helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: DONTMERGE virt: use "run_async" helper
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3147b6e860b9839b656257fcc22bf6f4b3c58914
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 4:

Rebase and fix the docstring mistakes kindly pointed out by Milan.

-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Add dependencies for generated .py files

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: build: Add dependencies for generated .py files
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57eeba76a5e07a1edeae6869e103547347e874cf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Add support for vgamem attribute

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: virt: Add support for vgamem attribute
..


virt: Add support for vgamem attribute

SPICE/QXL video RAM sizes are currently specified in  domain XML
element using the following attributes: ram, vram, vgamem.  VDSM is
missing support for vgamem, this patch adds it.

Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355
Bug-Url: https://bugzilla.redhat.com/1275539
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/50091
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Nir Soffer 
Reviewed-by: Vinzenz Feenstra 
Tested-by: Nir Soffer 
---
M lib/api/vdsmapi-schema.json
M tests/deviceTests.py
M vdsm/virt/vmdevices/core.py
3 files changed, 12 insertions(+), 7 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Add support for vgamem attribute

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Add support for vgamem attribute
..


Patch Set 3: Verified+1

Was verified before improving schema docs.

-- 
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 9: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/48860/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1206: nseconds = int((t - seconds) * 10**9)
Line 1207: try:
Line 1208: self._dom.setTime(time={'seconds': seconds, 'nseconds': 
nseconds})
Line 1209: except libvirt.libvirtError as e:
Line 1210: log_method = self.log.debug
We don't need to add this complexity just to log with different log level. If 
we want to use a common prefix ("Failed to set time"), can add it in a simple 
way:

format = "Failed to set time: %s"
if code == x:
self.log.debug(format, "message 1"
elif code = y:
self.log.debug(format, "message 2"
else:
self.log.error(format, e)
Line 1211: code = e.get_error_code()
Line 1212: if code == libvirt.VIR_ERR_AGENT_UNRESPONSIVE:
Line 1213: message = "QEMU agent unresponsive"
Line 1214: elif code == libvirt.VIR_ERR_NO_SUPPORT:


Line 1216: else:
Line 1217: message = e
Line 1218: log_method = self.log.error
Line 1219: log_method("Failed to set time: %s", message)
Line 1220: except virdomain.NotConnectedError:
Why do need to handle this here? We don't want to handle this error in every 
method. It should bubble up to the main error handler.
Line 1221: self.log.debug("Failed to set time: not connected")
Line 1222: else:
Line 1223: self.log.debug('Time updated to: %d.%09d', seconds, 
nseconds)
Line 1224: 


Line 2814: del self.conf['restoreState']
Line 2815: fromSnapshot = self.conf.pop('restoreFromSnapshot', 
False)
Line 2816: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), 
self.conf,
Line 2817:{'FROM_SNAPSHOT': 
fromSnapshot})
Line 2818: self._syncGuestTime()
If we lost connection here, it should bubble up to the top level error handler. 
Here we continue with the normal flow, which seems like a bad idea.
Line 2819: elif 'migrationDest' in self.conf:
Line 2820: if self._needToWaitForMigrationToComplete():
Line 2821: usedTimeout = self._waitForUnderlyingMigration()
Line 2822: self._attachLibvirtDomainAfterMigration(


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: properties: Add properties module

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: properties: Add properties module
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/40822/6/lib/vdsm/properties.py
File lib/vdsm/properties.py:

Line 141: class _Number(Property):
Line 142: 
Line 143: def __init__(self, required=False, default=None, doc=None, 
minval=None,
Line 144:  maxval=None):
Line 145: if minval is not None and default is not None and default < 
minval:
We have bunch of the same checks. It would be good to have single method which 
would be used in all 4 places.
Line 146: raise ValueError("Invalid default %s < %s" % (default, 
minval))
Line 147: if maxval is not None and default is not None and default > 
maxval:
Line 148: raise ValueError("Invalid default %s > %s" % (default, 
maxval))
Line 149: super(_Number, self).__init__(required=required, 
default=default,


-- 
To view, visit https://gerrit.ovirt.org/40822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62175172dddce7f84319e3c8669747994e06a697
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Add support for vgamem attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Add support for vgamem attribute
..


Patch Set 4:

* #1275539::Update tracker: OK
* Set MODIFIED::bug 1275539#1275539IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after migration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: vm: Update time on VM after migration
..


Patch Set 3:

agreed. Do we have an ETA of any form for qemu-guest-agent? I guess this will 
take quite some time to get fixed.

-- 
To view, visit https://gerrit.ovirt.org/49212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/49570/3/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 137: If `logger` is set, unhandled exceptions which occurs
Line 138: after the execution is succesfully started will be logged
Line 139: on this logger; Otherwise the root logger will be used.
Line 140: If `resource' is not None, run_async will acquire it
Line 141: before to start the `func' callable, and will
> Done
Omitted this one actually?
Line 142: release it once `func' exits.
Line 143: `resource' must support the threading.Semaphore protocol.
Line 144: If `error' is not None, it will be used as argument of
Line 145: AsyncStartError.


-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: make status field private

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: migration: make status field private
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic14e19f0576512dde081a2bb575915563843ee87
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: properties: Add properties module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: properties: Add properties module
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/40822/6/lib/vdsm/properties.py
File lib/vdsm/properties.py:

Line 141: class _Number(Property):
Line 142: 
Line 143: def __init__(self, required=False, default=None, doc=None, 
minval=None,
Line 144:  maxval=None):
Line 145: if minval is not None and default is not None and default < 
minval:
> We have bunch of the same checks. It would be good to have single method wh
I see 2 places - checking minval and maxval with default. This check is very 
similar but has different check (< or >) and different log message. Can you 
show me an example of doing this check in a more clear way?
Line 146: raise ValueError("Invalid default %s < %s" % (default, 
minval))
Line 147: if maxval is not None and default is not None and default > 
maxval:
Line 148: raise ValueError("Invalid default %s > %s" % (default, 
maxval))
Line 149: super(_Number, self).__init__(required=required, 
default=default,


-- 
To view, visit https://gerrit.ovirt.org/40822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62175172dddce7f84319e3c8669747994e06a697
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 9: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/49570/3/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 137: If `logger` is set, unhandled exceptions which occurs
Line 138: after the execution is succesfully started will be logged
Line 139: on this logger; Otherwise the root logger will be used.
Line 140: If `resource' is not None, run_async will acquire it
Line 141: before to start the `func' callable, and will
> Omitted this one actually?
just missed a ':w' :(
Line 142: release it once `func' exits.
Line 143: `resource' must support the threading.Semaphore protocol.
Line 144: If `error' is not None, it will be used as argument of
Line 145: AsyncStartError.


-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: track and report abort reason

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: track and report abort reason
..


Patch Set 6:

* #1154397::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1154397::OK, public bug
* Check Product::#1154397::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47b939845f049319766a32e784da64d63bc0a982
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: don't mess up with _status fields

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: don't mess up with _status fields
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec1f705fd28d11e6048379c9dc33a752a07a2f9e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: enhance migration.SourceThread.stop()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: enhance migration.SourceThread.stop()
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ab50fc789dde969b2fb9ab969241ed4ad12545c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: return copy of internal status

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: return copy of internal status
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I080b8d461ffef4fe7053b36326175568d39e90ed
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 2: -Verified

* #1205724::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1205724::OK, public bug
* Check Product::#1205724::OK, Correct classification oVirt
* Check TM::#1205724::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 3:

(5 comments)

https://gerrit.ovirt.org/#/c/49570/3/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 133: """
Line 134: Execute one callable, `func', in a background thread.
Line 135: If `name' is not None, set it as the thread name.
Line 136: If `daemon' is True, create a daemon thread.
Line 137: If `logger` is set, unhandled exceptions which occurs
> ... occur
Done
Line 138: after the execution is succesfully started will be logged
Line 139: on this logger; Otherwise the root logger will be used.
Line 140: If `resource' is not None, run_async will acquire it
Line 141: before to start the `func' callable, and will


Line 134: Execute one callable, `func', in a background thread.
Line 135: If `name' is not None, set it as the thread name.
Line 136: If `daemon' is True, create a daemon thread.
Line 137: If `logger` is set, unhandled exceptions which occurs
Line 138: after the execution is succesfully started will be logged
> ... execution _was_ succes_s_fully started ...
Done
Line 139: on this logger; Otherwise the root logger will be used.
Line 140: If `resource' is not None, run_async will acquire it
Line 141: before to start the `func' callable, and will
Line 142: release it once `func' exits.


Line 135: If `name' is not None, set it as the thread name.
Line 136: If `daemon' is True, create a daemon thread.
Line 137: If `logger` is set, unhandled exceptions which occurs
Line 138: after the execution is succesfully started will be logged
Line 139: on this logger; Otherwise the root logger will be used.
> ... otherwise ...
Done
Line 140: If `resource' is not None, run_async will acquire it
Line 141: before to start the `func' callable, and will
Line 142: release it once `func' exits.
Line 143: `resource' must support the threading.Semaphore protocol.


Line 137: If `logger` is set, unhandled exceptions which occurs
Line 138: after the execution is succesfully started will be logged
Line 139: on this logger; Otherwise the root logger will be used.
Line 140: If `resource' is not None, run_async will acquire it
Line 141: before to start the `func' callable, and will
> before starting the ...
Done
Line 142: release it once `func' exits.
Line 143: `resource' must support the threading.Semaphore protocol.
Line 144: If `error' is not None, it will be used as argument of
Line 145: AsyncStartError.


Line 141: before to start the `func' callable, and will
Line 142: release it once `func' exits.
Line 143: `resource' must support the threading.Semaphore protocol.
Line 144: If `error' is not None, it will be used as argument of
Line 145: AsyncStartError.
> AsyncStartError (in case the thread could not be started).
Done
Line 146: """
Line 147: starting_error = [None]
Line 148: started = threading.Event()
Line 149: 


-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/48860/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1217: message = e
Line 1218: log_method = self.log.error
Line 1219: log_method("Failed to set time: %s", message)
Line 1220: except virdomain.NotConnectedError:
Line 1221: self.log.debug("Failed to set time: not connected")
e.g. here it would deserve to be a warning or error I guess
Line 1222: else:
Line 1223: self.log.debug('Time updated to: %d.%09d', seconds, 
nseconds)
Line 1224: 
Line 1225: def shutdown(self, delay, message, reboot, timeout, force):


Line 2814: del self.conf['restoreState']
Line 2815: fromSnapshot = self.conf.pop('restoreFromSnapshot', 
False)
Line 2816: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), 
self.conf,
Line 2817:{'FROM_SNAPSHOT': 
fromSnapshot})
Line 2818: self._syncGuestTime()
> It did not fail, you are disconnected. You should handle this in the top le
I think reporting "error" somewhere is fine, but the overall fate of migration 
should be unaffected
Line 2819: elif 'migrationDest' in self.conf:
Line 2820: if self._needToWaitForMigrationToComplete():
Line 2821: usedTimeout = self._waitForUnderlyingMigration()
Line 2822: self._attachLibvirtDomainAfterMigration(


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 9: -Code-Review

(2 comments)

https://gerrit.ovirt.org/#/c/48860/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1216: else:
Line 1217: message = e
Line 1218: log_method = self.log.error
Line 1219: log_method("Failed to set time: %s", message)
Line 1220: except virdomain.NotConnectedError:
> Why do need to handle this here? We don't want to handle this error in ever
ok, disconnects shouldn't happen and are a reason to propagate all the way up. 
I agree.

Such assumption is not always ok though, as e.g. VM related functions are 
failing around lifecycle events and we don't want to bail out. But this should 
never be the case for libvirt connectivity
Line 1221: self.log.debug("Failed to set time: not connected")
Line 1222: else:
Line 1223: self.log.debug('Time updated to: %d.%09d', seconds, 
nseconds)
Line 1224: 


Line 2814: del self.conf['restoreState']
Line 2815: fromSnapshot = self.conf.pop('restoreFromSnapshot', 
False)
Line 2816: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), 
self.conf,
Line 2817:{'FROM_SNAPSHOT': 
fromSnapshot})
Line 2818: self._syncGuestTime()
> But syncGuestTime does not know anything about migration, this is not the p
syncGuestTime never supposed to fail the operation. It won't fail migration 
resume, cont from EIO...so I don't see a reason why to make the code 
complicated.
So it makes sense the "handling" is within syncGuestTime.
Line 2819: elif 'migrationDest' in self.conf:
Line 2820: if self._needToWaitForMigrationToComplete():
Line 2821: usedTimeout = self._waitForUnderlyingMigration()
Line 2822: self._attachLibvirtDomainAfterMigration(


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 9:

(4 comments)

https://gerrit.ovirt.org/#/c/48860/9/tests/vmTests.py
File tests/vmTests.py:

Line 1562: self.assertLessEqual(nseconds, 10 ** 9)
Line 1563: passed_time = seconds + nseconds * 1.0 / 10 ** 9
Line 1564: current_time = time.time()
Line 1565: self.assertLess(abs(passed_time - current_time), 1)
Line 1566: orig_set_time(time=time_)
To complicated, and too different from the way we tests other stuff. We prefer 
to collect data in the fake domain, and assert about it in the test.
Line 1567: 
Line 1568: def test_sync_guest_time(self):
Line 1569: vm = self._make_vm()
Line 1570: dom = vm._dom


Line 1564: current_time = time.time()
Line 1565: self.assertLess(abs(passed_time - current_time), 1)
Line 1566: orig_set_time(time=time_)
Line 1567: 
Line 1568: def test_sync_guest_time(self):
Should be something like test_success, do not repeat the class name here.
Line 1569: vm = self._make_vm()
Line 1570: dom = vm._dom
Line 1571: orig_set_time = dom.setTime
Line 1572: with MonkeyPatchScope([


Line 1575: ]):
Line 1576: vm._syncGuestTime()
Line 1577: calls = dom.__calls__
Line 1578: self.assertEqual(len(calls), 1)
Line 1579: self.assertEqual(calls[0][0], 'setTime')
You are spreading asserts all over, making it hard to understand.

How about this:

class FakeDomain(object):

@recorded
def setTime(self, seconds, nseconds):
pass

@MonkeyPatch(time, 'time', lambda: 12345678.123456)
def test_success(self):
vm = TestingVm(FakeDomain())
vm._setGuestTime()
self.assertEqual(vm._dom.__calls__, [
('setTime', (12345678, 123456), {}),
])
Line 1580: 
Line 1581: @permutations([[libvirt.VIR_ERR_AGENT_UNRESPONSIVE],
Line 1582:[libvirt.VIR_ERR_NO_SUPPORT],
Line 1583:[libvirt.VIR_ERR_INTERNAL_ERROR]])


Line 1582:[libvirt.VIR_ERR_NO_SUPPORT],
Line 1583:[libvirt.VIR_ERR_INTERNAL_ERROR]])
Line 1584: def test_sync_guest_time_on_error(self, virt_error):
Line 1585: vm = self._make_vm(virt_error=virt_error)
Line 1586: vm._syncGuestTime()
It looks like you test that libvirt errors are swallowed. The test should be 
more clear about this.

Also, since the we have a nice focus class for these tests, we don't need to 
repeat set_guest_time in the test name.

I think that renaming the method and adding a comment would make it clear 
enough:

def test_swallow_expected_errors(self, virt_error):
vm = self._make_vm(virt_error=virt_error)
# Should not raise
vm._syncGuestTime()

We have also a more formal way to assert that something did not raise:

with self.assertNotRaises():
vm._syncGuestTime()

This will make the test fail if it raises, while the former method will cause a 
test error.
Line 1587: 
Line 1588: 
Line 1589: def _load_xml(name):
Line 1590: test_path = os.path.realpath(__file__)


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/48860/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2814: del self.conf['restoreState']
Line 2815: fromSnapshot = self.conf.pop('restoreFromSnapshot', 
False)
Line 2816: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), 
self.conf,
Line 2817:{'FROM_SNAPSHOT': 
fromSnapshot})
Line 2818: self._syncGuestTime()
> If we lost connection here, it should bubble up to the top level error hand
we don't really care if synctime fails. we should continue and end successfully
Line 2819: elif 'migrationDest' in self.conf:
Line 2820: if self._needToWaitForMigrationToComplete():
Line 2821: usedTimeout = self._waitForUnderlyingMigration()
Line 2822: self._attachLibvirtDomainAfterMigration(


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/48860/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2814: del self.conf['restoreState']
Line 2815: fromSnapshot = self.conf.pop('restoreFromSnapshot', 
False)
Line 2816: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), 
self.conf,
Line 2817:{'FROM_SNAPSHOT': 
fromSnapshot})
Line 2818: self._syncGuestTime()
> I think reporting "error" somewhere is fine, but the overall fate of migrat
But syncGuestTime does not know anything about migration, this is not the place 
to ensure that migration succeeds if this fail.

The rule is - don't handle errors you cannot handle.
Line 2819: elif 'migrationDest' in self.conf:
Line 2820: if self._needToWaitForMigrationToComplete():
Line 2821: usedTimeout = self._waitForUnderlyingMigration()
Line 2822: self._attachLibvirtDomainAfterMigration(


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/48860/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2814: del self.conf['restoreState']
Line 2815: fromSnapshot = self.conf.pop('restoreFromSnapshot', 
False)
Line 2816: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), 
self.conf,
Line 2817:{'FROM_SNAPSHOT': 
fromSnapshot})
Line 2818: self._syncGuestTime()
> we don't really care if synctime fails. we should continue and end successf
It did not fail, you are disconnected. You should handle this in the top level 
request error handler.
Line 2819: elif 'migrationDest' in self.conf:
Line 2820: if self._needToWaitForMigrationToComplete():
Line 2821: usedTimeout = self._waitForUnderlyingMigration()
Line 2822: self._attachLibvirtDomainAfterMigration(


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/50272/1/tests/manifest_tests.py
File tests/manifest_tests.py:

Line 170: acquired = 
manifest._lvTagMetaSlotLock.acquire(False)
Line 171: self.assertFalse(acquired)
Line 172: 
Line 173: 
Line 174: class FakeStorageDomainManifest(sd.StorageDomainManifest):
> This is not really a fake object, but a subclass that good only for testing
Done
Line 175: def __init__(self):
Line 176: pass
Line 177: 
Line 178: @recorded


Line 192: with manifest.domain_lock(1):
Line 193: expected_calls.append(("acquireDomainLock", (1,), {}))
Line 194: self.assertEqual(manifest.__calls__, expected_calls)
Line 195: expected_calls.append(("releaseDomainLock", (), {}))
Line 196: self.assertEqual(manifest.__calls__, expected_calls)
> I would simplify like this - first, record another method:
Done
Line 197: 
Line 198: def test_domainlock_contextmanager_exception(self):
Line 199: class InjectedFailure(Exception):
Line 200: pass


Line 207: self.assertEqual(manifest.__calls__, expected_calls)
Line 208: raise InjectedFailure()
Line 209: except InjectedFailure:
Line 210: expected_calls.append(("releaseDomainLock", (), {}))
Line 211: self.assertEqual(manifest.__calls__, expected_calls)
> I would test it like this:
Done


-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: updating for VDSM 4.17.4 on Debian jessie

[stirabos]

Simone Tiraboschi has abandoned this change.

Change subject: packaging: updating for VDSM 4.17.4 on Debian jessie
..


Abandoned

Moved to https://gerrit.ovirt.org/49257

-- 
To view, visit https://gerrit.ovirt.org/37737
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I04be8619306e387f8fd528e2bf072c37e7ea8483
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: extract specific classes for libvirt and ova

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: extract specific classes for libvirt and ova
..


Patch Set 4:

(7 comments)

https://gerrit.ovirt.org/#/c/49951/4/vdsm/v2v.py
File vdsm/v2v.py:

Line 159: 
Line 160: 
Line 161: def convert_external_vm(uri, username, password, vminfo, job_id, irs):
Line 162: command = LibvirtCommand(uri, username, password, vminfo, job_id, 
irs)
Line 163: job = ImportVm(command)
job_id belongs to the job, not to the LibvirtCommand.
Line 164: job.start()
Line 165: _add_job(job_id, job)
Line 166: return {'status': doneCode}
Line 167: 


Line 167: 
Line 168: 
Line 169: def convert_ova(ova_path, vminfo, job_id, irs):
Line 170: command = OvaCommand(ova_path, vminfo, job_id, irs)
Line 171: job = ImportVm(command)
job_id belongs to the job, not to the OvaCommand.
Line 172: job.start()
Line 173: _add_job(job_id, job)
Line 174: return response.success()
Line 175: 


Line 299: def proc(self):
Line 300: return self._proc
Line 301: 
Line 302: @contextmanager
Line 303: def execute(self):
You sould provide instead a context manager for preparing volumes, like the 
password_file context manager:

def prepared_volumes(self):
self._generate_disk_parameters()
self._prepare_volumes()
try:
yield
finally:
self._teardown_volumes()

Subclasses can combine this, for example, LIbvirtCommand.execute:

def execute(self):
with self._prepare_volumes(), self._password_file():
proc = execCmd(...)
yield proc

OvaCommand.execute needs only the volumes, so:

def execute(self):
with self._prepare_volumes():
proc = execCmd(...)
yield proc

If the execCmd(...) is common, it can also moved up:

def execute(self):
with self._prepare_volumes():
yield self._start_v2v_process()
Line 304: self._generate_disk_parameters()
Line 305: self._prepare_volumes()
Line 306: try:
Line 307: self._proc = execCmd(self._command(), sync=False,


Line 309:  nice=NICENESS.HIGH,
Line 310:  ioclass=IOCLASS.IDLE,
Line 311:  env=self.environments())
Line 312: 
Line 313: yield
Why not:

yield proc

And you don't need the the proc() method now.
Line 314: finally:
Line 315: self._teardown_volumes()
Line 316: 
Line 317: def _get_disk_format(self):


Line 325: try:
Line 326: self._disk_parameters.append('--vdsm-image-uuid')
Line 327: self._disk_parameters.append(disk['imageID'])
Line 328: self._disk_parameters.append('--vdsm-vol-uuid')
Line 329: self._disk_parameters.append(disk['volumeID'])
Why keep disk_parameters instead of returning them? This is more fragile, as 
calling this twice is now wrong, was ok before.
Line 330: except KeyError as e:
Line 331: raise InvalidInputError('Job %r missing required 
property: %s'
Line 332: % (self._id, e))
Line 333: 


Line 448: cmd.extend(self._disk_parameters)
Line 449: return cmd
Line 450: 
Line 451: @contextmanager
Line 452: def execute(self):
> this just invoked the parent's execute(), thus feels redundant and could be
I agree, but it wold be nicer if subclasses implement their execute(), and the 
parent only provides the helper methods to do this.
Line 453: with super(self.__class__, self).execute():
Line 454: yield
Line 455: 
Line 456: 


Line 536: logging.info('Job %r finished import successfully',
Line 537:  self._command.id)
Line 538: 
Line 539: def _wait_for_process(self):
Line 540: if self._command.proc.returncode is not None:
This works, but I think this that it would be nicer if the Command classes 
generate a process object, and this class keeps this object, instead of going 
through the command object.

The command object gives no services regarding its proc object, so it should 
not keep it.
Line 541: return
Line 542: logging.debug("Job %r waiting for virt-v2v process", 
self._command.id)
Line 543: if not 
self._command.proc.wait(timeout=self.PROC_WAIT_TIMEOUT):
Line 544: raise V2VProcessError("Job %r timeout waiting for process 
pid=%s",


-- 
To view, visit https://gerrit.ovirt.org/49951
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a9ecd4a2cde6f379188da647c3a6f8874c41abd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: 

Change in vdsm[master]: tests: Add a live merge functional test

[alitke]

Adam Litke has restored this change.

Change subject: tests: Add a live merge functional test
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/29824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Idd5a2f7eedaef9e90981256de66fc3ed21658e89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yoav Kleinberger 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: updating for VDSM 4.17.4 on Debian jessie

[automation]

gerrit-hooks has posted comments on this change.

Change subject: packaging: updating for VDSM 4.17.4 on Debian jessie
..


Patch Set 35:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/37737
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04be8619306e387f8fd528e2bf072c37e7ea8483
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 2: Code-Review+1

(2 comments)

Looks good, but we can simplify the failing test even more.

https://gerrit.ovirt.org/#/c/50272/2/tests/manifest_tests.py
File tests/manifest_tests.py:

Line 191: def dummy(self):
Line 192: pass
Line 193: 
Line 194: def fail(self):
Line 195: raise InjectedFailure()
Thinking again, we don't need this - we can simply raise in the context manager.
Line 196: 
Line 197: 
Line 198: class DomainLockTests(VdsmTestCase):
Line 199: 


Line 213: try:
Line 214: with manifest.domain_lock(1):
Line 215: manifest.fail()
Line 216: except InjectedFailure:
Line 217: pass
Better use self.assertRaises for this:

with self.assertRaises(InjectedFailure):
with manitsst.domain_lock():
raise InjectedFailure


-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: report "MigrationSource" only if transferring

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: report "MigrationSource" only if transferring
..

vm: report "MigrationSource" only if transferring

When a Vm failed to migrate for whatever reason,
the reported status should be "Up", no longer
"MigrationSource".
Current Vdsm code reports instead "MigrationSource",
because of a too coarse check in Vm class.

To fix this properly is not easy, due to the asynchronous
implementation of migration supervision.
However, we can improve the reporting leveraging the new-ly
added 'transferring' property.

This patch does that, making the event raised on migration
aborted report the true status.

Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/50338/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index af8383c..ddad637 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1473,7 +1473,7 @@
 vmstatus.PAUSED, vmstatus.DOWN)
 if self.lastStatus in statuses:
 return self.lastStatus
-elif self.isMigrating():
+elif self.isMigrating() and self._migrationSource.transferring:
 if self._migrationSourceThread.hibernating:
 return vmstatus.SAVING_STATE
 else:


-- 
To view, visit https://gerrit.ovirt.org/50338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: add 'transferring' property

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: add 'transferring' property
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50337
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78fb89f8f150fb7eaad1318cbd54d057ac9da807
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: rename method

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: rename method
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50336
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f8558f85c3a9824e0fd7884fe7beed2b239f591
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: rename method

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: migration: rename method
..

migration: rename method

TODO

Change-Id: I9f8558f85c3a9824e0fd7884fe7beed2b239f591
Signed-off-by: Francesco Romani 
---
M vdsm/virt/migration.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/50336/1

diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 50b0392..e2e067d 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -307,7 +307,7 @@
 'dstparams': self._dstparams,
 'dstqemu': self._dstqemu}
 self._vm.saveState()
-self._startUnderlyingMigration(time.time())
+self._migrate(time.time())
 self._finishSuccessfully()
 except libvirt.libvirtError as e:
 if e.get_error_code() == libvirt.VIR_ERR_OPERATION_ABORTED:
@@ -325,7 +325,7 @@
 self._recover(str(e))
 self.log.exception("Failed to migrate")
 
-def _startUnderlyingMigration(self, startTime):
+def _migrate(self, startTime):
 if self.hibernating:
 hooks.before_vm_hibernate(self._vm._dom.XMLDesc(0), self._vm.conf)
 fname = self._vm.cif.prepareVolumePath(self._dst)


-- 
To view, visit https://gerrit.ovirt.org/50336
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f8558f85c3a9824e0fd7884fe7beed2b239f591
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: report "MigrationSource" only if transferring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: report "MigrationSource" only if transferring
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: add 'transferring' property

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: migration: add 'transferring' property
..

migration: add 'transferring' property

Add 'transferring' property to migration.SourceThread,
to let the client code learn if the code is performing
some useful data-transfer task, or if it is busy doing
setup/teardown duties.

The intended usage is:

sourceThread.is_alive()=True, transferring=True:
  actual migration, moving data from src to dst

sourceThread.is_alive()=True, transferring=False:
  setup/teardown in progress.

sourceThread.is_alive()=False, transferring=*
  no migration-related activity in progress

Change-Id: I78fb89f8f150fb7eaad1318cbd54d057ac9da807
Signed-off-by: Francesco Romani 
---
M vdsm/virt/migration.py
1 file changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/50337/1

diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index e2e067d..f460f8f 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -111,6 +111,11 @@
 self._monitorThread = None
 self._abort_reason_lock = threading.Lock()
 self._abort_reason = None
+self._transferring = True
+
+@property
+def transferring(self):
+return self._transferring
 
 @property
 def hibernating(self):
@@ -288,6 +293,7 @@
 raise e
 
 def run(self):
+self._transferring = True
 try:
 self._clear_abort_reason()
 startTime = time.time()
@@ -307,8 +313,13 @@
 'dstparams': self._dstparams,
 'dstqemu': self._dstqemu}
 self._vm.saveState()
-self._migrate(time.time())
+try:
+self._migrate(time.time())
+except:
+self._transferring = False
+raise
 self._finishSuccessfully()
+self._transferring = False
 except libvirt.libvirtError as e:
 if e.get_error_code() == libvirt.VIR_ERR_OPERATION_ABORTED:
 self._last_status = response.error(


-- 
To view, visit https://gerrit.ovirt.org/50337
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I78fb89f8f150fb7eaad1318cbd54d057ac9da807
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 10: Code-Review+1

Waiting for Francesco approval.

-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: report "MigrationSource" only if transferring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: report "MigrationSource" only if transferring
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: track and report abort reason

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: track and report abort reason
..


Patch Set 7:

* #1154397::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1154397::OK, public bug
* Check Product::#1154397::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47b939845f049319766a32e784da64d63bc0a982
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: rename method

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: migration: rename method
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/50336
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f8558f85c3a9824e0fd7884fe7beed2b239f591
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3: Continuous-Integration+1

jenkins failure unrelated

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3:

caused by appendMetadata - we need a try/except IndexError in sampling.py in 
_sampleCpuTune. Probably another backport.

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/50221/2/vdsm/storage/sdm/api/create_volume.py
File vdsm/storage/sdm/api/create_volume.py:

Line 32: class Job(sdm_job.SdmJob):
Line 33: def __init__(self, job_id, host_id, dom_manifest, vol_params):
Line 34: super(Job, self).__init__(job_id, 'create_volume', host_id)
Line 35: self.dom_manifest = dom_manifest
Line 36: self.vol_params = _CreateVolumeParams(vol_params)
Why not _VolumeParameters?
Line 37: 
Line 38: def _run(self):
Line 39: self.dom_manifest.validateCreateVolumeParams(
Line 40: self.vol_params.vol_format, self.vol_params.parent_vol_id)


Line 38: def _run(self):
Line 39: self.dom_manifest.validateCreateVolumeParams(
Line 40: self.vol_params.vol_format, self.vol_params.parent_vol_id)
Line 41: 
Line 42: self.dom_manifest.acquireDomainLock(self.host_id)
We can use now with dom_manifest.domain_lock(self.host_id)
Line 43: try:
Line 44: image_res_ns = sd.getNamespace(self.dom_manifest.sdUUID,
Line 45:IMAGE_NAMESPACE)
Line 46: with rmanager.acquireResource(image_res_ns, 
self.vol_params.img_id,


-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 5: Verified+1

tested the unthrottled path using patched VDSM running (and migrating) vms. 
Tested the other paths using unit tests.

-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 5:

Martin, please share your thoughts!

-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/50272/2/tests/manifest_tests.py
File tests/manifest_tests.py:

Line 191: def dummy(self):
Line 192: pass
Line 193: 
Line 194: def fail(self):
Line 195: raise InjectedFailure()
> Thinking again, we don't need this - we can simply raise in the context man
Done
Line 196: 
Line 197: 
Line 198: class DomainLockTests(VdsmTestCase):
Line 199: 


Line 213: try:
Line 214: with manifest.domain_lock(1):
Line 215: manifest.fail()
Line 216: except InjectedFailure:
Line 217: pass
> Better use self.assertRaises for this:
Done


-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 3: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: add a context manager for the domainLock
..


storage: add a context manager for the domainLock

Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/50272
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M tests/manifest_tests.py
M vdsm/storage/sd.py
2 files changed, 51 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Adam Litke: Verified



-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Handle empty QoS section with no cpu limit information
..


Patch Set 1: Verified-1

* #1219903::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1219903::OK, public bug
* Check Product::#1219903::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1219903::ERROR, wrong target milestone for stable branch, 
ovirt-3.6.1 should match ^.*3.5.*
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/50341
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860d2f92f5d6c2eb28127b4cdd7837eafe80b957
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

[msivak]

Martin Sivák has uploaded a new change for review.

Change subject: Handle empty QoS section with no cpu limit information
..

Handle empty QoS section with no cpu limit information

The 3.5 stats collecting code expected the cpu limit to be always
present when the metadata section was detected. The latest metadata
patch breaks the assumption and we have to handle it properly now.

Change-Id: I860d2f92f5d6c2eb28127b4cdd7837eafe80b957
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219903
Signed-off-by: Martin Sivak 
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/50341/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 2576522..7256680 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -390,7 +390,11 @@
 metadataCpuLimitXML = _domParseStr(metadataCpuLimit)
 nodeList = \
 metadataCpuLimitXML.getElementsByTagName('vcpuLimit')
-infos['vcpuLimit'] = nodeList[0].childNodes[0].data
+try:
+infos['vcpuLimit'] = nodeList[0].childNodes[0].data
+except IndexError:
+# No CPU limit defined yet, ignore
+pass
 
 return infos
 


-- 
To view, visit https://gerrit.ovirt.org/50341
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I860d2f92f5d6c2eb28127b4cdd7837eafe80b957
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Handle empty QoS section with no cpu limit information
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50341
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860d2f92f5d6c2eb28127b4cdd7837eafe80b957
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Handle empty QoS section with no cpu limit information
..


Patch Set 2: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/50341
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860d2f92f5d6c2eb28127b4cdd7837eafe80b957
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: add get_volume_artifacts_class to the domain manifest
..

storage: add get_volume_artifacts_class to the domain manifest

When working with a domain manifest code needs to know the type of
VolumeArtifact class to use.  Add helper methods to
BlockStorageDomainManifest and FileStorageDomainManifest to return the
proper type.

This patch expands the scope of volume_artifact_test in order to add the
BlockVolumeArtifactsTests class.  The added code will all be necessary
once more block domain support is added.

Change-Id: Iade716f7487f502243aaf280a7a8c147f501307d
Signed-off-by: Adam Litke 
---
M tests/volume_artifacts_test.py
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
3 files changed, 37 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/50339/1

diff --git a/tests/volume_artifacts_test.py b/tests/volume_artifacts_test.py
index d9edf62..62fae31 100644
--- a/tests/volume_artifacts_test.py
+++ b/tests/volume_artifacts_test.py
@@ -23,9 +23,11 @@
 from contextlib import contextmanager
 
 from testlib import VdsmTestCase, namedTemporaryDir
-from storagetestlib import make_filesd_manifest
+from monkeypatch import MonkeyPatchScope
+from storagetestlib import make_filesd_manifest, make_blocksd
+from storagefakelib import FakeLVM
 
-from storage import fileSD, fileVolume, image, sd, volume
+from storage import blockSD, fileSD, fileVolume, image, sd, volume
 from storage.sdm import volume_artifacts
 
 
@@ -35,6 +37,14 @@
 
 class ExpectedFailure(Exception):
 pass
+
+
+@contextmanager
+def fake_block_env(cls=None):
+with namedTemporaryDir() as tmpdir:
+lvm = FakeLVM(tmpdir)
+with MonkeyPatchScope([(blockSD, 'lvm', lvm)]):
+yield make_blocksd(tmpdir, lvm)
 
 
 @contextmanager
@@ -60,6 +70,11 @@
 
 def failure(*args):
 raise ExpectedFailure()
+
+def test_get_volume_artifacts_class(self):
+with self.fake_env() as manifest:
+self.assertEqual(self.artifacts_class,
+ manifest.get_volume_artifacts_class())
 
 def test_nonexist(self):
 with self.fake_env() as manifest:
@@ -188,6 +203,18 @@
   artifacts.create, *base_raw_params())
 
 
+class BlockVolumeArtifactsTests(VdsmTestCase):
+# TODO: Inherit from VolumeArtifactsTestsMixin once support is added
+
+artifacts_class = volume_artifacts.BlockVolumeArtifacts
+fake_env = fake_block_env
+
+def test_get_volume_artifacts_class(self):
+with self.fake_env() as manifest:
+self.assertEqual(self.artifacts_class,
+ manifest.get_volume_artifacts_class())
+
+
 class FileVolumeArtifactVisibilityTests(VdsmTestCase):
 
 def test_getallimages(self):
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 5453a8a..9d5e605 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -40,6 +40,7 @@
 import misc
 import fileUtils
 import sd
+import sdm
 import lvm
 import clusterlock
 import blockVolume
@@ -585,6 +586,9 @@
 """
 return blockVolume.BlockVolumeMetadata
 
+def get_volume_artifacts_class(self):
+return sdm.volume_artifacts.BlockVolumeArtifacts
+
 def _getImgExclusiveVols(self, imgUUID, volsImgs):
 """Filter vols belonging to imgUUID only."""
 exclusives = dict((vName, v) for vName, v in volsImgs.iteritems()
diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index 9248c11..00405d7 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -27,6 +27,7 @@
 import re
 
 import sd
+import sdm
 import storage_exception as se
 import fileUtils
 import fileVolume
@@ -201,6 +202,9 @@
 """
 return fileVolume.FileVolumeMetadata
 
+def get_volume_artifacts_class(self):
+return sdm.volume_artifacts.FileVolumeArtifacts
+
 def _getDeletedImagePath(self, imgUUID):
 currImgDir = self.getImagePath(imgUUID)
 dirName, baseName = os.path.split(currImgDir)


-- 
To view, visit https://gerrit.ovirt.org/50339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iade716f7487f502243aaf280a7a8c147f501307d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: add create_volume_container API stub

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: add create_volume_container API stub
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add get_volume_artifacts_class to the domain manifest
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iade716f7487f502243aaf280a7a8c147f501307d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storagefakelib: Add FakeResourceManager
..

storagefakelib: Add FakeResourceManager

Change-Id: I0302b48d984ce7eb8ce2326ab4bb033430c032f9
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 31 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/50340/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 45d9127..a8e3be7 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -20,6 +20,7 @@
 import os
 import string
 import random
+from contextlib import contextmanager
 from copy import deepcopy
 
 from storage import lvm as real_lvm
@@ -216,3 +217,19 @@
 def part(size):
 return ''.join(random.choice(chars) for _ in range(size))
 return '-'.join(part(size) for size in [6, 4, 4, 4, 4, 6])
+
+
+class FakeResourceManager(object):
+def __init__(self):
+self.__calls__ = []
+
+@contextmanager
+def acquireResource(self, *args, **kwargs):
+try:
+self.__calls__.append(('acquireResource', args, kwargs))
+yield
+finally:
+self.releaseResource(*args, **kwargs)
+
+def releaseResource(self, *args, **kwargs):
+self.__calls__.append(('releaseResource', args, kwargs))
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 68c8754..707ffc6 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -22,7 +22,7 @@
 
 from testlib import VdsmTestCase, namedTemporaryDir
 from testlib import permutations, expandPermutations
-from storagefakelib import FakeLVM
+from storagefakelib import FakeLVM, FakeResourceManager
 
 from storage import blockSD, blockVolume
 from storage import storage_exception as se
@@ -287,3 +287,16 @@
 lvm = FakeLVM(tmpdir)
 lvm_fn = getattr(lvm, fn)
 self.assertRaises(exception, lvm_fn, *args)
+
+
+class FakeResourceManagerTests(VdsmTestCase):
+
+def test_acquire_contextmanager(self):
+expected_calls = []
+rm = FakeResourceManager()
+acquire_args = ('ns', 'name', 'locktype')
+with rm.acquireResource(*acquire_args):
+expected_calls.append(('acquireResource', acquire_args, {}))
+self.assertEqual(expected_calls, rm.__calls__)
+expected_calls.append(('releaseResource', acquire_args, {}))
+self.assertEqual(expected_calls, rm.__calls__)


-- 
To view, visit https://gerrit.ovirt.org/50340
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0302b48d984ce7eb8ce2326ab4bb033430c032f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce VolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Introduce VolumeArtifacts
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagefakelib: Add FakeResourceManager
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50340
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0302b48d984ce7eb8ce2326ab4bb033430c032f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: add 'transferring' property

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: add 'transferring' property
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50337
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78fb89f8f150fb7eaad1318cbd54d057ac9da807
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: rename method

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: rename method
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50336
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f8558f85c3a9824e0fd7884fe7beed2b239f591
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Handle empty QoS section with no cpu limit information
..


Patch Set 2: Verified-1

* #1289007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1289007::OK, public bug
* Check Product::#1289007::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1289007::OK, correct target milestone ovirt-3.5.7
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/50341
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860d2f92f5d6c2eb28127b4cdd7837eafe80b957
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[mbetak]

Martin Betak has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 5: Code-Review+1

(1 comment)

Nice job! I really like the simplification over the previous implementations.

https://gerrit.ovirt.org/#/c/49570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 680: self.updateDriveIndex(drv)
Line 681: 
Line 682: return [drv for order, drv in drives]
Line 683: 
Line 684: def run(self, spawn=run_async):
this method didn't return anything before (it seems), do you utilize this new 
return value somewhere? cif/API.py?
Line 685: try:
Line 686: spawn(self._startUnderlyingVm)
Line 687: except AsyncStartError as ex:
Line 688: return response.error(ex.error)


-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: Handle empty QoS section with no cpu limit information
..


Patch Set 2: Continuous-Integration-1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/50341
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860d2f92f5d6c2eb28127b4cdd7837eafe80b957
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 2: Code-Review-1

(5 comments)

https://gerrit.ovirt.org/#/c/50221/2/vdsm/storage/sdm/api/sdm_job.py
File vdsm/storage/sdm/api/sdm_job.py:

Line 31: from .. import volume_artifacts
Line 32: 
Line 33: 
Line 34: class SdmJob(jobs.Job):
Line 35: log = logging.getLogger('Storage.SdmJob')
Lets use only lowercase logger names in new code: "storage.sdmjob", or 
"storage.sdm"
Line 36: 
Line 37: def __init__(self, job_id, desc, host_id):
Line 38: super(SdmJob, self).__init__(job_id, desc)
Line 39: self._error = None


Line 35: log = logging.getLogger('Storage.SdmJob')
Line 36: 
Line 37: def __init__(self, job_id, desc, host_id):
Line 38: super(SdmJob, self).__init__(job_id, desc)
Line 39: self._error = None
Why not move error up to Job?
Line 40: self._progress = None
Line 41: self.host_id = host_id
Line 42: 
Line 43: @property


Line 45: return self._progress
Line 46: 
Line 47: def info(self):
Line 48: sdm_info = super(SdmJob, self).info()
Line 49: sdm_info['extra_info'] = {'error': self._error}
Why not add error to standard job info?
Line 50: return sdm_info
Line 51: 
Line 52: def run(self):
Line 53: vars.job_id = self.id


Line 58:self.id, self.description)
Line 59: self._status = jobs.STATUS.FAILED
Line 60: self._error = e
Line 61: except Exception as e:
Line 62: self.log.exception("Job (id:%s desc:%s) failed",
We are using mostly (id=%s, desc=%s) in other places, and it is also the format 
used by Pyhton builtins such as namedtuple, so better keep this format.
Line 63:self.id, self.description)
Line 64: self._error = se.GENERAL_EXCEPTION(str(e))
Line 65: self._status = jobs.STATUS.FAILED
Line 66: else:


Line 60: self._error = e
Line 61: except Exception as e:
Line 62: self.log.exception("Job (id:%s desc:%s) failed",
Line 63:self.id, self.description)
Line 64: self._error = se.GENERAL_EXCEPTION(str(e))
This returns a tuple, but we want a GeneralExcpetion instance here.
If creating a GeneralException instance works with current code (it should), 
lets use it.

In the future, we should raise everywhere an error which has a response() 
method, and kill the error handling code in storage_exception.py.
Line 65: self._status = jobs.STATUS.FAILED
Line 66: else:
Line 67: self._status = jobs.STATUS.DONE


-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add a context manager for the domainLock

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: add a context manager for the domainLock
..


Patch Set 2: Verified+1

Verified with unit tests as before.

-- 
To view, visit https://gerrit.ovirt.org/50272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b831d4fe5a67f6998f31978f2399fdebdb3ceb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3:

...sorry, I misread 3.5 for 3.6. Will recheck the tests and merge

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 10:

* #1156194::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1156194::OK, public bug
* Check Product::#1156194::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3:

will check test failure, it should be bogus. Will be merged after the 3.6.1 
branch created (on monday 20151214)

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 10: Verified+1

Verified by suspending and resuming a VM with and without qemu-guest-agent 
running and checking time on the VM and VDSM log messages.

-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3: Code-Review-1

sorry for late noticing: smoke test revelead a bug

Thread-77::ERROR::2015-12-11 17:14:07,156::sampling::488::vm.Vm::(collect) 
vmId=`0eab0e22-d58b-4342-a8d9-dd9512557fd0`::Stats function failed: 

Traceback (most recent call last):
  File "/usr/share/vdsm/virt/sampling.py", line 484, in collect
statsFunction()
  File "/usr/share/vdsm/virt/sampling.py", line 359, in __call__
retValue = self._function(*args, **kwargs)
  File "/usr/share/vdsm/virt/vm.py", line 393, in _sampleCpuTune
infos['vcpuLimit'] = nodeList[0].childNodes[0].data
IndexError: list index out of range

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 1:

(17 comments)

https://gerrit.ovirt.org/#/c/50221/1/tests/sdm_verbs_test.py
File tests/sdm_verbs_test.py:

Line 38: self.sdUUID = sd_id
Line 39: 
Line 40: def validateCreateVolumeParams(self, *args):
Line 41: pass
Line 42: 
> Use @recorded and validate that the job acquired and released the lock?
Done
Line 43: def acquireDomainLock(self, *args):
Line 44: pass
Line 45: 
Line 46: def releaseDomainLock(self, *args):


Line 53: class FakeVolumeArtifacts(object):
Line 54: def __init__(self, img_id, vol_id):
Line 55: self.img_id = img_id
Line 56: self.vol_id = vol_id
Line 57: 
> Use @recorded and validate the the job created and committed?
Added TODO since I depend on the classmethod support in @recorded.
Line 58: def create(self, *args):
Line 59: pass
Line 60: 
Line 61: def commit(self):


Line 73: break
Line 74: 
Line 75: 
Line 76: @expandPermutations
Line 77: class CreateVolumeContainerTests(SdmVerbTests):
> Lets have separate tests for each verb, and put common helpers in sdmtestli
Done
Line 78: 
Line 79: def _get_args(self):
Line 80: dom_manifest = FakeDomainManifest(str(uuid.uuid4()))
Line 81: return dict(dom_manifest=dom_manifest, 
job_id=str(uuid.uuid4()),


https://gerrit.ovirt.org/#/c/50221/1/tests/storagefakelib.py
File tests/storagefakelib.py:

Line 218: return ''.join(random.choice(chars) for _ in range(size))
Line 219: return '-'.join(part(size) for size in [6, 4, 4, 4, 4, 6])
Line 220: 
Line 221: 
Line 222: class FakeResourceManager(object):
> Nice! - lets also @record operation so we can validate the locking?
I used a bit of custom recording logic to achieve this in the next version.
Line 223: @contextmanager
Line 224: def acquireResource(self, namespace, name, lockType, 
timeout=None):
Line 225: yield
Line 226: 


Line 224: def acquireResource(self, namespace, name, lockType, 
timeout=None):
Line 225: yield
Line 226: 
Line 227: def releaseResource(self, namespace, name):
Line 228: pass
> Split this into its own patch.
Done


https://gerrit.ovirt.org/#/c/50221/1/vdsm/storage/sdm/Makefile.am
File vdsm/storage/sdm/Makefile.am:

Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: SUBDIRS = jobs
> Good point, lets keep the package.
Done
Line 22: 
Line 23: include $(top_srcdir)/build-aux/Makefile.subs
Line 24: 
Line 25: vdsmsdmdir = $(vdsmdir)/storage/sdm


https://gerrit.ovirt.org/#/c/50221/1/vdsm/storage/sdm/jobs/Makefile.am
File vdsm/storage/sdm/jobs/Makefile.am:

Line 22: 
Line 23: vdsmsdmjobsdir = $(vdsmdir)/storage/sdm/jobs
Line 24: 
Line 25: dist_vdsmsdmjobs_PYTHON = \
Line 26:createVolumeContainer.py \
> While you rename it, lets use "create_volume.py"
Done
Line 27:$(NULL)


https://gerrit.ovirt.org/#/c/50221/1/vdsm/storage/sdm/jobs/createVolumeContainer.py
File vdsm/storage/sdm/jobs/createVolumeContainer.py:

Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
> Add this in every new module.
Done
Line 21: from vdsm import jobs
Line 22: from storage import resourceManager as rm
Line 23: from storage import blockVolume, fileVolume, sd
Line 24: from storage.resourceFactories import IMAGE_NAMESPACE


Line 21: from vdsm import jobs
Line 22: from storage import resourceManager as rm
Line 23: from storage import blockVolume, fileVolume, sd
Line 24: from storage.resourceFactories import IMAGE_NAMESPACE
Line 25: from storage.sdm import volumeartifacts
> We can use relative imports to import stuff from storage and storage.sdm:
Done
Line 26: 
Line 27: import sdmJob
Line 28: 
Line 29: rmanager = rm.ResourceManager.getInstance()


Line 23: from storage import blockVolume, fileVolume, sd
Line 24: from storage.resourceFactories import IMAGE_NAMESPACE
Line 25: from storage.sdm import volumeartifacts
Line 26: 
Line 27: import sdmJob
> Use relative imports when importing stuff from same package:
Done
Line 28: 
Line 29: rmanager = rm.ResourceManager.getInstance()
Line 30: 
Line 31: 


Line 47: self._progress = 0
Line 48: 
Line 49: @property
Line 50: def progress(self):
Line 51: return self._progress
> Lets keep it, and return special progress value that engine will treat as i
Let's go with None.  It seems logical.
Line 52: 
Line 53: def _run(self):
Line 54: self.dom_manifest.validateCreateVolumeParams(self.vol_format,
Line 55:  
self.parent_vol_id)


Line 65: artifacts = self._get_artifacts_instance()
Line 66: 

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

[alitke]

Adam Litke has posted comments on this change.

Change subject: XXX: All outstanding VolumeMetadata changes squashed
..


Patch Set 1: Code-Review-2

-- 
To view, visit https://gerrit.ovirt.org/50362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db8bb8bdf405b8760ecbe103dcbb1a1907ca1db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: Add _getDeletedImagePath until patch merged

[alitke]

Adam Litke has posted comments on this change.

Change subject: XXX: Add _getDeletedImagePath until patch merged
..


Patch Set 2: Code-Review-2

-- 
To view, visit https://gerrit.ovirt.org/50218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd67cacc58da27ffda7286582e263195dac96894
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: XXX: All outstanding VolumeMetadata changes squashed
..

XXX: All outstanding VolumeMetadata changes squashed

Change-Id: I5db8bb8bdf405b8760ecbe103dcbb1a1907ca1db
Signed-off-by: Adam Litke 
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/volume.py
3 files changed, 338 insertions(+), 270 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/50362/1

diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index cab02e2..a8de56a 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -30,6 +30,7 @@
 import volume
 import image
 import sd
+import blockSD
 import misc
 from misc import logskip
 from misc import deprecated
@@ -196,6 +197,18 @@
 """
 return lvm.lvPath(self.sdUUID, self.volUUID)
 
+def getVolumeSize(self, bs=BLOCK_SIZE):
+"""
+Return the volume size in blocks
+"""
+# Just call the SD Manifest method getVSize() - apparently it does what
+# we need. We consider incurred overhead of producing the object
+# to be a small price for code de-duplication.
+manifest = sdCache.produce(self.sdUUID).manifest
+return int(manifest.getVSize(self.imgUUID, self.volUUID) / bs)
+
+getVolumeTrueSize = getVolumeSize
+
 def setMetadata(self, meta, metaId=None):
 """
 Set the meta data hash as the new meta data of the Volume
@@ -270,6 +283,50 @@
 # tags
 self.setMetaParam(volume.IMAGE, imgUUID)
 
+def removeMetadata(self, metaId):
+"""
+Just wipe meta.
+"""
+try:
+self._putMetadata(metaId, {"NONE": "#" * (sd.METASIZE - 10)})
+except Exception as e:
+self.log.error(e, exc_info=True)
+raise se.VolumeMetadataWriteError("%s: %s" % (metaId, e))
+
+@classmethod
+def newVolumeLease(cls, metaId, sdUUID, volUUID):
+cls.log.debug("Initializing volume lease volUUID=%s sdUUID=%s, "
+  "metaId=%s", volUUID, sdUUID, metaId)
+manifest = blockSD.BlockStorageDomainManifest(sdUUID)
+metaSdUUID, mdSlot = metaId
+
+leasePath = manifest.getLeasesFilePath()
+leaseOffset = ((mdSlot + RESERVED_LEASES)
+   * manifest.logBlkSize * sd.LEASE_BLOCKS)
+
+sanlock.init_resource(sdUUID, volUUID, [(leasePath, leaseOffset)])
+
+def refreshVolume(self):
+lvm.refreshLVs(self.sdUUID, (self.volUUID,))
+
+def _share(self, dstImgPath):
+"""
+Share this volume to dstImgPath
+"""
+dstPath = os.path.join(dstImgPath, self.volUUID)
+
+self.log.debug("Share volume %s to %s", self.volUUID, dstImgPath)
+os.symlink(self._md.getDevPath(), dstPath)
+
+@classmethod
+def getImageVolumes(cls, repoPath, sdUUID, imgUUID):
+"""
+Fetch the list of the Volumes UUIDs, not including the shared base
+(template)
+"""
+lvs = lvm.lvsByTag(sdUUID, "%s%s" % (TAG_PREFIX_IMAGE, imgUUID))
+return [lv.name for lv in lvs]
+
 
 class BlockVolume(volume.Volume):
 """ Actually represents a single volume (i.e. part of virtual disk).
@@ -287,7 +344,7 @@
 return self._md.metaoff
 
 def refreshVolume(self):
-lvm.refreshLVs(self.sdUUID, (self.volUUID,))
+self._md.refreshVolume()
 
 @classmethod
 def halfbakedVolumeRollback(cls, taskObj, sdUUID, volUUID, volPath):
@@ -434,7 +491,7 @@
 self.recheckIfLeaf()
 
 if not force:
-self.validateDelete()
+self._md.validateDelete()
 
 # Mark volume as illegal before deleting
 self.setLegality(volume.ILLEGAL_VOL)
@@ -577,15 +634,6 @@
 def getDevPath(self):
 return self._md.getDevPath()
 
-def _share(self, dstImgPath):
-"""
-Share this volume to dstImgPath
-"""
-dstPath = os.path.join(dstImgPath, self.volUUID)
-
-self.log.debug("Share volume %s to %s", self.volUUID, dstImgPath)
-os.symlink(self._md.getDevPath(), dstPath)
-
 @classmethod
 def shareVolumeRollback(cls, taskObj, volPath):
 cls.log.info("Volume rollback for volPath=%s", volPath)
@@ -654,54 +702,10 @@
 
 @classmethod
 def getImageVolumes(cls, repoPath, sdUUID, imgUUID):
-"""
-Fetch the list of the Volumes UUIDs, not including the shared base
-(template)
-"""
-lvs = lvm.lvsByTag(sdUUID, "%s%s" % (TAG_PREFIX_IMAGE, imgUUID))
-return [lv.name for lv in lvs]
-
-def removeMetadata(self, metaId):
-"""
-Just wipe meta.
-"""
-try:
-self._putMetadata(metaId, {"NONE": "#" * (sd.METASIZE - 10)})
-except Exception as e:
-self.log.error(e, exc_info=True)
-   

Change in vdsm[master]: sdm: Add create_volume job

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches