Change in vdsm[master]: net: SetupNetworks small cleanups

[ibarkan]

Ido Barkan has abandoned this change.

Change subject: net: SetupNetworks small cleanups
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/42022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib054e144dccbff40b40b5967dca0bf840bce8ab9
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: SetupNetworks small cleanups

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: SetupNetworks small cleanups
..


Patch Set 27:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib054e144dccbff40b40b5967dca0bf840bce8ab9
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: rename _set/drop/remove_ip_config functions

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: rename _set/drop/remove_ip_config functions
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0489b7679577e2e038d46f025db75168986f3a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: drop initial bonds' slaves IP config
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Align RHEL and CentOS qemu* requiments

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Align RHEL and CentOS qemu* requiments
..


Patch Set 1:

* #1248400::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1248400::OK, public bug
* Check Product::#1248400::OK, Correct classification oVirt
* Check TM::#1248400::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb1035641fd03ecd3c7b38f398a2b7679f4801
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: service: change vdsm KillMode to mixed

[oourfali]

Oved Ourfali has posted comments on this change.

Change subject: service: change vdsm KillMode to mixed
..


Patch Set 6:

Douglas - can you elaborate?

-- 
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add documentation for setupNetworks rollback mechanism.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: add documentation for setupNetworks rollback mechanism.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7d66f9612ed6762fa80e7aa9e57d914dd65f34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Align RHEL and CentOS qemu* requiments

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Align RHEL and CentOS qemu* requiments
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb1035641fd03ecd3c7b38f398a2b7679f4801
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Align RHEL and CentOS qemu* requiments

[amureini]

Hello Nir Soffer, Sandro Bonazzola,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/50368

to review the following change.

Change subject: spec: Align RHEL and CentOS qemu* requiments
..

spec: Align RHEL and CentOS qemu* requiments

Since qemu-kvm-ev-2.3 is now build by the oVirt project, there's no
reason to keep the cumbersome separation between RHEL and CentOS
requirements.

Change-Id: I4bfb1035641fd03ecd3c7b38f398a2b7679f4801
Bug-Url: https://bugzilla.redhat.com/1248400
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/49974
Reviewed-by: Sandro Bonazzola 
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/50368/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index da359e2..affec8c 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -238,14 +238,8 @@
 %endif
 
 %if 0%{?rhel}
-%if 0%{?centos}
-# TODO: Remove when qemu-kvm-rhev 2.3.0-13 is available
-Requires: qemu-kvm-rhev >= 10:2.1.2-23.el7_1.2
-Requires: qemu-img-rhev >= 10:2.1.2-23.el7_1.2
-%else
 Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7
 Requires: qemu-img-rhev >= 10:2.3.0-13.el7
-%endif # centos
 %else
 Requires: qemu-kvm >= 2:2.1.3-11
 Requires: qemu-img >= 2:2.1.3-11


-- 
To view, visit https://gerrit.ovirt.org/50368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bfb1035641fd03ecd3c7b38f398a2b7679f4801
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add try/except to get_external_vms

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: add create_volume_container API stub

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: add create_volume_container API stub
..


Patch Set 3:

(1 comment)

Partial review

https://gerrit.ovirt.org/#/c/50220/3/client/vdsClient.py
File client/vdsClient.py:

Line 2508: '- disk_type: The type of disk (SYSTEM, DATA, 
SHARED, ..)',
Line 2509: '- description:   The volume description',
Line 2510: '- parent_img_id: Optional image UUID of the parent 
volume',
Line 2511: '- parent_vol_id: Optional volume UUID of the parent 
volume',
Line 2512: '- initial_size:  Optional requested initial 
allocated size '
requested -> desired, the semantics are similar, better name.

Lets also use this term in the schema.

Would it be nice if this help would be generated by the schema on the fly? (do 
not try this now).
Line 2513: '(in bytes)'
Line 2514: )),
Line 2515: 'extendVolumeSize': (serv.extendVolumeSize, (
Line 2516: '',


-- 
To view, visit https://gerrit.ovirt.org/50220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Only report progress if set

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Only report progress if set
..


Patch Set 2: Code-Review-1

(2 comments)

We do not need the _progress instance variable.

https://gerrit.ovirt.org/#/c/50355/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 66: def __init__(self, job_id, description=''):
Line 67: self._id = job_id
Line 68: self._status = STATUS.RUNNING
Line 69: self._description = description
Line 70: self._progress = None
v2v jobs have more complicated progress:

 393 @property
 394 def progress(self):
 395 '''
 396 progress is part of multiple disk_progress its
 397 flat and not 100% accurate - each disk take its
 398 portion ie if we have 2 disks the first will take
 399 0-50 and the second 50-100
 400 '''
 401 completed = (self._disk_count - 1) * 100
 402 return (completed + self._disk_progress) / self._disk_count

So basing progress on an instance variable is not a good idea.

We should keep the concept of having to override progress, but the logic should 
be that job.progress should be None when you cannot report progress.

For example, job copying image will return while it is blocked, taking locks 
and validating the operation, and once qemu-img has started, it will start to 
return progress value.

So in copy image we would do something like this:

@property
def progress(self):
if self._convert_operation:
return self._convert_operation.progress
return None

So Job should have no _progress instance variable.
Line 71: self._error = None
Line 72: 
Line 73: @property
Line 74: def id(self):


Line 83: return self._description
Line 84: 
Line 85: @property
Line 86: def progress(self):
Line 87: return self._progress
Return None, so code which does not override this will get no progress. v2v 
ImportVm overrides this so it is a safe change.
Line 88: 
Line 89: @property
Line 90: def job_type(self):
Line 91: return self._JOB_TYPE


-- 
To view, visit https://gerrit.ovirt.org/50355
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce VolumeArtifacts

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Introduce VolumeArtifacts
..


Patch Set 8: Code-Review-1

(2 comments)

Partial review, looks good.

https://gerrit.ovirt.org/#/c/48097/8/vdsm/storage/sdm/volume_artifacts.py
File vdsm/storage/sdm/volume_artifacts.py:

Line 152: self.log.debug("Creating path for new image: %s", 
artifacts_path)
Line 153: try:
Line 154: self._oop.os.mkdir(artifacts_path)
Line 155: except OSError as e:
Line 156: if e.errno == errno.EEXIST:
Lets always reject the error we cannot handle first, and then handle what we 
can (fail fast).

   if e.errno != errno.EEXIST:
   raise

# Handle EEXIST...
Line 157: # We have existing artifacts in the way.  Time to run
Line 158: # garbage collection
Line 159: self.log.error("Cannot create new image %s, garbage 
found "
Line 160:"at %s.", self.img_id, artifacts_path)


Line 162: raise
Line 163: 
Line 164: 
Line 165: class BlockVolumeArtifacts(VolumeArtifacts):
Line 166: pass
Lets wait with this to the next iteration.


-- 
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagefakelib: Add FakeResourceManager
..


Patch Set 2: Code-Review-1

(4 comments)

Partial review, looks good

https://gerrit.ovirt.org/#/c/50340/2/tests/storagefakelib.py
File tests/storagefakelib.py:

Line 220: 
Line 221: 
Line 222: class FakeResourceManager(object):
Line 223: def __init__(self):
Line 224: self.__calls__ = []
If we @record both method, we can eliminate init.
Line 225: 
Line 226: @contextmanager
Line 227: def acquireResource(self, *args, **kwargs):
Line 228: try:


Line 222: class FakeResourceManager(object):
Line 223: def __init__(self):
Line 224: self.__calls__ = []
Line 225: 
Line 226: @contextmanager
Try to @record this.
Line 227: def acquireResource(self, *args, **kwargs):
Line 228: try:
Line 229: self.__calls__.append(('acquireResource', args, kwargs))
Line 230: yield


Line 225: 
Line 226: @contextmanager
Line 227: def acquireResource(self, *args, **kwargs):
Line 228: try:
Line 229: self.__calls__.append(('acquireResource', args, kwargs))
If @recording works - this is unneeded.
Line 230: yield
Line 231: finally:
Line 232: self.releaseResource(*args, **kwargs)
Line 233: 


Line 229: self.__calls__.append(('acquireResource', args, kwargs))
Line 230: yield
Line 231: finally:
Line 232: self.releaseResource(*args, **kwargs)
Line 233: 
This can be @recorded
Line 234: def releaseResource(self, *args, **kwargs):


-- 
To view, visit https://gerrit.ovirt.org/50340
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0302b48d984ce7eb8ce2326ab4bb033430c032f9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Only report progress if set

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Only report progress if set
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50355
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 3: Code-Review-1

(15 comments)

Partial review, I like this very much.

https://gerrit.ovirt.org/#/c/50221/3/tests/sdm_create_volume_test.py
File tests/sdm_create_volume_test.py:

Line 38: 
Line 39: class FakeDomainManifest(object):
Line 40: def __init__(self, sd_id):
Line 41: self.sdUUID = sd_id
Line 42: 
We can@record this an verify that a job verified the arguments.

Lets also check the case when this raises.
Line 43: def validateCreateVolumeParams(self, *args):
Line 44: pass
Line 45: 
Line 46: @recorded


Line 73: self.vol_id = vol_id
Line 74: 
Line 75: # TODO: record these calls and verify them in the tests.
Line 76: 
Line 77: def create(self, *args):
Lets test that we deal correctly with failures here (locks released, error 
reported)
Line 78: pass
Line 79: 
Line 80: def commit(self):
Line 81: pass


Line 76: 
Line 77: def create(self, *args):
Line 78: pass
Line 79: 
Line 80: def commit(self):
Same
Line 81: pass
Line 82: 
Line 83: 
Line 84: class CreateVolumeTests(VdsmTestCase):


Line 82: 
Line 83: 
Line 84: class CreateVolumeTests(VdsmTestCase):
Line 85: 
Line 86: def _get_args(self):
Better call this setUp, and set the needed test state in self.
Line 87: job_id = str(uuid.uuid4())
Line 88: host_id = 1
Line 89: dom_manifest = FakeDomainManifest(str(uuid.uuid4()))
Line 90: vol_info = dict(img_id=str(uuid.uuid4()), 
vol_id=str(uuid.uuid4()),


Line 101: self.rm)]):
Line 102: yield
Line 103: 
Line 104: def test_create_volume(self):
Line 105: args = self._get_args()
You are re-inventing setUp()
Line 106: job = storage.sdm.api.create_volume.Job(**args)
Line 107: 
Line 108: with self._fake_env():
Line 109: job.run()


Line 127: def test_create_volume_domainlock_contended(self):
Line 128: def error(*args):
Line 129: raise se.AcquireLockFailure('id', 'rc', 'out', 'err')
Line 130: 
Line 131: args = self._get_args()
You are re-inventing setUp()
Line 132: args['dom_manifest'].acquireDomainLock = error
Line 133: job = storage.sdm.api.create_volume.Job(**args)
Line 134: job.run()
Line 135: wait_for_job(job)


https://gerrit.ovirt.org/#/c/50221/3/vdsm/storage/sdm/api/__init__.py
File vdsm/storage/sdm/api/__init__.py:

Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: __all__ = [
Please avoid this, we don't want code that does "from sdm import *", adding 20 
names to the global namespace.
Line 22: 'create_volume',


https://gerrit.ovirt.org/#/c/50221/3/vdsm/storage/sdm/api/create_volume.py
File vdsm/storage/sdm/api/create_volume.py:

Line 28: 
Line 29: rmanager = rm.ResourceManager.getInstance()
Line 30: 
Line 31: 
Line 32: class Job(sdm_job.SdmJob):
Please keep empty line after between class and __init__.
Line 33: def __init__(self, job_id, host_id, dom_manifest, vol_info):
Line 34: super(Job, self).__init__(job_id, 'create_volume', host_id)
Line 35: self.dom_manifest = dom_manifest
Line 36: self.vol_info = _CreateVolumeInfo(vol_info)


Line 36: self.vol_info = _CreateVolumeInfo(vol_info)
Line 37: 
Line 38: def _run(self):
Line 39: self.dom_manifest.validateCreateVolumeParams(
Line 40: self.vol_info.vol_format, self.vol_info.parent_vol_id)
Since we validate vol_info in __init__, we should also validate these 
parameters in __init__. I would copy the logic from dom_manifest into 
CreateVolumeInfo, so we don't have to depend on this class method, or if you 
want to avoid the duplication, send the manifest to  CreateVolumeInfo.__init__.
Line 41: 
Line 42: with self.dom_manifest.domain_lock(self.host_id):
Line 43: image_res_ns = sd.getNamespace(self.dom_manifest.sdUUID,
Line 44:IMAGE_NAMESPACE)


Line 50:  self.vol_info.vol_id)
Line 51: artifacts.create(
Line 52: self.vol_info.size, self.vol_info.vol_format,
Line 53: self.vol_info.disk_type, self.vol_info.desc,
Line 54: self.vol_info.parent_vol_id)
Wny not pass vol_info to artifacts.create?
Line 55: artifacts.commit()
Line 56: 
Line 57: # TODO: Adopt the properties framework for managing complex verb 
parameters
Line 58: 


Line 56: 
Line 57: # TODO: Adopt the properties framework for managing complex verb 
parameters
Line 58: 
Line 59: 
Line 60: class _CreateVolumeInfo(object):
We don't need to keep this private. In the future, it would be nice if the 
bridge creates this class (based on the type name in 

Change in vdsm[master]: jobs: Add error property

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Add error property
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f6e27bcd69db1673e5168524b0ce94f2e9e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

[ahino]

Ala Hino has uploaded a new change for review.

Change subject: gluster: Warn about missing glusterfs-cli package
..

gluster: Warn about missing glusterfs-cli package

In 3.6 we introduced a dependency to glusterfs-cli. This is required in
order to get gluster volume info needed to get gluster backup servers
and replica related logic. Howevre, we found tht during upgrade, if
glusterfs-cli is not installed, there is a not-completely clear
exception in the log file. In this case, we'd like to add a warning
message in the log clearly indicating missing glustefs-cli package.

Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Signed-off-by: Ala Hino 
https://bugzilla.redhat.com/1290997
---
M vdsm/storage/storageServer.py
1 file changed, 11 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/50363/1

diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index d30902f..2e538b4 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -43,6 +43,7 @@
 import iscsi
 from sync import asyncmethod, AsyncCallStub
 from mount import MountError
+from gluster import exception as ge
 import storage_exception as se
 
 
@@ -356,9 +357,16 @@
 return "backup-volfile-servers=" + ":".join(servers)
 
 def _get_gluster_volinfo(self):
-volinfo = supervdsm.getProxy().glusterVolumeInfo(self._volname,
- self._volfileserver)
-return volinfo[self._volname]
+try:
+sVdsmProxy = supervdsm.getProxy()
+volinfo = sVdsmProxy.glusterVolumeInfo(self._volname,
+   self._volfileserver)
+return volinfo[self._volname]
+except ge.GlusterCmdExecFailedException:
+self.log.warning("Required glusterfs-cli package is missing on "
+ "this host. Please install the package to work "
+ "with gluster storage")
+raise
 
 
 class NFSConnection(object):


-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Warn about missing glusterfs-cli package
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Warn about missing glusterfs-cli package
..


Patch Set 2:

* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Check Product::#1290997::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: gluster: Warn about missing glusterfs-cli package
..


Patch Set 2: Continuous-Integration-1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Warn about missing glusterfs-cli package
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50363/2/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 361: sVdsmProxy = supervdsm.getProxy()
Line 362: volinfo = sVdsmProxy.glusterVolumeInfo(self._volname,
Line 363:
self._volfileserver)
Line 364: return volinfo[self._volname]
Line 365: except ge.GlusterCmdExecFailedException:
> This is not correct, this error can be a failure of the gluster command lin
The simplest and cross platform way to check is to use _glusterCommandPath from 
vdsm/gluster/cli.py and check if the gluster tool exists.

I would add something like cli.gluster_exists(), if the command does not
exists, we can warn about it.

Or, change the gluster verbs to raise specific error when gluster tool
is not installed, instead of the useless  ge.GlusterCmdExecFailedException.
Line 366: self.log.warning("Required glusterfs-cli package is 
missing on "
Line 367:  "this host. Please install the package 
to work "
Line 368:  "with gluster storage")
Line 369: raise


-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

[automation]

gerrit-hooks has posted comments on this change.

Change subject: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50109
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5e797335d73af50e6ac4c8e1542adc4b6e4f07f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Warn about missing glusterfs-cli package
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50363/2/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 361: sVdsmProxy = supervdsm.getProxy()
Line 362: volinfo = sVdsmProxy.glusterVolumeInfo(self._volname,
Line 363:
self._volfileserver)
Line 364: return volinfo[self._volname]
Line 365: except ge.GlusterCmdExecFailedException:
This is not correct, this error can be a failure of the gluster command line 
tool.

The correct check is to check if gluster command line tool exists, or the 
glusterfs-cli package exists (check need to be cross platform).


But these warning starts to be too much. The real fix is to require the package 
when it is available (X68_64).
Line 366: self.log.warning("Required glusterfs-cli package is 
missing on "
Line 367:  "this host. Please install the package 
to work "
Line 368:  "with gluster storage")
Line 369: raise


-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Warn about missing glusterfs-cli package

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Warn about missing glusterfs-cli package
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50363/2/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 361: sVdsmProxy = supervdsm.getProxy()
Line 362: volinfo = sVdsmProxy.glusterVolumeInfo(self._volname,
Line 363:
self._volfileserver)
Line 364: return volinfo[self._volname]
Line 365: except ge.GlusterCmdExecFailedException:
> The simplest and cross platform way to check is to use _glusterCommandPath 
GlusterCmdExecFailedException has rc, out, and err attributes - please print 
them when the command fails, maybe we can detect the interesting failure using 
these.
Line 366: self.log.warning("Required glusterfs-cli package is 
missing on "
Line 367:  "this host. Please install the package 
to work "
Line 368:  "with gluster storage")
Line 369: raise


-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fc-scan: Use utilities from vdsm library.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fc-scan: Use utilities from vdsm library.
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/38466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48748d6a43d41e034e16cb4f636ebe627881590
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Cleanup waiting for xml update

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: vm: Cleanup waiting for xml update
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9fec5416a62736bad461ddd0b54093d23960b7a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fc-scan: Use utilities from vdsm library.

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: fc-scan: Use utilities from vdsm library.
..


Patch Set 4:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/38466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48748d6a43d41e034e16cb4f636ebe627881590
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Cleanup waiting for xml update

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Cleanup waiting for xml update
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/39938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fec5416a62736bad461ddd0b54093d23960b7a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net ifcfg.flush: log flushed files content

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: net ifcfg.flush: log flushed files content
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39285
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie0b46946474f639114f482864650e54002034d1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net ifcfg.flush: log flushed files content

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: net ifcfg.flush: log flushed files content
..


Patch Set 1:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39285
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b46946474f639114f482864650e54002034d1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: net: getXML: supply alias when known

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: virt: net: getXML: supply alias when known
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/38880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I01a881144514ad8abbd0b1d3e4e2bc877b0e88c9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: net: getXML: supply alias when known

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: net: getXML: supply alias when known
..


Patch Set 4:

* #1200418::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/38880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a881144514ad8abbd0b1d3e4e2bc877b0e88c9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: devices: move and rename getUnderlyingDeviceAddress

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: devices: move and rename getUnderlyingDeviceAddress
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/38714
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I45fefb65461bcf97f75d607c55097eb5db2ed2ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: Revert and refine error handling in tmap()

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: lib: Revert and refine error handling in tmap()
..


Patch Set 1:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0154b28ff7822c63e77181bbbf444c712bd0c31e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: HACK: Add a function to execute a qemu monitor command

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: HACK: Add a function to execute a qemu monitor command
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/27950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3e9e07ba0c236c0938b129ae90af825f18f0e644
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: Revert and refine error handling in tmap()

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: lib: Revert and refine error handling in tmap()
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0154b28ff7822c63e77181bbbf444c712bd0c31e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fc-scan: Use utilities from vdsm library.

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: fc-scan: Use utilities from vdsm library.
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/38466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic48748d6a43d41e034e16cb4f636ebe627881590
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: Revert and refine error handling in tmap()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: Revert and refine error handling in tmap()
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/39211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0154b28ff7822c63e77181bbbf444c712bd0c31e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for scsi devices

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: hostdev: add support for scsi devices
..


Patch Set 2:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: SDM: Add removeImage API

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: SDM: Add removeImage API
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3fcbfd4ac6ec903b5552edb053f2291da532f0db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tmp3:

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: tmp3:
..


Patch Set 1:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib341000b62d3306fa3589c25eac22bff78472869
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for scsi devices

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: hostdev: add support for scsi devices
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: HACK: Add a function to execute a qemu monitor command

[automation]

gerrit-hooks has posted comments on this change.

Change subject: HACK: Add a function to execute a qemu monitor command
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/27950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e9e07ba0c236c0938b129ae90af825f18f0e644
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tmp

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: tmp
..


Patch Set 1:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47c816e9d453dca595fc7abb4a84b301c34fc624
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Cleanup waiting for xml update

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: vm: Cleanup waiting for xml update
..


Patch Set 1:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fec5416a62736bad461ddd0b54093d23960b7a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tmp5

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: tmp5
..


Patch Set 1:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28acedfa77764393829a66b8985996bc6dd68d17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: SDM: Add removeImage API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: SDM: Add removeImage API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/39897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3fcbfd4ac6ec903b5552edb053f2291da532f0db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: SDM: Add removeImage API

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: SDM: Add removeImage API
..


Patch Set 1:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/39897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3fcbfd4ac6ec903b5552edb053f2291da532f0db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: HACK: Add a function to execute a qemu monitor command

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: HACK: Add a function to execute a qemu monitor command
..


Patch Set 4:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/27950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e9e07ba0c236c0938b129ae90af825f18f0e644
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: devices: move and rename getUnderlyingDeviceAddress

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: devices: move and rename getUnderlyingDeviceAddress
..


Patch Set 2:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/38714
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45fefb65461bcf97f75d607c55097eb5db2ed2ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: net: getXML: supply alias when known

[Jenkins CI RO]

Jenkins CI RO has posted comments on this change.

Change subject: virt: net: getXML: supply alias when known
..


Patch Set 4:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/38880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a881144514ad8abbd0b1d3e4e2bc877b0e88c9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: devices: move and rename getUnderlyingDeviceAddress

[automation]

gerrit-hooks has posted comments on this change.

Change subject: devices: move and rename getUnderlyingDeviceAddress
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/38714
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45fefb65461bcf97f75d607c55097eb5db2ed2ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net ifcfg.flush: log flushed files content

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net ifcfg.flush: log flushed files content
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/39285
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b46946474f639114f482864650e54002034d1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for scsi devices

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: add support for scsi devices
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/39809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move getVolumeSize and getVolumeTrueSize

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move getVolumeSize and getVolumeTrueSize
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..


Patch Set 23:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c1fa58d64efbb3cbc7eea84189fc8375b6fa3d
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move getVolumeSize and getVolumeTrueSize

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: move getVolumeSize and getVolumeTrueSize
..


Patch Set 24:

This version:
- Remove FileVolume methods moved up to Volume
- Add the missing indirection tests

-- 
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..


Patch Set 23: Code-Review-1

(2 comments)

- Missing indirection tests
- Missing redirections

https://gerrit.ovirt.org/#/c/41999/23/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 
Line 1112
Line 1113
Line 1114
Line 1115
Redirect to self._md?


Line 1200
Line 1201
Line 1202
Line 1203
Line 1204
Redirect to self._md - called when preparing a image for a vm


-- 
To view, visit https://gerrit.ovirt.org/41999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c1fa58d64efbb3cbc7eea84189fc8375b6fa3d
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move getVolumeSize and getVolumeTrueSize

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: move getVolumeSize and getVolumeTrueSize
..


Patch Set 24:

Please review again

-- 
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie122d4c96ad81d31c0e783e8651a99328722f8ed
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches