Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 14: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix alignment issue for brick creation on JBOD

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 7: Code-Review+1

If Sahina is ok with this, I can merge it.

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - adding appropriate logs

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: snapshot - adding appropriate logs
..


Patch Set 1:

(7 comments)

The logs are not appropriate :-)

https://gerrit.ovirt.org/#/c/50775/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3243
Line 3244
Line 3245
Line 3246
Line 3247
freeze() has its own info log, so we don't want to log about the snapshot 
before that log.


Line 3244
Line 3245
Line 3246
Line 3247
Line 3248
log.info message about the snapshot, drives and memory here.

I think something like:

Taking snapshot with drives 'vda', 'vdb' (memory=True)


Line 3245
Line 3246
Line 3247
Line 3248
Line 3249
log.info message here when snapshot is complete.


Line 3131: padToBlockSize(memoryVolPath)
Line 3132: else:
Line 3133: fileUtils.padToBlockSize(memoryVolPath)
Line 3134: 
Line 3135: self.log.info("Taking a live snapshot on VM %s.", 
self.conf['vmId'])
We already have a log about taking a snapshot in jsonrpc bridge, so we don't 
need another log here.

There is no need to include the vm id, it is already prefixed to the message 
(vmid=`xxxyyy`::message)
Line 3136: 
Line 3137: snap = vmxml.Element('domainsnapshot')
Line 3138: disks = vmxml.Element('disks')
Line 3139: newDrives = {}


Line 3183: vmDrives[vmDevName] = vmDrive
Line 3184: 
Line 3185: if len(newDrives) == 0:
Line 3186: self.log.info("Include no disks in live snapshot on VM 
%s.",
Line 3187:   self.conf['vmId'])
Instead of this, lets log the drives we take a snapshot with later.
Line 3188: 
Line 3189: preparedDrives = {}
Line 3190: 
Line 3191: for vmDevName, vmDevice in newDrives.iteritems():


Line 3212: snapFlags = (libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT |
Line 3213:  libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA)
Line 3214: 
Line 3215: if memoryParams:
Line 3216: self.log.info("Include memory in live snapshot on VM 
%s.",
Lets log this in the single log before taking a snapshot.
Line 3217:   self.conf['vmId'])
Line 3218: # Save the needed vm configuration
Line 3219: # TODO: this, as other places that use pickle.dump
Line 3220: # directly to files, should be done with outOfProcess


Line 3286: self.startDisksStatsCollection()
Line 3287: if memoryParams:
Line 3288: self.cif.teardownVolumePath(memoryVol)
Line 3289: 
Line 3290: self.log.info("Completed live snapshot on VM %s.", 
self.conf['vmId'])
Move this when snapshot is finished, before calling thaw(), again, to avoid 
thaw info log mixed with snapshot log.

Also we have a completion log in the json bridge, so there is not need to log 
anything here.
Line 3291: 
Line 3292: # Returning quiesce to notify the manager whether the guest 
agent
Line 3293: # froze and flushed the filesystems or not.
Line 3294: quiesce = should_freeze and freezed["status"]["code"] == 0


-- 
To view, visit https://gerrit.ovirt.org/50775
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: create bricks without MBR partitions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1: Code-Review+1

Waiting for Sahina ack.

-- 
To view, visit https://gerrit.ovirt.org/50769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix size conversion issues in brick create

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 6: Code-Review-1

(5 comments)

https://gerrit.ovirt.org/#/c/50705/6/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 65: 
Line 66: # This method helps to convert the size to given Unittype.
Line 67: # This is required to since there a incompatible change in blivet API
Line 68: # size.convertTo where older versions required string param but newer 
versions
Line 69: # requires the constants in blivet.size.KiB.
blivet.size.KiB -> blivet.size.
Line 70: def _getDeviceSize(device, unitType='MiB'):
Line 71: if hasattr(blivet.size, 'MiB'):
Line 72: if unitType == 'KiB':
Line 73: return device.size.convertTo(blivet.size.KiB)


Line 66: # This method helps to convert the size to given Unittype.
Line 67: # This is required to since there a incompatible change in blivet API
Line 68: # size.convertTo where older versions required string param but newer 
versions
Line 69: # requires the constants in blivet.size.KiB.
Line 70: def _getDeviceSize(device, unitType='MiB'):
Add a note that this part is for the new blivet version.
Line 71: if hasattr(blivet.size, 'MiB'):
Line 72: if unitType == 'KiB':
Line 73: return device.size.convertTo(blivet.size.KiB)
Line 74: elif unitType == 'MiB':


Line 71: if hasattr(blivet.size, 'MiB'):
Line 72: if unitType == 'KiB':
Line 73: return device.size.convertTo(blivet.size.KiB)
Line 74: elif unitType == 'MiB':
Line 75: return device.size.convertTo(blivet.size.MiB)
This should raise, the caller provided unitType we don't know how to handle.
Line 76: else:
Line 77: return device.size.convertTo(spec=unitType)
Line 78: return 0
Line 79: 


Line 72: if unitType == 'KiB':
Line 73: return device.size.convertTo(blivet.size.KiB)
Line 74: elif unitType == 'MiB':
Line 75: return device.size.convertTo(blivet.size.MiB)
Line 76: else:
Add a note that this is for old blivet version supporting spec string.
Line 77: return device.size.convertTo(spec=unitType)
Line 78: return 0
Line 79: 
Line 80: 


Line 74: elif unitType == 'MiB':
Line 75: return device.size.convertTo(blivet.size.MiB)
Line 76: else:
Line 77: return device.size.convertTo(spec=unitType)
Line 78: return 0
Not needed, and a bad way to fail, now all the callers have to check for 0, or 
we will fail much later when someone try to use the invalid size, making 
debugging much harder.

I suggest to do this:

if hasattr(blivet.size, 'MiB'):
# New blivet requires size constants (e.g, size.MiB, size.KiB)
unit = getattr(blivet.size, unitType)
return device.size.convertTo(unit)
else:
   # Old blivet using spec string
   return device.size.convertTo(spec=unitType)

This will raise AttributeError if you call with invalid unitType, which should 
make this easy to debug.
Line 79: 
Line 80: 
Line 81: def _getDeviceDict(device, createBrick=False):
Line 82: info = {'name': device.name,


-- 
To view, visit https://gerrit.ovirt.org/50705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: create bricks without MBR partitions

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster add mount options for gluster brick.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 1: Code-Review+1

Waiting for Sahina ack

-- 
To view, visit https://gerrit.ovirt.org/50770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Added Python 3 support for sslTests.py

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Added Python 3 support for sslTests.py
..


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/50760/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 50: import stat
Line 51: import string
Line 52: import threading
Line 53: import time
Line 54: from six.moves import StringIO
for that we need to change AsyncProc to use StringIO probably or rewrite it as 
I started in https://gerrit.ovirt.org/#/c/49441/
Line 55: import vdsm.infra.zombiereaper as zombiereaper
Line 56: 
Line 57: try:
Line 58: from cpopen import CPopen as Popen


Line 647: 
Line 648: execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd))
Line 649: 
Line 650: p = Popen(command, close_fds=True, cwd=cwd, env=env,
Line 651:deathSignal=deathSignal, childUmask=childUmask)
rebase.. childUmask was removed. deathSignal still exists so it will fail in 
python3. we need first to have https://gerrit.ovirt.org/48121
Line 652: if not sync:
Line 653: p = AsyncProc(p)
Line 654: if data is not None:
Line 655: p.stdin.write(data)


https://gerrit.ovirt.org/#/c/50760/1/tests/integration/sslhelper.py
File tests/integration/sslhelper.py:

Line 7: # Refer to the README and COPYING files for full details of the license
Line 8: #
Line 9: import os
Line 10: import ssl
Line 11: import six
redundant
Line 12: from six.moves import xmlrpc_server as SimpleXMLRPCServer
Line 13: import threading
Line 14: from vdsm.sslutils import SSLContext
Line 15: 


-- 
To view, visit https://gerrit.ovirt.org/50760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd7ee76d814d1661f5bd98ea37b6707d2f6f7fd1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Benjamin Kemper 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix size conversion issues in brick create

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 6:

(5 comments)

Thanks for your suggestions Nir. I will fix them in the next patch set.

https://gerrit.ovirt.org/#/c/50705/6/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 65: 
Line 66: # This method helps to convert the size to given Unittype.
Line 67: # This is required to since there a incompatible change in blivet API
Line 68: # size.convertTo where older versions required string param but newer 
versions
Line 69: # requires the constants in blivet.size.KiB.
> blivet.size.KiB -> blivet.size.
Done
Line 70: def _getDeviceSize(device, unitType='MiB'):
Line 71: if hasattr(blivet.size, 'MiB'):
Line 72: if unitType == 'KiB':
Line 73: return device.size.convertTo(blivet.size.KiB)


Line 66: # This method helps to convert the size to given Unittype.
Line 67: # This is required to since there a incompatible change in blivet API
Line 68: # size.convertTo where older versions required string param but newer 
versions
Line 69: # requires the constants in blivet.size.KiB.
Line 70: def _getDeviceSize(device, unitType='MiB'):
> Add a note that this part is for the new blivet version.
Done
Line 71: if hasattr(blivet.size, 'MiB'):
Line 72: if unitType == 'KiB':
Line 73: return device.size.convertTo(blivet.size.KiB)
Line 74: elif unitType == 'MiB':


Line 71: if hasattr(blivet.size, 'MiB'):
Line 72: if unitType == 'KiB':
Line 73: return device.size.convertTo(blivet.size.KiB)
Line 74: elif unitType == 'MiB':
Line 75: return device.size.convertTo(blivet.size.MiB)
> This should raise, the caller provided unitType we don't know how to handle
Done
Line 76: else:
Line 77: return device.size.convertTo(spec=unitType)
Line 78: return 0
Line 79: 


Line 72: if unitType == 'KiB':
Line 73: return device.size.convertTo(blivet.size.KiB)
Line 74: elif unitType == 'MiB':
Line 75: return device.size.convertTo(blivet.size.MiB)
Line 76: else:
> Add a note that this is for old blivet version supporting spec string.
Done
Line 77: return device.size.convertTo(spec=unitType)
Line 78: return 0
Line 79: 
Line 80: 


Line 74: elif unitType == 'MiB':
Line 75: return device.size.convertTo(blivet.size.MiB)
Line 76: else:
Line 77: return device.size.convertTo(spec=unitType)
Line 78: return 0
> Not needed, and a bad way to fail, now all the callers have to check for 0,
Done
Line 79: 
Line 80: 
Line 81: def _getDeviceDict(device, createBrick=False):
Line 82: info = {'name': device.name,


-- 
To view, visit https://gerrit.ovirt.org/50705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix alignment issue for brick creation on JBOD

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 7: Code-Review+1

Nir, could you merge?

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: spec: Require newer qemu version for el7
..


spec: Require newer qemu version for el7

Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential assertion error after lvextend caused by a memory
corruption in the block sub-system.

For more details:
* https://bugzilla.redhat.com/show_bug.cgi?id=1277922
* http://marc.info/?l=qemu-devel=144740716414450=2

Bug-Url: https://bugzilla.redhat.com/1279052
Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Signed-off-by: Daniel Erez 
Reviewed-on: https://gerrit.ovirt.org/50435
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
Reviewed-by: Sandro Bonazzola 
Reviewed-on: https://gerrit.ovirt.org/50766
Reviewed-by: Yaniv Bronhaim 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Daniel Erez: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2:

* #1279052::Update tracker: OK
* Set MODIFIED::bug 1279052#1279052IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/50766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster add mount options for gluster brick.

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Mapping bonding option value names to numerics
..


net: Mapping bonding option value names to numerics

Several bonding options have values that may be inputted
either by name or by their numeric equivalent.
When read, for comparing the actual settings with the
requested configuration, only one format should be used.

This change creates a map, outputted to a JSON file.
[bonding-name2numeric.json]

Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/49390
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan 
Reviewed-by: Dan Kenigsberg 
---
M debian/vdsm-python.install
M init/vdsmd_init_common.sh.in
M lib/vdsm/netinfo/bonding.py
M lib/vdsm/tool/Makefile.am
D lib/vdsm/tool/dump_bonding_defaults.py
A lib/vdsm/tool/dump_bonding_opts.py
M tests/Makefile.am
M tests/netinfoTests.py
A tests/toolBondingTests.py
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/bonding-name2numeric.json
12 files changed, 461 insertions(+), 83 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 27:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 26: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster add mount options for gluster brick.

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: gluster add mount options for gluster brick.
..


gluster add mount options for gluster brick.

 Mount options "inode64,noatime" should be used to
mount the gluster brick to improve the performance.

Bug-Url: https://bugzilla.redhat.com/1270792
Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Signed-off-by: Ramesh Nachimuthu 
Reviewed-on: https://gerrit.ovirt.org/50770
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M vdsm/gluster/storagedev.py
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Sahina Bose: Looks good to me, but someone else must approve
  Ramesh N: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster add mount options for gluster brick.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 2:

* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/50770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster add mount options for gluster brick.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 1: Code-Review+2 Continuous-Integration+1

CI failure is not relevant, we don't have any tests for this code.

-- 
To view, visit https://gerrit.ovirt.org/50770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vdsm standard CI arrangement

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Vdsm standard CI arrangement
..


Patch Set 37:

(1 comment)

https://gerrit.ovirt.org/#/c/48268/37/automation/check-merged.sh
File automation/check-merged.sh:

Line 7: $TEST_PATH/sosPluginTests.py \
Line 8: $TEST_PATH/vmRecoveryTests.py \
Line 9: $TEST_PATH/vmQoSTests.py \
Line 10: $TEST_PATH/virtTests.py \
Line 11: $TEST_PATH/storageTests.py \
Please don't run the storage tests, they are not useful to anyone and extremely 
slow. We don't have time to debug issues when running them in ci.

I suggest to apply the same rule should apply to other tests. Test owners 
should add them to the list only when the tests are stable.
Line 12: $TEST_PATH/networkTests.py \
Line 13: $TEST_PATH/networkTestsOVS.py \
Line 14: $TEST_PATH/momTests.py \
Line 15: $TEST_PATH/supervdsmFuncTests.py"


-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 37
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: spec: Require newer qemu version for el7
..


spec: Require newer qemu version for el7

Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential assertion error after lvextend caused by a memory
corruption in the block sub-system.

For more details:
* https://bugzilla.redhat.com/show_bug.cgi?id=1277922
* http://marc.info/?l=qemu-devel=144740716414450=2

Bug-Url: https://bugzilla.redhat.com/1279052
Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Signed-off-by: Daniel Erez 
Reviewed-on: https://gerrit.ovirt.org/50435
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
Reviewed-by: Sandro Bonazzola 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, approved
  Daniel Erez: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 4:

* #1279052::Update tracker: OK
* Set MODIFIED::bug 1279052#1279052IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Compare kernel vs running bond config opt vals
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f334a7ae2ecd8fc75c05972e37d539cf7c28661
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 26: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 26:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vdsm standard CI arrangement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Vdsm standard CI arrangement
..


Patch Set 38:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 38
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 25:

(1 comment)

https://gerrit.ovirt.org/#/c/49390/25/lib/vdsm/tool/dump_bonding_opts.py
File lib/vdsm/tool/dump_bonding_opts.py:

Line 82: with _bond_device(bond_name):
> _scan_modes uses _change_mode to set the bond mode.
you are right. I midssed that. but on second look- the code should still have 
one less context level.
it should look like this (conceptually):

  for mode in bond_modes:
  # explain why we replace bond at this level
  with bond(mode):
  opts[mode] = bond_opts_name2numeric_filtered(bond name)

This will eliminate the below addition in the beginning of _change_mode


-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: fix openvswitch dependency version

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: spec: fix openvswitch dependency version
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23e00681e04242729125afa68f05ea7d41f27085
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Always propagate bonding mode to engine

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove koji build flag and use specific one for vhostmd

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Remove koji build flag and use specific one for vhostmd
..


Patch Set 4: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/49427/4/configure.ac
File configure.ac:

Line 60: AC_ARG_ENABLE(
Line 61: [vhostmd],
Line 62: [AS_HELP_STRING(
Line 63: [--enable-vhostmd],
Line 64: [build vhostmd subpackage @<:@default=no@:>@]
> package is more correct. If we want to avoid specifying the name of the pac
dan asked for changing it to subpackage
Line 65: )],
Line 66: [enable_vhostmd="no"]
Line 67: )
Line 68: AS_IF([test "${enable_vhostmd}" = "yes"],


-- 
To view, visit https://gerrit.ovirt.org/49427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2401a803243e3e64216fe62039c1b15c431a906
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Always propagate bonding mode to engine

[edwardh]

Edward Haas has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[derez]

Hello Sandro Bonazzola, Nir Soffer, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/50766

to review the following change.

Change subject: spec: Require newer qemu version for el7
..

spec: Require newer qemu version for el7

Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential assertion error after lvextend caused by a memory
corruption in the block sub-system.

For more details:
* https://bugzilla.redhat.com/show_bug.cgi?id=1277922
* http://marc.info/?l=qemu-devel=144740716414450=2

Bug-Url: https://bugzilla.redhat.com/1279052
Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Signed-off-by: Daniel Erez 
Reviewed-on: https://gerrit.ovirt.org/50435
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
Reviewed-by: Sandro Bonazzola 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/50766/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0d9562f..0cd475f 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -238,8 +238,8 @@
 %endif
 
 %if 0%{?rhel}
-Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7
-Requires: qemu-img-rhev >= 10:2.3.0-13.el7
+Requires: qemu-kvm-rhev >= 10:2.3.0-31.el7_2.4
+Requires: qemu-img-rhev >= 10:2.3.0-31.el7_2.4
 %else
 Requires: qemu-kvm >= 2:2.1.3-11
 Requires: qemu-img >= 2:2.1.3-11


-- 
To view, visit https://gerrit.ovirt.org/50766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1:

* #1279052::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279052::OK, public bug
* Check Product::#1279052::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1279052::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: use network lib instead of hardcoded path hack

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: use network lib instead of hardcoded path hack
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49967
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I788e9e071ccf394022c754e33850b74aef2cad8a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[derez]

Daniel Erez has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 25:

(2 comments)

https://gerrit.ovirt.org/#/c/49390/25/lib/vdsm/netinfo/bonding.py
File lib/vdsm/netinfo/bonding.py:

Line 209: try:
: opt_num_val = bond_opts_map[mode_num][option_name][val_name]
: except KeyError:
: opt_num_val = None
> this can be also written as:
Done


https://gerrit.ovirt.org/#/c/49390/25/lib/vdsm/tool/dump_bonding_opts.py
File lib/vdsm/tool/dump_bonding_opts.py:

Line 82: with _bond_device(bond_name):
> you are right. I midssed that. but on second look- the code should still ha
Done


-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: list all attached nics in caps ports

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: list all attached nics in caps ports
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50730/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 263: self.assertIn(physical_iface, network_config['ports'])
port can be a non-physical_device (e.g. a vlan). so how does this predicate 
holds?


-- 
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: caps vlan vlanid property has to be int

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: network: caps vlan vlanid property has to be int
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50729
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I737ae75e066ee27d5ecba0aa86118b94fd1ea62d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vdsm standard CI arrangement

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Vdsm standard CI arrangement
..


Patch Set 38:

Please remove the temporary changes, and show us the actual change that you 
want to submit. It is not possible to review this in this state.

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 38
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: use a class instead of NamedTuple for IPConfig

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: use a class instead of NamedTuple for IPConfig
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49235
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic26e637d14e9542a65438f5e2b509abc20055ce2
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vdsm standard CI arrangement

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Vdsm standard CI arrangement
..


Patch Set 38:

(1 comment)

https://gerrit.ovirt.org/#/c/48268/38/tests/functional/storageTests.py
File tests/functional/storageTests.py:

Line 90: @permutations(
Line 91: [[backend, ver]
Line 92:  for backend in TYPES
Line 93:  for ver in VERSIONS])
Line 94: @brokentest("Fails in CI")
This is not needed now since we don't run it in the ci.
Line 95: def testStorage(self, backendType, domVersion):
Line 96: conf = storageLayouts[backendType]
Line 97: with RollbackContext() as rollback:
Line 98: self.createVdsmStorageLayout(conf, domVersion, rollback)


-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 38
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: tests: mirror drop inital ip tests

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: network: tests: mirror drop inital ip tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50713
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I042b45de389c5a0faca5f913eac9691ae3d6069b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test network's iface

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: tests: test network's iface
..


Patch Set 7: Code-Review-1 -Verified

nit

-- 
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test network's iface

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: tests: test network's iface
..


Patch Set 7: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/48366/7/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 231: physical_iface = (network_config.get('bonding') or
:   network_config.get('nic'))
this computation should be moved right before where it is used (downwards).


-- 
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: tests: mirror drop inital ip tests

[edwardh]

Edward Haas has posted comments on this change.

Change subject: network: tests: mirror drop inital ip tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50713
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I042b45de389c5a0faca5f913eac9691ae3d6069b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: caps vlan vlanid property has to be int

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: network: caps vlan vlanid property has to be int
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50729/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 257: else:
Line 258: expected_iface = physical_iface
Line 259: self.assertEquals(netinfo.networks[networkName]['iface'],
Line 260:   expected_iface)
Line 261: if network_config.get('vlan') is not None:
> 'vlan' in config
+1
Line 262: self.assertTrue(isinstance(network_config.get('vlan'), 
int))
Line 263: 
Line 264: def assertNetworkDoesntExist(self, networkName):
Line 265: netinfo = self.vdsm_net.netinfo


-- 
To view, visit https://gerrit.ovirt.org/50729
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I737ae75e066ee27d5ecba0aa86118b94fd1ea62d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[derez]

Daniel Erez has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3: Verified+1

Verified on CentOS/EL.

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1: Code-Review+1

Daniel, this was verified on master, so I think you can mark this as verified.

-- 
To view, visit https://gerrit.ovirt.org/50766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Always propagate bonding mode to engine

[edwardh]

Edward Haas has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix alignment issue for brick creation on JBOD

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


gluster: fix alignment issue for brick creation on JBOD

  Chunk size and alignment value should be 256KB for
 JBOD use case. So assigining these values incase of
JBOD.

 Note: blivet doesn't support alignment values in PV,VG,
Thinpool creation. So we were using blivet API only when i
we don't have any alignment and LVM commands directly when
we have alignment values. Now, with this patch we will
use lvm commands always as we have alignment values in all
the cases and Blivet API usage can be removed completely
in PV, Thin pool, VG creation.

Bug-Url: https://bugzilla.redhat.com/1270792
Signed-off-by: Ramesh Nachimuthu 
Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Signed-off-by: Timothy Asir Jeyasingh 
Reviewed-on: https://gerrit.ovirt.org/47959
Continuous-Integration: Jenkins CI
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
---
M vdsm/gluster/storagedev.py
1 file changed, 72 insertions(+), 98 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sahina Bose: Looks good to me, but someone else must approve
  Ramesh N: Verified



-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix alignment issue for brick creation on JBOD

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix alignment issue for brick creation on JBOD

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 8:

* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: MTU should be an integer all over VDSM.
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ba110d85b8ebd459c29ea438a68b8e55ccb1da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add documentation for setupNetworks rollback mechanism.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: add documentation for setupNetworks rollback mechanism.
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7d66f9612ed6762fa80e7aa9e57d914dd65f34
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: gluster: Handle missing glusterfs-cli package
..


gluster: Handle missing glusterfs-cli package

In 3.6 we introduced a soft dependency to glusterfs-cli. This was
required in order to get gluster volume info needed for to purposes:
1. get gluster backup servers in order to automatically mount gluster
   back servers
2. get replica related to verify that it is supported
However, during upgrade, if glusterfs-cli is missing, mount failed. In
this case, we'd like to add a warning message clearly indicating about
the missing glustefs-cli package, and ask the admin to install it in
order to enable automatica mount of gluster backup servers.

Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Signed-off-by: Ala Hino 
Bug-Url: https://bugzilla.redhat.com/1290997
Reviewed-on: https://gerrit.ovirt.org/50363
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Sahina Bose 
---
M tests/storageServerTests.py
M vdsm/gluster/cli.py
M vdsm/storage/storageServer.py
3 files changed, 33 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sahina Bose: Looks good to me, but someone else must approve
  Ala Hino: Verified



-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 15:

* #1290997::Update tracker: OK
* Set MODIFIED::bug 1290997#1290997OK

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 26: Code-Review+1

great job!

-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Compare kernel vs running bond config opt vals
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f334a7ae2ecd8fc75c05972e37d539cf7c28661
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Compare kernel vs running bond config opt vals
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f334a7ae2ecd8fc75c05972e37d539cf7c28661
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Compare kernel vs running bond config opt vals
..


net: Compare kernel vs running bond config opt vals

Comparing between the bond running config and the
bond kernel config should consider that some values
may be inputted as name or numeric.
A dictionary is kept to translate between the name
and its numeric value.

The running config bonding option values are normalized
to their numeric values and compared to the kernel
config which represents the values as numeric.

Change-Id: I0f334a7ae2ecd8fc75c05972e37d539cf7c28661
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/49579
Reviewed-by: Ido Barkan 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/kernelconfig.py
M tests/functional/networkTests.py
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/49579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f334a7ae2ecd8fc75c05972e37d539cf7c28661
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: track and report abort reason

[mlibra]

Marek Libra has posted comments on this change.

Change subject: migration: track and report abort reason
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47b939845f049319766a32e784da64d63bc0a982
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: MTU should be an integer all over VDSM.
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/50657/2/lib/vdsm/kernelconfig.py
File lib/vdsm/kernelconfig.py:

Line 199: 
Line 200: def _normalize_mtu(config_copy):
Line 201: for net_attr in config_copy.networks.itervalues():
Line 202: if 'mtu' in net_attr:
Line 203: # defensively convert to int so support upgrade path
> Please add
Done
Line 204: net_attr['mtu'] = int(net_attr['mtu'])
Line 205: else:
Line 206: net_attr['mtu'] = mtus.DEFAULT_MTU
Line 207: 


https://gerrit.ovirt.org/#/c/50657/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 976: if 'mtu' not in attrs:
: attrs['mtu'] = DEFAULT_MTU
: else:
: attrs['mtu'] = int(attrs['mtu'])
> attrs['mtu'] = int(attrs['mtu']) if 'mtu' in attrs else DEFAULT_MTU
Done


-- 
To view, visit https://gerrit.ovirt.org/50657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ba110d85b8ebd459c29ea438a68b8e55ccb1da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: MTU should be an integer all over VDSM.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ba110d85b8ebd459c29ea438a68b8e55ccb1da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: create bricks without MBR partitions

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: gluster: create bricks without MBR partitions
..


gluster: create bricks without MBR partitions

 During gluster brick creation, PVs should be
created directly on the disks instead of MBR
partitions to align the pvs correctly as per given
RAID parameter. This patch will remove the
_makePartition function and will not create
parition as part of gluster brick creation.

Bug-Url: https://bugzilla.redhat.com/1270792
Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Signed-off-by: Ramesh Nachimuthu 
Reviewed-on: https://gerrit.ovirt.org/50769
Continuous-Integration: Jenkins CI
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
---
M vdsm/gluster/storagedev.py
1 file changed, 1 insertion(+), 20 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sahina Bose: Looks good to me, but someone else must approve
  Ramesh N: Verified



-- 
To view, visit https://gerrit.ovirt.org/50769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: create bricks without MBR partitions

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 2:

* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/50769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: create bricks without MBR partitions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 15:

Ala, can you backport?

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: create bricks without MBR partitions

[rnachimu]

Ramesh N has uploaded a new change for review.

Change subject: gluster: create bricks without MBR partitions
..

gluster: create bricks without MBR partitions

 During gluster brick creation, PVs should be
created directly on the disks instead of MBR
partitions to align the pvs correctly as per given
RAID parameter. This patch will remove the
_makePartition function and will not create
parition as part of gluster brick creation.

Bug-Url: https://bugzilla.redhat.com/1270792
Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Signed-off-by: Ramesh Nachimuthu 
---
M vdsm/gluster/storagedev.py
1 file changed, 1 insertion(+), 20 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/50769/1

diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index 7ce4498..56815d1 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -137,24 +137,6 @@
 return [blivetEnv.devicetree.getDeviceByName(devName.split("/")[-1])
 for devName in devNameList]
 
-def _makePartition(deviceList):
-pvDeviceList = []
-doPartitioning = False
-for dev in deviceList:
-if dev.type not in ['disk', 'dm-multipath']:
-pvDeviceList.append(dev)
-else:
-blivetEnv.initializeDisk(dev)
-part = blivetEnv.newPartition(fmt_type="lvmpv", grow=True,
-  parents=[dev])
-blivetEnv.createDevice(part)
-pvDeviceList.append(part)
-doPartitioning = True
-
-if doPartitioning:
-blivet.partitioning.doPartitioning(blivetEnv)
-return pvDeviceList
-
 def _createPV(deviceList, alignment=0):
 def _createAlignedPV(deviceList, alignment):
 for dev in deviceList:
@@ -283,8 +265,7 @@
 if inUseList:
 raise ge.GlusterHostStorageDeviceInUseException(inUseList)
 
-pvDeviceList = _makePartition(deviceList)
-pvDeviceList = _createPV(pvDeviceList, alignment)
+pvDeviceList = _createPV(deviceList, alignment)
 vg = _createVG(vgName, pvDeviceList, raidParams.get('stripeSize', 0))
 
 # The following calculation is based on the redhat storage performance doc


-- 
To view, visit https://gerrit.ovirt.org/50769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster add mount options for gluster brick.

[rnachimu]

Ramesh N has uploaded a new change for review.

Change subject: gluster add mount options for gluster brick.
..

gluster add mount options for gluster brick.

 Mount options "inode64,noatime" should be used to
mount the gluster brick to improve the performance.

Bug-Url: https://bugzilla.redhat.com/1270792
Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Signed-off-by: Ramesh Nachimuthu 
---
M vdsm/gluster/storagedev.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/50770/1

diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index ec896c1..14190db 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -273,7 +273,8 @@
 raise ge.GlusterHostStorageDeviceMkfsFailedException(
 thinlv.path, alignment, raidParams.get('stripeSize', 0), fsType)
 
-format = blivet.formats.getFormat(DEFAULT_FS_TYPE, device=thinlv.path)
+format = blivet.formats.getFormat(DEFAULT_FS_TYPE, device=thinlv.path,
+  mountopts=DEFAULT_MOUNT_OPTIONS)
 format._defaultFormatOptions = ["-f", "-i", "size=512", "-n", "size=8192"]
 if raidParams.get('type') == '6':
 format._defaultFormatOptions += ["-d", "sw=%s,su=%sk" % (
@@ -296,5 +297,6 @@
 rc, out, err = utils.execCmd([_vgscanCommandPath.cmd])
 if rc:
 raise ge.GlusterHostStorageDeviceVGScanFailedException(rc, out, err)
-fstab.FsTab().add(thinlv.path, mountPoint, DEFAULT_FS_TYPE)
+fstab.FsTab().add(thinlv.path, mountPoint,
+  DEFAULT_FS_TYPE, mntOpts=[DEFAULT_MOUNT_OPTIONS])
 return _getDeviceDict(thinlv)


-- 
To view, visit https://gerrit.ovirt.org/50770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Always propagate bonding mode to engine

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Always propagate bonding mode to engine
..


Always propagate bonding mode to engine

Without this patch the bond mode is not propagated if it's
not equal to 0 (default) although engine expect it to be
always propagated

Bug-Url: https://bugzilla.redhat.com/1276445
Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Signed-off-by: Sagi Shnaidman 
Reviewed-on: https://gerrit.ovirt.org/49580
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan 
Reviewed-by: Edward Haas 
Tested-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/kernelconfig.py
M lib/vdsm/netinfo/bonding.py
M tests/functional/networkTests.py
3 files changed, 32 insertions(+), 4 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix size conversion issues in brick create

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 5:

(7 comments)

https://gerrit.ovirt.org/#/c/50705/5/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 73
Line 74
Line 75
Line 76
Line 77
> What is wrong with this?
device.size.convertTo(spec="MiB") doesn't work anymore. Spec should be passed 
using the constant from blivet.size like blivet.size.KiB. But older versions 
which is still being shipped in RHEL7.2 supports only the old way of passing 
spec as string.


Line 251
Line 252
Line 253
Line 254
Line 255
> metaDataSize is in Kib?
yes. Changed the name to metaDataSizeKib


Line 66: def _getDeviceSize(device, unitType=None):
Line 67: if hasattr(blivet.size, 'MiB'):
Line 68: if unitType == 'KiB':
Line 69: return device.size.convertTo(blivet.size.KiB)
Line 70: else:
> What if unitType is None? are you assuming that unitType is 'MiB' in this c
UnitType is assumed as MiB incase of None.
Line 71: return device.size.convertTo(blivet.size.MiB)
Line 72: else:
Line 73: if unitType == 'KiB':
Line 74: return device.size.convertTo(spec='KiB')


Line 68: if unitType == 'KiB':
Line 69: return device.size.convertTo(blivet.size.KiB)
Line 70: else:
Line 71: return device.size.convertTo(blivet.size.MiB)
Line 72: else:
> What does it mean when blivet.size does.MiB is not available?
This is due to a change in Blivet. Older versions of blivet requires unit spec 
to be string parameter. But newer version requires the constants defined in 
blivet.size.
Line 73: if unitType == 'KiB':
Line 74: return device.size.convertTo(spec='KiB')
Line 75: else:
Line 76: return device.size.convertTo(spec='MiB')


Line 71: return device.size.convertTo(blivet.size.MiB)
Line 72: else:
Line 73: if unitType == 'KiB':
Line 74: return device.size.convertTo(spec='KiB')
Line 75: else:
> What if unitType is None?
Its defaulted to MiB. May be I will change the default value to MiB instead of 
None.
Line 76: return device.size.convertTo(spec='MiB')
Line 77: return 0
Line 78: 
Line 79: 


Line 73: if unitType == 'KiB':
Line 74: return device.size.convertTo(spec='KiB')
Line 75: else:
Line 76: return device.size.convertTo(spec='MiB')
Line 77: return 0
> 0? Maybe you want to raise an error?
Done
Line 78: 
Line 79: 
Line 80: def _getDeviceDict(device, createBrick=False):
Line 81: info = {'name': device.name,


Line 87: 'mountPoint': '',
Line 88: 'uuid': '',
Line 89: 'createBrick': createBrick}
Line 90: if isinstance(device.size, blivet.size.Size):
Line 91: info['size'] = '%s' % _getDeviceSize(device)
> Using this without specifying the unit does not seem like a good idea, unle
Yes. MiB is the default here.
Line 92: else:
Line 93: info['size'] = '%s' % device.size
Line 94: if not info['bus'] and device.parents:
Line 95: info['bus'] = device.parents[0].bus


-- 
To view, visit https://gerrit.ovirt.org/50705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster add mount options for gluster brick.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 1:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: create bricks without MBR partitions

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster add mount options for gluster brick.

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster add mount options for gluster brick.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix alignment issue for brick creation on JBOD

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 7:

Splitted the original patch into 3 patches https://gerrit.ovirt.org/50769 
https://gerrit.ovirt.org/50770

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - adding appropriate logs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: snapshot - adding appropriate logs
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50775
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: snapshot - adding appropriate logs

[derez]

Daniel Erez has uploaded a new change for review.

Change subject: vm: snapshot - adding appropriate logs
..

vm: snapshot - adding appropriate logs

Following https://gerrit.ovirt.org/#/c/49535,
adding some useful logs to snapshot flow.

Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75
Signed-off-by: Daniel Erez 
---
M vdsm/virt/vm.py
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/50775/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ae91531..e4ed2bf 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3132,6 +3132,8 @@
 else:
 fileUtils.padToBlockSize(memoryVolPath)
 
+self.log.info("Taking a live snapshot on VM %s.", self.conf['vmId'])
+
 snap = vmxml.Element('domainsnapshot')
 disks = vmxml.Element('disks')
 newDrives = {}
@@ -3180,6 +3182,10 @@
 # safely access the blockDev property until after prepareVolumePath
 vmDrives[vmDevName] = vmDrive
 
+if len(newDrives) == 0:
+self.log.info("Include no disks in live snapshot on VM %s.",
+  self.conf['vmId'])
+
 preparedDrives = {}
 
 for vmDevName, vmDevice in newDrives.iteritems():
@@ -3207,6 +3213,8 @@
  libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA)
 
 if memoryParams:
+self.log.info("Include memory in live snapshot on VM %s.",
+  self.conf['vmId'])
 # Save the needed vm configuration
 # TODO: this, as other places that use pickle.dump
 # directly to files, should be done with outOfProcess
@@ -3279,6 +3287,8 @@
 if memoryParams:
 self.cif.teardownVolumePath(memoryVol)
 
+self.log.info("Completed live snapshot on VM %s.", self.conf['vmId'])
+
 # Returning quiesce to notify the manager whether the guest agent
 # froze and flushed the filesystems or not.
 quiesce = should_freeze and freezed["status"]["code"] == 0


-- 
To view, visit https://gerrit.ovirt.org/50775
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix alignment issue for brick creation on JBOD

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Always propagate bonding mode to engine

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix alignment issue for brick creation on JBOD

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix alignment issue for brick creation on JBOD
..


Patch Set 7:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: create bricks without MBR partitions

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: create bricks without MBR partitions
..


Patch Set 1:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Always propagate bonding mode to engine

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Always propagate bonding mode to engine
..


Patch Set 8:

* #1276445::Update tracker: OK
* Set MODIFIED::bug 1276445#1276445OK

-- 
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix size conversion issues in brick create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 6:

* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public bug
* Check Product::#1270792::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix size conversion issues in brick create

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: fix size conversion issues in brick create
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576b1a8c880ef6f355157225c7b763378d8cf46d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: MTU should be an integer all over VDSM.
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50657/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 976: if 'mtu' not in attrs:
: attrs['mtu'] = DEFAULT_MTU
: else:
: attrs['mtu'] = int(attrs['mtu'])
attrs['mtu'] = int(attrs['mtu']) if 'mtu' in attrs else DEFAULT_MTU


-- 
To view, visit https://gerrit.ovirt.org/50657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ba110d85b8ebd459c29ea438a68b8e55ccb1da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: MTU should be an integer all over VDSM.

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: MTU should be an integer all over VDSM.
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50657/2/lib/vdsm/kernelconfig.py
File lib/vdsm/kernelconfig.py:

Line 199: 
Line 200: def _normalize_mtu(config_copy):
Line 201: for net_attr in config_copy.networks.itervalues():
Line 202: if 'mtu' in net_attr:
Line 203: # defensively convert to int so support upgrade path
Please add

 REQUIRED_FOR: upgrade from vdsm<=4.17

so we can tell in the future when it is safe to drop the conversion.
Line 204: net_attr['mtu'] = int(net_attr['mtu'])
Line 205: else:
Line 206: net_attr['mtu'] = mtus.DEFAULT_MTU
Line 207: 


-- 
To view, visit https://gerrit.ovirt.org/50657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ba110d85b8ebd459c29ea438a68b8e55ccb1da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches