Change in vdsm[master]: net: native ovs: introduce constants module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: introduce constants module
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/56451/7/lib/vdsm/network/ovs/constants.py
File lib/vdsm/network/ovs/constants.py:

Line 18: #
Line 19: from __future__ import absolute_import
Line 20: 
Line 21: 
Line 22: BRIDGE_NAME = 'ovsbr0'  # TODO: support multiple bridges
> What else do you intend to add here?
i will add 'ovs' switch identificator here as well.


-- 
To view, visit https://gerrit.ovirt.org/56451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs network setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovs network setup
..


Patch Set 10:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: introduce constants module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: introduce constants module
..


Patch Set 7: Code-Review-1

i should add 'ovs' here too

-- 
To view, visit https://gerrit.ovirt.org/56451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs bonding setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovs bonding setup
..


Patch Set 5:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56416
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a3b698524d448fbc968c96a2c8104e57e770d6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs network setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovs network setup
..


Patch Set 9:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs network setup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: ovs network setup
..


Patch Set 8: -Verified

-- 
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs bonding setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovs bonding setup
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56416
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a3b698524d448fbc968c96a2c8104e57e770d6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: native ovs: reserve ovsbr0 network name
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/56452/5/tests/network/ovs_test.py
File tests/network/ovs_test.py:

Line 100: def test_add_network_with_reserved_name(self):
Line 101: fake_running_config = BaseConfig({}, {})
Line 102: fake_to_be_added_bonds = {}
Line 103: fake_kernel_nics = ['eth0']
Line 104: with self.assertRaises(ne.ConfigNetworkError):
You should confirm we failed on the correct specific error.
Line 105: ovs_validator.validate_net_configuration(
Line 106: ovs_constants.BRIDGE_NAME, {'nic': 'eth0', 'switch': 
'ovs'},
Line 107: fake_to_be_added_bonds, fake_running_config, 
fake_kernel_nics)
Line 108: 


-- 
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: native ovs: reserve ovsbr0 network name
..


Patch Set 5: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: introduce constants module

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: native ovs: introduce constants module
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/56451/7/lib/vdsm/network/ovs/constants.py
File lib/vdsm/network/ovs/constants.py:

Line 18: #
Line 19: from __future__ import absolute_import
Line 20: 
Line 21: 
Line 22: BRIDGE_NAME = 'ovsbr0'  # TODO: support multiple bridges
What else do you intend to add here?
Having a new module just for one constant seems a bit of overdoing.
Not even sure if it will be used like this when introducing multi ovs brifges.

Please convince us :)


-- 
To view, visit https://gerrit.ovirt.org/56451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: check for bond existence

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: native ovs: check for bond existence
..


Patch Set 4:

(2 comments)

Just some nits

https://gerrit.ovirt.org/#/c/56461/4//COMMIT_MSG
Commit Message:

PS4, Line 9: connected with
dependent on


https://gerrit.ovirt.org/#/c/56461/4/lib/vdsm/network/ovs/validator.py
File lib/vdsm/network/ovs/validator.py:

PS4, Line 58: is not None
I don't thin it is needed.


-- 
To view, visit https://gerrit.ovirt.org/56461
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife76761b5ca5a32dcff030efd6a5bef9b9c51f7b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: check for nic existence

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: native ovs: check for nic existence
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py
File lib/vdsm/network/ovs/validator.py:

PS6, Line 53: if nic is not None:
: if nic not in kernel_nics
> I think you can use: if not nic and nic not in kernel_nics
Sorry: if nic and ...


-- 
To view, visit https://gerrit.ovirt.org/56448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1ae02f7e65f305f2f21101fae0303baafe1ea6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add Transaction() to netconfpersistence

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: add Transaction() to netconfpersistence
..


Patch Set 15: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56149
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: check for nic existence

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: native ovs: check for nic existence
..


Patch Set 6:

(2 comments)

Small nit

https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py
File lib/vdsm/network/ovs/validator.py:

PS6, Line 53: if nic is not None:
: if nic not in kernel_nics
I think you can use: if not nic and nic not in kernel_nics


https://gerrit.ovirt.org/#/c/56448/6/tests/network/ovs_test.py
File tests/network/ovs_test.py:

Line 56: 
Line 57: def test_add_network_with_non_existing_nic(self):
Line 58: fake_running_networks = {}
Line 59: fake_kernel_nics = []
Line 60: with self.assertRaises(ne.ConfigNetworkError):
A general note for all exceptions checks: we should check the exact failure 
code.
Line 61: ovs_validator.validate_net_configuration(
Line 62: 'net1', {'nic': 'eth0', 'switch': 'ovs'},
Line 63: fake_running_networks, fake_kernel_nics)
Line 64: 


-- 
To view, visit https://gerrit.ovirt.org/56448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1ae02f7e65f305f2f21101fae0303baafe1ea6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Refactor metadata operations

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Refactor metadata operations
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/52671/6/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 223: DESCRIPTION_SIZE)
Line 224: desc = desc[:DESCRIPTION_SIZE]
Line 225: return desc
Line 226: 
Line 227: def storage_format(self):
I was happy with the previous name (format) -  why change it?
Line 228: """
Line 229: Format metadata string in storage format.
Line 230: 
Line 231: Raises MetadataOverflowError if formatted metadata is too 
long.


-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: Add from_lines factory method
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/52672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f63dce8e42e99d3240f4e916a9bd6ee5ee4b61
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Refactor metadata operations

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Refactor metadata operations
..


Patch Set 6: Code-Review+1

Waiting for another review.

-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs bonding setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovs bonding setup
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56416
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a3b698524d448fbc968c96a2c8104e57e770d6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: native ovs: ovsnettestlib.py
..


Patch Set 9: Code-Review-1

(2 comments)

Some nits

https://gerrit.ovirt.org/#/c/56391/8/tests/network/ovs_driver_test.py
File tests/network/ovs_driver_test.py:

PS8, Line 26: network
redundant


https://gerrit.ovirt.org/#/c/56391/8/tests/network/ovsnettestlib.py
File tests/network/ovsnettestlib.py:

PS8, Line 1: 2015-
remove


-- 
To view, visit https://gerrit.ovirt.org/56391
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs network setup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: ovs network setup
..


Patch Set 8: Verified+1

Passed ovs_test.py and manual setupNetworks API testing.

-- 
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: reserve ovsbr0 network name
..


Patch Set 5:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: introduce constants module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: introduce constants module
..


Patch Set 7:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: check for nic existence

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: check for nic existence
..


Patch Set 6:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1ae02f7e65f305f2f21101fae0303baafe1ea6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: check for bond existence

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: check for bond existence
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56461
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife76761b5ca5a32dcff030efd6a5bef9b9c51f7b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs network setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovs network setup
..


Patch Set 8:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovsnettestlib.py
..


Patch Set 9:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56391
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Add from_lines factory method
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/52672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f63dce8e42e99d3240f4e916a9bd6ee5ee4b61
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Refactor metadata operations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Refactor metadata operations
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I366fd989b1387aa483a74e14dcfdc91b9f422060
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Filter incomplete volumes from volume queries

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Filter incomplete volumes from volume queries
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92acef22de8b1faaed0754fbddedfc2273095c3b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add basic BlockVolumeArtifacts
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Replace misc.RWLock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: rwlock: Replace misc.RWLock
..


Patch Set 25:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/43423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ae6064e8e031339303e64606a70673807c4083a
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Add error logging in diskReplicateFinish

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Add error logging in diskReplicateFinish
..


Patch Set 3:

* #1325791::Update tracker: OK
* Set MODIFIED::bug 1325791#1325791FAILED, illegal change from NEW

-- 
To view, visit https://gerrit.ovirt.org/55939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcfe5a6e2f3dcd03ea07df523723e8134239fd59
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Add error logging in diskReplicateFinish

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: Add error logging in diskReplicateFinish
..


Patch Set 2:

The original problem cannot be reproduced with engine 3.6.4. I verified the 
logs by faking various error conditions.

-- 
To view, visit https://gerrit.ovirt.org/55939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcfe5a6e2f3dcd03ea07df523723e8134239fd59
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Add error logging in diskReplicateFinish

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: vm: Add error logging in diskReplicateFinish
..


vm: Add error logging in diskReplicateFinish

On failures of diskReplicateFinish we had mostly no logs, making
debugging much harder. Log error for each failure explaining the error,
and include the source disk, drive name, and the libvirt job info.

Change-Id: Ibcfe5a6e2f3dcd03ea07df523723e8134239fd59
Bug-Url: https://bugzilla.redhat.com/1325791
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/55939
Reviewed-by: Francesco Romani 
Reviewed-by: Freddy Rolland 
---
M vdsm/virt/vm.py
1 file changed, 14 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified; Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcfe5a6e2f3dcd03ea07df523723e8134239fd59
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Add error logging in diskReplicateFinish

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vm: Add error logging in diskReplicateFinish
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcfe5a6e2f3dcd03ea07df523723e8134239fd59
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: drop unused blkid external binary

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: drop unused blkid external binary
..


Patch Set 1: Code-Review+1

:. missed that

-- 
To view, visit https://gerrit.ovirt.org/56478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef69691a349626a12abfe839d6bbe91446929cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: add support for importing kvm based vms from libvirt
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56459/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 158: command = XenCommand(uri, vminfo, job_id, irs)
Line 159: elif uri.startswith(_VMWARE_PROTOCOL):
Line 160: command = LibvirtCommand(uri, username, password, vminfo, 
job_id, irs)
Line 161: else:
Line 162: command = KVMCommand(uri, username, password, vminfo, job_id, 
irs)
We can use this command only if we have the ovirt-image-common package 
installed - but this package does not exist yet. So we must have a soft 
dependency until the package will be available, which may be after the feature 
freeze.

Please use this logic:

try:
import ovirt_image_common
except ImportError:
ovirt_image_common = None

And check if we have the package when getting a request, failing with 
UnsupportedError if we cannot perform this request.

When the package is available, we can require it in vdsm spec and remove the 
soft dependency.
Line 163: job = ImportVm(job_id, command)
Line 164: job.start()
Line 165: _add_job(job_id, job)
Line 166: return {'status': doneCode}


-- 
To view, visit https://gerrit.ovirt.org/56459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ddbab700f2e0c54d53ed02ec61477b92c9c7960
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: kvm@ovirt: tool for streaming images from libvirt

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: kvm@ovirt: tool for streaming images from libvirt
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/55797/2/helpers/kvm2ovirt
File helpers/kvm2ovirt:

Line 96: if verbose:
Line 97: write_output('>>> disk %d, capasity: %d allocation %d' %
Line 98:  (diskno, vol.info()[1], vol.info()[2]))
Line 99: 
Line 100: size = vol.info()[2]
> could this raise? If so, it is ok if we explode?
If we cannot get volume size, I guess the best way to proceed is to explode.
Line 101: 
Line 102: stream = con.newStream()
Line 103: try:
Line 104: vol.download(stream, 0, 0, 0)


-- 
To view, visit https://gerrit.ovirt.org/55797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: add support for importing kvm based vms from libvirt
..


Patch Set 1: Code-Review+1

(3 comments)

Nice, needs some minor fixes.

https://gerrit.ovirt.org/#/c/56459/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 345
Line 346
Line 347
Line 348
Line 349
Please remove this blank line.


Line 157: if uri.startswith(_XEN_SSH_PROTOCOL):
Line 158: command = XenCommand(uri, vminfo, job_id, irs)
Line 159: elif uri.startswith(_VMWARE_PROTOCOL):
Line 160: command = LibvirtCommand(uri, username, password, vminfo, 
job_id, irs)
Line 161: else:
Please add constant for _KVM_PROTOCOL and do not assume that this is the only 
possible option. If we get another protocol, fail with ClientError.
Line 162: command = KVMCommand(uri, username, password, vminfo, job_id, 
irs)
Line 163: job = ImportVm(job_id, command)
Line 164: job.start()
Line 165: _add_job(job_id, job)


Line 572: 
Line 573: @contextmanager
Line 574: def execute(self):
Line 575: with self._volumes(), self._password_file():
Line 576: yield self._start_virt_v2v()
_start_virt_v2v is not correct now, since it may run kvm2ovirt or virt-v2v. 
Lets use a more generic name like start_helper
Line 577: 
Line 578: def _source_images(self):
Line 579: con = libvirtconnection.open_connection(uri=self._uri,
Line 580: 
username=self._username,


-- 
To view, visit https://gerrit.ovirt.org/56459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ddbab700f2e0c54d53ed02ec61477b92c9c7960
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: build: Remove pep8 and pyflakes requirement
..


Patch Set 3: -Continuous-Integration

-- 
To view, visit https://gerrit.ovirt.org/56152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: Add from_lines factory method
..


Patch Set 5: Code-Review+2

Looks good, waiting for previous patch.

-- 
To view, visit https://gerrit.ovirt.org/52672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f63dce8e42e99d3240f4e916a9bd6ee5ee4b61
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Refactor metadata operations

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Refactor metadata operations
..


Patch Set 5: Code-Review-1

Please check all comments

-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: drop unused blkid external binary

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: drop unused blkid external binary
..

drop unused blkid external binary

commit ac0efac98 should have removed these definitions.

Change-Id: I3ef69691a349626a12abfe839d6bbe91446929cd
Signed-off-by: Dan Kenigsberg 
---
M configure.ac
M lib/vdsm/constants.py.in
2 files changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/56478/1

diff --git a/configure.ac b/configure.ac
index 340c8dd..d4fc5f1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -317,7 +317,6 @@
 AX_PYTHON_MODULE([six], [fatal])
 
 # External programs (sorted, please keep in order)
-AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
 AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])
 AC_PATH_PROG([CAT_PATH], [cat], [/bin/cat])
 AC_PATH_PROG([CHCON_PATH], [chcon], [/bin/chcon])
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 7f3962d..8a48cf1 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -99,7 +99,6 @@
 #
 # External programs (sorted, please keep in order).
 #
-EXT_BLKID = '@BLKID_PATH@'
 EXT_BRCTL = '@BRCTL_PATH@'
 
 EXT_CHOWN = '@CHOWN_PATH@'


-- 
To view, visit https://gerrit.ovirt.org/56478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ef69691a349626a12abfe839d6bbe91446929cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: drop unused blkid external binary

[automation]

gerrit-hooks has posted comments on this change.

Change subject: drop unused blkid external binary
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef69691a349626a12abfe839d6bbe91446929cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Filter incomplete volumes from volume queries

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Filter incomplete volumes from volume queries
..


Patch Set 6:

Adam, can you verify?

-- 
To view, visit https://gerrit.ovirt.org/56086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92acef22de8b1faaed0754fbddedfc2273095c3b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add test_missing_tags for block storage

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add test_missing_tags for block storage
..


Patch Set 5: Verified+1

Tests pass, so this is verified.

-- 
To view, visit https://gerrit.ovirt.org/56171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add test_missing_tags for block storage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add test_missing_tags for block storage
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add test_missing_tags for block storage

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: Add test_missing_tags for block storage
..


tests: Add test_missing_tags for block storage

Add a simple test that verifies that volumes with missing tags are not
returned by getAllVolumes.

Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/56171
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
Tested-by: Nir Soffer 
---
M tests/Makefile.am
M tests/blocksdTests.py
A tests/lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out
M vdsm.spec.in
4 files changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/56171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: build: Remove pep8 and pyflakes requirement
..


Patch Set 3: Continuous-Integration+1

CI succeeded, but for some reason did not update gerrit yet.

-- 
To view, visit https://gerrit.ovirt.org/56152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: Run make check over el7 in automation CI

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: automation: Run make check over el7 in automation CI
..


Patch Set 6: Code-Review+1

Waiting from Piotr/Dan ack.

-- 
To view, visit https://gerrit.ovirt.org/56122
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabbb09920de316a4e26447a0ca77ba9f30e517cd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: Run make check over el7 in automation CI

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: automation: Run make check over el7 in automation CI
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56122
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabbb09920de316a4e26447a0ca77ba9f30e517cd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build: Remove pep8 and pyflakes requirement
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: Run make check over el7 in automation CI

[automation]

gerrit-hooks has posted comments on this change.

Change subject: automation: Run make check over el7 in automation CI
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56122
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabbb09920de316a4e26447a0ca77ba9f30e517cd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: Remove pep8 and pyflakes requirement
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Removing generationID from clientIF

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Removing generationID from clientIF
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecdf9e15dbc7aaf8a93d0b221b014ba2d5870d3f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Removing generationID from clientIF

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Removing generationID from clientIF
..

Removing generationID from clientIF

Seems like this verb is not in use for a long time. Originally it was
added to monitor vdsmd restarts.

Change-Id: Iecdf9e15dbc7aaf8a93d0b221b014ba2d5870d3f
Signed-off-by: Yaniv Bronhaim 
---
M vdsm/clientIF.py
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/56475/1

diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index fc4b5b4..b7ac5f7 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -24,7 +24,6 @@
 import socket
 import time
 import threading
-import uuid
 from functools import partial
 from weakref import proxy
 from collections import defaultdict
@@ -89,7 +88,6 @@
 self.log = log
 self._recovery = True
 self.channelListener = Listener(self.log)
-self._generationID = str(uuid.uuid4())
 self.mom = None
 self.bindings = {}
 self._broker_client = None


-- 
To view, visit https://gerrit.ovirt.org/56475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecdf9e15dbc7aaf8a93d0b221b014ba2d5870d3f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cmdutils: enhance systemd_run

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cmdutils: enhance systemd_run
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: HACK: virt: override vm type from custom property

[automation]

gerrit-hooks has posted comments on this change.

Change subject: HACK: virt: override vm type from custom property
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54872
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63b89f8791a9b0eb08100c62dcfa28d29b2321a6
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: add imagerepo feed containers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hook: add imagerepo feed containers
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94ae3b82150981c76a6079d5741aeca8faa1dd33
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: utils: add is_kvm helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: utils: add is_kvm helper
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: containers: always add emulator to XML

[automation]

gerrit-hooks has posted comments on this change.

Change subject: containers: always add emulator to XML
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54176
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie40c6a3e2cdbb72053db71056092d3b7684b994d
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cmdutils: enhance systemd_run

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: cmdutils: enhance systemd_run
..

cmdutils: enhance systemd_run

Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
TODO: explain
Signed-off-by: Francesco Romani 
---
M lib/vdsm/cmdutils.py
1 file changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/56474/1

diff --git a/lib/vdsm/cmdutils.py b/lib/vdsm/cmdutils.py
index 8629e1c..0c02f81 100644
--- a/lib/vdsm/cmdutils.py
+++ b/lib/vdsm/cmdutils.py
@@ -69,7 +69,8 @@
 return command
 
 
-def systemd_run(cmd, scope=False, unit=None, slice=None):
+def systemd_run(cmd, scope=False, unit=None, slice=None, accounting=False,
+uid=None, gid=None):
 command = [constants.EXT_SYSTEMD_RUN]
 if scope:
 command.append('--scope')
@@ -77,6 +78,16 @@
 command.append('--unit=%s' % unit)
 if slice:
 command.append('--slice=%s' % slice)
+if accounting:
+command.extend([
+'--property=CPUAccounting=1',
+'--property=MemoryAccounting=1',
+'--property=BlockIOAccounting=1',
+])
+if uid is not None:
+command.append('--uid=%i' % uid)
+if gid is not None:
+command.append('--gid=%i' % gid)
 command.extend(cmd)
 return command
 


-- 
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: vm: skip domDependentInit for containers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: vm: skip domDependentInit for containers
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7360d75c4adcab655c2cd215c6b9d91f9d92a646
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: containers: optional container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: containers: optional container support
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: supervdsm: configure container networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: supervdsm: configure container networks
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add test_missing_tags for block storage

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add test_missing_tags for block storage
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Refactor metadata operations

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Refactor metadata operations
..


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/52671/4/tests/storage_volume_metadata_test.py
File tests/storage_volume_metadata_test.py:

Line 103: 
Line 104: @permutations([['size'], ['ctime'], ['mtime']])
Line 105: def test_int_params_str_raises(self, param):
Line 106: params = get_params()
Line 107: params[param] = 'not_an_int'
> Actually it's not as clean because param is a variable not the key name its
Right

 **{param: 'not an int'} will do in this case params[param] = 'not an int' is 
nicer.


https://gerrit.ovirt.org/#/c/52671/4/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 458
Line 459
Line 460
Line 461
Line 462
This use now VolumeMedadata to write the description, right?

Since it already validate and truncate the description, we can remove the extra 
validation here, so this method would be just a call to the setMetaParam with 
the correct key.


Line 183: self.parent_vol_id = parent_vol_id
Line 184: self.size = size
Line 185: self.vol_format = vol_format
Line 186: self.alloc_policy = alloc_policy
Line 187: self.parental_status = parental_status
> Shared is a different kind of parental status in my opinion.  To me, parent
This is a common infrastructure that will be used everywhere, so it is not 
about personal preferences.

By using new names instead of the names in the old api and the storage format, 
we make the code harder to understand. How can developer understand which code 
is writing VOLTYPE=INTERNAL? 

If we keep the old names, this is very clear.
Line 188: self.disk_type = disk_type
Line 189: self.description = description
Line 190: self.legality = legality
Line 191: self.ctime = int(time.time()) if ctime is None else ctime


-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I366fd989b1387aa483a74e14dcfdc91b9f422060
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add test_missing_tags for block storage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add test_missing_tags for block storage
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Refactor metadata operations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Refactor metadata operations
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Filter incomplete volumes from volume queries

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Filter incomplete volumes from volume queries
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92acef22de8b1faaed0754fbddedfc2273095c3b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

[alitke]

Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: Add from_lines factory method
..


Patch Set 4:

(12 comments)

https://gerrit.ovirt.org/#/c/52672/3//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Add support for creating a VolumeMetadata instance from a list of lines.
Line 10: This is the format that can be read from either block or file based
Line 11: volume metadata and enables us to consolidate the logic into one place.
Line 12: 
> Add comment that we now raise when integer values were expected in from_lin
Done
Line 13: Note the following semantics changes:
Line 14: 
Line 15:  - from_lines can raise ValueError if fields that represent int values
Line 16:are not valid integers


https://gerrit.ovirt.org/#/c/52672/4/tests/storage_volume_metadata_test.py
File tests/storage_volume_metadata_test.py:

Line 107: params = get_params()
Line 108: params[param] = 'not_an_int'
Line 109: self.assertRaises(AssertionError, volume.VolumeMetadata, 
**params)
Line 110: 
Line 111: def test_from_lines_missing_param(self):
> Missing POOL will not raise, but this test does not check this. I think tha
Agreed.  Split the pool test case out and am now testing the omission of each 
required key as a separate permutation.
Line 112: self.assertRaises(se.MetaDataKeyNotFoundError,
Line 113:   volume.VolumeMetadata.from_lines, [])
Line 114: 
Line 115: def test_from_lines_invalid_param(self):


Line 118: lines.insert(0, "FOO=BAR")
Line 119: self.assertNotIn("FOO",
Line 120:  
volume.VolumeMetadata.from_lines(lines).legacy_info())
Line 121: 
Line 122: def test_from_lines_invalid_format(self):
> invalid_format is confusing, I was trying to understand whats wrong with "F
renamed and test all int params via permutations.
Line 123: lines = ["DOMAIN=domain", "IMAGE=image", "PUUID=parent", 
"SIZE=FOO",
Line 124:  "FORMAT=format", "TYPE=type", "VOLTYPE=voltype",
Line 125:  "DISKTYPE=disktype", "EOF"]
Line 126: self.assertRaises(ValueError,


Line 121: 
Line 122: def test_from_lines_invalid_format(self):
Line 123: lines = ["DOMAIN=domain", "IMAGE=image", "PUUID=parent", 
"SIZE=FOO",
Line 124:  "FORMAT=format", "TYPE=type", "VOLTYPE=voltype",
Line 125:  "DISKTYPE=disktype", "EOF"]
> This is very hard to read, please use always one item per line, sorted.
done.  Added a helper.
Line 126: self.assertRaises(ValueError,
Line 127:   volume.VolumeMetadata.from_lines, lines)
Line 128: 
Line 129: def test_from_lines(self):


Line 129: def test_from_lines(self):
Line 130: lines = ["DOMAIN=domain", "IMAGE=image", "PUUID=parent", 
"SIZE=0",
Line 131:  "FORMAT=format", "TYPE=type", "VOLTYPE=voltype",
Line 132:  "DISKTYPE=disktype", "DESCRIPTION=description", 
"MTIME=0",
Line 133:  "CTIME=0", "LEGALITY=legality", "EOF"]
> Same
Done
Line 134: md = volume.VolumeMetadata.from_lines(lines)
Line 135: self.assertEqual('domain', md.sd_id)
Line 136: self.assertEqual('image', md.img_id)
Line 137: self.assertEqual('parent', md.parent_vol_id)


https://gerrit.ovirt.org/#/c/52672/4/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 199
Line 200
Line 201
Line 202
Line 203
> Lets use validate_description - this class is does not have any other legac
Done


Line 169: TYPE_NETWORK = "network"
Line 170: 
Line 171: 
Line 172: class VolumeMetadata(object):
Line 173: # metadata_key: (attribute, coercion_fn)
> This is not coercion but validation - it convert the string to the correct 
Done
Line 174: MD_FIELDS = {
Line 175: DOMAIN: ('sd_id', None),
Line 176: IMAGE:  ('img_id', None),
Line 177: PUUID:  ('parent_vol_id', None),


Line 209: 
Line 210: @classmethod
Line 211: def from_lines(cls, lines):
Line 212: kwargs = {}
Line 213: found_md = []
> We can use set() and name it found_keys
Done
Line 214: for l in lines:
Line 215: if l.startswith("EOF"):
Line 216: break
Line 217: if l.find("=") < 0:


Line 210: @classmethod
Line 211: def from_lines(cls, lines):
Line 212: kwargs = {}
Line 213: found_md = []
Line 214: for l in lines:
> Use "line" instead of "l".
Done
Line 215: if l.startswith("EOF"):
Line 216: break
Line 217: if l.find("=") < 0:
Line 218: continue


Line 213: found_md = []
Line 214: for l in lines:
Line 215: if l.startswith("EOF"):
Line 216: break
Line 217: if l.find("=") < 0:
> Better use:
Done
Line 218: continue
Line 219: key, value = [item.strip() for item in 

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Add from_lines factory method
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/52672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f63dce8e42e99d3240f4e916a9bd6ee5ee4b61
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add basic BlockVolumeArtifacts
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [7]: configure basic ovs nets and bonds

[phoracek]

Petr Horáček has abandoned this change.

Change subject: net: native ovs [7]: configure basic ovs nets and bonds
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/55307
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic779d8798e02b5e5eae514e111ab2a7e2ad2e786
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [7]: configure basic ovs nets and bonds

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [7]: configure basic ovs nets and bonds
..


Patch Set 6:

* #1195208::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/55307
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic779d8798e02b5e5eae514e111ab2a7e2ad2e786
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: rename event for clarity

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: rename event for clarity
..


Patch Set 1: Code-Review+1

Good idea.

-- 
To view, visit https://gerrit.ovirt.org/56466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5931cc443e445eec49e87081b86f83d2a4c42a83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM: Always create lv file

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: FakeLVM: Always create lv file
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia364588a9fbe3a987b9117522db025e92c8ed296
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM: Always create lv file

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: FakeLVM: Always create lv file
..


tests: FakeLVM: Always create lv file

When creating Fake LVs always create a regular file at lvm.lvPath(...)
of the size passed into lvm.createLV.  This makes sure that storage code
will be able read from and write to the fake LV.

Change-Id: Ia364588a9fbe3a987b9117522db025e92c8ed296
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/56169
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
M tests/storagetestlib.py
3 files changed, 41 insertions(+), 8 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/56169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia364588a9fbe3a987b9117522db025e92c8ed296
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: kvm@ovirt: tool for streaming images from libvirt

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: kvm@ovirt: tool for streaming images from libvirt
..


Patch Set 2:

(5 comments)

https://gerrit.ovirt.org/#/c/55797/2/helpers/kvm2ovirt
File helpers/kvm2ovirt:

Line 82: write_output('Creating output metadata')
Line 83: write_output('Finishing off')
Line 84: 
Line 85: 
Line 86: def volume_progress(op):
Here we wait using time.sleep, so we always have to wait 1 second (or more if 
we decide) before finishing. We can instead wait on a threading.Event, which 
will allow waking the progress thread when we finish the operation.

When starting the operation, create an event object:

done = threading.Event()

Send it to the progress thread:

t = concurrent.thread(volume_progress, args=(op, done))
t.start()
op.run()
done.set()  # This will wake up the progress thread immediately.


And in volume_progress, do:

def volume_progress(op, done):
while op.done < op.size:
progress = op.done * 100 // op.size
write_progress(progress)
done.wait(1)
write_progress(100)

Note that you should write progress before sleeping, otherwise you will have 
empty
output for the first second, instead of seeing (0/100%) immediately.

Using an event we can not sleep for 5 seconds since we query progress only 
every 15 seconds from engine, and we will not have useless delay when the 
operation is done.
Line 87: while op.done < op.size:
Line 88: time.sleep(1)
Line 89: progress = op.done * 100 // op.size
Line 90: write_progress(progress)


Line 106: op = directio.Receive(dest, sr, size, buffersize=pksize)
Line 107: t = concurrent.thread(volume_progress, args=(op,))
Line 108: t.start()
Line 109: op.run()
Line 110: t.join()
> works. A nicer alternative
th.stop? I guess you mean join()
Line 111: finally:
Line 112: try:
Line 113: # TODO: remove that after libvirt answer???
Line 114: stream.finish()


Line 112: try:
Line 113: # TODO: remove that after libvirt answer???
Line 114: stream.finish()
Line 115: except Exception as ex:
Line 116: write_output(str(ex))
We probably need a helper for logging errors:

def write_error(e):
write_output("ERROR: %s" % e)
Line 117: 
Line 118: 
Line 119: def get_password():
Line 120: ret = ''


Line 125: fd = open(options.password_file, 'r')
Line 126: try:
Line 127: ret = fd.read()
Line 128: finally:
Line 129: fd.close()
> why not just
+1
Line 130: return ret
Line 131: 
Line 132: 
Line 133: options = parse_arguments()


Line 143: for item in itertools.izip(options.source, options.dest):
Line 144: vol = con.storageVolLookupByPath(item[0])
Line 145: download_volume(vol, item[1], diskno, disksitems, pksize, 
options.verbose)
Line 146: diskno = diskno + 1
Line 147: finish_progress()
> please wrap it into a function like _main()
There is no need to use _main(), the normal idiom is main()

This makes it possible to import and write unit tests for this module.


-- 
To view, visit https://gerrit.ovirt.org/55797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovsnettestlib.py
..


Patch Set 8:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56391
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: ovsnettestlib.py
..


Patch Set 8: Verified+1

Passed ovs_driver_test.py

-- 
To view, visit https://gerrit.ovirt.org/56391
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs network setup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: ovs network setup
..


Patch Set 7:

this should be rebased on top of consts patch

-- 
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add Transaction() to netconfpersistence

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: add Transaction() to netconfpersistence
..


Patch Set 15:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56149
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs network setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovs network setup
..


Patch Set 7:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs network setup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: ovs network setup
..


Patch Set 6: Verified+1

Passed ovs_test.py and manual setupNetworks API testing.

-- 
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovs network setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovs network setup
..


Patch Set 6:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56353
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: handle destroy request while starting up

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: handle destroy request while starting up
..


Patch Set 5:

Piotr, good points, but turns out that I was heading in the wrong direction, so 
I stripped away the timeout part and retargeted this patch. Problem solved, 
somehow :)

-- 
To view, visit https://gerrit.ovirt.org/55151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I618eb03783d7059ae33d7b0a02542b99c8d8199b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: fix spec normalization when mounting

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: fix spec normalization when mounting
..


Patch Set 9:

(7 comments)

https://gerrit.ovirt.org/#/c/55182/9/lib/vdsm/storage/fileUtils.py
File lib/vdsm/storage/fileUtils.py:

Line 89: def transform_remote_path(remote_path):
Line 90: """
Line 91: Transforms an unnormalized remote path to a new one for local mount
Line 92: """
Line 93: return transformPath(normalize_remote_path(remote_path))
Without this method the code will be more consistent and clear - storageServer, 
nfsSD and hsm will use both normalize_remove_path and transformPath.
Line 94: 
Line 95: 
Line 96: def normalize_remote_path(remote_path):
Line 97: if ":" in remote_path:


Line 92: """
Line 93: return transformPath(normalize_remote_path(remote_path))
Line 94: 
Line 95: 
Line 96: def normalize_remote_path(remote_path):
Lets call it normalize_path since it supports both remote and local path.

Add docstrings explaining what this does and mention handling both remote and 
local path.
Line 97: if ":" in remote_path:
Line 98: host, path = address.hosttail_split(remote_path)
Line 99: return address.hosttail_join(host, normpath(path))
Line 100: return normpath(remote_path)


https://gerrit.ovirt.org/#/c/55182/9/lib/vdsm/storage/mount.py
File lib/vdsm/storage/mount.py:

Line 181
Line 182
Line 183
Line 184
Line 185
This normpath is also not needed, the caller of this code should normalize 
paths if needed.


Line 58:  fs_freq, fs_passno) = line.split()[:6]
Line 59: fs_mntops = fs_mntops.split(",")
Line 60: fs_freq = int(fs_freq)
Line 61: fs_passno = int(fs_passno)
Line 62: fs_spec = fileUtils.normalize_remote_path(_parseFstabPath(fs_spec))
We don't need normalzation here, since we mounted the paths using normalized 
paths, and we don't expect the kernel to play with the paths.

Both fs_spec and fs_file.
Line 63: 
Line 64: fs_file = normpath(_parseFstabPath(fs_file))
Line 65: for suffix in (" (deleted)", ):
Line 66: if not fs_file.endswith(suffix):


Line 204: 
Line 205: log = logging.getLogger("storage.Mount")
Line 206: 
Line 207: def __init__(self, fs_spec, fs_file):
Line 208: self.fs_spec = fileUtils.normalize_remote_path(fs_spec)
The caller should normalize paths if needed. We must normalize fs_spec for 
creating fs_file as done in storageServer.MountConnection, so it does not make 
sense to normalize twice.

(both fs_file and fs_spec)
Line 209: self.fs_file = normpath(fs_file)
Line 210: 
Line 211: def __eq__(self, other):
Line 212: return (self.__class__ == other.__class__ and


https://gerrit.ovirt.org/#/c/55182/9/tests/fileUtilTests.py
File tests/fileUtilTests.py:

Line 279: self.assertRaises(OSError, fileUtils.atomic_symlink, 
target, link)
Line 280: 
Line 281: 
Line 282: @expandPermutations
Line 283: class TestTransformRemotePath(TestCaseBase):
If we remove tranform_remote_path, we don't need the tests.
Line 284: 
Line 285: @permutations([
Line 286: ("server:/path", "server:_path"),
Line 287: ("server:/path/", "server:_path"),


https://gerrit.ovirt.org/#/c/55182/9/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 211
Line 212
Line 213
Line 214
Line 215
We need to send the normalized spec to mount.


-- 
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: ovsnettestlib.py
..


Patch Set 7: Verified+1

Passed ovs_driver_test.py

-- 
To view, visit https://gerrit.ovirt.org/56391
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: rename event for clarity

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: rename event for clarity
..


Patch Set 1: Verified+1

trivial rename-only patch, verified using tests.

-- 
To view, visit https://gerrit.ovirt.org/56466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5931cc443e445eec49e87081b86f83d2a4c42a83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: serialize destroy() and creation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: serialize destroy() and creation
..


Patch Set 4:

* #912390::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/55150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I234922e46791f5baf46fcb5c790a9d386ac92371
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: serialize destroy() and creation

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: serialize destroy() and creation
..


Abandoned

wrong approach

-- 
To view, visit https://gerrit.ovirt.org/55150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I234922e46791f5baf46fcb5c790a9d386ac92371
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: rename event for clarity

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: rename event for clarity
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5931cc443e445eec49e87081b86f83d2a4c42a83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: handle destroy request while starting up

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: handle destroy request while starting up
..


Patch Set 5:

* #912390::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#912390::OK, public bug
* Check Product::#912390::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I618eb03783d7059ae33d7b0a02542b99c8d8199b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: rename event for clarity

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: rename event for clarity
..

vm: rename event for clarity

Vm._destroyed actually means that Vdsm received a request
to destroy a Vm which is not yet fully created.
Hence, we rename it as _destroy_requested to clarify a bit the flows.

Change-Id: I5931cc443e445eec49e87081b86f83d2a4c42a83
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/56466/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 86c0a5b..cc67096 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -242,7 +242,7 @@
 vmdevices.graphics.initLegacyConf(self.conf)
 self.cif = cif
 self.log = SimpleLogAdapter(self.log, {"vmId": self.conf['vmId']})
-self._destroyed = threading.Event()
+self._destroy_requested = threading.Event()
 self._recovery_file = recovery.File(self.conf['vmId'])
 self._monitorResponse = 0
 self.memCommitted = 0
@@ -776,7 +776,7 @@
 def _preparePathsForDrives(self, drives):
 for drive in drives:
 with self._volPrepareLock:
-if self._destroyed.is_set():
+if self._destroy_requested.is_set():
 # A destroy request has been issued, exit early
 break
 drive['path'] = self.cif.prepareVolumePath(drive, self.id)
@@ -853,7 +853,8 @@
 # This is not a definite fix, we're aware that there is still the
 # possibility of a race condition, however this covers more cases
 # than before and a quick gain
-if not self.conf.get('clientIp', '') and not self._destroyed.is_set():
+if (not self.conf.get('clientIp', '') and
+   not self._destroy_requested.is_set()):
 delay = config.get('vars', 'user_shutdown_timeout')
 timeout = config.getint('vars', 'sys_shutdown_timeout')
 CDA = ConsoleDisconnectAction
@@ -1759,7 +1760,7 @@
uuidPath, name)
 
 def _domDependentInit(self):
-if self._destroyed.is_set():
+if self._destroy_requested.is_set():
 # reaching here means that Vm.destroy() was called before we could
 # handle it. We must handle it now
 try:
@@ -4035,7 +4036,7 @@
 hooks.before_vm_destroy(self._domain.xml, self.conf)
 with self._shutdownLock:
 self._shutdownReason = vmexitreason.ADMIN_SHUTDOWN
-self._destroyed.set()
+self._destroy_requested.set()
 
 return self.releaseVm(gracefulAttempts)
 


-- 
To view, visit https://gerrit.ovirt.org/56466
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5931cc443e445eec49e87081b86f83d2a4c42a83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: ovsnettestlib.py
..


Patch Set 7:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56391
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: fix spec normalization when mounting

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: fix spec normalization when mounting
..


Patch Set 9:

(3 comments)

Please fix getStorageDomainsList - missing spec normalization before 
transforming path.

https://gerrit.ovirt.org/#/c/55182/9/tests/mountTests.py
File tests/mountTests.py:

Line 161: # TODO: Use libudev to wait for specific event
Line 162: with stopwatch("Wait for udev events"):
Line 163: udevadm.settle(5)
Line 164: 
Line 165: def test_is_mounted(self):
Lets check all 4 combinations (both spec and file match, only one match, none 
match).

And the case where the spec is a symbolic link (mounting local path).
Line 166: """
Line 167: This test verifies the correctness of a flow where we create 
a Mount
Line 168: object and then check if it's mounted by running 
Mount.isMounted on it.
Line 169: Specifficaly, if we normalized fs_spec the wrong way in


Line 169: Specifficaly, if we normalized fs_spec the wrong way in
Line 170: mount._parseFstabLine, this test would have failed since the 
read
Line 171: fs_spec (after normalizing) would have been "server:" instead 
of
Line 172: "server:/".
Line 173: """
Lets don't mention the implementation details in the tests.
Line 174: with fake_mounts([b"server:/ "
Line 175:   b"/rhev/data-center/mnt/server:_ "
Line 176:   b"nfs4 defaults 0 0"]):
Line 177: self.assertTrue(mount.Mount("server:/",


Line 175:   b"/rhev/data-center/mnt/server:_ "
Line 176:   b"nfs4 defaults 0 0"]):
Line 177: self.assertTrue(mount.Mount("server:/",
Line 178: 
"/rhev/data-center/mnt/server:_")
Line 179: .isMounted())
Please avoid long lines.

m = mount.Mount(...)
self.assertTrue(m.isMounted)
Line 180: 
Line 181: 
Line 182: class IterMountsPerfTests(TestCaseBase):
Line 183: line_fmt = ('%(fs_spec)s\t%(fs_file)s\t%(fs_vfstype)s'


-- 
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Refactor metadata operations

[alitke]

Adam Litke has posted comments on this change.

Change subject: Refactor metadata operations
..


Patch Set 4:

(5 comments)

https://gerrit.ovirt.org/#/c/52671/4/tests/storage_volume_metadata_test.py
File tests/storage_volume_metadata_test.py:

Line 35:vol_format=volume.type2name(volume.RAW_FORMAT),
Line 36:alloc_policy=volume.type2name(volume.SPARSE_VOL),
Line 37:parental_status=volume.type2name(volume.LEAF_VOL),
Line 38:disk_type=str(image.SYSTEM_DISK_TYPE),
Line 39:description="", legality=volume.LEGAL_VOL):
> Very hard to read like this.
Done
Line 40: return dict(
Line 41: sd_id=sd_id or str(uuid.uuid4()),
Line 42: img_id=img_id or str(uuid.uuid4()),
Line 43: parent_vol_id=parent_vol_id or str(uuid.uuid4()),


Line 42: img_id=img_id or str(uuid.uuid4()),
Line 43: parent_vol_id=parent_vol_id or str(uuid.uuid4()),
Line 44: size=size, vol_format=vol_format, alloc_policy=alloc_policy,
Line 45: parental_status=parental_status, disk_type=disk_type,
Line 46: description=description, legality=legality)
> Same.
Done
Line 47: 
Line 48: 
Line 49: @expandPermutations
Line 50: class VolumeMetadataTests(VdsmTestCase):


Line 71: self.assertEqual(expected, info)
Line 72: 
Line 73: def test_format(self):
Line 74: params = get_params()
Line 75: params['ctime'] = FAKE_TIME
> If you take my **kw suggestion, we can do now:
Done
Line 76: expected = textwrap.dedent("""\
Line 77: CTIME=%(ctime)s
Line 78: DESCRIPTION=%(description)s
Line 79: DISKTYPE=%(disk_type)s


Line 103: 
Line 104: @permutations([['size'], ['ctime'], ['mtime']])
Line 105: def test_int_params_str_raises(self, param):
Line 106: params = get_params()
Line 107: params[param] = 'not_an_int'
> If you take my **kw suggestion, we can do now:
Actually it's not as clean because param is a variable not the key name itself.


https://gerrit.ovirt.org/#/c/52671/4/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 183: self.parent_vol_id = parent_vol_id
Line 184: self.size = size
Line 185: self.vol_format = vol_format
Line 186: self.alloc_policy = alloc_policy
Line 187: self.parental_status = parental_status
> This kind of work for leaf or internal, but what about shared?
Shared is a different kind of parental status in my opinion.  To me, 
parental_status is far more descriptive than vol_type.
Line 188: self.disk_type = disk_type
Line 189: self.description = description
Line 190: self.legality = legality
Line 191: self.ctime = int(time.time()) if ctime is None else ctime


-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches