Change in vdsm[master]: net: lookup dhclient file

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: lookup dhclient file
..


Patch Set 7:

* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364081::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94d2c35bfa8acfc808d3852d41b45b7df38c2c41
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Pass scheduler to jobs.start

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Pass scheduler to jobs.start
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5004b49b992ae0f7171a0f0549465cc8782d05da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Move _run from sdm.base.Job to jobs.Job

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jobs: Move _run from sdm.base.Job to jobs.Job
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I194eb154d70e846b7ec5d462faa26b3aa35d2ff6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Add start/stop interface to jobs module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Add start/stop interface to jobs module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e67018fa45bcae9aedf74a9b4587230f6118024
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Autodelete

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jobs: Autodelete
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Pass scheduler to jobs.start

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: Pass scheduler to jobs.start
..

Pass scheduler to jobs.start

In a subsequent patch the jobs module will want to defer calls to delete by
using the program's scheduler instance.  Pass this scheduler into the jobs
module when calling start().

Change-Id: I5004b49b992ae0f7171a0f0549465cc8782d05da
Signed-off-by: Adam Litke 
---
M lib/vdsm/jobs.py
M tests/jobsTests.py
M vdsm/vdsm
3 files changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/62000/1

diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 8f44059..2669c85 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -27,6 +27,7 @@
 
 _lock = threading.Lock()
 _jobs = {}
+_scheduler = None
 
 
 class STATUS:
@@ -132,8 +133,9 @@
 return s.format(self=self, id=id(self))
 
 
-def start():
-pass
+def start(scheduler):
+global _scheduler
+_scheduler = scheduler
 
 
 def stop():
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index 5665d82..bc5baef 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -19,7 +19,7 @@
 
 import uuid
 
-from vdsm import jobs, response, exception
+from vdsm import exception, jobs, response, schedule
 
 from testlib import VdsmTestCase, expandPermutations, permutations
 
@@ -64,7 +64,8 @@
 TIMEOUT = 1
 
 def setUp(self):
-jobs.start()
+scheduler = schedule.Scheduler()
+jobs.start(scheduler)
 
 def tearDown(self):
 jobs.stop()
diff --git a/vdsm/vdsm b/vdsm/vdsm
index 9c6367a..0c78795 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -100,7 +100,7 @@
 scheduler = schedule.Scheduler(name="vdsm.Scheduler",
clock=utils.monotonic_time)
 scheduler.start()
-jobs.start()
+jobs.start(scheduler)
 
 from clientIF import clientIF  # must import after config is read
 cif = clientIF.getInstance(irs, log, scheduler)


-- 
To view, visit https://gerrit.ovirt.org/62000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5004b49b992ae0f7171a0f0549465cc8782d05da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Autodelete

[alitke]

Hello Nir Soffer,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/62002

to review the following change.

Change subject: jobs: Autodelete
..

jobs: Autodelete

For storage jobs we like to delete finished jobs automatically after some
delay, giving engine enough time to discover the job completion state in most
cases, and allowing easy inspection of job state.  The Job class implements now
both run() and abort(), managing the state changes and auto-deleting the job
when done. Subclasses should implement _run() and _abort().

To intergate with v2v code using old jobs framework, v2v code will have to use
_run() instead of run(). Subclass that want to enable autodelete must override
the autodelete class attribute and set it to True.

class AutodeletingJob(jobs.Job):
autodelete = True

This feature is not relevant now for v2v jobs since engine is deleting these
jobs.

Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add
Signed-off-by: Adam Litke 
Signed-off-by: Nir Soffer 
---
M lib/vdsm/config.py.in
M lib/vdsm/jobs.py
M tests/jobsTests.py
3 files changed, 67 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/62002/1

diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 9813fe5..50282e3 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -394,6 +394,14 @@
 '/sys/block//queue/discard_max_bytes is not zero.'),
 ]),
 
+# Section: [jobs]
+('jobs', [
+('autodelete_delay', '3600',
+'Automatically delete completed jobs from memory after the '
+'specified delay (in seconds).  When this value is negative '
+'autodelete will be disabled.'),
+]),
+
 # Section: [addresses]
 ('addresses', [
 
diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 21b6cb0..d6b3416 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -22,6 +22,7 @@
 import logging
 import threading
 
+from vdsm import config
 from vdsm import exception
 from vdsm import response
 
@@ -68,6 +69,10 @@
 
 class Job(object):
 _JOB_TYPE = None
+
+# If set to True, jobs of this class will be automatically deleted when
+# aborted or finished after a configurable delay.
+autodelete = False
 
 def __init__(self, job_id, description=''):
 self._id = job_id
@@ -118,11 +123,15 @@
 return self.status in (STATUS.PENDING, STATUS.RUNNING)
 
 def abort(self):
+# TODO: Don't abort if not pending and not running
 self._status = STATUS.ABORTED
 logging.info('Job %r aborting...', self._id)
 self._abort()
+if self.autodelete:
+self._autodelete()
 
 def run(self):
+# TODO: Don't run if aborted or not pending
 self._status = STATUS.RUNNING
 vars.job_id = self.id
 try:
@@ -138,6 +147,8 @@
 self._status = STATUS.DONE
 finally:
 vars.job_id = None
+if self.autodelete:
+self._autodelete()
 
 def _abort(self):
 """
@@ -151,6 +162,18 @@
 """
 raise NotImplementedError()
 
+def _autodelete(self):
+timeout = config.getint("jobs", "autodelete_delay")
+if timeout >= 0:
+_scheduler.schedule(timeout, self._delete)
+
+def _delete(self):
+logging.info("Autodeleting job %r", self.info())
+try:
+_delete(self._id)
+except Exception:
+logging.exception("Cannot delete job %s", self._id)
+
 def __repr__(self):
 s = "<{self.__class__.__name__} id={self.id} status={self.status} "
 if self.progress is not None:
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index dce6535..1781dba 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -17,12 +17,15 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
+import time
 import uuid
 
 from vdsm import exception, jobs, response, schedule
 from vdsm.storage.threadlocal import vars
 
+from monkeypatch import MonkeyPatchScope
 from testlib import VdsmTestCase, expandPermutations, permutations
+from testlib import make_config
 from testlib import wait_for_job
 
 
@@ -53,6 +56,10 @@
 _JOB_TYPE = 'bar'
 
 
+class AutodeleteJob(TestingJob):
+autodelete = True
+
+
 class ProgressingJob(jobs.Job):
 
 def __init__(self):
@@ -74,6 +81,7 @@
 
 def setUp(self):
 scheduler = schedule.Scheduler()
+scheduler.start()
 jobs.start(scheduler)
 
 def tearDown(self):
@@ -266,3 +274,31 @@
 self.run_job(job)
 self.assertEqual(jobs.STATUS.FAILED, job.status)
 self.assertIsInstance(job.error, exception.VdsmException)
+
+@permutations(((None, ), (Exception(),)))
+def test_autodelete_when_finished(self, error):
+cfg = make_config([('jobs', 'autodelete_delay', '0')])

Change in vdsm[master]: jobs: Move _run from sdm.base.Job to jobs.Job

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: jobs: Move _run from sdm.base.Job to jobs.Job
..

jobs: Move _run from sdm.base.Job to jobs.Job

The _run implementation in sdm.base.Job is generally useful.  It performs state
checking and error handling that can be applicable to all job types.  Move it
to job.Job.  The tests associated with this functionality need to move to
jobsTests.py which means we no longer need storage_sdm_api_test.py or
sdmtestlib.py

Change-Id: I194eb154d70e846b7ec5d462faa26b3aa35d2ff6
Signed-off-by: Adam Litke 
---
M lib/vdsm/jobs.py
M tests/Makefile.am
M tests/jobsTests.py
D tests/sdmtestlib.py
D tests/storage_sdm_api_test.py
M tests/storage_sdm_copy_data_test.py
M tests/storage_sdm_create_volume_test.py
M tests/testlib.py
M vdsm/storage/sdm/api/base.py
9 files changed, 73 insertions(+), 127 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/62001/1

diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 2669c85..21b6cb0 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -22,7 +22,10 @@
 import logging
 import threading
 
+from vdsm import exception
 from vdsm import response
+
+from vdsm.storage.threadlocal import vars
 
 
 _lock = threading.Lock()
@@ -119,12 +122,35 @@
 logging.info('Job %r aborting...', self._id)
 self._abort()
 
+def run(self):
+self._status = STATUS.RUNNING
+vars.job_id = self.id
+try:
+self._run()
+except Exception as e:
+logging.exception("Job (id=%s desc=%s) failed",
+  self.id, self.description)
+if not isinstance(e, exception.VdsmException):
+e = exception.GeneralException(str(e))
+self._error = e
+self._status = STATUS.FAILED
+else:
+self._status = STATUS.DONE
+finally:
+vars.job_id = None
+
 def _abort(self):
 """
 May be implemented by child class
 """
 raise AbortNotSupported()
 
+def _run(self):
+"""
+Must be implemented by child class
+"""
+raise NotImplementedError()
+
 def __repr__(self):
 s = "<{self.__class__.__name__} id={self.id} status={self.status} "
 if self.progress is not None:
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 467f2d4..f58a319 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -125,7 +125,6 @@
storage_hsm_test.py \
storage_monitor_test.py \
storage_rwlock_test.py \
-   storage_sdm_api_test.py \
storage_sdm_copy_data_test.py \
storage_sdm_create_volume_test.py \
storage_volume_artifacts_test.py \
@@ -226,7 +225,6 @@
storageServerTests.py \
storage_rwlock_test.py \
storage_blkdiscard_test.py \
-   storage_sdm_api_test.py \
storage_sdm_create_volume_test.py \
storage_sdm_copy_data_test.py \
storage_volume_artifacts_test.py \
@@ -338,7 +336,6 @@
fake-ssh-add \
fake-ssh-agent \
monkeypatch.py \
-   sdmtestlib.py \
storagefakelib.py \
storagetestlib.py \
testlib.py \
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index bc5baef..dce6535 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -20,20 +20,29 @@
 import uuid
 
 from vdsm import exception, jobs, response, schedule
+from vdsm.storage.threadlocal import vars
 
 from testlib import VdsmTestCase, expandPermutations, permutations
+from testlib import wait_for_job
 
 
 class TestingJob(jobs.Job):
 _JOB_TYPE = 'testing'
 
-def __init__(self, status=jobs.STATUS.PENDING):
+def __init__(self, status=jobs.STATUS.PENDING, exception=None):
 jobs.Job.__init__(self, str(uuid.uuid4()))
 self._aborted = False
 self._status = status
+self._exception = exception
 
 def _abort(self):
 self._aborted = True
+
+def _run(self):
+assert(self.status == jobs.STATUS.RUNNING)
+assert(vars.job_id == self.id)
+if self._exception:
+raise self._exception
 
 
 class FooJob(TestingJob):
@@ -69,6 +78,13 @@
 
 def tearDown(self):
 jobs.stop()
+
+def run_job(self, job):
+self.assertEqual(jobs.STATUS.PENDING, job.status)
+self.assertIsNone(getattr(vars, 'job_id', None))
+job.run()
+wait_for_job(job)
+self.assertIsNone(getattr(vars, 'job_id', None))
 
 def test_job_initial_state(self):
 job = TestingJob()
@@ -231,3 +247,22 @@
 job.progress = 32
 rep = repr(job)
 self.assertIn("progress=32%", rep)
+
+def test_running_states(self):
+job = TestingJob()
+self.run_job(job)
+self.assertEqual(jobs.STATUS.DONE, job.status)
+
+def test_default_exception(self):
+message = "testing failure"
+

Change in vdsm[master]: Add start/stop interface to jobs module

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: Add start/stop interface to jobs module
..

Add start/stop interface to jobs module

Add interfaces similar to virt.periodic and other subsystems for initializing a
module with parameters.  In a future patch we want to set the scheduler that
the jobs module will use.  The stop() interface will clear all jobs.

Change-Id: I5e67018fa45bcae9aedf74a9b4587230f6118024
Signed-off-by: Adam Litke 
---
M lib/vdsm/jobs.py
M tests/jobsTests.py
M vdsm/vdsm
3 files changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/61999/1

diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 232981c..8f44059 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -132,9 +132,11 @@
 return s.format(self=self, id=id(self))
 
 
-# This helper should only be called by test code.  Everything else should be
-# using the public APIs.
-def _clear():
+def start():
+pass
+
+
+def stop():
 with _lock:
 _jobs.clear()
 
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index cb1cb89..5665d82 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -64,7 +64,10 @@
 TIMEOUT = 1
 
 def setUp(self):
-jobs._clear()
+jobs.start()
+
+def tearDown(self):
+jobs.stop()
 
 def test_job_initial_state(self):
 job = TestingJob()
diff --git a/vdsm/vdsm b/vdsm/vdsm
index a6dc727..9c6367a 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -34,6 +34,7 @@
 from vdsm import constants
 from vdsm import dsaversion
 from vdsm import health
+from vdsm import jobs
 from vdsm import schedule
 from vdsm import utils
 from vdsm import libvirtconnection
@@ -99,6 +100,7 @@
 scheduler = schedule.Scheduler(name="vdsm.Scheduler",
clock=utils.monotonic_time)
 scheduler.start()
+jobs.start()
 
 from clientIF import clientIF  # must import after config is read
 cif = clientIF.getInstance(irs, log, scheduler)
@@ -119,6 +121,7 @@
 periodic.stop()
 cif.prepareForShutdown()
 scheduler.stop()
+jobs.stop()
 finally:
 libvirtconnection.stop_event_loop(wait=False)
 


-- 
To view, visit https://gerrit.ovirt.org/61999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e67018fa45bcae9aedf74a9b4587230f6118024
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: lookup dhclient file

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: lookup dhclient file
..


Patch Set 6:

* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#1364081::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94d2c35bfa8acfc808d3852d41b45b7df38c2c41
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: compat: py3: capture output of CPopen.communicate

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: compat: py3: capture output of CPopen.communicate
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/61393/2//COMMIT_MSG
Commit Message:

PS2, Line 12: stdin
you mean stdout/stderr


https://gerrit.ovirt.org/#/c/61393/2/lib/vdsm/compat.py
File lib/vdsm/compat.py:

Line 51: if 'stderr' not in kwargs:
Line 52: kwargs['stderr'] = subprocess.PIPE
Line 53: if 'stdout' not in kwargs:
Line 54: kwargs['stdout'] = subprocess.PIPE
Line 55: subprocess.Popen.__init__(self, args, **kwargs)
> please set explicitly stderr and stdout to PIPE in execCmd - that way only 
I aggree. This should be fixed in execCmd. And the few cases that use CPopen 
directly should be reviewed and fixed if necessary.

Otherwise we'll just end up reimplementing old CPopen behaviour over 
subprocess.Popen.
Line 56: 
Line 57: try:
Line 58: from contextlib import suppress
Line 59: suppress  # make pyflakes happy


-- 
To view, visit https://gerrit.ovirt.org/61393
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac9c1c1bd3ca1902103fac1f8675b7d42ca78a33
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: domainMonitor.getAllHostIds() API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: domainMonitor.getAllHostIds() API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1d89bb114eea58387cd88d9da3c27b69d6affa3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: export volume lease state in getVolumeInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: export volume lease state in getVolumeInfo
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61995
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If07ac876816b0a0ba61444fd94dc761508b09655
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add more stub methods for sanlock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add more stub methods for sanlock
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11dc27d1143b9caa2ce026fe2299f757fca0c71d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Move getVolumeLease to StorageDomainManifest
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60282
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60b35e9a41d73ecba741d6fb9f90cdaeb35b3e3b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Support volume leases

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Support volume leases
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60425
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb8711b9a88b8b57ed79cb3a246bbf3fcb9b2025
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Unify getVolumeLease signature

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Unify getVolumeLease signature
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85d3f754c266ce5296d2e52ec9bd544728723a94
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Raise if lock is used improperly

[automation]

gerrit-hooks has posted comments on this change.

Change subject: clusterlock: Raise if lock is used improperly
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia616070615a02fc86f85329e334d0af773e678b0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

[automation]

gerrit-hooks has posted comments on this change.

Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61153
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51f852103dcd90e1350b406d8bd053976e5820a1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Support for multiple leases

[automation]

gerrit-hooks has posted comments on this change.

Change subject: clusterlock: Support for multiple leases
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60422
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7903b13bd017e3da6762e8979f7f4dfc6520de9e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cluserlock: Use errno instead of os.errno
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15714261c3b25ccc90e98199225d61f134980788
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

[automation]

gerrit-hooks has posted comments on this change.

Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b604b9600db45ffa9092776c94f0278feb4746
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Fix double close on EINTR

[automation]

gerrit-hooks has posted comments on this change.

Change subject: clusterlock: Fix double close on EINTR
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cae714af9646e268f40ff1ff3cdb3f6b048e6e9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add more stub methods for sanlock

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: Add more stub methods for sanlock
..

tests: Add more stub methods for sanlock

When testing Volume Leases we make additional calls into sanlock.  Add stubs
for register, acquire, and release.  Use testlib.recorded so we can validate
that locks are acquired and released.

Change-Id: I11dc27d1143b9caa2ce026fe2299f757fca0c71d
Signed-off-by: Adam Litke 
---
M tests/testrunner.py
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/61996/1

diff --git a/tests/testrunner.py b/tests/testrunner.py
index 74e932b..9cde31f 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -52,9 +52,22 @@
 HOST_FAIL = 4
 HOST_DEAD = 5
 
+FAKE_SLKFD = 15
+
+def register(self):
+return self.FAKE_SLKFD
+
 def init_resource(self, sdUUID, volUUID, lockDisk):
 pass
 
+@testlib.recorded
+def acquire(self, lockspace, resource, lease, slkfd):
+pass
+
+@testlib.recorded
+def release(self, lockspace, resource, lease, slkfd):
+pass
+
 
 sys.modules.update({'sanlock': FakeSanlock()})
 


-- 
To view, visit https://gerrit.ovirt.org/61996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11dc27d1143b9caa2ce026fe2299f757fca0c71d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: osutils: Start the osutils module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: osutils: Start the osutils module
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia995c083f31c3489ced16265d459f30355f854b0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: domainMonitor.getAllHostIds() API

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: domainMonitor.getAllHostIds() API
..

storage: domainMonitor.getAllHostIds() API

SDM verbs require host_ids when working with Storage Domains.  The current API
for getting a host_id is domainMonitor.getHostId(sd_id) where the domainMonitor
is accessible to functions in the HSM class.  Therein lies the problem.  The
dictionary arguments passed to SDM verbs should be opaque to HSM because the
validation and business logic is implemented down in the SDM code.  To grant
SDM the ability to look up host_ids we could do one of the following:

 - Pass the domainMonitor instance to all SDM verbs and let them call its
   getHostId method when required, or
 - Pass a map of sd_id : host_id to SDM verbs and let them look it up

The second option avoids proliferating the domainMonitor and keeps the layers
more separated.  The second option is also easier to test.  This patch
implements it by adding a getAllHostIds() API to the domainMonitor which
returns this mapping.  To illustrate its usage, SDM.copy_volume is enhanced to
receive this map for eventual use when acquiring volume leases.

Change-Id: If1d89bb114eea58387cd88d9da3c27b69d6affa3
Signed-off-by: Adam Litke 
---
M tests/storage_sdm_copy_data_test.py
M vdsm/storage/hsm.py
M vdsm/storage/monitor.py
M vdsm/storage/sdm/api/copy_data.py
4 files changed, 26 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/61997/1

diff --git a/tests/storage_sdm_copy_data_test.py 
b/tests/storage_sdm_copy_data_test.py
index def8934..7d56c66 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -38,6 +38,8 @@
 
 import storage.sdm.api.copy_data
 
+HOST_ID = 1
+
 
 @expandPermutations
 class CopyDataTests(VdsmTestCase):
@@ -92,11 +94,13 @@
 self.assertRaises(ChainVerificationError,
   verify_qemu_chain, dst_chain)
 
+host_id_map = {dst_vol.sdUUID: HOST_ID}
 source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
   img_id=src_vol.imgUUID, vol_id=src_vol.volUUID)
 dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
 img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID)
-job = storage.sdm.api.copy_data.Job(job_id, None, source, dest)
+job = storage.sdm.api.copy_data.Job(job_id, host_id_map,
+source, dest)
 job.run()
 wait_for_job(job)
 
@@ -125,11 +129,13 @@
 job_id = str(uuid.uuid4())
 src_vol = src_chain[index]
 dst_vol = dst_chain[index]
+host_id_map = {dst_vol.sdUUID: HOST_ID}
 source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
   img_id=src_vol.imgUUID, vol_id=src_vol.volUUID)
 dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
 img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID)
-job = storage.sdm.api.copy_data.Job(job_id, None, source, dest)
+job = storage.sdm.api.copy_data.Job(job_id, host_id_map,
+source, dest)
 job.run()
 wait_for_job(job)
 verify_qemu_chain(dst_chain)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index cfa3118..533346b 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3521,5 +3521,6 @@
 
 @public
 def sdm_copy_data(self, job_id, source, destination):
-job = sdm.api.copy_data.Job(job_id, None, source, destination)
+host_id_map = self.domainMonitor.getAllHostIds()
+job = sdm.api.copy_data.Job(job_id, host_id_map, source, destination)
 self.sdm_schedule(job)
diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index 607f8af..c9232c7 100644
--- a/vdsm/storage/monitor.py
+++ b/vdsm/storage/monitor.py
@@ -214,6 +214,10 @@
 def getHostId(self, sdUUID):
 return self._monitors[sdUUID].hostId
 
+def getAllHostIds(self):
+return dict([(sd_id, self._monitors[sd_id].hostId)
+ for sd_id in self._monitors])
+
 def shutdown(self):
 """
 Called during shutdown to stop all monitors without releasing the host
diff --git a/vdsm/storage/sdm/api/copy_data.py 
b/vdsm/storage/sdm/api/copy_data.py
index aff0185..9bd169a 100644
--- a/vdsm/storage/sdm/api/copy_data.py
+++ b/vdsm/storage/sdm/api/copy_data.py
@@ -40,10 +40,10 @@
 """
 log = logging.getLogger('storage.sdm.copy_data')
 
-def __init__(self, job_id, host_id, source, destination):
-super(Job, self).__init__(job_id, 'copy_data', host_id)
-self._source = _create_endpoint(source)
-self._dest = _create_endpoint(destination)
+ 

Change in vdsm[master]: testlib: Use osutils.close_fd to avoid fd leaks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: testlib: Use osutils.close_fd to avoid fd leaks
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c8d2b7e29cc7df751d4fc1954ad3f3cae6917ce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: export volume lease state in getVolumeInfo

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: export volume lease state in getVolumeInfo
..

storage: export volume lease state in getVolumeInfo

In order to support an entity-based polling methodology (ie. in the new SDM
verbs) we must know whether a volume is currently locked by a long running
operation. Extend the getVolumeInfo API to report whether the lease is free or
held.  The API defines 'EXCLUSIVE' and 'SHARED' modes for future extensibility 
even though today we only support exclusive volume leases.

Change-Id: If07ac876816b0a0ba61444fd94dc761508b09655
Signed-off-by: Adam Litke 
---
M lib/api/vdsm-api.yml
M lib/vdsm/storage/constants.py
M vdsm/storage/volume.py
3 files changed, 30 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/61995/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index a99c488..5b0c385 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -6849,6 +6849,17 @@
 LEAF: The Volume is a writable leaf
 SHARED: The Volume is a shared template
 
+VolumeLeaseStatus: 
+added: '4.1'
+description: An enumeration of Volume Lease statuses
+name: VolumeLeaseStatus
+type: enum
+values:
+NONE: The Volume does not have an associated lease
+FREE: The lease is free
+EXCLUSIVE: The lease is held in exclusive mode
+SHARED: The lease is held in shared mode
+
 VolumeInfo: 
 added: '3.1'
 description: Information about a Volume.
@@ -6927,6 +6938,10 @@
 -   description: The Image associated with the Volume
 name: image
 type: *UUID
+
+-   description: The status of the Volume lease
+name: lease
+type: *VolumeLeaseStatus
 type: object
 
 VolumeSizeInfo: 
diff --git a/lib/vdsm/storage/constants.py b/lib/vdsm/storage/constants.py
index e49c88e..1446076 100644
--- a/lib/vdsm/storage/constants.py
+++ b/lib/vdsm/storage/constants.py
@@ -83,6 +83,12 @@
 RAW_FORMAT: qemuimg.FORMAT.RAW,
 }
 
+# Volume lease states
+LEASE_NONE = "NONE"# No lease
+LEASE_FREE = "FREE"# The lease is available
+LEASE_EXCLUSIVE = "EXCLUSIVE"  # The lease is held in exlusive mode
+LEASE_SHARED = "SHARED"# The lease is held in shared moce
+
 BLANK_UUID = "----"
 
 
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index b7a5608..285ed4d 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -181,6 +181,14 @@
 def isSparse(self):
 return self.getType() == sc.SPARSE_VOL
 
+def getLeaseStatus(self):
+sd_manifest = sdCache.produce_manifest(self.sdUUID)
+if not sd_manifest.hasVolumeLeases():
+return sc.LEASE_NONE
+ver, owners = sd_manifest.inquireVolumeLease(self.imgUUID,
+ self.volUUID)
+return sc.LEASE_EXCLUSIVE if owners else sc.LEASE_FREE
+
 def metadata2info(self, meta):
 return {
 "uuid": self.volUUID,
@@ -217,6 +225,7 @@
 info['apparentsize'] = str(vsize)
 info['truesize'] = str(avsize)
 info['status'] = "OK"
+info['lease'] = self.getLeaseStatus()
 except se.StorageException as e:
 self.log.debug("exception: %s:%s" % (str(e.message), str(e.value)))
 info['apparentsize'] = "0"


-- 
To view, visit https://gerrit.ovirt.org/61995
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If07ac876816b0a0ba61444fd94dc761508b09655
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: early IP+link setup

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: early IP+link setup
..


Patch Set 10: Code-Review-1

From CI logs:
./lib/vdsm/tool/restore_nets_init.py:53: undefined name 
'_convert_to_blocking_dhcp'

-- 
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: WIP vm: add utility to get sublogger

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP vm: add utility to get sublogger
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61992
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a378a36de93ebf2ab2b9dcf099deed44f7765b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: WIP: virt: migration: use the new VM sublogger

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: virt: migration: use the new VM sublogger
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2f9689fb5c0d0a80261aabed11eedbab358a491
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: switch to concurrent.thread()
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7918a6762b35000b02187a0356273e40bba57a8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: switch to concurrent.thread()
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61461
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad3bc231a710dcd11910f957bb5421eb8bb1ba5f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yajsonrpc: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: yajsonrpc: switch to concurrent.thread()
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42841c79e70755c0be5455949e33b84006930af0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: migration: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: migration: switch to concurrent.thread()
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23b98be05103529c827e6e21c0ed82cca58cb346
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: vm: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: vm: switch to concurrent.thread()
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61464
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I149315a1934a565012870c87a67f5a0185b9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: shorten executor thread system names

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibefc7d2c60d7b5d23739b129088f8e7f80514540
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: export volume lease state in getVolumeInfo

[alitke]

Adam Litke has restored this change.

Change subject: storage: export volume lease state in getVolumeInfo
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/38623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I55f062a4be15593fdc98518fd0a113976cbe0ae7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: build also vhostmd hook
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: build also vhostmd hook
..

automation: build also vhostmd hook

Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Signed-off-by: Sandro Bonazzola 
---
M automation/build-artifacts.sh
M automation/check-patch.sh
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/61984/1

diff --git a/automation/build-artifacts.sh b/automation/build-artifacts.sh
index 9576756..d81e2d7 100755
--- a/automation/build-artifacts.sh
+++ b/automation/build-artifacts.sh
@@ -10,7 +10,7 @@
 
 # autogen may already have been executed by check-patch.sh
 if [ ! -f Makefile ]; then
-  ./autogen.sh --system --enable-hooks
+  ./autogen.sh --system --enable-hooks --enable-vhostmd
 fi
 
 make
diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index 5f37792..383fbc3 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -7,7 +7,7 @@
 easy_install pip
 pip install -U nose==1.3.7 tox==2.1.1
 
-./autogen.sh --system --enable-hooks
+./autogen.sh --system --enable-hooks --enable-vhostmd
 
 debuginfo-install -y python
 


-- 
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: build also vhostmd hook

[automation]

gerrit-hooks has posted comments on this change.

Change subject: automation: build also vhostmd hook
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: shorten executor thread' system names

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: shorten executor thread' system  names
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibefc7d2c60d7b5d23739b129088f8e7f80514540
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: shorten executor thread' system names

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: jsonrpc: shorten executor thread' system  names
..

jsonrpc: shorten executor thread' system  names

We shorten the basename of the jsonrpc executor,
because the system has a hard limit of 15 ASCII
character per thread name.

The new name is less expressive, but leaves room
for the worker ID, which is an overall usability
improvement.

Before, it looked like

  jsonrpc.Executo

now it looks like

  jsonrpcex/0

Change-Id: Ibefc7d2c60d7b5d23739b129088f8e7f80514540
Signed-off-by: Francesco Romani 
---
M lib/vdsm/rpc/bindingjsonrpc.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/61978/1

diff --git a/lib/vdsm/rpc/bindingjsonrpc.py b/lib/vdsm/rpc/bindingjsonrpc.py
index 1f6f09a..1e55672 100644
--- a/lib/vdsm/rpc/bindingjsonrpc.py
+++ b/lib/vdsm/rpc/bindingjsonrpc.py
@@ -35,7 +35,7 @@
 log = logging.getLogger('BindingJsonRpc')
 
 def __init__(self, bridge, subs, timeout, scheduler, cif):
-self._executor = executor.Executor(name="jsonrpc.Executor",
+self._executor = executor.Executor(name="jsonrpcex",
workers_count=_THREADS,
max_tasks=_TASKS,
scheduler=scheduler)


-- 
To view, visit https://gerrit.ovirt.org/61978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibefc7d2c60d7b5d23739b129088f8e7f80514540
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: vmchannels: switch to concurrent.thread()

[vfeenstr]

Vinzenz Feenstra has posted comments on this change.

Change subject: virt: vmchannels: switch to concurrent.thread()
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/61460/3/lib/vdsm/virt/vmchannels.py
File lib/vdsm/virt/vmchannels.py:

Line 52: self._update_lock = threading.Lock()
Line 53: self._add_channels = {}
Line 54: self._del_channels = []
Line 55: self._timeout = None
Line 56: self._thread = concurrent.thread(self.run)
name='VM Channels Listener' missing
Line 57: 
Line 58: def start(self):
Line 59: self._thread.start()
Line 60: 


-- 
To view, visit https://gerrit.ovirt.org/61460
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d1c566c87ffac0cbfb5cc2b22587baa10760cf3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: vmchannels: switch to concurrent.thread()

[vfeenstr]

Vinzenz Feenstra has posted comments on this change.

Change subject: virt: vmchannels: switch to concurrent.thread()
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61460
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d1c566c87ffac0cbfb5cc2b22587baa10760cf3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: switch to concurrent.thread()
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7918a6762b35000b02187a0356273e40bba57a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: vmchannels: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: vmchannels: switch to concurrent.thread()
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61460
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d1c566c87ffac0cbfb5cc2b22587baa10760cf3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: migration: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: migration: switch to concurrent.thread()
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23b98be05103529c827e6e21c0ed82cca58cb346
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: switch to concurrent.thread()
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61461
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad3bc231a710dcd11910f957bb5421eb8bb1ba5f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: yajsonrpc: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: yajsonrpc: switch to concurrent.thread()
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42841c79e70755c0be5455949e33b84006930af0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: vm: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: vm: switch to concurrent.thread()
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61464
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I149315a1934a565012870c87a67f5a0185b9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: vmchannels: switch to concurrent.thread()

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: vmchannels: switch to concurrent.thread()
..


Patch Set 3: Verified+1

verified that the threads still runs as expected, and its name shows up as 
expected.

-- 
To view, visit https://gerrit.ovirt.org/61460
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d1c566c87ffac0cbfb5cc2b22587baa10760cf3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: set system name for threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: set system name for threads
..


Patch Set 4:

* #1141422::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1141422::OK, public bug
* Check Product::#1141422::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/55074
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I165f5ce9c86dad407d956a3b07e247431f2eed41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: set system name for threads

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lib: set system name for threads
..


Patch Set 3:

discard last comment, it applies to 61460

-- 
To view, visit https://gerrit.ovirt.org/55074
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I165f5ce9c86dad407d956a3b07e247431f2eed41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: set system name for threads

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lib: set system name for threads
..


Patch Set 3:

verified that the thread still works and has the expected name

-- 
To view, visit https://gerrit.ovirt.org/55074
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I165f5ce9c86dad407d956a3b07e247431f2eed41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: set system name for threads

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lib: set system name for threads
..


Patch Set 3: Verified+1

verified that the name still show up.

-- 
To view, visit https://gerrit.ovirt.org/55074
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I165f5ce9c86dad407d956a3b07e247431f2eed41
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: vmchannels: switch to concurrent.thread()

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: vmchannels: switch to concurrent.thread()
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/61460/2/lib/vdsm/virt/vmchannels.py
File lib/vdsm/virt/vmchannels.py:

Line 197: self._handle_timeouts()
Line 198: with self._update_lock:
Line 199: self._handle_unconnected()
Line 200: 
Line 201: def _run(self):
unneeded
Line 202: """ The listener thread's function. """
Line 203: self.log.debug("Starting VM channels listener thread.")
Line 204: self._quit = False
Line 205: try:


-- 
To view, visit https://gerrit.ovirt.org/61460
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d1c566c87ffac0cbfb5cc2b22587baa10760cf3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: migration: switch to concurrent.thread()

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: migration: switch to concurrent.thread()
..


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/61463/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 333: self.log.debug('Setting outgoing migration limit to %s',
Line 334:self._outgoingLimit)
Line 335: SourceThread.ongoingMigrations.bound = self._outgoingLimit
Line 336: 
Line 337: def _run(self):
maybe nice, but unneeded
Line 338: self._update_outgoing_limit()
Line 339: try:
Line 340: startTime = time.time()
Line 341: self._setupVdsConnection()


Line 562: def join(self):
Line 563: return self._thread.join()
Line 564: 
Line 565: @utils.traceback()
Line 566: def _run(self):
maybe nice, but unneeded
Line 567: self._vm.log.debug('migration downtime thread started (%i 
steps)',
Line 568:self._steps)
Line 569: 
Line 570: for downtime in self._downtimes:


Line 632: def enabled(self):
Line 633: return MonitorThread._MIGRATION_MONITOR_INTERVAL > 0
Line 634: 
Line 635: @utils.traceback()
Line 636: def _run(self):
maybe nice, but unneeded
Line 637: if self.enabled:
Line 638: self._vm.log.debug('starting migration monitor thread')
Line 639: try:
Line 640: self.monitor_migration()


-- 
To view, visit https://gerrit.ovirt.org/61463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23b98be05103529c827e6e21c0ed82cca58cb346
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: use 4.0 repos

[fromani]

Francesco Romani has posted comments on this change.

Change subject: automation: use 4.0 repos
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: automation: use 3.6 repos

[fromani]

Francesco Romani has posted comments on this change.

Change subject: automation: use 3.6 repos
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: Log detailed output of virt-v2v
..


Patch Set 10:

(2 comments)

https://gerrit.ovirt.org/#/c/59834/10/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

PS10, Line 658: def __len__(self):
  : return len(self._proc)
> why do we need this?
We don't. At least not any more. I forgot to remove it. Done.


https://gerrit.ovirt.org/#/c/59834/10/tests/fake-virt-v2v
File tests/fake-virt-v2v:

PS10, Line 90: # NOTE: Most verbose messages go to stderr, but some go to 
stdout. This can
 : # potentialy mess with out parsing routine.
> let's make sure we imitate this on our fake
added some traces to stderr too


-- 
To view, visit https://gerrit.ovirt.org/59834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Log detailed output of virt-v2v
..


Patch Set 12:

* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check Product::#1350465::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: automation: use 3.6 repos

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: use 3.6 repos
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: automation: use 3.6 repos

[automation]

gerrit-hooks has posted comments on this change.

Change subject: automation: use 3.6 repos
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches ovirt-4.0, master

-- 
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: automation: use 3.6 repos

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: use 3.6 repos
..

automation: use 3.6 repos

Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Signed-off-by: Sandro Bonazzola 
---
M automation/build-artifacts.repos.fc23
M automation/check-patch.repos.fc23
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/61970/1

diff --git a/automation/build-artifacts.repos.fc23 
b/automation/build-artifacts.repos.fc23
index c169fde..dc9188b 100644
--- a/automation/build-artifacts.repos.fc23
+++ b/automation/build-artifacts.repos.fc23
@@ -1 +1 @@
-ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
+ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro
diff --git a/automation/check-patch.repos.fc23 
b/automation/check-patch.repos.fc23
index c02ee8e..addb75e 100644
--- a/automation/check-patch.repos.fc23
+++ b/automation/check-patch.repos.fc23
@@ -1,2 +1,2 @@
-ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
-ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
+ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro
+ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-3.6-snapshot-static/rpm/$distro


-- 
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: use 4.0 repos

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: use 4.0 repos
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: use 4.0 repos

[automation]

gerrit-hooks has posted comments on this change.

Change subject: automation: use 4.0 repos
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/61969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: use 4.0 repos

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: use 4.0 repos
..

automation: use 4.0 repos

Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Signed-off-by: Sandro Bonazzola 
---
M automation/check-patch.repos.el7
M automation/check-patch.repos.fc23
M automation/reposync-config.repo.tpl
3 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/61969/1

diff --git a/automation/check-patch.repos.el7 b/automation/check-patch.repos.el7
index 0f388a1..614506b 100644
--- a/automation/check-patch.repos.el7
+++ b/automation/check-patch.repos.el7
@@ -1,5 +1,5 @@
 ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-4.0-snapshot/rpm/$distro
-ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
+ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-4.0-snapshot-static/rpm/$distro
 centos-glusterfs,http://mirror.centos.org/centos/7/storage/x86_64/gluster-3.7/
 
centos-ovirt40-candidate,http://cbs.centos.org/repos/virt7-ovirt-40-candidate/x86_64/os/
 ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
diff --git a/automation/check-patch.repos.fc23 
b/automation/check-patch.repos.fc23
index e516ed6..1cd44cf 100644
--- a/automation/check-patch.repos.fc23
+++ b/automation/check-patch.repos.fc23
@@ -1,4 +1,4 @@
 ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-4.0-snapshot/rpm/$distro
-ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
+ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-4.0-snapshot-static/rpm/$distro
 ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
 lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro
diff --git a/automation/reposync-config.repo.tpl 
b/automation/reposync-config.repo.tpl
index d6172d7..e7e40e9 100644
--- a/automation/reposync-config.repo.tpl
+++ b/automation/reposync-config.repo.tpl
@@ -7,16 +7,16 @@
 enabled=1
 gpgcheck=0
 
-[ovirt-master-snapshot-fc23]
+[ovirt-4.0-snapshot-fc23]
 name=oVirt Master Nightly Test Releases
-baseurl=http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/fc23/
+baseurl=http://resources.ovirt.org/pub/ovirt-4.0-snapshot/rpm/fc23/
 exclude=vdsm-* ovirt-node-* *-debuginfo ovirt-engine-appliance ovirt*engine* 
*win* *jboss*
 enabled=0
 gpgcheck=0
 
-[ovirt-master-snapshot-static-fc23]
+[ovirt-4.0-snapshot-static-fc23]
 name=oVirt Master Nightly Statics
-baseurl=http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/fc23/
+baseurl=http://resources.ovirt.org/pub/ovirt-4.0-snapshot-static/rpm/fc23/
 exclude=jasperreports-server ovirt-guest-tools-iso ovirt-engine-jboss-as 
*wildfly*
 enabled=0
 gpgcheck=0


-- 
To view, visit https://gerrit.ovirt.org/61969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org