Change in vdsm[ovirt-4.0]: net: Introduce nameservers (dns) network api

[obensass]

Ori Ben Sasson has posted comments on this change.

Change subject: net: Introduce nameservers (dns) network api
..


Patch Set 3: Verified+1

I checked that the adding a host which had static IP configuration to enp4s0 
and set DNS1=10.35.64.1 succeeded, nameservers didn't disappear. After adding 
host to engine and after reboot nameservers didn't disappear, ovirtmamt get the 
config of enp4s0 , same for vlan enp4s0.162

-- 
To view, visit https://gerrit.ovirt.org/61931
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9b0d0370951fe3985f61e550374eb63eb2cf161
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ori Ben Sasson 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: write out nameservers to ifcfg files

[obensass]

Ori Ben Sasson has posted comments on this change.

Change subject: net: write out nameservers to ifcfg files
..


Patch Set 2: -Verified

I did a mistake, i wanted to verified patch https://gerrit.ovirt.org/#/c/61931/

-- 
To view, visit https://gerrit.ovirt.org/62360
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie10ee7938b26a7f3b2b7be80bc1a2a83cd1c376c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ori Ben Sasson 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: Do not fail I/O after short outage

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: multipath: Do not fail I/O after short outage
..


Patch Set 1: Verified+1

Marking as verified based on Elad Ben Aharon's comment on 
https://bugzilla.redhat.com/show_bug.cgi?id=1335176#c31

-- 
To view, visit https://gerrit.ovirt.org/61281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6496dbdaafca6b110c952fcc5d51bf9ac04d49b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: write out nameservers to ifcfg files

[obensass]

Ori Ben Sasson has posted comments on this change.

Change subject: net: write out nameservers to ifcfg files
..


Patch Set 2: Verified+1

I checked that the adding a host which had static IP configuration to enp4s0 
and  set DNS1=10.35.64.1 succeeded, nameservers didn't disappear.
After adding host to engine and after reboot nameservers didn't disappear,
ovirtmamt get the config of enp4s0 ,
same for vlan enp4s0.162

-- 
To view, visit https://gerrit.ovirt.org/62360
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie10ee7938b26a7f3b2b7be80bc1a2a83cd1c376c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ori Ben Sasson 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Adding build-artifacts-manual.sh script

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches ovirt-4.0, master

-- 
To view, visit https://gerrit.ovirt.org/62557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3ea3ad68dbd5f822f6e57f4557b4670cb0e89c1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Adding build-artifacts-manual.sh script

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/62559
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70ed044ff9c8bc89c75e6c5e3669373468fadc1c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[eedri]

Eyal Edri has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 16: Verified+1

works for el7, disabled fc24 build for ppc64le due to weird aarch64 deps.
not sure we support fc24 also, but even if we do, we can add it later.

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.removePV API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.removePV API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62635
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b334262ea1a8a043c755b2b508197d328200f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.movePVData API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.movePVData API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6dce392d4cf157c42a47f70e972fa5d1d9dbdc2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.removePV API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.removePV API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b334262ea1a8a043c755b2b508197d328200f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.movePVData API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.movePVData API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62632
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6dce392d4cf157c42a47f70e972fa5d1d9dbdc2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.movePVData API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.movePVData API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6dce392d4cf157c42a47f70e972fa5d1d9dbdc2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the StorageDomain.removePV API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the StorageDomain.removePV API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62631
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b334262ea1a8a043c755b2b508197d328200f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[eedri]

Eyal Edri has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 16:

fc24 build fails on weird dependency to aarch64:
do we need to add aarch64 repo also? 

DEBUG util.py:421:  --> Processing Dependency: edk2-aarch64 for package: 
2:qemu-system-aarch64-2.6.0-4.fc24.ppc64le
DEBUG util.py:421:  ---> Package qemu-system-x86.ppc64le 2:2.6.0-4.fc24 will be 
installed
DEBUG util.py:421:  --> Processing Dependency: edk2-ovmf for package: 
2:qemu-system-x86-2.6.0-4.fc24.ppc64le
DEBUG util.py:421:  --> Finished Dependency Resolution
DEBUG util.py:421:  Error: Package: 2:qemu-system-aarch64-2.6.0-4.fc24.ppc64le 
(updates)
DEBUG util.py:421: Requires: edk2-aarch64
DEBUG util.py:421:   You could try using --skip-broken to work around the 
problem
DEBUG util.py:421:  Error: Package: 2:qemu-system-x86-2.6.0-4.fc24.ppc64le 
(updates)
DEBUG util.py:421: Requires: edk2-ovmf
DEBUG util.py:421:   You could try running: rpm -Va --nofiles --nodigest
DEBUG util.py:546:  Child return code was: 1

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 10:

Propagate review hook: Continuous Integration value inherited from patch 9

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 10: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 8

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: move to el7

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: move to el7
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: enabling ppc64le builds for vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: enabling ppc64le builds for vdsm
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 10:

(3 comments)

https://gerrit.ovirt.org/#/c/61186/10/tests/functional/Makefile.am
File tests/functional/Makefile.am:

Line 1: #
Line 2: # Copyright 2012-2013 Red Hat, Inc.
6 ?
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


https://gerrit.ovirt.org/#/c/61186/10/tests/functional/upgrade_vdsm_test.py
File tests/functional/upgrade_vdsm_test.py:

Line 21: from vdsm.tool.service import service_start, service_status, 
service_stop
Line 22: 
Line 23: from testlib import VdsmTestCase
Line 24: 
Line 25: repo_url = 'http://resources.ovirt.org/pub/ovirt-3.6/rpm/fc22/'
f22_ovirt36_repo.. already asked for renaming the global to something more 
meaningful
Line 26: 
Line 27: 
Line 28: def run_command(command, out_pipe=subprocess.PIPE, 
err_pipe=subprocess.PIPE):
Line 29: p = subprocess.Popen(command, stdout=out_pipe, stderr=err_pipe)


Line 48: class UpgradeTest(VdsmTestCase):
Line 49: def setUp(self):
Line 50: try:
Line 51: run_command(
Line 52: ['dnf', 'config-manager', '--set-disabled', 
'localsync'])
we need to change to yum if we want to run over centos
Line 53: except Exception as e:
Line 54: self.fail(e)
Line 55: 
Line 56: def service_up_test(self):


-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: functional tests: fix supervdsmServer test

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: functional tests: fix supervdsmServer test
..


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/61902/14/tests/functional/supervdsm_ping_call.py
File tests/functional/supervdsm_ping_call.py:

Line 23: from testlib import VdsmTestCase
Line 24: import testValidation
Line 25: from vdsm import supervdsm
Line 26: 
Line 27: from supervdsmFuncTests import dropPrivileges
arrange the imports .. first builtin, then vdsm's, then local test modules. and 
please add comment above the path.append that explains the need for it
Line 28: 
Line 29: 
Line 30: class TestPingCall(VdsmTestCase):
Line 31: @testValidation.ValidateRunningAsRoot


-- 
To view, visit https://gerrit.ovirt.org/61902
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: changing repos to be multi arch and support ppc64le

[automation]

gerrit-hooks has posted comments on this change.

Change subject: changing repos to be multi arch and support ppc64le
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: changing repos to be multi arch and support ppc64le

[automation]

gerrit-hooks has posted comments on this change.

Change subject: changing repos to be multi arch and support ppc64le
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Require python-blivet only with gluster-management build

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Require python-blivet only with gluster-management build
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62625
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ca94950e99717fe76072abdd712bcf23df4997
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hook-fcoe is arch depended

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: hook-fcoe is arch depended
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62454/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: hook-fcoe is arch depended
Line 8: 
Line 9: Using %post script in sub-package of arch depended package requires to
Line 10: declare the package as arch depended.
> could you explain this statement? (maybe with a url to Fedora standards)
I haven't find the reason. However in current f24 build in fedora I already 
removed the noarch to publish the build. 

As far as I checked manually anywhere you use %post script in spec you can't 
state noarch.
Line 11: 
Line 12: Change-Id: Ic59d7e29a75b13e1fc39b58a8d1252d6d2971058


-- 
To view, visit https://gerrit.ovirt.org/62454
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59d7e29a75b13e1fc39b58a8d1252d6d2971058
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: remove deprecated BuildRoot macro

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: remove deprecated BuildRoot macro
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb8398b42071f1fc2432f3bc0e754a27b0474b6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Revert "Remove __init__.py file from lib64 vdsm python 
directory"
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/62453/3//COMMIT_MSG
Commit Message:

PS3, Line 10: 17
> I suppose you mean 4.17 here.
because then vdsm-python will be arch depended , or we need to change the way 
we fix the upgrade issue


-- 
To view, visit https://gerrit.ovirt.org/62453
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Rename link_test module to netlink_test

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net test: Rename link_test module to netlink_test
..


net test: Rename link_test module to netlink_test

Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/62442
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M tests/Makefile.am
R tests/network/netlink_test.py
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/62442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Rename link_test module to netlink_test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: Rename link_test module to netlink_test
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Rename link_test module to netlink_test

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net test: Rename link_test module to netlink_test
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 1:

could you explain in the commit message what is build-artifacts-manual, and how 
is it different from the existing build-artifacts?

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Removed unused global

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Removed unused global
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d94b83e0ee9df0a8013580cb9cb8200ebdbc84b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Removed unused global

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Removed unused global
..


Removed unused global

Change-Id: I1d94b83e0ee9df0a8013580cb9cb8200ebdbc84b
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: https://gerrit.ovirt.org/62533
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d94b83e0ee9df0a8013580cb9cb8200ebdbc84b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm reg: clean up

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm reg: clean up
..


vdsm reg: clean up

Reviewing the vdsm spec found some remaining of vdsm reg
deprecated in early 3.6 versions.

Change-Id: I9f83b9e18ca24df4553e5b39e5b862759b9ac1b4
Signed-off-by: Douglas Schilling Landgraf 
Reviewed-on: https://gerrit.ovirt.org/62463
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Piotr Kliczewski 
Continuous-Integration: Jenkins CI
---
M build-aux/Makefile.subs
M configure.ac
M vdsm.spec.in
M vdsm/sos/vdsm.py.in
4 files changed, 1 insertion(+), 23 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Douglas Schilling Landgraf: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f83b9e18ca24df4553e5b39e5b862759b9ac1b4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm reg: clean up

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm reg: clean up
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f83b9e18ca24df4553e5b39e5b862759b9ac1b4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: Rename stats_flags variable

[ahino]

Ala Hino has abandoned this change.

Change subject: sampling: Rename stats_flags variable
..


Abandoned

Based on Francesco comment, this is by design

-- 
To view, visit https://gerrit.ovirt.org/60862
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaca95656038489f1ce4286e32ab819d78b9524dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: Rename stats_flags variable

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sampling: Rename stats_flags variable
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/60862
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaca95656038489f1ce4286e32ab819d78b9524dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: remove deprecated BuildRoot macro

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: remove deprecated BuildRoot macro
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb8398b42071f1fc2432f3bc0e754a27b0474b6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Vdsm supports only x86, ppc and ppc64

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Vdsm supports only x86, ppc and ppc64
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62465/2/vdsm.spec.in
File vdsm.spec.in:

Line 57: Url:http://www.ovirt.org/develop/developer-guide/vdsm/vdsm/
Line 58: Source0:%{vdsm_name}-%{version}.tar.gz
Line 59: BuildRoot:  
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Line 60: 
Line 61: ExclusiveArch: x86_64 ppc ppc64
I don't recall why, but before https://gerrit.ovirt.org/40738 we had a 
difference between Fedora and downstream. Can you explain why this difference 
is no longer needed?
Line 62: 
Line 63: %{!?_licensedir:%global license %%doc}
Line 64: 
Line 65: BuildRequires: cyrus-sasl-lib


-- 
To view, visit https://gerrit.ovirt.org/62465
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6f7a7d9aac6033b60fe592749bab2613b62466a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Revert "Remove __init__.py file from lib64 vdsm python 
directory"
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/62453/3//COMMIT_MSG
Commit Message:

PS3, Line 10: 17
I suppose you mean 4.17 here.

Why don't we want to support upgrade from ovirt-3.6 to ovirt-4.1?


-- 
To view, visit https://gerrit.ovirt.org/62453
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hook-fcoe is arch depended

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hook-fcoe is arch depended
..


Patch Set 2: Code-Review-1

(1 comment)

-1 for visibility

https://gerrit.ovirt.org/#/c/62454/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: hook-fcoe is arch depended
Line 8: 
Line 9: Using %post script in sub-package of arch depended package requires to
Line 10: declare the package as arch depended.
could you explain this statement? (maybe with a url to Fedora standards)

all we have is

 %post hook-fcoe
 %systemd_post lldpad.service
 %systemd_post fcoe.service

which seems noarch to me.
Line 11: 
Line 12: Change-Id: Ic59d7e29a75b13e1fc39b58a8d1252d6d2971058


-- 
To view, visit https://gerrit.ovirt.org/62454
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59d7e29a75b13e1fc39b58a8d1252d6d2971058
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net tests: add a 'status' parameter to SetupNetworksError

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net tests: add a 'status' parameter to SetupNetworksError
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62361
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ed5e4672474584364705f399493f357eba86586
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: don't accept nameservers on a non-default network

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: don't accept nameservers on a non-default network
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42a5d5a7aeb1169d510a3de8d04645efbab505e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: bridge-utils are required for tests

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
..


Patch Set 1:

Mh - Wasn't there some magiv to make it an automatic requirement if it was 
needed during builds?
Or was this just for -devel packages?

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: ifup: shorten name of the thread

[edwardh]

Edward Haas has posted comments on this change.

Change subject: network: ifup: shorten name of the thread
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/62617/1/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

PS1, Line 865: dhcpwait
This is in fact an 'ifup' command, not a dhcp one.
How about 'ifup/%s' or 'ifupwait/%s' ? I tend to favor the 1st.


-- 
To view, visit https://gerrit.ovirt.org/62617
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e59d97c16850521f4c45339677ee43c9f9bdd1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: dhclient: shorten name of the thread

[edwardh]

Edward Haas has posted comments on this change.

Change subject: network: dhclient: shorten name of the thread
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id413830191bebec9f17d8845e791ee66cdbcd2d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: network: switch to concurrent.thread()

[edwardh]

Edward Haas has posted comments on this change.

Change subject: network: switch to concurrent.thread()
..


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/61459/10/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 860: def _ifup(iface, cgroup=dhclient.DHCLIENT_CGROUP):
Line 861: if not iface.blockingdhcp and (iface.ipv4.bootproto == 'dhcp' or
Line 862:iface.ipv6.dhcpv6):
Line 863: # wait for dhcp in another thread, so vdsm won't get stuck 
(BZ#498940)
Line 864: t = concurrent.thread(_exec_ifup,
In both cases, the traceback logging is redundant and will probably just add 
noise. (We eventually call execCmd which logs an error anyway).
Is there an option to avoid the traceback logging?
Does it makes sense to add the wrapper if this is not needed?
Line 865:   name='ifup-waiting-on-dhcp',
Line 866:   args=(iface, cgroup))
Line 867: t.start()
Line 868: else:


-- 
To view, visit https://gerrit.ovirt.org/61459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7918a6762b35000b02187a0356273e40bba57a8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..

sos: replace dumpStorageTable with dump_volume_chains

dumpStorageTable is old and uses vdscli and has been replaced with
dump_volume_chains which uses jsonrpcvdscli

Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Signed-off-by: Irit Goihman 
---
M vdsm/sos/vdsm.py.in
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/62628/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 09ebb78..998c5a1 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -60,6 +60,7 @@
 
 config = _importVdsmPylibModule("vdsm.config").config
 jsonrpcvdscli = _importVdsmPylibModule("vdsm.jsonrpcvdscli")
+dump_volume_chains = _importVdsmPylibModule("vdsm.tool.dump_volume_chains")
 
 
 class vdsm(Plugin, RedHatPlugin):
@@ -151,12 +152,11 @@
 self.addObjectAsFile(
 cli.getSpmStatus(pool), "getSpmStatus " + pool)
 
-self.collectExtOutput(
-'/bin/su vdsm -s %s %s/dumpStorageTable.pyc' % (
-'@PYTHON@',
-'@VDSMDIR@',
-)
-)
+sd_uuid, = cli.getStorageDomainsList()["items"]
+
+self.addObjectAsFile(
+dump_volume_chains.dump_chains("dump-volume-chains", sd_uuid),
+"dump_volume_chains")
 
 def _addVdsmRunDir(self):
 """Add everything under /var/run/vdsm except possibly confidential


-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org