Change in vdsm[master]: tests: py3: decode byte string before checking for equality ...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: py3: decode byte string before checking for equality to 
string literal
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63194
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide782514cebbfbbeed112ec4ceef597614e6cbb7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: removing leftover whitespace (48d5e8)

[automation]

gerrit-hooks has posted comments on this change.

Change subject: removing leftover whitespace (48d5e8)
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63193
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d41040c82937f9691203c98cf83127a1223d5fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc.py py3 compliance via six

[automation]

gerrit-hooks has posted comments on this change.

Change subject: misc.py py3 compliance via six
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: make conf_persistence_test pass

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3: make conf_persistence_test pass
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: define __nonzero__ by means of __bool__

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3: define __nonzero__ by means of __bool__
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62771
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96beb2c794490def4ed904edd1c52ac2eb7b09a5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: make conf_persistence_test pass

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: py3: make conf_persistence_test pass
..


py3: make conf_persistence_test pass

In Python 3, an exception is not iterable, though its args are.

Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/62772
Continuous-Integration: Jenkins CI
Reviewed-by: Irit Goihman 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Petr Horáček 
Tested-by: Edward Haas 
---
M tests/Makefile.am
M tests/network/conf_persistence_test.py
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/62772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: make conf_persistence_test pass

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: py3: make conf_persistence_test pass
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: define __nonzero__ by means of __bool__

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: py3: define __nonzero__ by means of __bool__
..


py3: define __nonzero__ by means of __bool__

Python 3 has renamed __nonzero__ to __bool__. As long as we support both
language flavours, we should have both methods defined.

https://docs.python.org/3/library/2to3.html?highlight=__nonzero__#2to3fixer-nonzero

Signed-off-by: Dan Kenigsberg 
Change-Id: I96beb2c794490def4ed904edd1c52ac2eb7b09a5
Reviewed-on: https://gerrit.ovirt.org/62771
Continuous-Integration: Jenkins CI
Reviewed-by: Irit Goihman 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Petr Horáček 
Tested-by: Edward Haas 
---
M lib/vdsm/network/ip/address.py
M lib/vdsm/network/netconfpersistence.py
M lib/vdsm/virt/utils.py
3 files changed, 16 insertions(+), 4 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/62771
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96beb2c794490def4ed904edd1c52ac2eb7b09a5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: define __nonzero__ by means of __bool__

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: py3: define __nonzero__ by means of __bool__
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62771
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96beb2c794490def4ed904edd1c52ac2eb7b09a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: dhclient - address flush before starting and on shutdown
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63088/1/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:

Line 63: 
Line 64: def _dhclient(self):
Line 65: if iface.exists(self.iface):
Line 66: kill(self.iface, self.family)
Line 67: address.flush(self.iface, family=self.family)
> There is extra_ipv4_addrs hook.
For two static IP/s (or more), not for static+dynamic.
please check the history, the flush was there originally in kill (in its older 
name) and I am pretty sure dhclient will not support such a thing anyway.
Line 68: 
Line 69: cmd = [DHCLIENT_BINARY.cmd, '-%s' % self.family, '-1', '-pf',
Line 70:self.pidFile, '-lf', self.leaseFile]
Line 71: cmd += ['-R', DhcpClient.DEFAULT_REQ_OPTIONS]


-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: dhclient - address flush before starting and on shutdown
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63088/1/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:

Line 63: 
Line 64: def _dhclient(self):
Line 65: if iface.exists(self.iface):
Line 66: kill(self.iface, self.family)
Line 67: address.flush(self.iface, family=self.family)
> Is this a new feature? I am not aware of such an option.
There is extra_ipv4_addrs hook.
Line 68: 
Line 69: cmd = [DHCLIENT_BINARY.cmd, '-%s' % self.family, '-1', '-pf',
Line 70:self.pidFile, '-lf', self.leaseFile]
Line 71: cmd += ['-R', DhcpClient.DEFAULT_REQ_OPTIONS]


-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 9:

By unit tests and the new copy_data flow.

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Pass the real hostid to copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Pass the real hostid to copy_data
..


Patch Set 2: Verified+1

Verified by the new copy_data flow.

-- 
To view, visit https://gerrit.ovirt.org/62576
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I367576fca126be695d7617477f92110941620a3b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add GuardedLocks checking utility

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Add GuardedLocks checking utility
..


Patch Set 3: Verified+1

By unit tests.

-- 
To view, visit https://gerrit.ovirt.org/62467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a2b78e6439b75cd60f99f8e756306297cfe51c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 11: Verified+1

Verified with unit tests and as part of the new copy_data flow.

-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: dhclient - address flush before starting and on shutdown
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63088/1/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:

Line 63: 
Line 64: def _dhclient(self):
Line 65: if iface.exists(self.iface):
Line 66: kill(self.iface, self.family)
Line 67: address.flush(self.iface, family=self.family)
> but we can have static and dynamic IP at the same time.
Is this a new feature? I am not aware of such an option.
Line 68: 
Line 69: cmd = [DHCLIENT_BINARY.cmd, '-%s' % self.family, '-1', '-pf',
Line 70:self.pidFile, '-lf', self.leaseFile]
Line 71: cmd += ['-R', DhcpClient.DEFAULT_REQ_OPTIONS]


-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient kill - early exit if iface does not exists

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: dhclient kill - early exit if iface does not exists
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63087/1/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:

PS1, Line 63: if iface.exists(self.iface):
> this can be dropped now.
Unfortunately, we cannot drop it, see next patch.


-- 
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Introduce waitfor_link method and use it in iface module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Introduce waitfor_link method and use it in iface module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/63042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3808ef0b6dc086ad2770524f60c0d54b101d3383
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Introduce waitfor_link method and use it in iface module

[edwardh]

Edward Haas has abandoned this change.

Change subject: net: Introduce waitfor_link method and use it in iface module
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/63042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3808ef0b6dc086ad2770524f60c0d54b101d3383
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: v2v: filter out Xen VMs with block storage

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 1: Code-Review-1

I don't that this was merged to master, but I wonder if this is the right 
solution - don't we want to report the vms we cannot import to engine, so 
engine can display them as "vms that cannot be imported", e.g. grayed out?

Lets discuss this before we backport this to 4.0

-- 
To view, visit https://gerrit.ovirt.org/63133
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Require sanlock version handling EINTR

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require sanlock version handling EINTR
..


Patch Set 10: Verified-1

Package for rhel is not available yet.

-- 
To view, visit https://gerrit.ovirt.org/61200
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Remove unneeded multipath call

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 2:

multipathd receive event from udev, there is no need to call multipath directly 
(based on discussion with Ben Marzinsky, multipath developer).

-- 
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Remove unneeded multipath call

[ykaul]

Yaniv Kaul has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 2:

What causes a new device to be added to multipath though?

-- 
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Require sanlock version handling EINTR

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require sanlock version handling EINTR
..


Patch Set 10:

* #1356676::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356676::OK, public bug
* Check Product::#1356676::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61200
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hsm: add getVGInfo discard related fields

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hsm: add getVGInfo discard related fields
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hsm: add getVGInfo discard related fields

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: hsm: add getVGInfo discard related fields
..


hsm: add getVGInfo discard related fields

Patch I7ff47 added the fields discard_max_bytes and discard_zeroes_data
to getDeviceList.
This patch adds them also to getVGInfo.

Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Signed-off-by: Idan Shaby 
Reviewed-on: https://gerrit.ovirt.org/62800
Reviewed-by: Allon Mureinik 
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M vdsm/storage/hsm.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Remove unneeded multipath call

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hsm: add getVGInfo discard related fields

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: add getVGInfo discard related fields
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..


multipath: getDeviceDiscardMaxBytes return type

Since /sys/block/dm-X/queue/discard_max_bytes may return more than 4GB,
uint might not be enough.
Thus, this patch fixes the schema to state on a ulong instead of uint
value for discard_max_bytes.

Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Signed-off-by: Idan Shaby 
Reviewed-on: https://gerrit.ovirt.org/62799
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M lib/api/vdsm-api.yml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[automation]

gerrit-hooks has posted comments on this change.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: StorageDomain.getInfo - report metadata device for block sd

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: StorageDomain.getInfo - report metadata device for block sd
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63027/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 5654: 
Line 5655: -   defaultvalue: null
Line 5656: description: The device containing the domain metadata 
volume (optional)
Line 5657: name: metadatadevice
Line 5658: type: *UUID
GUID or path - should be same info returned in the pv list.
Line 5659: 
Line 5660: type: object
Line 5661: 
Line 5662: StorageDomainStatus: 


-- 
To view, visit https://gerrit.ovirt.org/63027
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32c847ae89b9f8f512c3dd8a0fff96fbc753ee5b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: switch type switch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: switch type switch
..


Patch Set 9:

* #1362399::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1362399::OK, public bug
* Check Product::#1362399::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/63119/1/lib/vdsm/network/kernelconfig.py
File lib/vdsm/network/kernelconfig.py:

PS1, Line 210: "mode"
we can use this patch to get a rid of nasty double quotes


PS1, Line 211: "mode"
'mode'


https://gerrit.ovirt.org/#/c/63119/1/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 162: with Transaction(in_rollback=in_rollback) as config:
Line 163: with ifacquire.Transaction(ovs_netinfo['networks']) as acq:
Line 164: with ovs_switch.create_setup(_ovs_info) as setup_ovs:
Line 165: setup_ovs.remove_nets(nets2remove)
Line 166: setup_bonds.remove_bonds()
We must update running config on each bond 'row' change, so we will be able to 
roll back.
Line 167: setup_bonds.edit_bonds()
Line 168: setup_bonds.add_bonds()
Line 169: setup_ovs.add_nets(nets2add)
Line 170: acq.acquire(setup_bonds.acquired_ifaces)


-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - Use request options to control the default r...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: dhclient - Use request options to control the default route
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63085/1/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:

PS1, Line 68: -R
> Tests do not pass on Fedora24?
I'd check for the dhclient version (find the border between old and new one) 
and use -R or --request-options.

I did not try it.


-- 
To view, visit https://gerrit.ovirt.org/63085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5698c905992028980f28ba3e9eecfcdfdbfd51ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - Use request options to control the default r...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: dhclient - Use request options to control the default route
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63085/1/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:

PS1, Line 68: -R
> dhclient has different API on fedora https://bugzilla.redhat.com/show_bug.c
Tests do not pass on Fedora24?
And I do not understand how this is a valid step to break compatibility.

How do you suggest solving this?


-- 
To view, visit https://gerrit.ovirt.org/63085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5698c905992028980f28ba3e9eecfcdfdbfd51ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: dhclient - address flush before starting and on shutdown
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/63088/1/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:

Line 63: 
Line 64: def _dhclient(self):
Line 65: if iface.exists(self.iface):
Line 66: kill(self.iface, self.family)
Line 67: address.flush(self.iface, family=self.family)
but we can have static and dynamic IP at the same time.
Line 68: 
Line 69: cmd = [DHCLIENT_BINARY.cmd, '-%s' % self.family, '-1', '-pf',
Line 70:self.pidFile, '-lf', self.leaseFile]
Line 71: cmd += ['-R', DhcpClient.DEFAULT_REQ_OPTIONS]


-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use is_link_up instead of operstate in netfunctestlib

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63090
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32f528ad3afc58394f4071465b321c0012841fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient kill - early exit if iface does not exists

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: dhclient kill - early exit if iface does not exists
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/63087/1/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:

PS1, Line 63: if iface.exists(self.iface):
this can be dropped now.


-- 
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Introduce iface.exists and start using it in ip.dhclient

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcece92726e7ef354b4792aee73bfc90fa5f3133
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - Use request options to control the default r...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: dhclient - Use request options to control the default route
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/63085/1/lib/vdsm/network/ip/dhclient.py
File lib/vdsm/network/ip/dhclient.py:

PS1, Line 68: -R
dhclient has different API on fedora 
https://bugzilla.redhat.com/show_bug.cgi?id=1372341


-- 
To view, visit https://gerrit.ovirt.org/63085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5698c905992028980f28ba3e9eecfcdfdbfd51ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: fix python-blivet dependency issue for python3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix python-blivet dependency issue for python3
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/56945
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad3d89d6daf667a9a505f27e7a1570a6e93696a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster: fix python-blivet dependency issue for python3

[rnachimu]

Ramesh N has abandoned this change.

Change subject: gluster: fix python-blivet dependency issue for python3
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/56945
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iad3d89d6daf667a9a505f27e7a1570a6e93696a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: make conf_persistence_test pass

[edwardh]

Edward Haas has posted comments on this change.

Change subject: py3: make conf_persistence_test pass
..


Patch Set 3: Verified+1

Passing unit and functional tests.

-- 
To view, visit https://gerrit.ovirt.org/62772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I330bd494be78bd9a78db5ac65b1a350df26b8911
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3: define __nonzero__ by means of __bool__

[edwardh]

Edward Haas has posted comments on this change.

Change subject: py3: define __nonzero__ by means of __bool__
..


Patch Set 1: Verified+1

Passing unit and functional tests.

-- 
To view, visit https://gerrit.ovirt.org/62771
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96beb2c794490def4ed904edd1c52ac2eb7b09a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: For IP-less networks, wait for link-up on ifup execution

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: For IP-less networks, wait for link-up on ifup execution
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63043
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id489fb3b021e6b0658691b1a9a6d6652e75c22ad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: early IP+link setup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: early IP+link setup
..


Patch Set 20:

* #1364087::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364087::OK, public bug
* Check Product::#1364087::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: early IP+link setup

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: early IP+link setup
..


Patch Set 20: Verified+1

(2 comments)

OVS networking was restored by vdsm-network-init.service

https://gerrit.ovirt.org/#/c/60371/19/lib/vdsm/network/netrestore.py
File lib/vdsm/network/netrestore.py:

Line 23: import os
Line 24: 
Line 25: import six
Line 26: 
Line 27: from vdsm.config import config
> Needs to be done though 'compat'.
Done
Line 28: from vdsm.constants import P_VDSM_RUN
Line 29: from vdsm.utils import tobool
Line 30: 
Line 31: from . import netswitch


Line 58: 
Line 59: for net, attrs in six.iteritems(nets):
Line 60: try:
Line 61: netswitch.setup_ipv6autoconf({net: attrs})
Line 62: except Exception:
> Why not just do it directly like this:
Done
Line 63: logging.exception('IPv6autoconf for {} 
failed.'.format(net))
Line 64: 
Line 65: for net, attrs in six.iteritems(nets):
Line 66: try:


-- 
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: mom: create the socket under tmpdir

[snaftaly]

Sharon Naftaly has posted comments on this change.

Change subject: tests: mom: create the socket under tmpdir
..


Patch Set 1: Verified+1

I encountered this issue when running the build-artifacts-manual 4.0 jobs. This 
patch solved the problem.

-- 
To view, visit https://gerrit.ovirt.org/63129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Relocating wait-for-event under its own module.

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Relocating wait-for-event under its own module.
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62876
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99c93083fd4db7a2d20518c06e70da5bc333a71
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Adding the 'link' package with an iface module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Adding the 'link' package with an iface module
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Remove unneeded multipath call

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 2:

* #1303578::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1303578::OK, public bug
* Check Product::#1303578::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Remove unneeded multipath call

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59865/1//COMMIT_MSG
Commit Message:

Line 9: As part of multipath rescan, we call iscsi and hba rescan.
Line 10: These operations are sufficient to discover new devices and
Line 11: detect changes in size.
Line 12: Therefore, the multipath call is not needed and can be removed
Line 13: improving the overall performance of GetDeviceList verb.
> Add note that this operation is risky and may get stuck.
Done
Line 14: 
Line 15: Detailed profiling :
Line 16: time filename:lineno(function)
Line 17: 3.178 |hsm.py:1948(HSM._getDeviceList)


-- 
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: v2v: filter out Xen VMs with block storage

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63133
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: v2v: filter out Xen VMs with block storage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 1:

* #1365411::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1365411::OK, public bug
* Check Product::#1365411::OK, Correct classification oVirt
* Check TM::#1365411::OK, correct target milestone ovirt-4.0.4
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63133
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: v2v: filter out Xen VMs with block storage

[shavivi]

Hello Francesco Romani, Tomas Golembiovsky,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/63133

to review the following change.

Change subject: v2v: filter out Xen VMs with block storage
..

v2v: filter out Xen VMs with block storage

virt-v2v is not support importing Xen VMs with block storage domain.
No need to return these VMs via get_external_vms verb

Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Bug-Url: https://bugzilla.redhat.com/1365411
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/62368
Reviewed-by: Tomas Golembiovsky 
Tested-by: Shahar Havivi 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M lib/vdsm/v2v.py
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/63133/1

diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index 62ccd3c..057704d 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -861,6 +861,8 @@
 except ET.ParseError as e:
 logging.error('error parsing domain xml: %s', e)
 return
+if not _block_disk_supported(conn, root):
+return
 try:
 _add_general_info(root, params)
 except InvalidVMConfiguration as e:
@@ -876,6 +878,16 @@
 vms.append(params)
 
 
+def _block_disk_supported(conn, root):
+'''
+Currently we do not support importing VMs with block device from
+Xen on Rhel 5.x
+'''
+if conn.getType() == 'Xen':
+return len(root.findall('.//disk[@type="block"]')) == 0
+return True
+
+
 def _add_vm_info(vm, params):
 params['vmName'] = vm.name()
 # TODO: use new API: vm.state()[0] == libvirt.VIR_DOMAIN_SHUTOFF


-- 
To view, visit https://gerrit.ovirt.org/63133
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Tomas Golembiovsky 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Remove unneeded multipath call

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/59865/1//COMMIT_MSG
Commit Message:

Line 9: As part of multipath rescan, we call iscsi and hba rescan.
Line 10: These operations are sufficient to discover new devices and
Line 11: detect changes in size.
Line 12: Therefore, the multipath call is not needed and can be removed
Line 13: improving the overall performance of GetDeviceList verb.
Add note that this operation is risky and may get stuck.
Line 14: 
Line 15: Detailed profiling :
Line 16: time filename:lineno(function)
Line 17: 3.178 |hsm.py:1948(HSM._getDeviceList)


-- 
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: filter out Xen VMs with block storage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: filter out Xen VMs with block storage
..


Patch Set 4:

* #1365411::Update tracker: OK
* Set MODIFIED::bug 1365411#1365411::IGNORE, skipping for branch 'master'

-- 
To view, visit https://gerrit.ovirt.org/62368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: filter out Xen VMs with block storage

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: v2v: filter out Xen VMs with block storage
..


v2v: filter out Xen VMs with block storage

virt-v2v is not support importing Xen VMs with block storage domain.
No need to return these VMs via get_external_vms verb

Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Bug-Url: https://bugzilla.redhat.com/1365411
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/62368
Reviewed-by: Tomas Golembiovsky 
Tested-by: Shahar Havivi 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M lib/vdsm/v2v.py
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Shahar Havivi: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Tomas Golembiovsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/62368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: mom: create the socket under tmpdir

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: mom: create the socket under tmpdir
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/63129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: mom: create the socket under tmpdir

[snaftaly]

Hello Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/63129

to review the following change.

Change subject: tests: mom: create the socket under tmpdir
..

tests: mom: create the socket under tmpdir

Some tests may fail under automation if Vdsm
is built and its test are run under a too nested
directory.
This because the absolute path of the UNIX domain
socket becomes too long.

To fix this, we create the socket under a temporary
directory.
This also makes cleanup a little easier.

Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Signed-off-by: Francesco Romani 
---
M tests/momTests.py
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/63129/1

diff --git a/tests/momTests.py b/tests/momTests.py
index 764aa57..c24f364 100644
--- a/tests/momTests.py
+++ b/tests/momTests.py
@@ -19,6 +19,8 @@
 
 from unittest import TestCase
 import logging
+import shutil
+import tempfile
 import threading
 from vdsm.define import Mbytes
 from vdsm.momIF import MomClient
@@ -30,7 +32,7 @@
 from vdsm import cpuarch
 
 MOM_CONF = "/dev/null"
-MOM_PORT = os.path.join(os.path.dirname(__file__), "test_mom_vdsm.sock")
+MOM_SOCK = "test_mom_vdsm.sock"
 
 
 class DummyMomApi(object):
@@ -67,12 +69,20 @@
 # added during the tests.
 @monkeypatch.MonkeyClass(logging.getLogger().manager, "loggerDict", {})
 class MomPolicyTests(TestCase):
+
+_TMP_DIR = tempfile.gettempdir()
+
 def setUp(self):
+self._tmp_dir = tempfile.mkdtemp(dir=self._TMP_DIR)
 self.config_overrides = configparser.SafeConfigParser()
 self.config_overrides.add_section("logging")
 self.config_overrides.set("logging", "log", "stdio")
 self.config_overrides.add_section("main")
-self.config_overrides.set("main", "rpc-port", str(MOM_PORT))
+self.config_overrides.set("main", "rpc-port",
+  os.path.join(self._tmp_dir, MOM_SOCK))
+
+def tearDown(self):
+shutil.rmtree(self._tmp_dir)
 
 def _getMomClient(self):
 return MomClient(MOM_CONF, self.config_overrides)


-- 
To view, visit https://gerrit.ovirt.org/63129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Method not found should return proper code

[sabose]

Sahina Bose has posted comments on this change.

Change subject: Method not found should return proper code
..


Patch Set 1: Verified+1

Thanks, Piotr!

-- 
To view, visit https://gerrit.ovirt.org/63120
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b3e1360303bca7ae3c30846ad46fec1fadac7fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..


Patch Set 3: Verified+1

(3 comments)

https://gerrit.ovirt.org/#/c/62799/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Since /sys/block/dm-X/queue/discard_max_bytes may return more than 4GB,
Line 10: uint might not be enough.
Line 11: Thus, this patch fixes the schema to state on a ulong instead of uint
Line 12: value for discard_max_bytes.
> This should only fix the schema, the code is already returning long value w
Done
Line 13: 
Line 14: Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4


https://gerrit.ovirt.org/#/c/62799/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 220: -   description: The maximal number of bytes that can be 
trimmed or
Line 221: unmapped in a single discard operation. 0 means that 
the device
Line 222: does not support discard functionality.
Line 223: name: discard_max_bytes
Line 224: type: ulong
> Should be ulong, unless you think the old type should have been int.
Done
Line 225: 
Line 226: -   description: Indicates whether or not the device 
deterministically
Line 227: returns zeroes when a discarded area is read.
Line 228: 1 means it does, 0 mesans that the result is 
undefined (can be


https://gerrit.ovirt.org/#/c/62799/2/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 185: def getScsiSerial(physdev):
Line 186: blkdev = os.path.join("/dev", physdev)
Line 187: cmd = [_SCSI_ID.cmd,
Line 188:"--page=0x80",
Line 189:"--whitelisted",
> int() and long() are the same since Python 2.4, and there is no need to cre
Done, thanks for the explanation, Nir.
Line 190:"--export",
Line 191:"--replace-whitespace",
Line 192:"--device=" + blkdev]
Line 193: (rc, out, err) = misc.execCmd(cmd)


-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: multipath: getDeviceDiscardMaxBytes return type

[automation]

gerrit-hooks has posted comments on this change.

Change subject: multipath: getDeviceDiscardMaxBytes return type
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc45c708df0e93ddf94165eb6f3e3630ce8430a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hsm: add getVGInfo discard related fields

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: add getVGInfo discard related fields
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cdb535923f6f5ffc961750271e8cde823ed835a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Method not found should return proper code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Method not found should return proper code
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63120
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b3e1360303bca7ae3c30846ad46fec1fadac7fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Method not found should return proper code

[piotr . kliczewski]

Piotr Kliczewski has uploaded a new change for review.

Change subject: Method not found should return proper code
..

Method not found should return proper code

When a method is not found we should return -32601 code.


Change-Id: I9b3e1360303bca7ae3c30846ad46fec1fadac7fb
Signed-off-by: Piotr Kliczewski 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/63120/1

diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index bd180e0..0bd1aaa 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -110,7 +110,7 @@
 try:
 className, methodName = method.split('.', 1)
 self._schema.get_method(vdsmapi.MethodRep(className, methodName))
-except (KeyError, ValueError):
+except (vdsmapi.MethodNotFound, ValueError):
 raise yajsonrpc.JsonRpcMethodNotFoundError(method)
 return partial(self._dynamicMethod, className, methodName)
 


-- 
To view, visit https://gerrit.ovirt.org/63120
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b3e1360303bca7ae3c30846ad46fec1fadac7fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Use Linux bonds with OVS networks
..

net: Use Linux bonds with OVS networks

OVS bonds have several major limitations which brings us to use Linux
bonds instead.
Limitations with OVS bonds: Unable to apply QoS rules and does not
support all bond mode options (compared to the Linux bond).

The OVS bond implementation is kept for potential future use, but it
will not be included in the avaliable setup flow.

Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/kernelconfig.py
M lib/vdsm/network/netswitch.py
M lib/vdsm/network/ovs/info.py
M lib/vdsm/network/ovs/switch.py
M tests/network/ovs_info_test.py
M tests/network/ovs_switch_test.py
M tests/network/ovs_test.py
7 files changed, 74 insertions(+), 176 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/63119/1

diff --git a/lib/vdsm/network/kernelconfig.py b/lib/vdsm/network/kernelconfig.py
index b20bdf1..17c15c4 100644
--- a/lib/vdsm/network/kernelconfig.py
+++ b/lib/vdsm/network/kernelconfig.py
@@ -208,11 +208,7 @@
 normalized_opts = _parse_bond_options(
 bond_attr.get('options'))
 if "mode" not in normalized_opts:
-if bond_attr.get('switch') == 'ovs':
-# Mode 0 is not available in OVS.
-normalized_opts["mode"] = '1'
-else:
-normalized_opts["mode"] = '0'
+normalized_opts["mode"] = '0'
 normalized_opts.pop('custom', None)
 bond_attr['options'] = bonding.bondOptsForIfcfg(normalized_opts)
 # before d18e2f10 bondingOptions were also part of networks, so in case
diff --git a/lib/vdsm/network/netswitch.py b/lib/vdsm/network/netswitch.py
index 0d23354..8e7a8c8 100644
--- a/lib/vdsm/network/netswitch.py
+++ b/lib/vdsm/network/netswitch.py
@@ -26,6 +26,7 @@
 from vdsm.network.ip import dhclient
 from vdsm.network.libvirt import networks as libvirt_nets
 from vdsm.network.link import iface
+from vdsm.network.link.setup import SetupBonds
 from vdsm.network.netinfo.cache import (libvirtNets2vdsm, get as netinfo_get,
 CachingNetInfo)
 from vdsm.tool.service import service_status
@@ -144,11 +145,14 @@
 def _setup_ovs(networks, bondings, options, in_rollback):
 _ovs_info = ovs_info.OvsInfo()
 ovs_netinfo = ovs_info.create_netinfo(_ovs_info)
+_netinfo = netinfo()
 
 nets2add, nets2edit, nets2remove = _split_setup_actions(
 networks, ovs_netinfo['networks'])
 bonds2add, bonds2edit, bonds2remove = _split_setup_actions(
-bondings, ovs_netinfo['bondings'])
+bondings, _netinfo['bondings'])
+
+setup_bonds = SetupBonds(bonds2add, bonds2edit, bonds2remove)
 
 # TODO: If a nework is to be edited, we remove it and recreate again.
 # We should implement editation.
@@ -157,13 +161,14 @@
 
 with Transaction(in_rollback=in_rollback) as config:
 with ifacquire.Transaction(ovs_netinfo['networks']) as acq:
-with ovs_switch.create_setup(_ovs_info) as s:
-s.remove_nets(nets2remove)
-s.remove_bonds(bonds2remove)
-s.edit_bonds(bonds2edit)
-s.add_bonds(bonds2add)
-s.add_nets(nets2add)
-acq.acquire(s.acquired_ifaces)
+with ovs_switch.create_setup(_ovs_info) as setup_ovs:
+setup_ovs.remove_nets(nets2remove)
+setup_bonds.remove_bonds()
+setup_bonds.edit_bonds()
+setup_bonds.add_bonds()
+setup_ovs.add_nets(nets2add)
+acq.acquire(setup_bonds.acquired_ifaces)
+acq.acquire(setup_ovs.acquired_ifaces)
 _update_running_config(networks, bondings, config)
 ovs_switch.cleanup()
 _setup_ipv6autoconf(networks)
@@ -200,6 +205,9 @@
 _drop_dhcp_config(net)
 
 for net, attrs in six.iteritems(nets2add):
+sb = attrs.get('bonding') or attrs.get('nic')
+address.disable_ipv6(sb)
+
 _set_static_ip_config(net, attrs)
 _set_dhcp_config(net, attrs)
 
@@ -271,11 +279,17 @@
 net for net, attrs in six.iteritems(running_networks)
 if attrs['switch'] == 'ovs' and not attrs['bridged']]
 ovs_info.fake_bridgeless(
-ovs_netinfo, _netinfo['nics'], bridgeless_ovs_nets)
+ovs_netinfo, _netinfo, bridgeless_ovs_nets)
 
 for type, entries in six.iteritems(ovs_netinfo):
 _netinfo[type].update(entries)
 
+# Fake bond type to satisfy Engine.
+for bond, bond_attrs in six.iteritems(RunningConfig().bonds):
+if (bond_attrs['switch'] == ovs_switch.SWITCH_TYPE and
+bond in _netinfo['bondings']):
+_netinfo['bondings'][bond]['switch'] 

Change in vdsm[master]: storage: export volume lease state in getVolumeInfo

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: export volume lease state in getVolumeInfo
..


storage: export volume lease state in getVolumeInfo

In order to support an entity-based polling methodology (ie. in the new
SDM verbs) we must know whether a volume is currently locked by a long
running operation. Extend the getVolumeInfo API to report whether the
lease is free or held.  If a storage domain does not support volume
leases then the status will be 'UNSUPPORTED'.  The API defines
'EXCLUSIVE' and 'SHARED' modes for future extensibility even though
today we only support exclusive volume leases.  Free leases will report
'FREE'.

Change-Id: If07ac876816b0a0ba61444fd94dc761508b09655
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/61995
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M lib/api/vdsm-api.yml
M lib/vdsm/storage/constants.py
M vdsm/storage/volume.py
3 files changed, 30 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/61995
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If07ac876816b0a0ba61444fd94dc761508b09655
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: export volume lease state in getVolumeInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: export volume lease state in getVolumeInfo
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/61995
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If07ac876816b0a0ba61444fd94dc761508b09655
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: Sortable ResourceManager lock namespaces
..


storage: Sortable ResourceManager lock namespaces

In order to simplify correct locking order, change the namespace constants so
that they sort in the order that they should be taken.

Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/61436
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/storage/constants.py
M tests/storage_sdm_create_volume_test.py
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/sd.py
M vdsm/storage/sdm/api/create_volume.py
M vdsm/storage/sp.py
M vdsm/storage/volume.py
11 files changed, 51 insertions(+), 50 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org