Change in vdsm[master]: volume: Add compat level to volume's info

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: volume: Add compat level to volume's info
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65867
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01646173a2b62dabb965cd79e393ca65e724f3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume: Add compat level to volume's info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume: Add compat level to volume's info
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65867
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01646173a2b62dabb965cd79e393ca65e724f3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume: Add compat level to volume's info

[mlipchuk]

Maor Lipchuk has uploaded a new change for review.

Change subject: volume: Add compat level to volume's info
..

volume: Add compat level to volume's info

Change-Id: Ic01646173a2b62dabb965cd79e393ca65e724f3b
Signed-off-by: Maor Lipchuk 
---
M vdsm/storage/volume.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/65867/1

diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index d7d65d7..73c14c9 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -231,6 +231,8 @@
 info['truesize'] = str(avsize)
 info['status'] = "OK"
 info['lease'] = self.getLeaseStatus()
+domain = sdCache.produce(self.sdUUID)
+info['qcow2compat'] = domain.qcow2_compat()
 except se.StorageException as e:
 self.log.debug("exception: %s:%s" % (str(e.message), str(e.value)))
 info['apparentsize'] = "0"


-- 
To view, visit https://gerrit.ovirt.org/65867
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic01646173a2b62dabb965cd79e393ca65e724f3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: broker cleanup

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: broker cleanup
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65681
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I972268a72f51975eb78c6bac926e29ac53178dca
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 22: Code-Review-1

this one should be squeezed with https://gerrit.ovirt.org/#/c/64502

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 13: Code-Review+1

you can split the patch and fix the commit msg. but generally for me this patch 
is fine.

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 14: Code-Review+1

lets monitor the sos paths collection in separate bugzilla and add it after 
splitting the constant module (other bugzilla to monitor. please open the two)

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: introduce new client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpc: introduce new client
..


Patch Set 13: Verified+1

(3 comments)

https://gerrit.ovirt.org/#/c/64502/10/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 108: ServerError will be raised if the command encountered execution error:
Line 109: 
Line 110: vdsm.client.ServerError: Vdsm request failed
Line 111: (code=4, message=Virtual machine already exists)
Line 112: 
> you repeat the errors description twice (here and in the call method). I gu
It is intentional. This description is the more informative one, with 
guidelines for developers who are willing to use this module, and the 
description in the call method is part of the method description. The next 
update should be responsible and update both places.
Line 113: 
Line 114: Please note that if the client isn't a context manager, it should be
Line 115: closed at the end of the run:
Line 116: 


Line 192: if args is None:
Line 193: args = {}
Line 194: req = yajsonrpc.JsonRpcRequest(method, args, 
reqId=str(uuid.uuid4()))
Line 195: try:
Line 196: responses = self._client.call(req, timeout=timeout)
> why not just have it as default values? like "def call(self, method, args={
Done
Line 197: except EnvironmentError as e:
Line 198: raise ClientError(e)
Line 199: 
Line 200: if not responses:


Line 224: if t is None:
Line 225: raise
Line 226
Line 227
Line 228
> why is this type check ?
__exit__ should only raise exception if it was raised during exit. So if t 
(type) is None it means an exception wasn't raised during the execution of the 
context manager and we have to handle the exception raised in __exit__. t,v, tb 
represent the exception that was raised before exiting the context manager and 
if they're not None, the raised exception from __exit__ will override it.


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: inspect.getargspec() is deprecated in py3
..


Patch Set 3:

* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: inspect.getargspec() is deprecated in py3
..


tests: inspect.getargspec() is deprecated in py3

We do not want to see following warning during running tests:

DeprecationWarning: inspect.getargspec() is deprecated, use
inspect.signature() instead

In order to replace getargspec with signature we need compatibility
object due to significant differences between both functions.


Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Signed-off-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/64313
Continuous-Integration: Jenkins CI
Reviewed-by: Irit Goihman 
Reviewed-by: Dan Kenigsberg 
---
M tests/api_test.py
M tests/schemaValidationTest.py
M tests/testlib.py
3 files changed, 52 insertions(+), 5 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: inspect.getargspec() is deprecated in py3
..


Patch Set 2: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: tests: inspect.getargspec() is deprecated in py3
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org