Change in vdsm[master]: hooking: move to static

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: hooking: move to static
..


Patch Set 4:

I know that this was my stupid suggestion, but folloeing Nir's comment about 
another module, I think that it would be better to keep (and deploy) hooking.py 
in a python subsubsubpackage of vdsm. We need to add tests for this tiny 
module, and making it easily importable would make it simpler.

-- 
To view, visit https://gerrit.ovirt.org/79638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2f1581d75cfb33868af41d1b116f56af89801a5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tool: clear networks configured by VDSM

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: tool: clear networks configured by VDSM
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/79495/4/lib/vdsm/tool/network.py
File lib/vdsm/tool/network.py:

Line 110: networks_request[net] = attrs
Line 111: networks_request[net]['bridged'] = False
Line 112: else:
Line 113: networks_request[net] = {'remove': True}
Line 114: net_api.setupNetworks(networks_request, {}, {'connectivityCheck': 
False})
I believe you need to setSafeConfig


-- 
To view, visit https://gerrit.ovirt.org/79495
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63702da4dd1c5a0328797f524734813ef251bdb6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tool: remove dummy bridge

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: tool: remove dummy bridge
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/79596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd78fba239b37d2c556f37c63438ee076516560b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: RPC: Refactor JSON RPC exceptions

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: RPC: Refactor JSON RPC exceptions
..


Patch Set 29:

(1 comment)

https://gerrit.ovirt.org/#/c/78660/29//COMMIT_MSG
Commit Message:

Line 13: For example, new error message for JsonRpcMethodNotFoundError is:
Line 14:   The method does not exist or is not available: {'method': 
'some_missing_method'}
Line 15: 
Line 16: Also added a new class JsonRpcGeneralError, that can have
Line 17: any code and message.
> I see... I think, it would be better to put the changes of exceptions to an
Nir, Seems like you have amazing design and appropriate behavior that you would 
like to have in all vdsm code as maintainer - it sounds amazing. but all those 
comments can't show me what you want to create - its too long and I can't allow 
follow the context. please create design document for your desire of how 
handling error\exception should be in vdsm - what way of using this hierarchy 
is valid and what is not- like may I create interfaces? can I call super? can I 
use same message but two different codes? whatever you love, just write it in a 
way that we will be able to follow your way ...  if you did so already, please 
share it and sorry for the interruption :)
Line 18: 
Line 19: Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958


-- 
To view, visit https://gerrit.ovirt.org/78660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Denis Chaplygin 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org