Change in vdsm[master]: spec: split network and common code to subrpms

2017-08-23 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: split network and common code to subrpms
..


Patch Set 2:

ci please build

-- 
To view, visit https://gerrit.ovirt.org/80982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11b663ff23023661017c6045a20925ca6abac69d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: spec: split network and common code to subrpms

2017-08-23 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: spec: split network and common code to subrpms
..

spec: split network and common code to subrpms

The code of the network subsystem still depends on the rest of vdsm.
Despite that, this patch introduces the vdsm-network and vdsm-common
subrpms as a little step to declare file ownership on an installed host.

Please note that at least the following dependencies remain:
* vdsm.network.api and vdsm.network.configurators.ifcfg depnend on vdsm.hooks,
  which in turn depends on execCmd
* vdsm.network.link.sriov depends on vdsm.udevadm
* vdsm.netswitch.configurators depends on vdsm.tool.service
* vdsm.network.initilizer.init_unprivileged_network_components still
  depends on vdsm.supervdsm
* vdsm.network.restore_net_config depends on vdsm.hostdev

Change-Id: I11b663ff23023661017c6045a20925ca6abac69d
Signed-off-by: Dan Kenigsberg 
---
M contrib/shell_helper
M vdsm.spec.in
2 files changed, 84 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/80982/1

diff --git a/contrib/shell_helper b/contrib/shell_helper
index 8e782d5..93fbe49 100755
--- a/contrib/shell_helper
+++ b/contrib/shell_helper
@@ -11,7 +11,7 @@
 
 _latest_rpms() {
 local VERSION=$(_latest_version)
-find "$RPMDIR"/ -iname "*$VERSION*.rpm" | egrep 
"vdsm-[0-9]|python|client|http|jsonrpc|tests|api|hook-vmfex-dev"
+find "$RPMDIR"/ -iname "*$VERSION*.rpm" | egrep 
"vdsm-[0-9]|python|client|http|jsonrpc|tests|api|hook-vmfex-dev|common|network"
 }
 
 vdsm_configure_force() {
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 5ffcd65..96d3c54 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -124,6 +124,7 @@
 Requires: safelease >= 1.0-7
 Requires: mom >= 0.5.8
 Requires(pre): shadow-utils
+Requires(preun): %{name}-network
 
 Obsoletes: %{name}-infra < 4.19
 
@@ -301,6 +302,8 @@
 BuildArch:  noarch
 Requires:   python-cpopen >= 1.5
 Requires:   python-ioprocess >= 0.16.1-1
+Requires:   %{name}-common = %{version}-%{release}
+Requires:   %{name}-network = %{version}-%{release}
 
 %description python
 Shared libraries between the various VDSM packages.
@@ -317,6 +320,22 @@
 rm -f %{python2_sitearch}/%{vdsm_name}/__init__.py*
 fi
 fi
+
+%package common
+Summary:common VDSM python libraries, required by all subsystems
+BuildArch:  noarch
+
+%description common
+VDSM libraries that are imported by all subsystems
+
+%package network
+Summary:VDSM network libraries
+BuildArch:  noarch
+Requires:   %{name}-common = %{version}-%{release}
+Requires:   %{name} = %{version}-%{release}
+
+%description network
+VDSM network libraries
 
 %package tests
 Summary:VDSM Test Suite
@@ -871,8 +890,6 @@
 %dir %{_libexecdir}/%{vdsm_name}
 %dir %{_sysconfdir}/%{vdsm_name}/vdsm.conf.d
 %dir %{_sysconfdir}/modprobe.d/
-%dir %{_sysconfdir}/NetworkManager
-%dir %{_sysconfdir}/NetworkManager/conf.d
 %dir %{_sysconfdir}/%{vdsm_name}
 %dir %{_sysconfdir}/%{vdsm_name}/mom.d
 %dir %{_datadir}/%{vdsm_name}
@@ -892,7 +909,6 @@
 %{_tmpfilesdir}/%{vdsm_name}.conf
 %{_sysconfdir}/dhcp/dhclient.d/dhclientmon.sh
 %{_sysconfdir}/modprobe.d/vdsm-bonding-modprobe.conf
-%{_sysconfdir}/NetworkManager/conf.d/vdsm.conf
 %{_sysconfdir}/sudoers.d/50_vdsm
 %{_sysconfdir}/cron.hourly/vdsm-logrotate
 %{_sysconfdir}/libvirt/hooks/qemu
@@ -1008,14 +1024,10 @@
 %{_datadir}/%{vdsm_name}/autounattend/Win2012R2.xml
 %{_datadir}/%{vdsm_name}/autounattend/Win2016.xml
 
-%files python
-%{_mandir}/man1/vdsm-tool.1*
-%{_bindir}/vdsm-tool
-%dir %{python_sitelib}/%{vdsm_name}
-%dir %{python_sitelib}/%{vdsm_name}/common
-%dir %{python_sitelib}/%{vdsm_name}/common/network
-%dir %{python_sitelib}/%{vdsm_name}/gluster
-%dir %{python_sitelib}/%{vdsm_name}/host
+%files network
+%dir %{_sysconfdir}/NetworkManager
+%dir %{_sysconfdir}/NetworkManager/conf.d
+%{_sysconfdir}/NetworkManager/conf.d/vdsm.conf
 %dir %{python_sitelib}/%{vdsm_name}/network
 %dir %{python_sitelib}/%{vdsm_name}/network/configurators
 %dir %{python_sitelib}/%{vdsm_name}/network/ip
@@ -1034,52 +1046,8 @@
 %dir %{python_sitelib}/%{vdsm_name}/network/ovs
 %dir %{python_sitelib}/%{vdsm_name}/network/ovs/driver
 %dir %{python_sitelib}/%{vdsm_name}/network/tc
-%dir %{python_sitelib}/%{vdsm_name}/metrics
-%dir %{python_sitelib}/%{vdsm_name}/tool
-%dir %{python_sitelib}/%{vdsm_name}/tool/configurators
-%dir %{python_sitelib}/%{vdsm_name}/profiling
-%dir %{python_sitelib}/%{vdsm_name}/storage
-%dir %{python_sitelib}/%{vdsm_name}/supervdsm_api
-%dir %{python_sitelib}/%{vdsm_name}/virt
-%dir %{python_sitelib}/%{vdsm_name}/virt/vmdevices
-%{python_sitelib}/%{vdsm_name}/__init__.py*
-%{python_sitelib}/%{vdsm_name}/alignmentScan.py*
-%{python_sitelib}/%{vdsm_name}/API.py*
-%{python_sitelib}/%{vdsm_name}/client.py*
-%{python_sitelib}/%{vdsm_name}/clientIF.py*

Change in vdsm[master]: move vdsm.config to common

2017-08-23 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/79980 )

Change subject: move vdsm.config to common
..


move vdsm.config to common

vdsm.config is used by all subsystems. It should thus sit in common.
This patch keeps a proxy in place, so that existing users of vdsm.config
can be updated in separate patches.

Change-Id: Ie84514aed56034c79044a94f7ce391b368cb99c4
Signed-off-by: Dan Kenigsberg 
---
M .gitignore
M lib/vdsm/Makefile.am
M lib/vdsm/common/Makefile.am
R lib/vdsm/common/config.py.in
A lib/vdsm/config.py
M tests/config_test.py
6 files changed, 41 insertions(+), 9 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/79980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie84514aed56034c79044a94f7ce391b368cb99c4
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooking: move to lib

2017-08-23 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80842 )

Change subject: hooking: move to lib
..


hooking: move to lib

As part of broader migration we move hooking.py away from vdsm dir.


Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Signed-off-by: Piotr Kliczewski 
---
M Makefile.am
M configure.ac
M lib/vdsm/Makefile.am
A lib/vdsm/hook/Makefile.am
A lib/vdsm/hook/__init__.py
R lib/vdsm/hook/hooking.py
M lib/vdsm/hooks.py
M vdsm.spec.in
M vdsm/Makefile.am
9 files changed, 33 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooking: move to lib

2017-08-23 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: hooking: move to lib
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooking: move to lib

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: hooking: move to lib
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/80842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d7ac3d8730b3961e420936536f3ee5a055d336
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: metrics: stop sending host metrics except storage

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: metrics: stop sending host metrics except storage
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/80050
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39c3eee94e927446df0e7f93f53f54cfe96ff5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: stop using hard coded values for heartbeats
..


Patch Set 5: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/78918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/78918 )

Change subject: stomp: stop using hard coded values for heartbeats
..


stomp: stop using hard coded values for heartbeats

We wish to support incoming heartbeats in JSONRPC client
in order to implement reconnect mechanism.
AsyncClient connect method used to send HEARTBEAT header with
hard coded values, which are now configurable and enable both
ways heartbeats.

Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Signed-off-by: Irit Goihman 
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompreactor.py
M tests/stompAsyncClientTests.py
3 files changed, 28 insertions(+), 9 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/78918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: stop using hard coded values for heartbeats

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: stop using hard coded values for heartbeats
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: fix AsyncDispatcher next_check_interval

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80911 )

Change subject: stomp: fix AsyncDispatcher next_check_interval
..


stomp: fix AsyncDispatcher next_check_interval

If next_check_interval returns 0, asyncore loop is triggerred.
In case of no outgoing heartbeat, the function doesn't ignore the
calculation and returns 0, which causes the loop to be triggerred
constantly and send heartbeats.
On server side outgoing heartbeats are always greater than 0 so we
didn't encounter this behavior before. When we added the same
functionality to client side, where outgoing heartbeat is 0 by default,
we encountered high cpu usage.

Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Signed-off-by: Irit Goihman 
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncDispatcherTests.py
2 files changed, 23 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/80911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: fix AsyncDispatcher next_check_interval

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: fix AsyncDispatcher next_check_interval
..


Patch Set 2: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/80911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle timeout in server side

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/78917 )

Change subject: stomp: handle timeout in server side
..


stomp: handle timeout in server side

When the server stops receiving incoming heartbeats, it should
cleanup subscriptions and close the fd.

Signed-off-by: Irit Goihman 
Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stompreactor.py
M tests/stompAdapterTests.py
2 files changed, 57 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Irit Goihman: Verified



-- 
To view, visit https://gerrit.ovirt.org/78917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: fix AsyncDispatcher next_check_interval

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: fix AsyncDispatcher next_check_interval
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle timeout in server side

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: handle timeout in server side
..


Patch Set 4: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/78917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle timeout in server side

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: handle timeout in server side
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: metrics: stop sending host metrics except storage

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: metrics: stop sending host metrics except storage
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/80050
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39c3eee94e927446df0e7f93f53f54cfe96ff5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle incoming heartbeats

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/78916 )

Change subject: stomp: handle incoming heartbeats
..


stomp: handle incoming heartbeats

According to stomp specification, Heart-beating can optionally be used
to test the healthiness of the underlying TCP connection and to make sure
that the remote end is alive and kicking. [1]
until now, we ignored incoming heartbeats and raised ValueError
when their value was not 0.
This patch gets the incoming heartbeats and updates the
dispatcher according to their value.
incoming heartbeat will be updated every time a new frame will be
received, indicating connection is still active.
If timeout has exceeded, the frame handler (client or server) will handle
it according to its implementation.

[1] https://stomp.github.io/stomp-specification-1.2.html#Heart-beating

Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Signed-off-by: Irit Goihman 
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncDispatcherTests.py
2 files changed, 38 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/78916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: stomp: handle incoming heartbeats

2017-08-23 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: handle incoming heartbeats
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/78916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: move dsaversion to common

2017-08-23 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: move dsaversion to common
..

move dsaversion to common

dsaversion is used by infra and network subsystems, and should thus be
shipped in common.

Change-Id: I687bf30db22fe43f685d89dab09a7e0abdd82db6
Signed-off-by: Dan Kenigsberg 
---
M .gitignore
M lib/vdsm/Makefile.am
M lib/vdsm/common/Makefile.am
R lib/vdsm/common/dsaversion.py.in
M lib/vdsm/host/caps.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/vdsmd.py
M vdsm.spec.in
8 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/80954/1

diff --git a/.gitignore b/.gitignore
index 7e8c362..f004f9c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -29,7 +29,7 @@
 lib/vdsm/api/vdsm-api.html
 lib/vdsm/common/constants.py
 lib/vdsm/common/config.py
-lib/vdsm/dsaversion.py
+lib/vdsm/common/dsaversion.py
 lib/sos/vdsm.py
 lib/vdsm/storage/lvm.env
 lib/vdsm/storage/protect/spmprotect.sh
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 1dd66d7..133143c 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -70,7 +70,6 @@
$(NULL)
 
 nodist_vdsmpylib_PYTHON = \
-   dsaversion.py \
$(NULL)
 
 nodist_noinst_DATA= \
@@ -84,7 +83,6 @@
 
 
 EXTRA_DIST = \
-   dsaversion.py.in \
vdsm.conf.sample \
$(NULL)
 
diff --git a/lib/vdsm/common/Makefile.am b/lib/vdsm/common/Makefile.am
index 3dafdc9..ec30777 100644
--- a/lib/vdsm/common/Makefile.am
+++ b/lib/vdsm/common/Makefile.am
@@ -25,6 +25,7 @@
 nodist_vdsmcommon_PYTHON = \
config.py \
constants.py \
+   dsaversion.py \
$(NULL)
 
 dist_vdsmcommon_PYTHON = \
@@ -34,6 +35,7 @@
 EXTRA_DIST = \
config.py.in \
constants.py.in \
+   dsaversion.py.in \
$(NULL)
 
 CLEANFILES = \
diff --git a/lib/vdsm/dsaversion.py.in b/lib/vdsm/common/dsaversion.py.in
similarity index 100%
rename from lib/vdsm/dsaversion.py.in
rename to lib/vdsm/common/dsaversion.py.in
diff --git a/lib/vdsm/host/caps.py b/lib/vdsm/host/caps.py
index 21c02a8..73378f0 100644
--- a/lib/vdsm/host/caps.py
+++ b/lib/vdsm/host/caps.py
@@ -27,13 +27,13 @@
 import libvirt
 
 from vdsm.common import cache
+from vdsm.common import dsaversion
 from vdsm.config import config
 from vdsm.host import rngsources
 from vdsm.storage import hba
 from vdsm import containersconnection
 from vdsm import cpuarch
 from vdsm import cpuinfo
-from vdsm import dsaversion
 from vdsm import hooks
 from vdsm import host
 from vdsm import hostdev
diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index ff16817..2a4c89b 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -32,10 +32,11 @@
 
 import six
 
-from vdsm import dsaversion
 from vdsm import hooks
+
 from vdsm.common import concurrent
 from vdsm.common import constants
+from vdsm.common import dsaversion
 from vdsm.common import fileutils
 from vdsm.common.config import config
 from vdsm.common.conv import tobool
diff --git a/lib/vdsm/vdsmd.py b/lib/vdsm/vdsmd.py
index ee734bc..ff9deaa 100755
--- a/lib/vdsm/vdsmd.py
+++ b/lib/vdsm/vdsmd.py
@@ -30,7 +30,6 @@
 
 from vdsm import commands
 from vdsm import constants
-from vdsm import dsaversion
 from vdsm import health
 from vdsm import jobs
 from vdsm import schedule
@@ -38,6 +37,7 @@
 from vdsm import containersconnection
 from vdsm import taskset
 from vdsm import metrics
+from vdsm.common import dsaversion
 from vdsm.common import sigutils
 from vdsm.common import time
 from vdsm.common import zombiereaper
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 4a57f5c..a9e0f83 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -736,7 +736,7 @@
 rawversion=%{version}-%{release}
 sed -i -e 's/^software_version =.*/software_version = "'"${baseversion}"'"/' \
-e 's/^raw_version_revision =.*/raw_version_revision = 
"'"${rawversion}"'"/' \
-   -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' 
lib/vdsm/dsaversion.py
+   -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' 
lib/vdsm/common/dsaversion.py
 
 %install
 make DESTDIR=%{buildroot} install
@@ -1058,7 +1058,6 @@
 %{python_sitelib}/%{vdsm_name}/containersconnection.py*
 %{python_sitelib}/%{vdsm_name}/cpuarch.py*
 %{python_sitelib}/%{vdsm_name}/cpuinfo.py*
-%{python_sitelib}/%{vdsm_name}/dsaversion.py*
 %{python_sitelib}/%{vdsm_name}/dmidecodeUtil.py*
 %{python_sitelib}/%{vdsm_name}/executor.py*
 # gluster.exception is used in many places like Bridge.py. So it is required


-- 
To view, visit https://gerrit.ovirt.org/80954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I687bf30db22fe43f685d89dab09a7e0abdd82db6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master

Change in vdsm[ovirt-4.1]: network: remove ip from a nic used by a removed network

2017-08-23 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/80835 )

Change subject: network: remove ip from a nic used by a removed network
..


network: remove ip from a nic used by a removed network

Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Signed-off-by: Petr Horacek 
Bug-Url: https://bugzilla.redhat.com/1432386
---
M lib/vdsm/network/configurators/ifcfg.py
M tests/network/func_net_basic_test.py
M tests/network/func_static_ip_test.py
3 files changed, 83 insertions(+), 19 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80835
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: network: remove ip from a nic used by a removed network

2017-08-23 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: network: remove ip from a nic used by a removed network
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/80835
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org