Change in vdsm[master]: gluster: Fix vdsm-tool crash report detected by abrt

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Fix vdsm-tool crash report detected by abrt
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/23551
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7b677ef8de713d2912f8926991b1dcd8134ccf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Dary 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 14: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: additional parsing of host UUID in verb 
glusterVolumesList
..


Patch Set 7: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/22693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9057f3aea0c0ed8fb4d4ec26eaf66fe80ec581e2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Kanagaraj M 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: additional parsing of host UUID in verb 
glusterVolumesList
..


Patch Set 6: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/22693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9057f3aea0c0ed8fb4d4ec26eaf66fe80ec581e2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Kanagaraj M 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: additional parsing of host UUID in verb 
glusterVolumesList
..


Patch Set 5: Code-Review-1

(1 comment)

One minor code comment. Rest of the changes looks good.

http://gerrit.ovirt.org/#/c/22693/5/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 367: try:
Line 368: brickDetail['name'] = d.find('name').text
Line 369: brickDetail['hostUuid'] = d.find('hostUuid').text
Line 370: value['bricksInfo'].append(brickDetail)
Line 371: except:
1. Please catch exact exception.
2. Use break instead of pass, so that you can eliminate looping all brick with 
pass.
Line 372: pass
Line 373: volumes[value['volumeName']] = value
Line 374: return volumes
Line 375: 


-- 
To view, visit http://gerrit.ovirt.org/22693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9057f3aea0c0ed8fb4d4ec26eaf66fe80ec581e2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Kanagaraj M 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 12:

No changes after Patchset 11, dependent patch got updated.

-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 12: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 11: Verified+1

Bala, Tim,

1. Removed validation in vdsClient as suggested.

2. Modified mount option as read only. 

3. Added additional exception which will be raised when volume is down

-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 8: Verified+1

Updated schema and updated client/vdsClientGluster.py as per Saggi's comment.

-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Replace bricks verbs removed

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Replace bricks verbs removed
..


Patch Set 4: Verified+1

Rebased and included client/vdsClientGluster.py

-- 
To view, visit http://gerrit.ovirt.org/20060
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23cd224ced9c6892ab182f663476df428f2f35da
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add force option to Volume Create command

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Add force option to Volume Create command
..


Patch Set 4: Verified+1

Bala, I updated the glusterfs version in spec file.

-- 
To view, visit http://gerrit.ovirt.org/21082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Replace bricks verbs removed

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Replace bricks verbs removed
..


Patch Set 3: Verified+1

Rebased and included client/vdsClientGluster.py

-- 
To view, visit http://gerrit.ovirt.org/20060
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23cd224ced9c6892ab182f663476df428f2f35da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: raise suitable exception based on errno for peerDetach

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: raise suitable exception based on errno for peerDetach
..


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/22284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I557a264445806695bb83d77400993ef9c8cfa698
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add force option to Volume Create command

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Add force option to Volume Create command
..


Patch Set 3:

GlusterFS changes is now available in release-3.4 branch
http://review.gluster.org/#/c/6355/

-- 
To view, visit http://gerrit.ovirt.org/21082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add force option to Volume Create command

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Add force option to Volume Create command
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/21082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add force option to Volume Create command

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Add force option to Volume Create command
..


Patch Set 3:

Updated the schema file.

-- 
To view, visit http://gerrit.ovirt.org/21082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add force option to Volume Create command

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Add force option to Volume Create command
..


Patch Set 2:

(2 comments)


File vdsm/gluster/api.py
Line 78: 
Line 79: @exportAsVerb
Line 80: def volumeCreate(self, volumeName, brickList, replicaCount=0,
Line 81:  stripeCount=0, transportList=[],
Line 82:  force=False, options=None):
As discussed with engine folks, adding new parameter will not cause any issue 
since engine knows about the new parameter with respect to vdsm version.

Please let me know if we need to use options dict itself for new parameter.
Line 83: return self.svdsmProxy.glusterVolumeCreate(volumeName, 
brickList,
Line 84:replicaCount, 
stripeCount,
Line 85:transportList, 
force)
Line 86: 



File vdsm/gluster/vdsmapi-gluster-schema.json
Line 557: #
Line 558: # Since: 4.10.3
Line 559: ##
Line 560: {'command': {'class': 'GlusterVolume', 'name': 'create'},
Line 561:  'data': {'volumeName': 'str', 'bricklist': ['str'], 'replicaCount': 
'int', 'stripeCount': 'int', 'transportList': ['transType'], 'force': 'bool'},
Ok, will update the desc.
Line 562:  'returns': 'UUID'}
Line 563: 
Line 564: ##
Line 565: # @GlusterVolume.start:


-- 
To view, visit http://gerrit.ovirt.org/21082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new verb to remove host using host UUID

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new verb to remove host using host UUID
..


Patch Set 4: Verified-1

(2 comments)


Commit Message
Line 7: gluster: new verb to remove host using host UUID
Line 8: 
Line 9: This patch adds a new verb glusterHostRemoveByUuid which
Line 10: retrives the host name based on uuid passed and uses it to
Line 11: remove the host.
Update verb name, possible exceptions and return type.
Line 12: 
Line 13: Signed-off-by: ndarshan 



File vdsm/gluster/vdsmapi-gluster-schema.json
Line 943: # Success or failure
Line 944: #
Line 945: # Since: 4.14.0
Line 946: ##
Line 947: {'command': {'class': 'GlusterHost', 'name': 'remove'},
name should be removeByUuid
Line 948:  'data': {'hostUuid': 'UUID', 'force': 'bool'},
Line 949:  'returns': 'bool'}
Line 950: 
Line 951: ##


-- 
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add force option to Volume Create command

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Add force option to Volume Create command
..


Patch Set 2: Verified+1

Added force as additional option instead of using as dictionary.

-- 
To view, visit http://gerrit.ovirt.org/21082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add force option to Volume Create command

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Add force option to Volume Create command
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/21082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Add force option to Volume Create command

[avishwan]

Aravinda VK has uploaded a new change for review.

Change subject: gluster: Add force option to Volume Create command
..

gluster: Add force option to Volume Create command

glusterfs cli will fail if system's root partition is used
as brick dirs. If user wants to use system's root partition as
bricks dir then "force" option can be used in gluster cli.

Added the "force" parameter to vdsm verb
glusterVolumeCreate

It will not break backward compatibility since it utilizes
existing optional parameter.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1008942
Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0
Signed-off-by: Aravinda VK 
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/vdsmapi-gluster-schema.json
4 files changed, 13 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/21082/1

diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index 65e6282..7353e13 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -39,10 +39,11 @@
 stripeCount = params.get('stripe', '')
 transport = params.get('transport', '')
 transportList = transport.strip().split(',') if transport else []
+force = {"force": (params.get('force', 'no').upper() == 'YES')}
 
 status = self.s.glusterVolumeCreate(volumeName, brickList,
 replicaCount, stripeCount,
-transportList)
+transportList, force)
 return status['status']['code'], status['status']['message']
 
 def do_glusterVolumesList(self, args):
@@ -449,7 +450,8 @@
 {'glusterVolumeCreate': (
 serv.do_glusterVolumeCreate,
 ('volumeName= bricks= '
- '[replica=] [stripe=] [transport={tcp|rdma}]\n\t'
+ '[replica=] [stripe=] [transport={tcp|rdma}] '
+ '[force={yes|no}]\n\t'
  ' is name of new volume',
  ' is brick(s) which will be used to '
  'create volume',
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 193d6bd..1078700 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -78,10 +78,11 @@
 
 @exportAsVerb
 def volumeCreate(self, volumeName, brickList, replicaCount=0,
- stripeCount=0, transportList=[], options=None):
+ stripeCount=0, transportList=[], options={}):
+force = options.get("force")
 return self.svdsmProxy.glusterVolumeCreate(volumeName, brickList,
replicaCount, stripeCount,
-   transportList)
+   transportList, force)
 
 @exportAsVerb
 def volumeStart(self, volumeName, force=False, options=None):
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index a654b56..25fd8ba 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -445,7 +445,7 @@
 
 @makePublic
 def volumeCreate(volumeName, brickList, replicaCount=0, stripeCount=0,
- transportList=[]):
+ transportList=[], force=False):
 command = _getGlusterVolCmd() + ["create", volumeName]
 if stripeCount:
 command += ["stripe", "%s" % stripeCount]
@@ -454,6 +454,10 @@
 if transportList:
 command += ["transport", ','.join(transportList)]
 command += brickList
+
+if force:
+command.append('force')
+
 try:
 xmltree = _execGlusterXml(command)
 except ge.GlusterCmdFailedException as e:
diff --git a/vdsm/gluster/vdsmapi-gluster-schema.json 
b/vdsm/gluster/vdsmapi-gluster-schema.json
index 7de762a..3bab622 100644
--- a/vdsm/gluster/vdsmapi-gluster-schema.json
+++ b/vdsm/gluster/vdsmapi-gluster-schema.json
@@ -558,7 +558,7 @@
 # Since: 4.10.3
 ##
 {'command': {'class': 'GlusterVolume', 'name': 'create'},
- 'data': {'volumeName': 'str', 'bricklist': ['str'], 'replicaCount': 'int', 
'stripeCount': 'int', 'transportList': ['transType']},
+ 'data': {'volumeName': 'str', 'bricklist': ['str'], 'replicaCount': 'int', 
'stripeCount': 'int', 'transportList': ['transType'], 'force': 'bool'},
  'returns': 'UUID'}
 
 ##


-- 
To view, visit http://gerrit.ovirt.org/21082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: correct parameter for creating hookpath in verb hoo...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: correct parameter for creating hookpath in verb 
hookAdd.
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/21017
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7806316f7cdfaa7d6f42323e6db45886a97f9d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: performs peer detach using host UUID if provided

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: performs peer detach using host UUID if provided
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: performs peer detach using host UUID if provided

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: performs peer detach using host UUID if provided
..


Patch Set 1: Code-Review-1

(2 comments)


File vdsm/gluster/api.py
Line 213: 
Line 214: @exportAsVerb
Line 215: def hostRemove(self, hostName, force=False, options={}):
Line 216: host = None
Line 217: hostUuid = options.get('hostUuid')
Sorry. This method will not work with new engine and old vdsm.
Line 218: 
Line 219: # get hostname of given host uuid
Line 220: if hostUuid:
Line 221: for hostInfo in self.svdsmProxy.glusterPeerStatus():


Line 222: if(hostInfo['uuid'] == hostUuid):
Line 223: host = hostInfo['hostname']
Line 224: break
Line 225: if not host:
Line 226: logging.debug("Host with UUID:%s not found " % 
hostUuid)
Avoid using global "logging", refer hooks.py for logging usage.

Use logging warn/error, since debug messages will be disabled in production use
Line 227: host = hostName
Line 228: else:
Line 229: host = hostName
Line 230: 


-- 
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: VDSM Gluster verb to set swift configuration

[avishwan]

Aravinda VK has abandoned this change.

Change subject: gluster: VDSM Gluster verb to set swift configuration
..


Abandoned

Current requirement is changed, and swift configuration is not used. So 
abandoning the patch.

-- 
To view, visit http://gerrit.ovirt.org/13383
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibba9c30d1ad4926c88e58cb4bc9a858b8a07f77b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: VDSM Gluster verb to get swift configuration

[avishwan]

Aravinda VK has abandoned this change.

Change subject: gluster: VDSM Gluster verb to get swift configuration
..


Abandoned

Current requirement is changed, and swift configuration is not used. So 
abandoning the patch.

-- 
To view, visit http://gerrit.ovirt.org/10864
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie966fb515275a0768f67cbbe2055a07002355327
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Return status after remove brick/rebalance stop

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Return status after remove brick/rebalance stop
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/20482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b46296c8ec9544644d2ab8fed5f9c12236b7ed0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: performs peer detach using host UUID if provided

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: performs peer detach using host UUID if provided
..


Patch Set 1:

(1 comment)


File vdsm/gluster/api.py
Line 213: 
Line 214: @exportAsVerb
Line 215: def hostRemove(self, hostName, force=False, options={}):
Line 216: host = None
Line 217: hostUuid = options.get('hostUuid')
One more option. how about using UUID validation to decide input value.

hostUuid = ""
try:
hostUuid = str(uuid.UUID(hostName))
except ValueError:
pass

This eliminates modification to existing function signature.
Line 218: 
Line 219: # get hostname of given host uuid
Line 220: if hostUuid:
Line 221: for hostInfo in self.svdsmProxy.glusterPeerStatus():


-- 
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Return status after remove brick/rebalance stop

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Return status after remove brick/rebalance stop
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/20482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b46296c8ec9544644d2ab8fed5f9c12236b7ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Return status after remove brick/rebalance stop

[avishwan]

Aravinda VK has uploaded a new change for review.

Change subject: gluster: Return status after remove brick/rebalance stop
..

gluster: Return status after remove brick/rebalance stop

Initially glusterVolumeRebalanceStop and glusterVolumeRemoveBrickStop
returns true/false.

Since rebalance and remove brick operations are async operations, if
rebalance/remove-brick STOP is triggered after these async tasks completed
then vdsm returns success when executing stop command. But since task is
completed engine has to show that task is completed(Now showing STOPPED)

This patch returns status after successful execution of stop command.
engine will check the summary[status] to see the status of task and
display in UI accordingly.

This patch will not affect the backward compatibility since "status"
is not changed in output dict.
'status': {'code': 0, 'message': 'Done'}

Output:
{'hosts': [{'filesFailed': LONG as STR,
'filesMoved': LONG as STR,
'filesScanned': LONG as STR,
'filesSkipped': LONG as STR,
'name': STRING,
'status': STRING,
'totalSizeMoved': LONG as STR},..],
 'status': {'code': 0, 'message': 'Done'},
 'summary': {'filesFailed': LONG as STR,
 'filesMoved': LONG as STR,
 'filesScanned': LONG as STR,
 'filesSkipped': LONG as STR,
 'status': STRING,
 'totalSizeMoved': LONG as STR}}

Exceptions:
GlusterVolumeRebalanceStopFailedException
code = 4137
message = "Volume rebalance stop failed"

GlusterVolumeRemoveBrickStopFailedException
code = 4150
message = "Volume remove brick stop failed"

GlusterXmlErrorException
code = 4106
message = "XML error"

Change-Id: I5b46296c8ec9544644d2ab8fed5f9c12236b7ed0
Signed-off-by: Aravinda VK 
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/vdsmapi-gluster-schema.json
4 files changed, 22 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/20482/1

diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index 3c1199c..65e6282 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -131,6 +131,7 @@
 force = (params.get('force', 'no').upper() == 'YES')
 
 status = self.s.glusterVolumeRebalanceStop(volumeName, force)
+pp.pprint(status)
 return status['status']['code'], status['status']['message']
 
 def do_glusterVolumeRebalanceStatus(self, args):
@@ -234,6 +235,7 @@
 status = self.s.glusterVolumeRemoveBrickStop(volumeName,
  brickList,
  replicaCount)
+pp.pprint(status)
 return status['status']['code'], status['status']['message']
 
 def do_glusterVolumeRemoveBrickStatus(self, args):
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 284fa97..193d6bd 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -122,7 +122,7 @@
 
 @exportAsVerb
 def volumeRebalanceStop(self, volumeName, force=False, options=None):
-self.svdsmProxy.glusterVolumeRebalanceStop(volumeName, force)
+return self.svdsmProxy.glusterVolumeRebalanceStop(volumeName, force)
 
 @exportAsVerb
 def volumeRebalanceStatus(self, volumeName, options=None):
@@ -175,8 +175,9 @@
 @exportAsVerb
 def volumeRemoveBrickStop(self, volumeName, brickList,
   replicaCount=0, options=None):
-self.svdsmProxy.glusterVolumeRemoveBrickStop(volumeName, brickList,
- replicaCount)
+return self.svdsmProxy.glusterVolumeRemoveBrickStop(volumeName,
+brickList,
+replicaCount)
 
 @exportAsVerb
 def volumeRemoveBrickStatus(self, volumeName, brickList,
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index a67658f..a654b56 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -583,11 +583,15 @@
 if force:
 command.append('force')
 try:
-_execGlusterXml(command)
-return True
+xmltree = _execGlusterXml(command)
 except ge.GlusterCmdFailedException, e:
 raise ge.GlusterVolumeRebalanceStopFailedException(rc=e.rc,
err=e.err)
+
+try:
+return _parseVolumeRebalanceRemoveBrickStatus(xmltree, 'rebalance')
+except _etreeExceptions:
+raise ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)])
 
 
 @makePublic
@@ -751,12 +755,16 @@
 command += ["replica", "%s" % replicaCount]
 command += brickList + ["stop"]
 try:
-_execGlusterXml(command)
-return True
+xmltree = _execGlusterXml(command)
   

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 7: -Verified

(1 comment)


File client/vdsClientGluster.py
Line 444: def do_glusterVolumeStatsInfoGet(self, args):
Line 445: params = self._eqSplit(args)
Line 446: volumeName = params.get('volumeName', '')
Line 447: if not volumeName:
Line 448: raise ValueError
Done
Line 449: 
Line 450: status = self.s.glusterVolumeStatsInfoGet(volumeName)
Line 451: pp.pprint(status)
Line 452: return status['status']['code'], status['status']['message']


-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 7:

I didn't succeed with the libgfapi approach to get statvfs information of 
glusterfs volume. Falling back to `mount -t glusterfs` method to get statvfs 
info of glusterfs volume.

-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 7: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Fix output format compatibility of removeBrickStatus
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/20108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Replace bricks verbs removed

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Replace bricks verbs removed
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/20060
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23cd224ced9c6892ab182f663476df428f2f35da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus

[avishwan]

Aravinda VK has uploaded a new change for review.

Change subject: gluster: Fix output format compatibility of removeBrickStatus
..

gluster: Fix output format compatibility of removeBrickStatus

Rebalance status and Remove brick status have common output structure,
engine uses common code to parse the vdsm output of both verbs.

This patch fixes the incompatibility in remove brick status output.
(As this verb is not consumed by engine/RHS-C yet, its OK to differ
in compatibility now)

Output:
{'summary': {
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
},
'hosts': [{
'name': STRING,
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
}..]}

Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Signed-off-by: Aravinda VK 
---
M vdsm/gluster/api.py
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/20108/1

diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index ebb0901..284fa97 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -181,10 +181,9 @@
 @exportAsVerb
 def volumeRemoveBrickStatus(self, volumeName, brickList,
 replicaCount=0, options=None):
-message = self.svdsmProxy.glusterVolumeRemoveBrickStatus(volumeName,
- brickList,
- replicaCount)
-return {'message': message}
+return self.svdsmProxy.glusterVolumeRemoveBrickStatus(volumeName,
+  brickList,
+  replicaCount)
 
 @exportAsVerb
 def volumeRemoveBrickCommit(self, volumeName, brickList,


-- 
To view, visit http://gerrit.ovirt.org/20108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Replace bricks verbs removed

[avishwan]

Aravinda VK has uploaded a new change for review.

Change subject: gluster: Replace bricks verbs removed
..

gluster: Replace bricks verbs removed

glusterfs phased out replace-brick feature.
http://lists.nongnu.org/archive/html/gluster-devel/2013-09/msg00155.html

Existing replace-bricks verbs are not yet consumed by ovirt-engine, so removing
all the verbs.

Removed verbs:
glusterVolumeReplaceBrickStart
glusterVolumeReplaceBrickAbort
glusterVolumeReplaceBrickPause
glusterVolumeReplaceBrickStatus
glusterVolumeReplaceBrickCommit
glusterVolumeRemoveBrickStart

Change-Id: I23cd224ced9c6892ab182f663476df428f2f35da
Signed-off-by: Aravinda VK 
---
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm/gluster/tasks.py
4 files changed, 1 insertion(+), 163 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/20060/1

diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index ebb0901..43e60cf 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -129,43 +129,6 @@
 return self.svdsmProxy.glusterVolumeRebalanceStatus(volumeName)
 
 @exportAsVerb
-def volumeReplaceBrickStart(self, volumeName, existingBrick, newBrick,
-options=None):
-return self.svdsmProxy.glusterVolumeReplaceBrickStart(volumeName,
-  existingBrick,
-  newBrick)
-
-@exportAsVerb
-def volumeReplaceBrickAbort(self, volumeName, existingBrick, newBrick,
-options=None):
-self.svdsmProxy.glusterVolumeReplaceBrickAbort(volumeName,
-   existingBrick,
-   newBrick)
-
-@exportAsVerb
-def volumeReplaceBrickPause(self, volumeName, existingBrick, newBrick,
-options=None):
-self.svdsmProxy.glusterVolumeReplaceBrickPause(volumeName,
-   existingBrick,
-   newBrick)
-
-@exportAsVerb
-def volumeReplaceBrickStatus(self, volumeName, oldBrick, newBrick,
- options=None):
-st, msg = self.svdsmProxy.glusterVolumeReplaceBrickStatus(volumeName,
-  oldBrick,
-  newBrick)
-return {'replaceBrick': st, 'message': msg}
-
-@exportAsVerb
-def volumeReplaceBrickCommit(self, volumeName, existingBrick, newBrick,
- force=False, options=None):
-self.svdsmProxy.glusterVolumeReplaceBrickCommit(volumeName,
-existingBrick,
-newBrick,
-force)
-
-@exportAsVerb
 def volumeRemoveBrickStart(self, volumeName, brickList,
replicaCount=0, options=None):
 return self.svdsmProxy.glusterVolumeRemoveBrickStart(volumeName,
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index a67658f..3ed3bd4 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -75,7 +75,6 @@
 
 class TaskType:
 REBALANCE = 'REBALANCE'
-REPLACE_BRICK = 'REPLACE_BRICK'
 REMOVE_BRICK = 'REMOVE_BRICK'
 
 
@@ -651,83 +650,6 @@
 
 
 @makePublic
-def volumeReplaceBrickStart(volumeName, existingBrick, newBrick):
-command = _getGlusterVolCmd() + ["replace-brick", volumeName,
- existingBrick, newBrick, "start"]
-try:
-xmltree = _execGlusterXml(command)
-except ge.GlusterCmdFailedException, e:
-raise ge.GlusterVolumeReplaceBrickStartFailedException(rc=e.rc,
-   err=e.err)
-try:
-return {'taskId': xmltree.find('volReplaceBrick/task-id').text}
-except _etreeExceptions:
-raise ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)])
-
-
-@makePublic
-def volumeReplaceBrickAbort(volumeName, existingBrick, newBrick):
-command = _getGlusterVolCmd() + ["replace-brick", volumeName,
- existingBrick, newBrick, "abort"]
-try:
-_execGlusterXml(command)
-return True
-except ge.GlusterCmdFailedException, e:
-raise ge.GlusterVolumeReplaceBrickAbortFailedException(rc=e.rc,
-   err=e.err)
-
-
-@makePublic
-def volumeReplaceBrickPause(volumeName, existingBrick, newBrick):
-command = _getGlusterVolCmd() + ["replace-brick", volumeName,
- existingBrick, newBrick, "pause"]
-try:
-_e

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 6: Verified+1

Falling back to mounting glusterfs volume using mount command instead of 
libgfapi.

-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: adopt xml changes of rebalance and remove-brick status

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: adopt xml changes of rebalance and remove-brick status
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3031b6eb796b7475bbe533fbdd0366fbaf6aea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: interpret and use correct xml elements

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: interpret and use correct xml elements
..


Patch Set 1: Code-Review-1

(1 comment)


File vdsm/gluster/cli.py
Line 611: tree = xmltree.find('volRemoveBrick')
Line 612: else:
Line 613: return
Line 614: 
Line 615: st = re.sub('[ -]', '_', 
tree.find('aggregate/statusStr').text.upper())
We can use simple string replace instead of re. If we are using re, "\s" is 
better representation for space for readability.

re.sub('\s|-', '_', tree.find('aggregate/statusStr').text.upper())
Line 616: status = {
Line 617: 'summary': {
Line 618: 'runtime': float(tree.find('aggregate/runtime').text),
Line 619: 'filesScanned': int(tree.find('aggregate/lookups').text),


-- 
To view, visit http://gerrit.ovirt.org/19674
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b90283ac2b9f4b54acfccffa02a30e38e5e9d85
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add task support

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: add task support
..


Patch Set 19: Verified+1

Incorporated Saggi's suggestions and added testcase for tasklist.

-- 
To view, visit http://gerrit.ovirt.org/10200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add task support

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: add task support
..


Patch Set 17: Verified+1

Rebased and added gerrit.ovirt.org/#/c/19408/ as dependent.

-- 
To view, visit http://gerrit.ovirt.org/10200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add task support

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: add task support
..


Patch Set 15:

Updated GlusterFS dependency as 3.4.1

-- 
To view, visit http://gerrit.ovirt.org/10200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Using XML output for rebalance/remove-brick status 
verbs
..


Patch Set 8: Verified+1

Updated as per Bala's comments.

-- 
To view, visit http://gerrit.ovirt.org/18358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Better Saggi 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Using XML output for rebalance/remove-brick status 
verbs
..


Patch Set 5: Verified+1

Updated statusStr in xml parsing as per Bala's suggestion and added tests.

-- 
To view, visit http://gerrit.ovirt.org/18358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Using XML output for rebalance/remove-brick status 
verbs
..


Patch Set 4:

(4 comments)


Commit Message
Line 10: output provided by gluster cli command.
Line 11: 
Line 12: Modified verbs:
Line 13: glusterVolumeRebalanceStatus
Line 14: glusterVolumeRemoveBrickStatus
Done
Line 15: 
Line 16: Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Line 17: Signed-off-by: Bala.FA 



File vdsm/gluster/cli.py
Line 648: 'filesMoved': 
int(el.find('files').text),
Line 649: 'filesFailed': 
int(el.find('failures').text),
Line 650: 'filesSkipped': 0,
Line 651: 'totalSizeMoved': 
int(el.find('size').text),
Line 652: 'status': 
_getStatus(el.find('status').text)})
Bug https://bugzilla.redhat.com/show_bug.cgi?id=955611

will add the comments.
Line 653: 
Line 654: if len(nodesStatus) == 1:
Line 655: status['summary']['status'] = _getStatus(nodesStatus.pop())
Line 656: else:


Line 651: 'totalSizeMoved': 
int(el.find('size').text),
Line 652: 'status': 
_getStatus(el.find('status').text)})
Line 653: 
Line 654: if len(nodesStatus) == 1:
Line 655: status['summary']['status'] = _getStatus(nodesStatus.pop())
1. cli doesn't provide status in , will file a bug for that too.

2. If each node is in different state then it sets overall status as in 
progress(STARTED). Since set will remove duplicates, at the end set will have 
only one element if state of all nodes are same.
Line 656: else:
Line 657: status['summary']['status'] = TaskStatus.STARTED
Line 658: return status
Line 659: 


Line 653: 
Line 654: if len(nodesStatus) == 1:
Line 655: status['summary']['status'] = _getStatus(nodesStatus.pop())
Line 656: else:
Line 657: status['summary']['status'] = TaskStatus.STARTED
If each node is in different state then it sets overall status as in 
progress(STARTED).
Line 658: return status
Line 659: 
Line 660: 
Line 661: @makePublic


-- 
To view, visit http://gerrit.ovirt.org/18358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add task support

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: add task support
..


Patch Set 13:

(9 comments)


Commit Message
Line 16: {TASKID: {
Line 17:   "volume": VOLUMENAME,
Line 18:   "status": TaskStatus,
Line 19:   "type": TaskType,
Line 20:  "data": SUMMARY
Done
Line 21:   }, ...}
Line 22: 
Line 23: Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Line 24: Signed-off-by: Bala.FA 



File vdsm/gluster/tasks.py
Line 24: from cli import TaskType
Line 25: 
Line 26: 
Line 27: @makePublic
Line 28: def tasksList(taskId=None):
After decorator, this func will be exported as glusterTasksList(For xmlrpc and 
vdsClient)
Line 29: subRes = {}
Line 30: tasks = cli.volumeStatusAll()
Line 31: for tid in tasks:
Line 32: if taskId:


Line 25: 
Line 26: 
Line 27: @makePublic
Line 28: def tasksList(taskId=None):
Line 29: subRes = {}
I will update var name as result.
Line 30: tasks = cli.volumeStatusAll()
Line 31: for tid in tasks:
Line 32: if taskId:
Line 33: if tid != taskId:


Line 26: 
Line 27: @makePublic
Line 28: def tasksList(taskId=None):
Line 29: subRes = {}
Line 30: tasks = cli.volumeStatusAll()
If fails, exception will be raised inside volumeStatusAll()
Line 31: for tid in tasks:
Line 32: if taskId:
Line 33: if tid != taskId:
Line 34: continue


Line 32: if taskId:
Line 33: if tid != taskId:
Line 34: continue
Line 35: 
Line 36: try:
Done
Line 37: value = tasks[tid]
Line 38: data = {}
Line 39: state = value['status']
Line 40: if value['taskType'] == TaskType.REBALANCE:


Line 37: value = tasks[tid]
Line 38: data = {}
Line 39: state = value['status']
Line 40: if value['taskType'] == TaskType.REBALANCE:
Line 41: data = cli.volumeRebalanceStatus(value['volumeName'])
Done
Line 42: elif value['taskType'] == TaskType.REMOVE_BRICK:
Line 43: data = cli.volumeRemoveBrickStatus(value['volumeName'],
Line 44:value['bricks'])
Line 45: elif value['taskType'] == TaskType.REPLACE_BRICK:


Line 42: elif value['taskType'] == TaskType.REMOVE_BRICK:
Line 43: data = cli.volumeRemoveBrickStatus(value['volumeName'],
Line 44:value['bricks'])
Line 45: elif value['taskType'] == TaskType.REPLACE_BRICK:
Line 46: data = 
cli.volumeReplaceBrickStatus(value['volumeName'],
Two different functions: volumeRemoveBrickStatus and volumeReplaceBrickStatus
Line 47: value['bricks'][0],
Line 48: value['bricks'][1])
Line 49: 
Line 50: summary = data['summary'] if 'summary' in data else {}


Line 46: data = 
cli.volumeReplaceBrickStatus(value['volumeName'],
Line 47: value['bricks'][0],
Line 48: value['bricks'][1])
Line 49: 
Line 50: summary = data['summary'] if 'summary' in data else {}
Done
Line 51: subRes[tid] = {"volume": value['volumeName'],
Line 52:"status": state,
Line 53:"type": value['taskType'],
Line 54:"data": summary}


Line 52:"status": state,
Line 53:"type": value['taskType'],
Line 54:"data": summary}
Line 55: except ge.GlusterException:
Line 56: logging.error("gluster exception occured", exc_info=True)
Done


-- 
To view, visit http://gerrit.ovirt.org/10200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
..


Patch Set 5:

(9 comments)

To refresh Volume Size info in ovirt engine UI, engine may query VDSM verb 
number of times. Mounting GlusterFS volumes every time may be overhead when 
compared to libgfapi usage.


File client/vdsClientGluster.py
Line 715:   'Returns status of all gluster services if serviceName 
is '
Line 716:   'not set'
Line 717:   '(swift, glusterd, smb, memcached)'
Line 718:   )),
Line 719:  'glusterVolumeSizeInfoGet': (
Done
Line 720:  serv.do_glusterVolumeSizeInfoGet,
Line 721:  ('volumeName= [humanReadable=]',
Line 722:   'Returns total, free and used space(bytes) of gluster 
volume'
Line 723:   )),


Line 719:  'glusterVolumeSizeInfoGet': (
Line 720:  serv.do_glusterVolumeSizeInfoGet,
Line 721:  ('volumeName= [humanReadable=]',
Line 722:   'Returns total, free and used space(bytes) of gluster 
volume'
Line 723:   )),
Done



File vdsm.spec.in
Line 1271: %dir %{_datadir}/%{vdsm_name}/gluster
Line 1272: %doc COPYING
Line 1273: %{_datadir}/%{vdsm_name}/gluster/api.py*
Line 1274: %{_datadir}/%{vdsm_name}/gluster/vdsmapi-gluster-schema.json
Line 1275: %{_datadir}/%{vdsm_name}/gluster/gfapi.py*
Full support for libgfapi is not planned from our team as of now. Current plan 
is to show volume stats in ovirt engine UI.
Line 1276: %{_datadir}/%{vdsm_name}/gluster/hooks.py*
Line 1277: %{_datadir}/%{vdsm_name}/gluster/services.py*
Line 1278: %endif
Line 1279: 



File vdsm/gluster/api.py
Line 289: return {'services': status}
Line 290: 
Line 291: @exportAsVerb
Line 292: def volumeSizeInfoGet(self, volumeName, human_readable=False,
Line 293:   options=None):
Done
Line 294: """
Line 295: f_blocks = Total number of blocks
Line 296: f_bfree = Total number of blocks free
Line 297: f_bavail = Total number of blocks available for non root user


Line 293:   options=None):
Line 294: """
Line 295: f_blocks = Total number of blocks
Line 296: f_bfree = Total number of blocks free
Line 297: f_bavail = Total number of blocks available for non root user
As per http://docs.python.org/2/library/statvfs.html

Will update the comment with more description.
Line 298: total blocks available = f_blocks - (f_bfree - f_bavail)
Line 299: 
Line 300: @returns {
Line 301: 'total': TOTALBYTES,


Line 312: total = formatVolumeSizeHumanReadable(total)
Line 313: free = formatVolumeSizeHumanReadable(free)
Line 314: used = formatVolumeSizeHumanReadable(used)
Line 315: 
Line 316: return {'total': str(total), 'free': str(free), 'used': 
str(used)}
Will update the @return
Line 317: 
Line 318: 
Line 319: def getGlusterMethods(gluster):
Line 320: l = []



File vdsm/gluster/gfapi.py
Line 24: import exception as ge
Line 25: from . import makePublic
Line 26: 
Line 27: 
Line 28: GLUSTER_VOL_PROTOCAL = 'tcp'
Done
Line 29: GLUSTER_VOL_HOST = 'localhost'
Line 30: GLUSTER_VOL_PORT = 24007
Line 31: GLUSTER_VOL_PATH = "/"
Line 32: _api = None


Line 25: from . import makePublic
Line 26: 
Line 27: 
Line 28: GLUSTER_VOL_PROTOCAL = 'tcp'
Line 29: GLUSTER_VOL_HOST = 'localhost'
I will add protocal and host as optional parameter to vdsm verb.
Line 30: GLUSTER_VOL_PORT = 24007
Line 31: GLUSTER_VOL_PATH = "/"
Line 32: _api = None
Line 33: 


Line 61: return
Line 62: 
Line 63: 
Line 64: def _volumeMount(volumeId):
Line 65: fs = _api.glfs_new(volumeId)
Done
Line 66: _api.glfs_set_volfile_server(fs,
Line 67:  GLUSTER_VOL_PROTOCAL,
Line 68:  GLUSTER_VOL_HOST,
Line 69:  GLUSTER_VOL_PORT)


-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Using XML output for rebalance/remove-brick status 
verbs
..


Patch Set 2:

(2 comments)


File client/vdsClientGluster.py
Line 135: 
Line 136: def do_glusterVolumeRebalanceStatus(self, args):
Line 137: params = self._eqSplit(args)
Line 138: volumeName = params.get('volumeName', '')
Line 139: 
Done
Line 140: status = self.s.glusterVolumeRebalanceStatus(volumeName)
Line 141: pp.pprint(status)
Line 142: return status['status']['code'], status['status']['message']
Line 143: 



File vdsm/gluster/cli.py
Line 75: 
Line 76: class TaskType:
Line 77: REBALANCE = 'REBALANCE'
Line 78: REPLACE_BRICK = 'REPLACE_BRICK'
Line 79: REMOVE_BRICK = 'REMOVE_BRICK'
I missed out to move this to tasklist patch. Will copy this to other patch.
Line 80: 
Line 81: 
Line 82: class TaskStatus:
Line 83: NOT_STARTED = "NOT STARTED"


-- 
To view, visit http://gerrit.ovirt.org/18358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: ndarshan 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick/replace...

[avishwan]

Hello Bala.FA,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/18358

to review the following change.

Change subject: gluster: Using XML output for 
rebalance/remove-brick/replace-brick status verbs
..

gluster: Using XML output for rebalance/remove-brick/replace-brick status verbs

Modified rebalance/remove-brick/replace-brick status outputto consume XML
output provided by gluster cli command.

Modified verbs:
glusterVolumeRebalanceStatus
glusterVolumeReplaceBrickStatus
glusterVolumeRemoveBrickStatus

Change-Id: I7d277f267cf64d8af419d07367c33dc065f86a9b
Signed-off-by: Bala.FA 
Signed-off-by: Aravinda VK 
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm/gluster/vdsmapi-gluster-schema.json
5 files changed, 408 insertions(+), 55 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/18358/1

diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index 90af83e..38674bb 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -134,7 +134,10 @@
 return status['status']['code'], status['status']['message']
 
 def do_glusterVolumeRebalanceStatus(self, args):
-status = self.s.glusterVolumeRebalanceStatus(args[0])
+params = self._eqSplit(args)
+volumeName = params.get('volumeName', '')
+
+status = self.s.glusterVolumeRebalanceStatus(volumeName)
 pp.pprint(status)
 return status['status']['code'], status['status']['message']
 
@@ -188,8 +191,15 @@
 return status['status']['code'], status['status']['message']
 
 def do_glusterVolumeReplaceBrickStatus(self, args):
-status = self.s.glusterVolumeReplaceBrickStatus(args[0], args[1],
-args[2])
+params = self._eqSplit(args)
+volumeName = params.get('volumeName', '')
+existingBrick = params.get('existingBrick', '')
+newBrick = params.get('newBrick', '')
+
+status = self.s.glusterVolumeReplaceBrickStatus(volumeName,
+existingBrick,
+newBrick)
+pp.pprint(status)
 return status['status']['code'], status['status']['message']
 
 def do_glusterVolumeReplaceBrickCommit(self, args):
@@ -235,13 +245,16 @@
 return status['status']['code'], status['status']['message']
 
 def do_glusterVolumeRemoveBrickStatus(self, args):
-params = self._eqSplit(args[1:])
+params = self._eqSplit(args)
+volumeName = params.get('volumeName', '')
 try:
 brickList = params['bricks'].split(',')
 except:
 raise ValueError
 replicaCount = params.get('replica', '')
-status = self.s.glusterVolumeRemoveBrickStatus(args[0], brickList,
+
+status = self.s.glusterVolumeRemoveBrickStatus(volumeName,
+   brickList,
replicaCount)
 pp.pprint(status)
 return status['status']['code'], status['status']['message']
@@ -421,8 +434,6 @@
 raise ValueError
 
 status = self.s.glusterServicesGet(serviceNames)
-pp.pprint(status)
-return status['status']['code'], status['status']['message']
 
 
 def getGlusterCmdDict(serv):
@@ -503,7 +514,8 @@
   )),
  'glusterVolumeRebalanceStatus': (
  serv.do_glusterVolumeRebalanceStatus,
- ('\n\t is existing volume name',
+ ('volumeName=\n\t'
+  ' is existing volume name',
   'get volume rebalance status'
   )),
  'glusterVolumeDelete': (
@@ -548,8 +560,10 @@
   )),
  'glusterVolumeReplaceBrickStatus': (
  serv.do_glusterVolumeReplaceBrickStatus,
- ('   \n\t '
-  'is existing volume name\n\t is existing brick\n\t'
+ ('volumeName= existingBrick= '
+  'newBrick=\n\t'
+  ' is existing volume name\n\t'
+  ' is existing brick\n\t'
   ' is new brick',
   'get volume replace brick status'
   )),
@@ -580,9 +594,10 @@
   )),
  'glusterVolumeRemoveBrickStatus': (
  serv.do_glusterVolumeRemoveBrickStatus,
- (' [replica=] bricks=brick[,brick] ... \n\t'
-  ' is existing volume name\n\t is '
-  'existing brick',
+ ('volumeName= bricks= '
+  '[replica=]\n\t'
+  ' is existing volume name\n\t'
+  ' is existing brick(s)',
   'get volume remove bricks status'
   )),
  'glusterVolumeRemoveBrickCommit': (
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 4

Change in vdsm[master]: [WIP]gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: [WIP]gluster: Get size information of a gluster volume
..


Patch Set 4:

(2 comments)


File vdsm/gluster/api.py
Line 287: status = self.svdsmProxy.glusterServicesGet(serviceNames)
Line 288: return {'services': status}
Line 289: 
Line 290: @exportAsVerb
Line 291: def volumeSize(self, volumeName, options=None):
Done
Line 292: """
Line 293: f_blocks = Total number of blocks
Line 294: f_bfree = Total number of blocks free
Line 295: f_bavail = Total number of blocks available for non root user



File vdsm/gluster/gfapi.py
Line 29: GLUSTER_VOL_HOST = 'localhost'
Line 30: GLUSTER_VOL_PORT = 24007
Line 31: GLUSTER_VOL_PATH = "/"
Line 32: 
Line 33: class Stat (Structure):
Yes. It is compatible. But here we need to pass information about C datatype 
which maps to a field in Python Structure. I am not sure how we can use 
os.statvfs_result with ctypes. Will check.
Line 34: _fields_ = [
Line 35: ('f_bsize', c_ulong),
Line 36: ('f_frsize', c_ulong),
Line 37: ('f_blocks', c_ulong),


-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP]gluster: Get size information of a gluster volume

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: [WIP]gluster: Get size information of a gluster volume
..


Patch Set 4:

(8 comments)


File client/vdsClientGluster.py
Line 426: 
Line 427: def do_glusterVolumeSize(self, args):
Line 428: params = self._eqSplit(args)
Line 429: try:
Line 430: volumeName = params.get('volumeName', '')
Done
Line 431: except:
Line 432: raise ValueError
Line 433: 
Line 434: status = self.s.glusterVolumeSize(volumeName)


Line 428: params = self._eqSplit(args)
Line 429: try:
Line 430: volumeName = params.get('volumeName', '')
Line 431: except:
Line 432: raise ValueError
Done
Line 433: 
Line 434: status = self.s.glusterVolumeSize(volumeName)
Line 435: pp.pprint(status)
Line 436: return status['status']['code'], status['status']['message']


Line 718:   )),
Line 719:  'glusterVolumeSize': (
Line 720:  serv.do_glusterVolumeSize,
Line 721:  ('volumeName=',
Line 722:   'Returns total, available and used '
Done
Line 723:   'space status of gluster volume'
Line 724:   )),


Line 719:  'glusterVolumeSize': (
Line 720:  serv.do_glusterVolumeSize,
Line 721:  ('volumeName=',
Line 722:   'Returns total, available and used '
Line 723:   'space status of gluster volume'
Done
Line 724:   )),



File vdsm/gluster/api.py
Line 287: status = self.svdsmProxy.glusterServicesGet(serviceNames)
Line 288: return {'services': status}
Line 289: 
Line 290: @exportAsVerb
Line 291: def volumeSize(self, volumeName, options=None):
Since we don't have Set, do we need to change to Get?
Line 292: """
Line 293: f_blocks = Total number of blocks
Line 294: f_bfree = Total number of blocks free
Line 295: f_bavail = Total number of blocks available for non root user


Line 301: return {
Line 302: 'total': total_blocks_available * data.f_bsize / 1024,
Line 303: 'free': data['f_bavail'] * data['f_bsize'] / 1024,
Line 304: 'used': (total_blocks_available - data['f_bavail']) * \
Line 305: data['f_bsize'] / 1024
bytes.
Line 306: }
Line 307: 
Line 308: 
Line 309: def getGlusterMethods(gluster):



File vdsm/gluster/gfapi.py
Line 29: GLUSTER_VOL_HOST = 'localhost'
Line 30: GLUSTER_VOL_PORT = 24007
Line 31: GLUSTER_VOL_PATH = "/"
Line 32: 
Line 33: class Stat (Structure):
Here Stat is derived class of Structure which should be same as C structure 
which libgfapi uses. 

We can plan to use the os.statvfs_result format while returning statvfsData 
from the function volumeStatvfs
Line 34: _fields_ = [
Line 35: ('f_bsize', c_ulong),
Line 36: ('f_frsize', c_ulong),
Line 37: ('f_blocks', c_ulong),


Line 52: @makePublic
Line 53: def volumeStatvfs(volumeId):
Line 54: api.glfs_statvfs.restype = c_int
Line 55: api.glfs_statvfs.argtypes = [c_void_p, c_char_p, POINTER(Stat)]
Line 56: fs = api.glfs_new(volumeId)
Done
Line 57: api.glfs_set_volfile_server(fs,
Line 58: GLUSTER_VOL_PROTOCAL,
Line 59: GLUSTER_VOL_HOST,
Line 60: GLUSTER_VOL_PORT)


-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP]vdsmapi: gluster: vdsmapi schema definitions for existi...

[avishwan]

Aravinda VK has uploaded a new change for review.

Change subject: [WIP]vdsmapi: gluster: vdsmapi schema definitions for existing 
gluster verbs
..

[WIP]vdsmapi: gluster: vdsmapi schema definitions for existing gluster verbs

vdsmapi schema definitions for existing gluster vdsm verbs

Change-Id: I70d8c01176e8159e462d311b1241dbda0baf0bb2
Signed-off-by: Aravinda VK 
---
M vdsm/gluster/vdsmapi-gluster-schema.json
1 file changed, 465 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/18005/1

diff --git a/vdsm/gluster/vdsmapi-gluster-schema.json 
b/vdsm/gluster/vdsmapi-gluster-schema.json
index 7a4c034..2b8b106 100644
--- a/vdsm/gluster/vdsmapi-gluster-schema.json
+++ b/vdsm/gluster/vdsmapi-gluster-schema.json
@@ -372,3 +372,468 @@
 {'command': {'class': 'GlusterService', 'name': 'action'},
  'data': {'serviceName': 'str', 'action': 'GlusterServiceAction'},
  'returns': 'GlusterServicesStatusInfo'}
+
+## Category: @GlusterVolume 
##
+##
+# @GlusterVolume:
+#
+# Gluster Volume object.
+#
+# Since: 4.10.3
+##
+{'class': 'GlusterVolume'}
+
+##
+# @GlusterVolume.list:
+#
+# Get the list of Gluster volumes
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# List of Gluster volumes
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'list'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.create:
+#
+# Create a Gluster volume
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# Creates Gluster Volume
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'create'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.start:
+#
+# Start Gluster volume
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# Starts Gluster volume
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'start'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.stop:
+#
+# Stop Gluster volume
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# Stops Gluster volume
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'stop'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.delete:
+#
+# Deletes Gluster volume
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# Deletes Gluster volume
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'delete'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.set:
+#
+# Set Gluster volume options
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# Sets Gluster volume options
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'set'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.setOptionsList:
+#
+# Set multiple gluster volume options
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# Starts Gluster volume
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'setOptionsList'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.reset:
+#
+# Reset Gluster volume options
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# Resets Gluster volume options
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'reset'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.addBrick:
+#
+# Add Gluster volume brick
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# Add a brick to Gluster volume
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'addBrick'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.replaceBrickStart:
+#
+# Start Gluster volume brick replace
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# 
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'replaceBrickStart'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.replaceBrickAbort:
+#
+# Abort Gluster volume brick replace
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# 
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'replaceBrickAbort'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.replaceBrickPause:
+#
+# Pause Gluster volume brick replace
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# 
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'replaceBrickPause'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.replaceBrickStatus:
+#
+# Get status of Gluster volume brick replace
+#
+# @volumeName: Gluster volume name
+#
+# Returns:
+# 
+#
+# Since: 4.10.3
+##
+{'command': {'class': 'GlusterVolume', 'name': 'replaceBrickStatus'},
+ 'data': {'volumeName': 'str'},
+ 'returns': ''}
+
+##
+# @GlusterVolume.replaceBrickCommit:
+#
+# Commit Gluster volume brick replace
+#
+# @volumeName: Gluster volume n

Change in vdsm[master]: gluster: [WIP]Get size information of gluster volume

[avishwan]

Aravinda VK has uploaded a new change for review.

Change subject: gluster: [WIP]Get size information of gluster volume
..

gluster: [WIP]Get size information of gluster volume

Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Signed-off-by: Aravinda VK 
---
M client/vdsClientGluster.py
M vdsm.spec.in
M vdsm/gluster/Makefile.am
M vdsm/gluster/__init__.py
M vdsm/gluster/api.py
A vdsm/gluster/gfapi.py
6 files changed, 100 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/17822/1

diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index 90af83e..644bfe3 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -424,6 +424,17 @@
 pp.pprint(status)
 return status['status']['code'], status['status']['message']
 
+def do_glusterVolumeSize(self, args):
+params = self._eqSplit(args)
+try:
+volumeName = params.get('volumeName', '')
+except:
+raise ValueError
+
+status = self.s.glusterVolumeSize(volumeName)
+pp.pprint(status)
+return status['status']['code'], status['status']['message']
+
 
 def getGlusterCmdDict(serv):
 return \
@@ -705,4 +716,9 @@
   'not set'
   '(swift, glusterd, smb, memcached)'
   )),
+ 'glusterVolumeSize': (
+ serv.do_glusterVolumeSize,
+ ('volumeName=',
+  'Returns total, available and used space status of gluster 
volume'
+  )),
  }
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 21b3565..e49e102 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1271,6 +1271,7 @@
 %doc COPYING
 %{_datadir}/%{vdsm_name}/gluster/api.py*
 %{_datadir}/%{vdsm_name}/gluster/vdsmapi-gluster-schema.json
+%{_datadir}/%{vdsm_name}/gluster/gfapi.py*
 %{_datadir}/%{vdsm_name}/gluster/hooks.py*
 %{_datadir}/%{vdsm_name}/gluster/services.py*
 %endif
diff --git a/vdsm/gluster/Makefile.am b/vdsm/gluster/Makefile.am
index dd5434d..9c2989f 100644
--- a/vdsm/gluster/Makefile.am
+++ b/vdsm/gluster/Makefile.am
@@ -26,6 +26,7 @@
api.py \
cli.py \
exception.py \
+   gfapi.py \
hooks.py \
hostname.py \
services.py \
diff --git a/vdsm/gluster/__init__.py b/vdsm/gluster/__init__.py
index bec70ea..e5a2fd6 100644
--- a/vdsm/gluster/__init__.py
+++ b/vdsm/gluster/__init__.py
@@ -22,7 +22,7 @@
 import tempfile
 from functools import wraps
 
-MODULE_LIST = ('cli', 'hooks', 'services')
+MODULE_LIST = ('cli', 'hooks', 'services', 'gfapi')
 
 
 def makePublic(func):
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 4bd8308..89546c1 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -287,6 +287,22 @@
 status = self.svdsmProxy.glusterServicesGet(serviceNames)
 return {'services': status}
 
+@exportAsVerb
+def volumeSize(self, volumeName, options=None):
+data = self.svdsmProxy.glusterVolumeStatvfs(volumeName)
+# f_blocks = Total number of blocks
+# f_bfree = Total number of blocks free
+# f_bavail = Total number of blocks available for non root user
+# total blocks available = f_blocks - (f_bfree - f_bavail)
+total_blocks_available = data['f_blocks'] - \
+(data['f_bfree'] - data['f_bavail'])
+return {
+'total': total_blocks_available * data.f_bsize / 1024,
+'free': data['f_bavail'] * data['f_bsize'] / 1024,
+'used': (total_blocks_available - data['f_bavail']) * \
+data['f_bsize'] / 1024
+}
+
 
 def getGlusterMethods(gluster):
 l = []
diff --git a/vdsm/gluster/gfapi.py b/vdsm/gluster/gfapi.py
new file mode 100644
index 000..abfdabd
--- /dev/null
+++ b/vdsm/gluster/gfapi.py
@@ -0,0 +1,65 @@
+#
+# Copyright 2013 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from ctypes import *
+
+# import exception as ge
+from . import makePublic
+
+GLUSTER_VOL_PROTOCAL='tcp'
+GLUSTER_VOL_HOST='localhost'
+GLUSTER_VOL_PORT=24007
+
+class Stat (Structure):
+_fields_ = [
+('f_bsize', c_ulong),
+('f_frs

Change in vdsm[master]: dumpStorageTable: fixed a unhandled exception when poollist ...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: dumpStorageTable: fixed a unhandled exception when poollist is 
empty
..


Patch Set 3: (1 inline comment)


File vdsm/dumpStorageTable.py.in
Line 166: for header in self.columns:
Line 167: self.tbl[header] = []
Line 168: 
Line 169: pools = self.serverConncetion.getConnectedStoragePoolsList()
Line 170: if not pools['poollist']:
The script is printing empty tabular structure in cli.
Line 171: return
Line 172: 
Line 173: self.pool = pools['poollist'][0]
Line 174: 


-- 
To view, visit http://gerrit.ovirt.org/14886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98b6bb29720cb21627dc8f1e23dd90126c3bf0b4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: humble devassy 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
..


Patch Set 8: Verified

-- 
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Giuseppe Vallarelli 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
..


Patch Set 7: No score

(3 inline comments)


File vdsm/gluster/cli.py
Line 110: 
Line 111: def _getGlusterUuid():
Line 112: command = _getGlusterSystemCmd() + ["uuid", "get"]
Line 113: rc, out, err = _execGluster(command)
Line 114: if not rc:
If error then condition will fail and returns empty string.
Line 115: try:
Line 116: return dict(["".join(out).split(': ', 1)]).get('UUID', '')
Line 117: except ValueError:
Line 118: # Empty string will be returned in the end so just


Line 112: command = _getGlusterSystemCmd() + ["uuid", "get"]
Line 113: rc, out, err = _execGluster(command)
Line 114: if not rc:
Line 115: try:
Line 116: return dict(["".join(out).split(': ', 1)]).get('UUID', '')
Done
Line 117: except ValueError:
Line 118: # Empty string will be returned in the end so just
Line 119: # ignore the ValueError here
Line 120: pass


Line 118: # Empty string will be returned in the end so just
Line 119: # ignore the ValueError here
Line 120: pass
Line 121: 
Line 122: return ''
Exception is raised if UUID is empty in the "hostUUIDGet" below. 

This was the existing function which was consumed by "peerStatus" verb, so 
return value is not changed. 

Failure cases are when gluster cli fails to return or parsing issue.
Line 123: 
Line 124: 
Line 125: def _parseVolumeStatus(tree):
Line 126: status = {'name': 
tree.find('volStatus/volumes/volume/volName').text,


-- 
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Giuseppe Vallarelli 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 23: No score

(10 inline comments)


File vdsm/gluster/Makefile.am
Line 27:cli.py \
Line 28:exception.py \
Line 29:hooks.py \
Line 30:hostname.py \
Line 31:services.py
Done
Line 32: 
Line 33: dist_vdsmgluster_DATA = \
Line 34:vdsmapi-gluster-schema.json \



File vdsm/gluster/services.py
Line 22: from vdsm.tool import service
Line 23: from . import makePublic
Line 24: 
Line 25: 
Line 26: ALLOWED_SERVICES = ["glusterd",
Done
Line 27: "memcached",
Line 28: "gluster-swift-proxy",
Line 29: "gluster-swift-container",
Line 30: "gluster-swift-object",


Line 56: def _formatStatus(serviceName, status, message=''):
Line 57: return {'name': serviceName, 'status': status, 'message': message}
Line 58: 
Line 59: 
Line 60: def _serviceStatus(serviceName, failOnError=False):
Done
Line 61: rc = service.service_status(serviceName)
Line 62: 
Line 63: if rc == 0:
Line 64: return _formatStatus(serviceName, StatusTypes.RUNNING)


Line 69: rc1 = service.service_is_managed(serviceName)
Line 70: if rc1 == 0:
Line 71: return _formatStatus(serviceName, StatusTypes.STOPPED)
Line 72: else:
Line 73: return _formatStatus(serviceName, StatusTypes.NOT_AVAILABLE)
If a supported service is not available in Host then it returns NOT_AVAILABLE. 
SUPPORTED_SERVICES is a list to restrict consumer of api to call only those 
services. (Ex: Stopping vdsmd is not supported)
Line 74: 
Line 75: 
Line 76: def _serviceAction(serviceName, action, failOnError=False):
Line 77: if action == ServiceActions.STATUS:


Line 109: else:
Line 110: if not failOnError:
Line 111: resp = _formatStatus(serviceName, 
StatusTypes.NOT_SUPPORTED)
Line 112: else:
Line 113: raise 
ge.GlusterServiceNotSupportedException(sName=serviceName)
Both are same. I will change the variable name as SUPPORTED_SERVICES
Line 114: 
Line 115: statusOutput.append(resp)
Line 116: 
Line 117: return statusOutput


Line 117: return statusOutput
Line 118: 
Line 119: 
Line 120: @makePublic
Line 121: def servicesManage(serviceNames, action, failOnError=False):
Since it is capable of handling Start, Stop, Restart as of now. We thought 
manage makes more sense. 

I will change this to servicesAction.
Line 122: """
Line 123: {'services': [
Line 124: {'name': SERVICE_NAME, 'status': STATUS, 'message': 
MESSAGE},..]}
Line 125: """


Line 119: 
Line 120: @makePublic
Line 121: def servicesManage(serviceNames, action, failOnError=False):
Line 122: """
Line 123: {'services': [
Done
Line 124: {'name': SERVICE_NAME, 'status': STATUS, 'message': 
MESSAGE},..]}
Line 125: """
Line 126: action = action.lower()
Line 127: return _action(serviceNames, action, failOnError)


Line 122: """
Line 123: {'services': [
Line 124: {'name': SERVICE_NAME, 'status': STATUS, 'message': 
MESSAGE},..]}
Line 125: """
Line 126: action = action.lower()
Done
Line 127: return _action(serviceNames, action, failOnError)
Line 128: 
Line 129: 
Line 130: @makePublic


Line 127: return _action(serviceNames, action, failOnError)
Line 128: 
Line 129: 
Line 130: @makePublic
Line 131: def servicesGet(serviceNames, failOnError=False):
I will update commit message.

Since the verb accepts multiple service names and does action, If failOnError 
is False then VDSM exception will not be raised If any one service fails, and 
returns error details in "message" in return dict, and status will be ERROR.
Line 132: """
Line 133: {'services': [
Line 134: {'name': SERVICE_NAME, 'status': STATUS, 'message': 
MESSAGE},..]}
Line 135: """



File vdsm/gluster/vdsmapi-gluster-schema.json
Line 260: # @RUNNING:Service is Running
Line 261: #
Line 262: # @STOPPED:Service is Stopped
Line 263: #
Line 264: # @NOT_AVAILABLE:Service is not managed/available
Yes
Line 265: #
Line 266: # @NOT_SUPPORTED:Service is not allowed to manage
Line 267: #
Line 268: # @ERROR:Service action failed


-- 
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: 

Change in vdsm[master]: dumpStorageTable: fixed a unhandled exception when poollist ...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: dumpStorageTable: fixed a unhandled exception when poollist is 
empty
..


Patch Set 3: Verified

-- 
To view, visit http://gerrit.ovirt.org/14886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98b6bb29720cb21627dc8f1e23dd90126c3bf0b4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: humble devassy 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 23: Verified

When using vdsm.tool.service as library it raises exception unlike non zero 
return value when run in commandline. 

Updated exception handling as per Zhou Zheng Sheng's suggestion.

-- 
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 22: Verified

Changed the way of using vdsm-tool/service. 

Initially gluster verb was calling vdsm-tool command as system command, but we 
observed CPU usage too high(~70-90%) while querying status repeatedly. 

Now modified code to use service as module instead of external tool.(from 
vdsm.tool import service)

-- 
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
..


Patch Set 7:

Gluster CLI changes merged to 3.4 branch.
http://review.gluster.org/#/c/5204/

-- 
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Giuseppe Vallarelli 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 21: Verified

Rebased since all dependent patches got merged.

-- 
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix remove disabled hook exception handling error

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: fix remove disabled hook exception handling error
..


Patch Set 2: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.ovirt.org/15506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37e27f2a42e663c74fa2f8a3f43f31b28a72840
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
..


Patch Set 7: Verified

Updated the patch to use new gluster cli(gluster system:: uuid get) command to 
get UUID instead of reading directly from the file 
/var/lib/glusterd/glusterd.info

-- 
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Giuseppe Vallarelli 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
..


Patch Set 6: No score

Gluster team is planning to introduce new cli command to read uuid and avoids 
reading uuid info directly from /var/lib/glusterd/glusterd.info. 

I will modify my patch to use the new command. 

Ref: http://review.gluster.org/#/c/5175/

-- 
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Giuseppe Vallarelli 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: multipath.py: use vdsm.tool.service to restart multipathd

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: multipath.py: use vdsm.tool.service to restart multipathd
..


Patch Set 6: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.ovirt.org/14728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1130a4baf770b805aaea8de97556d18a2da86207
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: avoid service action redirections

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: avoid service action redirections
..


Patch Set 4: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.ovirt.org/15099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idff541a724e3e2d2167b1f235af5ed04a3dc2ee0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: extend service module to cover alternative servic...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: extend service module to cover alternative service 
names
..


Patch Set 8: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.ovirt.org/14720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: extend "service" module to check existence of a s...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: extend "service" module to check existence of a 
service
..


Patch Set 4: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.ovirt.org/15100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23a7d98e39eaacd5f2dfa817bfae6defb5fc9ebe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix remove disabled hook exception handling error

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: fix remove disabled hook exception handling error
..


Patch Set 1: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.ovirt.org/15506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37e27f2a42e663c74fa2f8a3f43f31b28a72840
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
..


Patch Set 6: Verified

Rebased with master again, since one more gluster patch merged(15331)

--
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Giuseppe Vallarelli 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
..


Patch Set 5: Verified

Updated vdsmapi-gluster-schema as discussed with Adam in IRC.
Rebased to latest master.

--
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 20: Verified

Rebased with master since Gluster Hooks patch got merged.

--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: extend "service" module to check existence of a s...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: extend "service" module to check existence of a 
service
..


Patch Set 3: Looks good to me, but someone else must approve

Tested in Fedora 18.

--
To view, visit http://gerrit.ovirt.org/15100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23a7d98e39eaacd5f2dfa817bfae6defb5fc9ebe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: avoid service action redirections

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: avoid service action redirections
..


Patch Set 3: Looks good to me, but someone else must approve

Tested in Fedora 18.

--
To view, visit http://gerrit.ovirt.org/15099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idff541a724e3e2d2167b1f235af5ed04a3dc2ee0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: extend service module to cover alternative servic...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: extend service module to cover alternative service 
names
..


Patch Set 7: Looks good to me, but someone else must approve

Tested in Fedora 18.

--
To view, visit http://gerrit.ovirt.org/14720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: avoid service action redirections

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: avoid service action redirections
..


Patch Set 3: No score

This patch needs rebase, since dependent patch is merged.

--
To view, visit http://gerrit.ovirt.org/15099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idff541a724e3e2d2167b1f235af5ed04a3dc2ee0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: avoid service action redirections

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: avoid service action redirections
..


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/15099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idff541a724e3e2d2167b1f235af5ed04a3dc2ee0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: multipath.py: use vdsm.tool.service to restart multipathd

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: multipath.py: use vdsm.tool.service to restart multipathd
..


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/14728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1130a4baf770b805aaea8de97556d18a2da86207
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Fix vdsm gluster api schema error

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Fix vdsm gluster api schema error
..


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/15331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f54251a99bff1a16d6bc2a3e692855dab6c8561
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 19: Verified

--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
..


Patch Set 4: No score

(1 inline comment)


File vdsm/gluster/vdsmapi-gluster-schema.json
Line 156: #
Line 157: # Since: 4.10.3
Line 158: ##
Line 159: {'type': 'HostUUID',
Line 160:  'data': {'uuid': 'UUID'}}
If we use 'str' in returns, do we need to modify the output of verb 
http://gerrit.ovirt.org/#/c/13785/4/vdsm/gluster/api.py 

The existing output from that verb is created as dict because status and 
message will be added in xmlrpc output. 

Please clarify.
Line 161: 
Line 162: ##
Line 163: # @GlusterHost.uuid:
Line 164: #


--
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 18: No score

(1 inline comment)


File vdsm/gluster/vdsmapi-gluster-schema.json
Line 243: # status information for list of services
Line 244: #
Line 245: # Since: 4.10.3
Line 246: ##
Line 247: {'command': {'class': 'GlusterService', 'name': 'get'},
Done
Line 248:  'data': {'serviceName': 'str', 'action': 'GlusterServiceAction', 
'failOnError': 'bool'},


--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Supervdsm didn't create pid file when starting up

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: Supervdsm didn't create pid file when starting up
..


Patch Set 1: (1 inline comment)


File vdsm/supervdsmServer.py
Line 360: sys.exit(errno.EPERM)
Line 361: 
Line 362: pidfile = P_VDSM_RUN + 'supervdsmd.pid'
Line 363: pid = str(os.getpid())
Line 364: file(pidfile, 'w').write(pid + "\n")
file is not closed? can we use 

with open(pidfile, 'w') as f:
f.write(pid+"\n")
Line 365: 
Line 366: log.debug("Parsing cmd args")
Line 367: address = sys.argv[1]
Line 368: 


--
To view, visit http://gerrit.ovirt.org/15196
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I649179ca1c614dfcff91da9fada785c57303f57c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 18: Verified

Rebased and modified according to Zhou Zheng Sheng's comments.

--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 17: (1 inline comment)


File vdsm/gluster/exception.py
Line 36: class GlusterException(VdsmException):
Line 37: code = 4100
Line 38: message = "Gluster Exception"
Line 39: rc = 0
Line 40: out = []
Will submit separate patch for this fix. Looks like additional changes required 
which is not part of this patch.
Line 41: err = []
Line 42: 
Line 43: def __init__(self, rc=0, out=[], err=[]):
Line 44: self.rc = rc


--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 17: No score

(4 inline comments)


File vdsm/gluster/exception.py
Line 36: class GlusterException(VdsmException):
Line 37: code = 4100
Line 38: message = "Gluster Exception"
Line 39: rc = 0
Line 40: out = []
Done
Line 41: err = []
Line 42: 
Line 43: def __init__(self, rc=0, out=[], err=[]):
Line 44: self.rc = rc


Line 38: message = "Gluster Exception"
Line 39: rc = 0
Line 40: out = []
Line 41: err = []
Line 42: 
Done
Line 43: def __init__(self, rc=0, out=[], err=[]):
Line 44: self.rc = rc
Line 45: self.out = out
Line 46: self.err = err


Line 435: 
Line 436: def __init__(self, action=''):
Line 437: prefix = "%s: " % (action)
Line 438: self.message = prefix + "Service action is not supported"
Line 439: self.err = self.message
Done
Line 440: 
Line 441: 
Line 442: class GlusterServiceManageFailedException(GlusterServiceException):
Line 443: code = 4552


Line 453: 
Line 454: def __init__(self, sName=''):
Line 455: prefix = "%s: " % (sName)
Line 456: self.message = prefix + "Service not supported"
Line 457: self.err = self.message
Done


--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: verbs for managing services

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: verbs for managing services
..


Patch Set 17: Verified

--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: Extend vdsm.tool.service to cover alternative service names
..


Patch Set 4: Looks good to me, but someone else must approve

Tested in Fedora 18

--
To view, visit http://gerrit.ovirt.org/14720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: extend "service" module to check existence of a s...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: extend "service" module to check existence of a 
service
..


Patch Set 1: Looks good to me, but someone else must approve

Tested in Fedora 18

--
To view, visit http://gerrit.ovirt.org/15100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23a7d98e39eaacd5f2dfa817bfae6defb5fc9ebe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: avoid service action redirections

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: avoid service action redirections
..


Patch Set 1: Looks good to me, but someone else must approve

Tested in Fedora 18.

--
To view, visit http://gerrit.ovirt.org/15099
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idff541a724e3e2d2167b1f235af5ed04a3dc2ee0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: service operations do not trigger abrt warning on...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: vdsm-tool: service operations do not trigger abrt warning on 
RHEL6
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/15098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddac6c6d1b6f47fe653ca4a86cc3a89f5ed4efb6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added verbs for read, update, add and remove hooks

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Added verbs for read, update, add and remove hooks
..


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/14145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie123356209aa0f71176bd06b9c53e0e96211e716
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dumpStorageTable: fixed a unhandled exception when poollist ...

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: dumpStorageTable: fixed a unhandled exception when poollist is 
empty
..


Patch Set 1: (1 inline comment)


File vdsm/dumpStorageTable.py.in
Line 168: pools = self.serverConncetion.getConnectedStoragePoolsList()
Line 169: if len(pools['poollist']) > 0:
Line 170: self.pool = pools['poollist'][0]
Line 171: else:
Line 172: self.pool = ""
Python crash dump when poollist is empty, empty pool prevents Python exception 
and returns empty table. 

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=961816
Line 173: 
Line 174: # Check if its possible to access the ovf files
Line 175: try:
Line 176: files = os.listdir(os.path.join(DC, self.pool, 
MASTERSD_PATH))


--
To view, visit http://gerrit.ovirt.org/14886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98b6bb29720cb21627dc8f1e23dd90126c3bf0b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: humble devassy 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dumpStorageTable: fixed a unhandled exception when poollist ...

[avishwan]

Aravinda VK has uploaded a new change for review.

Change subject: dumpStorageTable: fixed a unhandled exception when poollist is 
empty
..

dumpStorageTable: fixed a unhandled exception when poollist is empty

when poollist is empty then dumpStorageTable was failing with
'IndexError: list index out of range', Also crash dump was reported
in /var/log/messages

Change-Id: I98b6bb29720cb21627dc8f1e23dd90126c3bf0b4
Signed-off-by: Aravinda VK 
---
M vdsm/dumpStorageTable.py.in
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/14886/1

diff --git a/vdsm/dumpStorageTable.py.in b/vdsm/dumpStorageTable.py.in
index 7562a35..7d01e51 100644
--- a/vdsm/dumpStorageTable.py.in
+++ b/vdsm/dumpStorageTable.py.in
@@ -166,7 +166,10 @@
 self.tbl[header] = []
 
 pools = self.serverConncetion.getConnectedStoragePoolsList()
-self.pool = pools['poollist'][0]
+if len(pools['poollist']) > 0:
+self.pool = pools['poollist'][0]
+else:
+self.pool = ""
 
 # Check if its possible to access the ovf files
 try:


--
To view, visit http://gerrit.ovirt.org/14886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98b6bb29720cb21627dc8f1e23dd90126c3bf0b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added verbs for read, update, add and remove hooks

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Added verbs for read, update, add and remove hooks
..


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/14145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie123356209aa0f71176bd06b9c53e0e96211e716
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added verbs for read, update, add and remove hooks

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Added verbs for read, update, add and remove hooks
..


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)


File vdsm/gluster/hooks.py
Line 219: raise ge.GlusterHookCheckSumMismatchException(md5Sum, 
hookMd5Sum)
Line 220: 
Line 221: if enable or hookStat[0]:
Line 222: safeWrite(enabledFile, content)
Line 223: os.chmod(enabledFile, stat.S_IXUSR)
To enable permission, use the same method as enableHook.
Line 224: else:
Line 225: safeWrite(disabledFile, content)
Line 226: 
Line 227: 


Line 253: def hookRemove(glusterCmd, hookLevel, hookName):
Line 254: enabledFile, disabledFile = _getHookFileNames(glusterCmd,
Line 255:   hookLevel.lower(),
Line 256:   hookName)
Line 257: try:
Use hookStat comparison as used in earlier verb, try delete only if file is 
available and raise error if fails to remove for both enabled and disabled 
file. 

if hookStat[0]:
try:
# os remove
except:
raise
Line 258: os.remove(enabledFile)
Line 259: except OSError, e:
Line 260: if errno.ENOENT != e.errno:
Line 261: errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror, 
e.filename)


--
To view, visit http://gerrit.ovirt.org/14145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie123356209aa0f71176bd06b9c53e0e96211e716
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: new vdsm verb glusterHostUUIDGet
..


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added gluster hooks support

[avishwan]

Aravinda VK has posted comments on this change.

Change subject: gluster: Added gluster hooks support
..


Patch Set 30: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3918aa035d90967f1297dc7fadcf14b6a9385c45
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Aravinda VK 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches