Change in vdsm[master]: fileSD: Optimize getAllVolumes on file storage
Eduardo has posted comments on this change.
Change subject: fileSD: Optimize getAllVolumes on file storage
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36593/2/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line 409:
Line 410: Return dict {volUUID: ((imgUUIDs,), parentUUID)} of the
domain.
Line 411:
Line 412: Template self image is the first item in template volume
images tuple.
Line 413: The parent uuid is available only for template volumes.
Templates have not parent.
Line 414:
Line 415: Setting parent = None for compatibility with block version.
Line 416:
Line 417: volMetaPattern = os.path.join(self.mountpoint, self.sdUUID,
--
To view, visit http://gerrit.ovirt.org/36593
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc19ce272b7e0b9c91d2f90aa46b5ddd21d69ece
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@gmail.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Add an option to replace locking type 4
Eduardo has posted comments on this change. Change subject: lvm: Add an option to replace locking type 4 .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Create storage domain using command type 1
Eduardo has posted comments on this change.
Change subject: Create storage domain using command type 1
..
Patch Set 7: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/23646/7/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 132: return LVM_ENC_ESCAPE.sub(lambda c: unichr(int(c.groups()[0])), s)
Line 133:
Line 134:
Line 135: def encodeVgTags(tagsDict):
Line 136: tags = [VGTagMetadataRW.METADATA_TAG_PREFIX +
More efficient will be to build the tuple directly.
Line 137: lvmTagEncode(%s=%s % (k, v))
Line 138: for k, v in tagsDict.items()]
Line 139: return tuple(tags)
Line 140:
Line 570: # no one reads it from here anyway
Line 571: initialMetadata = {
Line 572: sd.DMDK_VERSION: version,
Line 573: sd.DMDK_SDUUID: sdUUID,
Line 574: sd.DMDK_TYPE:
BLOCK_SD_MD_FIELDS[sd.DMDK_TYPE][1](storageType),
Add a comment please explaining the use of the MD encoding please.
Line 575: sd.DMDK_CLASS:
BLOCK_SD_MD_FIELDS[sd.DMDK_CLASS][1](domClass),
Line 576: sd.DMDK_DESCRIPTION: domainName,
Line 577: sd.DMDK_ROLE: sd.REGULAR_DOMAIN,
Line 578: sd.DMDK_POOLS: BLOCK_SD_MD_FIELDS[sd.DMDK_POOLS][1]([]),
Line 599:
Line 600: # Mark VG with Storage Domain Tag
Line 601: try:
Line 602: lvm.replaceVGTag(vgName, STORAGE_UNREADY_DOMAIN_TAG,
Line 603: STORAGE_DOMAIN_TAG, safe=False)
safe=False? IMHO it is not required anymore (previous version). Unify all this
tag changes please.
Line 604: except se.StorageException:
Line 605: raise se.VolumeGroupUninitialized(vgName)
Line 606:
Line 607: bsd = BlockStorageDomain(sdUUID)
http://gerrit.ovirt.org/#/c/23646/7/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 1052: # Public Logical volume interface
Line 1053: #
Line 1054:
Line 1055:
Line 1056: def _completeCreateLV(rc, vgName, lvName, activate=True):
I really dislike the complete part of the name.
Line 1057: if rc == 0:
Line 1058: _lvminfo._invalidatevgs(vgName)
Line 1059: _lvminfo._invalidatelvs(vgName, lvName)
Line 1060: else:
Line 1090: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName,
)), rw=True)
Line 1091: _completeCreateLV(rc, vgName, lvName)
Line 1092:
Line 1093:
Line 1094: def createLV(vgName, lvName, size, activate=True, contiguous=False,
The contiguous flag can be dropped, unifiying the cmd part of the 3 .*createLV
functions in the internal part.
Line 1095: initialTag=None):
Line 1096:
Line 1097: Size units: MB (1024 ** 2 = 2 ** 20)B.
Line 1098:
Line 1091: _completeCreateLV(rc, vgName, lvName)
Line 1092:
Line 1093:
Line 1094: def createLV(vgName, lvName, size, activate=True, contiguous=False,
Line 1095: initialTag=None):
For regular LVs, not special, image related ones the initialTag is mandatory,
simplifiying the code.
Line 1096:
Line 1097: Size units: MB (1024 ** 2 = 2 ** 20)B.
Line 1098:
Line 1099: # WARNING! From man vgs:
--
To view, visit http://gerrit.ovirt.org/23646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Eduardo has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Code-Review-1 (2 comments) How this patch solves the canDoAction engine warning logged in the BZ? http://gerrit.ovirt.org/#/c/25778/8//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-03-24 19:21:30 +0200 Line 4: Commit: Tal Nisan tni...@redhat.com Line 5: CommitDate: 2014-03-25 18:10:15 +0200 Line 6: Line 7: Allow moving of sparse images to a block domains Should be noted that this is valid for copy operations too. Line 8: Line 9: When attempting to move a sparse image from a file domain to a block domain Line 10: the destination image is created as sparse which is not supported on block Line 11: domains. http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py File vdsm/storage/image.py: Line 357: # To avoid prezeroing preallocated volumes on NFS domains Line 358: # we create the target as a sparse volume (since it will be Line 359: # soon filled with the data coming from the copy) and then Line 360: # we change its metadata back to the original value. Line 361: if destDom.supportsSparseness: This logic should be moved to .*Volume._create() functions, simplifiying the logic and restore here and removing SD.createVolume() driver function. Additionally the misuse of sparse parameter for block volumes instead of thin can be clarified. Line 362: tmpVolPreallocation = volume.SPARSE_VOL Line 363: else: Line 364: tmpVolPreallocation = volume.PREALLOCATED_VOL Line 365: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: setDomainRegularRole is implemented by backend
Eduardo has posted comments on this change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
Patch Set 1: Code-Review-1
(1 comment)
Modern engines never try to call deactivateSD in order to migrate MSD.
Please check if this functionality is supported for current versions. If not,
masterMigrate() can be safely removed solving the actual issue and more.
http://gerrit.ovirt.org/#/c/24495/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 810: except Exception:
Line 811: self.log.exception('migration to new master failed')
Line 812: try:
Line 813: self._backend.setDomainRegularRole(newmsd)
Line 814: except Exception:
The issue here is with catch all sentence causing a programming mistake being
reported as migration to new master failed.
Please remove this try except clause.
Narrow the big try except since we really don't expect that log.debug raises
and replace it with try finally or a with block wich will release (only) the
cluster lock.
There is no point to holding the newmsd master fs mounted after the
finalization of the tarCopy() call.
This way master fs and pool MD codes can be splited and more sensible code can
be produced.
Line 815: self.log.exception('unable to mark domain %s as
regular',
Line 816:newmsd.sdUUID)
Line 817:
Line 818: # Do not release the cluster lock if unmount fails. The
lock
--
To view, visit http://gerrit.ovirt.org/24495
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia49e45ccab0b933a8f1abc988ea0bd60e7b99b7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: fix spm start when failing to produce domain
Eduardo has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: Line 212: # log any exception, but keep going Line 213: self.log.error(Error trying to check/update domain %s role, Dan, 2. How are you attaching such domain? Why is still there the former pool MD? Do you understand the implications = bugs? Line 214:sdUUID, exc_info=True) Line 215: Line 216: @unsecured Line 217: def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None): Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: Line 212: # log any exception, but keep going Line 213: self.log.error(Error trying to check/update domain %s role, Dan, SPM _should not_ start or continue in the same if it is not capable to reach all the pools domains. Line 214:sdUUID, exc_info=True) Line 215: Line 216: @unsecured Line 217: def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None): -- To view, visit http://gerrit.ovirt.org/25424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: fix spm start when failing to produce domain
Eduardo has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 207: if domain.getDomainRole() == sd.REGULAR_DOMAIN: Line 208: continue Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: Regardless of changes in the engine that you think that should be done (I d This was merged in 3.0. (vdsm-4.9-112, Nov 7 16:45:00 2011) Therefore has nothing to do with BC. If any engine version expects SPM to start when no all the SDs are reacheable this is wrong and should be fixed, as was explained before. Is not what I think that should be done, it is basic oVirt knowledge. Line 212: # log any exception, but keep going Line 213: self.log.error(Error trying to check/update domain %s role, Line 214:sdUUID, exc_info=True) Line 215: -- To view, visit http://gerrit.ovirt.org/25424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: fix spm start when failing to produce domain
Eduardo has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 207: if domain.getDomainRole() == sd.REGULAR_DOMAIN: Line 208: continue Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: This change was introduced by I2ecf801d58b34c1c811e311e3779887a406af5f0 on You are wrong. Change-Id: I593060e354c0bdc9b19f4e11a376094d83e567ce Anyway maintaining wrong behaviours is not BC . Line 212: # log any exception, but keep going Line 213: self.log.error(Error trying to check/update domain %s role, Line 214:sdUUID, exc_info=True) Line 215: -- To view, visit http://gerrit.ovirt.org/25424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: fix spm start when failing to produce domain
Eduardo has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 207: if domain.getDomainRole() == sd.REGULAR_DOMAIN: Line 208: continue Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: As Sergey wrote, it was introduced in I2ecf801d58b34c1c811e311e3779887a406a Use your git-fu and look in 3.0! Line 212: # log any exception, but keep going Line 213: self.log.error(Error trying to check/update domain %s role, Line 214:sdUUID, exc_info=True) Line 215: Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: Line 212: # log any exception, but keep going Line 213: self.log.error(Error trying to check/update domain %s role, Eduardo, this is behavior change that is debatable (and we can discuss it r Your are killing any sense of the SPM semantics and you can understand it if you were so kind to read other people comments, in this patch and in the BZ. As stated in the BZ you have nothing to do with monitor domains, use getStorageDomainsList() in order to discover reachable domains. (Supported on all versions.) Your requeriments and behavioral changes are the result of careless changes in the engine reconstruct flows. Line 214:sdUUID, exc_info=True) Line 215: Line 216: @unsecured Line 217: def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None): -- To view, visit http://gerrit.ovirt.org/25424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: fix spm start when failing to produce domain
Eduardo has posted comments on this change. Change subject: sp: fix spm start when failing to produce domain .. Patch Set 2: Code-Review-2 (1 comment) http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 207: if domain.getDomainRole() == sd.REGULAR_DOMAIN: Line 208: continue Line 209: Line 210: self._backend.setDomainRegularRole(domain) Line 211: except Exception: SPM start should fail if one of the domains is unreacheable by the host designated of the SPM. Allowing this behaviour can lead, among others, to a situation when extend request of VMs using the missing SD are not served. If at any point in time one of the domains is unreacheable by the host, spm property should be lost. The missing domain is reported by SPM and should be used by engine to find another host to be SPM or to change the pool definition accordingly. Line 212: # log any exception, but keep going Line 213: self.log.error(Error trying to check/update domain %s role, Line 214:sdUUID, exc_info=True) Line 215: -- To view, visit http://gerrit.ovirt.org/25424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid to recompile namedtuple ATTR classes in lvm.
Eduardo has posted comments on this change. Change subject: Avoid to recompile namedtuple ATTR classes in lvm. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25678/1/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 220: args[LV._fields.index(tags)] = tags Line 221: # Convert attr string into named tuple fields. Line 222: sAttr = args[LV._fields.index(attr)] Line 223: attr_values = tuple(sAttr[:len(LV_ATTR._fields)]) Line 224: attrs = LV_ATTR(*attr_values) This change introduce duplication that the _attr2NamedTupple function preve Your suggested change only makes the code hard to follow. The new code can be only one line then clearly is no use for a function here. May be will be a case for unifying makeVG() and makeLV() but IMHO will make the code arcane without real gains. _attr2NamedTuple() purpose was to deal with this attributes dynamically. After years of use we have no deal with strings like this except this two specific points. Line 225: args[LV._fields.index(attr)] = attrs Line 226: # Add properties. Should be ordered as VG_PROPERTIES. Line 227: args.append(attrs.permission == w) # writable Line 228: args.append(attrs.devopen == o) # opened -- To view, visit http://gerrit.ovirt.org/25678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Meital Bourvine mbour...@redhat.com Gerrit-Reviewer: Meital bourvine meitalbourv...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid to recompile namedtuple ATTR classes in lvm.
Eduardo has uploaded a new change for review.
Change subject: Avoid to recompile namedtuple ATTR classes in lvm.
..
Avoid to recompile namedtuple ATTR classes in lvm.
Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447
Signed-off-by: Eduardo ewars...@redhat.com
---
M vdsm/storage/lvm.py
1 file changed, 9 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/25678/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 0fbed29..d963736 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -61,7 +61,9 @@
PV = namedtuple(PV, PV_FIELDS + ,guid)
VG = namedtuple(VG, VG_FIELDS + ,writeable,partial)
+VG_ATTR = namedtuple(VG_ATTR, VG_ATTR_BITS)
LV = namedtuple(LV, LV_FIELDS + ,writeable,opened,active)
+LV_ATTR = namedtuple(LV_ATTR, LV_ATTR_BITS)
Stub = namedtuple(Stub, name, stale)
@@ -185,19 +187,6 @@
return tuple(sTags.split(,)) if sTags else tuple()
-def _attr2NamedTuple(sAttr, attrMask, label):
-
-Converts a attr string into a named tuple.
-
-Fields are named as in attrMask.
-
-Attrs = namedtuple(label, attrMask)
-# tuple(wz--n-) = ('w', 'z', '-', '-', 'n', '-')
-values = tuple(sAttr[:len(attrMask)])
-attrs = Attrs(*values)
-return attrs
-
-
def makePV(*args):
guid = os.path.basename(args[1])
args += (guid,)
@@ -210,8 +199,10 @@
tags = _tags2Tuple(args[VG._fields.index(tags)])
args[VG._fields.index(tags)] = tags
# Convert attr string into named tuple fields.
-attrs = _attr2NamedTuple(args[VG._fields.index(attr)], VG_ATTR_BITS,
- VG_ATTR)
+# tuple(wz--n-) = ('w', 'z', '-', '-', 'n', '-')
+sAttr = args[VG._fields.index(attr)]
+attr_values = tuple(sAttr[:len(VG_ATTR._fields)])
+attrs = VG_ATTR(*attr_values)
args[VG._fields.index(attr)] = attrs
# Convert pv_names list to tuple.
args[VG._fields.index(pv_name)] = \
@@ -228,8 +219,9 @@
tags = _tags2Tuple(args[LV._fields.index(tags)])
args[LV._fields.index(tags)] = tags
# Convert attr string into named tuple fields.
-attrs = _attr2NamedTuple(args[LV._fields.index(attr)], LV_ATTR_BITS,
- LV_ATTR)
+sAttr = args[LV._fields.index(attr)]
+attr_values = tuple(sAttr[:len(LV_ATTR._fields)])
+attrs = LV_ATTR(*attr_values)
args[LV._fields.index(attr)] = attrs
# Add properties. Should be ordered as VG_PROPERTIES.
args.append(attrs.permission == w) # writable
--
To view, visit http://gerrit.ovirt.org/25678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid redundant volume produces.
Eduardo has posted comments on this change. Change subject: Avoid redundant volume produces. .. Patch Set 1: This change is should relevant. Should be rebased, verified by QE and merged. -- To view, visit http://gerrit.ovirt.org/17991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ad53a7e8a66d7f9bdd62048f2bf1f722a490c5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rename *Volume.extend method to *Volume.enlarge
Eduardo has posted comments on this change. Change subject: Rename *Volume.extend method to *Volume.enlarge .. Patch Set 1: This patch enlights what the function does and in addition simplifies grepping the code avoiding confusion with list extend methods. Should be merged. -- To view, visit http://gerrit.ovirt.org/17802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7b88067fa3fe2c19faab31d0c882b4494f0bc12 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 2: In spite that as said in the commit message there are not consumers today for this info may be worth to return the proper info until the key is removed. May be merged. -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4
Eduardo has posted comments on this change.
Change subject: [WIP] lvm: Add an option to replace locking type 4
..
Patch Set 2: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 256: self._filterStale = False
Line 257:
Line 258: return self._extraCfg
Line 259:
Line 260: def _addExtraCfg(self, cmd, devices=tuple(), safe):
Safe should have a default value or be before devices.
Line 261: newcmd = [constants.EXT_LVM, cmd[0]]
Line 262: if devices:
Line 263: conf = _buildConfig(devices)
Line 264: else:
Line 291: self._pvs = {}
Line 292: self._vgs = {}
Line 293: self._lvs = {}
Line 294:
Line 295: def cmd(self, cmd, devices=tuple(), safe=True):
May be better (TM) to change safe=True for lvm cluster safe commands?
(Inverting the value semantics.)
Line 296:
Line 297: Use safe as False only for lvm cluster safe commands.
Line 298: These are cmds that don't change metadata of an existing VG.
Line 299:
Line 945: cmd = [vgcreate] + options + [vgName] + pvs
Line 946: rc, out, err = _lvminfo.cmd(cmd, tuple(pvs), False)
Line 947: if rc == 0:
Line 948: _lvminfo._invalidatepvs(pvs)
Line 949: _lvminfo._invalidatevgs(vgName)
May be worth to add stubs instead invalidating the whole cache since this
operations are now orthogonal to any value already present in the caches.
Anyway this is a different patch.
Line 950: log.debug(Cache after createvg %s, _lvminfo._vgs)
Line 951: else:
Line 952: raise se.VolumeGroupCreateError(vgName, pvs)
Line 953:
Line 946: rc, out, err = _lvminfo.cmd(cmd, tuple(pvs), False)
Line 947: if rc == 0:
Line 948: _lvminfo._invalidatepvs(pvs)
Line 949: _lvminfo._invalidatevgs(vgName)
Line 950: log.debug(Cache after createvg %s, _lvminfo._vgs)
This log should be removed in production code.
Line 951: else:
Line 952: raise se.VolumeGroupCreateError(vgName, pvs)
Line 953:
Line 954:
--
To view, visit http://gerrit.ovirt.org/23645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage domain using command type 1
Eduardo has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 516: raise se.StorageDomainIsMadeFromTooManyPVs() Line 517: Line 518: # Create metadata service volume Line 519: metasize = cls.metaSize(vgName) Line 520: lvm.createLV(vgName, sd.METADATA, %s % (metasize), safe=False) Look at the lvm code comment. Line 521: # Create the mapping right now so the index 0 is guaranteed Line 522: # to belong to the metadata volume. Since the metadata is at Line 523: # least SDMETADATA/METASIZE units, we know we can use the first Line 524: # SDMETADATA bytes of the metadata volume for the SD metadata. http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 654: This fuction is so restrictive as we can do. Line 655: log.debug(### _current_lvmconf %s, globals()[_current_lvmconf]) Line 656: globals()[_current_lvmconf] = _current_lvmconf.replace(locking_type=4, Line 657: locking_type=1) Line 658: log.debug(### _current_lvmconf %s, globals()[_current_lvmconf]) These logs should be updated before production. Line 659: Line 660: Line 661: def bootstrap(refreshlvs=()): Line 662: Line 1061: # Line 1062: Line 1063: Line 1064: def createLV(vgName, lvName, size, activate=True, contiguous=False, Line 1065: initialTag=None, safe=True): createLV operates on an existing VG making safe parameters misuse very dangerous at this time. If the intention is to use this parameter only when the SD is created may be an alternative method should be found lioke spliting the function for createLV() for images volumes and createSpecialVolumes which are created only at SD creation and never modified, making this parameter redundant. Line 1066: Line 1067: Size units: MB (1024 ** 2 = 2 ** 20)B. Line 1068: Line 1069: # WARNING! From man vgs: Line 1280: Line 1281: return os.path.exists(lvPath(vgName, lvName)) Line 1282: Line 1283: Line 1284: def changeVGTags(vgName, delTags=(), addTags=(), safe=True): Again, this change is dangerous and very misleading. IMHO separating the only valid case for a non-SPM doing this operation (create) will be more in line with the purpose of this series. The new function should be more simple than the actual changeVGTags since it operates in a known set of tags. Please note that actually createSD() is the only user of replaceVGtags . Therefore you can change it there and the split is natural and you need not to change changeVGTags() function. Line 1285: delTags = set(delTags) Line 1286: addTags = set(addTags) Line 1287: if delTags.intersection(addTags): Line 1288: raise se.VolumeGroupReplaceTagError( Line 1321: if rc != 0: Line 1322: raise se.VolumeGroupRemoveTagError(vgName) Line 1323: Line 1324: Line 1325: def replaceVGTag(vg, oldTag, newTag, safe=True): Please see above. Line 1326: changeVGTags(vg, [oldTag], [newTag], safe) Line 1327: Line 1328: Line 1329: def addVGTags(vgName, tags): -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage domain using command type 1
Eduardo has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage pool using command type 1
Eduardo has posted comments on this change.
Change subject: [WIP] Create storage pool using command type 1
..
Patch Set 2: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 529: # to belong to the metadata volume. Since the metadata is at
Line 530: # least SDMETADATA/METASIZE units, we know we can use the
first
Line 531: # SDMETADATA bytes of the metadata volume for the SD metadata.
Line 532: # pass metadata's dev to ensure it is the first mapping
Line 533: #mapping = cls.getMetaDataMapping(vgName)
in final version comment needs to move with code and this needs to disappea
We already know that the mapping is redundant and it can be removed.
This is a different patch.
Line 534:
Line 535: # Create the rest of the BlockSD internal volumes
Line 536: lvm.createLV(vgName, sd.LEASES, sd.LEASES_SIZE, safe=False)
Line 537: lvm.createLV(vgName, sd.IDS, sd.IDS_SIZE, safe=False)
Line 593: }
Line 594:
Line 595: initialMetadata.update(mapping)
Line 596: toAdd = encodeVgTags(initialMetadata)
Line 597: lvm.changeVGTags(vgName, delTags=(), addTags=toAdd,
safe=False)
if it is not safe/possible to call md.update then need to explain this
IMHO is better to use the unused addVGTags() here. Since this function is
actually unused can be safely converted to lock_type=1 only and assert that no
new consumers are added. This is probably True since for any other option than
a create will use changeVGTags() since a set of tags already exists.
Line 598:
Line 599: # Mark VG with Storage Domain Tag
Line 600: try:
Line 601: lvm.replaceVGTag(vgName, STORAGE_UNREADY_DOMAIN_TAG,
Line 1318: for k, v in params.iteritems():
Line 1319: enc = poolMD.getEncoder(k)
Line 1320: newParams[k] = enc(v)
Line 1321: toAdd = encodeVgTags(newParams)
Line 1322: lvm.changeVGTags(vgName, deltags=(), addTags=toAdd,
safe=False)
Use addVGTags() instead as discussed.
Line 1323:
Line 1324: def setMasterDomainParams(self, spUUID, leaseParams):
Line 1325: vgUUID = self.getInfo()['vguuid']
Line 1326: vg = lvm.getVGbyUUID(vgUUID)
Line 1330: sd.DMDK_ROLE: sd.MASTER_DOMAIN})
Line 1331: toDel = encodeVgTags({sd.DMDK_ROLE: sd.REGULAR_DOMAIN,
Line 1332: sd.DMDK_POOLS: spUUID,
Line 1333: sd.DMDK_POOLS: ''})
Line 1334: lvm.changeVGTags(vgName, delTags=toDel, addTags=toAdd,
safe=False)
IMHO simpler using the replaceVGTags() change already discussed.
Line 1335:
Line 1336: def refreshDirTree(self):
Line 1337: # create domain images folder
Line 1338: imagesPath = os.path.join(self.domaindir, sd.DOMAIN_IMAGES)
http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 941: misc.validateUUID(spUUID, 'spUUID')
Line 942: if masterDom not in domList:
Line 943: raise se.InvalidParameterException(masterDom,
str(masterDom))
Line 944:
Line 945: if len(domList) 1:
==1 semantics will be more strict.
Line 946: raise NotImplementedError(Create storage pool
Line 947: only with master domain)
Line 948:
Line 949: if len(poolName) MAX_POOL_DESCRIPTION_SIZE:
http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/sd.py
File vdsm/storage/sd.py:
Line 768:
Line 769: def isMaster(self):
Line 770: return self.getMetaParam(DMDK_ROLE).capitalize() ==
MASTER_DOMAIN
Line 771:
Line 772: @classmethod
initMasterParams() is always called as an instance method. Then this should not
be a classmethod.
Since this called during pool creation/reconstruction all this redundant calls,
including the spbackend mess can be avoided IMHO.
Line 773: def initMasterParams(cls, poolMD, params):
Line 774: poolMD.update(params)
Line 775:
Line 776: def setMasterDomainParams(self, spUUID, leaseParams):
--
To view, visit http://gerrit.ovirt.org/23647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64f6dd2df38d2968f03ce66094f3ba7b4343503
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] destroy storage pool using command type 1
Eduardo has posted comments on this change.
Change subject: [WIP] destroy storage pool using command type 1
..
Patch Set 1: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/24398/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 1366: self.log.error(
Line 1367: Can't remove pool %s from domain %s pool list %s,
Line 1368: it does not exist,
Line 1369: spUUID, self.sdUUID, str(pools))
Line 1370: return
Use an else: block please instead this ugly return.
Line 1371: vgUUID = self.getInfo()['vguuid']
Line 1372: vg = lvm.getVGbyUUID(vgUUID)
Line 1373: vgName = vg.name
Line 1374: toAdd = encodeVgTags({sd.DMDK_POOLS: '',
Line 1369: spUUID, self.sdUUID, str(pools))
Line 1370: return
Line 1371: vgUUID = self.getInfo()['vguuid']
Line 1372: vg = lvm.getVGbyUUID(vgUUID)
Line 1373: vgName = vg.name
This block (3 lines) seems to me to be an echo from code a long time gone.
vgName is self.sdUUID.
Please remove this redundant calls.
Line 1374: toAdd = encodeVgTags({sd.DMDK_POOLS: '',
Line 1375: sd.DMDK_ROLE: sd.REGULAR_DOMAIN})
Line 1376: toDel = encodeVgTags({sd.DMDK_POOLS: spUUID,
Line 1377: sd.DMDK_ROLE: sd.MASTER_DOMAIN})
Line 1374: toAdd = encodeVgTags({sd.DMDK_POOLS: '',
Line 1375: sd.DMDK_ROLE: sd.REGULAR_DOMAIN})
Line 1376: toDel = encodeVgTags({sd.DMDK_POOLS: spUUID,
Line 1377: sd.DMDK_ROLE: sd.MASTER_DOMAIN})
Line 1378: lvm.changeVGTags(vgName, delTags=toDel, addTags=toAdd,
safe=False)
Since detachMaster is called only from hsm.destroyStoragePool() and the domain
was already removed from the pool MD, you can avoid here the use of
changeVGtags replacing it by addVGTags and remVGTags as was discussed in a
previous patch.
The operations will be logically atomic and no one should try ever to access
the domain between the removal and the adiditon of the role tag.
You can lock the master domain at hsm.destroyStoragePool() to be sure and this
covers the previous forceDetach() call.
Line 1379:
Line 1380: def refresh(self):
Line 1381: self.refreshDirTree()
Line 1382: lvm.invalidateVG(self.sdUUID)
--
To view, visit http://gerrit.ovirt.org/24398
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67cda9abd0bbc01d7d0642d5d3327f8687d7f728
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] destroy storage pool using command type 1
Eduardo has posted comments on this change. Change subject: [WIP] destroy storage pool using command type 1 .. Patch Set 1: After review the engine part: 1) all the regular domains are detached and removed. 2) destroy StoragePool is sent and afterwards the former master domain is removed. Therefore this patch can be greatly simplified if the MSD is removed when the pool is destroyed in a unique lvm operation. -- To view, visit http://gerrit.ovirt.org/24398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67cda9abd0bbc01d7d0642d5d3327f8687d7f728 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage domain using command type 1
Eduardo has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 1280: Line 1281: return os.path.exists(lvPath(vgName, lvName)) Line 1282: Line 1283: Line 1284: def changeVGTags(vgName, delTags=(), addTags=(), safe=True): create is not the only valid case non-SPM doing this operation, Please look at the comments in the last patch of this series. changeVGtags() can be avoided in the destroySP(). In addition destroyStoragePool can remove the entire MD of the domain or remove it enterily without changes to the subsequent formatStorageDomain(). The actual logic is inconsistent. In any case changeVGTags with locking type 1 without being SPM is not required. Line 1285: delTags = set(delTags) Line 1286: addTags = set(addTags) Line 1287: if delTags.intersection(addTags): Line 1288: raise se.VolumeGroupReplaceTagError( -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding monitorPoolDomains replacing connectStoragePool.
Eduardo has abandoned this change. Change subject: Adding monitorPoolDomains replacing connectStoragePool. .. Abandoned Obsoleted by HE changes. -- To view, visit http://gerrit.ovirt.org/11937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1db3aeb5d2c3ab5a4ad90c175bc3e576726f0336 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Update LUN size when starting a vm
Eduardo has posted comments on this change. Change subject: vm: Update LUN size when starting a vm .. Patch Set 6: Code-Review-1 (1 comment) File vdsm/clientIF.py Line 267: Line 268: # Update size for LUN volume Line 269: # Note: should be revisited when introducing Line 270: # manual refresh of storage target functionality. Line 271: volSize = self.irs.getVolumeSize(drive[GUID]) Use the getVolumeInfo interface. get*Size interfaces should be removed. Line 272: drive[truesize] = volSize['truesize'] Line 273: drive[apparentsize] = volSize['apparentsize'] Line 274: Line 275: # UUID drive format -- To view, visit http://gerrit.ovirt.org/22976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Update LUN size when starting a vm
Eduardo has posted comments on this change.
Change subject: vm: Update LUN size when starting a vm
..
Patch Set 5:
(4 comments)
File vdsm/clientIF.py
Line 263: res = self.irs.appropriateDevice(drive[GUID], vmId)
Line 264: if res['status']['code']:
Line 265: raise vm.VolumeError(drive)
Line 266:
Line 267: # Update size for LUN volume
Please add a comment here indicating that this should be removed when the issue
is solved with the appropiate refresh of the storage target, and this is a
compromise solution.
Line 268: volSize = self.irs.getVolumeSize(drive[GUID])
Line 269: drive[truesize] = volSize['truesize']
Line 270: drive[apparentsize] = volSize['apparentsize']
Line 271:
File vdsm/storage/hsm.py
Line 2991: sdUUID=sdUUID).produceVolume(imgUUID=imgUUID,
Line 2992:
volUUID=volUUID).refreshVolume()
Line 2993:
Line 2994: @public
Line 2995: def getVolumeSize(self, *args):
Daniel you are right with a general get size interface for a volume being
independent of the identifier passed.
Please consider passing a tuple for the PDIV. This way all the signatures will
have the same number of arguments.
Line 2996: if len(args) == 1:
Line 2997: return self._getLUVolumeSize(args[0])
Line 2998: else:
Line 2999: return self._getPDIVSize(args[0], args[1], args[2],
args[3])
Line 2997: return self._getLUVolumeSize(args[0])
Line 2998: else:
Line 2999: return self._getPDIVSize(args[0], args[1], args[2],
args[3])
Line 3000:
Line 3001: def _getLUVolumeSize(self, devGUID, options=None):
The name should be getLUSize IMHO. Logical Unit is descriptive enough for
anybody with basic storage knowledge.
Line 3002:
Line 3003: Gets the size of a LUN device volume.
Line 3004:
Line 3005: :param devGUID: The LUN device GUID.
File vdsm/vm.py
Line 632: dStats = {'truesize': str(vmDrive.truesize),
Line 633: 'apparentsize': str(vmDrive.apparentsize)}
Line 634: if isVdsmImage(vmDrive):
Line 635: dStats['imageID'] = vmDrive.imageID
Line 636: if vmDrive.GUID:
elif should be used here since up to now the PDIVs are not identified by GUIDs.
The usage criteria of PDIV or Direct LU is the 'GUID' key being present in the
drive specification dictionary. Please change your condition.
You need to be very careful and check that the all the dStats can be filled for
any Direct LU usage and dStats info is enough for all the consumers.
Line 637: dStats['lunGUID'] = vmDrive.GUID
Line 638: dStats['readRate'] = ((eInfo[dName][1] -
sInfo[dName][1]) /
Line 639: sampleInterval)
Line 640: dStats['writeRate'] = ((eInfo[dName][3] -
sInfo[dName][3]) /
--
To view, visit http://gerrit.ovirt.org/22976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdc: Change error messages to info
Eduardo has posted comments on this change. Change subject: sdc: Change error messages to info .. Patch Set 1: Code-Review-2 Already discussed. There is no spontaneous SD generation. Should not be unfetched domains, then if such thing exists, they should be reported as ERROR. An ERROR log is not a bug, is for help developers to understand degraded conditions or raise eyebrows. This log is no so frequent nor is the root cause of the issue here. Changing to info or debug is misleading and improve nothing. grep ERROR for opening bugs is a bad practice. The log dissapeared from 3.2. -- To view, visit http://gerrit.ovirt.org/21597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.
Eduardo has posted comments on this change. Change subject: getStorageDomainInfo: SP keys when disconnected. .. Patch Set 2: Verified+1 [root@camel-vdsb ~]# vdsClient -s 0 getStorageDomainInfo 0c3606f8-e509-4007-ae1e-aa023d7a0a94 uuid = 0c3606f8-e509-4007-ae1e-aa023d7a0a94 vguuid = lge2ds-GmcH-g3c6-sMP9-3c9q-7rf9-IIvd06 lver = 4 state = OK version = 3 role = Master pool = ['6e6a4fb2-3ec2-44f1-b07c-2d4f5acaee66'] spm_id = -1 type = ISCSI class = Data master_ver = 2 name = ddd -- To view, visit http://gerrit.ovirt.org/19555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix PEP 8 issue.
Eduardo has uploaded a new change for review.
Change subject: Fix PEP 8 issue.
..
Fix PEP 8 issue.
Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47
Signed-off-by: Eduardo ewars...@redhat.com
---
M lib/vdsm/ipwrapper.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/21578/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index 5e5ec29..c50b376 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -125,8 +125,8 @@
tokens = [token for token in processedData[1].split(' ') if token]
linkType = tokens.pop(0)
attrs['linkType'] = linkType
-attrs.update((linkType + tokens[i], tokens[i+1]) for i in
- range(0, len(tokens)-1, 2))
+attrs.update((linkType + tokens[i], tokens[i + 1]) for i in
+ range(0, len(tokens) - 1, 2))
return attrs
@classmethod
--
To view, visit http://gerrit.ovirt.org/21578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4952ab9cb3bfce0f787568369ead45c09aece47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove irs_enable configuration attribute
Eduardo has posted comments on this change. Change subject: remove irs_enable configuration attribute .. Patch Set 3: Code-Review+1 Dan we already agreed on the need of modularize vdsm. This configuration variable is not related to that, is only an echo the past (2008) which not delivers the modularization you want and is misleading. In addition is not supported by the engine. About actual use cases for it I think that nobody has seen such thing . -- To view, visit http://gerrit.ovirt.org/21141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove irs_enable configuration attribute
Eduardo has posted comments on this change. Change subject: remove irs_enable configuration attribute .. Patch Set 2: Code-Review+1 (2 comments) File vdsm/clientIF.py Line 247: while self._enabled: Line 248: time.sleep(3) Line 249: Line 250: def _initIRS(self): Line 251: self.irs = None Can this be removed? If not, it should be under the except clause. Line 252: try: Line 253: self.irs = Dispatcher(HSM()) Line 254: except: Line 255: self.log.error(Error initializing IRS, exc_info=True) Line 250: def _initIRS(self): Line 251: self.irs = None Line 252: try: Line 253: self.irs = Dispatcher(HSM()) Line 254: except: I would like a narrow except only because you are touching it, but... Line 255: self.log.error(Error initializing IRS, exc_info=True) Line 256: else: Line 257: self.irs.registerDomainStateChangeCallback(self.contEIOVms) Line 258: -- To view, visit http://gerrit.ovirt.org/21141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster prepareImage: return gluster-sepecific information
Eduardo has posted comments on this change. Change subject: gluster prepareImage: return gluster-sepecific information .. Patch Set 2: Code-Review-1 (4 comments) * Add WIP * Rephrase your commit message * Merge Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e Commit Message Line 7: gluster prepareImage: return gluster-sepecific information Line 8: Line 9: Since the introduction of gLuster storage domains, prepareImage retuns Line 10: and additional element beyond the path to the leaf: a dictionary keyed Line 11: by info, carrying gluster-specific information. This way is a serious error and should be corrected. Merging it was a mistake. Line 12: Line 13: This dictionary has been mistakenly dropped by a recent refactoring of Line 14: prepareImage. This patch re-inroduces the lost functionality, in the Line 15: price of a redundant production of a volume. To make this a little less Line 9: Since the introduction of gLuster storage domains, prepareImage retuns Line 10: and additional element beyond the path to the leaf: a dictionary keyed Line 11: by info, carrying gluster-specific information. Line 12: Line 13: This dictionary has been mistakenly dropped by a recent refactoring of This erroneous extra dictionary was evicted in order to make possible the HE introduction. Line 14: prepareImage. This patch re-inroduces the lost functionality, in the Line 15: price of a redundant production of a volume. To make this a little less Line 16: expensive, we limit the production to gluster volumes. Line 17: Line 12: Line 13: This dictionary has been mistakenly dropped by a recent refactoring of Line 14: prepareImage. This patch re-inroduces the lost functionality, in the Line 15: price of a redundant production of a volume. To make this a little less Line 16: expensive, we limit the production to gluster volumes. No need for. As we agreed this info should be retrieved using getVolumeInfo(). Merge Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e in order to implement the correct solution of this issue. Line 17: Line 18: This path is not the child we've prayed for, but it works. Line 19: Line 20: Special thanks to Samuli Heinonen samp...@neutraali.net for reporting Line 14: prepareImage. This patch re-inroduces the lost functionality, in the Line 15: price of a redundant production of a volume. To make this a little less Line 16: expensive, we limit the production to gluster volumes. Line 17: Line 18: This path is not the child we've prayed for, but it works. ?! Line 19: Line 20: Special thanks to Samuli Heinonen samp...@neutraali.net for reporting Line 21: the bug and testing this patch. Line 22: -- To view, visit http://gerrit.ovirt.org/21059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9a8fbf2baafa1f9bfc3677b1301c7934ca74651 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG
Eduardo has posted comments on this change. Change subject: Invalidate filters on HSMs before rescanning extended VG .. Patch Set 18: Code-Review-1 Very respectfully I disagree with this solution. My opinion is that the design should be revised. A long mail about sent. -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant supervsdm.validateAccess.
Eduardo has abandoned this change. Change subject: Remove redundant supervsdm.validateAccess. .. Abandoned We need to unify this functions anyway. -- To view, visit http://gerrit.ovirt.org/20838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Prevent auto-activation of vdsm logical volumes
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-activation of vdsm logical volumes
..
Patch Set 5: Code-Review-1
(1 comment)
File vdsm/storage/lvm.py
Line 787:
Line 788: def _setLVAvailability(vg, lvs, available):
Line 789: attrs = LV_ACTIVATE_FLAGS if available == y else
LV_DEACTIVATE_FLAGS
Line 790: try:
Line 791: changelv(vg, lvs, attrs)
Adding here instead in changelv() the skip flags requires from each caller
doing activation to send the proper flag and being aware of the defined
constants.
Line 792: except se.StorageException as e:
Line 793: error = ({y: se.CannotActivateLogicalVolumes,
Line 794: n: se.CannotDeactivateLogicalVolume}
Line 795: .get(available, se.VolumeGroupActionError))
--
To view, visit http://gerrit.ovirt.org/20832
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Prevent auto-actviation of logical volumes
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1: Verified-1 Code-Review-1
(6 comments)
Commit Message
Line 16: lvm 2.02.100.
Line 17:
Line 18: To make this change easy, lvm.changelv() was modified to accept
variable
Line 19: argument tuples, instead of multiple non-related types. This also
Line 20: simplify the only caller that use multiple arguments.
This change is not required and gives less functionality.
Line 21:
Line 22: Note: upgrade of existing volumes is not implemented yet.
Line 23:
Line 24: Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0
Line 18: To make this change easy, lvm.changelv() was modified to accept
variable
Line 19: argument tuples, instead of multiple non-related types. This also
Line 20: simplify the only caller that use multiple arguments.
Line 21:
Line 22: Note: upgrade of existing volumes is not implemented yet.
The change of existing volumes should be changed with a little app running when
installing or upgrading vdsm.
In addition should be runable from command line.
Should not be part of the vdsm code.
Line 23:
Line 24: Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0
Line 25: Bug-Url: https://bugzilla.redhat.com/1009812
File vdsm/storage/blockSD.py
Line 990: operation and is resilient to open LVs, etc.
Line 991:
Line 992: prefix = blockVolume.TAG_PREFIX_IMAGE
Line 993: try:
Line 994: lvm.changelv(sdUUID, volUUIDs, (--available, y),
This change is not required and gives less functionality.
Line 995: (--deltag, prefix + imgUUID),
Line 996: (--addtag, prefix + opTag + imgUUID))
Line 997: except se.StorageException as e:
Line 998: log.error(Can't activate or change LV tags in SD %s.
File vdsm/storage/lvm.py
Line 755:
Line 756: vg: VG name
Line 757: lvs: a single LV name or iterable of LV names.
Line 758: attrs: lvchange argument tupples. Use None value for unary
options.
Line 759:e.g. ('--attr', 'value'), ('--unary', None)
There is no vdsm use for unary operators.
The interface is cumbersome.
Line 760:
Line 761: Note:
Line 762: You may activate an activated LV without error
Line 763: but lvchange returns an error (RC=5) when activating rw if
already rw
Line 772: for attr, value in attrs:
Line 773: cmd.append(attr)
Line 774: if value is not None:
Line 775: cmd.append(value)
Line 776: if attr in (-a, --available, --activate) and value ==
y:
The if is redundant. Simply add --ignoreactivationskip for all the lvchanges.
Since vdsm is specifically activating the lvs, the modifier is required.
For other changes is a noop.
Line 777: cmd.append('--ignoreactivationskip')
Line 778: cmd.extend(lvnames)
Line 779: rc, out, err = _lvminfo.cmd(tuple(cmd), _lvminfo._getVGDevs((vg,
)))
Line 780: _lvminfo._invalidatelvs(vg, lvs)
Line 1022: cont = {True: y, False: n}[contiguous]
Line 1023: cmd = [lvcreate]
Line 1024: cmd.extend(LVM_NOBACKUP)
Line 1025: cmd.extend((--contiguous, cont, --size, %sm % size,
Line 1026: --setactivationskip, y))
--setactivationskip y requires either --zero n or --ignoreactivationskip
Line 1027: if initialTag is not None:
Line 1028: cmd.extend((--addtag, initialTag))
Line 1029: cmd.extend((--name, lvName, vgName))
Line 1030: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
--
To view, visit http://gerrit.ovirt.org/20832
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Prevent auto-activation of logical volumes.
Eduardo has uploaded a new change for review.
Change subject: lvm: Prevent auto-activation of logical volumes.
..
lvm: Prevent auto-activation of logical volumes.
When using FC storage, physical volumes are connected during boot,
and vdsm logical volumes are auto-activated by /etc/rc.sysinit
and/or /etc/init.d/netfs.
This patch prevents auto-activation of vdsm volumes using new
--setactivationskip and --ignoreactivationskip options, introduced
in lvm 2.02.100.
Note: The change of existing volumes should be done with a little app
running when installing or upgrading vdsm. In addition it should be
executable from command line. Should not be part of the vdsm code.
Change-Id: Iab9b7579990d934c60999b4c603c3acf46557be1
Bug-Url: https://bugzilla.redhat.com/1009812
Signed-off-by: Eduardo ewars...@redhat.com
---
M vdsm/storage/lvm.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/20836/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 0c2964e..2561ae4 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -769,6 +769,7 @@
lvnames = tuple(%s/%s % (vg, lv) for lv in lvs)
cmd = [lvchange]
cmd.extend(LVM_NOBACKUP)
+cmd.append('--ignoreactivationskip')
if isinstance(attrs[0], str):
# (--attribute, value)
cmd.extend(attrs)
@@ -1023,7 +1024,8 @@
cont = {True: y, False: n}[contiguous]
cmd = [lvcreate]
cmd.extend(LVM_NOBACKUP)
-cmd.extend((--contiguous, cont, --size, %sm % size))
+cmd.extend((--setactivationskip, y, --ignoreactivationskip,
+--contiguous, cont, --size, %sm % size))
if initialTag is not None:
cmd.extend((--addtag, initialTag))
cmd.extend((--name, lvName, vgName))
--
To view, visit http://gerrit.ovirt.org/20836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab9b7579990d934c60999b4c603c3acf46557be1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Prevent auto-actviation of logical volumes
Eduardo has posted comments on this change. Change subject: lvm: Prevent auto-actviation of logical volumes .. Patch Set 1: Please look at: Change-Id: Iab9b7579990d934c60999b4c603c3acf46557be1 -- To view, visit http://gerrit.ovirt.org/20832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Prevent auto-activation of logical volumes.
Eduardo has posted comments on this change. Change subject: lvm: Prevent auto-activation of logical volumes. .. Patch Set 1: (1 comment) Commit Message Line 6: Line 7: lvm: Prevent auto-activation of logical volumes. Line 8: Line 9: When using FC storage, physical volumes are connected during boot, Line 10: and vdsm logical volumes are auto-activated by /etc/rc.sysinit I'm agree with you that this is not my preferred API. And I think that the opposite logic will be more convinient for us, but this is the fine grain option that lvm provides by now. Line 11: and/or /etc/init.d/netfs. Line 12: Line 13: This patch prevents auto-activation of vdsm volumes using new Line 14: --setactivationskip and --ignoreactivationskip options, introduced -- To view, visit http://gerrit.ovirt.org/20836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab9b7579990d934c60999b4c603c3acf46557be1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant supervsdm.validateAccess.
Eduardo has uploaded a new change for review. Change subject: Remove redundant supervsdm.validateAccess. .. Remove redundant supervsdm.validateAccess. Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec Signed-off-by: Eduardo ewars...@redhat.com --- M vdsm/storage/fileSD.py M vdsm/supervdsmServer 2 files changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/20838/1 diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py index f9ff93b..47c5448 100644 --- a/vdsm/storage/fileSD.py +++ b/vdsm/storage/fileSD.py @@ -35,7 +35,6 @@ from persistentDict import PersistentDict, DictValidator from vdsm import constants from vdsm.utils import stripNewLines -import supervdsm import mount REMOTE_PATH = REMOTE_PATH @@ -50,10 +49,6 @@ def validateDirAccess(dirPath): try: getProcPool().fileUtils.validateAccess(dirPath) -supervdsm.getProxy().validateAccess( -constants.QEMU_PROCESS_USER, -(constants.DISKIMAGE_GROUP, constants.METADATA_GROUP), dirPath, -(os.R_OK | os.X_OK)) except OSError as e: if e.errno == errno.EACCES: raise se.StorageServerAccessPermissionError(dirPath) diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer index d42e320..7a9c3da 100755 --- a/vdsm/supervdsmServer +++ b/vdsm/supervdsmServer @@ -57,7 +57,6 @@ from storage.iscsi import readSessionInfo as _readSessionInfo from supervdsm import _SuperVdsmManager from storage.fileUtils import chown, resolveGid, resolveUid -from storage.fileUtils import validateAccess as _validateAccess from vdsm.constants import METADATA_GROUP, EXT_UDEVADM, \ DISKIMAGE_USER, DISKIMAGE_GROUP, P_LIBVIRT_VMCHANNELS, VDSM_USER from storage.devicemapper import _removeMapping, _getPathsStatus @@ -237,11 +236,6 @@ raise err return res - -@logDecorator -def validateAccess(self, user, groups, *args, **kwargs): -return self._runAs(user, groups, _validateAccess, args=args, - kwargs=kwargs) @logDecorator def setSafeNetworkConfig(self): -- To view, visit http://gerrit.ovirt.org/20838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Prevent auto-actviation of logical volumes
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3: Code-Review-1
(5 comments)
Commit Message
Line 8:
Line 9: When using FC storage, physical volumes are connected during boot, and
Line 10: vdsm logical volumes are auto-activated by /etc/rc.sysinit and/or
Line 11: /etc/init.d/netfs. This is abnormal situation that vdsm cannot handle,
Line 12: and leads to data corruption.
This is abnormal situation that vdsm cannot handle, 11
and leads to data corruption.
May lead. Please remove this sentence.
Line 13:
Line 14: This patch prevents auto-activation of vdsm volumes using new
Line 15: --setactivationskip and --ignoreactivationskip options, introcuded in
Line 16: lvm 2.02.100.
Line 16: lvm 2.02.100.
Line 17:
Line 18: To make this change easy, lvm.changelv() was modified to accept
variable
Line 19: argument tuples, instead of multiple non-related types. This also
Line 20: simplify the only caller that use multiple arguments.
Please remove.
Line 21:
Line 22: Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0
Line 23: Bug-Url: https://bugzilla.redhat.com/1009812
File vdsm/storage/lvm.py
Line 748: raise se.VolumeGroupActionError(
Line 749: vgchange on vg(s) %s failed. %d %s %s % (vgs, rc,
out, err))
Line 750:
Line 751:
Line 752: def changelv(vg, lvs, *attrs):
There is no reason for changing the interface of this function.
Line 753:
Line 754: Change multiple attributes on multiple LVs.
Line 755:
Line 756: vg: VG name
Line 769: cmd = [lvchange]
Line 770: cmd.extend(LVM_NOBACKUP)
Line 771: for attr, value in attrs:
Line 772: cmd.extend((attr, value))
Line 773: if attr in (-a, --available, --activate) and value ==
y:
The if is redundant as said before.
There is no need for more logic when it is not necessary. Let lvm do is best.
And for log's sake will be better (TM) if --ignoreactivationskip is added in
the invariant part of the command.
Line 774: cmd.append(--ignoreactivationskip)
Line 775: cmd.extend(lvnames)
Line 776: rc, out, err = _lvminfo.cmd(tuple(cmd), _lvminfo._getVGDevs((vg,
)))
Line 777: _lvminfo._invalidatelvs(vg, lvs)
Line 1019: cont = {True: y, False: n}[contiguous]
Line 1020: cmd = [lvcreate]
Line 1021: cmd.extend(LVM_NOBACKUP)
Line 1022: cmd.extend((--contiguous, cont, --size, %sm % size,
Line 1023: --setactivationskip, y,
--ignoreactivationskip))
In the invariant part, as before.
Line 1024: if initialTag is not None:
Line 1025: cmd.extend((--addtag, initialTag))
Line 1026: cmd.extend((--name, lvName, vgName))
Line 1027: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
--
To view, visit http://gerrit.ovirt.org/20832
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix fix getDomUuidFromVolumePath()
Eduardo has uploaded a new change for review.
Change subject: Fix fix getDomUuidFromVolumePath()
..
Fix fix getDomUuidFromVolumePath()
Change-Id: I648e6a3f4e877c8f2471e82d7064c3e5a021d4d1
Bug-Url: http://bugzilla.redhat.com/1017735
Signed-off-by: Eduardo ewars...@redhat.com
---
M vdsm/storage/fileVolume.py
1 file changed, 5 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/20783/1
diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index cf26197..c6f1702 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -18,13 +18,11 @@
# Refer to the README and COPYING files for full details of the license
#
-from os.path import normpath
import errno
import os
import sanlock
import storage_exception as se
-from vdsm.config import config
from vdsm.utils import ActionStopped, grepCmd
from sdc import sdCache
import outOfProcess as oop
@@ -44,16 +42,11 @@
def getDomUuidFromVolumePath(volPath):
-# Volume path has pattern:
-# /rhev/data-center/spUUID/sdUUID/images/imgUUID/volUUID
-
-# sdUUID position after data-center
-sdUUIDOffset = 1
-
-volList = volPath.split('/')
-sdUUIDPos = len(normpath(config.get('irs', 'repository')).split('/')) + \
-sdUUIDOffset
-return volList[sdUUIDPos]
+# fileVolume path has pattern:
+# */sdUUID/images/imgUUID/volUUID
+sdPath = os.path.normpath(volPath).split('/images')[0]
+target, sdUUID = os.path.split(sdPath)
+return sdUUID
class FileVolume(volume.Volume):
--
To view, visit http://gerrit.ovirt.org/20783
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I648e6a3f4e877c8f2471e82d7064c3e5a021d4d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix fix fix getDomUuidFromVolumePath()
Eduardo has posted comments on this change.
Change subject: Fix fix fix getDomUuidFromVolumePath()
..
Patch Set 1: Code-Review-2
(1 comment)
File vdsm/storage/fileVolume.py
Line 43:
Line 44: def getDomUuidFromVolumePath(volPath):
Line 45: # fileVolume path has pattern:
Line 46: # */sdUUID/images/imgUUID/volUUID
Line 47: return volPath.split('/')[-4]
I'm I agree with Ayal, as we discussed by mail.
Furthermore, from the quick search over the 6 calls we already done, we need to
remove this method and the hunchback callers.
Line 48:
Line 49:
Line 50: class FileVolume(volume.Volume):
Line 51: Actually represents a single volume (i.e. part of virtual
disk).
--
To view, visit http://gerrit.ovirt.org/20790
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96b71b7839666d402ec5166eefeac618685c0ab0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix fix getDomUuidFromVolumePath()
Eduardo has posted comments on this change. Change subject: Fix fix getDomUuidFromVolumePath() .. Patch Set 1: 20790 was considered and discarded before send this. This is a broken function, for broken by design callers, but this way is more robust, far as we can say robust for this wreck. -- To view, visit http://gerrit.ovirt.org/20783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I648e6a3f4e877c8f2471e82d7064c3e5a021d4d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix fix getDomUuidFromVolumePath()
Eduardo has posted comments on this change. Change subject: Fix fix getDomUuidFromVolumePath() .. Patch Set 1: As we already discussed this function and it's callers should be removed, since if you are reaching the volume you already know the SD. -- To view, visit http://gerrit.ovirt.org/20783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I648e6a3f4e877c8f2471e82d7064c3e5a021d4d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsiadm: Add debug level option
Eduardo has posted comments on this change. Change subject: iscsiadm: Add debug level option .. Patch Set 3: There is no necessity for this RFE or this way is questionable IMHO. (As I wrote there.) The bottom line is that cluttering the vdsm logs with this info is making vdsm log worse. vdsm is not a tool for iscsi debuging. -- To view, visit http://gerrit.ovirt.org/20338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lev Veyde lve...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsiadm: Add debug level option
Eduardo has posted comments on this change. Change subject: iscsiadm: Add debug level option .. Patch Set 3: Code-Review-1 Note that the usefulness of these logs is questionable, as one call to iscsiadm can generate 18KB 395 lines log, and all of this is collapsed to one line, replacing \n with \\n, which makes it almost unreadable. I agree with --author that dumping many times unreadable lines on the vdsm.log only will destroy the vdsm.log. The whole idea of RFE https://bugzilla.redhat.com/1011075 is questionable, being iscsiadm errors actually logged in vdsm.log and there is no need for logging iscasiadm possitive flows in vdsm.logs. -- To view, visit http://gerrit.ovirt.org/20338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Ensure active LVs are refreshed before use.
Eduardo has posted comments on this change. Change subject: lvm: Ensure active LVs are refreshed before use. .. Patch Set 5: Code-Review-1 So Nir/Eduardo, what do you suggest? 1) My perennial request: engine should send connectStorageServer for FC. _All_ the last changes/fixes dealing with stale objects are breaking the fundamental semantics of ovirt. They are very hurt. 2) ovirt LVs should not be activated by default using lvchange --setactivationskip. I almost sure that Yeela has patches for that. 3) In general: having an active LV in more than one host should always be avoided in the present state of the things. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Ensure active LVs are refreshed before use.
Eduardo has posted comments on this change. Change subject: lvm: Ensure active LVs are refreshed before use. .. Patch Set 5: we are in 'activate' flow which means that we were told to use the LV. Why we were told to use an LV actually in use? This means: 1) A bug in the manager. Since this can lead to data corruption with shouldn't start using the volume. 2) erroneous activation (e.g. https://bugzilla.redhat.com/1009812 use case) We cannot assert that the volume wasn't altered or is not still in use (by the same or other reason) by other hosts. In such case refresh will not help. The cause should be fixed and not mitigated. Are we aware of other causes but the current BZ? The 'performance' hit here is that we cannot refresh multiple volumes in one shot. 1) We were hurt badly by this in the past, exactly for this cause, for images composed by many volumes. 2) vdsm code, in spite that was improved assumes that activating an already active volume is an innocous operation and call it too liberaly. This will be a real performance impact. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getVolumeInfo() new implementation.
Eduardo has posted comments on this change. Change subject: getVolumeInfo() new implementation. .. Patch Set 7: (1 comment) File vdsm/storage/volume.py Line 894: else: Line 895: info = self.metadata2info(meta) Line 896: info[capacity] = str(int(info[size]) * BLOCK_SIZE) # Virtual Line 897: del info[size] # Remove the virtual (by volMD) size [blocks] Line 898: if info['mtime'] == and self.__class__.__name__ == FileVolume: Already discussed by phone. Line 899: info['mtime'] = self.oop.os.stat(self.volumePath).st_mtime Line 900: # If image was set to illegal, mark the status same Line 901: # (because of VDC constraints) Line 902: if info['legality'] == ILLEGAL_VOL: -- To view, visit http://gerrit.ovirt.org/18233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop a non-variable variable
Eduardo has posted comments on this change. Change subject: drop a non-variable variable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f1345fcb6af904e36c7ce175ed4dffe339cebda Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop a non-variable variable
Eduardo has posted comments on this change. Change subject: drop a non-variable variable .. Patch Set 2: Already addressed in: Change Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e -- To view, visit http://gerrit.ovirt.org/20425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f1345fcb6af904e36c7ce175ed4dffe339cebda Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Making getVSize and getVTrueSize SD methods.
Eduardo has posted comments on this change. Change subject: Making getVSize and getVTrueSize SD methods. .. Patch Set 6: (2 comments) File vdsm/storage/blockSD.py Line 132: return LVM_ENC_ESCAPE.sub(lambda c: unichr(int(c.groups()[0])), s) Line 133: Line 134: Line 135: def _get_st_size(devPath): Line 136: Size in bytes of a dm device workaround. st_size can't be used for dm devices. Line 137: Line 138: stat.st_size (in /sys/block/dm-*/stat) is identically 0. Line 139: Line 140: with open(devPath, rb) as f: File vdsm/storage/fileSD.py Line 287: return self.oop.fileUtils.pathExists(volPath) Line 288: Line 289: def getVSize(self, imgUUID, volUUID): Line 290: Returns file volume size in bytes. Line 291: volPath = os.path.join(self.mountpoint, self.sdUUID, 'images', getVolumePath is a Volume member. We want to avoid the redundant production of the volume only for geting the path, that can be calculated. The volume production includes too many IOs. Line 292:imgUUID, volUUID) Line 293: return self.oop.os.stat(volPath).st_size Line 294: Line 295: def getVAllocSize(self, imgUUID, volUUID): -- To view, visit http://gerrit.ovirt.org/18202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: New getChildrenList implementation.
Eduardo has posted comments on this change. Change subject: New getChildrenList implementation. .. Patch Set 9: Verified-1 Checking file domains. -- To view, visit http://gerrit.ovirt.org/15765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: New getChildrenList implementation.
Eduardo has posted comments on this change. Change subject: New getChildrenList implementation. .. Patch Set 9: Verified+1 * With Change-Id Ibf374e6abe81962619baecf96fffa0f817ce5dcb for debugging * │ │ │ ├── cca667fd-d1d5-4377-8bc4-a1653795b72d │ │ │ │ ├── 61fabbbe-b95e-47ae-b9bd-3691549c06da │ │ │ │ ├── 61fabbbe-b95e-47ae-b9bd-3691549c06da.lease │ │ │ │ ├── 61fabbbe-b95e-47ae-b9bd-3691549c06da.meta │ │ │ │ ├── 949b1eac-3aec-4d97-a45a-2321dd2f3545 │ │ │ │ ├── 949b1eac-3aec-4d97-a45a-2321dd2f3545.lease │ │ │ │ └── 949b1eac-3aec-4d97-a45a-2321dd2f3545.meta # ls -1 /rhev/data-center/e517a818-af65-465f-9be3-cd5bd7e059ef/8b84a07e-91b2-44f0-9878-7b0856dc748c/images/cca667fd-d1d5-4377-8bc4-a1653795b72d/ 61fabbbe-b95e-47ae-b9bd-3691549c06da 61fabbbe-b95e-47ae-b9bd-3691549c06da.lease 61fabbbe-b95e-47ae-b9bd-3691549c06da.meta 949b1eac-3aec-4d97-a45a-2321dd2f3545 949b1eac-3aec-4d97-a45a-2321dd2f3545.lease 949b1eac-3aec-4d97-a45a-2321dd2f3545.meta # vdsClient 0 getVolumeInfo 8b84a07e-91b2-44f0-9878-7b0856dc748c e517a818-af65-465f-9be3-cd5bd7e059ef cca667fd-d1d5-4377-8bc4-a1653795b72d 61fabbbe-b95e-47ae-b9bd-3691549c06da status = OK domain = 8b84a07e-91b2-44f0-9878-7b0856dc748c capacity = 1073741824 voltype = LEAF description = parent = 949b1eac-3aec-4d97-a45a-2321dd2f3545 format = COW image = cca667fd-d1d5-4377-8bc4-a1653795b72d uuid = 61fabbbe-b95e-47ae-b9bd-3691549c06da disktype = 2 legality = LEGAL mtime = 1381392388 apparentsize = 262144 truesize = 11776 type = SPARSE children = [] pool = ctime = 1381392388 # vdsClient 0 getVolumeInfo 8b84a07e-91b2-44f0-9878-7b0856dc748c e517a818-af65-465f-9be3-cd5bd7e059ef cca667fd-d1d5-4377-8bc4-a1653795b72d 949b1eac-3aec-4d97-a45a-2321dd2f3545 status = OK domain = 8b84a07e-91b2-44f0-9878-7b0856dc748c capacity = 1073741824 voltype = INTERNAL description = parent = ---- format = RAW image = cca667fd-d1d5-4377-8bc4-a1653795b72d uuid = 949b1eac-3aec-4d97-a45a-2321dd2f3545 disktype = 2 legality = LEGAL mtime = 1381392349 apparentsize = 1073741824 truesize = 512 type = SPARSE children = ['61fabbbe-b95e-47ae-b9bd-3691549c06da'] pool = ctime = 1381392348 -- To view, visit http://gerrit.ovirt.org/15765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 2: Verified+1 Verified on file: │ │ │ ├── cca667fd-d1d5-4377-8bc4-a1653795b72d │ │ │ │ ├── 61fabbbe-b95e-47ae-b9bd-3691549c06da │ │ │ │ ├── 61fabbbe-b95e-47ae-b9bd-3691549c06da.lease │ │ │ │ ├── 61fabbbe-b95e-47ae-b9bd-3691549c06da.meta │ │ │ │ ├── 949b1eac-3aec-4d97-a45a-2321dd2f3545 │ │ │ │ ├── 949b1eac-3aec-4d97-a45a-2321dd2f3545.lease │ │ │ │ └── 949b1eac-3aec-4d97-a45a-2321dd2f3545.meta # ls -1 /rhev/data-center/e517a818-af65-465f-9be3-cd5bd7e059ef/8b84a07e-91b2-44f0-9878-7b0856dc748c/images/cca667fd-d1d5-4377-8bc4-a1653795b72d/ 61fabbbe-b95e-47ae-b9bd-3691549c06da 61fabbbe-b95e-47ae-b9bd-3691549c06da.lease 61fabbbe-b95e-47ae-b9bd-3691549c06da.meta 949b1eac-3aec-4d97-a45a-2321dd2f3545 949b1eac-3aec-4d97-a45a-2321dd2f3545.lease 949b1eac-3aec-4d97-a45a-2321dd2f3545.meta # vdsClient 0 getVolumeInfo 8b84a07e-91b2-44f0-9878-7b0856dc748c e517a818-af65-465f-9be3-cd5bd7e059ef cca667fd-d1d5-4377-8bc4-a1653795b72d 61fabbbe-b95e-47ae-b9bd-3691549c06da status = OK domain = 8b84a07e-91b2-44f0-9878-7b0856dc748c capacity = 1073741824 voltype = LEAF description = parent = 949b1eac-3aec-4d97-a45a-2321dd2f3545 format = COW image = cca667fd-d1d5-4377-8bc4-a1653795b72d uuid = 61fabbbe-b95e-47ae-b9bd-3691549c06da disktype = 2 legality = LEGAL mtime = 1381392388 apparentsize = 262144 truesize = 11776 type = SPARSE children = [] pool = ctime = 1381392388 # vdsClient 0 getVolumeInfo 8b84a07e-91b2-44f0-9878-7b0856dc748c e517a818-af65-465f-9be3-cd5bd7e059ef cca667fd-d1d5-4377-8bc4-a1653795b72d 949b1eac-3aec-4d97-a45a-2321dd2f3545 status = OK domain = 8b84a07e-91b2-44f0-9878-7b0856dc748c capacity = 1073741824 voltype = INTERNAL description = parent = ---- format = RAW image = cca667fd-d1d5-4377-8bc4-a1653795b72d uuid = 949b1eac-3aec-4d97-a45a-2321dd2f3545 disktype = 2 legality = LEGAL mtime = 1381392349 apparentsize = 1073741824 truesize = 512 type = SPARSE children = ['61fabbbe-b95e-47ae-b9bd-3691549c06da'] pool = ctime = 1381392348 -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getVolumeInfo() new implementation.
Eduardo has posted comments on this change. Change subject: getVolumeInfo() new implementation. .. Patch Set 3: Verified+1 * Verified for block volumes * # vdsClient -s 0 getConnectedStoragePoolsList # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 ---- 95aa8eec-32bb-42e8-8853-f4e094a1060a 5416128c-7bf6-4917-90de-05588bdd1712 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 4294967296 voltype = LEAF description = parent = 6301335b-9444-4f49-a817-cfc5ef0879a4 format = COW image = 95aa8eec-32bb-42e8-8853-f4e094a1060a uuid = 5416128c-7bf6-4917-90de-05588bdd1712 disktype = 2 legality = LEGAL mtime = 1380810703 apparentsize = 1073741824 truesize = 1073741824 type = SPARSE children = [] pool = ctime = 1380810703 # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 ---- 79f93e4e-6b22-4b8a-9567-ea9b6b3093ff b48ba89a-6b90-41c5-b73d-9e7c2e313a51 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 5368709120 voltype = LEAF description = t_child_1 parent = d979e09c-0a7b-47fb-8235-d2872928ef04 format = COW image = 79f93e4e-6b22-4b8a-9567-ea9b6b3093ff uuid = b48ba89a-6b90-41c5-b73d-9e7c2e313a51 disktype = 0 legality = LEGAL mtime = 1381262616 apparentsize = 1073741824 truesize = 1073741824 type = SPARSE children = [] pool = ctime = 1381262616 # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 ---- f8ca3be1-3aad-4785-a938-2b29bb499a40 d979e09c-0a7b-47fb-8235-d2872928ef04 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 5368709120 voltype = SHARED description = Active VM parent = ---- format = COW image = f8ca3be1-3aad-4785-a938-2b29bb499a40 uuid = d979e09c-0a7b-47fb-8235-d2872928ef04 disktype = 2 legality = LEGAL mtime = 1380800450 apparentsize = 2147483648 truesize = 2147483648 type = SPARSE children = [] pool = ctime = 1380800444 -- To view, visit http://gerrit.ovirt.org/18233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getVolumeInfo() new implementation.
Eduardo has posted comments on this change. Change subject: getVolumeInfo() new implementation. .. Patch Set 4: Verified+1 # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 ---- 95aa8eec-32bb-42e8-8853-f4e094a1060a 5416128c-7bf6-4917-90de-05588bdd1712 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 4294967296 voltype = LEAF description = parent = 6301335b-9444-4f49-a817-cfc5ef0879a4 format = COW image = 95aa8eec-32bb-42e8-8853-f4e094a1060a uuid = 5416128c-7bf6-4917-90de-05588bdd1712 disktype = 2 legality = LEGAL mtime = 1380810703 apparentsize = 1073741824 truesize = 1073741824 type = SPARSE children = [] pool = ctime = 1380810703 # vdsClient -s 0 getConnectedStoragePoolsList [root@localhost ~]# vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 ---- 79f93e4e-6b22-4b8a-9567-ea9b6b3093ff b48ba89a-6b90-41c5-b73d-9e7c2e313a51 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 5368709120 voltype = LEAF description = t_child_1 parent = d979e09c-0a7b-47fb-8235-d2872928ef04 format = COW image = 79f93e4e-6b22-4b8a-9567-ea9b6b3093ff uuid = b48ba89a-6b90-41c5-b73d-9e7c2e313a51 disktype = 0 legality = LEGAL mtime = 1381262616 apparentsize = 1073741824 truesize = 1073741824 type = SPARSE children = [] pool = ctime = 1381262616 # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 ---- f8ca3be1-3aad-4785-a938-2b29bb499a40 d979e09c-0a7b-47fb-8235-d2872928ef04 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 5368709120 voltype = SHARED description = Active VM parent = ---- format = COW image = f8ca3be1-3aad-4785-a938-2b29bb499a40 uuid = d979e09c-0a7b-47fb-8235-d2872928ef04 disktype = 2 legality = LEGAL mtime = 1380800450 apparentsize = 2147483648 truesize = 2147483648 type = SPARSE children = [] pool = ctime = 1380800444 -- To view, visit http://gerrit.ovirt.org/18233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Making getVSize and getVTrueSize SD methods.
Eduardo has posted comments on this change. Change subject: Making getVSize and getVTrueSize SD methods. .. Patch Set 5: Verified+1 Verified (block) with Change-Id: Ic82fab1966bc6606e3c29483bea62dd17b4c56bc verification. -- To view, visit http://gerrit.ovirt.org/18202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rename Image.copy() to Image.copyCollapsed().
Eduardo has posted comments on this change. Change subject: Rename Image.copy() to Image.copyCollapsed(). .. Patch Set 3: Verified+1 # vdsClient -s 0 copyImage 2756f45a-6c7a-449a-baed-e796cd293168 d3050ab5-da92-4495-826c-567d90e562e4 ac422006-ad98-47e1-bdf6-72b9029f8e15 330f3fce-34cc-4642-aa00-5c187f840a08 1c7ff60d-7d79-49f5-84e9-3dc9f7332b9d 4a09d19e-dbfe-4d58-a29d-5f57e3b39a0b dd0d6d13-5182-4018-9763-e5d5c9ce35fa collapsed_copy 2756f45a-6c7a-449a-baed-e796cd293168 0 4 2 46eca7c8-093f-4812-ac3f-890446d4c99d -- To view, visit http://gerrit.ovirt.org/18232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b6ec44430465097baf4dd5a2e5bdf6e3842a33f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Making getVSize and getVTrueSize SD methods.
Eduardo has posted comments on this change. Change subject: Making getVSize and getVTrueSize SD methods. .. Patch Set 6: Verified+1 Patch Set 5: Verified+1 Verified (block) with Change-Id: Ic82fab1966bc6606e3c29483bea62dd17b4c56bc verification. -- To view, visit http://gerrit.ovirt.org/18202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getVolumeInfo() new implementation.
Eduardo has posted comments on this change. Change subject: getVolumeInfo() new implementation. .. Patch Set 5: Verified+1 As before. -- To view, visit http://gerrit.ovirt.org/18233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: New getChildrenList implementation.
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 8:
(1 comment)
File vdsm/storage/fileVolume.py
Line 378: gPath = os.path.join(domPath, 'images', '*', '*.meta')
Line 379: metaPaths = oop.getProcessPool(self.sdUUID).glob.glob(gPath)
Line 380: pattern = %s.*%s % (volume.PUUID, self.volUUID)
Line 381: matches = grepCmd(pattern, metaPaths)
Line 382: if matches:
if not matches children will not be initialized.
Therefore it should initialized as a children = [] out of the loop only to be
converted in a tuple in the return.
Seems to me ugly like the actual code.
Line 383: children = []
Line 384: for line in matches:
Line 385: volMeta = os.path.basename(line.split(':')[0])
Line 386: children.append(os.path.splitext(volMeta)[0]) #
volUUID
--
To view, visit http://gerrit.ovirt.org/15765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: New getChildrenList implementation.
Eduardo has posted comments on this change. Change subject: New getChildrenList implementation. .. Patch Set 9: Verified+1 No significative changes from patchset 7. -- To view, visit http://gerrit.ovirt.org/15765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
Eduardo has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 10: Verified+1 Verified by Liron that running a VM with CD is working. -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
Eduardo has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 9: Verified-1 Adding the working patch. -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: More precise catch in block volume create.
Eduardo has posted comments on this change.
Change subject: More precise catch in block volume create.
..
Patch Set 1: Verified+1
7b5ef3c5-adad-4fa5-a9dd-e2b80cf5cec0::WARNING::2013-10-09
09:37:58,731::blockVolume::212::Storage.Volume::(_create) Cannot deactivate new
created volume d0dccb15-bc4e-4815-889a-
c116028f30b0/6301335b-9444-4f49-a817-cfc5ef0879a4
Traceback (most recent call last):
File /usr/share/vdsm/storage/blockVolume.py, line 209, in _create
raise se.CannotDeactivateLogicalVolume(### Testing purpose)
CannotDeactivateLogicalVolume: Cannot deactivate Logical Volume: ('### Testing
purpose',)
18c19519-7526-44a7-9204-f25e722c0078::ERROR::2013-10-09
09:49:52,502::volume::505::Storage.Volume::(create) Unexpected error
Traceback (most recent call last):
File /usr/share/vdsm/storage/volume.py, line 463, in create
srcVolUUID, imgPath, volPath)
File /usr/share/vdsm/storage/blockVolume.py, line 209, in _create
raise Exception(### Testing purpose base Exception)
Exception: ### Testing purpose base Exception
--
To view, visit http://gerrit.ovirt.org/18883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ac32eb0d58404c3e066dc73488ae0101560a919
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 1: (1 comment) File vdsm/storage/volume.py Line 900: info['truesize'] = 0 Line 901: info['mtime'] = 0 Line 902: info['status'] = INVALID Line 903: Line 904: # Both engine and dumpStorageTable don't use this option so 1) It is still true that actually they are not consumers of this field. 2) This is a different patch because is breaking BC if someone relies on a false empty list. The former one no affects BC. Line 905: # only keeping it to not break existing scripts that look for the key Line 906: info['children'] = list(self.getChildren()) Line 907: Line 908: # If image was set to illegal, mark the status same -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: New getChildrenList implementation.
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 8:
(6 comments)
Commit Message
Line 3: AuthorDate: 2013-06-16 12:24:17 +0300
Line 4: Commit: Eduardo Warszawski ewars...@redhat.com
Line 5: CommitDate: 2013-10-08 23:38:48 +0200
Line 6:
Line 7: New getChildrenList implementation.
If grep is added in a separate patch, will be complains that it is dead code.
Line 8:
Line 9: This implementation returns children of any image on the SD.
Line 10: Avoids to produce each volume in the domain.
Line 11: Implemented like one shot operation.
Line 7: New getChildrenList implementation.
Line 8:
Line 9: This implementation returns children of any image on the SD.
Line 10: Avoids to produce each volume in the domain.
Line 11: Implemented like one shot operation.
Instead of the recursive nightmare we have before.
Line 12:
Line 13: Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24
Line 14: Related-to: BZ#960952
File lib/vdsm/utils.py
Line 163: raise
Line 164: time.sleep(0.1)
Line 165:
Line 166:
Line 167: def grepCmd(pattern, paths):
*flags: Because there is no use for them now and being prepared for the unknown
is preparing the infrastructure for an air conditioner or an air carrier. Both
will not be here.
As an example see the options parameter in the hsm module.
In addition: is impossible to deal with the unknown results of an unknown set
of changing behaviour parameters.
The objective for this function is just to deal with the known grep responses.
I
f in the future such advanced use is needed, a new function can be added or
this easily modified.
-E is required for regex and the added value for this function is dealing with
multiple paths at once. The file name is required for the response.
Line 168: cmd = [constants.EXT_GREP, '-E', '-H', pattern]
Line 169: cmd.extend(paths)
Line 170: rc, out, err = execCmd(cmd)
Line 171: if rc == 0:
Line 166:
Line 167: def grepCmd(pattern, paths):
Line 168: cmd = [constants.EXT_GREP, '-E', '-H', pattern]
Line 169: cmd.extend(paths)
Line 170: rc, out, err = execCmd(cmd)
This is exactly what we agree with Saggi.
This is a wrapper encapsulating the execCmd and taking care of all the
semantics for the specific case.
If execCmd never can be called will be better(TM) to remove it. ;)
Line 171: if rc == 0:
Line 172: matches = out # A list of matching lines
Line 173: elif rc == 1:
Line 174: matches = [] # pattern not found
File vdsm/storage/fileVolume.py
Line 374:
Line 375: Children can be found in any image of the volume SD.
Line 376:
Line 377: domPath = self.imagePath.split('images')[0]
Line 378: gPath = os.path.join(domPath, 'images', '*', '*.meta')
gPath = path to be passed to grep. It is an ad-hoc variable.
Feel free to suggest a better(TM) name.
Line 379: metaPaths = oop.getProcessPool(self.sdUUID).glob.glob(gPath)
Line 380: pattern = %s.*%s % (volume.PUUID, self.volUUID)
Line 381: matches = grepCmd(pattern, metaPaths)
Line 382: if matches:
Line 377: domPath = self.imagePath.split('images')[0]
Line 378: gPath = os.path.join(domPath, 'images', '*', '*.meta')
Line 379: metaPaths = oop.getProcessPool(self.sdUUID).glob.glob(gPath)
Line 380: pattern = %s.*%s % (volume.PUUID, self.volUUID)
Line 381: matches = grepCmd(pattern, metaPaths)
Look at YOUR comment in version 4.
Yaniv Bronhaim Jun 26 5:31 PM
no need for oop, execCmd is already in external process,
Welcome to the club of the self discussing people. :D
Line 382: if matches:
Line 383: children = []
Line 384: for line in matches:
Line 385: volMeta = os.path.basename(line.split(':')[0])
--
To view, visit http://gerrit.ovirt.org/15765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Make hsm.getVolumesList() pool independent.
Eduardo has posted comments on this change. Change subject: Make hsm.getVolumesList() pool independent. .. Patch Set 7: Verified+1 # lvs 9615bd0c-ed20-4d47-b8d9-61a06e634830 LV VG Attr LSize Pool Origin Data% Move Log Cpy%Sync Convert 624857c0-a805-433c-9541-282f81bb5c9f 9615bd0c-ed20-4d47-b8d9-61a06e634830 -wi-- 128.00m 64a0505b-f8ba-498a-a438-e70f6a149689 9615bd0c-ed20-4d47-b8d9-61a06e634830 -wi-- 2.00g bbfe816c-0f0a-4f34-9e62-0c4593328bf8 9615bd0c-ed20-4d47-b8d9-61a06e634830 -wi-- 128.00m ids 9615bd0c-ed20-4d47-b8d9-61a06e634830 -wi-a 128.00m inbox9615bd0c-ed20-4d47-b8d9-61a06e634830 -wi-a 128.00m leases 9615bd0c-ed20-4d47-b8d9-61a06e634830 -wi-a 2.00g master 9615bd0c-ed20-4d47-b8d9-61a06e634830 -wi-a 1.00g metadata 9615bd0c-ed20-4d47-b8d9-61a06e634830 -wi-a 512.00m outbox 9615bd0c-ed20-4d47-b8d9-61a06e634830 -wi-a 128.00m # vdsClient -s 0 getStorageDomainsList 9615bd0c-ed20-4d47-b8d9-61a06e634830 363b4be1-75ab-444e-bf05-5e67252b07f1 a4bdbdaa-a12d-496b-b0b4-d59029206e69 # vdsClient -s 0 getConnectedStoragePoolsList # vdsClient -s 0 getVolumesList 9615bd0c-ed20-4d47-b8d9-61a06e634830 ---- 64a0505b-f8ba-498a-a438-e70f6a149689 : 624857c0-a805-433c-9541-282f81bb5c9f : bbfe816c-0f0a-4f34-9e62-0c4593328bf8 : -- To view, visit http://gerrit.ovirt.org/15766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: New getChildrenList implementation.
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 6:
(2 comments)
File vdsm/storage/fileVolume.py
Line 378: domPath = self.imagePath.split('images')[0]
Line 379: gPath = os.path.join(domPath, 'images', '*', '*.meta')
Line 380: metaPaths = oop.getProcessPool(self.sdUUID).glob.glob(gPath)
Line 381: pattern = %s.*%s % (volume.PUUID, self.volUUID)
Line 382: matches = grepCmd(pattern, metaPaths)
From the vdsm point of view, using grep is a unique operation, making the error
logic here much more simpler.
Reading each file and regex'ing requires to catch filing for a particular file.
In addition, re module is not imported but utils is.
Line 383: if matches:
Line 384: children = []
Line 385: for line in matches:
Line 386: volMeta = os.path.basename(line.split(':')[0])
File vdsm/storage/volume.py
Line 532: # previous volume deletion failure).
Line 533: # So, there is no reasons to avoid its deletion
Line 534: self.log.warn(Volume %s metadata error (%s),
Line 535: self.volUUID, str(e))
Line 536: if self.getChildren():
Yes. Corrupted MD may not include the shared key.
Line 537: raise se.VolumeImageHasChildren(self)
Line 538:
Line 539: def extend(self, newsize):
Line 540:
--
To view, visit http://gerrit.ovirt.org/15765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: sd.py: Remove sds from sdCache when connecting
Eduardo has posted comments on this change. Change subject: WIP: sd.py: Remove sds from sdCache when connecting .. Patch Set 1: Code-Review-1 connectStorageServer calls for FC by engine is required. A solution for this (and other) BZ(s) should be not merged before. The path to the SD should not be storaged in the SD cache. This is a semantic error, in spite that is the actual semantics. -- To view, visit http://gerrit.ovirt.org/19995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make hsm.getVolumesList() pool independent.
Eduardo has posted comments on this change. Change subject: Make hsm.getVolumesList() pool independent. .. Patch Set 8: # vdsClient -s 0 getVolumesList d0dccb15-bc4e-4815-889a-c116028f30b0 ---- d979e09c-0a7b-47fb-8235-d2872928ef04 : Active VM. aeae31c0-63a9-4745-835b-92546f237b8f : 23ac0ec4-881a-43b0-9c32-32e22db7ff75 : Parent is aeae31c0-63a9-4745-835b-92546f237b8f -- To view, visit http://gerrit.ovirt.org/15766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: New getChildrenList implementation.
Eduardo has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 7:
## Block verification with extra debug
# lvs -o lv_name,lv_tags,lv_attr d0dccb15-bc4e-4815-889a-c116028f30b0
/dev/dm-19: read failed after 0 of 4096 at 1073676288: Input/output error
LV LV Tags
Attr
23ac0ec4-881a-43b0-9c32-32e22db7ff75
IU_95aa8eec-32bb-42e8-8853-f4e094a1060a,PU_aeae31c0-63a9-4745-835b-92546f237b8f,MD_10
-wi--
aeae31c0-63a9-4745-835b-92546f237b8f
IU_95aa8eec-32bb-42e8-8853-f4e094a1060a,PU_----,MD_9
-wi--
b48ba89a-6b90-41c5-b73d-9e7c2e313a51
MD_6,PU_d979e09c-0a7b-47fb-8235-d2872928ef04,IU_79f93e4e-6b22-4b8a-9567-ea9b6b3093ff
-wi--
b65475aa-fec4-4e1f-99ca-c5464af7ad07
MD_7,PU_d979e09c-0a7b-47fb-8235-d2872928ef04,IU_aa3dc170-f09a-4bd2-8c53-54300a6f67c3
-wi--
d979e09c-0a7b-47fb-8235-d2872928ef04
PU_----,MD_5,IU_f8ca3be1-3aad-4785-a938-2b29bb499a40
-wi--
ids
-wi-ao---
inbox
-wi-a
leases
-wi-a
master
-wi-a
metadata
-wi-a
outbox
-wi-a
## Trying a volume with children:
# vdsClient -s 0 deleteVolume d0dccb15-bc4e-4815-889a-c116028f30b0
8790f4b1-a47e-47cb-8cd4-bf9d6841fbed 95aa8eec-32bb-42e8-8853-f4e094a1060a
aeae31c0-63a9-4745-835b-92546f237b8f 0
Cannot delete volume which has children (non-ethical): ['sdUUID:
d0dccb15-bc4e-4815-889a-c116028f30b0', 'imgUUID:
95aa8eec-32bb-42e8-8853-f4e094a1060a', 'volUUID:
aeae31c0-63a9-4745-835b-92546f237b8f']
Thread-38::DEBUG::2013-10-08
22:37:00,735::volume::534::Storage.Volume::(validateDelete) ### children:
('23ac0ec4-881a-43b0-9c32-32e22db7ff75',)
## New! Template children.
# vdsClient -s 0 deleteVolume d0dccb15-bc4e-4815-889a-c116028f30b0
8790f4b1-a47e-47cb-8cd4-bf9d6841fbed f8ca3be1-3aad-4785-a938-2b29bb499a40
d979e09c-0a7b-47fb-8235-d2872928ef04 0
Cannot delete volume which has children (non-ethical): ['sdUUID:
d0dccb15-bc4e-4815-889a-c116028f30b0', 'imgUUID:
f8ca3be1-3aad-4785-a938-2b29bb499a40', 'volUUID:
d979e09c-0a7b-47fb-8235-d2872928ef04']
Thread-76::DEBUG::2013-10-08
23:26:20,834::volume::534::Storage.Volume::(validateDelete) ### children:
('b65475aa-fec4-4e1f-99ca-c5464af7ad07', 'b48ba89a-6b90-41c5-b73d-9e7c2e313a51')
--
To view, visit http://gerrit.ovirt.org/15765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: New getChildrenList implementation.
Eduardo has posted comments on this change. Change subject: New getChildrenList implementation. .. Patch Set 7: (Verification continuation) # Leaf (No children) # vdsClient -s 0 deleteVolume d0dccb15-bc4e-4815-889a-c116028f30b0 8790f4b1-a47e-47cb-8cd4-bf9d6841fbed 95aa8eec-32bb-42e8-8853-f4e094a1060a 23ac0ec4-881a-43b0-9c32-32e22db7ff75 0 0ed13f8c-1c36-4f86-b0c7-054cde140e82 Thread-77::DEBUG::2013-10-08 23:29:17,837::volume::534::Storage.Volume::(validateDelete) ### children: () -- To view, visit http://gerrit.ovirt.org/15765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has uploaded a new change for review. Change subject: Fill volume children info. .. Fill volume children info. In spite that they are no consumers for 'children' key in Volume.getInfo() result adding the children set for correcteness. Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Signed-off-by: Eduardo ewars...@redhat.com --- M vdsm/storage/volume.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/20004/1 diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py index c19ec2f..96b84d7 100644 --- a/vdsm/storage/volume.py +++ b/vdsm/storage/volume.py @@ -903,7 +903,7 @@ # Both engine and dumpStorageTable don't use this option so # only keeping it to not break existing scripts that look for the key -info['children'] = [] +info['children'] = list(self.getChildren()) # If image was set to illegal, mark the status same # (because of VDC constraints) -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 1: Verified+1 # lvs -o lv_name,lv_tags,lv_attr d0dccb15-bc4e-4815-889a-c116028f30b0 /dev/dm-19: read failed after 0 of 4096 at 1073676288: Input/output error LV LV Tags Attr aeae31c0-63a9-4745-835b-92546f237b8f IU_95aa8eec-32bb-42e8-8853-f4e094a1060a,PU_----,MD_9 -wi-- b48ba89a-6b90-41c5-b73d-9e7c2e313a51 MD_6,PU_d979e09c-0a7b-47fb-8235-d2872928ef04,IU_79f93e4e-6b22-4b8a-9567-ea9b6b3093ff -wi-- b65475aa-fec4-4e1f-99ca-c5464af7ad07 MD_7,PU_d979e09c-0a7b-47fb-8235-d2872928ef04,IU_aa3dc170-f09a-4bd2-8c53-54300a6f67c3 -wi-- c80a31d2-f0d4-46ec-9624-a1dee55c82c7 IU_95aa8eec-32bb-42e8-8853-f4e094a1060a,PU_aeae31c0-63a9-4745-835b-92546f237b8f,MD_10 -wi-- d979e09c-0a7b-47fb-8235-d2872928ef04 PU_----,MD_5,IU_f8ca3be1-3aad-4785-a938-2b29bb499a40 -wi-- ids -wi-ao--- inbox -wi-a leases -wi-a master -wi-a metadata -wi-a outbox -wi-a ## Before # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 8790f4b1-a47e-47cb-8cd4-bf9d6841fbed f8ca3be1-3aad-4785-a938-2b29bb499a40 d979e09c-0a7b-47fb-8235-d2872928ef04 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 5368709120 voltype = SHARED description = Active VM parent = ---- format = COW image = f8ca3be1-3aad-4785-a938-2b29bb499a40 uuid = d979e09c-0a7b-47fb-8235-d2872928ef04 disktype = 2 legality = LEGAL mtime = 1380800450 apparentsize = 2147483648 truesize = 2147483648 type = SPARSE children = [] pool = ctime = 1380800444 ## After: # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 8790f4b1-a47e-47cb-8cd4-bf9d6841fbed f8ca3be1-3aad-4785-a938-2b29bb499a40 d979e09c-0a7b-47fb-8235-d2872928ef04 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 5368709120 voltype = SHARED description = Active VM parent = ---- format = COW image = f8ca3be1-3aad-4785-a938-2b29bb499a40 uuid = d979e09c-0a7b-47fb-8235-d2872928ef04 disktype = 2 legality = LEGAL mtime = 1380800450 apparentsize = 2147483648 truesize = 2147483648 type = SPARSE children = ['b65475aa-fec4-4e1f-99ca-c5464af7ad07', 'b48ba89a-6b90-41c5-b73d-9e7c2e313a51'] pool = ctime = 1380800444 # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 8790f4b1-a47e-47cb-8cd4-bf9d6841fbed 95aa8eec-32bb-42e8-8853-f4e094a1060a aeae31c0-63a9-4745-835b-92546f237b8f status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 4294967296 voltype = INTERNAL description = parent = ---- format = COW image = 95aa8eec-32bb-42e8-8853-f4e094a1060a uuid = aeae31c0-63a9-4745-835b-92546f237b8f disktype = 2 legality = LEGAL mtime = 1381229549 apparentsize = 1073741824 truesize = 1073741824 type = SPARSE children = ['c80a31d2-f0d4-46ec-9624-a1dee55c82c7'] pool = ctime = 1381229549 # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 8790f4b1-a47e-47cb-8cd4-bf9d6841fbed 95aa8eec-32bb-42e8-8853-f4e094a1060a c80a31d2-f0d4-46ec-9624-a1dee55c82c7 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 4294967296 voltype = LEAF description = v_child_1 parent = aeae31c0-63a9-4745-835b-92546f237b8f format = COW image = 95aa8eec-32bb-42e8-8853-f4e094a1060a uuid = c80a31d2-f0d4-46ec-9624-a1dee55c82c7 disktype = 0 legality = LEGAL mtime = 1381267310 apparentsize = 1073741824 truesize = 1073741824
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Eduardo has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 1: (1 comment) File client/vdsClient.py Line 1694: Line 1695: def startMonitoringDomain(self, args): Line 1696: sdUUID, hostID = args Line 1697: self.s.startMonitoringDomain(sdUUID, hostID) Line 1698: return 0, '' This is equivalent, code, msg as in other functions. Line 1699: Line 1700: def stopMonitoringDomain(self, args): Line 1701: sdUUID, = args Line 1702: self.s.stopMonitoringDomain(sdUUID) -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
Eduardo has uploaded a new change for review. Change subject: Enable VM migration to old vdsm's. .. Enable VM migration to old vdsm's. Old vdsm's can't run VM from /var/run/vdsm/storage and rely on /rhev/data-center hierarchy. Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011608 Signed-off-by: Eduardo ewars...@redhat.com --- M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py M vdsm/storage/hsm.py 3 files changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/19825/1 diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index d27f331..b014253 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -1029,6 +1029,19 @@ vols, rems = self.getAllVolumesImages() return rems +def linkBCImage(self, imgPath, imgUUID): +dst = os.path.join(self.mountpoint, self.sdUUID, sd.DOMAIN_IMAGES, + imgUUID) +try: +os.symlink(imgPath, dst) +except OSError as e: +if e.errno == errno.EEXIST: +self.log.debug(img run vol already exists: %s, dstVol) +else: +self.log.error(Failed to create img run vol: %s, dstVol) +raise +return dst + def createImageLinks(self, srcImgPath, imgUUID, volUUIDs): qcow chain is build by reading each qcow header and reading the path diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py index 8e788a5..8da30bb 100644 --- a/vdsm/storage/fileSD.py +++ b/vdsm/storage/fileSD.py @@ -418,6 +418,10 @@ return dict((k, sd.ImgsPar(tuple(v['imgs']), v['parent'])) for k, v in volumes.iteritems()) +def linkBCImage(self, imgPath, imgUUID): +return os.path.join(self.mountpoint, self.sdUUID, sd.DOMAIN_IMAGES, + imgUUID) + def createImageLinks(self, srcImgPath, imgUUID): qcow chain is build by reading each qcow header and reading the path diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 4f5a8a7..061182d 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3230,8 +3230,12 @@ # Filter volumes related to this image imgVolumes = sd.getVolsOfImage(allVols, imgUUID).keys() imgPath = dom.activateVolumes(imgUUID, imgVolumes) +if spUUID and spUUID != sd.BLANK_UUID: +runImgPath = dom.linkBCImage(imgPath, imgUUID) +else: +runImgPath = imgPath -leafPath = os.path.join(imgPath, leafUUID) +leafPath = os.path.join(runImgPath, leafUUID) for volUUID in imgVolumes: path = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID, volUUID) -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
Eduardo has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 1: vmId: b889a032-0a78-4591-bbc4-53157dd6d1be namethe_vm/name was started in compatibility mode (valid spUUID) with: source dev=/rhev/data-center/mnt/blockSD/d0dccb15-bc4e-4815-889a-c116028f30b0/images/3a611e65-6261-4680-9a98-0fa8a4664ecc/775147a3-e652-4d8b-9e06-ef1a964a9cc5/ This should be OK for migrate to old vdsm's. [root@aqua-vds5 ~]# virsh -r list IdName State 1 the_vm running -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
Eduardo has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 2: (2 comments) File vdsm/storage/blockSD.py Line 1035: try: Line 1036: os.symlink(imgPath, dst) Line 1037: except OSError as e: Line 1038: if e.errno == errno.EEXIST: Line 1039: self.log.debug(img run dir already exists: %s, dst) Yes. If the image exists and is not the True link, running a VM is not where we need to fix it. In such case we need to remove the cause of the spurious link. Anyway, it will contain the leaf or not, and in the last case the VM run will fail. Line 1040: else: Line 1041: self.log.error(Failed to create img run dir: %s, dst) Line 1042: raise Line 1043: return dst File vdsm/storage/hsm.py Line 3229: allVols = dom.getAllVolumes() Line 3230: # Filter volumes related to this image Line 3231: imgVolumes = sd.getVolsOfImage(allVols, imgUUID).keys() Line 3232: imgPath = dom.activateVolumes(imgUUID, imgVolumes) Line 3233: if spUUID and spUUID != sd.BLANK_UUID: Ugly. It was required as the interface diferentiator for backwards compatibility. For running VMs without pool in new hosts engine will not sent the pool ID parameter at all. Personally I dislike it. Line 3234: runImgPath = dom.linkBCImage(imgPath, imgUUID) Line 3235: else: Line 3236: runImgPath = imgPath Line 3237: -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Eduardo has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 2: (1 comment) File vdsm/storage/hsm.py Line 1505: Line 1506: force parameter is deprecated and not evaluated. Line 1507: Line 1508: # vars.task.setDefaultException(se.ChangeMeError(%s % args)) Line 1509: pool = self.getPool(spUUID) # Validates pool connection. WHY? Wrong. Being connected to the pool does not warrants that this is SPM. Line 1510: dom = sdCache.produce(sdUUID=sdUUID) Line 1511: Line 1512: vars.task.getExclusiveLock(STORAGE, imgUUID) Line 1513: vars.task.getSharedLock(STORAGE, sdUUID) -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable VM migration to old vdsm's.
Eduardo has posted comments on this change. Change subject: Enable VM migration to old vdsm's. .. Patch Set 2: (1 comment) File vdsm/storage/blockSD.py Line 1035: try: Line 1036: os.symlink(imgPath, dst) Line 1037: except OSError as e: Line 1038: if e.errno == errno.EEXIST: Line 1039: self.log.debug(img run dir already exists: %s, dst) Stale link to where? There are not too many dst that can be there. Link to the image are created by other functions too and the net result is the same, linking the block image. This method is only called from vm.py. Running again the same VM, activating the dame SD/image, will result in the same link. In the case you described, you are talking about removing something that we don't know what is, assuming that is engine trying to run a VM with an image that is not (but was) in this SD. This is a serious engine bug, and it should be solved in the LSM. Having the same image UUID in two SDs, only engine can determine which is the correct one. Line 1040: else: Line 1041: self.log.error(Failed to create img run dir: %s, dst) Line 1042: raise Line 1043: return dst -- To view, visit http://gerrit.ovirt.org/19825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia778ad743a11b4c1d212857d8f25c81eb4c0defe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Eduardo has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1:
(1 comment)
File vdsm/storage/sp.py
Line 1545: # {sdUUID1: status1, sdUUID2: status2, ...}
Line 1546: self.invalidateMetadata()
Line 1547: poolDoms = self.getDomains()
Line 1548: activeDomains = tuple(sdUUID for sdUUID in poolDoms
Line 1549: if poolDoms[sdUUID] ==
sd.DOM_ACTIVE_STATUS)
This change is required since being StoragePool.domainMonitor a pointer to a
unique hsm instance. monitoredDomains member includes the extra-pool SDs, added
with startMonitoringDomain. Therefore these extra pool SDs will be removed from
the monitor with the old code, due to the iteration over monitoredDomains.
Line 1550: monitoredDomains = self.domainMonitor.monitoredDomains
Line 1551:
Line 1552: for sdUUID in poolDoms:
Line 1553: if sdUUID not in activeDomains:
--
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: revert premature selinux dependency
Eduardo has posted comments on this change. Change subject: revert premature selinux dependency .. Patch Set 1: Code-Review-1 (1 comment) Commit Message Line 12: EL6, so we'd better not require it now. Line 13: Line 14: Note that using /var/run/vdsm/storage is problematic not only due to Line 15: selinux, but also because it breaks cross-version migration. Hence, the Line 16: universal usage of this directory is soon to be changed. The selinux issue was discussed months ago. The solution of the cross version migration does not implies the use of another directory. Line 17: Line 18: Change-Id: Iea625d7c39035055b246357030372430b4bddf68 -- To view, visit http://gerrit.ovirt.org/19807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea625d7c39035055b246357030372430b4bddf68 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Toshio くらとみ a.bad...@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Eduardo has uploaded a new change for review.
Change subject: Adding [start|stop]MonitoringDomain().
..
Adding [start|stop]MonitoringDomain().
startMonitoringDomain() is added for monitoring a storage domain
without being connected to the pool and geting and ID for such
SD lockspace.
stopMonitoringDomain() stops the monitoring and releases the ID.
Monitoring results are gathered with repoStats().
Caveat Emptor:
SDs added to the monitor using startMonitoringDomain() should not
be part of the pool! i.e. the pool domain set and the added SDs set
should be disjoint.
Making repoStats pool independent.
Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Signed-off-by: Eduardo ewars...@redhat.com
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
M vdsm_api/vdsmapi-schema.json
6 files changed, 105 insertions(+), 32 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/19762/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 590b1e7..6aba25e 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1692,6 +1692,16 @@
print 'Domain %s %s' % (d, str(stats[d]))
return 0, ''
+def startMonitoringDomain(self, args):
+sdUUID, hostID = args
+self.s.startMonitoringDomain(sdUUID, hostID)
+return 0, ''
+
+def stopMonitoringDomain(self, args):
+sdUUID, = args
+self.s.stopMonitoringDomain(sdUUID)
+return 0, ''
+
def snapshot(self, args):
vmUUID, sdUUID, imgUUID, baseVolUUID, volUUID = args
@@ -2466,8 +2476,16 @@
)),
'repoStats': (serv.repoStats,
('',
- 'Get the the health status of the active domains'
+ 'Get the health status of the monitored domains'
)),
+'startMonitoringDomain': (serv.startMonitoringDomain,
+ ('sdUUID hostID',
+ 'Start SD: sdUUID monitoring with hostID'
+ )),
+'stopMonitoringDomain': (serv.stopMonitoringDomain,
+ ('sdUUID',
+ 'Stop monitoring SD: sdUUID'
+ )),
'snapshot': (serv.snapshot,
('vmId sdUUID imgUUID baseVolUUID volUUID',
'Take a live snapshot'
diff --git a/vdsm/API.py b/vdsm/API.py
index 37bb908..fa9a3ab 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1396,6 +1396,12 @@
def getStorageRepoStats(self):
return self._irs.repoStats()
+def startMonitoringDomain(self, sdUUID, hostID):
+return self._irs.startMonitoringDomain(sdUUID, hostID)
+
+def stopMonitoringDomain(self, sdUUID):
+return self._irs.stopMonitoringDomain(sdUUID)
+
def getLVMVolumeGroups(self, storageType=None):
return self._irs.getVGList(storageType)
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index fb65ad4..5dd747a 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -787,6 +787,14 @@
api = API.Global()
return api.getStorageRepoStats()
+def startMonitoringDomain(self, sdUUID, hostID, options=None):
+api = API.Global()
+return api.startMonitoringDomain(sdUUID, hostID)
+
+def stopMonitoringDomain(self, sdUUID, options=None):
+api = API.Global()
+return api.stopMonitoringDomain(sdUUID)
+
def vgsGetList(self, storageType=None, options=None):
api = API.Global()
return api.getLVMVolumeGroups(storageType)
@@ -937,6 +945,8 @@
(self.domainsGetList, 'getStorageDomainsList'),
(self.poolsGetConnectedList, 'getConnectedStoragePoolsList'),
(self.storageRepoGetStats, 'repoStats'),
+(self.startMonitoringDomain, 'startMonitoringDomain'),
+(self.stopMonitoringDomain, 'stopMonitoringDomain'),
(self.vgsGetList, 'getVGList'),
(self.devicesGetList, 'getDeviceList'),
(self.devicesGetVisibility, 'getDevicesVisibility'),
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 4ea68ea..5f14468 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -40,6 +40,7 @@
from vdsm.config import config
import sp
+import domainMonitor
import sd
import blockSD
import nfsSD
@@ -93,6 +94,8 @@
STORAGE_CONNECTION_DIR = os.path.join(constants.P_VDSM_LIB, connections/)
QEMU_READABLE_TIMEOUT = 30
+
+HSM_DOM_MON_LOCK = HsmDomainMonitorLock
def public(f=None, **kwargs):
@@ -398,6 +401,9 @@
name=storageRefresh)
storageRefreshThread.daemon = True
storageRefreshThread.start()
+
+monitorInterval = config.getint('irs', 'sd_health_check_delay')
+
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Eduardo has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1: Verified+1
More verification (with engine) is required!
[root@localhost ~]# vdsClient -s 0 getStorageDomainsList
9615bd0c-ed20-4d47-b8d9-61a06e634830
577c3957-ee57-4496-ac84-c35067e1913a
2a7fbb64-f64c-4139-ba79-aaf21547845f
eff02bb9-cea8-4f89-a077-47f36be46197
[root@localhost ~]# vdsClient -s 0 getStorageDomainInfo
9615bd0c-ed20-4d47-b8d9-61a06e634830
uuid = 9615bd0c-ed20-4d47-b8d9-61a06e634830
vguuid = FScea1-AGv1-hwlM-dYHv-BZFb-Wit8-1ogEdM
lver = -1
state = OK
version = 3
role = Regular
pool = ['5849b030-626e-47cb-ad90-3ce782d831b3']
spm_id = -1
type = ISCSI
class = Data
master_ver = 0
name = iscsi1
[root@localhost ~]# vdsClient -s 0 getStorageDomainInfo
2a7fbb64-f64c-4139-ba79-aaf21547845f
uuid = 2a7fbb64-f64c-4139-ba79-aaf21547845f
vguuid = fzjUA0-bfG5-UJIL-nya2-T6NI-yAOh-8w3FsC
lver = -1
state = OK
version = 3
role = Master
pool = ['0d1ef687-3b3f-4e27-89f2-69d38dc4dc22']
spm_id = -1
type = ISCSI
class = Data
master_ver = 0
name = edu1
[root@localhost ~]# vdsClient -s 0 getConnectedStoragePoolsList
[root@localhost ~]# vdsClient -s 0 repoStats
[root@localhost ~]# vdsClient -s 0 startMonitoringDomain
9615bd0c-ed20-4d47-b8d9-61a06e634830 9
[root@localhost ~]# vdsClient -s 0 repoStats
Domain 9615bd0c-ed20-4d47-b8d9-61a06e634830 {'delay': '0.000697625',
'lastCheck': '9.3', 'code': 0, 'valid': True, 'version': 3}
[root@localhost ~]# vdsClient -s 0 connectStoragePool
0d1ef687-3b3f-4e27-89f2-69d38dc4dc22 4 0 2a7fbb64-f64c-4139-ba79-aaf21547845f 1
[root@localhost ~]# vdsClient -s 0 repoStats
Domain 9615bd0c-ed20-4d47-b8d9-61a06e634830 {'delay': '0.000580883',
'lastCheck': '9.0', 'code': 0, 'valid': True, 'version': 3}
Domain 2a7fbb64-f64c-4139-ba79-aaf21547845f {'delay': '0.000485516',
'lastCheck': '9.6', 'code': 0, 'valid': True, 'version': 3}
[root@localhost ~]# vdsClient -s 0 stopMonitoringDomain
9615bd0c-ed20-4d47-b8d9-61a06e634830
[root@localhost ~]# vdsClient -s 0 repoStats
--
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
Eduardo has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 8: Verified+1 Verified with Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix getStorageDomainInfo() logic.
Eduardo has posted comments on this change. Change subject: Fix getStorageDomainInfo() logic. .. Patch Set 6: Verified+1 Verified with Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c -- To view, visit http://gerrit.ovirt.org/14671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()
Eduardo has posted comments on this change. Change subject: Read pool metadata once in StoragePool.getInfo() .. Patch Set 7: Verified+1 Verified with Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c -- To view, visit http://gerrit.ovirt.org/14672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix vdsClient.repoStats() bad path.
Eduardo has uploaded a new change for review. Change subject: Fix vdsClient.repoStats() bad path. .. Fix vdsClient.repoStats() bad path. (Or why using your list as a dict is bad.) Change-Id: Idf7f6c367c83c2d00967e31dda6c9d0ef2fd3e57 Signed-off-by: Eduardo ewars...@redhat.com --- M client/vdsClient.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/19764/1 diff --git a/client/vdsClient.py b/client/vdsClient.py index 5ecf04d..a393f1c 100644 --- a/client/vdsClient.py +++ b/client/vdsClient.py @@ -1685,7 +1685,7 @@ stats = self.s.repoStats() if stats['status']['code']: print count not get repo stats -return int(list['status']['code']) +return int(stats['status']['code']) for d in stats: if d == status: continue -- To view, visit http://gerrit.ovirt.org/19764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf7f6c367c83c2d00967e31dda6c9d0ef2fd3e57 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: is list a dict?
Eduardo has uploaded a new change for review. Change subject: vdsClient: is list a dict? .. vdsClient: is list a dict? Short answer: NO! Change-Id: Iacd7af3691eb2ed15b7fbb042f8ce43528dce31e Signed-off-by: Eduardo ewars...@redhat.com --- M client/vdsClient.py 1 file changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/19763/1 diff --git a/client/vdsClient.py b/client/vdsClient.py index 590b1e7..5ecf04d 100644 --- a/client/vdsClient.py +++ b/client/vdsClient.py @@ -1642,44 +1642,44 @@ return status['status']['code'], status['power'] return status['status']['code'], status['status']['message'] -def __image_status(self, imgUUID, list): -if imagestatus in list and message in list: +def __image_status(self, imgUUID, res): +if imagestatus in res and message in res: status = OK -if list[imagestatus]: +if res[imagestatus]: status = ERROR print (Image %s status %s: %s (%s) % - (imgUUID, status, list[message], list[imagestatus])) -if badvols in list: -for v, err in list[badvols].iteritems(): + (imgUUID, status, res[message], res[imagestatus])) +if badvols in res: +for v, err in res[badvols].iteritems(): print \tVolume %s is bad: %s % (v, err) -def __domain_status(self, sdUUID, list): -if domainstatus in list and message in list: +def __domain_status(self, sdUUID, res): +if domainstatus in res and message in res: status = OK -if list[domainstatus]: +if res[domainstatus]: status = ERROR print (Domain %s status %s: %s (%s) % - (sdUUID, status, list[message], list[domainstatus])) -if badimages in list: -for i in list[badimages]: + (sdUUID, status, res[message], res[domainstatus])) +if badimages in res: +for i in res[badimages]: print \tImage %s is bad % (i) -self.__image_status(i, list[badimages][i]) +self.__image_status(i, res[badimages][i]) -def __pool_status(self, spUUID, list): -if poolstatus in list and message in list: +def __pool_status(self, spUUID, res): +if poolstatus in res and message in res: status = OK -if list[poolstatus]: +if res[poolstatus]: status = ERROR print (Pool %s status %s: %s (%s) % - (spUUID, status, list[message], list[poolstatus])) + (spUUID, status, res[message], res[poolstatus])) if masterdomain: -print \tMaster domain is %s % list[masterdomain] +print \tMaster domain is %s % res[masterdomain] if spmhost: -print \tThe SPM host id is %s % list[spmhost] -if baddomains in list: -for d in list[baddomains]: +print \tThe SPM host id is %s % res[spmhost] +if baddomains in res: +for d in res[baddomains]: print \tDomain %s is bad: % (d) -self.__domain_status(d, list[baddomains][d]) +self.__domain_status(d, res[baddomains][d]) def repoStats(self, args): stats = self.s.repoStats() -- To view, visit http://gerrit.ovirt.org/19763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iacd7af3691eb2ed15b7fbb042f8ce43528dce31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
Eduardo has uploaded a new change for review. Change subject: Convert guids into mapper devs for extend blockSD .. Convert guids into mapper devs for extend blockSD After I1ec54147205992ac130684d01e73cd7aceccad48, which changed multipath.getMPDevNamesIter() to return full paths, HSM.extendStorageDomain() guids param should be converted accordingly. Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1012944 Signed-off-by: Eduardo ewars...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/19659/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 9cfabdb..8749163 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -723,7 +723,7 @@ return dict(size=str(roundedSizeBytes)) @public -def extendStorageDomain(self, sdUUID, spUUID, devlist, +def extendStorageDomain(self, sdUUID, spUUID, guids, force=False, options=None): Extends a VG. ? @@ -741,13 +741,15 @@ vars.task.setDefaultException( se.StorageDomainActionError( -sdUUID=%s, devlist=%s % (sdUUID, devlist))) +sdUUID=%s, devlist=%s % (sdUUID, guids))) vars.task.getSharedLock(STORAGE, sdUUID) # We need to let the domain to extend itself pool = self.getPool(spUUID) pool.validatePoolSD(sdUUID) -pool.extendSD(sdUUID, devlist, force) +dmDevs = tuple(os.path.join(devicemapper.DMPATH_PREFIX, guid) for guid + in guids) +pool.extendSD(sdUUID, dmDevs, force) @public def forcedDetachStorageDomain(self, sdUUID, spUUID, options=None): -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
Eduardo has posted comments on this change. Change subject: Convert guids into mapper devs for extend blockSD .. Patch Set 1: Verified+1 [root@localhost ~]# vgs -o +pv_name 2a7fbb64-f64c-4139-ba79-aaf21547845f VG #PV #LV #SN Attr VSize VFree PV 2a7fbb64-f64c-4139-ba79-aaf21547845f 1 6 0 wz--n- 99.62g 95.75g /dev/mapper/1elad1213738004 [root@localhost ~]# vdsClient -s 0 extendStorageDomain 2a7fbb64-f64c-4139-ba79-aaf21547845f 0d1ef687-3b3f-4e27-89f2-69d38dc4dc22 1elad1313738004 [root@localhost ~]# echo $? 0 [root@localhost ~]# vdsClient -s 0 getStorageDomainInfo 2a7fbb64-f64c-4139-ba79-aaf21547845f uuid = 2a7fbb64-f64c-4139-ba79-aaf21547845f vguuid = fzjUA0-bfG5-UJIL-nya2-T6NI-yAOh-8w3FsC lver = 1 state = OK version = 3 role = Master pool = ['0d1ef687-3b3f-4e27-89f2-69d38dc4dc22'] spm_id = 1 type = ISCSI class = Data master_ver = 1 name = edu1 [root@localhost ~]# vgs -o +pv_name 2a7fbb64-f64c-4139-ba79-aaf21547845f VG #PV #LV #SN Attr VSize VFree PV 2a7fbb64-f64c-4139-ba79-aaf21547845f 2 6 0 wz--n- 199.25g 195.38g /dev/mapper/1elad1213738004 2a7fbb64-f64c-4139-ba79-aaf21547845f 2 6 0 wz--n- 199.25g 195.38g /dev/mapper/1elad1313738004 -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
Eduardo has posted comments on this change. Change subject: Convert guids into mapper devs for extend blockSD .. Patch Set 2: Verified+1 Patchset 1 verified using vdsClient. See previous comment. -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.
Eduardo has uploaded a new change for review.
Change subject: getStorageDomainInfo: SP keys when disconnected.
..
getStorageDomainInfo: SP keys when disconnected.
Before this patch, getStorageDomainInfo() returns the real pool
info part (master_ver, spm_id, lver) only if the host is connected
to the same pool which the domain is attached. This patch reads
directly the pool MD for any MSD.
This changes the previous behaviour.
TODO: pool related information should not be returned as part of
this API response.
Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e
Signed-off-by: Eduardo ewars...@redhat.com
---
M vdsm/storage/hsm.py
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/19555/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 2b91640..6262822 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2736,8 +2736,11 @@
# These keys are not likely to change (also because of
# BC) so it's not that horrible. In any case please
# remove this when we can stop supporting this API.
-info.update({'lver': -1, 'spm_id': -1, 'master_ver': 0})
if info['role'] == sd.MASTER_DOMAIN:
+pmd = sp.StoragePool._getPoolMD(dom)
+info['lver'] = pmd[sp.PMDK_LVER]
+info['master_ver'] = pmd[sp.PMDK_MASTER_VER]
+info['spm_id'] = -1
try:
# Verify that the host is connected to the same pool which
# the SD is attached to.
@@ -2757,9 +2760,12 @@
master is %s,
sdUUID, pool.masterDomain.sdUUID)
else:
-poolInfo = pool.getInfo()
-for key in ('lver', 'spm_id', 'master_ver'):
-info[key] = poolInfo[key]
+# spm_id is relevant only when the host is connected
+# to the pool and this SD is the actual master
+info['spm_id'] = pmd[sp.PMDK_SPM_ID]
+
+else: # sd.REGULAR_DOMAIN
+info.update({'lver': -1, 'spm_id': -1, 'master_ver': 0})
return dict(info=info)
--
To view, visit http://gerrit.ovirt.org/19555
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid hsm image deletions.
Eduardo has posted comments on this change. Change subject: Avoid hsm image deletions. .. Patch Set 4: Comments addressed. This is fossilized code, failing to solve flaws from code that is not existing anymore, cluttering the log and wasting IOs. A very bad pattern modifying the storage as HSM. Proper garbage collection will be added at some point in the future. -- To view, visit http://gerrit.ovirt.org/17193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1ec2ea8793a4ad63453559bc5f663b65f9b9336 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix getStorageDomainInfo() logic.
Eduardo has posted comments on this change. Change subject: Fix getStorageDomainInfo() logic. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/14671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()
Eduardo has posted comments on this change. Change subject: Read pool metadata once in StoragePool.getInfo() .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/14672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getVolumeInfo() new implementation.
Eduardo has posted comments on this change. Change subject: getVolumeInfo() new implementation. .. Patch Set 3: (2 comments) Commit Message Line 5: CommitDate: 2013-09-16 04:46:09 +0300 Line 6: Line 7: getVolumeInfo() new implementation. Line 8: Line 9: BC compatibility preserved but in broken behaviours. The former semantic was incosistent but preserved. Logical impossibilities were removed if it was possible. Line 10: Line 11: Required to reduce the volume size functions proliferation. Line 12: Line 13: Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e File vdsm/storage/volume.py Line 895: else: Line 896: info = self.metadata2info(meta) Line 897: info[capacity] = str(int(info[size]) * BLOCK_SIZE) # Virtual Line 898: del info[size] # Remove the virtual (by volMD) size [blocks] Line 899: if info['mtime'] == and self.__class__.__name__ == FileVolume: They are operating on different files. Therefore we should not unify. Unfortunately this info dict is created only here and mix information of multiple sources and is created only here. Line 900: info['mtime'] = self.oop.os.stat(self.volumePath).st_mtime Line 901: # If image was set to illegal, mark the status same Line 902: # (because of VDC constraints) Line 903: if info['legality'] == ILLEGAL_VOL: -- To view, visit http://gerrit.ovirt.org/18233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Making getVSize and getVTrueSize SD methods.
Eduardo has posted comments on this change. Change subject: Making getVSize and getVTrueSize SD methods. .. Patch Set 4: (3 comments) Commit Message Line 12: Line 13: TODO: Line 14: This two method should be unified in a future patch since the Line 15: two values are returned in the same call for file volumes and Line 16: the two values are identical for block volumes. Makes the rebase of subsequent patches hard. Will be done after the remove of the getVolumeSize() call. Line 17: Line 18: Required to reduce the volume size functions proliferation. Line 19: Line 20: Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9 File vdsm/storage/blockSD.py Line 620: return False Line 621: return True Line 622: Line 623: def getVSize(self, imgUUID, volUUID): Line 624: Return the block volume size in bytes. Like st_size. Done Line 625: try: Line 626: size = _get_st_size(lvm.lvPath(self.sdUUID, volUUID)) Line 627: except IOError as e: Line 628: if e.errno == os.errno.ENOENT: Line 634: raise Line 635: Line 636: return size Line 637: Line 638: getVAllocSize = getVSize Will be addressed in a future patch. Line 639: Line 640: @classmethod Line 641: def validateCreateVolumeParams(cls, volFormat, preallocate, srcVolUUID): Line 642: -- To view, visit http://gerrit.ovirt.org/18202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
