Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Piotr Kliczewski has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: After rebase this patch is not needed anymore. There are new issues that I noticed in vdsm/static dir. Deleting this change. -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr KliczewskiGerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Piotr Kliczewski has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: sure -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr KliczewskiGerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Sandro Bonazzola has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: Can you please rebase? -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr KliczewskiGerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Piotr Kliczewski has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: Let's keep it for a bit longer -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr KliczewskiGerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Piotr Kliczewski has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: Let's keep this patch for a bit longer. -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr KliczewskiGerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Sandro Bonazzola has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: Nice start, you're on the right way. -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr KliczewskiGerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Piotr Kliczewski has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/52508/1//COMMIT_MSG Commit Message: Line 16: Traceback (most recent call last): Line 17: File "../../../tests/testrunner.py", line 82, in Line 18: from vdsm import constants Line 19: ImportError: cannot import name constants Line 20: > and with this patch does distcheck work? Not yet but I was close to it. Traceback in this message contains details where it fails. Line 21: Line 22: Bug-Url: https://bugzilla.redhat.com/1297808 Line 23: Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr KliczewskiGerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
Yaniv Bronhaim has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/52508/1//COMMIT_MSG Commit Message: Line 16: Traceback (most recent call last): Line 17: File "../../../tests/testrunner.py", line 82, in Line 18: from vdsm import constants Line 19: ImportError: cannot import name constants Line 20: and with this patch does distcheck work? dima investigated this issue in the past.. I think we can't find good solution for it when we have the in files Line 21: Line 22: Bug-Url: https://bugzilla.redhat.com/1297808 Line 23: Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr KliczewskiGerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...
gerrit-hooks has posted comments on this change. Change subject: [wip] build: assumptions about the path do not work for distcheck .. Patch Set 1: * #1297808::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1297808::OK, public bug * Check Product::#1297808::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr KliczewskiGerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches