Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Vinzenz Feenstra has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 10:
(3 comments)
Commit Message
Line 12: the destination to wait for the migration to finish.
Line 13: This is now reflected as the migration_destination_timeout.
Line 14:
Line 15: If the VM after the timeout still has the state PAUSED and the
Line 16: reason is migration we're going to raise an MigrationError.
This is the destination. We are trying to destroy the destination from the
source on errors, cancellation etc. But what if there's a network outage in the
middle? In some weird cases we'll never hear about it.
We're only destroying VMs after the timeout which are still in (Migration +
Paused State)
NOTE: Any other reason for the paused state is kept untouched.
Line 17:
Line 18: Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09
Line 19: Bug-Url: https://bugzilla.redhat.com/1028917
File vdsm/vm.py
Line 3660: if state[1] ==
libvirt.VIR_DOMAIN_PAUSED_MIGRATION:
Line 3661: raise MigrationError(Migration Error -
Timed out
Line 3662: (did not receive
success
Line 3663: event))
Line 3664: self.log.debug(NOTE: incomingMigrationFinished
event has
This is logged when we're NOT wanting to destroy the VM because we're not sure
why the migration did not finished (e.g. missed the event)
logging the state and reason is to have some data to figure out what is the
current state (for investigation)
So no I disagree putting it into the exception, because the in the case of the
MigrationError we know that the status must be paused.
Line 3665:not been set and wait timed out
after %d
Line 3666:seconds. Current VM state: %d,
reason %d.
Line 3667:Continuing with VM
initialization anyway.,
Line 3668:timeout, state[0], state[1])
Line 3665:not been set and wait timed out
after %d
Line 3666:seconds. Current VM state: %d,
reason %d.
Line 3667:Continuing with VM
initialization anyway.,
Line 3668:timeout, state[0], state[1])
Line 3669: except libvirt.libvirtError as e:
Because I am now throwing MigrationError and I want to avoid false positive log
messages. And therefore restrict it to VIR_ERR_NO_DOMAIN.
Line 3670: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3671: if not self._incomingMigrationFinished.isSet():
Line 3672: newMsg = ('%s - Timed out '
Line 3673: '(did not receive success event)' %
--
To view, visit http://gerrit.ovirt.org/21963
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Dan Kenigsberg has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 10:
(3 comments)
Commit Message
Line 12: the destination to wait for the migration to finish.
Line 13: This is now reflected as the migration_destination_timeout.
Line 14:
Line 15: If the VM after the timeout still has the state PAUSED and the
Line 16: reason is migration we're going to raise an MigrationError.
Understood - but I think it's worthwhile to mention that this is what going to
happen due to raising MigrationError.
Line 17:
Line 18: Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09
Line 19: Bug-Url: https://bugzilla.redhat.com/1028917
File vdsm/vm.py
Line 3660: if state[1] ==
libvirt.VIR_DOMAIN_PAUSED_MIGRATION:
Line 3661: raise MigrationError(Migration Error -
Timed out
Line 3662: (did not receive
success
Line 3663: event))
Line 3664: self.log.debug(NOTE: incomingMigrationFinished
event has
Ok.
Line 3665:not been set and wait timed out
after %d
Line 3666:seconds. Current VM state: %d,
reason %d.
Line 3667:Continuing with VM
initialization anyway.,
Line 3668:timeout, state[0], state[1])
Line 3665:not been set and wait timed out
after %d
Line 3666:seconds. Current VM state: %d,
reason %d.
Line 3667:Continuing with VM
initialization anyway.,
Line 3668:timeout, state[0], state[1])
Line 3669: except libvirt.libvirtError as e:
Thanks.
Line 3670: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3671: if not self._incomingMigrationFinished.isSet():
Line 3672: newMsg = ('%s - Timed out '
Line 3673: '(did not receive success event)' %
--
To view, visit http://gerrit.ovirt.org/21963
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Vinzenz Feenstra has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Vinzenz Feenstra has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 10: (3 comments) Commit Message Line 6: Line 7: Avoid going into 'Paused' status during long lasting migrations Line 8: Line 9: If a migration is taking longer than 'migration_timeout' the Line 10: migration is moving into 'Paused' state. Done Line 11: We increased the timeout to 6 hours as an absolute maximum for Line 12: the destination to wait for the migration to finish. Line 13: This is now reflected as the migration_destination_timeout. Line 14: Line 7: Avoid going into 'Paused' status during long lasting migrations Line 8: Line 9: If a migration is taking longer than 'migration_timeout' the Line 10: migration is moving into 'Paused' state. Line 11: We increased the timeout to 6 hours as an absolute maximum for Done Line 12: the destination to wait for the migration to finish. Line 13: This is now reflected as the migration_destination_timeout. Line 14: Line 15: If the VM after the timeout still has the state PAUSED and the Line 12: the destination to wait for the migration to finish. Line 13: This is now reflected as the migration_destination_timeout. Line 14: Line 15: If the VM after the timeout still has the state PAUSED and the Line 16: reason is migration we're going to raise an MigrationError. Done Line 17: Line 18: Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Line 19: Bug-Url: https://bugzilla.redhat.com/1028917 -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6629/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6542/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Dan Kenigsberg has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 11: Code-Review+2 (1 comment) Minor textual glitch. Commit Message Line 16: reason is `migration` we're going to raise an MigrationError and Line 17: will lead to the destruction of the VM on the destination. Line 18: Line 19: In all other cases we're keeping the previous behaviour and are Line 20: moving continuing with normal VDSM tasks without touching the s/moving// Line 21: state of the VM. That means that if the VM is in PAUSED state due Line 22: to other reasons than migration, it will stay PAUSED. Line 23: Line 24: Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Dan Kenigsberg has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Vinzenz Feenstra has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6631/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5738/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6544/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Dan Kenigsberg has submitted this change and it was merged. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Avoid going into 'Paused' status during long lasting migrations If a migration is taking longer than 'migration_timeout' the VM moves into 'Paused' state on the destination host. This patch increases the timeout to 6 hours as an absolute maximum for the destination to wait for the migration to finish. This is now reflected as the migration_destination_timeout. If the VM after the timeout still has the state PAUSED and the reason is `migration` we're going to raise an MigrationError and will lead to the destruction of the VM on the destination. In all other cases we're keeping the previous behaviour and are continuing with normal VDSM tasks without touching the state of the VM. That means that if the VM is in PAUSED state due to other reasons than migration, it will stay PAUSED. Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Bug-Url: https://bugzilla.redhat.com/1028917 Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21963 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/config.py.in M vdsm/vm.py 2 files changed, 30 insertions(+), 11 deletions(-) Approvals: Vinzenz Feenstra: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6594/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5701/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6507/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6603/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5710/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6517/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Dan Kenigsberg has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 10: Code-Review-1
(5 comments)
Commit Message
Line 6:
Line 7: Avoid going into 'Paused' status during long lasting migrations
Line 8:
Line 9: If a migration is taking longer than 'migration_timeout' the
Line 10: migration is moving into 'Paused' state.
migration... - the VM moves into 'Paused' state on the destination host.
Line 11: We increased the timeout to 6 hours as an absolute maximum for
Line 12: the destination to wait for the migration to finish.
Line 13: This is now reflected as the migration_destination_timeout.
Line 14:
Line 7: Avoid going into 'Paused' status during long lasting migrations
Line 8:
Line 9: If a migration is taking longer than 'migration_timeout' the
Line 10: migration is moving into 'Paused' state.
Line 11: We increased the timeout to 6 hours as an absolute maximum for
We-This patch increases
Line 12: the destination to wait for the migration to finish.
Line 13: This is now reflected as the migration_destination_timeout.
Line 14:
Line 15: If the VM after the timeout still has the state PAUSED and the
Line 12: the destination to wait for the migration to finish.
Line 13: This is now reflected as the migration_destination_timeout.
Line 14:
Line 15: If the VM after the timeout still has the state PAUSED and the
Line 16: reason is migration we're going to raise an MigrationError.
Why? Are we trying to destroy the VM on destination? I think we do, and this is
the interesting thing. The motivation for this was not to keep stray VMs at the
destination after the source has died. But frankly - it's raceful. Only Engine
should decide to destroy the VM.
Line 17:
Line 18: Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09
Line 19: Bug-Url: https://bugzilla.redhat.com/1028917
File vdsm/vm.py
Line 3660: if state[1] ==
libvirt.VIR_DOMAIN_PAUSED_MIGRATION:
Line 3661: raise MigrationError(Migration Error -
Timed out
Line 3662: (did not receive
success
Line 3663: event))
Line 3664: self.log.debug(NOTE: incomingMigrationFinished
event has
how about avoiding this long log line, and embedding state and timeout in
the text of MigrationError? They would be printed to the log when the exception
is caught.
Line 3665:not been set and wait timed out
after %d
Line 3666:seconds. Current VM state: %d,
reason %d.
Line 3667:Continuing with VM
initialization anyway.,
Line 3668:timeout, state[0], state[1])
Line 3665:not been set and wait timed out
after %d
Line 3666:seconds. Current VM state: %d,
reason %d.
Line 3667:Continuing with VM
initialization anyway.,
Line 3668:timeout, state[0], state[1])
Line 3669: except libvirt.libvirtError as e:
change of Exception to libvirtError is noble, but why is it related to the
change?
Line 3670: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3671: if not self._incomingMigrationFinished.isSet():
Line 3672: newMsg = ('%s - Timed out '
Line 3673: '(did not receive success event)' %
--
To view, visit http://gerrit.ovirt.org/21963
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Francesco Romani has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6499/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5606/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6412/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Vinzenz Feenstra has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Yaniv Bronhaim has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 7:
(1 comment)
File lib/vdsm/config.py.in
Line 56:
Line 57: ('migration_destination_timeout', '21600',
Line 58: 'Maximum time the destination waits for the migration to
finish.'),
Line 59:
Line 60: ('migration_timeout', '300',
now I just don't don't understand what this timeout is specifying .. maximum
time the source host waits? I'd suggest to update the doc for this value
Line 61: 'Migration Source Host: Uses at least 1/2 of this value
for VMs '
Line 62: 'with less than 2 GiB of RAM otherwise 1/4 of this value
per GiB '
Line 63: 'RAM for calculating the delay before setting/increasing
the '
Line 64: 'migration_downtime.'
--
To view, visit http://gerrit.ovirt.org/21963
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Vinzenz Feenstra has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 7:
(1 comment)
File lib/vdsm/config.py.in
Line 56:
Line 57: ('migration_destination_timeout', '21600',
Line 58: 'Maximum time the destination waits for the migration to
finish.'),
Line 59:
Line 60: ('migration_timeout', '300',
Well please suggest a better text I should update here. Please note that the
next patchset in the chain, however is attempting to fix this by removing it
and adding a new value for it. That's why I actually chained them.
Line 61: 'Migration Source Host: Uses at least 1/2 of this value
for VMs '
Line 62: 'with less than 2 GiB of RAM otherwise 1/4 of this value
per GiB '
Line 63: 'RAM for calculating the delay before setting/increasing
the '
Line 64: 'migration_downtime.'
--
To view, visit http://gerrit.ovirt.org/21963
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6104/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5317/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6207/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6110/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5323/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6213/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
Vinzenz Feenstra has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 4: Verified+1 Verified on EL6 with a 100GiB VM with the stress tool running in the vm and a reduced timeout for the destination (not 6 hours, but 100 seconds, by changing the configuration) Non reduced migration (without stress tool running in the vm) went through without a problem for the same 100GiB VM -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5980/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5184/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6072/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
