Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 15: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/768/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Yaniv Bronhaim has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 15: Verified -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 16: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/783/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Dan Kenigsberg has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 16: I would prefer that you didn't submit this (1 inline comment) I like this patch! I would like to see its follow up patch, too (the one with function renaming and other fixes). however please note my comment regarding the commit message. Commit Message Line 3: AuthorDate: 2012-08-30 16:51:25 +0300 Line 4: Commit: Yaniv Bronhaim ybron...@redhat.com Line 5: CommitDate: 2012-08-30 16:51:25 +0300 Line 6: Line 7: BZ#734847- vdsmd always restarts libvirtd upon start-up please note to an annoying comment of mine from http://gerrit.ovirt.org/#/c/7331/13..16//COMMIT_MSG Line 8: Line 9: When starting vdsm we need to verify that libvirt is running by Line 10: upstart and not by SysV. When processing start() we stop libvirtd Line 11: service only if upstart exists and not configured. -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 13: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/762/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 13: I would prefer that you didn't submit this
(6 inline comments)
Commit Message
Line 3: AuthorDate: 2012-08-29 19:22:03 +0300
Line 4: Commit: Yaniv Bronhaim ybron...@redhat.com
Line 5: CommitDate: 2012-08-29 19:22:03 +0300
Line 6:
Line 7: BZ#734847- vdsmd always restarts libvirtd upon start-up
I hate to play policeman and start enforcing this, but please use
Bug-Id: https://bugzilla.redhat.com/734847
tag. See the boring thread ending in
http://lists.ovirt.org/pipermail/arch/2012-August/000823.html
Line 8:
Line 9: When starting vdsm we need to verify that libvirt is running by
Line 10: upstart and not by SysV.
Line 11:
File vdsm/vdsmd.init.in
Line 146: done
Line 147: return 0
Line 148: }
Line 149:
Line 150: is_sysv_exist() {
you probably mean
upstart_exists()
but I think that a better name is
libvirt_should_use_upstart()
which we could in the future compute more semsibly.
Line 151: [[ -x /sbin/initctl ]]
Line 152: }
Line 153:
Line 154: start_needed_srv() {
Line 439: return 1
Line 440: }
Line 441:
Line 442: is_already_run_with_upstart(){
Line 443: packaged=`/bin/rpm -ql libvirt libvirt-daemon | \
I do not quite like the code duplication here
Line 444: /bin/grep libvirtd.upstart | /usr/bin/tail -1`
Line 445: target=/etc/init/libvirtd.conf
Line 446: if diff -q $packaged $target /dev/null 21;
Line 447: then
Line 441:
Line 442: is_already_run_with_upstart(){
Line 443: packaged=`/bin/rpm -ql libvirt libvirt-daemon | \
Line 444: /bin/grep libvirtd.upstart | /usr/bin/tail -1`
Line 445: target=/etc/init/libvirtd.conf
wouldn't a simple
[[ -f /etc/init/libvirtd.conf ]]
be enough for your needs?
Line 446: if diff -q $packaged $target /dev/null 21;
Line 447: then
Line 448: return 0
Line 449: fi
Line 450: return 1
Line 451: }
Line 452:
Line 453: is_libvirtd_run(){
Line 454: if pgrep libvirtd /dev/null 21;
dropping the whole if gives the same semantics.
Line 455: then
Line 456: return 0
Line 457: fi
Line 458: return 1
Line 485: then
Line 486: return
Line 487: fi
Line 488:
Line 489: startout=`/sbin/initctl start libvirtd 21`
could you explain (in the commit message) where a running libvirt is killed and
restarted? is it here? or line 470? or both?
Line 490: if [[ $? -eq 0 || $startout =~ .*already\ running.* ]];
Line 491: then
Line 492: await_libvirt_start_workaround
Line 493: return 0
--
To view, visit http://gerrit.ovirt.org/7331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Yaniv Bronhaim has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 9: The main change in this patch is to omit the line that calls to shutdown_conflicting_srv stop_libvirtd_sysv - this is unnecessary before running vdsm. If you prefer that I will change this patch to include only this omitting without including debug_log and the fix in stop_libvirtd_sysv method (that we don't use anymore), i will change it. please tell me. -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Michal Skrivanek has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 9: (2 inline comments)
File vdsm/vdsmd.init.in
Line 305: if [ $force_reconfigure != force ]
Line 306:grep -q $by_vdsm_vers $lconf grep -q $by_vdsm_vers
$qconf \
Line 307:grep -q $by_vdsm_vers $ldconf grep -q $by_vdsm_vers
$qlconf
Line 308: then
Line 309: debug_log no reconfigure proccedded
typo, I guess?
Line 310: log_success_msg $$prog: libvirt already configured for vdsm
Line 311: return 0
Line 312: fi
Line 313:
Line 425: }
Line 426:
Line 427: stop_libvirtd_sysv() {
Line 428: # stop libvirt SysV service if we intend to configure upstart
Line 429: if ! upstart_libvirt; then
then why keep this function around? At minimum please put a comment it's not
actually used.
Line 430: debug_log stopping libvirt service..
Line 431: /sbin/chkconfig libvirtd off
Line 432: /sbin/service libvirtd stop
Line 433: fi
--
To view, visit http://gerrit.ovirt.org/7331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Michal Skrivanek has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 10: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 11: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/684/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Moti Asayag has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 11: According to [1] the correct method is using upstart to manage libvirt. [1] https://bugzilla.redhat.com/show_bug.cgi?id=728153 -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 12: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/687/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Michal Skrivanek has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Yaniv Bronhaim has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 9: (2 inline comments)
please check my comments.
File vdsm/vdsmd.init.in
Line 402: # run service for restart instead of using initctl, both works
Line 403: # the same and works on fedora and rhel
Line 404: # /sbin/initctl restart libvirtd 2/dev/null || :
Line 405: debug_log running restart for libvirt
Line 406: /sbin/service libvirtd restart
because after i checked and verified both services controller work with service
libvirt.. so we don't need this condition here.
Line 407: }
Line 408:
Line 409:
Line 410: RETVAL=0
Line 425: }
Line 426:
Line 427: stop_libvirtd_sysv() {
Line 428: # stop libvirt SysV service if we intend to configure upstart
Line 429: if ! upstart_libvirt; then
look on upstart_libvirt please. it checks if initctl exist. if it does not
exist we need to stop libvirt (thats why the function is called
stop_libvirtd_sysv and not only stop_libvirt. anyway, we don't use this
function anymore as part of this fix (look on line 462), i just fixed this
function to do what it is called to do.
Line 430: debug_log stopping libvirt service..
Line 431: /sbin/chkconfig libvirtd off
Line 432: /sbin/service libvirtd stop
Line 433: fi
--
To view, visit http://gerrit.ovirt.org/7331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 9: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/608/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 9: I would prefer that you didn't submit this (1 inline comment) File vdsm/vdsmd.init.in Line 402: # run service for restart instead of using initctl, both works Line 403: # the same and works on fedora and rhel Line 404: # /sbin/initctl restart libvirtd 2/dev/null || : Line 405: debug_log running restart for libvirt Line 406: /sbin/service libvirtd restart Hi Yaniv, Why don't we us if ! upstart_libvirt; then service libvirt... else initctl ? I think most of vdsmd.init script already uses like that. Line 407: } Line 408: Line 409: Line 410: RETVAL=0 -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..
Patch Set 9: (1 inline comment)
File vdsm/vdsmd.init.in
Line 425: }
Line 426:
Line 427: stop_libvirtd_sysv() {
Line 428: # stop libvirt SysV service if we intend to configure upstart
Line 429: if ! upstart_libvirt; then
humm, reading the comment looks like ! is not required. Better check with Dan.
Line 430: debug_log stopping libvirt service..
Line 431: /sbin/chkconfig libvirtd off
Line 432: /sbin/service libvirtd stop
Line 433: fi
--
To view, visit http://gerrit.ovirt.org/7331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/575/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Yaniv Bronhaim has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 8: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/592/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
Yaniv Bronhaim has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 5: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/556/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up .. Patch Set 6: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/564/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
