Change in vdsm[master]: Fill volume children info.
Itamar Heim has abandoned this change. Change subject: Fill volume children info. .. Abandoned abandoning per last comment -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@gmail.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Itamar Heim has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 2: In spite that as said in the commit message there are not consumers today for this info may be worth to return the proper info until the key is removed. May be merged. -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Dan Kenigsberg has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 2: The children API is already broken in 3.3 and 3.4. I see no reason to reintroduce it in 3.5. Please abandon! -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 2: Verified+1 Verified on file: │ │ │ ├── cca667fd-d1d5-4377-8bc4-a1653795b72d │ │ │ │ ├── 61fabbbe-b95e-47ae-b9bd-3691549c06da │ │ │ │ ├── 61fabbbe-b95e-47ae-b9bd-3691549c06da.lease │ │ │ │ ├── 61fabbbe-b95e-47ae-b9bd-3691549c06da.meta │ │ │ │ ├── 949b1eac-3aec-4d97-a45a-2321dd2f3545 │ │ │ │ ├── 949b1eac-3aec-4d97-a45a-2321dd2f3545.lease │ │ │ │ └── 949b1eac-3aec-4d97-a45a-2321dd2f3545.meta # ls -1 /rhev/data-center/e517a818-af65-465f-9be3-cd5bd7e059ef/8b84a07e-91b2-44f0-9878-7b0856dc748c/images/cca667fd-d1d5-4377-8bc4-a1653795b72d/ 61fabbbe-b95e-47ae-b9bd-3691549c06da 61fabbbe-b95e-47ae-b9bd-3691549c06da.lease 61fabbbe-b95e-47ae-b9bd-3691549c06da.meta 949b1eac-3aec-4d97-a45a-2321dd2f3545 949b1eac-3aec-4d97-a45a-2321dd2f3545.lease 949b1eac-3aec-4d97-a45a-2321dd2f3545.meta # vdsClient 0 getVolumeInfo 8b84a07e-91b2-44f0-9878-7b0856dc748c e517a818-af65-465f-9be3-cd5bd7e059ef cca667fd-d1d5-4377-8bc4-a1653795b72d 61fabbbe-b95e-47ae-b9bd-3691549c06da status = OK domain = 8b84a07e-91b2-44f0-9878-7b0856dc748c capacity = 1073741824 voltype = LEAF description = parent = 949b1eac-3aec-4d97-a45a-2321dd2f3545 format = COW image = cca667fd-d1d5-4377-8bc4-a1653795b72d uuid = 61fabbbe-b95e-47ae-b9bd-3691549c06da disktype = 2 legality = LEGAL mtime = 1381392388 apparentsize = 262144 truesize = 11776 type = SPARSE children = [] pool = ctime = 1381392388 # vdsClient 0 getVolumeInfo 8b84a07e-91b2-44f0-9878-7b0856dc748c e517a818-af65-465f-9be3-cd5bd7e059ef cca667fd-d1d5-4377-8bc4-a1653795b72d 949b1eac-3aec-4d97-a45a-2321dd2f3545 status = OK domain = 8b84a07e-91b2-44f0-9878-7b0856dc748c capacity = 1073741824 voltype = INTERNAL description = parent = ---- format = RAW image = cca667fd-d1d5-4377-8bc4-a1653795b72d uuid = 949b1eac-3aec-4d97-a45a-2321dd2f3545 disktype = 2 legality = LEGAL mtime = 1381392349 apparentsize = 1073741824 truesize = 512 type = SPARSE children = ['61fabbbe-b95e-47ae-b9bd-3691549c06da'] pool = ctime = 1381392348 -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Dan Kenigsberg has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 1: Code-Review-1 (1 comment) File vdsm/storage/volume.py Line 900: info['truesize'] = 0 Line 901: info['mtime'] = 0 Line 902: info['status'] = INVALID Line 903: Line 904: # Both engine and dumpStorageTable don't use this option so You should dump or change the comment above. And better squash into the former patch. Line 905: # only keeping it to not break existing scripts that look for the key Line 906: info['children'] = list(self.getChildren()) Line 907: Line 908: # If image was set to illegal, mark the status same -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 1: (1 comment) File vdsm/storage/volume.py Line 900: info['truesize'] = 0 Line 901: info['mtime'] = 0 Line 902: info['status'] = INVALID Line 903: Line 904: # Both engine and dumpStorageTable don't use this option so 1) It is still true that actually they are not consumers of this field. 2) This is a different patch because is breaking BC if someone relies on a false empty list. The former one no affects BC. Line 905: # only keeping it to not break existing scripts that look for the key Line 906: info['children'] = list(self.getChildren()) Line 907: Line 908: # If image was set to illegal, mark the status same -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has uploaded a new change for review. Change subject: Fill volume children info. .. Fill volume children info. In spite that they are no consumers for 'children' key in Volume.getInfo() result adding the children set for correcteness. Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Signed-off-by: Eduardo ewars...@redhat.com --- M vdsm/storage/volume.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/20004/1 diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py index c19ec2f..96b84d7 100644 --- a/vdsm/storage/volume.py +++ b/vdsm/storage/volume.py @@ -903,7 +903,7 @@ # Both engine and dumpStorageTable don't use this option so # only keeping it to not break existing scripts that look for the key -info['children'] = [] +info['children'] = list(self.getChildren()) # If image was set to illegal, mark the status same # (because of VDC constraints) -- To view, visit http://gerrit.ovirt.org/20004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fill volume children info.
Eduardo has posted comments on this change. Change subject: Fill volume children info. .. Patch Set 1: Verified+1 # lvs -o lv_name,lv_tags,lv_attr d0dccb15-bc4e-4815-889a-c116028f30b0 /dev/dm-19: read failed after 0 of 4096 at 1073676288: Input/output error LV LV Tags Attr aeae31c0-63a9-4745-835b-92546f237b8f IU_95aa8eec-32bb-42e8-8853-f4e094a1060a,PU_----,MD_9 -wi-- b48ba89a-6b90-41c5-b73d-9e7c2e313a51 MD_6,PU_d979e09c-0a7b-47fb-8235-d2872928ef04,IU_79f93e4e-6b22-4b8a-9567-ea9b6b3093ff -wi-- b65475aa-fec4-4e1f-99ca-c5464af7ad07 MD_7,PU_d979e09c-0a7b-47fb-8235-d2872928ef04,IU_aa3dc170-f09a-4bd2-8c53-54300a6f67c3 -wi-- c80a31d2-f0d4-46ec-9624-a1dee55c82c7 IU_95aa8eec-32bb-42e8-8853-f4e094a1060a,PU_aeae31c0-63a9-4745-835b-92546f237b8f,MD_10 -wi-- d979e09c-0a7b-47fb-8235-d2872928ef04 PU_----,MD_5,IU_f8ca3be1-3aad-4785-a938-2b29bb499a40 -wi-- ids -wi-ao--- inbox -wi-a leases -wi-a master -wi-a metadata -wi-a outbox -wi-a ## Before # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 8790f4b1-a47e-47cb-8cd4-bf9d6841fbed f8ca3be1-3aad-4785-a938-2b29bb499a40 d979e09c-0a7b-47fb-8235-d2872928ef04 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 5368709120 voltype = SHARED description = Active VM parent = ---- format = COW image = f8ca3be1-3aad-4785-a938-2b29bb499a40 uuid = d979e09c-0a7b-47fb-8235-d2872928ef04 disktype = 2 legality = LEGAL mtime = 1380800450 apparentsize = 2147483648 truesize = 2147483648 type = SPARSE children = [] pool = ctime = 1380800444 ## After: # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 8790f4b1-a47e-47cb-8cd4-bf9d6841fbed f8ca3be1-3aad-4785-a938-2b29bb499a40 d979e09c-0a7b-47fb-8235-d2872928ef04 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 5368709120 voltype = SHARED description = Active VM parent = ---- format = COW image = f8ca3be1-3aad-4785-a938-2b29bb499a40 uuid = d979e09c-0a7b-47fb-8235-d2872928ef04 disktype = 2 legality = LEGAL mtime = 1380800450 apparentsize = 2147483648 truesize = 2147483648 type = SPARSE children = ['b65475aa-fec4-4e1f-99ca-c5464af7ad07', 'b48ba89a-6b90-41c5-b73d-9e7c2e313a51'] pool = ctime = 1380800444 # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 8790f4b1-a47e-47cb-8cd4-bf9d6841fbed 95aa8eec-32bb-42e8-8853-f4e094a1060a aeae31c0-63a9-4745-835b-92546f237b8f status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 4294967296 voltype = INTERNAL description = parent = ---- format = COW image = 95aa8eec-32bb-42e8-8853-f4e094a1060a uuid = aeae31c0-63a9-4745-835b-92546f237b8f disktype = 2 legality = LEGAL mtime = 1381229549 apparentsize = 1073741824 truesize = 1073741824 type = SPARSE children = ['c80a31d2-f0d4-46ec-9624-a1dee55c82c7'] pool = ctime = 1381229549 # vdsClient -s 0 getVolumeInfo d0dccb15-bc4e-4815-889a-c116028f30b0 8790f4b1-a47e-47cb-8cd4-bf9d6841fbed 95aa8eec-32bb-42e8-8853-f4e094a1060a c80a31d2-f0d4-46ec-9624-a1dee55c82c7 status = OK domain = d0dccb15-bc4e-4815-889a-c116028f30b0 capacity = 4294967296 voltype = LEAF description = v_child_1 parent = aeae31c0-63a9-4745-835b-92546f237b8f format = COW image = 95aa8eec-32bb-42e8-8853-f4e094a1060a uuid = c80a31d2-f0d4-46ec-9624-a1dee55c82c7 disktype = 0 legality = LEGAL mtime = 1381267310 apparentsize = 1073741824 truesize = 1073741824
