Change in vdsm[master]: Fix makefile - move config.log to right location
Dan Kenigsberg has posted comments on this change. Change subject: Fix makefile - move config.log to right location .. Patch Set 3: Code-Review+2 Continuous-Integration+1 FAIL: test_events_keys (network.netlink_test.NetlinkEventMonitorTests) is known, and about to be marked as broken. -- To view, visit https://gerrit.ovirt.org/63221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Fix makefile - move config.log to right location
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix makefile - move config.log to right location .. Fix makefile - move config.log to right location Probably by mistake config.log was declared in wrong location and caused failure in rpmbuild run Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/63221 Reviewed-by: Irit Goihman Reviewed-by: Dan Kenigsberg Continuous-Integration: Dan Kenigsberg --- M vdsm_hooks/checkips/Makefile.am 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/63221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Fix makefile - move config.log to right location
gerrit-hooks has posted comments on this change. Change subject: Fix makefile - move config.log to right location .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/63221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Fix makefile - move config.log to right location
gerrit-hooks has posted comments on this change. Change subject: Fix makefile - move config.log to right location .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Fix makefile - move config.log to right location
Irit Goihman has posted comments on this change. Change subject: Fix makefile - move config.log to right location .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Fix makefile - move config.log to right location
gerrit-hooks has posted comments on this change. Change subject: Fix makefile - move config.log to right location .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Fix makefile - move config.log to right location
Yaniv Bronhaim has posted comments on this change. Change subject: Fix makefile - move config.log to right location .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/63221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Fix makefile - move config.log to right location
gerrit-hooks has posted comments on this change. Change subject: Fix makefile - move config.log to right location .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Fix makefile - move config.log to right location
Yaniv Bronhaim has uploaded a new change for review. Change subject: Fix makefile - move config.log to right location .. Fix makefile - move config.log to right location Probably by mistake config.log was declared in wrong location and caused failure in rpmbuild run Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Signed-off-by: Yaniv Bronhaim --- M vdsm_hooks/checkips/Makefile.am 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/63221/1 diff --git a/vdsm_hooks/checkips/Makefile.am b/vdsm_hooks/checkips/Makefile.am index 4b25acd..9d2c014 100644 --- a/vdsm_hooks/checkips/Makefile.am +++ b/vdsm_hooks/checkips/Makefile.am @@ -27,9 +27,10 @@ nodist_noinst_DATA = \ vdsm-checkips.service \ - config.log + $(NULL) CLEANFILES = \ + config.log \ $(nodist_noinst_DATA) EXTRA_DIST = \ -- To view, visit https://gerrit.ovirt.org/63221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org