Change in vdsm[master]: Remove redundant file closing
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove redundant file closing .. Remove redundant file closing Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20106 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/netconf/ifcfg.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant file closing
Dan Kenigsberg has posted comments on this change. Change subject: Remove redundant file closing .. Patch Set 1: Code-Review+2 Oops. -- To view, visit http://gerrit.ovirt.org/20106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant file closing
Dan Kenigsberg has posted comments on this change. Change subject: Remove redundant file closing .. Patch Set 1: Verified+1 Obviously correct. -- To view, visit http://gerrit.ovirt.org/20106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant file closing
Antoni Segura Puimedon has uploaded a new change for review. Change subject: Remove redundant file closing .. Remove redundant file closing Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com --- M vdsm/netconf/ifcfg.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/20106/1 diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py index b278183..6c8af10 100644 --- a/vdsm/netconf/ifcfg.py +++ b/vdsm/netconf/ifcfg.py @@ -671,7 +671,6 @@ self._backup(conffile) with open(conffile, 'w') as f: f.writelines(entries) -f.close() def setIfaceMtu(self, iface, newmtu): cf = netinfo.NET_CONF_PREF + iface -- To view, visit http://gerrit.ovirt.org/20106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant file closing
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant file closing .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4925/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4040/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4850/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/679/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant file closing
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant file closing .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4040/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4850/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/679/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4928/ : ABORTED -- To view, visit http://gerrit.ovirt.org/20106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
