Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Dan Kenigsberg has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Dan Kenigsberg has submitted this change and it was merged. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Replace unused getFileList() with more flexible getFileStats() 1. Rename to getFileStats(). New name getFileStats() better describes the essence of that API. This is safe to rename it because this API is not in use. 2. Add caseSensitive option. Currently Engine is using getIsoList() and getFloppyList() APIs to retrieve the list of iso and floppy files respectively. Both these APIs are working in case-insensitive manner but don't provide file statistics. getFileStats() returns file statistics. Adding caseSensitive option allows using getFileStats() instead of getIsoList() and getFloppyList(). Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Bug-Url: https://bugzilla.redhat.com/1005889 Signed-off-by: Sergey Gotliv sgot...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20476 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Ayal Baron aba...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClient.py M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm/storage/storage_exception.py M vdsm_api/Bridge.py M vdsm_api/vdsmapi-schema.json 7 files changed, 38 insertions(+), 30 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, but someone else must approve Sergey Gotliv: Verified Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Sergey Gotliv has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Ayal Baron has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Nir Soffer has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
oVirt Jenkins CI Server has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5129/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4325/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5203/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Federico Simoncelli has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 6: Code-Review+1 I'm not thrilled by the caseSensitive argument. I'll think about it. The rest looks good. -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Sergey Gotliv has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 5: Yes, it's correct. I did a lot of changes due to your comments in the patch set 5. See diff between 5 and 4. -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
oVirt Jenkins CI Server has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5101/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4297/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5175/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Nir Soffer has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 5: Code-Review+1 (1 comment) Nice - there is one possible documentation cleanup if you post another version. File vdsm/storage/hsm.py Line 2238: :param caseSensitive: Enables case-sensitive matching. Line 2239: :type caseSensitive: bool Line 2240: :options: ? Line 2241: Line 2242: :returns: a dict of all files and statistics matching the pattern. :returns: file statistics for files matching pattern. Is more correct. The fact that we return a dict is specified in :rtype: bellow. Line 2243: :rtype: dict Line 2244: Line 2245: vars.task.setDefaultException(se.GetFileStatsError(sdUUID)) Line 2246: vars.task.getSharedLock(STORAGE, sdUUID) -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Sergey Gotliv has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 5: (1 comment) File vdsm/storage/hsm.py Line 2238: :param caseSensitive: Enables case-sensitive matching. Line 2239: :type caseSensitive: bool Line 2240: :options: ? Line 2241: Line 2242: :returns: a dict of all files and statistics matching the pattern. Done Line 2243: :rtype: dict Line 2244: Line 2245: vars.task.setDefaultException(se.GetFileStatsError(sdUUID)) Line 2246: vars.task.getSharedLock(STORAGE, sdUUID) -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace unused getFileList() with more flexible getFileStats()
Nir Soffer has posted comments on this change. Change subject: Replace unused getFileList() with more flexible getFileStats() .. Patch Set 5: Are you sure patch 5 is correct? I don't see the changes in gerrit. -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
