Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
From Yaniv Bronhaim: Yaniv Bronhaim has abandoned this change. Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory" .. Abandoned reopen when re-visiting fedora build for vdsm -- To view, visit https://gerrit.ovirt.org/62453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
Yaniv Bronhaim has posted comments on this change. Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory" .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62453/3//COMMIT_MSG Commit Message: PS3, Line 10: 17 > I suppose you mean 4.17 here. because then vdsm-python will be arch depended , or we need to change the way we fix the upgrade issue -- To view, visit https://gerrit.ovirt.org/62453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv BronhaimGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
Dan Kenigsberg has posted comments on this change. Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory" .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/62453/3//COMMIT_MSG Commit Message: PS3, Line 10: 17 I suppose you mean 4.17 here. Why don't we want to support upgrade from ovirt-3.6 to ovirt-4.1? -- To view, visit https://gerrit.ovirt.org/62453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv BronhaimGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
gerrit-hooks has posted comments on this change. Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory" .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv BronhaimGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
gerrit-hooks has posted comments on this change. Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory" .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv BronhaimGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
Yaniv Bronhaim has posted comments on this change. Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory" .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/62453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv BronhaimGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
Douglas Schilling Landgraf has posted comments on this change. Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv BronhaimGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
gerrit-hooks has posted comments on this change. Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory" .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv BronhaimGerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "Remove __init__.py file from lib64 vdsm python direc...
Yaniv Bronhaim has uploaded a new change for review. Change subject: Revert "Remove __init__.py file from lib64 vdsm python directory" .. Revert "Remove __init__.py file from lib64 vdsm python directory" This reverts commit 9f9e8b37c6fb120f1bb40514c9d22c9d5602dded. Which is not needed anymore (we stop supporting upgrade from vdsm <=17). Without the %post script we can declare vdsm-python as noarch. Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Signed-off-by: Yaniv Bronhaim--- M vdsm.spec.in 1 file changed, 0 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/62453/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index edd8e82..8aaa866 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -347,19 +347,6 @@ %description python Shared libraries between the various VDSM packages. -%post python -# REQUIRED_FOR: Upgrade from 4.14 to 4.17 -# HACK: Remove vdsm python lib __init__ file if installed on old location -# https://bugzilla.redhat.com/show_bug.cgi?id=1279167 -if [ "$1" -ge 2 ]; then -if [ -d "%{python2_sitearch}/%{vdsm_name}" ]; then -logger -t '%{vdsm_name}' \ -'Disabling old vdsm package in %{python2_sitearch}/%{vdsm_name}.' \ -'Removing %{python2_sitearch}/%{vdsm_name}/init.py*' -rm -f %{python2_sitearch}/%{vdsm_name}/__init__.py* -fi -fi - %package tests Summary:VDSM Test Suite BuildArch: noarch -- To view, visit https://gerrit.ovirt.org/62453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id06b502c714074a62c8ac6b5d5cb9d350472137b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org