Change in vdsm[master]: Sort the pep8 whitelist list
Dan Kenigsberg has submitted this change and it was merged. Change subject: Sort the pep8 whitelist list .. Sort the pep8 whitelist list Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Signed-off-by: Saggi Mizrahi smizr...@redhat.com --- M Makefile.am 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Ewoud Kohl van Wijngaarden: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Dan Kenigsberg has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 13: Looks good to me, approved The commit message is now wrong, but this little patch annoyed us enough. -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 13: Verified; Looks good to me, but someone else must approve Can we get this merged fast? It's a trivial patch that is taking more time than needed with all the rebasing. -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
oVirt Jenkins CI Server has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 13: Build Failed http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/419/ : FAILURE -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Douglas Schilling Landgraf has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 13: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Shu Ming has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
oVirt Jenkins CI Server has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 12: No score Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/225/ -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
oVirt Jenkins CI Server has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 12: Build Successful http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/225/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 11: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 5: (1 inline comment) File Makefile.am Line 64:vdsm/qemuImg.py \ The patch is to sort it, so I would expect this to be removed somewhere. Now it seems you added it out of nowhere. -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Dan Kenigsberg has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) File Makefile.am Line 66:vdsm/qemuImg.py \ evil tab -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Saggi Mizrahi has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 4: (1 inline comment) File Makefile.am Line 66:vdsm/qemuImg.py \ I shell vanquish the evil from this file! -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Dan Kenigsberg has posted comments on this change. Change subject: Sort the pep8 whitelist list .. Patch Set 4: (1 inline comment) File Makefile.am Line 60:vdsm/hooks.py \ and much worse - you're using non-C locale for sorting. I think the difference between a slash and an underscore is quite significant. -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sort the pep8 whitelist list
Saggi Mizrahi has uploaded a new change for review. Change subject: Sort the pep8 whitelist list .. Sort the pep8 whitelist list Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Signed-off-by: Saggi Mizrahi smizr...@redhat.com --- M Makefile.am 1 file changed, 11 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/6246/1 -- To view, visit http://gerrit.ovirt.org/6246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f021e72 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
