Change in vdsm[master]: Too many True sizes for a False Volume class.
Ayal Baron has posted comments on this change. Change subject: Too many True sizes for a False Volume class. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98c82bf2b48c62626b496fe16e4b83f48c189c10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Too many True sizes for a False Volume class.
Dan Kenigsberg has posted comments on this change. Change subject: Too many True sizes for a False Volume class. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98c82bf2b48c62626b496fe16e4b83f48c189c10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Too many True sizes for a False Volume class.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Too many True sizes for a False Volume class. .. Too many True sizes for a False Volume class. Since an (abstract) volume never will be instantiated alone, get the size of the typed object instead. Removes Volume.getVSize(), Volume.getVTrueSize() and Volume.getVolumeTrueSize(). Reduce the number of SD produces. Related to BZ#960952, BZ#769502. Change-Id: I98c82bf2b48c62626b496fe16e4b83f48c189c10 Signed-off-by: Eduardo ewars...@redhat.com Reviewed-on: http://gerrit.ovirt.org/17509 Tested-by: Elad Ben Aharon eladba1...@gmail.com Reviewed-by: Ayal Baron aba...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/hsm.py M vdsm/storage/volume.py 2 files changed, 4 insertions(+), 27 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Elad Ben Aharon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98c82bf2b48c62626b496fe16e4b83f48c189c10 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Too many True sizes for a False Volume class.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Too many True sizes for a False Volume class. .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2761/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3568/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3652/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98c82bf2b48c62626b496fe16e4b83f48c189c10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Too many True sizes for a False Volume class.
Eduardo has uploaded a new change for review.
Change subject: Too many True sizes for a False Volume class.
..
Too many True sizes for a False Volume class.
Since an (abstract) volume never will be instantiated alone, get
the size of the typed object instead.
Removes Volume.getVSize(), Volume.getVTrueSize() and
Volume.getVolumeTrueSize().
Reduce the number of SD produces.
Related to BZ#960952, BZ#769502.
Change-Id: I98c82bf2b48c62626b496fe16e4b83f48c189c10
Signed-off-by: Eduardo ewars...@redhat.com
---
M vdsm/storage/hsm.py
M vdsm/storage/volume.py
2 files changed, 4 insertions(+), 27 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/17509/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 5da6ae6..404ffc2 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3049,10 +3049,10 @@
:rtype: dict
# Return string because xmlrpc's int is very limited
-apparentsize = str(volume.Volume.getVSize(sdUUID, imgUUID,
- volUUID, bs=1))
-truesize = str(volume.Volume.getVTrueSize(sdUUID, imgUUID,
- volUUID, bs=1))
+dom = sdCache.produce(sdUUID=sdUUID)
+volClass = dom.getVolumeClass()
+apparentsize = str(volClass.getVSize(dom, imgUUID, volUUID, bs=1))
+truesize = str(volClass.getVTrueSize(dom, imgUUID, volUUID, bs=1))
return dict(apparentsize=apparentsize, truesize=truesize)
@public
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index 0fa70f4..10b3363 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -326,22 +326,6 @@
pass
@classmethod
-def getVSize(cls, sdUUID, imgUUID, volUUID, bs=BLOCK_SIZE):
-
-Return volume size
-
-mysd = sdCache.produce(sdUUID=sdUUID)
-return mysd.getVolumeClass().getVSize(mysd, imgUUID, volUUID, bs)
-
-@classmethod
-def getVTrueSize(cls, sdUUID, imgUUID, volUUID, bs=BLOCK_SIZE):
-
-Return allocated volume size
-
-mysd = sdCache.produce(sdUUID=sdUUID)
-return mysd.getVolumeClass().getVTrueSize(mysd, imgUUID, volUUID, bs)
-
-@classmethod
def parentVolumeRollback(cls, taskObj, sdUUID, pimgUUID, pvolUUID):
cls.log.info(parentVolumeRollback: sdUUID=%s pimgUUID=%s
pvolUUID=%s % (sdUUID, pimgUUID, pvolUUID))
@@ -994,13 +978,6 @@
self.log.error(Volume.setMetaParam: %s: %s=%s %
(self.volUUID, key, value))
raise
-
-def getVolumeTrueSize(self, bs=BLOCK_SIZE):
-
-Return the size of the storage allocated for this volume
-on underlying storage
-
-pass
def getVolumeParams(self, bs=BLOCK_SIZE):
volParams = {}
--
To view, visit http://gerrit.ovirt.org/17509
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98c82bf2b48c62626b496fe16e4b83f48c189c10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Too many True sizes for a False Volume class.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Too many True sizes for a False Volume class. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2756/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3563/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3647/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98c82bf2b48c62626b496fe16e4b83f48c189c10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
