Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Federico Simoncelli has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Dan Kenigsberg has submitted this change and it was merged. Change subject: Use quiesce only if qgaEnable is enabled .. Use quiesce only if qgaEnable is enabled Do not attempt to use the quiesce live snapshot flag if the guest agent channel is not present. Signed-off-by: Federico Simoncelli fsimo...@redhat.com Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 --- M vdsm/libvirtvm.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Mark Wu: Looks good to me, but someone else must approve Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Ayal Baron has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Federico Simoncelli has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: why should we attempt live snapshot with no guest agent support? The question was: why attempting to use the guest agent (with quiesce) if we already know that we can't reach it (if even present), given that the channel is not enabled. I missed this in my previous patch because there was a collision with another patch that introduced this new option. -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Dan Kenigsberg has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Mark Wu has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: Looks good to me, but someone else must approve There's an availability checking for guest agent in libvirt, so it's fine to just check the configuration option. -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Federico Simoncelli has uploaded a new change for review.
Change subject: Use quiesce only if qgaEnable is enabled
..
Use quiesce only if qgaEnable is enabled
Do not attempt to use the quiesce live snapshot flag if the guest agent
channel is not present.
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058
---
M vdsm/libvirtvm.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/7143/1
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 8bf5bb2..d8aecc1 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1791,8 +1791,10 @@
self._volumesPrepared = False
snapFlags = (libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY |
- libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT |
- libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE)
+ libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT)
+
+if utils.tobool(self.conf.get('qgaEnable', 'true')):
+snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
while True:
try:
--
To view, visit http://gerrit.ovirt.org/7143
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/412/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use quiesce only if qgaEnable is enabled
Dan Kenigsberg has posted comments on this change. Change subject: Use quiesce only if qgaEnable is enabled .. Patch Set 1: I would prefer that you didn't submit this why should we attempt live snapshot with no guest agent support? -- To view, visit http://gerrit.ovirt.org/7143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44758949d7a328117f4d759d8d9df1183eb058 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
