Change in vdsm[master]: added glusterVolumeProfileInfo verb
Timothy Asir has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 17: Verified -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Dan Kenigsberg has submitted this change and it was merged.
Change subject: added glusterVolumeProfileInfo verb
..
added glusterVolumeProfileInfo verb
Following is the output structure
when nfs is true:
{'volumeName': VOLUME-NAME,
'nfsServers': [
{'nfs': SERVER-NAME,
'cumulativeStats': {'blockStats': [{'size': int,
'read': int,
'write': int}, ...],
'fopStats': [{'name': FOP-NAME,
'hits': int,
'latencyAvg': float,
'latencyMin': float,
'latencyMax': float}, ...],
'duration': int,
'totalRead': int,
'totalWrite': int},
'intervalStats': {'blockStats': [{'size': int,
'read': int,
'write': int}, ...],
'fopStats': [{'name': FOP-NAME,
'hits': int,
'latencyAvg': float,
'latencyMin': float,
'latencyMax': float}, ...],
'duration': int,
'totalRead': int,
'totalWrite': int}}, ...]}
When nfs is false:
{'volumeName': VOLUME-NAME,
'bricks': [
{'brick': BRICK-NAME,
'cumulativeStats': {'blockStats': [{'size': int,
'read': int,
'write': int}, ...],
'fopStats': [{'name': FOP-NAME,
'hits': int,
'latencyAvg': float,
'latencyMin': float,
'latencyMax': float}, ...],
'duration': int,
'totalRead': int,
'totalWrite': int},
'intervalStats': {'blockStats': [{'size': int,
'read': int,
'write': int}, ...],
'fopStats': [{'name': FOP-NAME,
'hits': int,
'latencyAvg': float,
'latencyMin': float,
'latencyMax': float}, ...],
'duration': int,
'totalRead': int,
'totalWrite': int}}, ...]}
Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c
Signed-off-by: Timothy Asir tjeya...@redhat.com
---
M tests/Makefile.am
A tests/glusterTestData.py
A tests/glusterVolumeProfileInfo.xml
A tests/glusterVolumeProfileInfoNfs.xml
M tests/gluster_cli_tests.py
M vdsm.spec.in
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm_cli/vdsClientGluster.py
10 files changed, 2,250 insertions(+), 71 deletions(-)
Approvals:
Timothy Asir: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Dan Kenigsberg has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 17: Looks good to me, approved thanks. -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Bala.FA has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 16: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Timothy Asir has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 16: Verified -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 14: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/166/ (2/2) -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 14: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/200/ (1/2) -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Timothy Asir has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 14: Verified -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 15: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/215/ (1/2) -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/181/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/215/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 15: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/181/ (2/2) -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Bala.FA has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 15: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Timothy Asir has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 15: Verified -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 12: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/186/ (2/2) -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 12: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/152/ (1/2) -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 12: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/152/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/186/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 13: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/192/ (2/2) -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Timothy Asir has posted comments on this change.
Change subject: added glusterVolumeProfileInfo verb
..
Patch Set 11: (1 inline comment)
File tests/gluster_cli_tests.py
Line 991:
Line 992: tree = etree.fromstring(out)
Line 993: status = gcli._parseVolumeProfileInfo(tree)
Line 994: self.assertEquals(status, {'bricks': [], 'volumeName': None})
Line 995:
done
Line 996: def _parseVolumeProfileInfo(self):
Line 997: out = '''?xml version=1.0 encoding=UTF-8
standalone=yes?
Line 998: cliOutput
Line 999: opRet0/opRet
--
To view, visit http://gerrit.ovirt.org/7436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Bala.FA has posted comments on this change.
Change subject: added glusterVolumeProfileInfo verb
..
Patch Set 11: I would prefer that you didn't submit this
(1 inline comment)
File tests/gluster_cli_tests.py
Line 991:
Line 992: tree = etree.fromstring(out)
Line 993: status = gcli._parseVolumeProfileInfo(tree)
Line 994: self.assertEquals(status, {'bricks': [], 'volumeName': None})
Line 995:
This case never occurs. Please remove it
Line 996: def _parseVolumeProfileInfo(self):
Line 997: out = '''?xml version=1.0 encoding=UTF-8
standalone=yes?
Line 998: cliOutput
Line 999: opRet0/opRet
--
To view, visit http://gerrit.ovirt.org/7436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 10: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/16/ -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 10: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/16/ : FAILURE -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 11: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/23/ -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 11: Verified Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/23/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Bala.FA has posted comments on this change.
Change subject: added glusterVolumeProfileInfo verb
..
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
Commit Message
Line 7: added glusterVolumeProfileInfo verb
Line 8:
Line 9: Following is the output structure
Line 10:
Line 11: { 'statusCode' : CODE,
What does statusCode mean? Isn't it conflicting with verb 'status'?
Line 12:'volumeName' : VOLUME-NAME,
Line 13:'brickCount' : BRICK-COUNT,
Line 14:'bricks' : {
Line 15: BRICK-NAME: {
Line 9: Following is the output structure
Line 10:
Line 11: { 'statusCode' : CODE,
Line 12:'volumeName' : VOLUME-NAME,
Line 13:'brickCount' : BRICK-COUNT,
No need of brickCount
Line 14:'bricks' : {
Line 15: BRICK-NAME: {
Line 16: 'cumulativeStats': {
Line 17: 'blockStats': [
File vdsm/gluster/cli.py
Line 819: return True
Line 820:
Line 821:
Line 822: @exportToSuperVdsm
Line 823: def volumeProfileInfo(volumeName):
Add docstring describing return structure
Line 824: command = _getGlusterVolCmd() + [profile, volumeName, info]
Line 825: try:
Line 826: xmltree = _execGlusterXml(command)
Line 827: except ge.GlusterCmdFailedException, e:
--
To view, visit http://gerrit.ovirt.org/7436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Timothy Asir has posted comments on this change.
Change subject: added glusterVolumeProfileInfo verb
..
Patch Set 5: (3 inline comments)
Commit Message
Line 7: added glusterVolumeProfileInfo verb
Line 8:
Line 9: Following is the output structure
Line 10:
Line 11: { 'statusCode' : CODE,
Yes, I agree, It's just a gluster cli return code. I will remove it
Line 12:'volumeName' : VOLUME-NAME,
Line 13:'brickCount' : BRICK-COUNT,
Line 14:'bricks' : {
Line 15: BRICK-NAME: {
Line 9: Following is the output structure
Line 10:
Line 11: { 'statusCode' : CODE,
Line 12:'volumeName' : VOLUME-NAME,
Line 13:'brickCount' : BRICK-COUNT,
I will remove it
Line 14:'bricks' : {
Line 15: BRICK-NAME: {
Line 16: 'cumulativeStats': {
Line 17: 'blockStats': [
File vdsm/gluster/cli.py
Line 819: return True
Line 820:
Line 821:
Line 822: @exportToSuperVdsm
Line 823: def volumeProfileInfo(volumeName):
Done
Line 824: command = _getGlusterVolCmd() + [profile, volumeName, info]
Line 825: try:
Line 826: xmltree = _execGlusterXml(command)
Line 827: except ge.GlusterCmdFailedException, e:
--
To view, visit http://gerrit.ovirt.org/7436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: added glusterVolumeProfileInfo verb
Hello Bala.FA, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/7436
to review the following change.
Change subject: added glusterVolumeProfileInfo verb
..
added glusterVolumeProfileInfo verb
Following is the output structure
{ 'statusCode' : CODE,
'volumeName' : VOLUME-NAME,
'brickCount' : BRICK-COUNT,
'bricks' : {
BRICK-NAME: {
'cumulativeStats': {
'blockStat': [
{ 'size': SIZE,
'read': READ-COUNT,
'write': WRITE-COUNT
}, ...],
'fopStat': [
{ 'name': FOP-NAME,
'hits': HITS,
'latencyAvg': AVERAGE-LATENCY,
'latencyMin': MINIMUM-LATENCY,
'latencyMax': MAXIMUM-LATENCY
}, ...],
'duration': DURATION,
'totalRead': TOTAL-READ,
'totalWrite': TOTAL-WRITE },
'intervalStats': {
'blockStat': [
{ 'size': SIZE,
'read': READ-COUNT,
'write': WRITE-COUNT
}, ...],
'fopStat': [
{ 'name': FOP-NAME,
'hits': HITS,
'latencyAvg': AVERAGE-LATENCY,
'latencyMin': MINIMUM-LATENCY,
'latencyMax': MAXIMUM-LATENCY
}, ...],
'duration': DURATION,
'totalRead': TOTAL-READ,
'totalWrite': TOTAL-WRITE }}, ...}}
Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c
Signed-off-by: Timothy Asir tjeya...@redhat.com
---
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm_cli/vdsClientGluster.py
4 files changed, 81 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/7436/1
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index dc3ec0b..9073791 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -229,6 +229,11 @@
def volumeProfileStop(self, volumeName, options=None):
self.svdsmProxy.glusterVolumeProfileStop(volumeName)
+@exportAsVerb
+def volumeProfileInfo(self, volumeName, options=None):
+status = self.svdsmProxy.glusterVolumeProfileInfo(volumeName)
+return {'profileInfo': status}
+
def getGlusterMethods(gluster):
l = []
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index 2618aa1..059bff4 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -155,6 +155,54 @@
return volumeInfoDict
+def _parseGlusterVolumeProfileInfo(tree):
+fopCumulative = []
+blkCumulative = []
+fopInterval = []
+blkInterval = []
+bricks = {}
+for brick in tree.findall('volProfile/brick'):
+for block in brick.findall('cumulativeStats/blockStats/block'):
+blkCumulative.append({'size': block.find('size').text,
+ 'read': block.find('reads').text,
+ 'write': block.find('writes').text})
+for fop in brick.findall('cumulativeStats/fopStats/fop'):
+fopCumulative.append({'name': fop.find('name').text,
+ 'hits': fop.find('hits').text,
+ 'latencyAvg': fop.find('avgLatency').text,
+ 'latencyMin': fop.find('minLatency').text,
+ 'latencyMax': fop.find('maxLatency').text})
+for block in brick.findall('intervalStats/blockStats/block'):
+blkInterval.append({'size': block.find('size').text,
+'read': block.find('reads').text,
+'write': block.find('writes').text})
+for fop in brick.findall('intervalStats/fopStats/fop'):
+fopInterval.append({'name': fop.find('name').text,
+'hits': fop.find('hits').text,
+'latencyAvg': fop.find('avgLatency').text,
+'latencyMin': fop.find('minLatency').text,
+'latencyMax': fop.find('maxLatency').text})
+bricks[brick.find('brickName').text] = {
+'cumulativeStats': {
+'blockStats': blkCumulative,
+'fopStats': fopCumulative,
+'duration': brick.find('cumulativeStats/duration').text,
+'totalRead': brick.find('cumulativeStats/totalRead').text,
+'totalWrite': brick.find('cumulativeStats/totalWrite').text},
+'intervalStats': {
+
Change in vdsm[master]: added glusterVolumeProfileInfo verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: added glusterVolumeProfileInfo verb .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/633/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
