Change in vdsm[master]: build: update libvirt dependency for fedora

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: build: update libvirt dependency for fedora
..


build: update libvirt dependency for fedora

Require a libvirt version that fixes the problem of reporting
physical=0 for COW2 volumes on block storage on Fedora. The given
version 1.1.2.18.1 exists in Fedora 23 and fixes the issue.

See Fedora BZ: https://bugzilla.redhat.com/1253754

Though the fix is only in libvirt-daemon, the libvirt-python
required version is also aligned to it to keep consistency.

Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Bug-Url: https://bugzilla.redhat.com/1253756
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/51295
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Allon Mureinik 
---
M vdsm.spec.in
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 5:

* #1253756::Update tracker: OK
* Set MODIFIED::bug 1253756#1253756OK

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 1:

* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
* Check Product::#1253756::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[frolland]

Hello Fred Rolland,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/51295

to review the following change.

Change subject: build: update libvirt dependency for fedora
..

build: update libvirt dependency for fedora

Require a libvirt version that fixes the problem of reporting
physical=0 for COW2 volumes on block storage on Fedora. The given
version 1.1.2.18.1 exists in Fedora 23 and fixes the issue.

See Fedora BZ: https://bugzilla.redhat.com/1253754

Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Bug-Url: https://bugzilla.redhat.com/1253756
Signed-off-by: Fred Rolland 
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/51295/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 97bdfd2..c53fee8 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -150,14 +150,14 @@
 %endif # centos
 %endif # rhel
 
-%if 0%{?fedora} >= 22
+%if 0%{?fedora} == 22
 Requires: libvirt-daemon >= 1.2.13
 Requires: libvirt-python >= 1.2.9-2
 %endif
 
-%if 0%{?fedora}
-Requires: libvirt-daemon >= 1.2.9.3-1
-Requires: libvirt-python >= 1.2.9-2
+%if 0%{?fedora} >= 23
+Requires: libvirt-daemon >= 1.2.18.1-1
+Requires: libvirt-python >= 1.2.18.1-1
 %endif
 
 Requires: libvirt-lock-sanlock, libvirt-client


-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 3:

* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
* Check Product::#1253756::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 4:

* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
* Check Product::#1253756::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 2:

* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
* Check Product::#1253756::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 4: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 3

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: update libvirt dependency for fedora

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: build: update libvirt dependency for fedora
..


Patch Set 4:

Fred, can you verify?

-- 
To view, visit https://gerrit.ovirt.org/51295
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7569dd69d7c5ccfe7cb275acba64c2506d0a9e0a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches