Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-13 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-13 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: build tests: Disable the builtin check target.
..


build tests: Disable the builtin check target.

There is no need to recursively check the tests/ folder for check-local
targets as there are none.

Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63646
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Irit Goihman 
Reviewed-by: Dan Kenigsberg 
---
M tests/Makefile.am
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-13 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-13 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-13 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-12 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Code-Review-1

-1 for attention

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-12 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63646/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-09-11 16:29:06 +0300
Line 6: 
Line 7: build tests: Disable the builtin check target.
Line 8: 
Line 9: There is no need to recursively check the tests/ folder for check-local
IIUIC, check-local here handles all subfolders so there is no need to go 
recursively?
Line 10: targets as there are none.
Line 11: 
Line 12: Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1


-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-11 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-11 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

2016-09-11 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: build tests: Disable the builtin check target.
..

build tests: Disable the builtin check target.

There is no need to recursively check the tests/ folder for check-local
targets as there are none.

Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Signed-off-by: Edward Haas 
---
M tests/Makefile.am
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/63646/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index ae671c9..2ff09a4 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -370,10 +370,14 @@
 run_modules += $(device_modules)
 run_modules += $(common_modules)
 
+# Disable builtin (recursive) check target.
+check-recursive:
+   @true
+
 # crossImportsTests.py has to be run separate due to different tests which
 # load modules first, making the env dirty. Unloading python modules
 # is not supported, see http://bugs.python.org/issue9072 .
-check-local:
+check:
@echo '*** Running tests.  To skip this step place NOSE_EXCLUDE=.* ***'
@echo '*** into your environment.  Do not submit untested code!***'
$(top_srcdir)/tests/run_tests_local.sh $(args) crossImportsTests.py


-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org