Change in vdsm[master]: changing un-shared treatment in the volume share function
Oved Ourfali has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Verified as you requested: vdsClient 0 getVolumeInfo 7e88ee54-36e7-4d79-b447-083ab3050e32 bbf03ebf-46f7-4539-a38e-269b45a9c589 3459f1cf-707f-48cb-acea-e3b805876959 1546c9a0-bb9d-455a-8aaf-8204dfede321 Before: voltype = LEAF After: voltype = SHARED -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
oVirt Jenkins CI Server has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5860/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
Federico Simoncelli has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23260/4//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-01-14 20:18:04 +0200 Line 4: Commit: Oved Ourfali oourf...@redhat.com Line 5: CommitDate: 2014-01-15 13:11:16 +0200 Line 6: Line 7: changing un-shared treatment in the volume share function You probably missed the comment on the subject format. Line 8: Line 9: Up until now, the only way to create a 'template' disk was by using the Line 10: copyImage command. This has 2 limitations: Line 11: 1. It forces the user to copy all the data instead of doing an in-place -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
Oved Ourfali has uploaded a new change for review. Change subject: changing un-shared treatment in the volume share function .. changing un-shared treatment in the volume share function This patch changes the share function to allow non-shared volumes to be shared. If this volume is not shared, and it doesn't have any snapshots, then we set it as shared, and continue with the share function as expected. Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Signed-off-by: Oved Ourfali oourf...@redhat.com --- M vdsm/storage/volume.py 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/23260/1 diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py index fc7a3e5..98f1de2 100644 --- a/vdsm/storage/volume.py +++ b/vdsm/storage/volume.py @@ -300,7 +300,11 @@ self.log.debug(Share volume %s to %s, self.volUUID, dstImgPath) if not self.isShared(): -raise se.VolumeNonShareable(self) +if self.getParent() == BLANK_UUID: +self.log.debug(Volume %s is not shared, but can be shared as it has no snapshots. Setting it as shared, self.volUUID) +self.setShared() +else: +raise se.VolumeNonShareable(self) if os.path.basename(dstImgPath) == os.path.basename(self.imagePath): raise se.VolumeOwnershipError(self) -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
oVirt Jenkins CI Server has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6740/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6653/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5848/ : FAILURE -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
oVirt Jenkins CI Server has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6741/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6654/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5849/ : FAILURE -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
oVirt Jenkins CI Server has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6742/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6655/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5850/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
Oved Ourfali has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Verified+1 Verified that adding VM from template works, both in the use-case in which the disk is shared, and the use-case which it doesn't. -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
Federico Simoncelli has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Code-Review+1 Sane. Please verify it using vdsClient getVolumeInfo commands before and after the first VM is created out of the new template. Before the type should be LEAF and after SHARED. -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
Federico Simoncelli has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/23260/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-01-14 20:18:04 +0200 Line 4: Commit: Oved Ourfali oourf...@redhat.com Line 5: CommitDate: 2014-01-14 20:56:25 +0200 Line 6: Line 7: changing un-shared treatment in the volume share function volume: changing un-shared treatment in the share function Line 8: Line 9: This patch changes the share function to allow non-shared volumes to be Line 10: shared. If this volume is not shared, and it doesn't have any snapshots, Line 11: then we set it as shared volume, and continue with the share function as http://gerrit.ovirt.org/#/c/23260/3/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 299: Line 300: self.log.debug(Share volume %s to %s, self.volUUID, dstImgPath) Line 301: Line 302: if not self.isShared(): Line 303: if self.getParent() == BLANK_UUID: Ayal do you want the RAW check as well? I can't think of any assumption we're having around that. Line 304: self.log.debug(Volume %s is not shared. Setting it as shared, Line 305:self.volUUID) Line 306: self.setShared() Line 307: else: -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
Itamar Heim has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: adding ayal, as noticed federico question in the comment is to him -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changing un-shared treatment in the volume share function
Ayal Baron has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/23260/3/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 299: Line 300: self.log.debug(Share volume %s to %s, self.volUUID, dstImgPath) Line 301: Line 302: if not self.isShared(): Line 303: if self.getParent() == BLANK_UUID: Ayal do you want the RAW check as well? I can't think of any assumption we' I see no reason to block it here, we can just not use it from the engine atm to avoid risk of regressions until tested thoroughly Line 304: self.log.debug(Volume %s is not shared. Setting it as shared, Line 305:self.volUUID) Line 306: self.setShared() Line 307: else: -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
