Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu
oVirt Jenkins CI Server has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/578/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu
Meni Yakove has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 2: Fails (1 inline comment) Can't attach 2 network with MTU to interface. MainProcess|Thread-517::ERROR::2012-08-21 09:21:07,647::configNetwork::1289::setupNetworks::(setupNetworks) %d format: a number is required, not str File vdsm/configNetwork.py Line 567: Line 568: for nic in nics: Line 569: cf = self.NET_CONF_PREF + nic Line 570: mtuval = self._getConfigValue(cf, 'MTU') Line 571: if not mtuval is None: mtuval = int(mtuval) if mtuval mtu: Line 572: if int(mtuval) mtu: Line 573: mtu = mtuval Line 574: return mtu Line 575: -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu
Igor Lvovsky has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 2: I don't know what you talking about, I succeeded to do it right now. could you please send me a log ? -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Meni Yakove myak...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu
Igor Lvovsky has uploaded a new change for review. Change subject: configNetwork: use MTU as int in setNewMtu .. configNetwork: use MTU as int in setNewMtu Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Signed-off-by: Igor Lvovsky ilvov...@redhat.com --- M vdsm/configNetwork.py 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/7360/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index ac4a131..f6669e9 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -583,7 +583,9 @@ _netinfo = netinfo.NetInfo() cf = self.NET_CONF_PREF + bridge currmtu = self._getConfigValue(cf, 'MTU') -if currmtu is None: +if currmtu: +currmtu = int(currmtu) +else: return nics, delvlan, bonding = _netinfo.getNicsVlanAndBondingForNetwork(bridge) @@ -604,19 +606,22 @@ continue cf = self.NET_CONF_PREF + iface + '.' + vlan mtu = self._getConfigValue(cf, 'MTU') +if mtu: +mtu = int(mtu) newmtu = max(newmtu, mtu) if newmtu != currmtu: if bonding: cf = self.NET_CONF_PREF + bonding -self._updateConfigValue(cf, 'MTU', newmtu, newmtu is None) +self._updateConfigValue(cf, 'MTU', str(newmtu), newmtu is None) slaves = netinfo.slaves(bonding) for slave in slaves: cf = self.NET_CONF_PREF + slave -self._updateConfigValue(cf, 'MTU', newmtu, newmtu is None) +self._updateConfigValue(cf, 'MTU', str(newmtu), +newmtu is None) else: cf = self.NET_CONF_PREF + nics[0] -self._updateConfigValue(cf, 'MTU', newmtu, newmtu is None) +self._updateConfigValue(cf, 'MTU', str(newmtu), newmtu is None) def isBridgeNameValid(bridgeName): return bridgeName and len(bridgeName) = MAX_BRIDGE_NAME_LEN and \ -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu
oVirt Jenkins CI Server has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/545/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu
oVirt Jenkins CI Server has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/548/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: use MTU as int in setNewMtu
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu .. Patch Set 2: Looks good to me, approved goodness gracious. this has never ever worked. thanks for fixing this mess - but we must have some kind of a unit test for this. -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
