Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...

2016-09-19 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...

2016-09-19 Thread mmirecki 
Marcin Mirecki has abandoned this change.

Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...

2016-09-12 Thread Jenkins CI 
Jenkins CI has posted comments on this change.

Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...

2016-09-12 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...

2016-09-12 Thread mmirecki 
Marcin Mirecki has posted comments on this change.

Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..


Patch Set 2: Code-Review-1 Verified-1

-- 
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...

2016-09-12 Thread mmirecki 
Marcin Mirecki has uploaded a new change for review.

Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..

draft: Hook before_nic_libvirt_migration_destination, proposal 1

Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Signed-off-by: mirecki 
---
M lib/vdsm/hooks.py
M vdsm/virt/vm_migrate_hook.py
2 files changed, 17 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/63684/1

diff --git a/lib/vdsm/hooks.py b/lib/vdsm/hooks.py
index 03363ae..8c7efc6 100644
--- a/lib/vdsm/hooks.py
+++ b/lib/vdsm/hooks.py
@@ -418,6 +418,18 @@
 raiseError=False, hookType=_JSON_HOOK)
 
 
+def before_nic_libvirt_migration_destination(
+devicexml, vmconf={}, customProperties={}):
+return _runHooksDir(devicexml, 'before_nic_libvirt_migration_destination',
+vmconf=vmconf, params=customProperties)
+
+
+def after_nic_libvirt_migration_destination(
+devicexml, vmconf={}, customProperties={}):
+return _runHooksDir(devicexml, 'after_nic_libvirt_migration_destination',
+vmconf=vmconf, params=customProperties)
+
+
 def _getScriptInfo(path):
 try:
 with open(path) as f:
diff --git a/vdsm/virt/vm_migrate_hook.py b/vdsm/virt/vm_migrate_hook.py
index 633e4f0..e198497 100755
--- a/vdsm/virt/vm_migrate_hook.py
+++ b/vdsm/virt/vm_migrate_hook.py
@@ -24,6 +24,7 @@
 import traceback
 import xml.etree.cElementTree as ET
 
+from vdsm import hooks
 from vdsm import jsonrpcvdscli
 from vdsm.config import config
 from vdsm.network import api as net_api
@@ -86,8 +87,12 @@
   for dev in target_vm_conf['devices']
   if dev.get('type') == 'interface'}
 for interface in devices.findall('interface'):
+hooks.before_nic_libvirt_migration_destination(interface,
+   target_vm_conf)
 if interface.get('type') == 'bridge':
 _bind_iface_to_bridge(interface, target_vm_nets_by_vnic_mac)
+hooks.after_nic_libvirt_migration_destination(interface,
+  target_vm_conf)
 
 
 def _bind_iface_to_bridge(interface, target_vm_nets_by_vnic_mac):


-- 
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: draft: Hook before_nic_libvirt_migration_destination, propos...

2016-09-12 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38363bd36f5580d006960487ad7df0dc5ded73bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org