Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has abandoned this change. Change subject: getIsoList() returns dict with files metadata .. Abandoned I took another approach to fix this issue: http://gerrit.ovirt.org/#/c/20476/ -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Saggi Mizrahi has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 11: Shouldn't this be abandoned because of http://gerrit.ovirt.org/#/c/20476/ ? -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 11: Wake up maintainer - its time to merge :-) -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 11:
(2 comments)
File vdsm/storage/hsm.py
Line 2271: raise se.GetIsoListError(spUUID)
Line 2272:
Line 2273: fileStats = isoDom.getFileList(pattern='*.' + extension,
Line 2274:caseSensitive=False)
Line 2275: # Older clients expected list of file names with correct
permissions.
I will.
Line 2276: fileNames = [key for key, value in fileStats.iteritems()
Line 2277: if value['status'] == 0]
Line 2278:
Line 2279: return {'isolist': fileNames, 'fileStats': fileStats}
File vdsm_api/vdsmapi-schema.json
Line 3840: # @isolist: List of file names with proper permissions (for backward
compatibility)
Line 3841: #
Line 3842: # @fileStats: Mapping with all file information
Line 3843: #
Line 3844: # Since: 4.14.0
I think that 4.13 is on the way out. But in any case it can be changed after
the merge, this file is not in use anyway.
Line 3845: ##
Line 3846: {'type': 'StorageDomainFileInfoMap',
Line 3847: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3848:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4995/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4108/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4918/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 11: Code-Review+1
(2 comments)
Looks good except the API version that can be fixed when merging.
File vdsm/storage/hsm.py
Line 2271: raise se.GetIsoListError(spUUID)
Line 2272:
Line 2273: fileStats = isoDom.getFileList(pattern='*.' + extension,
Line 2274:caseSensitive=False)
Line 2275: # Older clients expected list of file names with correct
permissions.
Older clients are expecting a list; fix this if you need to post another patch.
Line 2276: fileNames = [key for key, value in fileStats.iteritems()
Line 2277: if value['status'] == 0]
Line 2278:
Line 2279: return {'isolist': fileNames, 'fileStats': fileStats}
File vdsm_api/vdsmapi-schema.json
Line 3840: # @isolist: List of file names with proper permissions (for backward
compatibility)
Line 3841: #
Line 3842: # @fileStats: Mapping with all file information
Line 3843: #
Line 3844: # Since: 4.14.0
Why 4.14?
Line 3845: ##
Line 3846: {'type': 'StorageDomainFileInfoMap',
Line 3847: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3848:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 11: Rebase -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4994/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4107/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4917/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Ayal Baron has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 10: Verified+1 Dan, I think that reviewers generally agree with that direction, right? -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Saggi Mizrahi has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 9:
(2 comments)
File vdsm/storage/hsm.py
Line 2263:
Line 2264: fileStats = isoDom.getFileList(pattern='*.' + extension,
Line 2265:caseSensitive=False)
Line 2266: # Older clients expected list of file names with correct
permissions.
Line 2267: fileNames = [key for key, value in fileStats.items()
filestats.iteritems()
Line 2268: if value['status'] == 0]
Line 2269:
Line 2270: return {'isolist': fileNames, 'fileStats': fileStats}
Line 2271:
File vdsm_api/vdsmapi-schema.json
Line 3802: # @isolist: List of file names with proper permissions (for backward
compatibility)
Line 3803: #
Line 3804: # @fileStats: Mapping with all file information
Line 3805: #
Line 3806: # Since: 4.12.2
:)
Line 3807: ##
Line 3808: {'type': 'StorageDomainFileInfoMap',
Line 3809: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3810:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 9:
(1 comment)
Reply
File vdsm_api/vdsmapi-schema.json
Line 3802: # @isolist: List of file names with proper permissions (for backward
compatibility)
Line 3803: #
Line 3804: # @fileStats: Mapping with all file information
Line 3805: #
Line 3806: # Since: 4.12.2
Lets ask Dan?
Line 3807: ##
Line 3808: {'type': 'StorageDomainFileInfoMap',
Line 3809: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3810:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 9:
(1 comment)
File vdsm_api/vdsmapi-schema.json
Line 3802: # @isolist: List of file names with proper permissions (for backward
compatibility)
Line 3803: #
Line 3804: # @fileStats: Mapping with all file information
Line 3805: #
Line 3806: # Since: 4.12.2
Maybe I should use 4.14. Just to be sure that this patch will be in.
Line 3807: ##
Line 3808: {'type': 'StorageDomainFileInfoMap',
Line 3809: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3810:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 9:
(1 comment)
API version should be updated as master version was bumped to 4.13.0.
File vdsm_api/vdsmapi-schema.json
Line 3802: # @isolist: List of file names with proper permissions (for backward
compatibility)
Line 3803: #
Line 3804: # @fileStats: Mapping with all file information
Line 3805: #
Line 3806: # Since: 4.12.2
Use 4.13.0
Line 3807: ##
Line 3808: {'type': 'StorageDomainFileInfoMap',
Line 3809: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3810:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4970/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4084/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4894/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4958/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4072/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4882/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 8: I changed Bridge.py due to Saggi's comment. -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Saggi Mizrahi has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 7: Code-Review-1
Since you changed the base return type of the call you need to change Bridge.py
as well
look for:
'StoragePool_getIsoList': {'ret': 'isolist'},
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Dan Kenigsberg has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 7: A gallant developer suggested that using the existing getFileList verb would be more fitting for this task, while keeping our API cleaner. The only problem with using it NOW is that its current globbing is case-sensitive, while Engine would like it to be insensitive. This can be solved by passing a new option to control case sensitivity. In https://bugzilla.redhat.com/show_bug.cgi?id=693218 Engine requested the getFileList verb. Maybe it's time to start using it? I'm not stating my opinion as firmly as I should because I woke up late in the process of these reviews. -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Federico Simoncelli has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 7: Code-Review+1 Nice! This works well with the recent db/ui changes! -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Ayal Baron has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3851/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4660/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 6:
(9 comments)
Commit Message
Line 5: CommitDate: 2013-10-01 22:45:50 +0300
Line 6:
Line 7: getIsoList() returns dict with files metadata
Line 8:
Line 9: Previously getIsoList() returned only list of file names although it has
Done
Line 10: additional information such as file size. Absence of this information
Line 11: prevented Engine to display correct data.
Line 12:
Line 13: Now this API returns all available information about these files
File vdsm/storage/hsm.py
Line 2240: @public
Line 2241: def getIsoList(self, spUUID, extension='iso', options=None):
Line 2242: """
Line 2243: Gets a dict of ISO files in a storage pool. For backward
Line 2244: compatibility also return a list of file names.
Done
Line 2245:
Line 2246: :param spUUID: The UUID of the storage pool you want to
query.
Line 2247: :type spUUID: UUID
Line 2248: :param extension: ?
Line 2256: vars.task.getSharedLock(STORAGE, spUUID)
Line 2257: isoDom = self.getPool(spUUID).getIsoDomain()
Line 2258: if not isoDom:
Line 2259: raise se.GetIsoListError(spUUID)
Line 2260:
I respect your opinion but don't agree with it.
# Return all files stats including those with wrong permissions
>You can see it from the code
# so client can tell why file is not usable and display more helpful
# information.
>This is a good sentence for patch description but not for the code. I don't
>have to explain what client can do with that API. It has input an output...
I don't need to explain the natural behavior, code should do that. The natural
behavior of "getIsoList" is returning the iso list.
What is really needs explanation is why name list is filtered, because as a
code reader I don't expect the method with name "getIsoList" will filter
something.
For example, getFileList doesn't filter anything, so according to you it has to
defend itself.
I am going with you and trying better explain "usable" side, but let's leave
new behavior as clean as possible.
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Line 2264: fileNames = [key for key, value in filesDict.items()
Line 2257: isoDom = self.getPool(spUUID).getIsoDomain()
Line 2258: if not isoDom:
Line 2259: raise se.GetIsoListError(spUUID)
Line 2260:
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Done
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Line 2264: fileNames = [key for key, value in filesDict.items()
Line 2265: if value['status'] == 0]
Line 2259: raise se.GetIsoListError(spUUID)
Line 2260:
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Done
Line 2264: fileNames = [key for key, value in filesDict.items()
Line 2265: if value['status'] == 0]
Line 2266:
Line 2267: return {'isolist': fileNames, 'fileStats': filesDict}
Line 2260:
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Line 2264: fileNames = [key for key, value in filesDict.items()
I prefer it that way. The thing of "usable" is documented good enough.
You always can provide another patch with that rename.
Line 2265: if value['status'] == 0]
Line 2266:
Line 2267: return {'isolist': fileNames, 'fileStats': filesDict}
Line 2268:
Line 2269: @public
Line 2270: def getFloppyList(self, spUUID, options=None):
Line 2271: """
Line 2272: Gets a dict of floppy files in a storage pool. For backward
Line 2273: compatibility also return a list of file names.
Done
Line 2274:
Line 2275: :param spUUID: The UUID of the storage pool you want to
query.
Line 2276: :type spUUID: UUID
Line 2277: :param options: ?
File vdsm_api/vdsmapi-schema.json
Line 3794: # @StorageDomainFileInfoMap:
Line 3795: #
Line 3796: # Mapping with information about files contained within a Storage
Domain.
Line 3797: #
Line 3798: # @isolist: List of file names (for backward comp
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 6:
(10 comments)
Looks very good - but need to emphasize the difference between the old isolist
and new fileStats. It is little confusing that one collection include only
usable files and the other all files; hopefully more precise documentation will
mitigate this confusion.
Commit Message
Line 5: CommitDate: 2013-10-01 22:45:50 +0300
Line 6:
Line 7: getIsoList() returns dict with files metadata
Line 8:
Line 9: Previously getIsoList() returned only list of file names although it has
More correct:
Previously getIsoList() returned only list of usable file names although it
has
Line 10: additional information such as file size. Absence of this information
Line 11: prevented Engine to display correct data.
Line 12:
Line 13: Now this API returns all available information about these files
Line 13: Now this API returns all available information about these files
Line 14: including files with wrong permissions, so Engine can display correct
Line 15: sizes and files that previously were hidden. It also returns
Line 16: the information in the old format in order to support old Engine
Line 17: versions.
Good description!
Line 18:
Line 19: Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Line 20: Bug-Url: https://bugzilla.redhat.com/1005889
File vdsm/storage/hsm.py
Line 2240: @public
Line 2241: def getIsoList(self, spUUID, extension='iso', options=None):
Line 2242: """
Line 2243: Gets a dict of ISO files in a storage pool. For backward
Line 2244: compatibility also return a list of file names.
More correct:
Gets a dict of all iso files in a storage pool. For backward
compatibility also return a list of usable file names.
Line 2245:
Line 2246: :param spUUID: The UUID of the storage pool you want to
query.
Line 2247: :type spUUID: UUID
Line 2248: :param extension: ?
Line 2256: vars.task.getSharedLock(STORAGE, spUUID)
Line 2257: isoDom = self.getPool(spUUID).getIsoDomain()
Line 2258: if not isoDom:
Line 2259: raise se.GetIsoListError(spUUID)
Line 2260:
Explain why do not filter fileStats:
# Return all files stats including those with wrong permissions,
# so client can tell why file is not usable and display more helpful
# information.
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Line 2264: fileNames = [key for key, value in filesDict.items()
Line 2257: isoDom = self.getPool(spUUID).getIsoDomain()
Line 2258: if not isoDom:
Line 2259: raise se.GetIsoListError(spUUID)
Line 2260:
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Rename to fileStats
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Line 2264: fileNames = [key for key, value in filesDict.items()
Line 2265: if value['status'] == 0]
Line 2259: raise se.GetIsoListError(spUUID)
Line 2260:
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Replace comment that explain what the code does with comment that explain why
it does that:
# Older clients expected list of file names with correct permissions.
Line 2264: fileNames = [key for key, value in filesDict.items()
Line 2265: if value['status'] == 0]
Line 2266:
Line 2267: return {'isolist': fileNames, 'fileStats': filesDict}
Line 2260:
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Line 2264: fileNames = [key for key, value in filesDict.items()
Rename fileNames to usableFileNames
Line 2265: if value['status'] == 0]
Line 2266:
Line 2267: return {'isolist': fileNames, 'fileStats': filesDict}
Line 2268:
Line 2269: @public
Line 2270: def getFloppyList(self, spUUID, options=None):
Line 2271: """
Line 2272: Gets a dict of floppy files in a storage pool. For backward
Line 2273: compatibility also return a list of file names.
More correct:
Gets a dict of all floppy files in a storage pool. For backward
compatibility also return a list of usable f
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3842/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4727/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4651/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 5:
(1 comment)
File vdsm/storage/hsm.py
Line 2261: found = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263:
Line 2264: # Filter out files without proper permissions
Line 2265: filtered = dict((key, value) for key, value in found.items()
Great idea! And update the commit message and documentation that now *all*
files are returned, and the engine can display information about inaccessible
files which was hidden before.
Line 2266: if value['status'] == 0)
Line 2267:
Line 2268: return {'isolist': filtered.keys(), 'fileStats': filtered}
Line 2269:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Ayal Baron has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 5: Code-Review-1
(1 comment)
File vdsm/storage/hsm.py
Line 2261: found = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263:
Line 2264: # Filter out files without proper permissions
Line 2265: filtered = dict((key, value) for key, value in found.items()
why are you filtering out the files with wrong permissions from the dict?
We now have the opportunity to return these together with this information so
that user (engine) would be able to know why a file is not usable...
Line 2266: if value['status'] == 0)
Line 2267:
Line 2268: return {'isolist': filtered.keys(), 'fileStats': filtered}
Line 2269:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 5:
(1 comment)
File vdsm_api/vdsmapi-schema.json
Line 3799: #
Line 3800: # @fileStats: Mapping with file information
Line 3801: #
Line 3802: # Since: 4.12.1
Line 3803: ##
Latest release (4.12.1) does *not* include this api". So it must be 4.12.2 or
4.13.0.
Do we have a roadmap where we can see future releases?
Line 3804: {'type': 'StorageDomainFileInfoMap',
Line 3805: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3806:
Line 3807: ##
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 5:
(1 comment)
File vdsm_api/vdsmapi-schema.json
Line 3799: #
Line 3800: # @fileStats: Mapping with file information
Line 3801: #
Line 3802: # Since: 4.12.1
Line 3803: ##
I am expecting this patch to be merged to the master, so what version it should
be?
4.12.1?
4.13?
Line 3804: {'type': 'StorageDomainFileInfoMap',
Line 3805: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3806:
Line 3807: ##
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3797/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4682/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4606/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Saggi Mizrahi has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 4: Code-Review-1 Put the number of the version you expect this to get in. -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 4: Code-Review+1
(1 comment)
Check new return value "Since" version.
File vdsm_api/vdsmapi-schema.json
Line 3798: # @isolist: List of file names (for backward compatibility)
Line 3799: #
Line 3800: # @fileStats: Mapping with file information
Line 3801: #
Line 3802: # Since: 4.12.0
The version is probably wrong, because stable version is at 4.12.1 and it does
*not* include this api. This value can be set when we know which version will
include this patch.
Line 3803: ##
Line 3804: {'type': 'StorageDomainFileInfoMap',
Line 3805: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3806:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4664/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4588/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3774/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4659/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4583/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 2:
(1 comment)
API is can be less ugly.
File vdsm/storage/hsm.py
Line 2264: # Filter out files without proper permissions
Line 2265: filtered = dict((key, value) for key, value in found.items()
Line 2266: if found[key]['status'] == 0)
Line 2267:
Line 2268: return {'isolist': filtered.keys(), 'isodict': filtered}
"isolist" and "isodict" are ugly and incorrect, since this method is also used
for getting floppy images. We cannot change the "isolist" key because old
clients depend on it, but we can use a better name for "isodict" such as
"fileStats".
Line 2269:
Line 2270: @public
Line 2271: def getFloppyList(self, spUUID, options=None):
Line 2272: """
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 2: -Code-Review
(2 comments)
After more thinking, I think we should avoid this change by calling
getFileList() directly in engine, and filtering the list by status in the
engine.
Using existing api allows the engine to display correct file information even
when working with older vdsm versions, while after this change, engine still
does not have the needed information when working with older vdsm.
File vdsm/storage/hsm.py
Line 2262:caseSensitive=False)
Line 2263:
Line 2264: # Filter out files without proper permissions
Line 2265: filtered = dict((key, value) for key, value in found.items()
Line 2266: if found[key]['status'] == 0)
found[key] should be replaced with value:
if value['status'] == 0)
Line 2267:
Line 2268: return {'isolist': filtered.keys(), 'isodict': filtered}
Line 2269:
Line 2270: @public
Line 2276: :param spUUID: The UUID of the storage pool you want to
query.
Line 2277: :type spUUID: UUID
Line 2278: :param options: ?
Line 2279:
Line 2280: :returns: a dict of all the floppy volumes found.
Should be same return value of getIsoList()
Line 2281: :rtype: dict
Line 2282: """
Line 2283: vars.task.setDefaultException(se.GetFloppyListError("%s" %
spUUID))
Line 2284: return self.getIsoList(spUUID=spUUID, extension='vfd')
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Dan Kenigsberg has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 2: Code-Review-1 It's not going to be easy, but please document the new return value in vdsmapi-schema.json -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4628/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4550/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3743/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4624/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4546/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3739/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Sergey Gotliv has uploaded a new change for review.
Change subject: getIsoList() returns dict with files metadata
..
getIsoList() returns dict with files metadata
Previously getIsoList() returned only list of file names although it has
additional information such as file size. Absence of this information
prevented Engine to display correct data.
Now this API returns all information about these files. It also returns
the information in the old format in order to support old Engine
versions.
Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Bug-Url: https://bugzilla.redhat.com/1005889
Signed-off-by: Sergey Gotliv
---
M vdsm/storage/hsm.py
1 file changed, 12 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/19544/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 9cfabdb..10ab687 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2240,7 +2240,8 @@
@public
def getIsoList(self, spUUID, extension='iso', options=None):
"""
-Gets a list of all ISO/Floppy volumes in a storage pool.
+Gets a dict of ISO/floppy files in a storage pool. For backward
+compatibility also return a list of file names.
:param spUUID: The UUID of the storage pool you want to query.
:type spUUID: UUID
@@ -2248,7 +2249,7 @@
:type extension: str
:options: ?
-:returns: a dict of all the volumes found.
+:returns: a dict with files info
:rtype: dict
"""
vars.task.setDefaultException(se.GetIsoListError(spUUID))
@@ -2257,18 +2258,20 @@
if not isoDom:
raise se.GetIsoListError(spUUID)
-# Get full iso files dictionary
-isodict = isoDom.getFileList(pattern='*.' + extension,
+found = isoDom.getFileList(pattern='*.' + extension,
caseSensitive=False)
-# Get list of iso images with proper permissions only
-isolist = [key for key, value in isodict.items()
- if isodict[key]['status'] == 0]
-return {'isolist': isolist}
+
+# Filter out files without proper permissions
+filtered = dict((key, value) for key, value in found.items()
+ if found[key]['status'] == 0)
+
+return {'isolist': filtered.keys(), 'isodict': filtered}
@public
def getFloppyList(self, spUUID, options=None):
"""
-Gets a list of all Floppy volumes if a storage pool.
+Gets a dict of floppy files in a storage pool. For backward
+compatibility also return a list of file names.
:param spUUID: The UUID of the storage pool you want to query.
:type spUUID: UUID
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
