Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. gluster: Adds new verbs to setup gluster geo-replication. This patch adds two new verbs to setup gluster geo-replication: geoRepKeysGet: This verb executes the gsec create command and then reads the collected public keys generated by gsec create command. It returns the collected public key as a list of strings. geoReoKeysUpdate: This verb takes user name and public key collection as argument. It appends the public keys to the user's authorized_keys file. Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Signed-off-by: Darshan N dnara...@redhat.com Signed-off-by: Bala.FA barum...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38228 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClientGluster.py M vdsm/gluster/__init__.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 7 files changed, 179 insertions(+), 1 deletion(-) Approvals: Bala.FA: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 14: Code-Review+2 Raising -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/793/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/389/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4775/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/766/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/395/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/798/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/396/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/384/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/800/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: Build Started (3/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/766/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: Build Started (6/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/798/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: Build Started (5/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/395/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: Build Started (2/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/389/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: Build Started (4/9) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4775/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: Build Started (8/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/384/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: Build Started (7/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/396/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 15: Build Started (9/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/800/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 13: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17004/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 12: (5 comments) https://gerrit.ovirt.org/#/c/38228/12/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 82: remoteUserName remoteUserName has to be userName as this key update is done local cluster Done Line 92: authKeys rename this to authKeysFile Done Line 108: existingKeyLines can you do this in try..except block by checking EEXIST than os.path.exists Done Line 117: join As outLines is a list of string, does ''.join(...) work? f.readlines() returns lines which contains '\n' at end, so each element of this list has a '\n' present at the end. So just joining with '' would suffice and it works as expected. Line 569: remoteUserName its not remoteUserName instead its userName. Done -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 14: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17192/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17018/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17192/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Bala.FA has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 12: Code-Review-1 (5 comments) Sorry. I missed out earlier in the review. https://gerrit.ovirt.org/#/c/38228/12/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 82: remoteUserName remoteUserName has to be userName as this key update is done local cluster only. Line 92: authKeys rename this to authKeysFile Line 108: existingKeyLines can you do this in try..except block by checking EEXIST than os.path.exists()? The try block needs to be out of current try block Line 117: join As outLines is a list of string, does ''.join(...) work? Line 569: remoteUserName its not remoteUserName instead its userName. Please change this everywhere -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Bala.FA has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17004/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17178/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 13: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17178/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Bala.FA has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 13: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38228/13/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 112: raise you should raise ge.GlusterGeoRepPublicKeyWriteFailedException(err=[str(e)]) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 13: Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 14: Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/38228/13/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 112: raise you should raise ge.GlusterGeoRepPublicKeyWriteFailedException(err=[str(e)] Done -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 14: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17018/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16907/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17079/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 10: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16907/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 10: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17079/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 11: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17092/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16919/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17092/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 11: Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 11: Rebased patch set 9 and fixed a small mistake in api.py -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 11: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16919/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Bala.FA has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 11: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38228/11/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 108: (). why not f.readlines()? -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 12: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17110/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 12: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16937/ -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16937/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17110/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 12: Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 9: Code-Review+1 api and schema changes looks good -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Bala.FA has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 9: Code-Review+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16827/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16999/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16718/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16890/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38228/5/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 116: raise In that case, you have to compare only this Done -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16875/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Bala.FA has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 5: Code-Review-1 (2 comments) If you see this patch is applicable for newer glusterfs, please wait for the release, till then mark it as -1 https://gerrit.ovirt.org/#/c/38228/5/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 99: GlusterGeoRepPublicKeyWriteFailedException No 'e' available here Line 116: raise You haven't taken the rsa/dsa keys in the comparison. The above thing would be simpler by existingKeyLines = [] newKeys = [l.split()[1] for l in geoRepPubKeys] newKeyDict = dict(zap(newKeys, geoRepPubKeys)) try: if os.path.exists(authKeys): with open(authKeys) as f: existingKeyLines = f.readlines() existingKeys = [l.split()[1] for l in existingKeyLines] outLines = existingKeyLines outKeys = set(newKeyDict).difference(set(existingKeyDict)) outLines.append([newKeyDict[k] for k in outKeys]) safeWrite(authKeys, '\n'.join(outLines)) os.chmod(authKeys, 0600) os.chown(authKeys, uid, gid) except IOError as e: raise ge.GlusterGeoRepPublicKeyWriteFailedException(err=[str(e)]) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38228/5/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 99: GlusterGeoRepPublicKeyWriteFailedException No 'e' available here Done Line 116: raise You haven't taken the rsa/dsa keys in the comparison. The above thing woul The sample of single public key generated by geo-rep is as follows: 'command=tar ${SSH_ORIGINAL_COMMAND#* } ssh-rsa B3NzaC1yc2EDAQABAAABAQDTTE3or6J8/hMcveaaou8FedMQNBjkjGB+PxCiiQ5VSahi7Ah0SYKpk70BNYlaRb+XNkfkqoeP+bHXLWUpKH1k2Sl7eVqDeJQhy7QRndz3nnVAOITupyQ0BIRlqX+7AxSAAtqV9DQQ7jQi8Fz3JROxRahSQqKMmR/PUDhUN/EpWSJ7Doh9yA4gAta5Db2hePmE6HzEns/aS2AOO2cBKQvURv9/Rx1ktrCkazWjuPtF5NX85U7eaBtc0hsgfkmPnwzOMvxKdPS6ApNywNBzRosjjJb2ZfaYRsmVQXWZad7xEMUnpxT5id17e++E7Lni5l8yOMu4bYcHpXjluSWi+FUl r...@dhcp43-63.lab.eng.blr.redhat.com\n' They have the ssh set up for selected commands, so the key contains command as well. Because of this I was taking the whole key(command,rsa-key,user@host) to compare. some keys in the authorized_keys file(user copied keys) might not have the command part in the key, so for the comparison to be unambiguous, I feel its better to compare the whole key. Please provide your thoughts. -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Bala.FA has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38228/5/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 116: raise The sample of single public key generated by geo-rep is as follows: In that case, you have to compare only this 'command=tar ${SSH_ORIGINAL_COMMAND#* } ssh-rsa B3NzaC1yc2EDAQABAAABAQDTTE3or6J8/hMcveaaou8FedMQNBjkjGB+PxCiiQ5VSahi7Ah0SYKpk70BNYlaRb+XNkfkqoeP+bHXLWUpKH1k2Sl7eVqDeJQhy7QRndz3nnVAOITupyQ0BIRlqX+7AxSAAtqV9DQQ7jQi8Fz3JROxRahSQqKMmR/PUDhUN/EpWSJ7Doh9yA4gAta5Db2hePmE6HzEns/aS2AOO2cBKQvURv9/Rx1ktrCkazWjuPtF5NX85U7eaBtc0hsgfkmPnwzOMvxKdPS6ApNywNBzRosjjJb2ZfaYRsmVQXWZad7xEMUnpxT5id17e++E7Lni5l8yOMu4bYcHpXjluSWi+FUl -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16570/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16741/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15771/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Bala.FA has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 4: Code-Review-1 (10 comments) https://gerrit.ovirt.org/#/c/38228/4/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 76: GlusterGeoRepPublicKeyFileNotFoundException you need to pass err=[str(e)] Line 85: have userInfo = getpwnam(userName) homeDir = userInfo[5] ... Line 87: GlusterGeoRepUserNotFoundException you should pass [str(e)] Line 93: sshDir 1. call os.makedirs() only if it doesn't exist 2. use os.makedirs(sshDir, mode) Line 98: raise You should handle the exception and raise proper gluster exception. Line 105: authKeys you should do this once you have written things successfully Line 106: key Why can't geoRepPubKeys be list of strings? If you prefer this way, you should use string.splitlines() Line 107: pubKeys You should match token[1] of pubkeys.splitlines() and geoRepPubKeys.splitlines() Line 108: write You should use safeWrite(). Line 111: GlusterGeoRepPublicKeyWriteFailedException err=[str(e)] -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 4: (10 comments) https://gerrit.ovirt.org/#/c/38228/4/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 76: GlusterGeoRepPublicKeyFileNotFoundException you need to pass err=[str(e)] Done Line 85: have Done Line 87: GlusterGeoRepUserNotFoundException you should pass [str(e)] Done Line 93: sshDir 1. call os.makedirs() only if it doesn't exist Done Line 98: raise You should handle the exception and raise proper gluster exception. Done Line 105: authKeys you should do this once you have written things successfully Done Line 106: key Why can't geoRepPubKeys be list of strings? If you prefer this way, you sh Done Line 107: pubKeys You should match token[1] of pubkeys.splitlines() and geoRepPubKeys.splitli Done Line 108: write You should use safeWrite(). Done Line 111: GlusterGeoRepPublicKeyWriteFailedException err=[str(e)] Done -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16504/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16675/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15705/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16316/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15516/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16486/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/508/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16179/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1074/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15379/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16349/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1155/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1057/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/514/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16169/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1072/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15369/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16339/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1145/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1055/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Darshan N has uploaded a new change for review. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. gluster: Adds new verbs to setup gluster geo-replication. This patch adds three new verbs to setup gluster geo-replication: getGeoRepPubKeys: This verb executes the gsec create command and then reads the collected public keys generated by gsec create command. It returns the collected public key as a string. writeGeoReoPubKeys: This verb takes user name and public key collection as argument. It appends the public keys to the user's authorized_keys file. setupGeoRepMountBroker: This verb takes user name, group name and remote volume name as argument. and sets the mount broker need for non-root geo- replication. Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Signed-off-by: Darshan N dnara...@redhat.com --- M client/vdsClientGluster.py M vdsm.spec.in M vdsm/gluster/Makefile.am M vdsm/gluster/__init__.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py A vdsm/gluster/geoSetup.py 9 files changed, 242 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/38228/1 diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py index d86d16d..8d017f9 100644 --- a/client/vdsClientGluster.py +++ b/client/vdsClientGluster.py @@ -613,6 +613,32 @@ pp.pprint(status) return status['status']['code'], status['status']['message'] +def do_glusterGetGeoRepPubKeys(self, args): +status = self.s.glusterGetGeoRepPubKeys() +pp.pprint(status) +return status['status']['code'], status['status']['message'] + +def do_glusterWriteGeoRepPubKeys(self, args): +params = self._eqSplit(args) +userName = params.get('userName', '') +geoRepPubKeys = params.get('geoRepPubKeys', '') + +status = self.s.glusterWriteGeoRepPubKeys(userName, geoRepPubKeys) +pp.pprint(status) +return status['status']['code'], status['status']['message'] + +def do_glusterSetupGeoRepMountBroker(self, args): +params = self._eqSplit(args) +userName = params.get('userName', '') +remoteVolumeName = params.get('remoteVolumeName', '') +groupName = params.get('groupName', '') + +status = self.s.glusterSetupGeoRepMountBroker(userName, + groupName, + remoteVolumeName) +pp.pprint(status) +return status['status']['code'], status['status']['message'] + def getGlusterCmdDict(serv): return \ @@ -1041,5 +1067,24 @@ serv.do_glusterSnapshotRestore, ('snapName=snap_name', 'restore snapshot' + )), + 'glusterGetGeoRepPubKeys': ( + serv.do_glusterGetGeoRepPubKeys, + ('', + 'get geo replication public keys for all nodes in cluster' + )), + 'glusterWriteGeoRepPubKeys': ( + serv.do_glusterWriteGeoRepPubKeys, + ('userName=user_name' + 'geoRepPubKeys=geo_replication_pub_keys', + 'write geo replication public keys to authorized' + ' keys file of user' + )), + 'glusterSetupGeoRepMountBroker': ( + serv.do_glusterSetupGeoRepMountBroker, + ('userName=user_name' + 'remoteVolumeName=remote_volume_name' + 'groupName=group_name', + 'setup mount broker for geo replication' )) } diff --git a/vdsm.spec.in b/vdsm.spec.in index 0740530..1dfe03f 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -1662,6 +1662,7 @@ %{_datadir}/%{vdsm_name}/gluster/api.py* %{_datadir}/%{vdsm_name}/gluster/apiwrapper.py* %{_datadir}/%{vdsm_name}/rpc/vdsmapi-gluster-schema.json +%{_datadir}/%{vdsm_name}/gluster/geoSetup.py* %{_datadir}/%{vdsm_name}/gluster/gfapi.py* %{_datadir}/%{vdsm_name}/gluster/hooks.py* %{_datadir}/%{vdsm_name}/gluster/services.py* diff --git a/vdsm/gluster/Makefile.am b/vdsm/gluster/Makefile.am index 96b8054..d145dec 100644 --- a/vdsm/gluster/Makefile.am +++ b/vdsm/gluster/Makefile.am @@ -32,6 +32,7 @@ apiwrapper.py \ cli.py \ exception.py \ + geoSetup.py \ gfapi.py \ hooks.py \ services.py \ diff --git a/vdsm/gluster/__init__.py b/vdsm/gluster/__init__.py index c50ae4d..95a9c69 100644 --- a/vdsm/gluster/__init__.py +++ b/vdsm/gluster/__init__.py @@ -22,7 +22,8 @@ import tempfile from functools import wraps -MODULE_LIST = ('cli', 'hooks', 'services', 'tasks', 'gfapi', 'storagedev') +MODULE_LIST = ('cli', 'hooks', 'services', 'tasks', + 'gfapi', 'storagedev', 'geoSetup') def makePublic(func): diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py index 6d7e139..15a1b15 100644 ---
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/511/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16141/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1069/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15341/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16311/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1117/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1052/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches