Change in vdsm[master]: gluster: remove unwanted error codes
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: remove unwanted error codes .. gluster: remove unwanted error codes This patch fixes to remove unwanted error codes which are no longer needed. Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Signed-off-by: Bala.FA Reviewed-on: http://gerrit.ovirt.org/19922 Reviewed-by: Timothy Asir Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M vdsm/gluster/exception.py 1 file changed, 0 insertions(+), 45 deletions(-) Approvals: Timothy Asir: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
Dan Kenigsberg has posted comments on this change. Change subject: gluster: remove unwanted error codes .. Patch Set 1: Verified+1 Code-Review+2 I have not verified this patch, but I trust Bala and Timothy that the exceptions are not used at all. -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
Timothy Asir has posted comments on this change. Change subject: gluster: remove unwanted error codes .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
Bala.FA has posted comments on this change. Change subject: gluster: remove unwanted error codes .. Patch Set 1: This error is used at vdsm side. I am sure there is patch in review at engine side or on the way to consume. -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
Maor Lipchuk has posted comments on this change. Change subject: gluster: remove unwanted error codes .. Patch Set 1: What about GlusterVolumeTasksFailedException with code 4161. I see that he was merged in http://gerrit.ovirt.org/#/c/10200/20/vdsm/gluster/exception.py, but still it is not in the engine. -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: remove unwanted error codes .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4744/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4820/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3935/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
Hello Timothy Asir, Saggi Mizrahi, Aravinda VK, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/19922 to review the following change. Change subject: gluster: remove unwanted error codes .. gluster: remove unwanted error codes This patch fixes to remove unwanted error codes which are no longer needed. Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Signed-off-by: Bala.FA --- M vdsm/gluster/exception.py 1 file changed, 0 insertions(+), 45 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/19922/1 diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py index 1d9399f..20c157e 100644 --- a/vdsm/gluster/exception.py +++ b/vdsm/gluster/exception.py @@ -356,51 +356,6 @@ message = "Volume tasks list failed" -class GlusterTaskNotFoundException(GlusterVolumeException): -code = 4162 -message = "Task not found" - -def __init__(self, taskId): -self.taskId = taskId -s = 'task id: %s' % taskId -self.err = [s] - - -class GlusterTaskActionNotFoundException(GlusterVolumeException): -code = 4163 -message = "Task action not found" - -def __init__(self, taskId, action): -self.taskId = taskId -self.action = action -s = 'Action %s not found for task %s' % (action, taskId) -self.err = [s] - - -class GlusterTaskActionUnsupportedException(GlusterVolumeException): -code = 4164 -message = "Task action unsupported" - -def __init__(self, taskId, taskType, action): -self.taskId = taskId -self.taskType = taskType -self.action = action -s = 'Unsupported action %s for task %s and type %s' % \ -(action, taskId, taskType) -self.err = [s] - - -class GlusterTaskTypeUnknownException(GlusterVolumeException): -code = 4165 -message = "Task type unknown" - -def __init__(self, taskId, taskType): -self.taskId = taskId -self.taskType = taskType -s = 'Unknown task type %s for task %s' % (taskId, taskType) -self.err = [s] - - # Host class GlusterHostException(GlusterException): code = 4400 -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
