Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Ayal Baron has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3956/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4766/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4842/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3957/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Federico Simoncelli has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 4: Verified+1 deleteImage on HSM fails (Not SPM) and on SPM is successful. -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Dan Kenigsberg has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: protect deleteImage with the spm lock .. hsm: protect deleteImage with the spm lock Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19795 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 22 insertions(+), 2 deletions(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Dan Kenigsberg has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4678/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4754/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3869/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Dan Kenigsberg has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 2: (1 comment) File vdsm/storage/hsm.py Line 1505: Line 1506: force parameter is deprecated and not evaluated. Line 1507: Line 1508: # vars.task.setDefaultException(se.ChangeMeError(%s % args)) Line 1509: pool = self.getPool(spUUID) # Validates pool connection. WHY? we actually know the answer to the WHY question: it's to make sure we are SPM. Line 1510: dom = sdCache.produce(sdUUID=sdUUID) Line 1511: Line 1512: vars.task.getExclusiveLock(STORAGE, imgUUID) Line 1513: vars.task.getSharedLock(STORAGE, sdUUID) -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Federico Simoncelli has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 2: (1 comment) File vdsm/storage/hsm.py Line 1505: Line 1506: force parameter is deprecated and not evaluated. Line 1507: Line 1508: # vars.task.setDefaultException(se.ChangeMeError(%s % args)) Line 1509: pool = self.getPool(spUUID) # Validates pool connection. WHY? yes, it's about time to remove this comment Line 1510: dom = sdCache.produce(sdUUID=sdUUID) Line 1511: Line 1512: vars.task.getExclusiveLock(STORAGE, imgUUID) Line 1513: vars.task.getSharedLock(STORAGE, sdUUID) -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Eduardo has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 2: (1 comment) File vdsm/storage/hsm.py Line 1505: Line 1506: force parameter is deprecated and not evaluated. Line 1507: Line 1508: # vars.task.setDefaultException(se.ChangeMeError(%s % args)) Line 1509: pool = self.getPool(spUUID) # Validates pool connection. WHY? Wrong. Being connected to the pool does not warrants that this is SPM. Line 1510: dom = sdCache.produce(sdUUID=sdUUID) Line 1511: Line 1512: vars.task.getExclusiveLock(STORAGE, imgUUID) Line 1513: vars.task.getSharedLock(STORAGE, sdUUID) -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: protect deleteImage with the spm lock
Dan Kenigsberg has posted comments on this change. Change subject: hsm: protect deleteImage with the spm lock .. Patch Set 2: (1 comment) File vdsm/storage/hsm.py Line 1505: Line 1506: force parameter is deprecated and not evaluated. Line 1507: Line 1508: # vars.task.setDefaultException(se.ChangeMeError(%s % args)) Line 1509: pool = self.getPool(spUUID) # Validates pool connection. WHY? right, but executing a non-@unsecure method of sp makes sure that on the time of function entry, we were SPM. We hope that the vdsm process, and its lvm ancestors are killed when spm status is lost and before another spm is chosen. Currently, deleteImage lacks this (imperfect) protection, and it is exposed to Engine bugs which may call it on a non-spm host. Line 1510: dom = sdCache.produce(sdUUID=sdUUID) Line 1511: Line 1512: vars.task.getExclusiveLock(STORAGE, imgUUID) Line 1513: vars.task.getSharedLock(STORAGE, sdUUID) -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
