Change in vdsm[master]: janitorial: move isVdsmImage into utils
Dan Kenigsberg has submitted this change and it was merged. Change subject: janitorial: move isVdsmImage into utils .. janitorial: move isVdsmImage into utils this patch moves vdsm/virt/vm.isVdsmImage into utils without code changes. In doing so, we bootstrap the vdsm/virt/utils module, which will contain the common shared code in the virt package, to shed some load from vm.py. This change is a preliminary step to the move of VmSamplingThread from vm.py to sampling.py. Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28477 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm.install M vdsm.spec.in M vdsm/clientIF.py M vdsm/virt/Makefile.am A vdsm/virt/utils.py M vdsm/virt/vm.py 6 files changed, 42 insertions(+), 14 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1532/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5517/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3675/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9616/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10401/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10558/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5482/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/999/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/28/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/8/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/9/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Antoni Segura Puimedon has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/10/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9623/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10408/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10565/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5489/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3647/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1005/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/29/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/9/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Dan Kenigsberg has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Francesco Romani has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 8: Verified+1 trivial patch which just moves code around. Verified with 'make rpm' on F20 and RHEL6.5 (ok) and running into a real VDSM (booted a VM, tested recovery). -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9595/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10379/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10536/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5461/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3619/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/991/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/25/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/5/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/6/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Francesco Romani has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28477/5//COMMIT_MSG Commit Message: Line 7: janitorial: move isVdsmImage into utils Line 8: Line 9: this patch moves vdsm/virt/vm.isVdsmImage into utils without code Line 10: changes. Line 11: The move has little oif any benefit on its own, but it is a preliminary oif-if Done Line 12: step to the move of VmSamplingThread from vm.py to sampling.py. Line 13: Line 14: Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Line 8: Line 9: this patch moves vdsm/virt/vm.isVdsmImage into utils without code Line 10: changes. Line 11: The move has little oif any benefit on its own, but it is a preliminary Line 12: step to the move of VmSamplingThread from vm.py to sampling.py. But why take the code out of the virt package, where it naturally belongs? I can begin a new utils-like module inside the virt package. Would that be ok? Line 13: Line 14: Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9560/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/781/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10345/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10502/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5427/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3585/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/970/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/22/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/2/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/3/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Dan Kenigsberg has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Antoni Segura Puimedon has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 6: Code-Review-1 Before doing a proper code review... vdsm/virt/virtutils.py doesn't make much sense as a name. from virt import utils better than from virt import virtutils -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Antoni Segura Puimedon has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 6: after reviewing, only the name is bad. -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Dan Kenigsberg has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 5: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28477/5//COMMIT_MSG Commit Message: Line 7: janitorial: move isVdsmImage into utils Line 8: Line 9: this patch moves vdsm/virt/vm.isVdsmImage into utils without code Line 10: changes. Line 11: The move has little oif any benefit on its own, but it is a preliminary oif-if Line 12: step to the move of VmSamplingThread from vm.py to sampling.py. Line 13: Line 14: Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Line 8: Line 9: this patch moves vdsm/virt/vm.isVdsmImage into utils without code Line 10: changes. Line 11: The move has little oif any benefit on its own, but it is a preliminary Line 12: step to the move of VmSamplingThread from vm.py to sampling.py. But why take the code out of the virt package, where it naturally belongs? Can we avoid that? Line 13: Line 14: Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Francesco Romani has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 5: Verified+1 rebased; no code changes. -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9486/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10269/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10425/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5351/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3509/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/937/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Francesco Romani has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 3: Verified+1 trivial patch which just moves code around. Verified (on isolation) by running the testsuite -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Francesco Romani has uploaded a new change for review.
Change subject: janitorial: move isVdsmImage into utils
..
janitorial: move isVdsmImage into utils
this patch moves vdsm/virt/vm.isVdsmImage into utils without code
changes.
The move has little oif any benefit on its own, but it is a preliminary
step to the move of VmSamplingThread from vm.py to sampling.py.
Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af
Signed-off-by: Francesco Romani from...@redhat.com
---
M lib/vdsm/utils.py
M vdsm/clientIF.py
M vdsm/virt/vm.py
3 files changed, 15 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/28477/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 4e60acf..95ce617 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -104,6 +104,18 @@
return stat.S_ISBLK(os.stat(path).st_mode)
+def isVdsmImage(drive):
+
+Tell if drive looks like a vdsm image
+
+:param drive: drive to check
+:type drive: dict or vm.Drive
+:return: bool
+
+required = ('domainID', 'imageID', 'poolID', 'volumeID')
+return all(k in drive for k in required)
+
+
def touchFile(filePath):
http://www.unix.com/man-page/POSIX/1posix/touch/
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index ea950b6..8811fa5 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -249,7 +249,7 @@
if type(drive) is dict:
device = drive['device']
# PDIV drive format
-if device == 'disk' and vm.isVdsmImage(drive):
+if device == 'disk' and utils.isVdsmImage(drive):
res = self.irs.prepareImage(
drive['domainID'], drive['poolID'],
drive['imageID'], drive['volumeID'])
@@ -336,7 +336,7 @@
def teardownVolumePath(self, drive):
res = {'status': doneCode}
try:
-if vm.isVdsmImage(drive):
+if utils.isVdsmImage(drive):
res = self.irs.teardownImage(drive['domainID'],
drive['poolID'], drive['imageID'])
except TypeError:
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7bb1f94..fabd0db 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -45,6 +45,7 @@
from vdsm.config import config
from vdsm.define import ERROR, NORMAL, doneCode, errCode
from vdsm.netinfo import DUMMY_BRIDGE
+from vdsm.utils import isVdsmImage
from storage import outOfProcess as oop
from storage import sd
from storage import fileUtils
@@ -87,18 +88,6 @@
CONSOLE_DEVICES = 'console'
SMARTCARD_DEVICES = 'smartcard'
TPM_DEVICES = 'tpm'
-
-
-def isVdsmImage(drive):
-
-Tell if drive looks like a vdsm image
-
-:param drive: drive to check
-:type drive: dict or vm.Drive
-:return: bool
-
-required = ('domainID', 'imageID', 'poolID', 'volumeID')
-return all(k in drive for k in required)
def _filterSnappableDiskDevices(diskDeviceXmlElements):
--
To view, visit http://gerrit.ovirt.org/28477
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9790/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8852/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9637/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/657/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1129/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
Francesco Romani has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 2: rebased -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move isVdsmImage into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move isVdsmImage into utils .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8892/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9676/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1143/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9831/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
