Change in vdsm[master]: kvm group can now r/w to all newly created files in /var/log...
Assaf Muller has posted comments on this change. Change subject: kvm group can now r/w to all newly created files in /var/log/vdsm .. Patch Set 2: -Verified My subconscious came up with the following solution during a night's sleep: Remove the upgrade logger/handler from the VDSM logger conf file. During the start of an upgrade, configure logging using basicConfig (And not from a file), then use chown to make sure that upgrade.log is owned by vdsm:kvm. This change will make it so that upgrade.log is only created in one place, and that no matter if vdsm-tool was run by root or VDSM itself, upgrade.log will end up owned by vdsm:kvm. I'll code it up Sunday. -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm group can now r/w to all newly created files in /var/log...
Assaf Muller has uploaded a new change for review. Change subject: kvm group can now r/w to all newly created files in /var/log/vdsm .. kvm group can now r/w to all newly created files in /var/log/vdsm Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Signed-off-by: Assaf Muller amul...@redhat.com --- M vdsm.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/22349/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 81d7e66..6e9d570 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -687,6 +687,8 @@ %endif %endif +setfacl -m d:g:kvm:rw- /var/log/vdsm + %preun if [ $1 -eq 0 ]; then start_conf_section=## beginning of configuration section by vdsm -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm group can now r/w to all newly created files in /var/log...
oVirt Jenkins CI Server has posted comments on this change. Change subject: kvm group can now r/w to all newly created files in /var/log/vdsm .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6062/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5275/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6165/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/132/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm group can now r/w to all newly created files in /var/log...
Assaf Muller has posted comments on this change. Change subject: kvm group can now r/w to all newly created files in /var/log/vdsm .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm group can now r/w to all newly created files in /var/log...
oVirt Jenkins CI Server has posted comments on this change. Change subject: kvm group can now r/w to all newly created files in /var/log/vdsm .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6063/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5276/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6166/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/133/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm group can now r/w to all newly created files in /var/log...
Assaf Muller has posted comments on this change. Change subject: kvm group can now r/w to all newly created files in /var/log/vdsm .. Patch Set 2: Verified-1 * Missing Debian post-install script mention * Need to test if logrotate kills file access lists -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm group can now r/w to all newly created files in /var/log...
Dan Kenigsberg has posted comments on this change. Change subject: kvm group can now r/w to all newly created files in /var/log/vdsm .. Patch Set 2: Code-Review-1 (1 comment) File vdsm.spec.in Line 686: exit 0 Line 687: %endif Line 688: %endif Line 689: Line 690: setfacl -m d:g:kvm:rw- /var/log/vdsm This allows any qemu process to write on our logs or delete them. why not have d:u:vdsm ? Please verify that it flies on ovirt-node, and repeat in debian and in `make install` (for tarball-based installation). Alternatively, split to upgrade.log and superupgrade.log. Line 691: Line 692: %preun Line 693: if [ $1 -eq 0 ]; then Line 694: start_conf_section=## beginning of configuration section by vdsm -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kvm group can now r/w to all newly created files in /var/log...
Assaf Muller has posted comments on this change. Change subject: kvm group can now r/w to all newly created files in /var/log/vdsm .. Patch Set 2: From very minimal research it seems that the acl package might not be installed by default on Debian based distributions, and that the acl option may need to be set in /etc/fstab for the appropriate file system (In Red Hat based distributions the acl option is on by default IIRC). This might make this solution invalid. More research is needed. -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
