Change in vdsm[master]: libvirtvm: unsetPortMirroring just before hotunplug

2012-08-28 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: libvirtvm: unsetPortMirroring just before hotunplug
..


Patch Set 3: I would prefer that you didn't submit this

Igor: must add symmetric setPortMirroring on hotplug!

--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: libvirtvm: unsetPortMirroring just before hotunplug

2012-08-23 Thread danken
Dan Kenigsberg has uploaded a new change for review.

Change subject: libvirtvm: unsetPortMirroring just before hotunplug
..

libvirtvm: unsetPortMirroring just before hotunplug

Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/libvirtvm.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/7425/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index acc9399..e3d8915 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1436,6 +1436,10 @@
 break
 
 if nic:
+if hasattr(nic, 'portMirroring'):
+for network in nic.portMirroring:
+supervdsm.getProxy().unsetPortMirroring(network, nic.name)
+
 nicXml = nic.getXML().toprettyxml(encoding='utf-8')
 self.log.debug(Hotunplug NIC xml: %s, nicXml)
 else:


--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: libvirtvm: unsetPortMirroring just before hotunplug

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: libvirtvm: unsetPortMirroring just before hotunplug
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/615/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: libvirtvm: unsetPortMirroring just before hotunplug

2012-08-23 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: libvirtvm: unsetPortMirroring just before hotunplug
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/629/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches