Change in vdsm[master]: misc.py py3 compliance via six

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: misc.py py3 compliance via six
..


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/63192/2//COMMIT_MSG
Commit Message:

PS2, Line 7: misc.py py3 compliance via six
please use this commit message format:
topic: short summary

longer description (if needed)


https://gerrit.ovirt.org/#/c/63192/2/lib/vdsm/storage/misc.py
File lib/vdsm/storage/misc.py:

PS2, Line 70: six.moves.imap
i think it's six.moves.map, please check again


PS2, Line 668: six.moves.queue
it will be more readable to import six.moves.queue and six.moves.map than call 
the full name of the module.


PS2, Line 698: xrange
xrange is removed in python 3, please replace it also


-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc.py py3 compliance via six

[automation]

gerrit-hooks has posted comments on this change.

Change subject: misc.py py3 compliance via six
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc.py py3 compliance via six

[automation]

gerrit-hooks has posted comments on this change.

Change subject: misc.py py3 compliance via six
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org