Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


net: Log a setup networks transaction failure when using ovs switch

When a failure occurs during the ovs setup process, an exception is
raised.
Log this failure in order to ease debugging.

Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/64242
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 4: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 3: -Code-Review Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net: Log a setup networks transaction failure when using ovs 
switch
..

net: Log a setup networks transaction failure when using ovs switch

When a failure occurs during the ovs setup process, an exception is
raised.
Log this failure in order to ease debugging.

Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/64242/1

diff --git a/lib/vdsm/network/netconfpersistence.py 
b/lib/vdsm/network/netconfpersistence.py
index 37b9e89..9763cc3 100644
--- a/lib/vdsm/network/netconfpersistence.py
+++ b/lib/vdsm/network/netconfpersistence.py
@@ -245,6 +245,10 @@
 else:
 config_diff = self.base_config.diffFrom(self.config)
 if config_diff:
+logging.warning(
+'Failed setup transaction,'
+'reverting to last known good network.',
+exc_info=(ex_type, ex_value, ex_traceback))
 raise ne.RollbackIncomplete(config_diff, ex_type, ex_value)
 
 


-- 
To view, visit https://gerrit.ovirt.org/64242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I157a93a1cb800d47587eec5fef5a7c3eb08df58d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org